Hi Miklos,

> i think the only popular vcs today that is unsupported by Pootle is hg.
> so i've made a patch to add support for it :)

that is great!


> patch attached, any feedback is appreciated.

The code itself looks fine to me.

I am not used to mercurial, so I just downloaded a mercurial repository as an
example:
 hg init test
 cd test
 hg pull http://selenic.com/repo/hg-stable
 hg update

Then I switched to the translate directory and tested the "getcleanfile"
function:
 python storage/versioncontrol/__init__.py SOME_DIR/test/mercurial/repo.py

The resulting error message was: 
 abort: mercurial/repo.py not under root

This problem seems to be fixed after replacing "self.location_rel" with
"self.location_abs" in "getcleanfile" in "hg.py".

So I guess, that mercurial needs the absolute file location (in contrast to git
and darcs). But I could not verify this for the "update" and the "commit"
function in "hg.py", since I don't have a real repository for testing.

Could you check, if everything works after replacing the two
occurrences of "location_rel" with "location_abs"?

I noticed another thing while going through the code: in "commit" the location
of the specific file is not used. I guess, this results in a commit of the
complete local working copy, or? This behaviour would be different from the
other interfaces (svn, cvs, ...) .Could you check that, too, please?

It feels great to see the number of supported systems growing!

regards,
Lars

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Translate-pootle mailing list
Translate-pootle@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/translate-pootle

Reply via email to