[tryton-dev] sao: Add option to show revisions and manage microseconds in JSON-RPC

[Code Review - New issues: ced]

issue3678

URL: http://codereview.tryton.org/3671003/

[tryton-dev] sao: Add Len to PYSON

[Code Review - New issues: ced]

issue3692

URL: http://codereview.tryton.org/3681002/

[tryton-dev] tryton: Add Len to PYSON

[Code Review - New issues: ced]

issue3692

URL: http://codereview.tryton.org/3671002/

[tryton-dev] trytond: Add Len to PYSON

[Code Review - New issues: ced]

issue3692

URL: http://codereview.tryton.org/3661002/

[tryton-dev] trytond: When saving record don' t store target link for one2many to create

[Code Review - New issues: ced]

When saving an instance if the relation field of a one2many item is set, it 
should not try to save it as it will be replaced by the current record. And in 
the worst case, the target set could not be valid and so it prevents to store 
the instance which doesn't need of this target.

issue3501

URL: http://codereview.tryton.org/3601003/

[tryton-dev] sao: Fix action button sensibility

[Code Review - New issues: ced]

Allow to run action if no record is selected.

issue3685

URL: http://codereview.tryton.org/3611004/

[tryton-dev] tryton: Fix action button sensibility

[Code Review - New issues: ced]

Allow to run action if no record is selected.

issue3685

URL: http://codereview.tryton.org/3611003/

[tryton-dev] calendar_scheduling: Convert Attendee into Mixin

[Code Review - New issues: ced]

Since the removal of _inherits, calendar.attendee doesn't exist, so 
Attendee must be converted into Mixin and used for calendar.event.attendee.

issue3662

URL: http://codereview.tryton.org/3601002/

[tryton-dev] account_statement: Use statement line date for currency convertion

[Code Review - New issues: ced]

issue3650

URL: http://codereview.tryton.org/3571002/

[tryton-dev] account_stock_continental: Use drop shipment in scenario

[Code Review - New issues: ced]

issue3677

URL: http://codereview.tryton.org/3561002/

[tryton-dev] trytond: Add history revisions and manage microseconds in JSON-RPC

[Code Review - New issues: ced]

issue3678

URL: http://codereview.tryton.org/3551002/

[tryton-dev] tryton: Add option to show revisions and manage microseconds in JSON-RPC

[Code Review - New issues: ced]

issue3678

URL: http://codereview.tryton.org/3501003/

[tryton-dev] dashboard: Add icon to main menu

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3541002/

[tryton-dev] calendar: Add icon to main menu

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3541003/

[tryton-dev] sao: Many2Many edit should use his own screen instance

[Code Review - New issues: ced]

issue3646

URL: http://codereview.tryton.org/3531002/

[tryton-dev] sale: Add warning for customer moves without origin

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3511004/

[tryton-dev] purchase: Add warning for supplier moves without origin

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3521003/

[tryton-dev] stock: Add warning for external move without origin

[Code Review - New issues: ced]

issue3677

URL: http://codereview.tryton.org/3521002/

[tryton-dev] trytond: Add some icons to global search

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3511002/

[tryton-dev] tryton: Use a pool of connection

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3471002/

[tryton-dev] tryton: Use explicit callback instead of implicit gtk main iteration in rpc calls

[Code Review - New issues: ced]

The implicit gtk main iteration leads to bad ordered processing of events. So 
as explicit is better than implicit, rpc calls that don't need to block 
until the result use a callback.

URL: http://codereview.tryton.org/3461002/

[tryton-dev] trytond: Better guess "selection_change_with" attribute

[Code Review - New issues: ced]

Testing on the instance for Selection field is not enough because some field 
selection could come from a Function field.
So it is better to use a dick typing style in this case.

issue3649

URL: http://codereview.tryton.org/3451002/

[tryton-dev] tryton: Missing removal of early attribute clearing in destroy

[Code Review - New issues: ced]

This one was missing in changeset 894fb914ef79

URL: http://codereview.tryton.org/3441002/

[tryton-dev] account_invoice: Use sign to preserve precision

[Code Review - New issues: ced]

Needs http://codereview.tryton.org/3411002/

issue3668

URL: http://codereview.tryton.org/3421002/

[tryton-dev] trytond: Add sign function to SQLite backend

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3411002/

[tryton-dev] Update to tip

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3431002/

[tryton-dev] trytond: Use a sequence of ids, values to set fields

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3331003/

[tryton-dev] tryton: Fix race condition when switching tabs fast

[Code Review - New issues: ced]

Since changeset 894fb914ef79, the set_cursor on form doesn't detect it was 
closed and so the cursor widget is no more there.

URL: http://codereview.tryton.org/3401002/

[tryton-dev] trytond: Fix error message "foreign_model_exist"

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3381002/

[tryton-dev] trytond: Improve module buttons

[Code Review - New issues: ced]

- Enforce origin state of modules
- Speedup on_write computation
- Better usage of record cache

URL: http://codereview.tryton.org/3361002/

[tryton-dev] account_invoice: Fix computation of second currency amount

[Code Review - New issues: ced]

contains patch from  http://codereview.tryton.org/3131002/

issue3664

URL: http://codereview.tryton.org/3351002/

[tryton-dev] account_fr: New tax rates for 2014

[Code Review - New issues: ced]

issue3596

URL: http://codereview.tryton.org/3341002/

[tryton-dev] sao: Fix domain inversion for xxx2many fields

[Code Review - New issues: ced]

issue3659

URL: http://codereview.tryton.org/3331002/

[tryton-dev] tryton: Fix domain inversion for xxx2many fields

[Code Review - New issues: ced]

issue3659

URL: http://codereview.tryton.org/3311002/

[tryton-dev] stock: Allow to use many locations and sum cost value for products by locations

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3291003/

[tryton-dev] tryton: Allow to close wizard if end state transition exists

[Code Review - New issues: ced]

issue3652

URL: http://codereview.tryton.org/3291002/

[tryton-dev] tryton: Fix dynamic size for translate widget

[Code Review - New issues: ced]

Dynamic size was added in changeset 8ee7e142c8fd but the translate widget was 
not updated.

URL: http://codereview.tryton.org/3271004/

[tryton-dev] tryton: Fix selection of column in next/previous

[Code Review - New issues: ced]

When _sign is negative, it doesn't select the first column but the second. 
So despite of selection the wrong column, it could crash if there is only one 
column in the view.

URL: http://codereview.tryton.org/3241004/

[tryton-dev] tryton: Many2Many edit should use his own screen instance

[Code Review - New issues: ced]

issue3646

URL: http://codereview.tryton.org/3191003/

[tryton-dev] tryton: Don't set missing default value to False

[Code Review - New issues: ced]

False is not always a good valid value for the field, so it is better to let 
the field dealing with default value.

issue3643

URL: http://codereview.tryton.org/3281002/

[tryton-dev] tryton: Search for sequence on all view of one2many

[Code Review - New issues: ced]

issue3642

URL: http://codereview.tryton.org/3201004/

[tryton-dev] tryton: Don't evaluate anymore relate action with the record

[Code Review - New issues: ced]

This enforce the usage of only active_mode, active_id and active_ids for relate 
domain otherwise the behavior is not depend of the fields present on the view 
and already loaded.

issue2474

URL: http://codereview.tryton.org/3271002/

[tryton-dev] trytond: Use active_ids in form_relate

[Code Review - New issues: ced]

Only active_mode, active_id and active_ids can be used on relate domain because 
it is the only values which could be sur to be present.
Also it always try to use active_ids over active_id to give more possibilities 
to the user.

issue2474

URL: http://codereview.tryton.org/3261002/

[tryton-dev] trytond: No good reason to make get_translation_join private

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3241003/

[tryton-dev] tryton: Remove process call on wizard sensitive state change

[Code Review - New issues: ced]

This hack was added by changeset cd8bf16ecab4 to manage wizard launching other 
wizards but changeset 8bcd8092c2d9 makes this hack useless.

issue3638

URL: http://codereview.tryton.org/3201003/

[tryton-dev] trytond: Search also on source for some translation types when overriding

[Code Review - New issues: ced]

issue3637

URL: http://codereview.tryton.org/3221004/

[tryton-dev] tryton: Remove early attribute clearing in destroy

[Code Review - New issues: ced]

Removing those attributes could lead to errors where in the code we expect to 
have those attributes.
It is better to leave them and let the garbage collector detect them.

URL: http://codereview.tryton.org/3251002/

[tryton-dev] tryton: Manage client actions from buttons

[Code Review - New issues: ced]

issue3343

URL: http://codereview.tryton.org/3241002/

[tryton-dev] sao: Manage client actions from buttons

[Code Review - New issues: ced]

issue3343

URL: http://codereview.tryton.org/3221003/

[tryton-dev] trytond: Add documentation about client actions for button

[Code Review - New issues: ced]

issue3343

URL: http://codereview.tryton.org/3231002/

[tryton-dev] tryton: Use same modified value as on_change for pre_validate

[Code Review - New issues: ced]

The value sent for pre_validation will be used to instanciate a record in the 
same way as on_change. It is also better to get the id also for pre_validate.

URL: http://codereview.tryton.org/3211002/

[tryton-dev] trytond: Add missing button in tree view documentation

[Code Review - New issues: ced]

trytond: Add missing button in tree view documentation

URL: http://codereview.tryton.org/3201002/

[tryton-dev] trytond: Add link between stock moves and invoice lines

[Code Review - New issues: ced]

issue3614

URL: http://codereview.tryton.org/3181002/

[tryton-dev] bugs.tryton.org: Allow to search on nosy list members

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3111003/

[tryton-dev] tryton: Send record-saved signal after display

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3131003/

[tryton-dev] account_invoice: Fix account move cache computation when second currency

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3131002/

[tryton-dev] tryton: Fix find button in search window

[Code Review - New issues: ced]

It should use the text filled in the search entry.
And it should not close the window if nothing is found.

URL: http://codereview.tryton.org/3101003/

[tryton-dev] account_asset: Add confirmation on close button

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3101002/

[tryton-dev] tryton: Add buttons of the view in actions menu

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3011005/

[tryton-dev] trytond: Add tree_invisible attribute to button in tree view

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3041003/

[tryton-dev] trytond: Fix documentation about button name

[Code Review - New issues: ced]

trytond: Fix documentation about button name

URL: http://codereview.tryton.org/3011004/

[tryton-dev] trytond: Prevent unecessary update of record when loading XML

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3061003/

[tryton-dev] stock_supply_production: Prevent unecessary update of record when loading XML

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3091002/

[tryton-dev] stock_supply: Prevent unecessary update of record when loading XML

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3021003/

[tryton-dev] product: Prevent unecessary update of record when loading XML

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3081002/

[tryton-dev] account_de_skr03: Prevent unecessary update of record when loading XML

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3071002/

[tryton-dev] bank: Use pre_validate for IBAN validation

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3051002/

[tryton-dev] trytond: Add depends attribute to data tag

[Code Review - New issues: ced]

This is the counterpart of the Pool register of extras_depend modules for the 
XML record creation. It allow to create records if some other modules are 
installed.

URL: http://codereview.tryton.org/3041002/

[tryton-dev] sale_supply: Fix computation of done state

[Code Review - New issues: ced]

issue3550

URL: http://codereview.tryton.org/3011002/

[tryton-dev] account: Improve Trial Balance by using set instead of list

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/3001002/

[tryton-dev] tryton: Encode gettext value to match with string value

[Code Review - New issues: ced]

issue3587

URL: http://codereview.tryton.org/2991002/

[tryton-dev] tryton: Add context to import window

[Code Review - New issues: ced]

Users could expect that importing from a specific window will inherit of his 
behavior like the default value of fields. So the context of this window should 
be passed to the import_data call.

URL: http://codereview.tryton.org/2971002/

[tryton-dev] trytond: Add memoize to import data search functions

[Code Review - New issues: ced]

As during the processing of imported data, there is no creation of new records, 
the result of the search calls could be cached.

URL: http://codereview.tryton.org/2981002/

[tryton-dev] project: Make hours always visible

[Code Review - New issues: ced]

project: Make hours always visible

URL: http://codereview.tryton.org/2931004/

[tryton-dev] project_revenue: Use work effort instead of total to compute revenue

[Code Review - New issues: ced]

total_effort contains the effort of the children but sum_tree needs only the 
value of the work without the children.

URL: http://codereview.tryton.org/2931003/

[tryton-dev] project: Make hours always visible

[Code Review - New issues: ced]

hours is also useful for work without timesheet as it could have children with 
timesheet.

URL: http://codereview.tryton.org/2951002/

[tryton-dev] timesheet: Make hours always visible

[Code Review - New issues: ced]

hours is also useful for work without timesheet as it could have children with 
timesheet.

URL: http://codereview.tryton.org/2941002/

[tryton-dev] project: Fix compute of initial leafs in sum_tree

[Code Review - New issues: ced]

Initial leafs are works that are not parent.

URL: http://codereview.tryton.org/2931002/

[tryton-dev] trytond: Resync widget attributes and add missing filename attribute in views

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2911002/

[tryton-dev] tryton: Allow to use other field with the binary widget

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2921002/

[tryton-dev] tryton: Use sys.prefix instead of guessing

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2881002/

[tryton-dev] tryton: Improve Binary edition

[Code Review - New issues: ced]

This makes the Binary widgets remeber the path of the last file edited, so it 
can be selected by default by the open button.

issue3606

URL: http://codereview.tryton.org/2861002/

[tryton-dev] trytond: Add Content Name to ActionReport

[Code Review - New issues: ced]

This will ease the edition of the report template from the client.

issue3608

URL: http://codereview.tryton.org/2851002/

[tryton-dev] tryton: Paste on editable list create new records if needed

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2841002/

[tryton-dev] tryton: Add missing states management for Binary in TreeView

[Code Review - New issues: ced]

issue3570

URL: http://codereview.tryton.org/2811002/

[tryton-dev] trytond: Fix MySQL tests

[Code Review - New issues: ced]

- Force UTC timezone on MySQL connection
- Add 1s sleep to test check timestamp

URL: http://codereview.tryton.org/2801002/

[tryton-dev] www.tryton.org: Add monthly donation via PayPal

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2791002/

[tryton-dev] trytond: Add with_on_change switch to default_get

[Code Review - New issues: ced]

default_get should not call on_change when called in create because it could 
modify values set by the caller.

issue3602

URL: http://codereview.tryton.org/2781002/

[tryton-dev] trytond: Add history to tax

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2771002/

[tryton-dev] tryton-tools: Add neso and tryton-tools to reviewbot

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2711003/

[tryton-dev] proteus: Drop support of Python 2.6

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2701002/

[tryton-dev] tryton: Drop support of Python 2.6

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2681004/

[tryton-dev] neso: Drop support of Python 2.6

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2711002/

[tryton-dev] trytond: Drop support of Python 2.6

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2691002/

[tryton-dev] tryton: Remove old workaround for PyGTK < 2.22

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2681003/

[tryton-dev] trytond: Anonymise tests

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2681002/

[tryton-dev] bank: Add IBAN format and validation

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2661002/

[tryton-dev] account_statement: Test if id >= 0 before getting rec_name

[Code Review - New issues: ced]

The instance of many2one received in on_change call could be negative in case 
it is a parent record not yet saved.

URL: http://codereview.tryton.org/2611002/

[tryton-dev] proteus: Force value of parent Many2One, Reference fields

[Code Review - New issues: ced]

(No description)

URL: http://codereview.tryton.org/2601002/

[tryton-dev] tryton: Fix reload of screen at the end of wizard

[Code Review - New issues: ced]

A wizard could be launch by a button defined on a children record. In this 
case, the ids to reload is not the ids from the wizard as they are from the 
children model but just the current record.

issue3519

URL: http://codereview.tryton.org/2571002/