Re: [tryton-dev] contributions: approval rules
* Pierre-Louis Bonicoli: " Re: [tryton-dev] contributions: approval rules" (Tue, 16 Dec 2014 16:41:13 +0100): > Does the following seem ok to you (s/rules/contributions/ and 'rules' > subtitle added) ? > > - Contributions > - requirements > - must > - nice to have, but not required > - rules Perfect for me. -- Mathias Behrle MBSolutions Gilgenmatten 10 A D-79114 Freiburg Tel: +49(761)471023 Fax: +49(761)4770816 http://m9s.biz UStIdNr: DE 142009020 PGP/GnuPG key availabable from any keyserver, ID: 0x8405BBF6 pgph1ThP0fLEw.pgp Description: Digitale Signatur von OpenPGP
Re: [tryton-dev] contributions: approval rules
Does the following seem ok to you (s/rules/contributions/ and 'rules' subtitle added) ? - Contributions - requirements - must - nice to have, but not required - rules -- Pierre-Louis
Re: [tryton-dev] contributions: approval rules
* Udo Spallek: " Re: [tryton-dev] contributions: approval rules" (Tue, 16 Dec 2014 13:06:20 +0100): > As an old discussion I participated is *swimming up*, I would like to > explain my opinion today. > After the SCO-Linux controversies[3] I changed my opinion[4] > in many of the proposals. I am not really up-to-date with this subject, but AFAIS SCO was defeated on its law suits? [A] And SCO attacked on the validty of the GPL itself, where we can't do a lot? > > - The contributor name must be the real name of the natural person > > who submit the code > > - The contributor email must be a valid email address > > - The username of mercurial patch must be in the form: > > Name > > Today, I would strongly vote *yes* for the above proposals. > Because it makes the project stronger in case of copyright questions. > In my country the copyright of a creation is fixed to the natural > persons who act as a creators. > IANAL, but AFAIK in Germany the copyright is not transferable to anyone > else (§ 29 Abs. 1 UrhG). > In other countries like USA it is different, the copyright is > transferable even to legal person. > > I think it is good when the Tryton project is able to identify a > natural or legal person as author. > Additionally I find we need a sign-off process for contributors to the > developer-certificate-of-origin[5], as many other projects do[6]. For me the situation is still the same as of our first discussions on this subject. - We shouldn't try to require arrangements, that we cannot enforce. or the other way round - If we require something, then we must enforce it correctly. AFAIS in [B] it is said: "... then you just add a line saying Signed-off-by: ..." There is nowhere said, that this commit has to be gpg signed. Perhaps this document is not complete (and I currently don't have the time to investigate), but this way you could just use any name. That's just snakeoil;) [C] The only somewhat reliable process would be to require to sign commits etc. with a key signed by at least (put in a number here) project members. I doubt that this can be, what we want to simplify contribution. So just today I even would be inclined to not vote for any of the requirements in [D]. > [3]http://en.wikipedia.org/wiki/SCO%E2%80%93Linux_controversies > [4]http://thread.gmane.org/gmane.comp.python.tryton/1591/ > [5]http://www.do-not-panic.com/2014/02/developer-certificate-of-origin.html > [6]https://www.gnu.org/licenses/why-assign.en.html > https://www.kernel.org/doc/Documentation/SubmittingPatches [A] http://www.zdnet.com/article/novell-defeats-sco-in-unix-copyright-case-3039288508/ [B] https://www.kernel.org/doc/Documentation/SubmittingPatches [C] http://www.merriam-webster.com/dictionary/snakeoil [D] http://thread.gmane.org/gmane.comp.python.tryton/1591/ -- Mathias Behrle MBSolutions Gilgenmatten 10 A D-79114 Freiburg Tel: +49(761)471023 Fax: +49(761)4770816 http://m9s.biz UStIdNr: DE 142009020 PGP/GnuPG key availabable from any keyserver, ID: 0x8405BBF6 pgpGGFFRIviWn.pgp Description: Digitale Signatur von OpenPGP
Re: [tryton-dev] contributions: approval rules
* Pierre-Louis Bonicoli: " Re: [tryton-dev] contributions: approval rules" (Tue, 16 Dec 2014 12:54:02 +0100): Hi Pierre-Louis, > Thanks for your modifications :) > > In order to improve clarity, could I: > - join the "Must" section with the paragraph starting with "If the > contributor has a significant amount of code" (this time I will keep the > link to the thread about the vote :) IIUC then it is not the same. Those rules apply to each contribution, whether you add yourself to COPYRIGHT or not. > - move the "Nice to have, but not required" at the end of the "Rules" > section ? Basically the same as above. Since those rules are preconditions for any contribution I would expose them very clearly at the beginning of the chapter (as is the case). my 2¢ -- Mathias Behrle MBSolutions Gilgenmatten 10 A D-79114 Freiburg Tel: +49(761)471023 Fax: +49(761)4770816 http://m9s.biz UStIdNr: DE 142009020 PGP/GnuPG key availabable from any keyserver, ID: 0x8405BBF6 pgptnKvph9wwi.pgp Description: Digitale Signatur von OpenPGP
Re: [tryton-dev] contributions: approval rules
Hi, thank you Pierre-Louise for starting this constructive collection and discussion and for taking the initiative. Tue, 16 Dec 2014 10:51:44 +0100 Mathias Behrle : >* Pierre-Louis Bonicoli: " Re: [tryton-dev] contributions: approval > rules" (Tue, 16 Dec 2014 04:38:03 +0100): >> On 20/08/2014 12:50, Pierre-Louis Bonicoli wrote: >> [...] >> - what is the "Vote results performed on 2010-07-05" ? >See [1][2]. >[1] thread.gmane.org/gmane.comp.python.tryton/1591/ >[2] http://article.gmane.org/gmane.comp.python.tryton/1641 As an old discussion I participated is *swimming up*, I would like to explain my opinion today. After the SCO-Linux controversies[3] I changed my opinion[4] in many of the proposals. > - The contributor name must be the real name of the natural person > who submit the code > - The contributor email must be a valid email address > - The username of mercurial patch must be in the form: > Name Today, I would strongly vote *yes* for the above proposals. Because it makes the project stronger in case of copyright questions. In my country the copyright of a creation is fixed to the natural persons who act as a creators. IANAL, but AFAIK in Germany the copyright is not transferable to anyone else (§ 29 Abs. 1 UrhG). In other countries like USA it is different, the copyright is transferable even to legal person. I think it is good when the Tryton project is able to identify a natural or legal person as author. Additionally I find we need a sign-off process for contributors to the developer-certificate-of-origin[5], as many other projects do[6]. [3]http://en.wikipedia.org/wiki/SCO%E2%80%93Linux_controversies [4]http://thread.gmane.org/gmane.comp.python.tryton/1591/ [5]http://www.do-not-panic.com/2014/02/developer-certificate-of-origin.html [6]https://www.gnu.org/licenses/why-assign.en.html https://www.kernel.org/doc/Documentation/SubmittingPatches Regards Udo Spallek -- _ virtual things Preisler & Spallek GbR München - Aachen Windeckstr. 77 81375 München Tel: +49 (89) 710 481 55 Fax: +49 (89) 710 481 56 i...@virtual-things.biz http://www.virtual-things.biz pgplwh2Un4Gwr.pgp Description: Digitale Signatur von OpenPGP
Re: [tryton-dev] contributions: approval rules
Hi, Thanks for your modifications :) In order to improve clarity, could I: - join the "Must" section with the paragraph starting with "If the contributor has a significant amount of code" (this time I will keep the link to the thread about the vote :) - move the "Nice to have, but not required" at the end of the "Rules" section ? -- Pierre-Louis
Re: [tryton-dev] contributions: approval rules
* Pierre-Louis Bonicoli: " Re: [tryton-dev] contributions: approval rules" (Tue, 16 Dec 2014 04:38:03 +0100): > On 20/08/2014 12:50, Pierre-Louis Bonicoli wrote: > [...] > > The rules - as explained by Cédric [1], are: > > > > Any core developer is allowed to push, core developers take > > responsibility. The core developers are: Cédric, nicoe, pokoli and albert. > > > > People allowed to push without being core developers are allowed to push > > small fixes without LGTM. Bigger fixes need approval (LGTM) of a core > > developer. > > > > For bigger fixes, in case of disagreement a consensus should be reached, > > at last the project leader takes a decision. > [...] > > [1] French: > > http://www.tryton.org/~irclog/fr/2014-08-20.log.html#t2014-08-20%2011:35 > > Hi, > > There have been many modifications since August :) There are fewer steps > (some have been automated), a better documentation (quick start added) > and fewer rules (no differences between core dev and committers). > > About the HowToContribute wiki page: > - why is there a link to http://codereview.tryton.org/6451002/ ? It > seems unrelated. Indeed the link was wrong. I just corrected it. > - what is the "Vote results performed on 2010-07-05" ? See [1][2]. Thanks for taking care, Mathias [1] thread.gmane.org/gmane.comp.python.tryton/1591/ [2] http://article.gmane.org/gmane.comp.python.tryton/1641 -- Mathias Behrle MBSolutions Gilgenmatten 10 A D-79114 Freiburg Tel: +49(761)471023 Fax: +49(761)4770816 http://m9s.biz UStIdNr: DE 142009020 PGP/GnuPG key availabable from any keyserver, ID: 0x8405BBF6 pgpq9gIKxZYaL.pgp Description: Digitale Signatur von OpenPGP
Re: [tryton-dev] contributions: approval rules
On 20/08/2014 12:50, Pierre-Louis Bonicoli wrote: [...] > The rules - as explained by Cédric [1], are: > > Any core developer is allowed to push, core developers take > responsibility. The core developers are: Cédric, nicoe, pokoli and albert. > > People allowed to push without being core developers are allowed to push > small fixes without LGTM. Bigger fixes need approval (LGTM) of a core > developer. > > For bigger fixes, in case of disagreement a consensus should be reached, > at last the project leader takes a decision. [...] > [1] French: > http://www.tryton.org/~irclog/fr/2014-08-20.log.html#t2014-08-20%2011:35 Hi, There have been many modifications since August :) There are fewer steps (some have been automated), a better documentation (quick start added) and fewer rules (no differences between core dev and committers). About the HowToContribute wiki page: - why is there a link to http://codereview.tryton.org/6451002/ ? It seems unrelated. - what is the "Vote results performed on 2010-07-05" ? -- Pierre-Louis
[tryton-dev] contributions: approval rules
Hi ! While discussing with Cédric [1], I discovered that the workflow which describes how contributions are accepted was not completely documented. This is important to describe this workflow: new contributor need it [2], so documenting it allows us to focus on the code. I believed - it was my understanding of [3] and [4] - that any patch to framework sub-project (the Tryton server and client) must be approved by a "LGTM" of Cédric. It occurs that it was a misunderstanding [2] :) The rules - as explained by Cédric [1], are: Any core developer is allowed to push, core developers take responsibility. The core developers are: Cédric, nicoe, pokoli and albert. People allowed to push without being core developers are allowed to push small fixes without LGTM. Bigger fixes need approval (LGTM) of a core developer. For bigger fixes, in case of disagreement a consensus should be reached, at last the project leader takes a decision. If nobody disagrees, I will update [4] in one week (if you miss this dead line, discussion could take place later :) [1] French: http://www.tryton.org/~irclog/fr/2014-08-20.log.html#t2014-08-20%2011:35 [2] http://www.tryton.org/~irclog/2014-01-31.log.html#t2014-01-31%2012:47 [3] https://code.google.com/p/tryton/wiki/ProjectOrganization/ [4] https://code.google.com/p/tryton/wiki/HowtoContribute -- Pierre-Louis
