[jira] Commented: (TUSCANY-1811) ClassCastException saving codegen-based DataGraph with ChangeSummary containing an xsd:float

2007-09-26 Thread Frank Budinsky (JIRA) 

[ 
https://issues.apache.org/jira/browse/TUSCANY-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530554
 ] 

Frank Budinsky commented on TUSCANY-1811:
-

Is the general problem that we need a notify() method in DataObjectBase for 
every Java primitive type - boolean, byte, char, double, float, int, long, 
short? Jjust like ENotificationImpl has a constructor for each of them?

 ClassCastException saving codegen-based DataGraph with ChangeSummary 
 containing an xsd:float
 

 Key: TUSCANY-1811
 URL: https://issues.apache.org/jira/browse/TUSCANY-1811
 Project: Tuscany
  Issue Type: Bug
  Components: Java SDO Implementation
Affects Versions: Java-SDO-1.0
Reporter: Ron Gavlin

 This problem is similar to TUSCANY-1393 except the schema type in this case 
 is an xsd:float instead of an xsd:int. The fix involves adding the following 
 lines to DataObjectBase.java. If you would like me to submit a patch with a 
 revised testcase, let me know.
 LINES TO BE ADDED to DataObjectBase.java:
   protected void notify(int changeKind, int property, float oldFloatValue, 
 float newFloatValue)
   {
 eNotify(new ENotificationImpl(this, Notification.SET, property, 
 oldFloatValue, newFloatValue));
   }
   
   protected void notify(int changeKind, int property, float oldFloatValue, 
 float newFloatValue, boolean isSetChange)
   {
 eNotify(new ENotificationImpl(this, Notification.SET, property, 
 oldFloatValue, newFloatValue, isSetChange));
   }
 END OF LINES TO BE ADDED
 - Ron
 P.S., below I have included the stacktrace for the problem.
 java.lang.ClassCastException: java.lang.Double
   at 
 org.apache.tuscany.sdo.model.impl.ModelFactoryImpl.convertFloatToString(ModelFactoryImpl.java:2036)
   at 
 org.apache.tuscany.sdo.model.impl.ModelFactoryImpl.convertToString(ModelFactoryImpl.java:318)
   at 
 org.apache.tuscany.sdo.impl.FactoryBase$SDOEFactoryImpl.convertToString(FactoryBase.java:291)
   at 
 org.eclipse.emf.ecore.util.EcoreUtil.convertToString(EcoreUtil.java:2994)
   at 
 org.eclipse.emf.ecore.change.impl.FeatureChangeImpl.getDataValue(FeatureChangeImpl.java:228)
   at 
 org.eclipse.emf.ecore.change.impl.FeatureChangeImpl.eIsSet(FeatureChangeImpl.java:771)
   at 
 org.eclipse.emf.ecore.impl.BasicEObjectImpl.eIsSet(BasicEObjectImpl.java:818)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveFeatures(XMLSaveImpl.java:1107)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElementID(XMLSaveImpl.java:2462)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElement(XMLSaveImpl.java:1036)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElement(XMLSaveImpl.java:922)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveContainedMany(XMLSaveImpl.java:2182)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveFeatures(XMLSaveImpl.java:1390)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElementID(XMLSaveImpl.java:2462)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElement(XMLSaveImpl.java:1036)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElement(XMLSaveImpl.java:922)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveContainedMany(XMLSaveImpl.java:2182)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveFeatures(XMLSaveImpl.java:1390)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElementID(XMLSaveImpl.java:2462)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.writeTopObject(XMLSaveImpl.java:620)
   at 
 org.apache.tuscany.sdo.util.DataGraphResourceFactoryImpl$DataGraphResourceImpl$SaveImpl.traverse(DataGraphResourceFactoryImpl.java:382)
   at org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.save(XMLSaveImpl.java:233)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.doSave(XMLResourceImpl.java:203)
   at 
 org.eclipse.emf.ecore.resource.impl.ResourceImpl.save(ResourceImpl.java:993)
   at 
 org.apache.tuscany.sdo.helper.SDOHelperImpl.saveDataGraph(SDOHelperImpl.java:182)
   at org.apache.tuscany.sdo.api.SDOUtil.saveDataGraph(SDOUtil.java:158)
   at 
 org.apache.tuscany.sdo.test.ChangeSummaryGenTestCase.testChangeSummaryOnDataGraphWithIntAndFloat(ChangeSummaryGenTestCase.java:128)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
   at java.lang.reflect.Method.invoke(Method.java:585)
   at junit.framework.TestCase.runTest(TestCase.java:154)
   at junit.framework.TestCase.runBare(TestCase.java:127)
   at junit.framework.TestResult$1.protect(TestResult.java:106)
   at

[jira] Commented: (TUSCANY-1811) ClassCastException saving codegen-based DataGraph with ChangeSummary containing an xsd:float

2007-09-26 Thread Ron Gavlin (JIRA) 

[ 
https://issues.apache.org/jira/browse/TUSCANY-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530559
 ] 

Ron Gavlin commented on TUSCANY-1811:
-

Precisely! 

It would probably be a good idea to generalize 
ChangeSummaryGenTestCase.testChangeSummaryOnDataGraphWithInt to include all 
primitives.

- Ron

 ClassCastException saving codegen-based DataGraph with ChangeSummary 
 containing an xsd:float
 

 Key: TUSCANY-1811
 URL: https://issues.apache.org/jira/browse/TUSCANY-1811
 Project: Tuscany
  Issue Type: Bug
  Components: Java SDO Implementation
Affects Versions: Java-SDO-1.0
Reporter: Ron Gavlin

 This problem is similar to TUSCANY-1393 except the schema type in this case 
 is an xsd:float instead of an xsd:int. The fix involves adding the following 
 lines to DataObjectBase.java. If you would like me to submit a patch with a 
 revised testcase, let me know.
 LINES TO BE ADDED to DataObjectBase.java:
   protected void notify(int changeKind, int property, float oldFloatValue, 
 float newFloatValue)
   {
 eNotify(new ENotificationImpl(this, Notification.SET, property, 
 oldFloatValue, newFloatValue));
   }
   
   protected void notify(int changeKind, int property, float oldFloatValue, 
 float newFloatValue, boolean isSetChange)
   {
 eNotify(new ENotificationImpl(this, Notification.SET, property, 
 oldFloatValue, newFloatValue, isSetChange));
   }
 END OF LINES TO BE ADDED
 - Ron
 P.S., below I have included the stacktrace for the problem.
 java.lang.ClassCastException: java.lang.Double
   at 
 org.apache.tuscany.sdo.model.impl.ModelFactoryImpl.convertFloatToString(ModelFactoryImpl.java:2036)
   at 
 org.apache.tuscany.sdo.model.impl.ModelFactoryImpl.convertToString(ModelFactoryImpl.java:318)
   at 
 org.apache.tuscany.sdo.impl.FactoryBase$SDOEFactoryImpl.convertToString(FactoryBase.java:291)
   at 
 org.eclipse.emf.ecore.util.EcoreUtil.convertToString(EcoreUtil.java:2994)
   at 
 org.eclipse.emf.ecore.change.impl.FeatureChangeImpl.getDataValue(FeatureChangeImpl.java:228)
   at 
 org.eclipse.emf.ecore.change.impl.FeatureChangeImpl.eIsSet(FeatureChangeImpl.java:771)
   at 
 org.eclipse.emf.ecore.impl.BasicEObjectImpl.eIsSet(BasicEObjectImpl.java:818)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveFeatures(XMLSaveImpl.java:1107)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElementID(XMLSaveImpl.java:2462)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElement(XMLSaveImpl.java:1036)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElement(XMLSaveImpl.java:922)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveContainedMany(XMLSaveImpl.java:2182)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveFeatures(XMLSaveImpl.java:1390)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElementID(XMLSaveImpl.java:2462)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElement(XMLSaveImpl.java:1036)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElement(XMLSaveImpl.java:922)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveContainedMany(XMLSaveImpl.java:2182)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveFeatures(XMLSaveImpl.java:1390)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.saveElementID(XMLSaveImpl.java:2462)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.writeTopObject(XMLSaveImpl.java:620)
   at 
 org.apache.tuscany.sdo.util.DataGraphResourceFactoryImpl$DataGraphResourceImpl$SaveImpl.traverse(DataGraphResourceFactoryImpl.java:382)
   at org.eclipse.emf.ecore.xmi.impl.XMLSaveImpl.save(XMLSaveImpl.java:233)
   at 
 org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.doSave(XMLResourceImpl.java:203)
   at 
 org.eclipse.emf.ecore.resource.impl.ResourceImpl.save(ResourceImpl.java:993)
   at 
 org.apache.tuscany.sdo.helper.SDOHelperImpl.saveDataGraph(SDOHelperImpl.java:182)
   at org.apache.tuscany.sdo.api.SDOUtil.saveDataGraph(SDOUtil.java:158)
   at 
 org.apache.tuscany.sdo.test.ChangeSummaryGenTestCase.testChangeSummaryOnDataGraphWithIntAndFloat(ChangeSummaryGenTestCase.java:128)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
   at java.lang.reflect.Method.invoke(Method.java:585)
   at junit.framework.TestCase.runTest(TestCase.java:154)
   at junit.framework.TestCase.runBare(TestCase.java:127)
   at junit.framework.TestResult$1.protect(TestResult.java:106)
   at junit.framework.TestResult.runProtected(TestResult.java:124)
   at