Re: [Twisted-Python] Moving Twisted off Trac and SVN to somewhere nicer
On 07/06/2011 07:19 AM, Kevin Horn wrote: On Tue, Jul 5, 2011 at 5:31 AM, Laurens Van Houtven _...@lvh.cc wrote: On Tue, Jul 5, 2011 at 12:22 PM, David da...@silveregg.co.jp mailto:da...@silveregg.co.jp wrote: Most people who stay on windows do not find cygwin or even CLI tools an acceptable solution. So, the argument isn't that git is worse on Windows than it is on *nix: it's just that Windows users don't want to use CLI tools? cheers, David cheers lvh Not in my opinion. I find hg, bzr, and svn all easier to use on Windows than git, and I use them all from the command line. But I think you will think the same on unix, that is you will prefer hg/bzr to git on unix as well. I don't think someones will prefer hg over git on windows and prefer git over hg on unix, frankly. As for which is simpler, I think those differences are much more superficial than people want to think, and some concepts introduced in hg/bzr for simplicity sake actually harmful in the long term (e.g. natural revision number, especially as used in bzr). Git UI is not super consistent, but neither is hg as soon as you use e.g. named branches and bookmarks. cheers, David ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Moving Twisted off Trac and SVN to somewhere nicer
On Tue, Jul 05, 2011 at 10:15:09PM -0400, Jasper St. Pierre wrote: On Tue, Jul 5, 2011 at 5:02 AM, Alessandro Dentella san...@e-den.it wrote: On Tue, Jul 05, 2011 at 03:42:04AM -0400, Jasper St. Pierre wrote: re: Mercurial, I didn't like it when I used it. If someone can tell me how to do this[3] in hg, I'd be more inclined to play along. And that I do this sort of things using mercurial queues. I pile up patches in a queue and can subsequently navigate in the queue (hg qgoto fix_header1) and fold it with a later one (hg qfold fix_header2). Hm. So it's like quilt? I think so Are patch queues real commits (changesets, revisions, whatever), so I can log and blame and grep them while I'm working? yes for all 3 (log, blame, grep) While the queue is not yet committed I can change the commit log of a patch in a simple way. if the patch is called my_patch1: $ hg goto my_patch1 $ hg qrefresh -e (open editor to change edit log) hg qrefresh alone would just incorporate all modification to working directory in the patch, before committing you can anyhow keep all patches in a separate repository (hg qinit will initialize it for you. I personally don't use it though). If you use such a second repository I guess you can simply share that with other people too, but I'm not using this workflow. hg qnew -f fix1 -m this fixed issue 1 hg qnew -I debian/control -m fix control hg qnew -f fix1.1 -m forgot something in issue 1 hg qgoto fix1 hg qfold fix1.1 # This concatenate the 2 comments hg qrefresh -e # fix your comment as you like it hg qpush hg qfinish -a # commit all queues currently applied Neato. This requires me to be in a queue *before* I fix my patch, right? that's simpler. Otherwise you create a second patch and subsequently fold them toghether. Using a third part application called qct (that works also on git and some other I believe) you can also cherry pick single diffs in a single patch to be incorporated in a changeset. I use this a lot to keep the changeset as clean as possible. [disclaimer] I'm not an expert of git, so my comparison should not be taken seriously. It's true that all the time I use git I find it more convoluted than mercurial, and I always thought it was an historical heritage. sandro *:-) -- Sandro Dentella *:-) http://www.reteisi.org Soluzioni libere per le scuole http://sqlkit.argolinux.orgSQLkit home page - PyGTK/python/sqlalchemy ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Moving Twisted off Trac and SVN to somewhere nicer
On Wed, Jul 6, 2011 at 12:19 AM, Kevin Horn kevin.h...@gmail.com wrote: Also, Git _is_ worse on Windows than it is on *nix. It's just not as bad as it _used_ to be. It's functional. It works. But it is difficult to deal with, and a lot of Windows users I have talked to (as well as myself, of course) just don't like using it. I'm not necessarily saying that that means Twisted shouldn't use Git. But it _should_ be considered as a factor. Kevin Horn Gotcha, thanks. I've been told that hg is a lot more pleasant on Windows, (and you appear to echo that), and hg-git manages to be a damn-near 1:1 mapping. Have you tried that? cheers lvh ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Ways to register stuff only done for backwards compatibility
On Tue, Jul 5, 2011 at 2:41 PM, Laurens Van Houtven _...@lvh.cc wrote: By registration I meant stuff where we could put reminders that some code can be cleaned up now. Perhaps that means ticket, if there's some way to mark a ticket as being only relevant when we stop supporting $PYTHON_VERSION_WHATEVER? Jp's excellent points aside, could we just use the code itself to do this? Whenever you see something that looks overly complicated and it turns out that that complexity is there to provide support for older Pythons, add a comment saying so. 2.3 is fairly easy to grep for, and it's almost always a good idea to explain the motive behind ugly code. jml ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] SURVEY: Have you submitted a patch to Twisted and it never got in?
On 7/5/11 10:36 PM, Glyph Lefkowitz wrote: Can you point to a specific ticket where you think this was the case? I have this same general feeling, but pretty much all of the reviews I found when I went looking for specific examples included at least some significant coding-standard, documentation, and test coverage problems. If we can find more specific examples, perhaps we can prevent this from recurring. I was mostly thinking about the persistent connection functionality for twisted.web.client.Agent. Maybe Twisted would benefit more from having that functionality in place, than having the super-perfect API between Agent and HTTP parser. I do agree that we don't want to block every ticket on the absolute best possible implementation; but, allowing changes that don't have test and documentation coverage is a recipe for creating an unmaintainable mess. I agree. -- Johan Rydberg Product Designer Edgeware AB Mäster Samuelsgatan 56 SE-111 21 Stockholm, Sweden ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] SURVEY: Have you submitted a patch to Twisted and it never got in?
On Wed, 2011-07-06 at 13:10 +0200, Johan Rydberg wrote: I was mostly thinking about the persistent connection functionality for twisted.web.client.Agent. We definitely want this to get in, this was a large part of the motivation for Agent in the first place. Maybe Twisted would benefit more from having that functionality in place, than having the super-perfect API between Agent and HTTP parser. The goal is not so much a perfect API as something we won't have to deprecate soon after because we realize there are some requirements that can't be addressed in a backwards compatible way. In this case, the cookie, proxy and other agent wrappers that have been created mean we now have a better understanding of what the Agent API looks like from a higher level, which should help. ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Ways to register stuff only done for backwards compatibility
On Jul 5, 2011, at 8:32 AM, Laurens Van Houtven wrote: In doing twisted.positioning I find my self writing a bunch of code in ways I would ordinarily write it differently, because we have to support 2.4 still (when is that going away? Isn't the most recent RHEL 2.6 already?). Is there some way to register that so that as soon as we stop supporting 2.4, we can make a lot of code a lot prettier? For certain functions such as any/all, perhaps a twisted.python._backports (with the explicit mention that code in backports will go away as soon as the version it's built to work around is no longer supported). That way, as soon as you support 2.5 (which has any/all), you just remove it from _backports, see which tests break, remove the imports, run tests again, commit. Woo! Of course, _backports is obviously not a solution for everything, since not every language feature can be fixed by defining a class or a function somewhere. Yes, we've done that many times before, in twisted.python.compat. (that should probably be an _ module now; it has always been treated as such, but it's not named appropriately.) ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Moving Twisted off Trac and SVN to somewhere nicer
On Wed, Jul 6, 2011 at 5:35 AM, Laurens Van Houtven _...@lvh.cc wrote: On Wed, Jul 6, 2011 at 12:19 AM, Kevin Horn kevin.h...@gmail.com wrote: Also, Git _is_ worse on Windows than it is on *nix. It's just not as bad as it _used_ to be. It's functional. It works. But it is difficult to deal with, and a lot of Windows users I have talked to (as well as myself, of course) just don't like using it. I'm not necessarily saying that that means Twisted shouldn't use Git. But it _should_ be considered as a factor. Kevin Horn Gotcha, thanks. I've been told that hg is a lot more pleasant on Windows, (and you appear to echo that), and hg-git manages to be a damn-near 1:1 mapping. Have you tried that? cheers lvh I've been told the same thing, by someone who _really_ didn't want to switch a project to git and got overruled. He indicated that using hg-git pretty much fixed all his complaints. I haven't used it myself, though if I ever need to do any serious work on a large project using git, I certainly intend to. Kevin Horn ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] Twisted Project Jobs Volunteer
On 5 Jul, 05:51 pm, a...@roiban.ro wrote: Hi, I have been using Twisted for about 6 months and looking for ways in which I could help the project. I just read the announcement and I would like to volunteer for one of the Twisted jobs. I am familiar with bzr and git and for the beginning I would like to start with maintaining the version control mirrors (bzr and git) and if this will not consume all my free time, I would also like to take care of buildbot master and slaves (or some other job that you consider is more important). Beside the job description, I was thinking that creating repositories mirrors on Github/Gitorious could be useful. The Launchpad BZR mirror seems to be functional. Hoping that I can be useful, please let know if my application is accepted. Hi Adi, Thanks for volunteering. It seems like the git mirror is well in hand. Perhaps you could take on just the bzr mirror for now. The buildbot related jobs are also still open. :) Send me a private email, or find me on Freenode, and we'll talk more about the details. Thanks! Jean-Paul ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
[Twisted-Python] Twisted bzr mirror (Was: Twisted Project Jobs Volunteer)
Hi, To move things forwards, I would like to discuss the next actions for BZR mirror. After the BZR mirror is done, I will look at git. Launchpad BZR mirror AFAIK Launchpad can only import a single svn branch, so importing all twisted in-development branches in Launchpad is not possible. Right now, Twisted trunk is mirrored into Launchpad using the bzr mirror and the last change is : 15922. By exarkun on 2011-06-14. Maybe Launchpad can be configured to mirror the SVN trunk branch, instead of the BZR branch. In this way Launchpad mirror will not depend on Twisted BZR mirror errors. Jonathan Lange, do you think this is a good idea? Twisted self hosted BZR mirror -- In the following days I will look at the current state of BZR mirror available here http://svn.twistedmatrix.com/bzr/Twisted/ , document the tools used for maintaining the mirror and try to reproduce a mirror on my server. Cheers, Adi On Tue, 2011-07-05 at 19:22 +, exar...@twistedmatrix.com wrote: On 05:56 pm, _...@lvh.cc wrote: Hey, Cool, thanks for offering to chip in! I think buildbot management is more important, since I can manage github + wolfwood git mirrors pretty much on my own, and the launchpad mirror looks permanently up to snuff. *Keeping* the Launchpad bzr mirror up to date is still a job we're trying to assign (that's why it's on the jobs page). Beyond that, it would be nice if more than just trunk were on Launchpad. As it is now, if you want to use Launchpad, you can't work on any branches people have made in svn. Jean-Paul ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] server issues; SVN in read-only, but Trac isn't
On 5 Jul, 08:51 pm, ziga.seilna...@gmail.com wrote: On 5.7.2011 1:49, James Y Knight wrote: On Jul 4, 2011, at 7:06 PM, Glyph Lefkowitz wrote: Hello from the Twisted server operations team, The Twisted SVN server has run into some minor unexpected trouble during routine system maintenance. For now, SVN is in read-only mode. However, this shouldn't affect Trac, so feel free to keep doing reviews and submitting patches in the meanwhile. Hopefully many of you are working from DVCS mirrors and will hardly notice the interruption :-). We will send another notice as soon as things are back to normal. I believe it should be functional now. Please advise if anything seems broken. :) James Hello, It looks like the subversion commit mails to twisted- comm...@twistedmatrix.com list are not getting through for about a day. It would be great if they could be restored, I find them convenient to keep up with the Twisted development. Thanks for pointing this out. I think James has fixed the issue. Jean-Paul ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] SURVEY: Have you submitted a patch to Twisted and it never got in?
On Jul 6, 2011, at 8:04 AM, Itamar Turner-Trauring wrote: On Wed, 2011-07-06 at 13:10 +0200, Johan Rydberg wrote: I was mostly thinking about the persistent connection functionality for twisted.web.client.Agent. We definitely want this to get in, this was a large part of the motivation for Agent in the first place. Looking at http://twistedmatrix.com/trac/ticket/3420 now, I see reviews with lots of functional issues and spec-compliance/correctness issues raised. There are a few notes on the API as well, but without addressing the reviews there, the patch would just have incorrect behavior. The few notes that are purely API aesthetics are mostly make this private by default, which should be a trivial search-and-replace to fix. Maybe Twisted would benefit more from having that functionality in place, than having the super-perfect API between Agent and HTTP parser. The goal is not so much a perfect API as something we won't have to deprecate soon after because we realize there are some requirements that can't be addressed in a backwards compatible way. In this case, the cookie, proxy and other agent wrappers that have been created mean we now have a better understanding of what the Agent API looks like from a higher level, which should help. That does sound a little like the perfect API to me :). And, I'd be inclined to argue - if I could find even one example of a functionally-correct patch with sufficient docs and tests that had actually been held up because of API issues :). -glyph ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
