Re: [Twisted-Python] SURVEY: Have you submitted a patch to Twisted and it never got in?

2011-07-07 Thread Albert Brandl 
On Wed, Jul 06, 2011 at 05:27:55PM -0400, Glyph Lefkowitz wrote:

 Looking at http://twistedmatrix.com/trac/ticket/3420 now, I see 
 reviews with lots of functional issues and spec-compliance/correctness 
 issues raised.  There are a few notes on the API as well, but without 
 addressing the reviews there, the patch would just have incorrect 
 behavior.

This is also my experience. When fixing issue 4378, I received mostly 
constructive feedback. 

There is much knowledge how to do things when working on the codebase, 
some of it implicit or spread over multiple documents. During review, 
this knowledge was conveyed in a tangible way, using a concrete piece of 
code.

I have to admit that it was a little discouraging to receive a long list 
of change requests. But the reviewers did a very good job explaining why 
things should be changed. This helped me to adapt my patches to fulfill 
the standards for the codebase. And it was very satisfying to finally 
have the patch accepted :-).

Best regards,
-- 
Albert Brandl
Weiermayer Solutions GmbH  | Abteistraße 12, A-4813 Altmünster
phone: +43 (0) 720 70 30 14| fax: +43 (0) 7612 20 3 56
web: http://www.weiermayer.com

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Ways to register stuff only done for backwards compatibility

2011-07-07 Thread Laurens Van Houtven 
I hear tickets is how you get things done: http://tm.tl/5181
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Ways to register stuff only done for backwards compatibility

2011-07-07 Thread exarkun 
On 11:15 am, _...@lvh.cc wrote:
I hear tickets is how you get things done: http://tm.tl/5181

But not this.  If we want *new* backwards compatibility stuff to be 
private, then give it a private name.  The old stuff is public though, 
so it should be treated how we treat public stuff.

Jean-Paul

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Twisted bzr mirror (Was: Twisted Project Jobs Volunteer)

2011-07-07 Thread Adi Roiban 
Hi,


LP BZR Mirror status


Martin Pool enabled trunk import directly from SVN repo and the branch
is available here:
https://code.launchpad.net/~vcs-imports/twisted/trunk

The mirror is refreshed about every 5 to 6 hours.
Only trunk is available.


Own BZR Mirror
--

I have hacked a quick and dirty script for pulling / creating / deleting
all Twisted svn branches.

The code is here: http://pastebin.ubuntu.com/639582/

Synchronizing all branches takes about 41 minutes on an Intel Xeon 2.8G
CPU. It does not uses to much memory since each branch is pulled using a
different bzr pull process.

Pulling a single branch takes about 15 seconds, so maybe we the SVN repo
can have some commit hooks to execute 'bzr pull' in the right branch.

-

Please let me know what do you think should be the next action for
resolving the bzr mirror issues?

-
Cheers,
Adi

On Wed, 2011-07-06 at 22:51 +0300, Adi Roiban wrote:
 Hi,
 
 To move things forwards, I would like to discuss the next actions for
 BZR mirror. After the BZR mirror is done, I will look at git.
 
 
 Launchpad BZR mirror
 
 
 AFAIK Launchpad can only import a single svn branch, so importing all
 twisted in-development branches in Launchpad is not possible.
 
 Right now, Twisted trunk is mirrored into Launchpad using the bzr mirror
 and the last change is : 15922. By exarkun on 2011-06-14.
 
 Maybe Launchpad can be configured to mirror the SVN trunk branch,
 instead of the BZR branch.
 In this way Launchpad mirror will not depend on Twisted BZR mirror
 errors.
 
 Jonathan Lange, do you think this is a good idea?
 
 
 Twisted self hosted BZR mirror
 --
 
 In the following days I will look at the current state of BZR mirror
 available here http://svn.twistedmatrix.com/bzr/Twisted/ , document the
 tools used for maintaining the mirror and try to reproduce a mirror on
 my server.
 
 
 Cheers,
 Adi
 
 
 On Tue, 2011-07-05 at 19:22 +, exar...@twistedmatrix.com wrote: 
  On 05:56 pm, _...@lvh.cc wrote:
  Hey,
  
  Cool, thanks for offering to chip in!
  
  I think buildbot management is more important, since I can manage 
  github +
  wolfwood git mirrors pretty much on my own, and the launchpad mirror 
  looks
  permanently up to snuff.
  
  *Keeping* the Launchpad bzr mirror up to date is still a job we're 
  trying to assign (that's why it's on the jobs page).
  
  Beyond that, it would be nice if more than just trunk were on Launchpad. 
  As it is now, if you want to use Launchpad, you can't work on any 
  branches people have made in svn.
  
  Jean-Paul
  
  ___
  Twisted-Python mailing list
  Twisted-Python@twistedmatrix.com
  http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
 
 
 
 
 
 ___
 Twisted-Python mailing list
 Twisted-Python@twistedmatrix.com
 http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python



___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python