Re: [Twisted-Python] patch for t.p.logger.SyslogObserver (was #7549)

[Roberto Polli]

Hi Glyph|all,

I just noticed the t.p.logger is gone (or integrated). This made 
the patch for supporting logLevels in t.p.syslog straightforward: 

https://twistedmatrix.com/trac/attachment/ticket/7549/syslog-loglevels-7549.patch

There are plenty of tests and it worked nicely on my env,
allowing rsyslog to split my twistd app log in various files with different
priorities.

If you see some flaw in the tests just let me know... once I roll it 
for a while on my apps I'll put the ticket in review.

Sorry for the great delay :( 
Peace,
R.

-- 
Roberto Polli


___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Silverberg CQL Driver

[Christopher Armstrong]

Yes, we use it in production in the Rackspace Otter project: 
https://github.com/rackerlabs/otter  

The particular file we most use it in is here: 
https://github.com/rackerlabs/otter/blob/master/otter/models/cass.py#L530 
 — 
the connection attribute of that class is a silverberg client.

I’ve not personally touched that code but I know we've been using it in 
production for about a year.

-radix


> On Dec 3, 2014, at 2:03 PM, Jason J. W. Williams  
> wrote:
> 
> Is anyone using the silverberg CQL (Cassandra) library for Twisted in 
> production? Just curious what people's experience with it is, since it 
> appears to be the most recently updated Twisted/CQL project.
> 
> -J
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Silverberg CQL Driver

[Jason J. W. Williams]

Is anyone using the silverberg CQL (Cassandra) library for Twisted in
production? Just curious what people's experience with it is, since it
appears to be the most recently updated Twisted/CQL project.

-J
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] doc bloat

[Adi Roiban]

On 3 December 2014 at 00:55, Glyph  wrote:

>
> > On Dec 2, 2014, at 20:05, exar...@twistedmatrix.com wrote:
>
> > Are there lots of useless docstrings on nested function definitions
> purely for the sake of twistedchecker?  Or are there undocumented nested
> functions that are actually a little bit difficult to understand on their
> own?
>
>
> twistedchecker does not presently require nested function

>From my experience, even nested functions need a sentence to describe
themthere are many nested functions used as deferred callbacks and I
prefer to have a sentence describing when they are called.

For callback methods I still don't know whether I should name based on what
they do or after the condition in which they are called. I prefer to name
them after what they do, but also to document in the docstring the
condition

But I don't think that nested functions required extensive apidoc/pydoctor
markup.

--

In order to survey the current code, maybe we can create a wiki page, and
while reading/writing/reviewing code we can extract examples and put them
in the wiki page.

-- 
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] doc bloat

[exarkun]

On 12:55 am, gl...@twistedmatrix.com wrote:



On Dec 2, 2014, at 20:05, exar...@twistedmatrix.com wrote:


Are there lots of useless docstrings on nested function definitions 
purely for the sake of twistedchecker?  Or are there undocumented 
nested functions that are actually a little bit difficult to 
understand on their own?


twistedchecker does not presently require nested function definitions 
to have docstrings.  I recently merged a fix to an incongruity where it 
was requiring this of classes defined within functions: 
. 
So this one, at least, we can cross off for the future :).


The broader context of this suggestion was that we should inspect the 
codebase to see what policy changes would improve the quality of the 
code/documentation while reducing the effort required to develop and 
maintain it.


It sounds like you have some ideas about such changes already.  Does 
that mean you'd like to suggest them (presumably in the form of issues 
filed against twistedhecker) instead of doing this investigation?


Jean-Paul

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python