[Twisted-Python] Weekly Bug Summary
Bug summary __ Summary for 2017-01-15 through 2017-01-22 Opened Closed Total Change Enhancements: 10 15 1337 -5 Defects: 3 5882 -2 Tasks: 1 3 97 -2 Regressions: 0 0 7 +0 Total:14 23 2324 -9 |== Type Changes |== Priority Changes |== Component Changes |Defect: -2 |High:-1 |Conch: -1 |Enhancement: -5 |Normal: -5 |Core:-5 |Task: -2 |Low: -1 |Ftp: -1 |Lowest: -2 |Names: -1 |Release Management: -1 |Trial: +1 |Twist: -1 |Web: +1 |Words: -1 Total Tickets Open Tickets New / Reopened Bugs __ = Normal = [#8996] pydoctor templates should set a canonical URL (opened by markrwilliams) enhancement core http://twistedmatrix.com/trac/ticket/8996 [#8997] inspect.getargspec() deprecation warnings on Python 3.6 (opened by rodrigc) enhancement core http://twistedmatrix.com/trac/ticket/8997 [#8998] Difficult or impossible to know when twisted.web.client.Agent cleanup has completed (opened by exarkun) defect webhttp://twistedmatrix.com/trac/ticket/8998 [#8999] twisted.python.test.test_release.APIBuilderTests spurious failures (opened by wsanchez) (CLOSED, duplicate) enhancement core http://twistedmatrix.com/trac/ticket/8999 [#9000] RESERVED (opened by glyph) taskcore http://twistedmatrix.com/trac/ticket/9000 [#9001] it's… (opened by glyph) enhancement core http://twistedmatrix.com/trac/ticket/9001 [#9002] twist command line that specifies --reactor multiple times fails. (opened by wsanchez) enhancement core http://twistedmatrix.com/trac/ticket/9002 [#9003] iosim calls `resumeProducing` on unpaused streaming (push) producers (opened by exarkun) defect core http://twistedmatrix.com/trac/ticket/9003 [#9004] Failure should adopt the current traceback if _findFailure's is empty (opened by markrwilliams) enhancement core http://twistedmatrix.com/trac/ticket/9004 [#9005] trial warning handling only supports warning where message is in the constructor first argument (opened by tardyp) defect core http://twistedmatrix.com/trac/ticket/9005 [#9006] successResultOf and failureResultOf should accept coroutines (opened by wsanchez) enhancement trial http://twistedmatrix.com/trac/ticket/9006 [#9007] successResultOf and failureResultOf should accept coroutines (opened by wsanchez) (CLOSED, duplicate) enhancement core http://twistedmatrix.com/trac/ticket/9007 [#8890] async/await doesn't work with chained Deferreds (opened by hawkowl) (CLOSED, fixed) enhancement core http://twistedmatrix.com/trac/ticket/8890 [#8764] Twisted should be versioned as year.month.patch, not year.release-1.patch (opened by hawkowl) (CLOSED, fixed) enhancement core http://twistedmatrix.com/trac/ticket/8764 Closed Bugs __ = High = [#8865] twisted.protocols.ftp module port to PY3 (opened by mateuszdargacz, closed by Craig Rodrigues, fixed) defect ftphttp://twistedmatrix.com/trac/ticket/8865 = Normal = [#8990] twisted.conch.ssh.factory's docstring slightly inaccurately claims to contain OpenSSH support (opened by Julian, closed by rodrigc, fixed) defect conch http://twistedmatrix.com/trac/ticket/8990 [#4996] replace call to functions from the string module in manhole (opened by nueces, closed by rodrigc, fixed) enhancement core http://twistedmatrix.com/trac/ticket/4996 [#8614] twisted.python.win32.quoteArguments problem with Python 3 on Windows (opened by rodrigc, closed by rodrigc, fixed) enhancement core http://twistedmatrix.com/trac/ticket/8614 [#8704] Do not use inspect.getargspec() in twisted/python/test/test_deprecate.py on Python 3 (opened by rodrigc, closed by rodrigc, duplicate) enhancement core http://twistedmatrix.com/trac/ticket/8704 [#5002] replace call to functions from the string module in spread (opened by nueces, closed by rodrigc, fixed) enhancement core http://twistedmatrix.com/trac/ticket/5002 [#5102] Remove cmp usage in 'conch' and 'internet' (opened by facundobatista, closed by rodrigc, fixed)
Re: [Twisted-Python] Problems with inlineCallback, Deferred, yield and Python 3 in buildbot
> On Jan 21, 2017, at 6:15 PM, Craig Rodrigueswrote: > > If I run the test on Python 2, I don't get the error, and on line 93, brdicts > is a dict. > However, if I run the test on Python 3, brdicts is a Deferred, thus the error. This really ought to be impossible. If I were seeing this, single-stepping through inlineCallbacks in pudb would probably be my next step. Have you made any attempts to simplify it down to remove some of the buildbot-specific code? -glyph___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
[Twisted-Python] Problems with inlineCallback, Deferred, yield and Python 3 in buildbot
Hi, I have been submitting many patches to get buildbot working on Python 3: http://bit.ly/2jCCMPW I have run into one problem involving inlineCallback, Deferred, and yield which I am having difficulty solving. Can someone help me? If I do the following inside a Python 3 virtualenv to set things up: git clone https://github.com/buildbot/buildbot buildbot_test cd buildbot_test pip install -e pkg pip install -e worker pip install -e 'master[tls,tests]' trial buildbot.test.unit.test_process_buildrequestdistributor I get this error: == File "/Users/crodrigues/buildbot_test/master/buildbot/process/buildrequestdistributor.py", line 93, in ^M brdicts.sort(key=lambda brd: brd['submitted_at']) builtins.TypeError: 'Deferred' object is not subscriptable buildbot.test.unit.test_process_buildrequestdistributor.TestMaybeStartBuilds.test_slow_db^M == The code causing this problem is on line 93 of master/buildbot/process/buildrequestdistributor.py: 78 @defer.inlineCallbacks 79 def _fetchUnclaimedBrdicts(self): 80 # Sets up a cache of all the unclaimed brdicts. The cache is 81 # saved at self.unclaimedBrdicts cache. If the cache already 82 # exists, this function does nothing. If a refetch is desired, set 83 # the self.unclaimedBrdicts to None before calling.""" 84 if self.unclaimedBrdicts is None: 85 # TODO: use order of the DATA API 86 brdicts = yield self.master.data.get(('builders', 87 (yield self.bldr.getBuilderId()), 88 'buildrequests'), 89 [resultspec.Filter('claimed', 90 'eq', 91 [False])]) 92 # sort by submitted_at, so the first is the oldest 93 brdicts.sort(key=lambda brd: brd['submitted_at']) 94 self.unclaimedBrdicts = brdicts 95 defer.returnValue(self.unclaimedBrdicts) If I run the test on Python 2, I don't get the error, and on line 93, brdicts is a dict. However, if I run the test on Python 3, brdicts is a Deferred, thus the error. Can someone point me in the right direction for solving this problem? I am not so familiar with the differences in generators and Deferreds between Python 2 and 3. Thanks. -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?
On Fri, Jan 20, 2017 at 10:21 PM, Glyph Lefkowitzwrote: > > > I finally got around to trying this, and was baffled as to why the > behavior wasn't different between trunk and trunk-with-merged-PRs; then I > realized the commits from both were already in trunk :-). Seems to work > great now vs. 16.0 - thank you for fixing this! > > Many thanks to the0id Abhishek Choudhary for doing this to add ECDSA support to conch. I just fixed up some of the rough edges in conch. One minor thing I noticed about conch that deviates from the OpenSSH client is that conch wants to write two entries in ~/.ssh/known_hosts for each host it connects to: - one entry for the hostname - one entry for the IP address If the entry doesn't exist already, then the encoded form of the hostname is written, so it looks like: |1|8QluEPLDr6TMoscEvJPcpzFGhGo=|5wLvN+5WhahGWukK2XtBFd/tjaQ= ecdsa-sha2-nistp256 E2VjZHNhLXNoYTItbmlzdHAyNTYIbmlzdHAyNTYAAAmhQ2+fYcGOOdLqOsRQ5wzvQjP9K1tpF9+UTwLi9UIBIWOySfJBDtkZvycrIYcNolofySA//ffJA4ka0EvfAbg= |1|EHrWwxCedWehiySnBrsY8YW/9TE=|uDqYMkrF0rvXgQIdDsUhBgPzKEo= ecdsa-sha2-nistp256 E2VjZHNhLXNoYTItbmlzdHAyNTYIbmlzdHAyNTYAAAmhQ2+fYcGOOdLqOsRQ5wzvQjP9K1tpF9+UTwLi9UIBIWOySfJBDtkZvycrIYcNolofySA//ffJA4ka0EvfAbg= This seems quite weird to me, and I'm not sure why this behavior was implemented differently from the OpenSSH client. I didn't change this behavior, though. -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python