[Twisted-Python] Weekly Bug Summary

[trac]

Bug summary
__
Summary for 2018-07-01 through 2018-07-08
  Opened Closed  Total Change
Enhancements:  6  2   1397 +4
Defects:   5  7923 -2
Tasks: 1  0 95 +1
Regressions:   1  1  6 +0
Total:13 10   2422 +3

|== Type Changes   |== Priority Changes   |== Component Changes 
|Defect:   -2  |High:+0   |Conch:   -1  
|Enhancement:  +4  |Normal:  +1   |Core:+2  
|Release Blocker: Regression:  +0  |Low: +2   |Logger:  +1  
|Task: +1  |Lowest:  +0   |Release Management:  +1  
  |Trial:   -2  
  |Web: +2  



Total Tickets
Open Tickets



New / Reopened Bugs
__
= High =
[#9480] Rename samesite arg to sameSite in t.w.h.Request.addCookie (opened by evilham) (CLOSED, fixed)
release blocker: regression webhttp://twistedmatrix.com/trac/ticket/9480

= Normal =
[#9472] It's easy to misuse ReverseProxyRequest in a way that breaks it (opened by dmollerm)
enhancement webhttp://twistedmatrix.com/trac/ticket/9472

[#9473] ReverseProxyRequest will fail when building a transparent proxy (opened by dmollerm) (CLOSED, duplicate)
defect  webhttp://twistedmatrix.com/trac/ticket/9473

[#9475] Release Twisted 18.7 (opened by hawkowl)
taskrelease management http://twistedmatrix.com/trac/ticket/9475

[#9476] t.a.i.backoffPolicy fails after a certain number of retries (builtins.OverflowError) (opened by wiml)
defect  core   http://twistedmatrix.com/trac/ticket/9476

[#9477] Support PyPA-style entry points (via pkg_resources) for Twisted plugins (opened by wiml)
enhancement core   http://twistedmatrix.com/trac/ticket/9477

[#9481] t.i.b.DelayedCall repr should include useful information (opened by twm)
enhancement core   http://twistedmatrix.com/trac/ticket/9481

[#9483] failure serialization round-trip via eventAsJSON / eventFromJSON loses message, renders traceback almost useless (opened by glyph)
defect  logger http://twistedmatrix.com/trac/ticket/9483

= Low =
[#9478] Improve docs for t.w.h.Request.addCookie (opened by evilham)
enhancement webhttp://twistedmatrix.com/trac/ticket/9478

[#9479] Improve docs for t.w.h.Request.addCookie (opened by evilham) (CLOSED, fixed)
enhancement webhttp://twistedmatrix.com/trac/ticket/9479

[#9482] t.w.h.HTTPFactory docstring should mention reactor is used for timeouts (opened by twm)
enhancement webhttp://twistedmatrix.com/trac/ticket/9482

[#9484] Package coding standard should not use implicit relative imports (opened by twm)
defect  core   http://twistedmatrix.com/trac/ticket/9484

= Lowest =
[#9474] ReverseProxyRequest will fail when building a transparent proxy (opened by dmollerm) (CLOSED, duplicate)
defect  core   http://twistedmatrix.com/trac/ticket/9474



Closed Bugs
__
= High =
[#9480] Rename samesite arg to sameSite in t.w.h.Request.addCookie (opened by evilham, closed by Mark Williams , fixed)
release blocker: regression webhttp://twistedmatrix.com/trac/ticket/9480

= Normal =
[#9467] adbapi doesn't consistently use the reactor it is passed (opened by hawkowl, closed by Amber Brown , fixed)
defect  core   http://twistedmatrix.com/trac/ticket/9467

[#9086] t.w.server.GzipEncoderFactory doesn't correctly handle Accept-Encodings with items separated by ", " (opened by hawkowl, closed by Amber Brown , fixed)
defect  webhttp://twistedmatrix.com/trac/ticket/9086

[#9473] ReverseProxyRequest will fail when building a transparent proxy (opened by dmollerm, closed by dmollerm, duplicate)
defect  webhttp://twistedmatrix.com/trac/ticket/9473

[#9449] socket.getsockname requires AI_NUMERICHOST on Python 3.7+ (opened by hawkowl, closed by Amber Brown , fixed)
defect  core   http://twistedmatrix.com/trac/ticket/9449

[#9436] trial -j omits tracebacks under Python 3 (opened by markrwilliams, closed by Glyph , fixed)
defect  trial  http://twistedmatrix.com/trac/ticket/9436

[#9379] Distributed trial's AMP commands should use Unicode on Python 3 (opened by markrwilliams, closed by Glyph , fixed)
enhancement trial  http://twistedmatrix.com/trac/ticket/9379

= 

Re: [Twisted-Python] "Cleared to Land"?

[Glyph]

> On Jul 7, 2018, at 12:36 PM, Tom Most  wrote:
> 
> On Sat, Jul 7, 2018, at 12:08 AM, Glyph wrote:
>> 
>>> 
>>> On Jul 6, 2018, at 4:11 PM, Wim Lewis >> > wrote:
>>> 
>>> I have a minor PR that was reviewed and labeled "cleared to land" a
>>> while back, but three months have passed since then and it's still
>>> unmerged. Is there something else I need to do to move this along, or
>>> did it just fall through the cracks?
>>> 
>>> Wim.
>> 
>> 
>> Hi Wim,
>> 
>> Can you include a link to to the issue in question?  Probably someone (me?) 
>> intended to indicate that it was in the appropriate workflow state for 
>> landing, but was waiting for continuous integration to complete, and 
>> wandered off and forgot about it.  If you can pester a contributor here, or 
>> on IRC, someone should be able to land it for you.
>> 
>> Speaking of which, it seems like you've been a fairly stalwart and patient 
>> external contributor.  Would you like to join the project as a member and 
>> merge your own approved stuff to trunk?  Mostly, the attendant 
>> responsibilities are documented here:
>> 
>> https://twistedmatrix.com/trac/wiki/ReviewProcess 
>> 
>> 
>> (This used to be the authoritative list - 
>> https://twistedmatrix.com/trac/wiki/CommitterCheckList 
>>  - and I've just 
>> updated it to remove some extraneous stuff, but it seems that pervasive 
>> cultural understanding of github's workflow have obviated the need for 
>> repetitive stern cautions that one should not commit directly to trunk 
>> without code review and CI...)
>> 
>> -g
> 
> Hi all,
> 
> Perhaps it was https://github.com/twisted/twisted/pull/991? 
> 
Hah, it was Mark, not me!  Score!

> It was tagged "cleared to land", but had build failures unrelated to the 
> changes. I merged forward, pushed to branch, kicked a failing build, and got 
> the green checkmark. It has been merged.

Thanks for driving this to completion, Tom!  Much appreciated.

For future reference though, when landing stuff on trunk, please use this 
format exactly:

https://twistedmatrix.com/trac/wiki/ReviewProcess#Authors:Howtomergethechangetotrunk
 


This helps with both automatically closing the associated Trac ticket (I 
already did that in this case) and properly attributing credit for reviewer 
points on https://twistedmatrix.com/highscores/ 
.

> Perhaps we should avoid the "cleared to land" label on PRs from 
> non-committers? I scan through open PRs for ones which require a procedural 
> nudge now and again, but I had not looked at this one as the process appeared 
> to be done with it, and I missed that it was from a non-committer.

Ideally it would be used sparingly, but, the availability of such a process 
release-valve allows someone to do a review even if they only have time to read 
the code, and not the time to sit around waiting 40 minutes for some 
intermittent CI nonsense to shake out.

Since this doesn't have a https://twisted.reviews/  
-like "core gameplay loop" that project members regularly visit, perhaps if 
you're going to use this label you should always shoot a message to this list 
as well, to let other contributors know that they should take a look if they 
have a minute?

On that note, it looks like https://github.com/twisted/twisted/pull/1010 
 has suffered the same fate?  Any 
other committers have a minute to land that one? :)

-g


___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] "Cleared to Land"?

[Tom Most]

On Sat, Jul 7, 2018, at 12:08 AM, Glyph wrote:
> 
>> 
>> On Jul 6, 2018, at 4:11 PM, Wim Lewis  wrote:
>> 
>> I have a minor PR that was reviewed and labeled "cleared to land" a
>> while back, but three months have passed since then and it's still
>> unmerged. Is there something else I need to do to move this along, or>> did 
>> it just fall through the cracks?
>> 
>> Wim.
> 
> 
> Hi Wim,
> 
> Can you include a link to to the issue in question?  Probably
> someone (me?) intended to indicate that it was in the appropriate
> workflow state for landing, but was waiting for continuous
> integration to complete, and wandered off and forgot about it.  If
> you can pester a contributor here, or on IRC, someone should be able
> to land it for you.> 
> Speaking of which, it seems like you've been a fairly stalwart and
> patient external contributor.  Would you like to join the project as a
> member and merge your own approved stuff to trunk?  Mostly, the
> attendant responsibilities are documented here:> 
> https://twistedmatrix.com/trac/wiki/ReviewProcess
> 
> (This used to be the authoritative list -
> https://twistedmatrix.com/trac/wiki/CommitterCheckList - and I've just
> updated it to remove some extraneous stuff, but it seems that
> pervasive cultural understanding of github's workflow have obviated
> the need for repetitive stern cautions that one should not commit
> directly to trunk without code review and CI...)> 
> -g

Hi all,

Perhaps it was https://github.com/twisted/twisted/pull/991? It was
tagged "cleared to land", but had build failures unrelated to the
changes. I merged forward, pushed to branch, kicked a failing build, and
got the green checkmark. It has been merged.
Perhaps we should avoid the "cleared to land" label on PRs from non-
committers? I scan through open PRs for ones which require a procedural
nudge now and again, but I had not looked at this one as the process
appeared to be done with it, and I missed that it was from a non-
committer.
Also, yes, welcome Wim!

---Tom


___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] "Cleared to Land"?

[Glyph]

> 
> On Jul 6, 2018, at 4:11 PM, Wim Lewis  wrote:
> 
> I have a minor PR that was reviewed and labeled "cleared to land" a
> while back, but three months have passed since then and it's still
> unmerged. Is there something else I need to do to move this along, or
> did it just fall through the cracks?
> 
> Wim.

Hi Wim,

Can you include a link to to the issue in question?  Probably someone (me?) 
intended to indicate that it was in the appropriate workflow state for landing, 
but was waiting for continuous integration to complete, and wandered off and 
forgot about it.  If you can pester a contributor here, or on IRC, someone 
should be able to land it for you.

Speaking of which, it seems like you've been a fairly stalwart and patient 
external contributor.  Would you like to join the project as a member and merge 
your own approved stuff to trunk?  Mostly, the attendant responsibilities are 
documented here:

https://twistedmatrix.com/trac/wiki/ReviewProcess 


(This used to be the authoritative list - 
https://twistedmatrix.com/trac/wiki/CommitterCheckList 
 - and I've just 
updated it to remove some extraneous stuff, but it seems that pervasive 
cultural understanding of github's workflow have obviated the need for 
repetitive stern cautions that one should not commit directly to trunk without 
code review and CI...)

-g___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python