Re: [Twisted-Python] Change Trac /login link to point to /trac/github/login

[Adi Roiban]

Hi,


On Sun, 30 Aug 2020 at 17:11, Craig Rodrigues 
wrote:

> Where in https://github.com/twisted-infra/braid/ does this change need to
> be done?
>
> I'm not familiar with how braid works.
>
>
I have created a PR here
https://github.com/twisted-infra/braid/pull/263



I think that this is a trac-github plugin/extension issue which was fixed
https://github.com/trac-hacks/trac-github/issues/95

The link is created by the extension here:
https://github.com/trac-hacks/trac-github/blob/master/tracext/github/__init__.py#L136

I hope someone could review and apply the change in prod.

Cheers


> --
> Craig
>
> On Sat, Aug 29, 2020 at 11:30 PM Glyph  wrote:
>
>> If you can express this as a PR to Braid, I can promise you I'll merge &
>> apply it, but that's probably the maximum energy I can personally afford to
>> dedicate to it :).
>>
>> On Aug 29, 2020, at 10:56 AM, Craig Rodrigues 
>> wrote:
>>
>> If I am not logged in, and click on:
>>
>> https://twistedmatrix.com/trac/newticket
>>
>> It takes me to a page:
>>
>>  You are currently not logged in. You may want to do so
>>  now.
>>
>> If I click on *do so*, it takes me to:
>>
>> No handler matched request to /login
>>
>> Can this be fixed on the Trac side so that */login* redirects to:
>> https://twistedmatrix.com/trac/github/login ?
>> Or change *do so* to hyperlink to */trac/github/login*?
>>
>> This is a stumbling block when new contributors are asked to open a
>> ticket in Trac.
>>
>> --
>> Craig
>> ___
>> Twisted-Python mailing list
>> Twisted-Python@twistedmatrix.com
>> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>>
>>
>> ___
>> Twisted-Python mailing list
>> Twisted-Python@twistedmatrix.com
>> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>


-- 
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Change Trac /login link to point to /trac/github/login

[Craig Rodrigues]

Where in https://github.com/twisted-infra/braid/ does this change need to
be done?

I'm not familiar with how braid works.

--
Craig

On Sat, Aug 29, 2020 at 11:30 PM Glyph  wrote:

> If you can express this as a PR to Braid, I can promise you I'll merge &
> apply it, but that's probably the maximum energy I can personally afford to
> dedicate to it :).
>
> On Aug 29, 2020, at 10:56 AM, Craig Rodrigues 
> wrote:
>
> If I am not logged in, and click on:
>
> https://twistedmatrix.com/trac/newticket
>
> It takes me to a page:
>
>  You are currently not logged in. You may want to do so
>  now.
>
> If I click on *do so*, it takes me to:
>
> No handler matched request to /login
>
> Can this be fixed on the Trac side so that */login* redirects to:
> https://twistedmatrix.com/trac/github/login ?
> Or change *do so* to hyperlink to */trac/github/login*?
>
> This is a stumbling block when new contributors are asked to open a ticket
> in Trac.
>
> --
> Craig
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python