Re: [Twisted-Python] twisted.web HTTPS client certificate

[Barry Scott]

On Tuesday, 13 July 2021 22:48:18 BST Glyph wrote:
> 
> > On Jul 13, 2021, at 2:09 AM, Barry Scott  wrote:
> > 
> > On Monday, 12 July 2021 09:27:19 BST Glyph wrote:
> >> FWIW I would avoid calling the pyOpenSSL APIs for this, since hopefully 
> >> we'll manage to move away from OpenSSL and at least somewhat abstract away 
> >> the transition. 
> > 
> > Are you thinking to use the Windows and macOS provided crypto API and only 
> > use openssl on Unix systems?
> > 
> > Barry
> 
> It would be nice to have a system for backends so that we could do this when 
> certain specific situations call for it (usually related to TLS clients, 
> rather than servers, although having both would be great), but no, the main 
> motivation is to drop OpenSSL entirely in favor of Rustls, as recommended by 
> the ISRG: 
>  >.

That is a great goal for Twisted.

Barry




___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Adding Tom Most's SSH key to root on dornkirk.twistedmatrix.com

[Adi Roiban]

Hi team,

I would like to give Tom Most SSH access to dornkirk.twistedmatrix.com to
help with Twisted web / trac services.

Anyone over here think that is a bad idea?

Thanks!

-- 
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Fwd: Enable auto-merge for twisted/twisted

[Adi Roiban]

Hi,

Do you see any issues if we enable the auto-merge feature for
twisted/twisted?

The feature is documented here

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/automatically-merging-a-pull-request

With this, in theory you don't have to wait for all the CI to be green
before a merge.
You got your reviews, you fix some typos that don't require a re-review and
then set the merge message and your are done.
Or there was a flaky test failure and just re-run the job and the merge
will be done once all the jobs are green again.

-

This can be abused if someone will enable auto-merge before the PR is
approved by a reviewer.
As most of the time the reviewer will accept the PR but will request or
suggest minor changes.
If the auto-merge is enabled, the PR is mergesd as soon as it is reviewed.

-

The config looks like this:

You can allow setting pull requests to merge automatically once all
required reviews and status checks have passed.

   - Allow auto-merge

   Waits for merge requirements to be met and then merges automatically.




There is also the option to block a merge only after all the conversations
are marked as resolved.
I am using this for my project and it works ok... a bit annoying but can
help if you accedentally forgot to address a comment.

Cheers


-- 
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Twisted-Infra org - twm added as maintainer

[Adi Roiban]

Hi,

I tried to send this email 9 days ago... but I was not subscribed to the
list using this email... and have not seen the bounce message... if any.

--

I just wanted to let you know that I have added Tom Most as a "core" team
member to the twisted-infra organization.

This is more of an information.
Let me know if I did something wrong
I don't know if there is any process in place for adding new members to
twisted-infra org.

Tom can merge the code but without access to the actual production server
there is not much he can do.

I think that we can give him access to the servers to help with the
infrastructure.

I have not added the keys yet, but if any other member of the team think
that this is a good idea please check with Tom what are the preferred
key/keys to be added to ~/.ssh/authorized_keys

Tom's SSH Keys https://api.github.com/users/twm/keys

I can also add the keys once I get some feedback.

Cheers
-- 
Adi Roiban
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python