Re: [Twisted-Python] TerminalSession instance has no attribute 'windowChanged'

2014-08-01 Thread Glyph Lefkowitz

On Aug 1, 2014, at 5:06 AM, exar...@twistedmatrix.com wrote:

> On 10:17 am, gl...@twistedmatrix.com wrote:
>> On Jul 31, 2014, at 3:03 AM, Maxim Lacrima  wrote:
>>> Hello!
>>> 
>>> When size of terminal window of ssh client is changed, then twisted ssh 
>>> server throws an exception:
>>> 
>>> exceptions.AttributeError: TerminalSession instance has no attribute 
>>> 'windowChanged'
>>> 
>>> `manhole_ssh.TerminalSession` doesn't implement this method, but according 
>>> to ISession interface it should.
>>> 
>>> Is this a bug?
>> 
>> Yes, this is definitely a bug.  The interface says it should be there, it's 
>> called by a user of the interface, and it is not present.  Pretty clearly 
>> wrong.  Can you file a ticket?
> 
> Good news.  No need to file a ticket:
> 
>   https://twistedmatrix.com/trac/ticket/3303
> 
> Just need to resolve it.
> 
> Jean-Paul

Thanks for digging this one up.  Always nice to avoid a dup :).

-glyph



___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python


Re: [Twisted-Python] TerminalSession instance has no attribute 'windowChanged'

2014-08-01 Thread exarkun

On 10:17 am, gl...@twistedmatrix.com wrote:
On Jul 31, 2014, at 3:03 AM, Maxim Lacrima  
wrote:

Hello!

When size of terminal window of ssh client is changed, then twisted 
ssh server throws an exception:


exceptions.AttributeError: TerminalSession instance has no attribute 
'windowChanged'


`manhole_ssh.TerminalSession` doesn't implement this method, but 
according to ISession interface it should.


Is this a bug?


Yes, this is definitely a bug.  The interface says it should be there, 
it's called by a user of the interface, and it is not present.  Pretty 
clearly wrong.  Can you file a ticket?


Good news.  No need to file a ticket:

   https://twistedmatrix.com/trac/ticket/3303

Just need to resolve it.

Jean-Paul

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python


Re: [Twisted-Python] TerminalSession instance has no attribute 'windowChanged'

2014-08-01 Thread Glyph
On Jul 31, 2014, at 3:03 AM, Maxim Lacrima  wrote:

> Hello!
> 
> When size of terminal window of ssh client is changed, then twisted ssh 
> server throws an exception:
> 
> exceptions.AttributeError: TerminalSession instance has no attribute 
> 'windowChanged'
> 
> `manhole_ssh.TerminalSession` doesn't implement this method, but according to 
> ISession interface it should.
> 
> Is this a bug?

Yes, this is definitely a bug.  The interface says it should be there, it's 
called by a user of the interface, and it is not present.  Pretty clearly 
wrong.  Can you file a ticket?

> I use insults to create some curses-like ui and I need widgets to be redrawn 
> when the size of window is changed.


This is definitely possible.  Just to get yourself unblocked right now, you can 
probably give your TerminalRealm a different sessionFactory programmatically, 
one that subclasses TerminalSession and hacks in the requisite method.

But please help us fix this for real going forward too ;).

-glyph


___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python


[Twisted-Python] TerminalSession instance has no attribute 'windowChanged'

2014-07-31 Thread Maxim Lacrima
Hello!

When size of terminal window of ssh client is changed, then twisted ssh
server throws an exception:

exceptions.AttributeError: TerminalSession instance has no attribute
'windowChanged'

`manhole_ssh.TerminalSession` doesn't implement this method, but according
to ISession interface it should.

Is this a bug?

I use insults to create some curses-like ui and I need widgets to be
redrawn when the size of window is changed.

-- 
Regards,
Maxim
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python