Re: [twsocket] OverbyteICSSmtpProt IFNDEF missing?

[Angus Robertson - Magenta Systems Ltd]

> Shouldn't be there a similar construction later in the file at 
> line 1167 where it now only says:
> 
> property IcsLogger;  { V8.03 }
> 
> I would expect that here also a check for the NO_DEBUG_LOG define 
> is required.

Yes, this should be conditional code, however the SSL samples and all
my own applications use the IcsLogger, so I'm afraid I never test ICS
without SSL or logging.  

I've even just fixed an SSL bug caused by logging being optional.  

Ideally we should get rid of many of these IFDEF/IFNDEF to simplify the
code.  There are really a hang over to 10 to 15 years ago when memory
was still very limited.   

Angus

-- 
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be

[twsocket] OverbyteICSSmtpProt IFNDEF missing?

[Daniel van der Lei]

Hi,

I'm wondering if there is some minor mistake in the OverbyteSmtpProt.pas file 
of the ICS library.
Currently I'm using version 8.50 but I saw the same 'issue' was still in the 
latest nightly build.

At line 1060 it says in my file:

{$IFNDEF NO_DEBUG_LOG}
property IcsLogger  : TIcsLogger read  GetIcsLogger   { 
V8.04 }
 write SetIcsLogger;
{$ENDIF}

which is part of class definition TCustomSmtpClient

Shouldn't be there a similar construction later in the file at line 1167 where 
it now only says:

property IcsLogger;  { V8.03 }

I would expect that here also a check for the NO_DEBUG_LOG define is required.

Running with NO_DEBUG_LOG define now results in my compiler with the error:
[dcc32 Error] OverbyteIcsSmtpProt.pas(1167): E2147 Property 'IcsLogger' does 
not exist in base class

Thanks for your help




Kind Regards,


AviaVox BV

Daniel van der Lei
R Manager


[cid:AviaVox_logo_Office_82395741-0d50-4524-98e6-2a8d8327df98.png]



T   +31203160110 | F +31203160115
A   Hoofdweg 848  |  2132 MC Hoofddorp  |  The Netherlands
E   i...@aviavox.com  W www.aviavox.com


[cid:Facebook_ff181eec-a2bc-426a-a9d9-2ba6acb53f16.png]
  [cid:LinkedIn_0fc092a6-581e-4493-acb4-6126a312f4f0.png] 
   
[cid:Twitter_077296e8-956d-4d04-a408-b0827ecace92.png] 
   
[cid:Youtube_f04bff7a-c1dc-4caa-9169-f9ad85f9bb48.png] 
   
[cid:Soundcloud_5b30947a-9bb6-4f4f-8eeb-e77477482c70.png] 




D I S C L A I M E R For information, services and offers, please visit our web 
site: http://www.aviavox.com This e-mail and any attachment may contain 
confidential and privileged material intended for the addressee only. If you 
are not the addressee, you are notified that no part of the e-mail or any 
attachment may be disclosed, copied or distributed, and that any other action 
related to this e-mail or attachment is strictly prohibited, and may be 
unlawful. If you have received this e-mail by error, please notify the sender 
immediately by return e-mail, and delete this message. AviaVox BV and/or its 
employees shall not be liable for the incorrect or incomplete transmission of 
this e-mail or any attachments, nor responsible for any delay in receipt.
-- 
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be