date:20090330

[U-Boot] Please pull u-boot-i2c.git

2009-03-30 Thread Heiko Schocher

Hello Wolfgang,

The following changes since commit 2344bb8de2354101a8264c2123303c9d8d2aed3c:
  Detlev Zundel (1):
inka4x0: Use proper accessor macros for memory mapped registers.

are available in the git repository at:

  git://git.denx.de/u-boot-i2c.git master

Jens Scharsig (1):
  soft_i2c.c compiler/linker error

 drivers/i2c/soft_i2c.c |6 +-
 1 files changed, 1 insertions(+), 5 deletions(-)

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Maillist issue of u-boot@lists.denx.de

2009-03-30 Thread Liu Dave-R63238

Hello all,

I often miss some mails from u-boot@lists.denx.de in these days,
For example, we didn't receive the 8569 support patch from lists,
and didn't receive the mail from Kim
http://lists.denx.de/pipermail/u-boot/2009-March/049890.html
http://lists.denx.de/pipermail/u-boot/2009-March/049891.html

What is the matter? does my mail system have some problem?

Thanks, Dave
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch V2.1] soft_i2c.c compiler/linker error

2009-03-30 Thread Heiko Schocher

Hello Jens,

Jens Scharsig wrote:
> This patch fix the compiler/linker errors 
> 
> common/cmd_i2c.c:1252: undefined reference to `i2c_get_bus_speed'
> common/cmd_i2c.c:1256: undefined reference to `i2c_set_bus_speed'
> 
> if board use CONFIG_I2C_CMD_TREE and CONFIG_I2C_MULTI_BUS is not 
> uesd/undef (wrong define order)
> 
> and 
> 
> removes additional empty lines
> 
> Signed-off-by: Jens Scharsig 

Applied to u-boot-i2c.git

thanks
Heiko
-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2] mtd: SPI Flash: Support the Spansion Flash

2009-03-30 Thread Mingkai Hu

Add MTD SPI Flash support for S25FL008A, S25FL016A,
S25FL032A, S25FL064A, S25FL128P.

Signed-off-by: Mingkai Hu 
---
 drivers/mtd/spi/Makefile   |1 +
 drivers/mtd/spi/spansion.c |  356 
 2 files changed, 357 insertions(+), 0 deletions(-)
 create mode 100644 drivers/mtd/spi/spansion.c

diff --git a/drivers/mtd/spi/Makefile b/drivers/mtd/spi/Makefile
index 3d4f892..6ca6073 100644
--- a/drivers/mtd/spi/Makefile
+++ b/drivers/mtd/spi/Makefile
@@ -27,6 +27,7 @@ LIB   := $(obj)libspi_flash.a
 
 COBJS-$(CONFIG_SPI_FLASH)  += spi_flash.o
 COBJS-$(CONFIG_SPI_FLASH_ATMEL)+= atmel.o
+COBJS-$(CONFIG_SPI_FLASH_SPANSION) += spansion.o
 COBJS-$(CONFIG_SPI_FLASH_STMICRO)  += stmicro.o
 
 COBJS  := $(COBJS-y)
diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
new file mode 100644
index 000..3dcccd3
--- /dev/null
+++ b/drivers/mtd/spi/spansion.c
@@ -0,0 +1,356 @@
+/*
+ * Copyright (C) 2009 Freescale Semiconductor, Inc.
+ *
+ * Author: Mingkai Hu (mingkai...@freescale.com)
+ * Based on stmicro.c by Wolfgang Denk (w...@denx.de),
+ * TsiChung Liew (tsi-chung.l...@freescale.com),
+ * and  Jason McMullan (mcmul...@netapp.com)
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include 
+#include 
+#include 
+
+#include "spi_flash_internal.h"
+
+/* S25FLxx-specific commands */
+#define CMD_S25FLXX_READ   0x03/* Read Data Bytes */
+#define CMD_S25FLXX_FAST_READ  0x0b/* Read Data Bytes at Higher Speed */
+#define CMD_S25FLXX_READID 0x90/* Read Manufacture ID and Device ID */
+#define CMD_S25FLXX_WREN   0x06/* Write Enable */
+#define CMD_S25FLXX_WRDI   0x04/* Write Disable */
+#define CMD_S25FLXX_RDSR   0x05/* Read Status Register */
+#define CMD_S25FLXX_WRSR   0x01/* Write Status Register */
+#define CMD_S25FLXX_PP 0x02/* Page Program */
+#define CMD_S25FLXX_SE 0xd8/* Sector Erase */
+#define CMD_S25FLXX_BE 0xc7/* Bulk Erase */
+#define CMD_S25FLXX_DP 0xb9/* Deep Power-down */
+#define CMD_S25FLXX_RES0xab/* Release from DP, and Read 
Signature */
+
+#define SPSN_ID_S25FL008A  0x0213
+#define SPSN_ID_S25FL016A  0x0214
+#define SPSN_ID_S25FL032A  0x0215
+#define SPSN_ID_S25FL064A  0x0216
+#define SPSN_ID_S25FL128P  0x2018
+#define SPSN_EXT_ID_S25FL128P_256KB0x0300
+#define SPSN_EXT_ID_S25FL128P_64KB 0x0301
+
+#define SPANSION_SR_WIP(1 << 0)/* Write-in-Progress */
+
+struct spansion_spi_flash_params {
+   u16 idcode1;
+   u16 idcode2;
+   u16 page_size;
+   u16 pages_per_sector;
+   u16 nr_sectors;
+   const char *name;
+};
+
+struct spansion_spi_flash {
+   struct spi_flash flash;
+   const struct spansion_spi_flash_params *params;
+};
+
+static inline struct spansion_spi_flash *to_spansion_spi_flash(struct spi_flash
+*flash)
+{
+   return container_of(flash, struct spansion_spi_flash, flash);
+}
+
+static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
+   {
+   .idcode1 = SPSN_ID_S25FL008A,
+   .idcode2 = 0,
+   .page_size = 256,
+   .pages_per_sector = 256,
+   .nr_sectors = 16,
+   .name = "S25FL008A",
+   },
+   {
+   .idcode1 = SPSN_ID_S25FL016A,
+   .idcode2 = 0,
+   .page_size = 256,
+   .pages_per_sector = 256,
+   .nr_sectors = 32,
+   .name = "S25FL016A",
+   },
+   {
+   .idcode1 = SPSN_ID_S25FL032A,
+   .idcode2 = 0,
+   .page_size = 256,
+   .pages_per_sector = 256,
+   .nr_sectors = 64,
+   .name = "S25FL032A",
+   },
+   {
+   .idcode1 = SPSN_ID_S25FL064A,
+   .idcode2 = 0,
+   .page_size = 256,
+   .pages_per_sector = 256,
+   .nr_sectors = 128,
+   .name = "S25FL064A",
+   },
+   {
+   .idcode1 = SPSN_ID_S25FL128P,
+   .idcode2 = SPSN_EXT_

[U-Boot] [PATCH] eSPI: add the eSPI register support

2009-03-30 Thread Mingkai Hu

Signed-off-by: Mingkai Hu 
---
 include/asm-ppc/immap_85xx.h |   17 +
 1 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/include/asm-ppc/immap_85xx.h b/include/asm-ppc/immap_85xx.h
index 7b97fe0..e84599d 100644
--- a/include/asm-ppc/immap_85xx.h
+++ b/include/asm-ppc/immap_85xx.h
@@ -258,6 +258,21 @@ typedef struct ccsr_lbc {
 } ccsr_lbc_t;
 
 /*
+ * eSPI Registers(0x7000-0x8000)
+ */
+typedef struct ccsr_espi {
+   uintmode;   /* 0x00 - eSPI mode register  */
+   uintevent;  /* 0x04 - eSPI event register */
+   uintmask;   /* 0x08 - eSPI mask register  */
+   uintcom;/* 0x0c - eSPI command register */
+   uinttx; /* 0x10 - eSPI transmit FIFO access register */
+   uintrx; /* 0x14 - eSPI receive FIFO access register */
+   charres1[8];/* reserved */
+   uintcsmode[4];  /* 0x20 - 0x2c: sSPI CS0/1/2/3 mode register */
+   charres2[4048]; /* fill up to 0x1000 */
+} ccsr_espi_t;
+
+/*
  * PCI Registers(0x8000-0x9000)
  */
 typedef struct ccsr_pcix {
@@ -1682,6 +1697,8 @@ typedef struct ccsr_gur {
 #define CONFIG_SYS_MPC85xx_DDR2_ADDR   (CONFIG_SYS_IMMR + 
CONFIG_SYS_MPC85xx_DDR2_OFFSET)
 #define CONFIG_SYS_MPC85xx_LBC_OFFSET  (0x5000)
 #define CONFIG_SYS_MPC85xx_LBC_ADDR(CONFIG_SYS_IMMR + 
CONFIG_SYS_MPC85xx_LBC_OFFSET)
+#define CONFIG_SYS_MPC85xx_ESPI_OFFSET (0x7000)
+#define CONFIG_SYS_MPC85xx_ESPI_ADDR   (CONFIG_SYS_IMMR + 
CONFIG_SYS_MPC85xx_ESPI_OFFSET)
 #define CONFIG_SYS_MPC85xx_PCIX_OFFSET (0x8000)
 #define CONFIG_SYS_MPC85xx_PCIX_ADDR   (CONFIG_SYS_IMMR + 
CONFIG_SYS_MPC85xx_PCIX_OFFSET)
 #define CONFIG_SYS_MPC85xx_PCIX2_OFFSET(0x9000)
-- 
1.5.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch V2.1] soft_i2c.c compiler/linker error

2009-03-30 Thread Jens Scharsig

This patch fix the compiler/linker errors 

common/cmd_i2c.c:1252: undefined reference to `i2c_get_bus_speed'
common/cmd_i2c.c:1256: undefined reference to `i2c_set_bus_speed'

if board use CONFIG_I2C_CMD_TREE and CONFIG_I2C_MULTI_BUS is not 
uesd/undef (wrong define order)

and 

removes additional empty lines

Signed-off-by: Jens Scharsig 
--- 

diff --git a/drivers/i2c/soft_i2c.c b/drivers/i2c/soft_i2c.c
index ed5f5b2..185634d 100644
--- a/drivers/i2c/soft_i2c.c
+++ b/drivers/i2c/soft_i2c.c
@@ -51,14 +51,12 @@
 DECLARE_GLOBAL_DATA_PTR;
 #endif
 
-
 /*---
  * Definitions
  */
 
 #define RETRIES0
 
-
 #define I2C_ACK0   /* PD_SDA level to ack a byte */
 #define I2C_NOACK  1   /* PD_SDA level to noack a byte */
 
@@ -154,7 +152,6 @@ static void send_stop(void)
I2C_TRISTATE;
 }
 
-
 /*---
  * ack should be I2C_ACK or I2C_NOACK
  */
@@ -174,7 +171,6 @@ static void send_ack(int ack)
I2C_DELAY;
 }
 
-
 /*---
  * Send 8 bits and look for an acknowledgement.
  */
@@ -246,6 +242,7 @@ int i2c_set_bus_num(unsigned int bus)
 #endif
return 0;
 }
+#endif
 
 /* TODO: add 100/400k switching */
 unsigned int i2c_get_bus_speed(void)
@@ -260,7 +257,6 @@ int i2c_set_bus_speed(unsigned int speed)
 
return 0;
 }
-#endif
 
 /*---
  * if ack == I2C_ACK, ACK the byte so can continue reading, else
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] mpc52xx phy: initialize only when needed

2009-03-30 Thread Ben Warren

On Mon, Mar 30, 2009 at 6:04 PM, Jon Smirl  wrote:

> On Wed, Mar 25, 2009 at 5:53 PM, Wolfgang Denk  wrote:
> > Dear Jon Smirl,
> >
> > In message <9e4733910903251212j4436f1afu817456c7f6e9c...@mail.gmail.com>
> you wrote:
> >> Is this patch ok for inclusion?
>
> Ping? Any answer on this one?
>
Sorry, I have some catching up to do.  Will respond within the next couple
of days.

regards,
Ben
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-03-30 Thread Heiko Schocher

Hello Michael,

Michael Zaidman wrote:
> Please see my comments and updated patch below.
> 
> On Mon, Mar 30, 2009 at 7:12 AM, Heiko Schocher  wrote:
>> Hello Michael,
>>
>> Michael Zaidman wrote:
[...]
>> The following 2 vars are just used, if CONFIG_CMD_CDP
>> is used, can we do a "#if defined" around it?
>>> +   NetOurNativeVLAN = getenv_VLAN("nvlan");
>>> +   NetOurVLAN = getenv_VLAN("vlan");
> 
> These two variables have been initialized in original code for all
> protocols supported by u-boot. As I can see, at least the NetOurVLAN
> is used by most of them. This was the reason for keeping them in place.

Ok.

>> [...]
>>> @@ -443,18 +392,19 @@ restart:
>>>/* Start with a clean slate... */
>>>BootpTry = 0;
>>>NetOurIP = 0;
>>> -   NetServerIP = getenv_IPaddr ("serverip");
>>>DhcpRequest();  /* Basically same as BOOTP */
>>>break;
>>>  #endif
>>>
>>>case BOOTP:
>>>BootpTry = 0;
>>> +   NetOurIP = 0;
>>>
>> why we need this here?
> 
> Generally, for the same reason the DHCP does - "Start with a clean state..."
> On the other hand you are right - we do not need to clear the NetOurIP
> address for BOOTP, DHCP and RARP because the current implementation
> does not check it. So it has been removed in my new patch below.

thanks.

> Here is the updated patch:
> 
> Subject: [U-Boot] [PATCH] NetLoop initialization bug

Hmm.. can you please add your commit message and your Signed-off-by

thanks
Heiko
-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch V2] soft_i2c.c compiler/linker error

2009-03-30 Thread Heiko Schocher

Hello Jens,

Jens Scharsig wrote:
> This patch fix the compiler/linker errors 
> 
> common/cmd_i2c.c:1252: undefined reference to `i2c_get_bus_speed'
> common/cmd_i2c.c:1256: undefined reference to `i2c_set_bus_speed'
> 
> if board use CONFIG_I2C_CMD_TREE and CONFIG_I2C_MULTI_BUS is not uesd/undef 
> (wrong define order)

This line is too long also s/uesd/used should be done ... I fix
this, when apply this patch (or you send me a new one)

bye
Heiko
-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/7] mtd: SPI Flash: Support the Spansion Flash

2009-03-30 Thread Hu Mingkai-B21284

 

> -Original Message-
> From: Mike Frysinger [mailto:vap...@gentoo.org] 
> Sent: Tuesday, March 31, 2009 9:12 AM
> To: u-boot@lists.denx.de
> Cc: Hu Mingkai-B21284; Fleming Andy-AFLEMING
> Subject: Re: [U-Boot] [PATCH 2/7] mtd: SPI Flash: Support the 
> Spansion Flash
> 
> On Sunday 15 March 2009 22:52:18 Mingkai Hu wrote:
> > +int spansion_erase(struct spi_flash *flash, u32 offset, 
> size_t len) { 
> > +...
> > +   ret = spansion_wait_ready(flash, 2 * CONFIG_SYS_HZ);
> 
> there is a common define you should use instead: 
> SPI_FLASH_PAGE_ERASE_TIMEOUT -mike
> 

Thanks, Mike, I'll fix it.

Best Regards,
Mingkai
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read CONFIG_SYS_MONITOR_LEN

2009-03-30 Thread Amit Kumar Sharma

Hi Rubini,

AS suggested by scott , Please share your views regarding 
CONFIG_SYS_MONITOR_LEN
because image size getting bigger then 1 block we have to 
use this macro for uboot image size.

- Original Message - 
From: "Scott Wood" 
To: "apgmoorthy" 
Cc: ; 
Sent: Tuesday, March 31, 2009 4:03 AM
Subject: Re: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read 
CONFIG_SYS_MONITOR_LEN


> apgmoorthy wrote:
>> Currently OneNAND initial program loader (ipl) reads only 
>> block 0 ie 128KB.
>> However, u-boot image for apollon board is 195KB making 
>> the board
>> unbootable with OneNAND.
>>
>> Fix ipl to read CONFIG_SYS_MONITOR_LEN.
>> CONFIG_SYS_MONITOR_LEN macro holds the U-Boot image size.
>>
>>  Signed-off-by: Rohit Hagargundgi 
>>  Signed-off-by: Gangheyamoorthy 
>> 
>
> Applied to u-boot-nand-flash, with the below whitespace 
> errors fixed:
>
> Applying RE: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read
> CONFIG_SYS_MONITOR_LEN
> .dotest/patch:128: trailing whitespace.
> /* This block is bad. Skip 
> it
> .dotest/patch:130: space before tab in indent.
> offset -= page * pagesize;
> warning: 2 lines add whitespace errors.
>
> Note that there are a couple of board files (apollon and 
> nmdk8815) that
> use the OneNAND loader that do not define 
> CONFIG_SYS_MONITOR_LEN.  I've
> added the maintainers to the Cc: list.
>
> -Scott
Thanks
Amit
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot 


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] U-boot NAND boot on IMX31 3stack(ARM)

2009-03-30 Thread alfred steele

Hi Scott:
Thanks!


>> I am also wondering if there is a include file which builds up a table
>> of working NAND devices and thier attributes which tells the U-boot on
>> the parameters about a particular NAND device on the board like
>> Block_size , page_size, device size, pages per block, device id etc.
>> Or This information needs to be kind of hardcoded every time.
>
> drivers/mtd/nand/nand_ids.c
I have three files which probably make sense to include the new flash part.
drivers/mtd/nand/nand_ids.c
./common/cmd_doc.c
./include/linux/mtd/nand_ids.h:

At this point, i do not understand the purpose of each and especially
how would the structure flash_id be populated from our data sheet for
the flash part we use
 "Samsung K9F1G08R0A".
I basically do not understand all the elements of the array
nand_flash_dev nand_flash_ids[] to be able to populate it correctly.
It would be great if you can throw some light on it or point me to
some relevant documentation.

Thanks in advance!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/7] mtd: SPI Flash: Support the Spansion Flash

2009-03-30 Thread Mike Frysinger

On Sunday 15 March 2009 22:52:18 Mingkai Hu wrote:
> +int spansion_erase(struct spi_flash *flash, u32 offset, size_t len)
> +{
> +...
> + ret = spansion_wait_ready(flash, 2 * CONFIG_SYS_HZ);

there is a common define you should use instead: SPI_FLASH_PAGE_ERASE_TIMEOUT
-mike

signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] core ticks/timer code

2009-03-30 Thread Mike Frysinger

so if we were to document things, it should read like this:
 - CONFIG_SYS_HZ is required to be 1000
 - get_ticks() / get_tbclk() should be deprecated -- use get_timer() instead
 - get_timer(X) returns the number of milliseconds since the last call to 
reset_timer(), minus X (which is in milliseconds too)

is there any reason to keep ticks/tbclk around ?  looking at consumers of 
these functions, they seem to re-implement the get_timer() logic anyways.
-mike


signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] mpc52xx phy: initialize only when needed

2009-03-30 Thread Jon Smirl

On Wed, Mar 25, 2009 at 5:53 PM, Wolfgang Denk  wrote:
> Dear Jon Smirl,
>
> In message <9e4733910903251212j4436f1afu817456c7f6e9c...@mail.gmail.com> you 
> wrote:
>> Is this patch ok for inclusion?

Ping? Any answer on this one?

>>
>> On Sat, Mar 21, 2009 at 9:38 AM, Jon  wrote:
>> > From: Sascha Hauer 
>> >
>> > Do not initialize phy on startup, instead initialize it
>> > when we actually need it.
>> >
>> > Signed-off-by: Sascha Hauer 
>> > ---
>> >  drivers/net/mpc5xxx_fec.c |   11 +--
>> >  1 files changed, 9 insertions(+), 2 deletions(-)
>
> This is more for Ben to review, I think.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> Intuition, however illogical, is recognized as a command prerogative.
>        -- Kirk, "Obsession", stardate 3620.7
>



-- 
Jon Smirl
jonsm...@gmail.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH V2] mpc5200: reduce delays in i2c

2009-03-30 Thread Jon Smirl

Make the i2c delays smaller. The measured delay is 55us at
100Khz. Set the delay to 15us which should work for 400Khz.
100Khz will loop four times and get a 60us delay. Previous
total delay was 100,000us new total delay is 150,000us before
timeout.

Signed-off-by: Jon Smirl 

---
 cpu/mpc5xxx/i2c.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cpu/mpc5xxx/i2c.c b/cpu/mpc5xxx/i2c.c
index e2506d8..48b6464 100644
--- a/cpu/mpc5xxx/i2c.c
+++ b/cpu/mpc5xxx/i2c.c
@@ -38,7 +38,7 @@ DECLARE_GLOBAL_DATA_PTR;
 #error CONFIG_SYS_I2C_MODULE is not properly configured
 #endif
 
-#define I2C_TIMEOUT100
+#define I2C_TIMEOUT1
 #define I2C_RETRIES3
 
 struct mpc5xxx_i2c_tap {
@@ -94,7 +94,7 @@ static int wait_for_bb(void)
mpc_reg_out(®s->mcr, 0, 0);
mpc_reg_out(®s->mcr, I2C_EN, 0);
 #endif
-   udelay(1000);
+   udelay(15);
status = mpc_reg_in(®s->msr);
}
 
@@ -109,7 +109,7 @@ static int wait_for_pin(int *status)
*status = mpc_reg_in(®s->msr);
 
while (timeout-- && !(*status & I2C_IF)) {
-   udelay(1000);
+   udelay(15);
*status = mpc_reg_in(®s->msr);
}
 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] pending patches website

2009-03-30 Thread Mike Frysinger

not so long ago there was some custom thingy that was running on the u-boot 
website that'd automatically grab patches from the mailing list and try to 
file them away so they wouldnt get lost.  but i cant seem to find it any more.  
is it gone ?
-mike


signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] rtc: remove broken rtc_read and rtc_write declarations

2009-03-30 Thread Detlev Zundel

Hi Kim,

> commit 04e11cf3 "rtc: add support for 4543 RTC (manufactured by e.g.
> EPSON)" introduces the following build error on boards configuring e.g,
> the ds1374 rtc:
>
> Configuring for MPC837XEMDS board...
> ds1374.c:103: error: static declaration of 'rtc_read' follows non-static 
> declaration
> /home/r1aaha/git/u-boot/include/rtc.h:64: error: previous declaration of 
> 'rtc_read' was here
> ds1374.c:104: error: conflicting types for 'rtc_write'
> /home/r1aaha/git/u-boot/include/rtc.h:65: error: previous declaration of 
> 'rtc_write' was here
>
> this reverts the erroneous chunk.
>
> Signed-off-by: Kim Phillips 
> CC: Detlev Zundel 
> CC: Andreas Pfefferle 

Acked-by: Detlev Zundel 

Sorry for the breakage.

Cheers
  Detlev

-- 
Math and Alcohol don't mix, so...
PLEASE DON'T DRINK AND DERIVE

[Motto of the society: Mathematicians Against Drunk Deriving]
--
DENX Software Engineering GmbH,  MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] mpc83xx: Set guarded bit on BAT that covers the end of the address space

2009-03-30 Thread Kim Phillips

continuation of commit a5d7049a4 to remaining mpc83xx boards that suffer
from the same problem.

Signed-off-by: Kim Phillips 
CC: Scott Wood 
---
 include/configs/MPC8349EMDS.h |3 ++-
 include/configs/MPC8349ITX.h  |3 ++-
 include/configs/MVBLM7.h  |3 ++-
 include/configs/SIMPC8313.h   |2 +-
 include/configs/sbc8349.h |3 ++-
 5 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h
index b3c0e2d..0d1d663 100644
--- a/include/configs/MPC8349EMDS.h
+++ b/include/configs/MPC8349EMDS.h
@@ -683,7 +683,8 @@
 #define CONFIG_SYS_IBAT5U  (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | 
BATU_VP)
 
 /* SDRAM @ 0xF000, stack in DCACHE 0xFDF0 & FLASH @ 0xFE00 */
-#define CONFIG_SYS_IBAT6L  (0xF000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L  (0xF000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+BATL_GUARDEDSTORAGE)
 #define CONFIG_SYS_IBAT6U  (0xF000 | BATU_BL_256M | BATU_VS | BATU_VP)
 
 #define CONFIG_SYS_IBAT7L  (0)
diff --git a/include/configs/MPC8349ITX.h b/include/configs/MPC8349ITX.h
index 38a7386..ab6fe55 100644
--- a/include/configs/MPC8349ITX.h
+++ b/include/configs/MPC8349ITX.h
@@ -615,7 +615,8 @@ boards, we say we have two, but don't display a message if 
we find only one. */
 #define CONFIG_SYS_IBAT5U  (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | 
BATU_VP)
 
 /* SDRAM @ 0xF000, stack in DCACHE 0xFDF0 & FLASH @ 0xFE00 */
-#define CONFIG_SYS_IBAT6L  (0xF000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L  (0xF000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+BATL_GUARDEDSTORAGE)
 #define CONFIG_SYS_IBAT6U  (0xF000 | BATU_BL_256M | BATU_VS | BATU_VP)
 
 #define CONFIG_SYS_IBAT7L  0
diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h
index 4ecf806..b321825 100644
--- a/include/configs/MVBLM7.h
+++ b/include/configs/MVBLM7.h
@@ -360,7 +360,8 @@
 #define CONFIG_SYS_IBAT5U  (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | 
BATU_VP)
 
 /* stack in DCACHE 0xFDF0 & FLASH @ 0xFF80 */
-#define CONFIG_SYS_IBAT6L  (0xF000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L  (0xF000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+BATL_GUARDEDSTORAGE)
 #define CONFIG_SYS_IBAT6U  (0xF000 | BATU_BL_256M | BATU_VS | BATU_VP)
 #define CONFIG_SYS_IBAT7L  0
 #define CONFIG_SYS_IBAT7U  0
diff --git a/include/configs/SIMPC8313.h b/include/configs/SIMPC8313.h
index e20527e..79582e1 100644
--- a/include/configs/SIMPC8313.h
+++ b/include/configs/SIMPC8313.h
@@ -437,7 +437,7 @@
 #define CONFIG_SYS_IBAT5U  (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | 
BATU_VP)
 
 /* SDRAM @ 0xF000, stack in DCACHE 0xFDF0 & FLASH @ 0xFE00 */
-#define CONFIG_SYS_IBAT6L  (0xF000 | BATL_PP_10)
+#define CONFIG_SYS_IBAT6L  (0xF000 | BATL_PP_10 | BATL_GUARDEDSTORAGE)
 #define CONFIG_SYS_IBAT6U  (0xF000 | BATU_BL_256M | BATU_VS | BATU_VP)
 
 #define CONFIG_SYS_IBAT7L  (0)
diff --git a/include/configs/sbc8349.h b/include/configs/sbc8349.h
index f476e3e..42033ac 100644
--- a/include/configs/sbc8349.h
+++ b/include/configs/sbc8349.h
@@ -605,7 +605,8 @@
 #define CONFIG_SYS_IBAT5U  (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | 
BATU_VP)
 
 /* SDRAM @ 0xF000, stack in DCACHE 0xFDF0 & FLASH @ 0xFE00 */
-#define CONFIG_SYS_IBAT6L  (0xF000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L  (0xF000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+BATL_GUARDEDSTORAGE)
 #define CONFIG_SYS_IBAT6U  (0xF000 | BATU_BL_256M | BATU_VS | BATU_VP)
 
 #define CONFIG_SYS_IBAT7L  (0)
-- 
1.6.1.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] 8313erdb: Set guarded bit on BAT that covers the end of the address space.

2009-03-30 Thread Kim Phillips

On Tue, 17 Mar 2009 12:09:31 -0500
Scott Wood  wrote:

> This board currently sets DBAT6 to cover all of the final 256MiB of
> address space; however, not all of this space is covered by a device.  In
> particular, flash sits at 0xfe00-0xfe7f, and nothing is mapped
> at the far end of the address space.
> 
> In zlib, there is a loop that references p[-1] if p is non-NULL.  Under
> some circumstances, this leads to the CPU speculatively loading from
> 0xfff8 if p is NULL.  This leads to a machine check.
> 
> Signed-off-by: Scott Wood 
> ---

applied, thanks.

> Note that there are likely other board with the same issue.

patch forthcoming.

Kim
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read CONFIG_SYS_MONITOR_LEN

2009-03-30 Thread Scott Wood

apgmoorthy wrote:
> Currently OneNAND initial program loader (ipl) reads only block 0 ie 128KB.
> However, u-boot image for apollon board is 195KB making the board
> unbootable with OneNAND.
> 
> Fix ipl to read CONFIG_SYS_MONITOR_LEN.
> CONFIG_SYS_MONITOR_LEN macro holds the U-Boot image size.
> 
>  Signed-off-by: Rohit Hagargundgi 
>  Signed-off-by: Gangheyamoorthy   

Applied to u-boot-nand-flash, with the below whitespace errors fixed:

Applying RE: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read 
CONFIG_SYS_MONITOR_LEN
.dotest/patch:128: trailing whitespace.
 /* This block is bad. Skip it
.dotest/patch:130: space before tab in indent.
 offset -= page * pagesize;
warning: 2 lines add whitespace errors.

Note that there are a couple of board files (apollon and nmdk8815) that 
use the OneNAND loader that do not define CONFIG_SYS_MONITOR_LEN.  I've 
added the maintainers to the Cc: list.

-Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Enabling ARM DCache (and MMU setup) in U-Boot

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

On 21:56 Mon 30 Mar , Drasko DRASKOVIC wrote:
> Hi all,
> I would like to eneble DCache in U-Boot, because peripheral register R/W and
> SDRAM R/W is extremely slow on my platform, so booting Linux image takes
> unexceptable long time. But apparently for ARM, MMU setup is needed first.
> Now, I did not find example on any presented ARM platforms included in
> U-Boot.
> 
> Did somebody maybe suceeded on doing this and where can I find some C/ASM
> examples how to set up MMU and enable DCache for ARM?
before booting linux you must disable the cache which will be re-enable by
linux.

Could you give us more details about your soc, u-boot verison and linux
version

Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] ARM Pull Request

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

On 21:49 Mon 30 Mar , Wolfgang Denk wrote:
> Dear Dirk Behme,
> 
> In message <49d11e7d.5030...@googlemail.com> you wrote:
> > 
> > >> http://lists.denx.de/pipermail/u-boot/2009-March/049762.html
> > >>
> > >> Please remove it from the pull request until everybody agreed
> > > this duplicated code 
> > 
> > It would be nice if you could give the exact file in which you found 
> > the other/original version of this code. As already mentioned I'd like 
> > to compare/review it.
> > 
> > > so I'll remove it anyway I do not want duplicated code
> > 
> > It would be nice if we could agree on a common way how to improve 
> > (remove?) this code. And not just "I'll remove it anyway". Sorry if I 
> > misunderstood this, but it could be understood as "I will remove it 
> > independent of what other people think and do".
> 
> I have to admit that I, too, hesitated what that statement was
> supposed to mean. Jean-Christophe, it would really be nice to raise
> your complaints on the mailing list, and without too long delays, so
> we can discuss things.
It's simple I really hate duplicated that's all
so when I find copy&paste I remote it
> 
> > > I'm not statisfy about this one I'm looking on an other implementation
> > > so this patch will wait a few more days
> > 
> > It would be nice if you could share your ideas/doubts/findings so that 
> > we can work together on improving this code.
> 
> Again, I agree 100%. Jean-Christophe, please share your concerns on
> the mailing list, and without so long delays after the postings. It
> is not your job as a custodian to fix everything yourself. It is
> sufficient (and actually usualy much better, think for example about
> the long-term educational aspect) just to raise your concerns and ask
> the original poster to change things (or maybe he has good reasons
> for doing it this way, which you didn't see). But please keep such
> discussion on the mailing list, and without big delays.  Thanks.
I need to time to study a way to clean it up. Without necessarely implement it
I'm just bored by reading duplicated code everytime as the timer
implementations.

So I need few days to study it

Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Enabling ARM DCache (and MMU setup) in U-Boot

2009-03-30 Thread Drasko DRASKOVIC

Hi all,
I would like to eneble DCache in U-Boot, because peripheral register R/W and
SDRAM R/W is extremely slow on my platform, so booting Linux image takes
unexceptable long time. But apparently for ARM, MMU setup is needed first.
Now, I did not find example on any presented ARM platforms included in
U-Boot.

Did somebody maybe suceeded on doing this and where can I find some C/ASM
examples how to set up MMU and enable DCache for ARM?

Best regards,
Drasko
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] ARM Pull Request

2009-03-30 Thread Wolfgang Denk

Dear Dirk Behme,

In message <49d11e7d.5030...@googlemail.com> you wrote:
> 
> >> http://lists.denx.de/pipermail/u-boot/2009-March/049762.html
> >>
> >> Please remove it from the pull request until everybody agreed
> > this duplicated code 
> 
> It would be nice if you could give the exact file in which you found 
> the other/original version of this code. As already mentioned I'd like 
> to compare/review it.
> 
> > so I'll remove it anyway I do not want duplicated code
> 
> It would be nice if we could agree on a common way how to improve 
> (remove?) this code. And not just "I'll remove it anyway". Sorry if I 
> misunderstood this, but it could be understood as "I will remove it 
> independent of what other people think and do".

I have to admit that I, too, hesitated what that statement was
supposed to mean. Jean-Christophe, it would really be nice to raise
your complaints on the mailing list, and without too long delays, so
we can discuss things.

> > I'm not statisfy about this one I'm looking on an other implementation
> > so this patch will wait a few more days
> 
> It would be nice if you could share your ideas/doubts/findings so that 
> we can work together on improving this code.

Again, I agree 100%. Jean-Christophe, please share your concerns on
the mailing list, and without so long delays after the postings. It
is not your job as a custodian to fix everything yourself. It is
sufficient (and actually usualy much better, think for example about
the long-term educational aspect) just to raise your concerns and ask
the original poster to change things (or maybe he has good reasons
for doing it this way, which you didn't see). But please keep such
discussion on the mailing list, and without big delays.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The biggest difference between time and space is that you can't reuse
time. - Merrick Furst
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Out-of-tree build for imx31_phycore_eet fails

2009-03-30 Thread Wolfgang Denk

Dear Guennadi,

In message  you wrote:
>
> > /bin/sh: line 1: /work/wd/tmp-arm/include/config.h: No such file or 
> > directory
> > make: *** [imx31_phycore_eet_config] Error 1
> 
> ok, that's just a missing
> 
> + @mkdir -p $(obj)include
> 
> right? will submit.

Thanks.

> > Please fix.
> > 
> > BTW: you also forgot to add your name to the MAINTAINERS file. Please
> > fix this, too.
> 
> Hm, this is not a new board, just a new configuration for an existing 
> board. Do we really want a new MAINTAINERS entry for it? I looked at a 
> couple other boards with multiple configs, they all had only one entry in 
> MAINTAINERS (at most:-)).

I see. I thought that was a new board.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
There are some things worth dying for.
-- Kirk, "Errand of Mercy", stardate 3201.7
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] ARM Pull Request

2009-03-30 Thread Dirk Behme

Dear Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 15:33 Mon 30 Mar , Dirk Behme wrote:
>> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> Hi Wolfgang,
>>>
>>> Please pull
>>> The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b:
>>>   Wolfgang Denk (1):
>>> VCMA9: fix compile errors
>>>
>>> are available in the git repository at:
>>>
>>>   git://git.denx.de/u-boot-arm.git master
>>>
>>> Jean-Christophe PLAGNIOL-VILLARD (19):
>>>   s3c4510b: move specific code to soc directory
>>>   s3c44b0: move i2c driver to drivers/i2c
>>>   s3c44b0: move rtc driver to drivers/rtc
>>>   s3c44b0: move serial driver to drivers/serial
>>>   s3c44b0: extract cache from cpu.c
>>>   sa1100: move serial driver to drivers/serial
>>>   netarm: move serial driver to drivers/serial
>>>   imx31: move serial driver to drivers/serial
>>>   s3c64xx: move usb driver to drivers/usb
>>>   ks8695: move serial driver to drivers/serial
>>>   lpc2292: move serial driver to drivers/serial
>>>   arm720t/clps7111: move serial driver to drivers/serial
>>>   omap3: remove duplicate interrupts code
>> This patch isn't finally reviewed
>>
>> http://lists.denx.de/pipermail/u-boot/2009-March/049762.html
>>
>> Please remove it from the pull request until everybody agreed
> this duplicated code 

It would be nice if you could give the exact file in which you found 
the other/original version of this code. As already mentioned I'd like 
to compare/review it.

> so I'll remove it anyway I do not want duplicated code

It would be nice if we could agree on a common way how to improve 
(remove?) this code. And not just "I'll remove it anyway". Sorry if I 
misunderstood this, but it could be understood as "I will remove it 
independent of what other people think and do".

>>>   imx: move serial driver to drivers/serial
>>>   davinci: move nand driver to drivers/mtd/nand
>>>   davinci: move i2c driver to drivers/i2c
>>>   s3c24x0: move serial driver to drivers/serial
>>>   s3c24x0: move i2c driver to drivers/i2c
>>>   s3c2410: move nand driver to drivers/mtd/nand
>> It seems to me that
>>
>> http://lists.denx.de/pipermail/u-boot/2009-March/049662.html
> This one is NACK

? This link just links to a mail with two questions, not a patch ?

>> is unanswered. Therefore again:
>>
>> What's about
>>
>> http://lists.denx.de/pipermail/u-boot/2009-March/049146.html
>>
>> ?
> I'm not statisfy about this one I'm looking on an other implementation
> so this patch will wait a few more days

It would be nice if you could share your ideas/doubts/findings so that 
we can work together on improving this code.

Dirk

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2] OMAP3: Update Overo pin mux for new expansion board

2009-03-30 Thread Dirk Behme

A new Overo expansion board uses GPIO 14, 21, 22 and 23 for LED's and
switches. This patch changes the pinmux configuration for those pins.
They were previously set up for unused MMC3_DAT4-7.

Signed-off-by: Steve Sakoman 
Signed-off-by: Dirk Behme 
---

Changes in v2:

- Add Dirk's Signed-off-by
- Rebase against U-Boot mainline commit
  2344bb8de2354101a8264c2123303c9d8d2aed3c
  'inka4x0: Use proper accessor macros for memory mapped registers.'

This v2 version makes any previous version of this patch obsolete.

 board/omap3/overo/overo.h |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

Index: u-boot-main/board/omap3/overo/overo.h
===
--- u-boot-main.orig/board/omap3/overo/overo.h
+++ u-boot-main/board/omap3/overo/overo.h
@@ -185,6 +185,7 @@ const omap3_sysinfo sysinfo = {
  MUX_VAL(CP(CSI2_DX0), (IEN  | PTD | DIS | M0)) /*CSI2_DX0*/\
  MUX_VAL(CP(CSI2_DY0), (IEN  | PTD | DIS | M0)) /*CSI2_DY0*/\
  MUX_VAL(CP(CSI2_DX1), (IEN  | PTD | EN  | M4)) /*GPIO_114*/\
+/* - PEN_DOWN*/\
  MUX_VAL(CP(CSI2_DY1), (IEN  | PTU | EN  | M4)) /*GPIO_115*/\
  /*Audio Interface */\
  MUX_VAL(CP(MCBSP2_FSX),   (IEN  | PTD | DIS | M0)) /*McBSP2_FSX*/\
@@ -295,7 +296,7 @@ const omap3_sysinfo sysinfo = {
  MUX_VAL(CP(SYS_CLKOUT2),  (IEN  | PTU | EN  | M4)) /*GPIO_186*/\
  MUX_VAL(CP(ETK_CLK_ES2),  (IDIS | PTU | EN  | M2)) /*MMC3_CLK*/\
  MUX_VAL(CP(ETK_CTL_ES2),  (IEN  | PTU | EN  | M2)) /*MMC3_CMD*/\
- MUX_VAL(CP(ETK_D0_ES2),   (IEN  | PTU | EN  | M2)) /*MMC3_DAT4*/\
+ MUX_VAL(CP(ETK_D0_ES2),   (IEN  | PTU | EN  | M4)) /*GPIO_14*/\
  MUX_VAL(CP(ETK_D1_ES2),   (IEN  | PTD | EN  | M4)) /*GPIO_15 - X_GATE*/\
  MUX_VAL(CP(ETK_D2_ES2),   (IEN  | PTU | EN  | M4)) /*GPIO_16*/\
 /* - W2W_NRESET*/\
@@ -303,9 +304,9 @@ const omap3_sysinfo sysinfo = {
  MUX_VAL(CP(ETK_D4_ES2),   (IEN  | PTU | EN  | M2)) /*MMC3_DAT0*/\
  MUX_VAL(CP(ETK_D5_ES2),   (IEN  | PTU | EN  | M2)) /*MMC3_DAT1*/\
  MUX_VAL(CP(ETK_D6_ES2),   (IEN  | PTU | EN  | M2)) /*MMC3_DAT2*/\
- MUX_VAL(CP(ETK_D7_ES2),   (IEN  | PTU | EN  | M2)) /*MMC3_DAT7*/\
- MUX_VAL(CP(ETK_D8_ES2),   (IEN  | PTU | EN  | M2)) /*MMC3_DAT6*/\
- MUX_VAL(CP(ETK_D9_ES2),   (IEN  | PTU | EN  | M2)) /*MMC3_DAT5*/\
+ MUX_VAL(CP(ETK_D7_ES2),   (IEN  | PTU | EN  | M4)) /*GPIO_21*/\
+ MUX_VAL(CP(ETK_D8_ES2),   (IEN  | PTU | EN  | M4)) /*GPIO_22*/\
+ MUX_VAL(CP(ETK_D9_ES2),   (IEN  | PTU | EN  | M4)) /*GPIO_23*/\
  MUX_VAL(CP(ETK_D10_ES2),  (IDIS | PTD | DIS | M3)) /*HSUSB2_CLK*/\
  MUX_VAL(CP(ETK_D11_ES2),  (IDIS | PTD | DIS | M3)) /*HSUSB2_STP*/\
  MUX_VAL(CP(ETK_D12_ES2),  (IEN  | PTD | DIS | M3)) /*HSUSB2_DIR*/\
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Out-of-tree build for imx31_phycore_eet fails

2009-03-30 Thread Guennadi Liakhovetski

Hi Wolfgang,

On Sun, 29 Mar 2009, Wolfgang Denk wrote:

> Dear Guennadi,
> 
> out-of-tree building for the imx31_phycore_eet target fails:
> 
> -> make O=/work/wd/tmp-arm imx31_phycore_eet_config
> /bin/sh: line 1: /work/wd/tmp-arm/include/config.h: No such file or directory
> make: *** [imx31_phycore_eet_config] Error 1

ok, that's just a missing

+   @mkdir -p $(obj)include

right? will submit.

> Please fix.
> 
> BTW: you also forgot to add your name to the MAINTAINERS file. Please
> fix this, too.

Hm, this is not a new board, just a new configuration for an existing 
board. Do we really want a new MAINTAINERS entry for it? I looked at a 
couple other boards with multiple configs, they all had only one entry in 
MAINTAINERS (at most:-)).

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: off...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] rtc: remove broken rtc_read and rtc_write declarations

2009-03-30 Thread Kim Phillips

commit 04e11cf3 "rtc: add support for 4543 RTC (manufactured by e.g.
EPSON)" introduces the following build error on boards configuring e.g,
the ds1374 rtc:

Configuring for MPC837XEMDS board...
ds1374.c:103: error: static declaration of 'rtc_read' follows non-static 
declaration
/home/r1aaha/git/u-boot/include/rtc.h:64: error: previous declaration of 
'rtc_read' was here
ds1374.c:104: error: conflicting types for 'rtc_write'
/home/r1aaha/git/u-boot/include/rtc.h:65: error: previous declaration of 
'rtc_write' was here

this reverts the erroneous chunk.

Signed-off-by: Kim Phillips 
CC: Detlev Zundel 
CC: Andreas Pfefferle 
---
 include/rtc.h |4 
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/include/rtc.h b/include/rtc.h
index 019c2eb..785fbe3 100644
--- a/include/rtc.h
+++ b/include/rtc.h
@@ -61,8 +61,4 @@ void to_tm (int, struct rtc_time *);
 unsigned long mktime (unsigned int, unsigned int, unsigned int,
  unsigned int, unsigned int, unsigned int);
 
-uchar rtc_read(uchar reg) __attribute__((weak));
-void  rtc_write(uchar reg, uchar val) __attribute__((weak));
-
-
 #endif /* _RTC_H_ */
-- 
1.6.1.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Please pull u-boot-mpc85xx.git

2009-03-30 Thread Kumar Gala

The following changes since commit 2344bb8de2354101a8264c2123303c9d8d2aed3c:
  Detlev Zundel (1):
inka4x0: Use proper accessor macros for memory mapped registers.

are available in the git repository at:

  git://www.denx.de/git/u-boot-mpc85xx.git master

Dave Liu (2):
  fsl-ddr: Fix two bugs in the ddr infrastructure
  fsl-ddr: add the DDR3 SPD infrastructure

Haiying Wang (3):
  MPC85xx: Load and enable QE microcode patch in IRAM
  MPC85xx: Add MPC8569 CPU support
  MPC85xx: Add MPC8569MDS board support

Kumar Gala (4):
  Add LSDMR (SDRAM Mode Register) definition on localbus
  85xx: Use common LSDMR defines from asm/fsl_lbc.h
  83xx: Use common LSDMR defines from asm/fsl_lbc.h
  85xx: Add support for additional e500mc features

 MAKEALL |1 +
 Makefile|3 +
 board/freescale/mpc8541cds/mpc8541cds.c |   14 +-
 board/freescale/mpc8548cds/mpc8548cds.c |   10 +-
 board/freescale/mpc8555cds/mpc8555cds.c |   14 +-
 board/freescale/mpc8560ads/mpc8560ads.c |1 +
 board/freescale/mpc8568mds/mpc8568mds.c |   10 +-
 board/freescale/mpc8569mds/Makefile |   55 
 board/freescale/mpc8569mds/bcsr.c   |   49 
 board/freescale/mpc8569mds/bcsr.h   |   82 ++
 board/freescale/mpc8569mds/config.mk|   30 ++
 board/freescale/mpc8569mds/ddr.c|   84 ++
 board/freescale/mpc8569mds/law.c|   59 
 board/freescale/mpc8569mds/mpc8569mds.c |  329 ++
 board/freescale/mpc8569mds/tlb.c|  103 +++
 board/freescale/mpc8569mds/u-boot.lds   |  143 ++
 board/sbc8548/sbc8548.c |   10 +-
 common/ddr_spd.c|   53 
 cpu/mpc85xx/Makefile|1 +
 cpu/mpc85xx/cpu.c   |2 +
 cpu/mpc85xx/cpu_init.c  |   13 +
 cpu/mpc85xx/ddr-gen3.c  |6 +-
 cpu/mpc85xx/fdt.c   |   64 +-
 cpu/mpc85xx/release.S   |   16 +
 cpu/mpc85xx/start.S |   51 
 cpu/mpc8xxx/ddr/Makefile|4 +
 cpu/mpc8xxx/ddr/ctrl_regs.c |  383 +++---
 cpu/mpc8xxx/ddr/ddr3_dimm_params.c  |  314 +
 cpu/mpc8xxx/ddr/lc_common_dimm_params.c |   74 +-
 cpu/mpc8xxx/ddr/options.c   |   28 ++-
 drivers/misc/fsl_law.c  |2 +-
 drivers/qe/qe.c |9 +
 drivers/qe/qe.h |1 +
 include/asm-ppc/fsl_ddr_dimm_params.h   |7 +
 include/asm-ppc/fsl_ddr_sdram.h |   31 ++-
 include/asm-ppc/fsl_lbc.h   |   27 ++
 include/asm-ppc/immap_85xx.h|   13 +-
 include/asm-ppc/immap_qe.h  |8 +-
 include/asm-ppc/processor.h |2 +
 include/configs/MPC8323ERDB.h   |   26 --
 include/configs/MPC832XEMDS.h   |   26 --
 include/configs/MPC8349EMDS.h   |   62 +
 include/configs/MPC8360EMDS.h   |   27 +--
 include/configs/MPC8540ADS.h|   59 +---
 include/configs/MPC8541CDS.h|   37 +--
 include/configs/MPC8548CDS.h|   37 +--
 include/configs/MPC8555CDS.h|   37 +--
 include/configs/MPC8560ADS.h|   59 +---
 include/configs/MPC8568MDS.h|   37 +--
 include/configs/MPC8569MDS.h|  454 +++
 include/configs/sbc8349.h   |   62 +
 include/configs/sbc8548.h   |   37 +--
 include/ddr_spd.h   |   13 +-
 53 files changed, 2580 insertions(+), 499 deletions(-)
 create mode 100644 board/freescale/mpc8569mds/Makefile
 create mode 100644 board/freescale/mpc8569mds/bcsr.c
 create mode 100644 board/freescale/mpc8569mds/bcsr.h
 create mode 100644 board/freescale/mpc8569mds/config.mk
 create mode 100644 board/freescale/mpc8569mds/ddr.c
 create mode 100644 board/freescale/mpc8569mds/law.c
 create mode 100644 board/freescale/mpc8569mds/mpc8569mds.c
 create mode 100644 board/freescale/mpc8569mds/tlb.c
 create mode 100644 board/freescale/mpc8569mds/u-boot.lds
 create mode 100644 cpu/mpc8xxx/ddr/ddr3_dimm_params.c
 create mode 100644 include/configs/MPC8569MDS.h
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] U-boot NAND boot on IMX31 3stack(ARM)

2009-03-30 Thread Magnus Lilja

Hi

2009/3/30 alfred steele :
> Hi Magnus,
>
> Thanks!
> Do you remember, off the head, what kind of hardware differences
> between MX31 and Phycore.  I am kind of trying to identify the
> differences between the two in order to be able to map the patch to
> the differences.
> Was the nand_spl directory created for imx31(PDK) NAND specific
> changes. The reason i am asking is because in the
> "uboot-imx-imx_v2009.01" tarball Freescale has supplied us with, the
> directory already exists. I am yet to try apply your PDK patch to the
> same or compare the differences yet.

You need to be more specific, MX31 is the System-on-Chip while Phycore
is a board with the MX31 (and other devices). If you mean the PDK
board, no, I don't know the differences.

I didn't know Freescale has released a uboot-imx tarball so I don't
know which patches they have applied on top of 2009.01.


Regards, Magnus
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Out-of-tree build of API code fails

2009-03-30 Thread Rafal Jaworowski

Dear Wolfgang,

On 2009-03-29, at 00:03, Wolfgang Denk wrote:

> Dear Rafal,
>
> it seems the api_examples/ code fails when building out of tree:

...

> Could you please have a look?   Thanks in advance.

Sure, I'll take a look.

kind regards,
Rafal

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] OMAP3: Update Overo pin mux for new expansion board

2009-03-30 Thread Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090330150504.gd21...@game.jcrosoft.org> you wrote:
>
> >>> A new Overo expansion board uses GPIO 14, 21, 22 and 23 for LED's and
> >>> switches. This patch changes the pinmux configuration for those pins.
> >>> They were previously set up for unused MMC3_DAT4-7.
> >>>
> >>> Signed-off-by: Steve Sakoman 
> >>> ---
> >>>
> >>> Patch is against recent mainline commit
> >>> 'b3dd629e78870ba2dc9f8032978721c0fa02a856'
> >>> "Prepare 2009.03-rc2"
> >> sorry NACK
> >>
> >> Please send it correctly because git am will take the information from the
> >> email Hearder and I do not want to fix it manually
> >
> > Hmm, I sent this patch the same way I did with the other patches. And I 
> > can't see anything obviously wrong. Please give some details what you 
> > think might be wrong with this patch (header?).
> Based on the patch info your not the Author of the patch so it must be the
> same in the Mail Header info

Or Dirk should have added his own signed-off-by: line, too.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A girl with a future avoids the man with a past.
   -- Evan Esar, "The Humor of Humor"
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] Add imls utility command

2009-03-30 Thread Marco

This patch adds, under tools folder, a new command called imls. Its
goal is the same of UBoot imls but it can be used as Linux shell
command. It reads from raw mtd partition and prints the list of the
stored images. I'd like to receive comments about the usefulness of this
command.

Signed-off-by: Marco Stornelli 
---

diff -uprN u-boot-2009.03-orig/tools/imls.c u-boot-2009.03/tools/imls.c
--- u-boot-2009.03-orig/tools/imls.c1970-01-01 01:00:00.0 +0100
+++ u-boot-2009.03/tools/imls.c 2009-03-30 19:06:56.0 +0200
@@ -0,0 +1,218 @@
+/*
+ * (C) Copyright 2009 Marco Stornelli
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include "imls.h"
+
+extern unsigned long crc32(unsigned long crc, const char *buf, unsigned int 
len);
+static void usage(void);
+static int image_verify_header(char *ptr, int fd);
+
+char   *cmdname;
+char   *devicefile;
+
+unsigned int sectorcount = 0;
+int sflag = 0;
+unsigned int sectoroffset = 0;
+unsigned int sectorsize = 0;
+int cflag = 0;
+
+int main (int argc, char **argv)
+{
+   int fd = -1, err = 0, readbyte = 0, j, len;
+   uint32_t mtdsize, dim;
+   struct mtd_info_user mtdinfo;
+   char *buf;
+   int found = 0;
+
+   cmdname = *argv;
+
+   while (--argc > 0 && **++argv == '-') {
+   while (*++*argv) {
+   switch (**argv) {
+   case 's':
+   if (--argc <= 0) 
+   usage ();
+   sectorcount = (unsigned int)atoi(*++argv);
+   sflag = 1;
+   goto NXTARG;
+   case 'o':
+   if (--argc <= 0)
+   usage ();
+   sectoroffset = (unsigned int)atoi(*++argv);
+   goto NXTARG;
+
+   case 'c':
+   if (--argc <= 0)
+   usage ();
+   sectorsize = (unsigned int)atoi(*++argv);
+   cflag = 1;
+   goto NXTARG;
+   default:
+   usage ();
+   }
+   }
+NXTARG:;
+   }
+
+   if (argc != 1 || cflag == 0 || sflag == 0)
+   usage();
+
+   devicefile = *argv;
+
+   fd = open(devicefile, O_RDONLY);
+   if (fd < 0) {
+   fprintf (stderr, "%s: Can't open %s: %s\n",
+   cmdname, devicefile, strerror(errno));
+   exit(EXIT_FAILURE);
+   }
+
+   err = ioctl(fd, MEMGETINFO, &mtdinfo);
+   if (err < 0) {
+   fprintf(stderr, "%s: Cannot get MTD information: 
%s\n",cmdname,strerror(errno));
+   exit(EXIT_FAILURE);
+   }
+
+   mtdsize = mtdinfo.size;
+
+   if (sectorsize * sectorcount != mtdsize) {
+   fprintf(stderr, "%s: Partition size (%d) incompatible with 
sector size and count\n", cmdname, mtdsize);
+   exit(EXIT_FAILURE);
+   }
+
+   if (sectorsize * sectoroffset >= mtdsize) {
+   fprintf(stderr, "%s: Partition size (%d) incompatible with 
sector offset given\n", cmdname, mtdsize);
+   exit(EXIT_FAILURE);
+   }
+
+   if (sectoroffset > sectorcount - 1) {
+   fprintf(stderr, "%s: Sector offset cannot be grater than sector 
count minus one\n", cmdname);
+   exit(EXIT_FAILURE);
+   }
+
+   dim = image_get_header_size();
+
+   buf = malloc(sizeof(char)*dim);
+   if (!buf) {
+   fprintf (stderr, "%s: Can't allocate memory: %s\n",
+   cmdname, strerror(errno));
+   exit(EXIT_FAILURE);
+   }
+
+   if (sectoroffset != 0)
+   lseek(fd, sectoroffset*sectorsize, SEEK_SET);
+
+   printf("Searching\n");
+
+   for (j = sectoroffset; j < sectorcount; ++j) {
+
+   readbyte = read(fd, buf, dim);
+   if (readbyte != dim) {
+   fprintf(stderr, "%s: Can't read from device: %s\n",
+   cmdname, strerror(errno));
+   exit(EXIT_FAILURE);
+

Re: [U-Boot] U-boot NAND boot on IMX31 3stack(ARM)

2009-03-30 Thread Scott Wood

On Mon, Mar 30, 2009 at 11:48:57AM -0500, alfred steele wrote:
> Was the nand_spl directory created for imx31(PDK) NAND specific
> changes.

No.  It has a "board" subdirectory where board-specific code goes, plus
some board-independent drivers.

> I am also wondering if there is a include file which builds up a table
> of working NAND devices and thier attributes which tells the U-boot on
> the parameters about a particular NAND device on the board like
> Block_size , page_size, device size, pages per block, device id etc.
> Or This information needs to be kind of hardcoded every time.

drivers/mtd/nand/nand_ids.c

-Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4] board support patch for phyCORE-MPC5200B-tiny

2009-03-30 Thread Markus Rathgeb

On Mon, Mar 30, 2009 at 7:01 PM, Jon Smirl  wrote:
> On Mon, Mar 30, 2009 at 12:13 PM, Anatolij Gustschin  wrote:
>> Jon Smirl wrote:
>>> On Sun, Mar 29, 2009 at 10:08 AM, Markus Rathgeb
>>>  wrote:
 Hi!

 Have you read the BIOSEMU stuff in the mailing list?
 Can you adjust the PCI section and perhaps you can include the video
 example (set undef video).
>>>
>>> I have v1 of the pcm030 hardware and the baseboard doesn't have a PCI slot.
>>>
>>> I looked at some of your older emails. It looks like the framebuffer
>>> is not accessible. You are hanging on a write to the PCI bus.
>>>
>>> Forget about running the video BIOS initially, just use the memory
>>> commands from u-boot to make sure you can read and write the
>>> framebuffer.
>>
>> No, memory access to frame buffer will only work after the SD-RAM
>> controller of the GPU is properly initialized. Video BIOS is supposed
>> to do this among other things. As the boot log showed, video memory
>> size was not recognized by the radeon driver which indicates that
>> the video BIOS run failed to initialize the graphic chip and memory
>
> I forgot that it needed to initialize the memory controller.
>
>> controller. Fixing the XLB Initiator Window configuration for bus
>> PCI IO space starting at 0x seemed to solve problems with
>> video BIOS run.
>
> So you have this working now?

I see the u-boot console with an sweet Tux in upper left corner on the
monitor connected to the radeon card.
So I say: Yes, it is working.

When I start Xorg with framebuffer driver (after radeonfb was loaded),
this is working, too.

The xorg radeon driver with drm/radeon kernel modul loaded is not
completly working.
I will inform you in the next days. Today I have no time anymore.

>
> I've only done this from Linux and not u-boot. Linux already has the
> PCI bus set up properly.
>
>>
>> Best regards,
>> Anatolij
>>
>>
>
>
>
> --
> Jon Smirl
> jonsm...@gmail.com
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4] board support patch for phyCORE-MPC5200B-tiny

2009-03-30 Thread Jon Smirl

On Mon, Mar 30, 2009 at 12:13 PM, Anatolij Gustschin  wrote:
> Jon Smirl wrote:
>> On Sun, Mar 29, 2009 at 10:08 AM, Markus Rathgeb
>>  wrote:
>>> Hi!
>>>
>>> Have you read the BIOSEMU stuff in the mailing list?
>>> Can you adjust the PCI section and perhaps you can include the video
>>> example (set undef video).
>>
>> I have v1 of the pcm030 hardware and the baseboard doesn't have a PCI slot.
>>
>> I looked at some of your older emails. It looks like the framebuffer
>> is not accessible. You are hanging on a write to the PCI bus.
>>
>> Forget about running the video BIOS initially, just use the memory
>> commands from u-boot to make sure you can read and write the
>> framebuffer.
>
> No, memory access to frame buffer will only work after the SD-RAM
> controller of the GPU is properly initialized. Video BIOS is supposed
> to do this among other things. As the boot log showed, video memory
> size was not recognized by the radeon driver which indicates that

That comment triggered a memory. There is a bug fix in the fbdev
Radeon driver in Linux that pokes an undocumented register. That poke
fixes this problem. The problem is only present one some cards, not
all. It is a flaw in the ASIC.

I'm looking at the the fbdev driver but I can't remember where the fix is.

> the video BIOS run failed to initialize the graphic chip and memory
> controller. Fixing the XLB Initiator Window configuration for bus
> PCI IO space starting at 0x seemed to solve problems with
> video BIOS run.
>
> Best regards,
> Anatolij
>
>



-- 
Jon Smirl
jonsm...@gmail.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 3/3] arm: unify reset command

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD 
---
 cpu/arm1136/cpu.c|8 
 cpu/arm1176/cpu.c|8 
 cpu/arm720t/cpu.c|8 
 cpu/arm920t/cpu.c|8 
 cpu/arm925t/cpu.c|8 
 cpu/arm926ejs/cpu.c  |8 
 cpu/arm946es/cpu.c   |   10 -
 cpu/arm_cortexa8/cpu.c   |9 
 cpu/arm_intcm/cpu.c  |   10 -
 cpu/ixp/cpu.c|   12 --
 cpu/lh7a40x/cpu.c|9 
 cpu/pxa/cpu.c|   12 --
 cpu/s3c44b0/cpu.c|9 
 cpu/sa1100/cpu.c |   12 --
 lib_arm/Makefile |1 +
 cpu/s3c44b0/cpu.c => lib_arm/reset.c |   68 +
 16 files changed, 20 insertions(+), 180 deletions(-)
 copy cpu/s3c44b0/cpu.c => lib_arm/reset.c (58%)

diff --git a/cpu/arm1136/cpu.c b/cpu/arm1136/cpu.c
index 78f6e92..e03a765 100644
--- a/cpu/arm1136/cpu.c
+++ b/cpu/arm1136/cpu.c
@@ -83,14 +83,6 @@ int cleanup_before_linux (void)
return 0;
 }
 
-int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
-{
-   disable_interrupts ();
-   reset_cpu (0);
-   /*NOTREACHED*/
-   return(0);
-}
-
 static void cache_flush(void)
 {
unsigned long i = 0;
diff --git a/cpu/arm1176/cpu.c b/cpu/arm1176/cpu.c
index 8aefbe3..bfa4378 100644
--- a/cpu/arm1176/cpu.c
+++ b/cpu/arm1176/cpu.c
@@ -79,14 +79,6 @@ void reset_cpu (ulong ignored)
/*NOTREACHED*/
 }
 
-int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
-{
-   disable_interrupts ();
-   reset_cpu (0);
-   /*NOTREACHED*/
-   return 0;
-}
-
 /* flush I/D-cache */
 static void cache_flush (void)
 {
diff --git a/cpu/arm720t/cpu.c b/cpu/arm720t/cpu.c
index a6f5c4d..6c40903 100644
--- a/cpu/arm720t/cpu.c
+++ b/cpu/arm720t/cpu.c
@@ -86,14 +86,6 @@ int cleanup_before_linux (void)
return 0;
 }
 
-int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
-{
-   disable_interrupts ();
-   reset_cpu (0);
-   /*NOTREACHED*/
-   return (0);
-}
-
 #if defined(CONFIG_IMPA7) || defined(CONFIG_EP7312) || 
defined(CONFIG_ARMADILLO)
 /* flush I/D-cache */
 static void cache_flush (void)
diff --git a/cpu/arm920t/cpu.c b/cpu/arm920t/cpu.c
index 08c9339..87c1adc 100644
--- a/cpu/arm920t/cpu.c
+++ b/cpu/arm920t/cpu.c
@@ -72,14 +72,6 @@ int cleanup_before_linux (void)
return 0;
 }
 
-int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
-{
-   disable_interrupts ();
-   reset_cpu (0);
-   /*NOTREACHED*/
-   return 0;
-}
-
 /* flush I/D-cache */
 static void cache_flush (void)
 {
diff --git a/cpu/arm925t/cpu.c b/cpu/arm925t/cpu.c
index eb6364d..cf6a489 100644
--- a/cpu/arm925t/cpu.c
+++ b/cpu/arm925t/cpu.c
@@ -73,14 +73,6 @@ int cleanup_before_linux (void)
return 0;
 }
 
-int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
-{
-   disable_interrupts ();
-   reset_cpu (0);
-   /*NOTREACHED*/
-   return (0);
-}
-
 /* flush I/D-cache */
 static void cache_flush (void)
 {
diff --git a/cpu/arm926ejs/cpu.c b/cpu/arm926ejs/cpu.c
index 84c169e..6307e33 100644
--- a/cpu/arm926ejs/cpu.c
+++ b/cpu/arm926ejs/cpu.c
@@ -73,14 +73,6 @@ int cleanup_before_linux (void)
return 0;
 }
 
-int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
-{
-   disable_interrupts ();
-   reset_cpu (0);
-   /*NOTREACHED*/
-   return (0);
-}
-
 /* flush I/D-cache */
 static void cache_flush (void)
 {
diff --git a/cpu/arm946es/cpu.c b/cpu/arm946es/cpu.c
index 8d0c533..ef7995d 100644
--- a/cpu/arm946es/cpu.c
+++ b/cpu/arm946es/cpu.c
@@ -76,16 +76,6 @@ int cleanup_before_linux (void)
return 0;
 }
 
-int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
-{
-   extern void reset_cpu (ulong addr);
-
-   disable_interrupts ();
-   reset_cpu (0);
-   /*NOTREACHED*/
-   return (0);
-}
-
 /* flush I/D-cache */
 static void cache_flush (void)
 {
diff --git a/cpu/arm_cortexa8/cpu.c b/cpu/arm_cortexa8/cpu.c
index 64ee972..5e7b935 100644
--- a/cpu/arm_cortexa8/cpu.c
+++ b/cpu/arm_cortexa8/cpu.c
@@ -95,15 +95,6 @@ int cleanup_before_linux(void)
return 0;
 }
 
-int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
-{
-   disable_interrupts();
-   reset_cpu(0);
-
-   /* NOTREACHED */
-   return 0;
-}
-
 void l2cache_enable()
 {
unsigned long i;
diff --git a/cpu/arm_intcm/cpu.c b/cpu/arm_intcm/cpu.c
index ea6747a..1636ffb 100644
--- a/cpu/arm_intcm/cpu.c
+++ b/cpu/arm_intcm/cpu.c
@@ -66,13 +66,3 @@ int cleanup_before_linux (void)
 
return (0);
 }
-
-int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
-{
-   extern void reset_cpu (ulong addr);
-
-   disable_interrupts ();
-   reset_cpu (0);
-

[U-Boot] [PATCH 1/3] arm: update co-processor 15 access

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

import system.h from linux

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD 
---
 cpu/arm1136/cpu.c|   50 ---
 cpu/arm1176/cpu.c|   58 ++-
 cpu/arm720t/cpu.c|   58 ++-
 cpu/arm920t/cpu.c|   69 +++--
 cpu/arm925t/cpu.c|   57 ---
 cpu/arm926ejs/cpu.c  |   71 ---
 cpu/arm946es/cpu.c   |   57 ---
 cpu/arm_cortexa8/cpu.c   |   48 --
 cpu/ixp/cpu.c|   53 
 cpu/lh7a40x/cpu.c|   68 +++--
 cpu/pxa/cpu.c|   53 
 cpu/sa1100/cpu.c |   45 +---
 include/asm-arm/system.h |   84 ++
 13 files changed, 238 insertions(+), 533 deletions(-)
 create mode 100644 include/asm-arm/system.h

diff --git a/cpu/arm1136/cpu.c b/cpu/arm1136/cpu.c
index 0486163..0abe307 100644
--- a/cpu/arm1136/cpu.c
+++ b/cpu/arm1136/cpu.c
@@ -33,36 +33,12 @@
 
 #include 
 #include 
+#include 
 
 #ifdef CONFIG_USE_IRQ
 DECLARE_GLOBAL_DATA_PTR;
 #endif
 
-/* read co-processor 15, register #1 (control register) */
-static unsigned long read_p15_c1 (void)
-{
-   unsigned long value;
-
-   __asm__ __volatile__(
-   "mrcp15, 0, %0, c1, c0, 0   @ read control 
reg\n"
-   : "=r" (value)
-   :
-   : "memory");
-   return value;
-}
-
-/* write to co-processor 15, register #1 (control register) */
-static void write_p15_c1 (unsigned long value)
-{
-   __asm__ __volatile__(
-   "mcrp15, 0, %0, c1, c0, 0   
@ write it back\n"
-   :
-   : "r" (value)
-   : "memory");
-
-   read_p15_c1 ();
-}
-
 static void cp_delay (void)
 {
volatile int i;
@@ -71,18 +47,6 @@ static void cp_delay (void)
for (i = 0; i < 100; i++);
 }
 
-/* See also ARM Ref. Man. */
-#define C1_MMU (1<<0)  /* mmu off/on */
-#define C1_ALIGN   (1<<1)  /* alignment faults off/on */
-#define C1_DC  (1<<2)  /* dcache off/on */
-#define C1_WB  (1<<3)  /* merging write buffer on/off */
-#define C1_BIG_ENDIAN  (1<<7)  /* big endian off/on */
-#define C1_SYS_PROT(1<<8)  /* system protection */
-#define C1_ROM_PROT(1<<9)  /* ROM protection */
-#define C1_IC  (1<<12) /* icache off/on */
-#define C1_HIGH_VECTORS(1<<13) /* location of vectors: low/high 
addresses */
-#define RESERVED_1 (0xf << 3)  /* must be 111b for R/W */
-
 int cpu_init (void)
 {
/*
@@ -120,7 +84,7 @@ int cleanup_before_linux (void)
 
/* turn off I/D-cache */
asm ("mrc p15, 0, %0, c1, c0, 0":"=r" (i));
-   i &= ~(C1_DC | C1_IC);
+   i &= ~(CR_C | CR_I);
asm ("mcr p15, 0, %0, c1, c0, 0": :"r" (i));
 
/* flush I/D-cache */
@@ -142,21 +106,21 @@ void icache_enable (void)
 {
ulong reg;
 
-   reg = read_p15_c1 ();   /* get control reg. */
+   reg = get_cr ();/* get control reg. */
cp_delay ();
-   write_p15_c1 (reg | C1_IC);
+   set_cr (reg | CR_I);
 }
 
 void icache_disable (void)
 {
ulong reg;
 
-   reg = read_p15_c1 ();
+   reg = get_cr ();
cp_delay ();
-   write_p15_c1 (reg & ~C1_IC);
+   set_cr (reg & ~CR_I);
 }
 
 int icache_status (void)
 {
-   return(read_p15_c1 () & C1_IC) != 0;
+   return(get_cr () & CR_I) != 0;
 }
diff --git a/cpu/arm1176/cpu.c b/cpu/arm1176/cpu.c
index 1e94f7d..ef78bd9 100644
--- a/cpu/arm1176/cpu.c
+++ b/cpu/arm1176/cpu.c
@@ -34,34 +34,10 @@
 #include 
 #include 
 #include 
+#include 
 
 static void cache_flush (void);
 
-/* read co-processor 15, register #1 (control register) */
-static unsigned long read_p15_c1 (void)
-{
-   unsigned long value;
-
-   __asm__ __volatile__(
-   "mrcp15, 0, %0, c1, c0, 0   @ read control reg\n"
-   : "=r" (value)
-   :
-   : "memory");
-   return value;
-}
-
-/* write to co-processor 15, register #1 (control register) */
-static void write_p15_c1 (unsigned long value)
-{
-   __asm__ __volatile__(
-   "mcrp15, 0, %0, c1, c0, 0   @ write it back\n"
-   :
-   : "r" (value)
-   : "memory");
-
-   read_p15_c1();
-}
-
 static void cp_delay (void)
 {
volatile int i;
@@ -71,18 +47,6 @@ static void cp_delay (void)
__asm__ __volatile__("nop\n");
 }
 
-/* See also ARM Ref. Man. */
-#define C1_MMU (1 << 0)/* mmu o

[U-Boot] [PATCH 2/3] arm: clean cache management

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

unify arm cache management except for non standard cache as ARM7TDMI

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD 
---
 board/armltd/integratorap/split_by_variant.sh |   16 +++-
 cpu/arm1136/cpu.c |   46 +++-
 cpu/arm1176/cpu.c |   57 +--
 cpu/arm720t/cpu.c |   74 +++---
 cpu/arm920t/cpu.c |   73 +++
 cpu/arm925t/cpu.c |   45 +++-
 cpu/arm926ejs/cpu.c   |   72 +++---
 cpu/arm946es/cpu.c|   48 +++-
 cpu/arm_cortexa8/cpu.c|   39 --
 cpu/arm_intcm/cpu.c   |   15 
 cpu/ixp/cpu.c |   64 +++-
 cpu/lh7a40x/cpu.c |   70 +++---
 cpu/pxa/cpu.c |   62 ++-
 cpu/sa1100/cpu.c  |   58 ++
 include/configs/B2.h  |1 +
 include/configs/assabet.h |2 +
 include/configs/cerf250.h |3 +
 include/configs/cradle.h  |3 +
 include/configs/csb226.h  |4 +
 include/configs/delta.h   |3 +
 include/configs/dnp1110.h |2 +
 include/configs/evb4510.h |1 +
 include/configs/gcplus.h  |2 +
 include/configs/innokom.h |4 +
 include/configs/lart.h|2 +
 include/configs/logodl.h  |4 +
 include/configs/lubbock.h |3 +
 include/configs/pleb2.h   |3 +
 include/configs/pxa255_idp.h  |3 +
 include/configs/shannon.h |2 +
 include/configs/trizepsiv.h   |3 +
 include/configs/wepep250.h|2 +
 include/configs/xaeniax.h |3 +
 include/configs/xm250.h   |3 +
 include/configs/xsengine.h|3 +
 include/configs/zylonite.h|3 +
 lib_arm/Makefile  |3 +
 cpu/arm926ejs/cpu.c => lib_arm/cache-cp15.c   |  100 ++---
 38 files changed, 217 insertions(+), 684 deletions(-)
 copy cpu/arm926ejs/cpu.c => lib_arm/cache-cp15.c (59%)

diff --git a/board/armltd/integratorap/split_by_variant.sh 
b/board/armltd/integratorap/split_by_variant.sh
index 51dc53f..0c89844 100755
--- a/board/armltd/integratorap/split_by_variant.sh
+++ b/board/armltd/integratorap/split_by_variant.sh
@@ -84,8 +84,8 @@ else
esac
 fi
 
-if [ "$cpu" = "arm_intcm" ]
-then
+case "$cpu" in
+   arm_intcm)
echo "/* Core module undefined/not ported */"   >> tmp.fil
echo "#define CONFIG_ARM_INTCM 1"   >> tmp.fil
echo -n "#undef CONFIG_CM_MULTIPLE_SSRAM"   >> tmp.fil
@@ -102,7 +102,17 @@ then
echo"initialization reg */" >> tmp.fil
echo -n "#undef CONFIG_CM_TCRAM "   >> tmp.fil
echo" /* CM may not have TCRAM */"  >> tmp.fil
-fi
+   echo" /* May not be cahed processor */" >> tmp.fil
+   echo"#define CONFIG_SYS_NO_ICACHE 1">> tmp.fil
+   echo"#define CONFIG_SYS_NO_DCACHE 1">> tmp.fil
+   ;;
+
+   arm720t)
+   echo" /* May not be cahed processor */" >> tmp.fil
+   echo"#define CONFIG_SYS_NO_ICACHE 1">> tmp.fil
+   echo"#define CONFIG_SYS_NO_DCACHE 1">> tmp.fil
+   ;;
+esac
 
 mkdir -p ${obj}include
 mkdir -p ${obj}board/armltd/integratorap
diff --git a/cpu/arm1136/cpu.c b/cpu/arm1136/cpu.c
index 0abe307..78f6e92 100644
--- a/cpu/arm1136/cpu.c
+++ b/cpu/arm1136/cpu.c
@@ -39,13 +39,7 @@
 DECLARE_GLOBAL_DATA_PTR;
 #endif
 
-static void cp_delay (void)
-{
-   volatile int i;
-
-   /* Many OMAP regs need at least 2 nops  */
-   for (i = 0; i < 100; i++);
-}
+static void cache_flush(void);
 
 int cpu_init (void)
 {
@@ -68,8 +62,6 @@ int cleanup_before_linux (void)
 * we turn off caches etc ...
 */
 
-   unsigned long i;
-
disable_interrupts ();
 
 #ifdef CONFIG_LCD
@@ -83,15 +75,12 @@ int cleanup_before_linux (void)
 #endif
 
/* turn off I/D-cache */
-   asm ("mrc p15, 0, %0, c1, c0, 0":"=r" (i));
-   i &= ~(CR_C | CR_I);
-   asm ("mcr p15, 0, %0, c1, c0, 0": :"r" (i));
-
+   icache_disable();
+   dcache_disable();
/* flush I/D-cache */
-   i = 0;
-   asm ("mcr p15, 0, %0, c7, c7, 0": :"r" (i));  /* invalidate both caches 
and flush btb */
-   asm ("mcr p15, 0, %0, c7, c10, 4": :"r" (i)); /* mem barrier to sync 
things */
-   return(0);
+   cache_flush();
+
+

Re: [U-Boot] ARM Pull Request

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

Hi Wolfgang,

The OMAP3 patch has been dropped

Please Pull
The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b:
  Wolfgang Denk (1):
VCMA9: fix compile errors

are available in the git repository at:

  git://git.denx.de/u-boot-arm.git master

Jean-Christophe PLAGNIOL-VILLARD (18):
  s3c4510b: move specific code to soc directory
  s3c44b0: move i2c driver to drivers/i2c
  s3c44b0: move rtc driver to drivers/rtc
  s3c44b0: move serial driver to drivers/serial
  s3c44b0: extract cache from cpu.c
  sa1100: move serial driver to drivers/serial
  netarm: move serial driver to drivers/serial
  imx31: move serial driver to drivers/serial
  s3c64xx: move usb driver to drivers/usb
  ks8695: move serial driver to drivers/serial
  lpc2292: move serial driver to drivers/serial
  arm720t/clps7111: move serial driver to drivers/serial
  imx: move serial driver to drivers/serial
  davinci: move nand driver to drivers/mtd/nand
  davinci: move i2c driver to drivers/i2c
  s3c24x0: move serial driver to drivers/serial
  s3c24x0: move i2c driver to drivers/i2c
  s3c2410: move nand driver to drivers/mtd/nand

Ladislav Michl (7):
  Remove nowhere used symbol CONFIG_SYS_CLKS_IN_HZ
  NetStar: update crcit utility
  NetStar: use generic flash driver
  NetStar: add RTC support
  OMAP: reindent timer code
  OMAP: rename timer divisor
  OMAP: use {read,write}l to access timer registers

 Makefile   |2 +-
 board/netstar/Makefile |2 +-
 board/netstar/crcit.c  |   14 +-
 board/netstar/flash.c  |  343 
 board/netstar/netstar.c|   20 +
 cpu/arm1136/mx31/Makefile  |2 +-
 cpu/arm1136/omap24xx/interrupts.c  |2 +-
 cpu/arm1176/s3c64xx/Makefile   |1 -
 cpu/arm720t/Makefile   |2 +-
 cpu/arm720t/cpu.c  |   62 ---
 cpu/arm720t/s3c4510b/Makefile  |   46 ++
 cpu/arm720t/s3c4510b/cache.c   |   86 
 cpu/arm720t/serial.c   |  202 -
 cpu/arm920t/imx/Makefile   |2 +-
 cpu/arm920t/ks8695/Makefile|2 +-
 cpu/arm920t/s3c24x0/Makefile   |3 +-
 cpu/arm925t/interrupts.c   |   40 +-
 cpu/arm926ejs/davinci/Makefile |2 +-
 cpu/arm926ejs/omap/timer.c |2 +-
 cpu/arm_cortexa8/omap3/interrupts.c|2 +-
 cpu/s3c44b0/Makefile   |2 +-
 cpu/s3c44b0/cache.c|   91 
 cpu/s3c44b0/cpu.c  |  430 
 cpu/sa1100/Makefile|2 +-
 drivers/i2c/Makefile   |3 +
 .../davinci/i2c.c => drivers/i2c/davinci_i2c.c |5 -
 .../s3c24x0/i2c.c => drivers/i2c/s3c24x0_i2c.c |5 -
 drivers/i2c/s3c44b0_i2c.c  |  315 ++
 drivers/mtd/nand/Makefile  |2 +
 .../nand.c => drivers/mtd/nand/davinci_nand.c  |9 -
 .../nand.c => drivers/mtd/nand/s3c2410_nand.c  |8 -
 drivers/rtc/Makefile   |1 +
 drivers/rtc/s3c44b0_rtc.c  |  102 +
 drivers/serial/Makefile|9 +
 .../serial.c => drivers/serial/serial_clps7111.c   |   97 ++---
 .../imx/serial.c => drivers/serial/serial_imx.c|6 -
 .../serial.c => drivers/serial/serial_ks8695.c |0
 drivers/serial/serial_lpc2292.c|  105 +
 .../mx31/serial.c => drivers/serial/serial_mx31.c  |6 -
 {cpu/arm720t => drivers/serial}/serial_netarm.c|5 -
 .../serial.c => drivers/serial/serial_s3c24x0.c|4 -
 .../serial.c => drivers/serial/serial_s3c44b0.c|0
 .../serial.c => drivers/serial/serial_sa1100.c |0
 drivers/usb/Makefile   |1 +
 .../s3c64xx/usb.c => drivers/usb/s3c64xx_usb.c |0
 include/asm-arm/arch-arm720t/hardware.h|4 +-
 .../s3c4510b.h => arch-s3c4510b/hardware.h}|0
 include/configs/ADNPESC1.h |1 -
 include/configs/B2.h   |6 +-
 include/configs/DK1C20.h   |1 -
 include/configs/DK1S10.h   |1 -
 include/configs/EXBITGEN.h |2 -
 include/configs/SMN42.h|3 +-
 include/configs/SX1.h  |8 +-
 include/configs/VCMA9.h|4 +-
 include/configs/W7OLMC.h

Re: [U-Boot] [PATCH v4] board support patch for phyCORE-MPC5200B-tiny

2009-03-30 Thread Jon Smirl

On Mon, Mar 30, 2009 at 12:13 PM, Anatolij Gustschin  wrote:
> Jon Smirl wrote:
>> On Sun, Mar 29, 2009 at 10:08 AM, Markus Rathgeb
>>  wrote:
>>> Hi!
>>>
>>> Have you read the BIOSEMU stuff in the mailing list?
>>> Can you adjust the PCI section and perhaps you can include the video
>>> example (set undef video).
>>
>> I have v1 of the pcm030 hardware and the baseboard doesn't have a PCI slot.
>>
>> I looked at some of your older emails. It looks like the framebuffer
>> is not accessible. You are hanging on a write to the PCI bus.
>>
>> Forget about running the video BIOS initially, just use the memory
>> commands from u-boot to make sure you can read and write the
>> framebuffer.
>
> No, memory access to frame buffer will only work after the SD-RAM
> controller of the GPU is properly initialized. Video BIOS is supposed
> to do this among other things. As the boot log showed, video memory
> size was not recognized by the radeon driver which indicates that
> the video BIOS run failed to initialize the graphic chip and memory

I forgot that it needed to initialize the memory controller.

> controller. Fixing the XLB Initiator Window configuration for bus
> PCI IO space starting at 0x seemed to solve problems with
> video BIOS run.

So you have this working now?

I've only done this from Linux and not u-boot. Linux already has the
PCI bus set up properly.

>
> Best regards,
> Anatolij
>
>



-- 
Jon Smirl
jonsm...@gmail.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] ARM Pull Request

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

Hi Wolfgang,

The OMAP3 patch has been dropped

Please Pull

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] AT91 Pull Request

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

Hi Wolfgang,

the I2C drivers has been dropped

Please pull

The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b:
  Wolfgang Denk (1):
VCMA9: fix compile errors

are available in the git repository at:

  git://git.denx.de/u-boot-at91.git master

Jean-Christophe PLAGNIOL-VILLARD (11):
  at91sam9/at91cap: spi init add hardware chip select support
  at91sam9: add watchdog support
  at91: rename DATAFLASH_MMC_SELECT to CONFIG_DATAFLASH_MMC_SELECT
  at91rm9200dk: Move conditional compilation to Makefile
  add dataflash mmc mux missing support
  at91rm9200: move serial driver to drivers/serial
  at91rm9200: move serial shutdown code to serial drivers
  at91rm9200: Reset update
  at91: move usb driver to drivers/usb
  at91: move dataflash spi driver to drivers/spi
  at91sam9263ek: active hush and auto compelete support

Ulf Samuelsson (1):
  Add support for the AT91RM9200EK Board.

 MAKEALL|1 +
 Makefile   |4 +
 board/atmel/at91rm9200dk/Makefile  |   14 +-
 board/atmel/at91rm9200dk/at91rm9200dk.c|   10 +
 board/atmel/at91rm9200dk/mux.c |   28 +-
 board/atmel/at91rm9200ek/Makefile  |   56 
 board/atmel/at91rm9200ek/at91rm9200ek.c|   86 +
 board/atmel/at91rm9200ek/config.mk |1 +
 board/atmel/at91rm9200ek/led.c |   89 ++
 board/atmel/at91rm9200ek/misc.c|   51 +++
 board/atmel/at91rm9200ek/mux.c |   38 +++
 board/atmel/at91rm9200ek/partition.c   |   38 +++
 board/atmel/at91rm9200ek/u-boot.lds|   56 
 common/Makefile|1 +
 common/cmd_dataflash_mmc_mux.c |   65 
 cpu/arm920t/at91rm9200/Makefile|2 +-
 cpu/arm920t/at91rm9200/interrupts.c|   27 +--
 cpu/arm920t/start.S|4 +-
 cpu/arm926ejs/at91/.gitignore  |5 +
 cpu/arm926ejs/at91/Makefile|2 -
 cpu/arm926ejs/at91/at91cap9_spi.c  |   37 ++-
 cpu/arm926ejs/at91/at91sam9260_spi.c   |   36 ++-
 cpu/arm926ejs/at91/at91sam9261_spi.c   |   36 ++-
 cpu/arm926ejs/at91/at91sam9263_spi.c   |   36 ++-
 cpu/arm926ejs/at91/at91sam9rl_spi.c|   18 +-
 doc/README.at91|   11 +
 drivers/mtd/cfi_flash.c|5 +-
 drivers/serial/Makefile|1 +
 .../serial.c => drivers/serial/at91rm9200_usart.c  |5 +
 drivers/serial/atmel_usart.c   |4 +-
 drivers/spi/Makefile   |1 +
 .../spi.c => drivers/spi/atmel_dataflash_spi.c |0
 drivers/usb/Makefile   |1 +
 .../at91/usb.c => drivers/usb/atmel_usb.c  |0
 drivers/watchdog/Makefile  |   46 +++
 drivers/watchdog/at91sam9_wdt.c|   79 +
 include/asm-arm/arch-at91/at91_wdt.h   |   38 +++
 include/at45.h |2 +-
 include/common.h   |1 +
 include/configs/afeb9260.h |2 +
 include/configs/at91cap9adk.h  |2 +
 include/configs/at91rm9200dk.h |1 +
 include/configs/at91rm9200ek.h |  327 
 include/configs/at91sam9260ek.h|2 +
 include/configs/at91sam9261ek.h|2 +
 include/configs/at91sam9263ek.h|5 +
 include/configs/at91sam9rlek.h |1 +
 include/configs/cmc_pu2.h  |1 +
 include/configs/csb637.h   |1 +
 include/configs/kb9202.h   |1 +
 include/configs/m501sk.h   |1 +
 include/configs/mp2usb.h   |1 +
 52 files changed, 1201 insertions(+), 81 deletions(-)
 create mode 100644 board/atmel/at91rm9200ek/Makefile
 create mode 100644 board/atmel/at91rm9200ek/at91rm9200ek.c
 create mode 100644 board/atmel/at91rm9200ek/config.mk
 create mode 100644 board/atmel/at91rm9200ek/led.c
 create mode 100644 board/atmel/at91rm9200ek/misc.c
 create mode 100644 board/atmel/at91rm9200ek/mux.c
 create mode 100644 board/atmel/at91rm9200ek/partition.c
 create mode 100644 board/atmel/at91rm9200ek/u-boot.lds
 create mode 100644 common/cmd_dataflash_mmc_mux.c
 create mode 100644 cpu/arm926ejs/at91/.gitignore
 rename cpu/arm920t/at91rm9200/serial.c => drivers/serial/at91rm9200_usart.c 
(97%)
 rename cpu/arm926ejs/at91/spi.c => drivers/spi/atmel_dataflash_spi.c (100%)
 rename cpu/arm926ejs/at91/usb.c => driv

Re: [U-Boot] U-boot NAND boot on IMX31 3stack(ARM)

2009-03-30 Thread alfred steele

Hi Magnus,

Thanks!
Do you remember, off the head, what kind of hardware differences
between MX31 and Phycore.  I am kind of trying to identify the
differences between the two in order to be able to map the patch to
the differences.
Was the nand_spl directory created for imx31(PDK) NAND specific
changes. The reason i am asking is because in the
"uboot-imx-imx_v2009.01" tarball Freescale has supplied us with, the
directory already exists. I am yet to try apply your PDK patch to the
same or compare the differences yet.

I am also wondering if there is a include file which builds up a table
of working NAND devices and thier attributes which tells the U-boot on
the parameters about a particular NAND device on the board like
Block_size , page_size, device size, pages per block, device id etc.
Or This information needs to be kind of hardcoded every time.

We have been working on Redboot all this while and what's driving us
to move to U-boot is the available ability to be able to boot Linux
off the SD card on the MX31 platform.

Regards,
Alfred.

On Fri, Mar 27, 2009 at 3:01 PM, Magnus Lilja  wrote:
> 2009/3/27 alfred steele :
>> Thanks Magnus,
>> How difficult or rather much an effort would it need to add NAND boot
>> support and make it work on MX35 or MX31 3stack board.
>> Are there any existing guidelines for accelerating the development or
>> is the generic uboot porting guidelines .
>
>
> For i.MX31 3stack (a.k.a. PDK) there's really not that much porting
> that needs to be done. mx31 is supported in U-boot so the following is
> needed:
> * Update my basic i.MX31 PDK patch to apply on top of the current
> U-boot git (it's been a while since I updated it)
> * Add the NAND SPL patch I mentioned in my previous reply (update it
> with the review comments)
> * Test and submit the patches
>
> The above could be done in a couple of days if your're familiar with
> i.MX31 and U-boot. Add more time if you're a newcomer to U-boot and/or
> i.MX31.
>
> Since Freescale hasn't published much info on i.MX35 or the 3stack for
> that I can only guess that it would probably be pretty straight
> forward to do a NAND SPL for i.MX35 based on the one for i.MX31 (the
> NAND controller and possibly the SDRAM controller on i.MX35 seems to
> be different from i.MX31).
>
>
> Regards, Magnus
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4] board support patch for phyCORE-MPC5200B-tiny

2009-03-30 Thread Anatolij Gustschin

Jon Smirl wrote:
> On Sun, Mar 29, 2009 at 10:08 AM, Markus Rathgeb
>  wrote:
>> Hi!
>>
>> Have you read the BIOSEMU stuff in the mailing list?
>> Can you adjust the PCI section and perhaps you can include the video
>> example (set undef video).
> 
> I have v1 of the pcm030 hardware and the baseboard doesn't have a PCI slot.
> 
> I looked at some of your older emails. It looks like the framebuffer
> is not accessible. You are hanging on a write to the PCI bus.
> 
> Forget about running the video BIOS initially, just use the memory
> commands from u-boot to make sure you can read and write the
> framebuffer.

No, memory access to frame buffer will only work after the SD-RAM
controller of the GPU is properly initialized. Video BIOS is supposed
to do this among other things. As the boot log showed, video memory
size was not recognized by the radeon driver which indicates that
the video BIOS run failed to initialize the graphic chip and memory
controller. Fixing the XLB Initiator Window configuration for bus
PCI IO space starting at 0x seemed to solve problems with
video BIOS run.

Best regards,
Anatolij

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] OMAP3: Update Overo pin mux for new expansion board

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

On 15:29 Mon 30 Mar , Dirk Behme wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 20:00 Mon 16 Mar , Dirk Behme wrote:
>>> A new Overo expansion board uses GPIO 14, 21, 22 and 23 for LED's and
>>> switches. This patch changes the pinmux configuration for those pins.
>>> They were previously set up for unused MMC3_DAT4-7.
>>>
>>> Signed-off-by: Steve Sakoman 
>>> ---
>>>
>>> Patch is against recent mainline commit
>>> 'b3dd629e78870ba2dc9f8032978721c0fa02a856'
>>> "Prepare 2009.03-rc2"
>> sorry NACK
>>
>> Please send it correctly because git am will take the information from the
>> email Hearder and I do not want to fix it manually
>
> Hmm, I sent this patch the same way I did with the other patches. And I 
> can't see anything obviously wrong. Please give some details what you 
> think might be wrong with this patch (header?).
Based on the patch info your not the Author of the patch so it must be the
same in the Mail Header info

Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] ARM Pull Request

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

On 15:33 Mon 30 Mar , Dirk Behme wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> Hi Wolfgang,
>>
>> Please pull
>> The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b:
>>   Wolfgang Denk (1):
>> VCMA9: fix compile errors
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-arm.git master
>>
>> Jean-Christophe PLAGNIOL-VILLARD (19):
>>   s3c4510b: move specific code to soc directory
>>   s3c44b0: move i2c driver to drivers/i2c
>>   s3c44b0: move rtc driver to drivers/rtc
>>   s3c44b0: move serial driver to drivers/serial
>>   s3c44b0: extract cache from cpu.c
>>   sa1100: move serial driver to drivers/serial
>>   netarm: move serial driver to drivers/serial
>>   imx31: move serial driver to drivers/serial
>>   s3c64xx: move usb driver to drivers/usb
>>   ks8695: move serial driver to drivers/serial
>>   lpc2292: move serial driver to drivers/serial
>>   arm720t/clps7111: move serial driver to drivers/serial
>>   omap3: remove duplicate interrupts code
>
> This patch isn't finally reviewed
>
> http://lists.denx.de/pipermail/u-boot/2009-March/049762.html
>
> Please remove it from the pull request until everybody agreed
this duplicated code so I'll remove it anyway I do not want duplicated code
>
>>   imx: move serial driver to drivers/serial
>>   davinci: move nand driver to drivers/mtd/nand
>>   davinci: move i2c driver to drivers/i2c
>>   s3c24x0: move serial driver to drivers/serial
>>   s3c24x0: move i2c driver to drivers/i2c
>>   s3c2410: move nand driver to drivers/mtd/nand
>
> It seems to me that
>
> http://lists.denx.de/pipermail/u-boot/2009-March/049662.html
This one is NACK 
>
> is unanswered. Therefore again:
>
> What's about
>
> http://lists.denx.de/pipermail/u-boot/2009-March/049146.html
>
> ?
I'm not statisfy about this one I'm looking on an other implementation
so this patch will wait a few more days

Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] What to do for a working BIOSEMU and ATI_RADEON_FB environment?

2009-03-30 Thread Anatolij Gustschin

Markus Rathgeb wrote:

> -#define CONFIG_SYS_MONITOR_LEN (192 << 10) /* Reserve 192 kB for Monitor   */
> -#define CONFIG_SYS_MALLOC_LEN (128 << 10) /* Reserve 128 kB for malloc()  */
> +#define CONFIG_SYS_MONITOR_LEN (1024 << 10) /* Reserve 1024 kB for Monitor   
> */
> +#define CONFIG_SYS_MALLOC_LEN (1024 << 10) /* Reserve 1024 kB for malloc()  
> */

> I changed also CONFIG_SYS_MONITOR_LEN and CONFIG_SYS_MALLOC_LEN.
> I do not know, what are the minimum values that are working.
> But 128 and 256 for CONFIG_SYS_MALLOC_LEN are to small and with the
> above values it is working - so it is okay for me.

CONFIG_SYS_MONITOR_LEN could probably be 384 kB or 512 kB. It
depends on included (configured) drivers and U-Boot commands.
1024 kB is too big here, i think. 1024 kB for CONFIG_SYS_MALLOC_LEN
is OK.

> Where can I read more about that options (and the options for video)?
> Are there documentations or should I read the source code (that is no
> problem, but it will be cost a lot of time)?

u-boot/README contains a description of these options. Video
related options are described there too. README also describes
"videomode" U-Boot environment variable for selection of display
resolution and color depth.

Best regards,
Anatolij
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 13/19] omap3: remove duplicate interrupts code

2009-03-30 Thread Dirk Behme

Dear Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD 
> ---
>  cpu/arm_cortexa8/omap3/interrupts.c |  128 
> ---
>  1 files changed, 0 insertions(+), 128 deletions(-)

It seems to me that this patch is a re-post of

http://lists.denx.de/pipermail/u-boot/2009-March/049736.html

?

If this is the case, it would be helpful if you could mark re-send 
patches with 'v2' or something similar, explain what changed (or 
what's unchanged) and that the previous patch is obsolete with the 
re-post.

Dirk

Btw.: A description in the body of a patch (and not subject only) 
going into git would be nice, too. E.g.

"Remove interrupt code which is already in xxx and therefore not 
needed here"

> diff --git a/cpu/arm_cortexa8/omap3/interrupts.c 
> b/cpu/arm_cortexa8/omap3/interrupts.c
> index 9e9817d..384ffdc 100644
> --- a/cpu/arm_cortexa8/omap3/interrupts.c
> +++ b/cpu/arm_cortexa8/omap3/interrupts.c
> @@ -34,137 +34,9 @@
>  
>  #include 
>  #include 
> -#include 
>  
>  #define TIMER_LOAD_VAL 0
>  
> -#ifdef CONFIG_USE_IRQ
> -/* enable IRQ interrupts */
> -void enable_interrupts(void)
> -{
> - unsigned long temp;
> - __asm__ __volatile__("mrs %0, cpsr\n"
> -  "bic %0, %0, #0x80\n" "msr cpsr_c, %0":"=r"(temp)
> -  ::"memory");
> -}
> -
> -/*
> - * disable IRQ/FIQ interrupts
> - * returns true if interrupts had been enabled before we disabled them
> - */
> -int disable_interrupts(void)
> -{
> - unsigned long old, temp;
> - __asm__ __volatile__("mrs %0, cpsr\n"
> -  "orr %1, %0, #0xc0\n"
> -  "msr cpsr_c, %1":"=r"(old), "=r"(temp)
> -  ::"memory");
> - return (old & 0x80) == 0;
> -}
> -#else
> -void enable_interrupts(void)
> -{
> - return;
> -}
> -int disable_interrupts(void)
> -{
> - return 0;
> -}
> -#endif
> -
> -void bad_mode(void)
> -{
> - panic("Resetting CPU ...\n");
> - reset_cpu(0);
> -}
> -
> -void show_regs(struct pt_regs *regs)
> -{
> - unsigned long flags;
> - const char *processor_modes[] = {
> - "USER_26", "FIQ_26", "IRQ_26", "SVC_26",
> - "UK4_26", "UK5_26", "UK6_26", "UK7_26",
> - "UK8_26", "UK9_26", "UK10_26", "UK11_26",
> - "UK12_26", "UK13_26", "UK14_26", "UK15_26",
> - "USER_32", "FIQ_32", "IRQ_32", "SVC_32",
> - "UK4_32", "UK5_32", "UK6_32", "ABT_32",
> - "UK8_32", "UK9_32", "UK10_32", "UND_32",
> - "UK12_32", "UK13_32", "UK14_32", "SYS_32",
> - };
> -
> - flags = condition_codes(regs);
> -
> - printf("pc : [<%08lx>]lr : [<%08lx>]\n"
> - "sp : %08lx  ip : %08lx  fp : %08lx\n",
> - instruction_pointer(regs),
> - regs->ARM_lr, regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
> - printf("r10: %08lx  r9 : %08lx  r8 : %08lx\n",
> - regs->ARM_r10, regs->ARM_r9, regs->ARM_r8);
> - printf("r7 : %08lx  r6 : %08lx  r5 : %08lx  r4 : %08lx\n",
> - regs->ARM_r7, regs->ARM_r6, regs->ARM_r5, regs->ARM_r4);
> - printf("r3 : %08lx  r2 : %08lx  r1 : %08lx  r0 : %08lx\n",
> - regs->ARM_r3, regs->ARM_r2, regs->ARM_r1, regs->ARM_r0);
> - printf("Flags: %c%c%c%c",
> - flags & CC_N_BIT ? 'N' : 'n',
> - flags & CC_Z_BIT ? 'Z' : 'z',
> - flags & CC_C_BIT ? 'C' : 'c', flags & CC_V_BIT ? 'V' : 'v');
> - printf("  IRQs %s  FIQs %s  Mode %s%s\n",
> - interrupts_enabled(regs) ? "on" : "off",
> - fast_interrupts_enabled(regs) ? "on" : "off",
> - processor_modes[processor_mode(regs)],
> - thumb_mode(regs) ? " (T)" : "");
> -}
> -
> -void do_undefined_instruction(struct pt_regs *pt_regs)
> -{
> - printf("undefined instruction\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_software_interrupt(struct pt_regs *pt_regs)
> -{
> - printf("software interrupt\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_prefetch_abort(struct pt_regs *pt_regs)
> -{
> - printf("prefetch abort\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_data_abort(struct pt_regs *pt_regs)
> -{
> - printf("data abort\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_not_used(struct pt_regs *pt_regs)
> -{
> - printf("not used\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_fiq(struct pt_regs *pt_regs)
> -{
> - printf("fast interrupt request\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -void do_irq(struct pt_regs *pt_regs)
> -{
> - printf("interrupt request\n");
> - show_regs(pt_regs);
> - bad_mode();
> -}
> -
> -
>  static ulong timestamp;
>  static ulong lastinc;
>  static gptimer_t *timer_base = (gptimer_t *)CONFIG_SYS_TIMERBASE;

__

Re: [U-Boot] ARM Pull Request

2009-03-30 Thread Dirk Behme

Jean-Christophe PLAGNIOL-VILLARD wrote:
> Hi Wolfgang,
> 
> Please pull
> The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b:
>   Wolfgang Denk (1):
> VCMA9: fix compile errors
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-arm.git master
> 
> Jean-Christophe PLAGNIOL-VILLARD (19):
>   s3c4510b: move specific code to soc directory
>   s3c44b0: move i2c driver to drivers/i2c
>   s3c44b0: move rtc driver to drivers/rtc
>   s3c44b0: move serial driver to drivers/serial
>   s3c44b0: extract cache from cpu.c
>   sa1100: move serial driver to drivers/serial
>   netarm: move serial driver to drivers/serial
>   imx31: move serial driver to drivers/serial
>   s3c64xx: move usb driver to drivers/usb
>   ks8695: move serial driver to drivers/serial
>   lpc2292: move serial driver to drivers/serial
>   arm720t/clps7111: move serial driver to drivers/serial
>   omap3: remove duplicate interrupts code

This patch isn't finally reviewed

http://lists.denx.de/pipermail/u-boot/2009-March/049762.html

Please remove it from the pull request until everybody agreed.

>   imx: move serial driver to drivers/serial
>   davinci: move nand driver to drivers/mtd/nand
>   davinci: move i2c driver to drivers/i2c
>   s3c24x0: move serial driver to drivers/serial
>   s3c24x0: move i2c driver to drivers/i2c
>   s3c2410: move nand driver to drivers/mtd/nand

It seems to me that

http://lists.denx.de/pipermail/u-boot/2009-March/049662.html

is unanswered. Therefore again:

What's about

http://lists.denx.de/pipermail/u-boot/2009-March/049146.html

?

Dirk

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] OMAP3: Update Overo pin mux for new expansion board

2009-03-30 Thread Dirk Behme

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 20:00 Mon 16 Mar , Dirk Behme wrote:
>> A new Overo expansion board uses GPIO 14, 21, 22 and 23 for LED's and
>> switches. This patch changes the pinmux configuration for those pins.
>> They were previously set up for unused MMC3_DAT4-7.
>>
>> Signed-off-by: Steve Sakoman 
>> ---
>>
>> Patch is against recent mainline commit
>> 'b3dd629e78870ba2dc9f8032978721c0fa02a856'
>> "Prepare 2009.03-rc2"
> sorry NACK
> 
> Please send it correctly because git am will take the information from the
> email Hearder and I do not want to fix it manually

Hmm, I sent this patch the same way I did with the other patches. And 
I can't see anything obviously wrong. Please give some details what 
you think might be wrong with this patch (header?).

Dirk
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Add "source" command; prepare removal of "autoscr" command

2009-03-30 Thread Peter Tyser

The changes look good to me.  2 comments below:

> +/*
> + * Keep for now for backward compatibility;
> + * remove later when support for "autoscr" goes away.
> + */
> +U_BOOT_CMD(
> + autoscr, 2, 0,  do_source,
> + "run script from memory",
> + "[addr] - run script starting at addr"
> + " - A valid image header must be present\n"
> +#if defined(CONFIG_FIT)
> + "For FIT format uImage addr must include subimage\n"
> + "unit name in the form of addr:\n"
> +#endif
> +);

I'd vote to change autoscr's help messages to something letting end
user's know that the command is deprecated and being replaced by the
"source".  Eg something like:

+ autoscr, 2, 0, do_source,
+ "DEPRECATED - see 'source' command",
+ "DEPRECATED - see 'source' command"

Most U-Boot user's are more likely to see this than the
feature-removal-schedule.txt in the source code.

> +#endif
> diff --git a/doc/feature-removal-schedule.txt 
> b/doc/feature-removal-schedule.txt
> index 9ba7a04..cd429a4 100644
> --- a/doc/feature-removal-schedule.txt
> +++ b/doc/feature-removal-schedule.txt
> @@ -8,12 +8,20 @@ file.
>  ---
>  
>  What:"autoscr" command
> -When:August 2009
> -Why: "autosrc" is an ugly and completely non-standard name.  The "autoscr"
> - command is deprecated and will be replaced the "source" command as
> - used by other shells such as bash.  Both commands will be supported
> - for a transition period of 6 months after which "autoscr" will be
> - removed.
> +When:Release 2009-09
> +
> +Why: "autosrc" is an ugly and completely non-standard name.
> +The "autoscr" command is deprecated and will be replaced by
> +

There's an out of place newline here.

> +the "source" command as used by other shells such as bash.
> +
> +Starting with March 2009, both commands will be supported for
> +a transition period of 6 months after which "autoscr" will be
> +removed. During the transition period existing scripts and
> +environment variable names remain untouched for maximum
> +compatibiltiy; thse will be changed when support for the
> +"autoscr" command get's finally dropped.

s/compatibiltiy/compatibility/ s/thse/these/ and s/get's finally/finally
gets/

Best,
Peter

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-03-30 Thread Michael Zaidman

Hello Heiko,

Please see my comments and updated patch below.

On Mon, Mar 30, 2009 at 7:12 AM, Heiko Schocher  wrote:
> Hello Michael,
>
> Michael Zaidman wrote:
>> Hi Heiko,
>>
>> The patch "netloop: speed up NetLoop" you delivered
>> into the u-boot-2009.03 introduced bug I have described
>> below a few days ago. Could you please take a look at
>> the proposed fix?
>>
>
> Sorry, seems I missed it.
>
>> Thanks,
>> Michael
>>
>> -- Forwarded message --
>> From: Michael Zaidman 
>> Date: Sun, Mar 22, 2009 at 8:35 PM
>> Subject: [U-Boot] [PATCH] NetLoop initialization bug
>> To: u-boot@lists.denx.de
>>
>>
>> [U-Boot] [PATCH] NetLoop initialization bug
>>
>
> Thanks for catching this.
> Your patch doesn;t apply, I get "malformed patch". Before
> sending a new one, please have a look at my comments:
>
>>
>>
>> Upon u-boot's start up the first ping command causes a failure of the
>> consequent TFTP command. It happens in the recently added mechanism of
>> the NetLoop initialization where initialization of global network parameters 
>> is
>> separated in the NetInitLoop routine which is called per env_id change.
>> Thus, ping request will initialize the network parameters necessary for ping
>> operation only, afterwards the env_changed_id will be set to the env_id
>> that will prevent all following initialization requests from other protocols.
>> The problem is that the initialized by ping subset of network parameters is 
>> not
>> sufficient for other protocols and particularly for TFTP
>> which requires the NetServerIp also.
>>
>> Signed-off-by: michael.zaid...@gmail.com
>>
>> diff --git a/net/net.c b/net/net.c
>> index a89f6a0..dc98d0f 100644
>> --- a/net/net.c
>> +++ b/net/net.c
>> @@ -288,64 +288,13 @@ NetInitLoop(proto_t protocol)
>>        if (env_changed_id == env_id)
>>                return 0;
>>
>> -       switch (protocol) {
>> -#if defined(CONFIG_CMD_NFS)
>> -       case NFS:
>> -#endif
>> -#if defined(CONFIG_CMD_PING)
>> -       case PING:
>> -#endif
>> -#if defined(CONFIG_CMD_SNTP)
>> -       case SNTP:
>> -#endif
>> -       case NETCONS:
>> -       case TFTP:
>> -               NetCopyIP(&NetOurIP, &bd->bi_ip_addr);
>> -               NetOurGatewayIP = getenv_IPaddr ("gatewayip");
>> -               NetOurSubnetMask= getenv_IPaddr ("netmask");
>> -               NetOurVLAN = getenv_VLAN("vlan");
>> -               NetOurNativeVLAN = getenv_VLAN("nvlan");
>> +       NetCopyIP(&NetOurIP, &bd->bi_ip_addr);
>> +       NetOurGatewayIP = getenv_IPaddr ("gatewayip");
>> +       NetOurSubnetMask= getenv_IPaddr ("netmask");
>> +       NetServerIP = getenv_IPaddr ("serverip");
>>
>
> The following 2 vars are just used, if CONFIG_CMD_CDP
> is used, can we do a "#if defined" around it?
>> +       NetOurNativeVLAN = getenv_VLAN("nvlan");
>> +       NetOurVLAN = getenv_VLAN("vlan");

These two variables have been initialized in original code for all
protocols supported by u-boot. As I can see, at least the NetOurVLAN
is used by most of them. This was the reason for keeping them in place.

>>
> [...]
>> @@ -443,18 +392,19 @@ restart:
>>                        /* Start with a clean slate... */
>>                        BootpTry = 0;
>>                        NetOurIP = 0;
>> -                       NetServerIP = getenv_IPaddr ("serverip");
>>                        DhcpRequest();          /* Basically same as BOOTP */
>>                        break;
>>  #endif
>>
>>                case BOOTP:
>>                        BootpTry = 0;
>> +                       NetOurIP = 0;
>>
>
> why we need this here?

Generally, for the same reason the DHCP does - "Start with a clean state..."
On the other hand you are right - we do not need to clear the NetOurIP
address for BOOTP, DHCP and RARP because the current implementation
does not check it. So it has been removed in my new patch below.

>
>>                        BootpRequest ();
>>                        break;
>>
>>                case RARP:
>>                        RarpTry = 0;
>> +                       NetOurIP = 0;
>>
> also here?
> Has this to do something with the bugfix?

The same as before.

>
> bye
> Heiko
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>
>


Here is the updated patch:

Subject: [U-Boot] [PATCH] NetLoop initialization bug

---
 net/net.c |   66 +---
 1 files changed, 6 insertions(+), 60 deletions(-)

diff --git a/net/net.c b/net/net.c
index a89f6a0..91ed0d7 100644
--- a/net/net.c
+++ b/net/net.c
@@ -288,64 +288,13 @@ NetInitLoop(proto_t protocol)
if (env_changed_id == env_id)
return 0;

-   switch (protocol) {
-#if defined(CONFIG_CMD_NFS)
-   case NFS:
-#endif
-#if defined(CONFIG_CMD_PING)
-   case PING:
-#endif
-#if defined(CONFIG_CMD_SNTP)
-   case SNTP:
-#endif
-   case NETCONS:
-   case TFTP:
-   NetCopy

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

On 12:43 Mon 30 Mar , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20090330085011.ga21...@game.jcrosoft.org> you wrote:
> >
> > > Hmm.. maybe this should be fixed in Linux too.
> > IMHO no because the double tab was use to align but field of the register
> 
> It doesn't matter what it's being used for when it causes too long
> lines.
but it clearly an import from linux and I do want to be sync so I'll prefer to
not modify it to simplify the update and tacking

I'll send an e-mail to Andrew Victor to known if he is ok to split

Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-30 Thread Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090330085011.ga21...@game.jcrosoft.org> you wrote:
>
> > Hmm.. maybe this should be fixed in Linux too.
> IMHO no because the double tab was use to align but field of the register

It doesn't matter what it's being used for when it causes too long
lines.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Punishment becomes ineffective after a certain point. Men become  in-
sensitive.
-- Eneg, "Patterns of Force", stardate 2534.7
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

> >>> +#ifndef AT91_TWI_H
> >>> +#define AT91_TWI_H
> >>> +
> >>> +#define  AT91_TWI_CR 0x00/* Control Register */
> >>> +#define  AT91_TWI_START  (1 <<  0)   /* Send a Start 
> >>> Condition */
> >>> +#define  AT91_TWI_STOP   (1 <<  1)   /* Send a Stop 
> >>> Condition */
> >>> +#define  AT91_TWI_MSEN   (1 <<  2)   /* Master 
> >>> Transfer Enable */
> >>> +#define  AT91_TWI_MSDIS  (1 <<  3)   /* Master 
> >>> Transfer Disable */
> >>> +#define  AT91_TWI_SVEN   (1 <<  4)   /* Slave 
> >>> Transfer Enable [SAM9260 only] */
> >>> +#define  AT91_TWI_SVDIS  (1 <<  5)   /* Slave 
> >>> Transfer Disable [SAM9260 only] */
> >>> +#define  AT91_TWI_SWRST  (1 <<  7)   /* Software 
> >>> Reset */
> >>>   
> >>  ^^^
> >>  doule tabs breaks line length (this affects for the
> >> whole file)
> >>
> > I'll prefer to keep it as it because it's an import from Linux
> 
> Hmm.. maybe this should be fixed in Linux too.
IMHO no because the double tab was use to align but field of the register

Best Regards,
J.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-03-30 Thread Kazuaki Ichinohe

Hello Denk,

After confirming operation, I'll send sata_dwc.c with cmd_sata.c again.

Regards,
Kazuaki Ichinohe

Wolfgang Denk wrote:
> Dear Kazuaki Ichinohe,
> 
> In message <49cb5f77.1060...@fsi.co.jp> you wrote:
> ...
>>  >Why do you add this 460EX SATA support to cmd_scsi.c? Wouldn't cmd_sata.c 
>> be a
>>  >better place? Or did I miss something here?
>>
>> The cmd_scsi.c which define CONFIG_CMD_SCSI are modified
>> because I want to use scsiboot command of U-BOOT.
> 
> This makes no sense. It is a S-ATA driver, not a SCSI driver, and as
> such it has to be supported in the context of the S-ATA support.
> 
> I explicitly NAK the changes to the SCSI related files.
> 
> Best regards,
> 
> Wolfgang Denk
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-30 Thread Heiko Schocher

Hello Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 07:53 Mon 30 Mar , Heiko Schocher wrote:
>> Hello Jean,
>>
>> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD 
>>> ---
>>>  cpu/arm926ejs/at91/Makefile|6 +
>>>  .../arm926ejs/at91/at91cap9_i2c.c  |   31 ++--
>>>  .../arm926ejs/at91/at91sam9260_i2c.c   |   31 ++--
>>>  .../arm926ejs/at91/at91sam9261_i2c.c   |   31 ++--
>>>  .../arm926ejs/at91/at91sam9263_i2c.c   |   31 ++--
>>>  .../clk.h => cpu/arm926ejs/at91/at91sam9rl_i2c.c   |   37 ++--
>>>  drivers/i2c/Makefile   |1 +
>>>  drivers/i2c/atmel_i2c.c|  234 
>>> 
>>>  include/asm-arm/arch-at91/at91_common.h|2 +
>>>  include/asm-arm/arch-at91/at91_twi.h   |   68 ++
>>>  include/asm-arm/arch-at91/clk.h|4 +
>>>  include/asm-arm/arch-at91/hardware.h   |5 +
>>>  12 files changed, 405 insertions(+), 76 deletions(-)
>>>  copy include/asm-arm/arch-at91/at91_common.h => 
>>> cpu/arm926ejs/at91/at91cap9_i2c.c (61%)
>>>  copy include/asm-arm/arch-at91/at91_common.h => 
>>> cpu/arm926ejs/at91/at91sam9260_i2c.c (61%)
>>>  copy include/asm-arm/arch-at91/at91_common.h => 
>>> cpu/arm926ejs/at91/at91sam9261_i2c.c (61%)
>>>  copy include/asm-arm/arch-at91/at91_common.h => 
>>> cpu/arm926ejs/at91/at91sam9263_i2c.c (61%)
>>>  copy include/asm-arm/arch-at91/clk.h => 
>>> cpu/arm926ejs/at91/at91sam9rl_i2c.c (52%)
>>>  create mode 100644 drivers/i2c/atmel_i2c.c
>>>  create mode 100644 include/asm-arm/arch-at91/at91_twi.h
>>>
>>>   
>> [...]
>>> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
>>> index 9c74657..27a5251 100644
>>> --- a/drivers/i2c/Makefile
>>> +++ b/drivers/i2c/Makefile
>>> @@ -25,6 +25,7 @@ include $(TOPDIR)/config.mk
>>>  
>>>  LIB:= $(obj)libi2c.a
>>>  
>>> +COBJS-$(CONFIG_I2C_ATMEL) += atmel_i2c.o
>>>  COBJS-$(CONFIG_BFIN_TWI_I2C) += bfin-twi_i2c.o
>>>  COBJS-$(CONFIG_FSL_I2C) += fsl_i2c.o
>>>  COBJS-$(CONFIG_I2C_MXC) += mxc_i2c.o
>>>   
>> Independent from your patch, I think we need here a common
>> rule. Either we name in future this define "CONFIG_I2C_XXX"
>> or "CONFIG_XXX_I2C. I vote for using "CONFIG_I2C_XXX"
> it's plan to clean up the driver CONFIG_ just before send the Kconfig patch
> series

Ah, ok, thanks.

>>> + *
>>> +*/
>>> +#include 
>>> +
>>> +#ifdef CONFIG_HARD_I2C
>>>   
>> Why not "#if defined(CONFIG_I2C_ATMEL)" as in the Makefile?
> until the Kconfig I'll prefer to keep the CONFIG_HARD_I2C

ok.

>>> +
>>> +#include 
>>> +#include 
>>>   
>> [...]
>>> +   if (alen > 1)
>>> +   return 1;
>>> +   /* XXX assume an ATMEL AT24C16 */

[...]

>>> diff --git a/include/asm-arm/arch-at91/at91_twi.h 
>>> b/include/asm-arm/arch-at91/at91_twi.h
>>> new file mode 100644
>>> index 000..bb2880f
>>> --- /dev/null
>>> +++ b/include/asm-arm/arch-at91/at91_twi.h
>>> @@ -0,0 +1,68 @@
>>> +/*
>>> + * arch/arm/mach-at91/include/mach/at91_twi.h
>>> + *
>>> + * Copyright (C) 2005 Ivan Kokshaysky
>>> + * Copyright (C) SAN People
>>> + *
>>> + * Two-wire Interface (TWI) registers.
>>> + * Based on AT91RM9200 datasheet revision E.
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License as published by
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + */
>>> +
>>> +#ifndef AT91_TWI_H
>>> +#define AT91_TWI_H
>>> +
>>> +#defineAT91_TWI_CR 0x00/* Control Register */
>>> +#defineAT91_TWI_START  (1 <<  0)   /* Send a Start 
>>> Condition */
>>> +#defineAT91_TWI_STOP   (1 <<  1)   /* Send a Stop 
>>> Condition */
>>> +#defineAT91_TWI_MSEN   (1 <<  2)   /* Master 
>>> Transfer Enable */
>>> +#defineAT91_TWI_MSDIS  (1 <<  3)   /* Master 
>>> Transfer Disable */
>>> +#defineAT91_TWI_SVEN   (1 <<  4)   /* Slave 
>>> Transfer Enable [SAM9260 only] */
>>> +#defineAT91_TWI_SVDIS  (1 <<  5)   /* Slave 
>>> Transfer Disable [SAM9260 only] */
>>> +#defineAT91_TWI_SWRST  (1 <<  7)   /* Software 
>>> Reset */
>>>   
>>  ^^^
>>  doule tabs breaks line length (this affects for the
>> whole file)
>>
> I'll prefer to keep it as it because it's an import from Linux

Hmm.. maybe this should be fixed in Linux too.

bye
Heiko
-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 5/5] inka4x0: Use proper accessor macros for memory mapped registers.

2009-03-30 Thread Wolfgang Denk

Dear Detlev Zundel,

In message <1238365896-20271-6-git-send-email-...@denx.de> you wrote:
> Signed-off-by: Detlev Zundel 
> ---
>  board/inka4x0/inka4x0.c |  139 
> +--
>  1 files changed, 75 insertions(+), 64 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Was heißt Windows auf Indianisch? - "Weißer  Mann,  der  auf  Sanduhr
wartet!"
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 3/5] inka4x0: Add hardware diagnosis functions for inka4x0

2009-03-30 Thread Wolfgang Denk

Dear Detlev Zundel,

In message <1238365896-20271-4-git-send-email-...@denx.de> you wrote:
> This patch adds advanced diagnosis functions for the inka4x0 board.
> 
> Signed-off-by: Andreas Pfefferle 
> Signed-off-by: Detlev Zundel 
> ---
>  board/inka4x0/Makefile|4 +-
>  board/inka4x0/inka4x0.c   |   20 ++-
>  board/inka4x0/inkadiag.c  |  514 
> +
>  include/configs/inka4x0.h |1 +
>  include/ns16550.h |   11 +
>  5 files changed, 546 insertions(+), 4 deletions(-)
>  create mode 100644 board/inka4x0/inkadiag.c

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
"Wagner's music is better than it sounds."   - Mark Twain
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 1/5] drivers/twserial: Add protocol driver for "three wire serial" interface.

2009-03-30 Thread Wolfgang Denk

Dear Detlev Zundel,

In message <1238365896-20271-2-git-send-email-...@denx.de> you wrote:
> This pretty unintelligent interface is used on some RTC chips.
> 
> Signed-off-by: Detlev Zundel 
> ---
>  Makefile|3 +-
>  drivers/twserial/Makefile   |   46 ++
>  drivers/twserial/soft_tws.c |  111 
> +++
>  include/tws.h   |   38 +++
>  4 files changed, 197 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/twserial/Makefile
>  create mode 100644 drivers/twserial/soft_tws.c
>  create mode 100644 include/tws.h

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
What can it profit a man to gain the whole world and to come  to  his
property with a gastric ulcer, a blown prostate, and bifocals?
 -- John Steinbeck, _Cannery Row_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 4/5] inka4x0: Add hardware diagnosis and RTC in configuration.

2009-03-30 Thread Wolfgang Denk

Dear Detlev Zundel,

In message <1238365896-20271-5-git-send-email-...@denx.de> you wrote:
> This patch adds the board specific communication routines needed by
> the external 4543 RTC.
> 
> Signed-off-by: Detlev Zundel 
> Signed-off-by: Andreas Pfefferle 
> ---
>  board/inka4x0/inka4x0.c   |   20 ++
>  include/configs/inka4x0.h |   90 ++--
>  2 files changed, 105 insertions(+), 5 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Quote from the Boss after overriding the decision of a task force  he
created  to  find  a  solution:  "I'm  sorry  if  I ever gave you the
impression your input would have any effect on my  decision  for  the
outcome of this project!"
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 2/5] rtc: add support for 4543 RTC (manufactured by e.g. EPSON)

2009-03-30 Thread Wolfgang Denk

Dear Detlev Zundel,

In message <1238365896-20271-3-git-send-email-...@denx.de> you wrote:
> Signed-off-by: Detlev Zundel 
> Signed-off-by: Andreas Pfefferle 
> ---
>  drivers/rtc/Makefile  |1 +
>  drivers/rtc/rtc4543.c |  118 
> +
>  include/rtc.h |4 ++
>  3 files changed, 123 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/rtc/rtc4543.c

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A secure program has to be robust: it  must  be  able  to  deal  with
conditions  that "can't happen", whether user input, program error or
library/etc. This is basic damage  control.  Buffer  overflow  errors
have nothing to do with security, but everything with stupidity.
 -- Wietse Venema in <5cnqm3$...@spike.porcupine.org>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

2009-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD

On 07:53 Mon 30 Mar , Heiko Schocher wrote:
> Hello Jean,
> 
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD 
> > ---
> >  cpu/arm926ejs/at91/Makefile|6 +
> >  .../arm926ejs/at91/at91cap9_i2c.c  |   31 ++--
> >  .../arm926ejs/at91/at91sam9260_i2c.c   |   31 ++--
> >  .../arm926ejs/at91/at91sam9261_i2c.c   |   31 ++--
> >  .../arm926ejs/at91/at91sam9263_i2c.c   |   31 ++--
> >  .../clk.h => cpu/arm926ejs/at91/at91sam9rl_i2c.c   |   37 ++--
> >  drivers/i2c/Makefile   |1 +
> >  drivers/i2c/atmel_i2c.c|  234 
> > 
> >  include/asm-arm/arch-at91/at91_common.h|2 +
> >  include/asm-arm/arch-at91/at91_twi.h   |   68 ++
> >  include/asm-arm/arch-at91/clk.h|4 +
> >  include/asm-arm/arch-at91/hardware.h   |5 +
> >  12 files changed, 405 insertions(+), 76 deletions(-)
> >  copy include/asm-arm/arch-at91/at91_common.h => 
> > cpu/arm926ejs/at91/at91cap9_i2c.c (61%)
> >  copy include/asm-arm/arch-at91/at91_common.h => 
> > cpu/arm926ejs/at91/at91sam9260_i2c.c (61%)
> >  copy include/asm-arm/arch-at91/at91_common.h => 
> > cpu/arm926ejs/at91/at91sam9261_i2c.c (61%)
> >  copy include/asm-arm/arch-at91/at91_common.h => 
> > cpu/arm926ejs/at91/at91sam9263_i2c.c (61%)
> >  copy include/asm-arm/arch-at91/clk.h => 
> > cpu/arm926ejs/at91/at91sam9rl_i2c.c (52%)
> >  create mode 100644 drivers/i2c/atmel_i2c.c
> >  create mode 100644 include/asm-arm/arch-at91/at91_twi.h
> >
> >   
> [...]
> > diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
> > index 9c74657..27a5251 100644
> > --- a/drivers/i2c/Makefile
> > +++ b/drivers/i2c/Makefile
> > @@ -25,6 +25,7 @@ include $(TOPDIR)/config.mk
> >  
> >  LIB:= $(obj)libi2c.a
> >  
> > +COBJS-$(CONFIG_I2C_ATMEL) += atmel_i2c.o
> >  COBJS-$(CONFIG_BFIN_TWI_I2C) += bfin-twi_i2c.o
> >  COBJS-$(CONFIG_FSL_I2C) += fsl_i2c.o
> >  COBJS-$(CONFIG_I2C_MXC) += mxc_i2c.o
> >   
> 
> Independent from your patch, I think we need here a common
> rule. Either we name in future this define "CONFIG_I2C_XXX"
> or "CONFIG_XXX_I2C. I vote for using "CONFIG_I2C_XXX"
it's plan to clean up the driver CONFIG_ just before send the Kconfig patch
series

> > + *
> > +*/
> > +#include 
> > +
> > +#ifdef CONFIG_HARD_I2C
> >   
> 
> Why not "#if defined(CONFIG_I2C_ATMEL)" as in the Makefile?
until the Kconfig I'll prefer to keep the CONFIG_HARD_I2C
> 
> > +
> > +#include 
> > +#include 
> >   
> [...]
> > +   if (alen > 1)
> > +   return 1;
> > +   /* XXX assume an ATMEL AT24C16 */
> > +   if (alen == 1) {
> > +#if 0 /* EEPROM code already sets this correctly */
> > +   chip |= (addr >> 8) & 0xff;
> > +#endif
> >   
> 
> please remove dead code.
> 
> > +   addr = addr & 0xff;
> > +   }
> > +#endif
> > +   return at91_xfer(chip, addr, alen, buffer, len, 1);
> > +}
> > +
> > +int
> > +i2c_write(unsigned char chip, unsigned int addr, int alen,
> > + unsigned char *buffer, int len)
> > +{
> > +#ifdef CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW
> > +   int i;
> > +   unsigned char *buf;
> > +
> > +   /* we only allow one address byte */
> > +   if (alen > 1)
> > +   return 1;
> > +   /* XXX assume an ATMEL AT24C16 */
> > +   if (alen == 1) {
> > +   buf = buffer;
> > +   /* do single byte writes */
> > +   for (i = 0; i < len; i++) {
> > +#if 0 /* EEPROM code already sets this correctly */
> > +   chip |= (addr >> 8) & 0xff;
> > +#endif
> >   
> 
> here too, please remove dead code.
> 
> > +   addr = addr & 0xff;
> > +   if (at91_xfer(chip, addr, alen, buf++, 1, 0))
> > +   return 1;
> > +   addr++;
> > +   }
> > +   return 0;
> >   
> [...]
> > diff --git a/include/asm-arm/arch-at91/at91_twi.h 
> > b/include/asm-arm/arch-at91/at91_twi.h
> > new file mode 100644
> > index 000..bb2880f
> > --- /dev/null
> > +++ b/include/asm-arm/arch-at91/at91_twi.h
> > @@ -0,0 +1,68 @@
> > +/*
> > + * arch/arm/mach-at91/include/mach/at91_twi.h
> > + *
> > + * Copyright (C) 2005 Ivan Kokshaysky
> > + * Copyright (C) SAN People
> > + *
> > + * Two-wire Interface (TWI) registers.
> > + * Based on AT91RM9200 datasheet revision E.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> > +
> > +#ifndef AT91_TWI_H
> > +#define AT91_TWI_H
> > +
> > +#defineAT91_TWI_CR 0x00/* Control Register */
> > +#defineAT91_TWI_START  (1 <<  0)   /* Send a Start 
> > Condition */
> > +#defineAT91_TWI_STOP   (1

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-03-30 Thread Wolfgang Denk

Dear Heiko,

In message <49d054ba.1060...@denx.de> you wrote:
> 
> The following 2 vars are just used, if CONFIG_CMD_CDP
> is used, can we do a "#if defined" around it?
> > +   NetOurNativeVLAN = getenv_VLAN("nvlan");
> > +   NetOurVLAN = getenv_VLAN("vlan");

We probably could, but we then had to do this in several places, and
the code would become less readable, I think.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Q:  How many DEC repairman does it take to fix a flat ?
A:  Five; four to hold the car up and one to swap tires.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch] soft_i2c.c compiler/linker error

2009-03-30 Thread Jens Scharsig

Heiko Schocher schrieb:
> Hello Jean-Christophe
> 
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 11:31 Fri 27 Mar , Jens Scharsig wrote:
>>   
>>> This patch fix the compiler/linker errors
>>>
>>> common/cmd_i2c.c:1252: undefined reference to `i2c_get_bus_speed'
>>> common/cmd_i2c.c:1256: undefined reference to `i2c_set_bus_speed'
>>>
>>> if board use CONFIG_I2C_CMD_TREE and CONFIG_I2C_MULTI_BUS is not uesd/undef
>>>
>>> Signed-off-by: Jens Scharsig 
>>> 
>> NACK
>>
>> you must implement it
>>   
> 
> It is implemented in the driver, but not activated, because
> wrong define order ... I think this patch is OK.
> 
> bye
> Heiko
> 
Thanks for the confirmation. That was my thought. Only my description was bad 
or not completely.

regards Jens

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [Patch V2] soft_i2c.c compiler/linker error

2009-03-30 Thread Jens Scharsig

This patch fix the compiler/linker errors 

common/cmd_i2c.c:1252: undefined reference to `i2c_get_bus_speed'
common/cmd_i2c.c:1256: undefined reference to `i2c_set_bus_speed'

if board use CONFIG_I2C_CMD_TREE and CONFIG_I2C_MULTI_BUS is not uesd/undef 
(wrong define order)

and 

removes additional empty lines

Signed-off-by: Jens Scharsig 
--- 

diff --git a/drivers/i2c/soft_i2c.c b/drivers/i2c/soft_i2c.c
index ed5f5b2..185634d 100644
--- a/drivers/i2c/soft_i2c.c
+++ b/drivers/i2c/soft_i2c.c
@@ -51,14 +51,12 @@
 DECLARE_GLOBAL_DATA_PTR;
 #endif
 
-
 /*---
  * Definitions
  */
 
 #define RETRIES0
 
-
 #define I2C_ACK0   /* PD_SDA level to ack a byte */
 #define I2C_NOACK  1   /* PD_SDA level to noack a byte */
 
@@ -154,7 +152,6 @@ static void send_stop(void)
I2C_TRISTATE;
 }
 
-
 /*---
  * ack should be I2C_ACK or I2C_NOACK
  */
@@ -174,7 +171,6 @@ static void send_ack(int ack)
I2C_DELAY;
 }
 
-
 /*---
  * Send 8 bits and look for an acknowledgement.
  */
@@ -246,6 +242,7 @@ int i2c_set_bus_num(unsigned int bus)
 #endif
return 0;
 }
+#endif
 
 /* TODO: add 100/400k switching */
 unsigned int i2c_get_bus_speed(void)
@@ -260,7 +257,6 @@ int i2c_set_bus_speed(unsigned int speed)
 
return 0;
 }
-#endif
 
 /*---
  * if ack == I2C_ACK, ACK the byte so can continue reading, else

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

69 matches

Mail list logo