Re: [U-Boot] [PATCH v5] zlib: updated to v.1.2.3
Dear Giuseppe CONDORELLI, In message 1248869108-15570-1-git-send-email-giuseppe.condore...@st.com you wrote: This patch updates zlib to the latest stable version. Only relevant zlib parts were ported to u-boot tree, as already did for the current zlib (0.95). New zlib guarantees a faster inflate performances other then others improvements as explained at www.zlib.net. It also includes Alessandro Rubini's patches to allow 0 as destination pointer and to call watchdog reset if required by architecture. Signed-off-by: Giuseppe Condorelli giuseppe.condore...@st.com Reviewed-by: Angelo Castello angelo.caste...@st.com Reviewed-by: Alessandro Rubini rubini-l...@gnudd.com --- include/u-boot/zlib.h | 718 ++--- lib_generic/zlib.c| 3933 + 2 files changed, 2466 insertions(+), 2185 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Crash programs fail because they are based on the theory that, with nine women pregnant, you can get a baby a month. - Wernher von Braun ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-mpc85xx - master branch
Dear Kumar Gala, In message pine.lnx.4.64.0908101646200.22...@localhost.localdomain you wrote: The following changes since commit eb1a4d0a471505c169bef19a73a60f8641f0b875: Wolfgang Denk (1): Prepare 2009.08-rc2 are available in the git repository at: git://git.denx.de/u-boot-mpc85xx.git master Kumar Gala (1): 85xx: Removed BEDBUG support from FSL 85xx boards include/configs/MPC8536DS.h |1 - include/configs/MPC8544DS.h |1 - include/configs/MPC8572DS.h |1 - include/configs/P2020DS.h |1 - 4 files changed, 0 insertions(+), 4 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If you believe that feeling bad or worrying long enough will change a past or future event, then you are residing on another planet with a different reality system. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] PPC460EX with 2 Ethernet Tranceivers
On Tuesday 11 August 2009 16:44:52 Judd Gilbert wrote: I am currently running linux 2.6.28.4 on a PPC460EX with 2 Marvell Alaska 88E Ethernet transceivers connected to it. I've added the flags I believe to configure u-boot properly: #define CONFIG_IBM_EMAC4_V4 1 #define CONFIG_HAS_ETH0 #define CONFIG_HAS_ETH1 /* Based on the marvell phy datasheet for obscure details */ #define CONFIG_PHY_ADDR 1 /* PHY address, See schematics */ #define CONFIG_PHY1_ADDR2 /* 2nd PHY address. See schematics */ #define CONFIG_PHY_RESET1 /* reset phy upon startup */ #define CONFIG_PHY_GIGE 1 /* Include GbE speed/duplex detection */ #define CONFIG_PHY_DYNAMIC_ANEG 1 If I hold one the 2nd transceiver (address 2) in reset on power up, (just for a second or so) the linux kernel boots, detects both PHYs, and eth0 and eth1 both work fine. I'm holding the chip in reset manually with a switch I added to the board. The linux kernel spits the following information out on success: eth0: EMAC-0 /plb/opb/ether...@ef600e00, MAC 00:13:a8:00:0d:c6 eth0: found Generic MII PHY (0x00) Is this really PHY address 0? Above you configured the PHY for EMAC0 to address 1. What does mii info show? Best regards, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Urgent
Hello Good Day This is Listowel, With regards to your Company i am sending this email Regards to order some(CORDLESS DRILL) ,i will like to know the type and sizes you have in stock and get me the sales price of one so that i will tell you the quantity i will be ordering, and also if you accept credit card as a form of payment . God Bless . NAME.LISTOWEL Mike Listowel Listowel And Wife Co Ltd. 101 31st Ave West Number 5 Dickinson,ND 58505 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-mpc83xx
Dear Wolfgang Denk, Please pull: The following changes since commit 108f56b056780f0d23f720d98709304f84a0d6c8: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-i2c are available in the git repository at: git://git.denx.de/u-boot-mpc83xx.git master Heiko Schocher (1): 83xx, kmeter1, fix: update in the DTS the correct size for the first flash board/keymile/kmeter1/kmeter1.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Danke, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] ppc: trigger WDT before starting Linux
Signed-off-by: Heiko Schocher h...@denx.de --- lib_ppc/bootm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib_ppc/bootm.c b/lib_ppc/bootm.c index 0d702bf..8385749 100644 --- a/lib_ppc/bootm.c +++ b/lib_ppc/bootm.c @@ -94,6 +94,7 @@ static void boot_jump_linux(bootm_headers_t *images) #endif debug ( Booting using OF flat tree...\n); + WATCHDOG_RESET (); (*kernel) ((bd_t *)of_flat_tree, 0, 0, EPAPR_MAGIC, CONFIG_SYS_BOOTMAPSZ, 0, 0); /* does not return */ @@ -117,6 +118,7 @@ static void boot_jump_linux(bootm_headers_t *images) bd_t *kbd = images-kbd; debug ( Booting using board info...\n); + WATCHDOG_RESET (); (*kernel) (kbd, initrd_start, initrd_end, cmd_start, cmd_end, 0, 0); /* does not return */ -- 1.6.0.6 -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] jffs2: clean the cache in case of malloc fails in build_lists
We should call jffs2_clean_cache() if we return from jffs2_build_lists() with an error to prevent usage of incomplete lists. Also we should free() a local buffer to prevent memory leaks. Signed-off-by: Ilya Yanok ya...@emcraft.com --- fs/jffs2/jffs2_1pass.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/fs/jffs2/jffs2_1pass.c b/fs/jffs2/jffs2_1pass.c index 07511b9..1923ed9 100644 --- a/fs/jffs2/jffs2_1pass.c +++ b/fs/jffs2/jffs2_1pass.c @@ -1496,6 +1496,8 @@ jffs2_1pass_build_lists(struct part_info * part) if (!sumptr) { putstr(Can't get memory for summary node!\n); + free(buf); + jffs2_free_cache(part); return 0; } memcpy(sumptr + sumlen - buf_len, buf + @@ -1517,8 +1519,11 @@ jffs2_1pass_build_lists(struct part_info * part) if (buf_size sumlen buf_size) free(sumptr); - if (ret 0) + if (ret 0) { + free(buf); + jffs2_free_cache(part); return 0; + } if (ret) continue; @@ -1632,8 +1637,11 @@ jffs2_1pass_build_lists(struct part_info * part) break; if (insert_node(pL-frag, (u32) part-offset + - ofs) == NULL) + ofs) == NULL) { + free(buf); + jffs2_free_cache(part); return 0; + } if (max_totlen node-totlen) max_totlen = node-totlen; break; @@ -1659,8 +1667,11 @@ jffs2_1pass_build_lists(struct part_info * part) if (! (counterN%100)) puts (\b\b. ); if (insert_node(pL-dir, (u32) part-offset + - ofs) == NULL) + ofs) == NULL) { + free(buf); + jffs2_free_cache(part); return 0; + } if (max_totlen node-totlen) max_totlen = node-totlen; counterN++; -- 1.6.0.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] test mail server
please ignore. It seems like the list server or something isn't quite happy and sending this to see if it comes back. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Support for NANDs greater than/equal to 4 GB
On Tue, Aug 11, 2009 at 10:17:24AM -0500, Paulraj, Sandeep wrote: [Sandeep] Please tell me the U-boot policy of picking features from the kernel. I try to sync every now and then, but if you need something sooner please send it as a patch. But the above support in question is not my patch That's OK -- just send it with the author in a From: line at the beginning of the patch (but not in the e-mail headers). If someone submits a patch, yes. Otherwise it'll get picked up the next time I sync with Linux. [Sandeep] Can I do it? That's my question. Sure. That brings me to my final point are the patches I sent yesterday [PATCH 1/2] NAND: ADD page Parameter to all read_page/read_page_raw API's [PATCH 2/2] MTD:NAND: ADD new ECC mode NAND_ECC_HW_OOB_FIRST Going to be accepted by you? I've been busy on non-U-boot stuff, and haven't had a chance to look at them in detail yet. I'll try to get to them soon. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] taking the time pressure off board init
I'm working on an AVR32 with a funny system of warm boots caused by watchdog which don't fully reset the watchdog or real-time-counter hardware. I think the system allows RTC interrupts to be generated during or after the warm boot which can cause havoc with the existing code. It certainly means you have to rush to the watchdog and disable it within a second, or you'll loop. but I have a modem which I need/want to handle in board-init, and it takes 1-second pulses to get it going I have found it reasonable to add an cpu_early_init leading into an clock_early_init. That means that board_early_init can run without any time pressure on it because WDT hasn't yet been stomped on. The early clock init can disable the WDT, then kill off RTC interrupts. Any good reason why I shouldn't upload a patch to cover this? Do I do it here, or on AVR32-specific u-boot list? David Collier www.dexdyne.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Support for NANDs greater than/equal to 4 GB
Scott, Please see inline -Original Message- From: Scott Wood [mailto:scottw...@freescale.com] Sent: Tuesday, August 11, 2009 11:10 AM To: Paulraj, Sandeep Cc: u-boot@lists.denx.de Subject: Re: Support for NANDs greater than/equal to 4 GB On Tue, Aug 11, 2009 at 09:02:44AM -0500, Paulraj, Sandeep wrote: There was a patch some time which added the 64 bit support in the MTD subsystem. I am referring to the patch below http://git.infradead.org/mtd- 2.6.git/blobdiff/8a4c2495b142fe612b291a810d9e695f269c26db..69423d99fc182a8 1f3c5db3eb5c140acc6fc64be:/drivers/mtd/nand/nand_base.c Was it submitted to U-Boot? If it was, I missed it. [Sandeep] Please tell me the U-boot policy of picking features from the kernel. I submitted 2 NAND/MTD patches yesterday which were accepted by Andrew Morton. Since I am in the signed-off-by, I sent the patches to U-boot as well. But the above support in question is not my patch This feature still is not part of U-Boot. Is it going to be added? If someone submits a patch, yes. Otherwise it'll get picked up the next time I sync with Linux. [Sandeep] Can I do it? That's my question. BTW I have tried it myself, it does not seem to be a trivial feature addition. Changes will also be required in the files in the /common folder which relates to NAND. That brings me to my final point are the patches I sent yesterday [PATCH 1/2] NAND: ADD page Parameter to all read_page/read_page_raw API's [PATCH 2/2] MTD:NAND: ADD new ECC mode NAND_ECC_HW_OOB_FIRST Going to be accepted by you? -Scott Thanks, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] CFI Flash write speed
Hello, I have add CFI support to my project. I use Intel strata flash P30 and PXA270 CPU. The flash is connected with 16bit to the PXA data bus. If I write to the flash I have transfer rates of roughly 75kB/sec. I think this is very slow. How can I increase the transfer rate? Thanks, Andreas ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] raise not defined, when compiler uses its own div0
Dear Ulf Samuelsson, In message 4a81e724.3070...@atmel.com you wrote: Try setting USE_PRIVATE_LIBGCC=yes in your envrionment, like USE_PRIVATE_LIBGCC=yes make ... I have done two fixes to make it build with openembedded. 1) Define raise in libarm/board.c which calls hang. Did you use USE_PRIVATE_LIBGCC=yes, and it still needed raise(), or did you implement that workaround instead of using USE_PRIVATE_LIBGCC=yes. Normally no raise() should be needed when using USE_PRIVATE_LIBGCC=yes 2) Changes mapi to -mapi=aapcs-linux in cpu/arm926ej-s/config.mk Some toolchains want to keep apcs-gnu I guess. I wonder why we enforce a specific API at all - would it not be better to use the toolchain provided default settings? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Single tasking: Just Say No. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] imx27lite: add support for imx27lite board from LogicPD
--- On Mon, 8/10/09, Ilya Yanok ya...@emcraft.com wrote: From: Ilya Yanok ya...@emcraft.com Subject: [U-Boot] [PATCH] imx27lite: add support for imx27lite board from LogicPD To: plagn...@jcrosoft.com Cc: u-boot@lists.denx.de, Ilya Yanok ya...@emcraft.com Date: Monday, August 10, 2009, 7:32 PM This patch adds support for i.MX27-LITEKIT development board from LogicPD. This board uses i.MX27 SoC and has 2MB NOR flash, 64MB NAND flash, FEC ethernet controller integrated into i.MX27. Signed-off-by: Ilya Yanok ya...@emcraft.com ... cpu/arm926ejs/mx27/generic.c | 65 include/asm-arm/arch-mx27/imx-regs.h Shouldn't these two files be part of a separate patch as they are not specific to the iMX27 Lite board support? Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add md5sum and sha1 commands...
On Tue 11 Aug 2009 15:21, Wolfgang Denk pondered: Dear Robin Getz, In message 200908111357.25007.rg...@blackfin.uclinux.org you wrote: Now that we have sha1 and md5 in lib_generic, allow people to use them on the command line, for checking downloaded files Signed-off-by: Robin Getz rg...@blackfin.uclinux.org README |4 ++ common/cmd_mem.c | 68 + 2 files changed, 72 insertions(+) Wolfgang - was there anything wrong with this? or did you want me to send again? No, there is nothing wrog with it. Looks good to me. But it is new stuff, and the next branch is currently not so high on my priority list. Is this urgent to you? No - I was just going to update, and if I dropped it by accident (still learning git) - I wanted to make sure it was in your inbox... :) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/3] net/eth_device: keep index inside each device
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- include/net.h |1 + net/eth.c | 17 + 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/include/net.h b/include/net.h index 4a03717..2a8a12d 100644 --- a/include/net.h +++ b/include/net.h @@ -93,6 +93,7 @@ enum eth_state_t { }; struct eth_device { + int index; char name[NAMESIZE]; unsigned char enetaddr[6]; int iobase; diff --git a/net/eth.c b/net/eth.c index 42f74da..2316a22 100644 --- a/net/eth.c +++ b/net/eth.c @@ -83,6 +83,7 @@ static unsigned int eth_rcv_current = 0, eth_rcv_last = 0; #endif static struct eth_device *eth_devices, *eth_current; +static int nb_eth_devices = 0; struct eth_device *eth_get_dev(void) { @@ -133,22 +134,12 @@ struct eth_device *eth_get_dev_by_index(int index) int eth_get_dev_index (void) { - struct eth_device *dev; - int num = 0; - if (!eth_devices) { return (-1); } - for (dev = eth_devices; dev; dev = dev-next) { - if (dev == eth_current) - break; - ++num; - } - - if (dev) { - return (num); - } + if (eth_current) + return eth_current-index; return (0); } @@ -172,6 +163,8 @@ int eth_register(struct eth_device* dev) d-next = dev; } + dev-index = nb_eth_devices; + nb_eth_devices++; dev-state = ETH_STATE_INIT; dev-next = eth_devices; -- 1.6.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] raise not defined, when compiler uses its own div0
Dear Ulf Samuelsson, In message e26ff1fbf0834320ac6f19ce783c7...@aeglos you wrote: If I build u-boot from the u-boot dir outside the buildsystem, it also means a lot of typing - If I remember to do it... Why not make it a default mode? Because the default mode is to assume you are using a good tool chain. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de He had quite a powerful intellect, but it was as powerful like a locomotive, and ran on rails and was therefore almost impossible to steer. - Terry Pratchett, _Lords and Ladies_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request - net
Dear Ben Warren, In message 4a809b2e.9090...@gmail.com you wrote: Wolfgang, The following changes since commit eb1a4d0a471505c169bef19a73a60f8641f0b875: Wolfgang Denk (1): Prepare 2009.08-rc2 are available in the git repository at: git://git.denx.de/u-boot-net.git master Po-Yu Chuang (1): arm: A320: driver for FTMAC100 ethernet controller Prafulla Wadaskar (2): net: phy: bugfixes: mv88E61xx compiler warnings fixed net: kirkwood: updates: used eth_setenv_enetaddr api Roy Zang (1): Fix E1000 build warning on AP1000 board Sandeep Paulraj (1): ARM: Davinci DM355: Enabling DM9000 on DM355 EVM Hmm... Seems the repo also included: 07/01 Richard Retanubun [U-Boot] [PATCH] UEC FIXED PHY: Determine fixed-phy port using UEC interface name. 07/01 Richard Retanubun [U-Boot] [PATCH] Assigned a static SMI address to all UECs TBIPA address. OK, pulled. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de For those who like this sort of thing, this is the sort of thing they like. - Abraham Lincoln ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] MTD:NAND: ADD new ECC mode NAND_ECC_HW_OOB_FIRST
-Original Message- From: Scott Wood [mailto:scottw...@freescale.com] Sent: Tuesday, August 11, 2009 6:35 PM To: Paulraj, Sandeep Cc: u-boot@lists.denx.de; Narnakaje, Snehaprabha Subject: Re: [U-Boot] [PATCH 2/2] MTD:NAND: ADD new ECC mode NAND_ECC_HW_OOB_FIRST On Mon, Aug 10, 2009 at 01:27:56PM -0400, s-paul...@dal.design.ti.com wrote: /** + * nand_read_page_hwecc_oob_first - [REPLACABLE] hw ecc, read oob first + * @mtd: mtd info structure + * @chip: nand chip info structure + * @buf: buffer to store read data + * + * Hardware ECC for large page chips, require OOB to be read first. That statement may be true on some controllers, but not all. [Sandeep] Yes, this is true for TI DaVinci controllers + * For this ECC mode, the write_page method is re-used from ECC_HW. + * These methods read/write ECC from the OOB area, unlike the + * ECC_HW_SYNDROME support with multiple ECC steps, follows the + * infix ECC scheme and reads/writes ECC from the data area, by + * overwriting the NAND manufacturer bad block markings. + */ +static int nand_read_page_hwecc_oob_first(struct mtd_info *mtd, + struct nand_chip *chip, uint8_t *buf, int page) +{ + int i, eccsize = chip-ecc.size; + int eccbytes = chip-ecc.bytes; + int eccsteps = chip-ecc.steps; + uint8_t *p = buf; + uint8_t *ecc_code = chip-buffers-ecccode; + uint32_t *eccpos = chip-ecc.layout-eccpos; + uint8_t *ecc_calc = chip-buffers-ecccalc; + + /* Read the OOB area first */ + chip-cmdfunc(mtd, NAND_CMD_READOOB, 0, page); Note that a READ0 command will have already been issued at this point. I guess it looks to the NAND chip as a zero-byte read, but still things are getting quite ugly. The generic interface is one big layering violation that assumes a certain type of very simple controller, and we're accumulating hacks to deal with less straightforward controllers. :-( [Sandeep] I agree.At the beginning of the year we had a way to do it with the existing modes. WE had are own read and write funtions in the Davinci NAND driver to achieve what were are doing in this patch. But the solution was not accepted by the MTD community. I have given the link for the original kernel patches. This current solution had the blessings of Thomas Gleixner and David Brownell. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] NAND: ADD page Parameter to all read_page/read_page_raw API's
On Mon, Aug 10, 2009 at 01:27:46PM -0400, s-paul...@dal.design.ti.com wrote: From: Sandeep Paulraj s-paul...@ti.com This patch adds a new page parameter to all NAND read_page/read_page_raw APIs. The read_page API for the new mode ECC_HW_OOB_FIRST requires the page information to send the READOOB command and read the OOB area before the data area. This patch has been accepted by Andrew Morton and can be found at http://userweb.kernel.org/~akpm/mmotm/broken-out/mtd-nand-add-page-parameter-to-all-read_page-read_page_raw-apis.patch WE would like this to become part of the u-boot GIT as well Signed-off-by: Sandeep Paulraj s-paul...@ti.com Signed-off-by: Sneha Narnakaje nsnehapra...@ti.com Applied to u-boot-nand-flash/next. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] 85xx: Removed BEDBUG support on P1_P2_RDB
To match all other 85xx platforms we are removing BEDBUG support. Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- include/configs/P1_P2_RDB.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/configs/P1_P2_RDB.h b/include/configs/P1_P2_RDB.h index ff4a5cb..9591641 100644 --- a/include/configs/P1_P2_RDB.h +++ b/include/configs/P1_P2_RDB.h @@ -378,7 +378,6 @@ extern unsigned long get_board_sys_clk(unsigned long dummy); #define CONFIG_CMD_SETEXPR #if defined(CONFIG_PCI) -#define CONFIG_CMD_BEDBUG #define CONFIG_CMD_NET #define CONFIG_CMD_PCI #endif -- 1.6.0.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request - net
Dear Ben Warren, In message 4a81d1de.9060...@gmail.com you wrote: Seems the repo also included: 07/01 Richard Retanubun [U-Boot] [PATCH] UEC FIXED PHY: Determine fixed-phy port using UEC interface name. 07/01 Richard Retanubun [U-Boot] [PATCH] Assigned a static SMI address to all UECs TBIPA address. ... Sorry, I pushed those two after the pull request and forgot to send another one. No problem. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It is easier to change the specification to fit the program than vice versa. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] PPC460EX with 2 Ethernet Tranceivers
Dear Judd Gilbert, In message 16691a8b34b5d9458ea3a1c37a11555a01351...@tanisys-ex2.tanisys.local you wrote: I am currently running linux 2.6.28.4 on a PPC460EX with 2 Marvell Alaska 88E Ethernet transceivers connected to it. I've added the flags I believe to configure u-boot properly: ... eth0: EMAC-0 /plb/opb/ether...@ef600e00, MAC 00:13:a8:00:0d:c6 eth0: found Generic MII PHY (0x00) /plb/opb/emac-rg...@ef601500: input 1 in RGMII mode eth1: EMAC-1 /plb/opb/ether...@ef600f00, MAC 00:13:a8:00:0d:c7 eth1: found Generic MII PHY (0x02) If I don't hold the 2nd transceiver in reset I get the following message when linux boots: eth0: EMAC-0 /plb/opb/ether...@ef600e00, MAC 00:13:a8:00:0d:c6 eth0: found Generic MII PHY (0x00) /plb/opb/emac-rg...@ef601500: input 1 in RGMII mode /plb/opb/ether...@ef600f00: can't find PHY! Well, this is a Linux issue. Linux should make no assumptions about a specific state of a network device. No matter what U-Boot does, the Linux kernel should always initialize the hardware so that it works. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A girl with a future avoids the man with a past. -- Evan Esar, The Humor of Humor ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Make TFTP Quiet
Hi Timur, +#ifdef CONFIG_TFTP_QUIET +#define puts_quiet(fmt) +#else +#define puts_quiet(fmt) puts(fmt); +#endif This looks backwards to me. I would do this: #ifdef CONFIG_TFTP_QUIET #define puts(x) puts_quiet(x) #endif That way, you don't need to change all of the puts calls to puts_quiet. Plus, having the normal calls be puts_quiet that changes to puts when QUIET is *not* enabled just feels wrong. Just as a general remark - I consider it a bad idea to overload well known functions with non-standard behaviour. This breaks the principle of least surprise which turns out to be very valuable. Cheers Detlev -- It was actually a very beautiful thing to see a sunrise, cause' that's such a calm time of day. It's a wonderful time of day to get ready to go to bed. -- Richard M. Stallman -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] LIBFDT - changing command line
Hi Michal Michal Simek wrote: Hi All, I would like to use fdt for changing command line in DTB but I found there is one problem if I have longer command line which contains any spaces. Below is my workflow. If I understand correctly the problem is in cmd_fdt.c:fdt_parse_prop:593-603. It will be worth to add case for supporting fdt set /chosen bootargs console=ttyUL root=/dev/mtdblock0 copy from first to next Or is it there any solution which I miss for this case? Thanks, Michal It is somewhat ugly, but the you can use \ to escape the spaces: fdt set /chosen bootargs console=ttyUL\ root=/dev/mtdblock0 I did this originally (IIRC) so that I wouldn't have to deal with handling quotes in the parsing (Are they there? Are they balanced? What to do if not balanced?). Add in a dash of lazy... [snip] Best regards, gvb ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add md5sum and sha1 commands...
Dear Robin Getz, In message 200908111357.25007.rg...@blackfin.uclinux.org you wrote: Now that we have sha1 and md5 in lib_generic, allow people to use them on the command line, for checking downloaded files Signed-off-by: Robin Getz rg...@blackfin.uclinux.org README |4 ++ common/cmd_mem.c | 68 + 2 files changed, 72 insertions(+) Wolfgang - was there anything wrong with this? or did you want me to send again? No, there is nothing wrog with it. Looks good to me. But it is new stuff, and the next branch is currently not so high on my priority list. Is this urgent to you? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de No question is too silly to ask. Of course, some questions are too silly to to answer... - L. Wall R. L. Schwartz, _Programming Perl_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/3] smc91111: switch to MULTI_NET api
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- board/netstar/eeprom.c |3 +- board/voiceblue/eeprom.c |3 +- drivers/net/smc9.c | 420 +++-- drivers/net/smc9.h |8 +- include/configs/ADNPESC1.h |1 + include/configs/DK1C20.h |1 + include/configs/DK1S10.h |1 + include/configs/EP1C20.h |1 + include/configs/EP1S10.h |1 + include/configs/EP1S40.h |1 + include/configs/MigoR.h |1 + include/configs/PK1C20.h |1 + include/configs/bf533-ezkit.h|1 + include/configs/bf533-stamp.h|1 + include/configs/bf538f-ezkit.h |1 + include/configs/bf561-ezkit.h|1 + include/configs/blackstamp.h |1 + include/configs/cerf250.h|1 + include/configs/cm-bf533.h |1 + include/configs/cm-bf561.h |1 + include/configs/cradle.h |1 + include/configs/delta.h |1 + include/configs/dnp1110.h|1 + include/configs/gr_cpci_ax2000.h |1 + include/configs/gr_ep2s60.h |1 + include/configs/innokom.h|1 + include/configs/integratorcp.h |1 + include/configs/logodl.h |1 + include/configs/lpd7a400-10.h|1 + include/configs/lpd7a404-10.h|1 + include/configs/ms7722se.h |1 + include/configs/netstar.h|1 + include/configs/nhk8815.h|1 + include/configs/pxa255_idp.h |1 + include/configs/versatile.h |1 + include/configs/voiceblue.h |1 + include/configs/xaeniax.h|1 + include/configs/xm250.h |1 + include/configs/xsengine.h |1 + include/configs/zylonite.h |1 + include/netdev.h |1 + 41 files changed, 259 insertions(+), 212 deletions(-) diff --git a/board/netstar/eeprom.c b/board/netstar/eeprom.c index 5806128..05c6768 100644 --- a/board/netstar/eeprom.c +++ b/board/netstar/eeprom.c @@ -27,9 +27,8 @@ #include common.h #include exports.h #include timestamp.h -#include ../drivers/net/smc9.h - #define SMC_BASE_ADDRESS CONFIG_SMC9_BASE +#include ../drivers/net/smc9.h static u16 read_eeprom_reg(u16 reg) { diff --git a/board/voiceblue/eeprom.c b/board/voiceblue/eeprom.c index f01597a..8b3fbed 100644 --- a/board/voiceblue/eeprom.c +++ b/board/voiceblue/eeprom.c @@ -27,9 +27,8 @@ #include common.h #include exports.h #include timestamp.h -#include ../drivers/net/smc9.h - #define SMC_BASE_ADDRESS CONFIG_SMC9_BASE +#include ../drivers/net/smc9.h static u16 read_eeprom_reg(u16 reg) { diff --git a/drivers/net/smc9.c b/drivers/net/smc9.c index b41e4d2..1c0c20f 100644 --- a/drivers/net/smc9.c +++ b/drivers/net/smc9.c @@ -61,9 +61,10 @@ #include common.h #include command.h -#include config.h +#include malloc.h #include smc9.h #include net.h +#include netdev.h /* Use power-down feature of the chip */ #define POWER_DOWN 0 @@ -114,7 +115,6 @@ static const char version[] = #define PRINTK(args...) #endif - /* . . The internal workings of the driver. If you are changing anything @@ -127,14 +127,7 @@ static const char version[] = /* Memory sizing constant */ #define LAN91C111_MEMORY_MULTIPLIER(1024*2) -#ifndef CONFIG_SMC9_BASE -#define CONFIG_SMC9_BASE 0x2300 -#endif - -#define SMC_BASE_ADDRESS CONFIG_SMC9_BASE - #define SMC_DEV_NAME SMC9 -#define SMC_PHY_ADDR 0x #define SMC_ALLOC_MAX_TRY 5 #define SMC_TX_TIMEOUT 30 @@ -143,75 +136,51 @@ static const char version[] = #define ETH_ZLEN 60 #ifdef CONFIG_SMC_USE_32_BIT -#define USE_32_BIT 1 +#define is_use_32bit(x) (x-use_32bit) #else -#undef USE_32_BIT +#define is_use_32bit(x) (0) #endif + +struct smc9_device { + int id; + void*regs; + + int use_32bit; + + struct eth_device netdev; + unsigned short phy_addr; +}; +#define to_smc9(_nd) container_of(_nd, struct smc9_device, netdev) + /*- . . The driver can be entered at any of the following entry points. . .-- */ -extern int eth_init(bd_t *bd); -extern void eth_halt(void); -extern int eth_rx(void); -extern int eth_send(volatile void *packet, int length); - #ifdef SHARED_RESOURCES extern void swap_to(int device_id); #endif /* - . This is called by register_netdev(). It is responsible for - . checking the portlist for the SMC9000 series chipset. If it finds - . one, then it will initialize the device, find the hardware information, - . and sets up the appropriate device parameters. - . NOTE: Interrupts
Re: [U-Boot] raise not defined, when compiler uses its own div0
Sent: Tuesday, August 11, 2009 11:58 PM Subject: Re: [U-Boot] raise not defined, when compiler uses its own div0 Dear Ulf Samuelsson, In message 4a81e724.3070...@atmel.com you wrote: Try setting USE_PRIVATE_LIBGCC=yes in your envrionment, like USE_PRIVATE_LIBGCC=yes make ... I have done two fixes to make it build with openembedded. 1) Define raise in libarm/board.c which calls hang. Did you use USE_PRIVATE_LIBGCC=yes, and it still needed raise(), or did you implement that workaround instead of using USE_PRIVATE_LIBGCC=yes. Normally no raise() should be needed when using USE_PRIVATE_LIBGCC=yes Instead, since I think it is ugly. If I build u-boot from the u-boot dir outside the buildsystem, it also means a lot of typing - If I remember to do it... Why not make it a default mode? Then there is no problem anywhere and the patch is not needed. 2) Changes mapi to -mapi=aapcs-linux in cpu/arm926ej-s/config.mk Some toolchains want to keep apcs-gnu I guess. I wonder why we enforce a specific API at all - would it not be better to use the toolchain provided default settings? I tried that, but that did not work with openembedded. ' I suspect that the openembedded libraries are built with -mapi-aapcs-linux. -mapi=apcs-gnu is not a problem with buildroot. A similar thing: For ARM, -msoftfloat is enforced, and I think that should be removed. AFAIK there are no floating point stuff in u-boot, and why then enforce something which might or might not work for an arbitrary toolchain. Is there any toolchain that will not work, if -msoftfloat is removed? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Single tasking: Just Say No. Best Regards Ulf Samuelssonu...@atmel.com Atmel Nordic AB Mail: Box 2033, 174 02 Sundbyberg, Sweden Visit: Kavallerivägen 24, 174 58 Sundbyberg, Sweden Phone +46 (8) 441 54 22 Fax +46 (8) 441 54 29 GSM+46 (706) 22 44 57 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Porting
Hi there, First let me introduce myself so you know what you're dealing with. My name is Peter and I'm a web designer by trade, messing around with embedded platforms in my spare time. However I'm only really getting started in the low level code aspect of it, so you'll have to excuse my inexperience and ignorance. I'm playing with a Broadcom BCM7038 platform at the moment, and currently the bootloader starts in flash, inits the DRAM, copies the kernel image from flash into memory and starts it. What I'm looking to do is to init the memory and SATA HD, then load the kernel image from the HD and start it. U-Boot looks like a good choice to do this, but I'm having trouble getting started. I have the code for the original bootloader, including the ASM code with the reset vector and coprocessor bring-up code, but I'm having trouble figuring out how I would integrate that with U-Boot. I've read through the README and it's not really aimed for beginners (with good reason I guess) I really could do with an overview of what U-Boot requires of my code, and what configuration changes I need to make to U-Boot to get it to use my code. -- Regards, Peter Belm ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] http client?
On Wed 22 Jul 2009 10:04, jeffery palmer pondered: We are looking for an http client now as well. Our major issue revolves around the download times for tftp. Can Volkmar Uhlig kindly provide the patches? Our units automically update themselves inside of uboot giving us the most control over our firmware. The issue is that it takes 20 minutes via a DSL line in Africa to update our units. An http test showed that the same firmware downloads in 30 seconds. We have also added things like the blksize parameter to the uboot tftp client to get it down to 20 minutes, our original download times were ~50 minutes. Jeff: Can you look at the recent changes to the net/next tree/branch? On a slow connection -- I saw things go from 15:28 download (tftpblocksize == 1468) to 1:47 (tftpblocksize == 16268) - more than a 8x difference. Even if you look at the your stated time of 50min - that should drop it to a more reasonable ~6ish ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add md5sum and sha1 commands...
On Mon 27 Jul 2009 00:07, Robin Getz pondered: From: Robin Getz rg...@blackfin.uclinux.org Now that we have sha1 and md5 in lib_generic, allow people to use them on the command line, for checking downloaded files Signed-off-by: Robin Getz rg...@blackfin.uclinux.org README |4 ++ common/cmd_mem.c | 68 + 2 files changed, 72 insertions(+) Wolfgang - was there anything wrong with this? or did you want me to send again? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Write back flash content to SD/MMC Card
Hello, I will write back the complete content of my flash memory to a binary File on SD/MMC Card. How can I do this? Is there any support to create a file on SD/MMC card? Thanks, Andreas ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] 85xx: Move to a common linker script
Dear Kumar Gala, In message 1249997451-21265-1-git-send-email-ga...@kernel.crashing.org you wrote: There are really no differences between all the 85xx linker scripts so we can just move to a single common one. Board code is still able to override the common one if need be. Are you sure there are no differences? --- board/atum8548/u-boot.lds 2009-07-28 20:27:27.549470982 +0200 +++ board/freescale/mpc8536ds/u-boot.lds2009-07-28 20:27:27.678455216 +0200 @@ -1,5 +1,5 @@ /* - * Copyright 2007 Freescale Semiconductor, Inc. + * Copyright 2008 Freescale Semiconductor, Inc. * * See file CREDITS for list of people who contributed to this * project. @@ -23,18 +23,14 @@ OUTPUT_ARCH(powerpc) /* Do we need any of these for elf? __DYNAMIC = 0;*/ -SECTIONS -{ - .resetvec 0xFFFC : +PHDRS { -*(.resetvec) - } = 0x + text PT_LOAD; + bss PT_LOAD; +} - .bootpg 0xF000 : +SECTIONS { -cpu/mpc85xx/start.o(.bootpg) - } = 0x - /* Read-only sections, merged into text segment: */ . = + SIZEOF_HEADERS; .interp : { *(.interp) } @@ -61,26 +57,17 @@ .plt : { *(.plt) } .text : { -cpu/mpc85xx/start.o(.text) -cpu/mpc85xx/traps.o (.text) -cpu/mpc85xx/interrupts.o (.text) -cpu/mpc85xx/cpu_init.o (.text) -cpu/mpc85xx/cpu.o (.text) -cpu/mpc85xx/speed.o (.text) -lib_generic/crc32.o (.text) -lib_ppc/extable.o (.text) -lib_generic/zlib.o (.text) *(.text) *(.fixup) *(.got1) - } + } :text _etext = .; PROVIDE (etext = .); .rodata: { *(.eh_frame) *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*))) - } + } :text .fini : { *(.fini)} =0 .ctors : { *(.ctors) } .dtors : { *(.dtors) } @@ -129,6 +116,18 @@ . = ALIGN(256); __init_end = .; + .bootpg ADDR(.text) + 0x7f000 : + { +cpu/mpc85xx/start.o(.bootpg) + } :text = 0x + + .resetvec ADDR(.text) + 0x7fffc : + { +*(.resetvec) + } :text = 0x + + . = ADDR(.text) + 0x8; + __bss_start = .; .bss (NOLOAD) : { @@ -136,8 +135,9 @@ *(.dynbss) *(.bss) *(COMMON) + } :bss + . = ALIGN(4); - } _end = . ; PROVIDE (end = .); } ??? Also, you're compressing a lot of different Copyrights into a single Copyright 2007-2009 Freescale Semiconductor, Inc.. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Our business is run on trust. We trust you will pay in advance. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mxc_nand: add nand driver for MX2/MX3
On Tue, Aug 11, 2009 at 02:32:54AM +0400, Ilya Yanok wrote: Driver for NFC NAND controller found on Freescale's MX2 and MX3 processors. Ported from Linux. Tested only with i.MX27 but should works with other MX2 and MX3 processors too. Signed-off-by: Ilya Yanok ya...@emcraft.com Applied to u-boot-nand-flash/next. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] MTD:NAND: ADD new ECC mode NAND_ECC_HW_OOB_FIRST
On Mon, Aug 10, 2009 at 01:27:56PM -0400, s-paul...@dal.design.ti.com wrote: From: Sandeep Paulraj s-paul...@ti.com This patch adds the new mode NAND_ECC_HW_OOB_FIRST in the nand code to support 4-bit ECC on TI DaVinci devices with large page (up to 2K) NAND chips. This ECC mode is similar to NAND_ECC_HW, with the exception of read_page API that first reads the OOB area, reads the data in chunks, feeds the ECC from OOB area to the ECC hw engine and perform any correction on the data as per the ECC status reported by the engine. Is this going to be used by any other NAND controllers? If it's not a particularly common thing, perhaps the DaVinci NAND controller driver should just override the read_page method. Even if it's shared, the alternative read_page should probably be provided in library form for the controller driver to use if desired. We should move most of the so-called generic NAND stuff in that direction; currently it bloats u-boot even on hardware that doesn't need it. This patch has been accepted by Andrew Morton and can be found at http://userweb.kernel.org/~akpm/mmotm/broken-out/mtd-nand-add-new-ecc-mode-ecc_hw_oob_first.patch That's a testing tree -- it's not actually accepted if it's not in the mtd tree (or Linus's). + case NAND_ECC_HW_OOB_FIRST: + /* Similar to NAND_ECC_HW, but a separate read_page handle */ + if (!chip-ecc.calculate || !chip-ecc.correct || + !chip-ecc.hwctl) { + printk(KERN_WARNING No ECC functions supplied, +Hardware ECC not possible\n); + BUG(); + } + if (!chip-ecc.read_page) + chip-ecc.read_page = nand_read_page_hwecc_oob_first; Would anyone ever use this with read_page non-NULL? It seems like its whole point is to overide that. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] LIBFDT - changing command line
Jerry Van Baren wrote: Hi Michal Michal Simek wrote: Hi All, I would like to use fdt for changing command line in DTB but I found there is one problem if I have longer command line which contains any spaces. Below is my workflow. If I understand correctly the problem is in cmd_fdt.c:fdt_parse_prop:593-603. It will be worth to add case for supporting fdt set /chosen bootargs console=ttyUL root=/dev/mtdblock0 copy from first to next Or is it there any solution which I miss for this case? Thanks, Michal It is somewhat ugly, but the you can use \ to escape the spaces: fdt set /chosen bootargs console=ttyUL\ root=/dev/mtdblock0 Of course I tried it but simply not work. U-Boot-mONStR fdt list /chosen chosen { bootargs = console=ttyUL0,115200 highres=on root=/dev/mtdblock0; linux,stdout-path = /p...@0/ser...@8400; }; U-Boot-mONStR fdt set /chosen bootargs console=ttyUL\ root=dev U-Boot-mONStR fdt list /chosen chosen { bootargs = root=dev; linux,stdout-path = /p...@0/ser...@8400; }; U-Boot-mONStR Can you tried it on your ppc? Michal I did this originally (IIRC) so that I wouldn't have to deal with handling quotes in the parsing (Are they there? Are they balanced? What to do if not balanced?). Add in a dash of lazy... [snip] Best regards, gvb -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] imx27lite: add support for imx27lite board from LogicPD
Hi Fabio, Fabio Estevam wrote: cpu/arm926ejs/mx27/generic.c | 65 include/asm-arm/arch-mx27/imx-regs.h Shouldn't these two files be part of a separate patch as they are not specific to the iMX27 Lite board support? Well, I thought about this... Let's wait for a Jean-Christophe opinion. Regards, Ilya. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] MTD:NAND: ADD new ECC mode NAND_ECC_HW_OOB_FIRST
On Mon, Aug 10, 2009 at 01:27:56PM -0400, s-paul...@dal.design.ti.com wrote: /** + * nand_read_page_hwecc_oob_first - [REPLACABLE] hw ecc, read oob first + * @mtd: mtd info structure + * @chip:nand chip info structure + * @buf: buffer to store read data + * + * Hardware ECC for large page chips, require OOB to be read first. That statement may be true on some controllers, but not all. + * For this ECC mode, the write_page method is re-used from ECC_HW. + * These methods read/write ECC from the OOB area, unlike the + * ECC_HW_SYNDROME support with multiple ECC steps, follows the + * infix ECC scheme and reads/writes ECC from the data area, by + * overwriting the NAND manufacturer bad block markings. + */ +static int nand_read_page_hwecc_oob_first(struct mtd_info *mtd, + struct nand_chip *chip, uint8_t *buf, int page) +{ + int i, eccsize = chip-ecc.size; + int eccbytes = chip-ecc.bytes; + int eccsteps = chip-ecc.steps; + uint8_t *p = buf; + uint8_t *ecc_code = chip-buffers-ecccode; + uint32_t *eccpos = chip-ecc.layout-eccpos; + uint8_t *ecc_calc = chip-buffers-ecccalc; + + /* Read the OOB area first */ + chip-cmdfunc(mtd, NAND_CMD_READOOB, 0, page); Note that a READ0 command will have already been issued at this point. I guess it looks to the NAND chip as a zero-byte read, but still things are getting quite ugly. The generic interface is one big layering violation that assumes a certain type of very simple controller, and we're accumulating hacks to deal with less straightforward controllers. :-( -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] raise not defined, when compiler uses its own div0
Wolfgang Denk skrev: Dear Ulf Samuelsson, In message 4a810dbc.50...@atmel.com you wrote: When trying to build U-Boot under Buildroot and OpenEmbedded, These probably count to the tool chains with broken ARM cross compilers. Maybe, Buildroot is even more broken, if you try to use an external toolchain and I would be surprised if openembedded is better. In the end, noone wants to mess around with one compiler per application so it is better if a small fix to u-boot can be applied. When linking u-boot the linker seems to use the div0 from the C compiler libgcc instead of the u-boot div0. Try setting USE_PRIVATE_LIBGCC=yes in your envrionment, like USE_PRIVATE_LIBGCC=yes make ... I have done two fixes to make it build with openembedded. 1) Define raise in libarm/board.c which calls hang. 2) Changes mapi to -mapi=aapcs-linux in cpu/arm926ej-s/config.mk Some toolchains want to keep apcs-gnu I guess. Best regards, Wolfgang Denk BR Ulf Samuelsson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tools: mkimage: Fixed build warnings
Dear Prafulla Wadaskar, In message 1249983988-3370-1-git-send-email-prafu...@marvell.com you wrote: uninitialized retval variable warning fixed crc32 api moved to crc.h(new) and build warnings fixed Hm... why are you changing the casts to new variable types? +/* lib_generic/crc32.c */ +uint32_t crc32 (uint32_t, const unsigned char *, uint); +uint32_t crc32_wd (uint32_t, const unsigned char *, uint, uint); +uint32_t crc32_no_comp (uint32_t, const unsigned char *, uint); So the prototypes (and the implementation) use const unsigned char * for the second argument. checksum = crc32 (0, - (const char *)(ptr + image_get_header_size ()), + (const uint8_t *)(ptr + image_get_header_size ()), Why are you changing the type here to uint8_t? I would expect to see unsigned char. - checksum = crc32 (0, (const char *)hdr, image_get_header_size ()); + checksum = crc32 (0, (const uint8_t *)hdr, image_get_header_size ()); Ditto. @@ -485,7 +485,7 @@ static int image_verify_header (char *ptr, int image_size) { int len; - char *data; + uint8_t *data; Ditto. uint32_t checksum; image_header_t header; image_header_t *hdr = header; @@ -504,7 +504,7 @@ image_verify_header (char *ptr, int image_size) return -FDT_ERR_BADMAGIC; } - data = (char *)hdr; + data = (uint8_t *)hdr; len = sizeof(image_header_t); checksum = be32_to_cpu(hdr-ih_hcrc); @@ -517,7 +517,7 @@ image_verify_header (char *ptr, int image_size) return -FDT_ERR_BADSTATE; } - data = ptr + sizeof(image_header_t); + data = (uint8_t *)ptr + sizeof(image_header_t); And again and again. This does not look consistent to me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The software required `Windows 95 or better', so I installed Linux. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Where is the GPR30 register in PowerPC arch as GOT pointer documented?
I find nothing about this in (E)ABI specification(perhaps some old), so, where is it? Thanks. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 2/2] zlib: add watchdog reset call
Dear Giuseppe CONDORELLI, In message 1248861920-12280-1-git-send-email-giuseppe.condore...@st.com you wrote: This patch adds watchdog reset call to allow its invokation during decompression phase. This control was present on old zlib version and here it is backported for those relevant routines. This patch is sent as a zlib separate one beacuse it was not tested due to specific board lack. zlib patches will be unified just in one when this will be validated through tests. Signed-off-by: Giuseppe Condorelli giuseppe.condore...@st.com --- lib_generic/zlib.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I'd rather be led to hell than managed to heaven. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] LIBFDT - changing command line
Hi All, I would like to use fdt for changing command line in DTB but I found there is one problem if I have longer command line which contains any spaces. Below is my workflow. If I understand correctly the problem is in cmd_fdt.c:fdt_parse_prop:593-603. It will be worth to add case for supporting fdt set /chosen bootargs console=ttyUL root=/dev/mtdblock0 copy from first to next Or is it there any solution which I miss for this case? Thanks, Michal U-Boot-mONStR tftp 9078 system.dtb Using Xilinx LL TEMAC device TFTP from server 192.168.0.102; our IP address is 192.168.0.3 Filename 'system.dtb'. Load address: 0x9078 Loading: 100BASE-T/FD # done Bytes transferred = 9121 (23a1 hex) U-Boot-mONStR fdt addr 9078 U-Boot-mONStR fdt h magic: 0xd00dfeed totalsize: 0x23a1 (9121) off_dt_struct: 0x38 off_dt_strings: 0x14a0 off_mem_rsvmap: 0x28 version:17 last_comp_version: 16 boot_cpuid_phys:0x0 size_dt_strings:0xf01 size_dt_struct: 0x1468 number mem_rsv: 0x0 U-Boot-mONStR fdt list /chosen chosen { bootargs = console=ttyUL0,115200 highres=on root=/dev/mtdblock0; linux,stdout-path = /p...@0/ser...@8400; }; U-Boot-mONStR fdt set /chosen bootargs console=ttyUL root=/dev/mtdblock0 U-Boot-mONStR fdt list /chosen chosen { bootargs = root=/dev/mtdblock0; linux,stdout-path = /p...@0/ser...@8400; }; U-Boot-mONStR -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/3] net: add getenv/setenv enetaddr function to use ethernet device num
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- include/net.h |2 ++ net/eth.c | 28 +--- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/include/net.h b/include/net.h index 2a8a12d..dc4ae41 100644 --- a/include/net.h +++ b/include/net.h @@ -124,6 +124,8 @@ extern void eth_set_enetaddr(int num, char* a); /* Set new MAC address */ extern void eth_parse_enetaddr(const char *addr, uchar *enetaddr); extern int eth_getenv_enetaddr(char *name, uchar *enetaddr); extern int eth_setenv_enetaddr(char *name, const uchar *enetaddr); +extern int eth_getenv_num_enetaddr(int num, uchar *enetaddr); +extern int eth_setenv_num_enetaddr(int num, const uchar *enetaddr); extern int eth_init(bd_t *bis);/* Initialize the device */ extern int eth_send(volatile void *packet, int length); /* Send a packet */ diff --git a/net/eth.c b/net/eth.c index 2316a22..9bdf961 100644 --- a/net/eth.c +++ b/net/eth.c @@ -27,6 +27,12 @@ #include miidev.h #ifdef CONFIG_CMD_NET + +static void get_enetvar(int num, char *enetvar) +{ + sprintf(enetvar, num ? eth%daddr : ethaddr, num); +} + void eth_parse_enetaddr(const char *addr, uchar *enetaddr) { char *end; @@ -53,6 +59,24 @@ int eth_setenv_enetaddr(char *name, const uchar *enetaddr) return setenv(name, buf); } + +int eth_getenv_num_enetaddr(int num, uchar *enetaddr) +{ + char enetvar[32]; + + get_enetvar(num, enetvar); + + return eth_getenv_enetaddr(enetvar, enetaddr); +} + +int eth_setenv_num_enetaddr(int num, const uchar *enetaddr) +{ + char enetvar[32]; + + get_enetvar(num, enetvar); + + return eth_setenv_enetaddr(enetvar, enetaddr); +} #endif #if defined(CONFIG_CMD_NET) defined(CONFIG_NET_MULTI) @@ -173,7 +197,6 @@ int eth_register(struct eth_device* dev) int eth_initialize(bd_t *bis) { - char enetvar[32]; unsigned char env_enetaddr[6]; int eth_number = 0; @@ -214,8 +237,7 @@ int eth_initialize(bd_t *bis) puts ( [PRIME]); } - sprintf(enetvar, eth_number ? eth%daddr : ethaddr, eth_number); - eth_getenv_enetaddr(enetvar, env_enetaddr); + eth_getenv_num_enetaddr(eth_number, env_enetaddr); if (memcmp(env_enetaddr, \0\0\0\0\0\0, 6)) { if (memcmp(dev-enetaddr, \0\0\0\0\0\0, 6) -- 1.6.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/1][Net] Convert CS8900 Ethernet driver to CONFIG_NET_MULTI API
Hello, This driver is compile-tested only on ARM platform. I'm hoping some volunteers can test it on real hardware. thanks, Ben --- board/altera/dk1c20/dk1c20.c | 12 ++ board/altera/dk1s10/dk1s10.c | 12 ++ board/armadillo/armadillo.c | 12 ++ board/csb226/csb226.c | 12 ++ board/ep7312/ep7312.c | 12 ++ board/freescale/mx31ads/mx31ads.c | 12 ++ board/impa7/impa7.c | 12 ++ board/lart/lart.c | 12 ++ board/mpl/vcma9/cmd_vcma9.c | 28 +++-- board/mpl/vcma9/vcma9.c | 12 ++ board/mx1ads/mx1ads.c | 12 ++ board/samsung/smdk2400/smdk2400.c | 12 ++ board/samsung/smdk2410/smdk2410.c | 12 ++ board/samsung/smdk6400/smdk6400.c | 12 ++ board/sbc2410x/sbc2410x.c | 12 ++ board/ssv/adnpesc1/adnpesc1.c | 12 ++ board/trab/trab.c | 12 ++ drivers/net/Makefile |2 +- drivers/net/cs8900.c | 243 - drivers/net/cs8900.h | 41 --- include/configs/ADNPESC1.h| 14 ++- include/configs/DK1C20.h | 14 ++- include/configs/DK1S10.h | 14 ++- include/configs/VCMA9.h |7 +- include/configs/armadillo.h |9 +- include/configs/csb226.h |7 +- include/configs/ep7312.h |9 +- include/configs/impa7.h |7 +- include/configs/lart.h|7 +- include/configs/mx1ads.h |7 +- include/configs/mx31ads.h |7 +- include/configs/sbc2410x.h|7 +- include/configs/smdk2400.h|7 +- include/configs/smdk2410.h|7 +- include/configs/smdk6400.h|7 +- include/configs/trab.h|7 +- include/netdev.h |1 + lib_arm/board.c |9 -- 38 files changed, 448 insertions(+), 205 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] reset environment
Dear Dexdyne Postmaster, whoops - fixed that now!!! This depends on your configuration. When using an embedded environment, this will get replaced with each install. this will get replaced with each install sorry - I don't know how you mean that will happen OK - I'm working on an AVR32 - if I follow the instructions they give, it replaces the u-boot code, and leaves the environment sector in flash unchanged. I have added a 1-byte-write to the sector to my script to corrupt it but a command would be easier. Worse, there doesn't seem to be a command to say over-write that with your new defaults You can run a script image that does whatever you want. OK again - I don't seem to have scripting enabled in my u-boot - I'd like to do that so I can use in by boot sequence. What would I put in a script to have the effect of forcing a load of the new defaults??? If there's no single command, do you mean I could make up a script full of set commands? If that is indeed so, then can I propose such a command should be added? Search the archives. There has been a proposal before, and even an API has been agreed on, it's just that nobody implemented it yet. Patches are welcome. I did some reading last night, and did indeed find the proposed implementation on the to-do list Thanks David Collier www.dexdyne.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/1][Net] Convert CS8900 Ethernet driver to CONFIG_NET_MULTI API
All in-tree boards that use this controller have CONFIG_NET_MULTI added Also: - changed CONFIG_DRIVER_CS8900 to CONFIG_CS8900 - changed CS8900_BASE to CONFIG_CS8900_BASE - changed CS8900_BUS?? to CONFIG_CS8900_BUS?? - cleaned up line lengths - modified VCMA9 command function that accesses the device - removed MAC address initialization from lib_arm/board.c Signed-off-by: Ben Warren biggerbadder...@gmail.com --- board/altera/dk1c20/dk1c20.c | 12 ++ board/altera/dk1s10/dk1s10.c | 12 ++ board/armadillo/armadillo.c | 12 ++ board/csb226/csb226.c | 12 ++ board/ep7312/ep7312.c | 12 ++ board/freescale/mx31ads/mx31ads.c | 12 ++ board/impa7/impa7.c | 12 ++ board/lart/lart.c | 12 ++ board/mpl/vcma9/cmd_vcma9.c | 28 +++-- board/mpl/vcma9/vcma9.c | 12 ++ board/mx1ads/mx1ads.c | 12 ++ board/samsung/smdk2400/smdk2400.c | 12 ++ board/samsung/smdk2410/smdk2410.c | 12 ++ board/samsung/smdk6400/smdk6400.c | 12 ++ board/sbc2410x/sbc2410x.c | 12 ++ board/ssv/adnpesc1/adnpesc1.c | 12 ++ board/trab/trab.c | 12 ++ drivers/net/Makefile |2 +- drivers/net/cs8900.c | 243 - drivers/net/cs8900.h | 41 --- include/configs/ADNPESC1.h| 14 ++- include/configs/DK1C20.h | 14 ++- include/configs/DK1S10.h | 14 ++- include/configs/VCMA9.h |7 +- include/configs/armadillo.h |9 +- include/configs/csb226.h |7 +- include/configs/ep7312.h |9 +- include/configs/impa7.h |7 +- include/configs/lart.h|7 +- include/configs/mx1ads.h |7 +- include/configs/mx31ads.h |7 +- include/configs/sbc2410x.h|7 +- include/configs/smdk2400.h|7 +- include/configs/smdk2410.h|7 +- include/configs/smdk6400.h|7 +- include/configs/trab.h|7 +- include/netdev.h |1 + lib_arm/board.c |9 -- 38 files changed, 448 insertions(+), 205 deletions(-) diff --git a/board/altera/dk1c20/dk1c20.c b/board/altera/dk1c20/dk1c20.c index 11c19b7..0bcaa4f 100644 --- a/board/altera/dk1c20/dk1c20.c +++ b/board/altera/dk1c20/dk1c20.c @@ -25,6 +25,7 @@ */ #include common.h +#include netdev.h #include nios-io.h #ifdefined(CONFIG_SEVENSEG) #include ../common/sevenseg.h @@ -79,3 +80,14 @@ int ide_preinit (void) return 0; } #endif + +#ifdef CONFIG_CMD_NET +int board_eth_init(bd_t *bis) +{ + int rc = 0; +#ifdef CONFIG_CS8900 + rc = cs8900_initialize(0, CONFIG_CS8900_BASE); +#endif + return rc; +} +#endif diff --git a/board/altera/dk1s10/dk1s10.c b/board/altera/dk1s10/dk1s10.c index 64d591e..fb96501 100644 --- a/board/altera/dk1s10/dk1s10.c +++ b/board/altera/dk1s10/dk1s10.c @@ -22,6 +22,7 @@ */ #include common.h +#include netdev.h #ifdefined(CONFIG_SEVENSEG) #include ../common/sevenseg.h #endif @@ -58,3 +59,14 @@ phys_size_t initdram (int board_type) { return (0); } + +#ifdef CONFIG_CMD_NET +int board_eth_init(bd_t *bis) +{ + int rc = 0; +#ifdef CONFIG_CS8900 + rc = cs8900_initialize(0, CONFIG_CS8900_BASE); +#endif + return rc; +} +#endif diff --git a/board/armadillo/armadillo.c b/board/armadillo/armadillo.c index ca5bd1d..a825144 100644 --- a/board/armadillo/armadillo.c +++ b/board/armadillo/armadillo.c @@ -26,6 +26,7 @@ */ #include common.h +#include netdev.h #include clps7111.h DECLARE_GLOBAL_DATA_PTR; @@ -58,3 +59,14 @@ int dram_init (void) return (0); } + +#ifdef CONFIG_CMD_NET +int board_eth_init(bd_t *bis) +{ + int rc = 0; +#ifdef CONFIG_CS8900 + rc = cs8900_initialize(0, CONFIG_CS8900_BASE); +#endif + return rc; +} +#endif diff --git a/board/csb226/csb226.c b/board/csb226/csb226.c index 80caf8b..0a6c13d 100644 --- a/board/csb226/csb226.c +++ b/board/csb226/csb226.c @@ -24,6 +24,7 @@ */ #include common.h +#include netdev.h #include asm/arch/pxa-regs.h DECLARE_GLOBAL_DATA_PTR; @@ -151,3 +152,14 @@ void show_boot_progress (int status) return; } + +#ifdef CONFIG_CMD_NET +int board_eth_init(bd_t *bis) +{ + int rc = 0; +#ifdef CONFIG_CS8900 + rc = cs8900_initialize(0, CONFIG_CS8900_BASE); +#endif + return rc; +} +#endif diff --git a/board/ep7312/ep7312.c b/board/ep7312/ep7312.c index 6968a5d..8ed14ad 100644 --- a/board/ep7312/ep7312.c +++ b/board/ep7312/ep7312.c @@ -23,6 +23,7 @@ */ #include common.h +#include netdev.h #include clps7111.h DECLARE_GLOBAL_DATA_PTR; @@ -52,3 +53,14 @@ int dram_init (void) return (0); } + +#ifdef CONFIG_CMD_NET +int board_eth_init(bd_t *bis) +{ + int rc = 0; +#ifdef CONFIG_CS8900 + rc = cs8900_initialize(0, CONFIG_CS8900_BASE); +#endif + return rc; +}
Re: [U-Boot] driving a serial peripheral in u-boot
Is there an example anywhere of u-boot talking to a device on a serial port ( which is not the console ) I can use as an example? See common/modem.c and search the code for mdm_init(). h Goodie - thanks. David Collier www.dexdyne.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Why u-boot linux uses different machineid for at91rm9200dk
Hello, Why u-boot linux uses different machine id for at91rm9200dk. is seems that u-boot is using 0x00FB linux is using 0x0106. Can we fix this in u-boot itself ? Thanks Regards vibi sreenivasan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] modem pass-through
I was reading the notes about openmoko and saw that they had implemented a serial pass-through to allow the on-board GSM modem to be driven via an external serial port. Did that feature ever make it's way into the standard u-boot code??? David Collier www.dexdyne.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] eeprom_m95xxx: remove unused variable i
Hi Wolfgang, On Fri, Aug 07, 2009 at 11:56:21PM +0200, Wolfgang Denk wrote : Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1249681074-21164-1-git-send-email-plagn...@jcrosoft.com you wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- drivers/mtd/spi/eeprom_m95xxx.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) No such file or directory. This patch can be applied now, the driver made it into mainline. Regards, -- Albin Tonnerre, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] dtt, lm81: move unneccessary printf into a debug printf
Dear Heiko Schocher, In message 4a812de6.5040...@denx.de you wrote: Signed-off-by: Heiko Schocher h...@denx.de --- drivers/hwmon/lm81.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Probably the best operating system in the world is the [operating system] made for the PDP-11 by Bell Laboratories. - Ted Nelson, October 1977 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] NAND issues
Hi All, I have been using the nand erase.e command with favourable results till now. I was enticed by the CONFIG_JFFS2_NAND option in the platform config. When i turn this config option on and use the NAND. write.jffs2 , and use the resulting image, i get abnormal results including a kernel crash. What is the difference between a nand write.jffs2 and the traditional nand write.e command? I haven't been able to dig up on any relevant documention. I haven't grepped through the common source for the NAND subsystem. Are the commands any different , which of the commands is deprecated? i was guessing nand write.e understands bad blocks whereas nand write.jffs2 understands bad blocks as well as jffs2 internals like cleanmarker etc. Which one should i be using? Thanks, Alfred ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Where is the GPR30 register in PowerPC arch as GOT pointer of C code documented?
I find nothing about this in (E)ABI specification(perhaps some old), so, where is it? Thanks. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Where is the GPR30 register in PowerPC arch as GOT pointer of C code documented?
I find nothing about this in (E)ABI specification(perhaps some old), so, where is it? Thanks. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Where is the GPR30 register in PowerPC arch as GOT pointer of C code documented?
On Aug 12, 2009, at 8:46 AM, Gao Ya'nan wrote: I find nothing about this in (E)ABI specification(perhaps some old), so, where is it? You want the ABI that is available here: http://refspecs.freestandards.org/elf/elfspec_ppc.pdf The EABI is just extensions on top of it. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Network defrag
On Mon 10 Aug 2009 15:57, Ben Warren pondered: Robin Getz wrote: Thanks to Alessandro for putting it together. Feel free to add my Signed-off (once the docs have been updated explaining what this is all for). I'll do that. Thanks for all your help. Some info for the docs, when I was troubleshooting a Ubuntu 9.04 install. == It appears that some tftp servers (the older BSD version, Debian's tftpd) doesn't support RFC 2348 (blksize), and always use a block size of 512 :( You need to make sure that you install the the Peter Anvin version, which does support RFC 2348, and blksize up to 65,464 bytes (Debian's tftpd-hpa). http://www.kernel.org/pub/software/network/tftp/ How to tell which you have? Check your man page: man tftpd or ask for the version: Peter Anvin version: rg...@imhotep:~ /usr/sbin/in.tftpd -V tftp-hpa 0.48, with remap, with tcpwrappers rg...@imhotep:~ non-RFC 2348 one: rg...@imhotep:~ /usr/sbin/in.tftpd -V rg...@imhotep:~ Even when using the Peter Anvin version, block size can still be reduced via two methods: -B : limits the maximum permitted block size (-B 512) -r : rejects RFC 2347 TFTP options (-r blksize) Check your local /etc/xinetd.d/tftp or /etc/inetd.conf file to see how your tftpd server is being invoked. === -Robin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] OMAP3 Move cache routines to cache.S
v7_flush_dcache_all, because it depends on omap ROM code is not generic. Rename the function to 'invalidate_dcache' and move it to the omap cpu directory. Collect the other omap cache routines l2_cache_enable and l2_cache_disable with invalide_dcache into cache.S. This means removing the old cache.c file that contained l2_cache_enable and l2_cache_disable. The conversion from cache.c to cache.S was done most through disassembling the uboot binary. The only significant change was to change the comparision for the return of get_cpu_rev from cmp r0, #0 beq earlier_than_label Which was lost information to cmp r0, #CPU_3XX_ES20 blt earlier_than_label The paths through the enable routine were verified by adding an infinite loop and seeing the hang. Then removing the infinite loop and seeing it continue. The disable routine is similar enough that it was not tested with this method. Run tested by cold booting from nand on beagle and zoom1. Compile tested on MAKEALL arm. Signed-off-by: Tom Rix tom@windriver.com --- cpu/arm_cortexa8/cpu.c |2 +- cpu/arm_cortexa8/omap3/Makefile|2 +- cpu/arm_cortexa8/omap3/board.c |2 +- cpu/arm_cortexa8/omap3/cache.S | 191 cpu/arm_cortexa8/omap3/cache.c | 95 cpu/arm_cortexa8/start.S | 85 -- include/asm-arm/arch-omap3/omap3.h |2 + include/asm-arm/arch-omap3/sys_proto.h |2 +- 8 files changed, 197 insertions(+), 184 deletions(-) create mode 100644 cpu/arm_cortexa8/omap3/cache.S delete mode 100644 cpu/arm_cortexa8/omap3/cache.c diff --git a/cpu/arm_cortexa8/cpu.c b/cpu/arm_cortexa8/cpu.c index 5a5981e..a01e0d6 100644 --- a/cpu/arm_cortexa8/cpu.c +++ b/cpu/arm_cortexa8/cpu.c @@ -64,7 +64,7 @@ int cleanup_before_linux(void) /* turn off L2 cache */ l2_cache_disable(); /* invalidate L2 cache also */ - v7_flush_dcache_all(get_device_type()); + invalidate_dcache(get_device_type()); #endif i = 0; /* mem barrier to sync up things */ diff --git a/cpu/arm_cortexa8/omap3/Makefile b/cpu/arm_cortexa8/omap3/Makefile index eef165c..136b163 100644 --- a/cpu/arm_cortexa8/omap3/Makefile +++ b/cpu/arm_cortexa8/omap3/Makefile @@ -26,10 +26,10 @@ include $(TOPDIR)/config.mk LIB= $(obj)lib$(SOC).a SOBJS := lowlevel_init.o +SOBJS += cache.o SOBJS += reset.o COBJS += board.o -COBJS += cache.o COBJS += clock.o COBJS += gpio.o COBJS += mem.o diff --git a/cpu/arm_cortexa8/omap3/board.c b/cpu/arm_cortexa8/omap3/board.c index 2337287..43262e7 100644 --- a/cpu/arm_cortexa8/omap3/board.c +++ b/cpu/arm_cortexa8/omap3/board.c @@ -201,7 +201,7 @@ void s_init(void) * Right now flushing at low MPU speed. * Need to move after clock init */ - v7_flush_dcache_all(get_device_type()); + invalidate_dcache(get_device_type()); #ifndef CONFIG_ICACHE_OFF icache_enable(); #endif diff --git a/cpu/arm_cortexa8/omap3/cache.S b/cpu/arm_cortexa8/omap3/cache.S new file mode 100644 index 000..0f63815 --- /dev/null +++ b/cpu/arm_cortexa8/omap3/cache.S @@ -0,0 +1,191 @@ +/* + * Copyright (c) 2009 Wind River Systems, Inc. + * Tom Rix tom@windriver.com + * + * This file is based on and replaces the existing cache.c file + * The copyrights for the cache.c file are: + * + * (C) Copyright 2008 Texas Insturments + * + * (C) Copyright 2002 + * Sysgo Real-Time Solutions, GmbH www.elinos.com + * Marius Groeger mgroe...@sysgo.de + * + * (C) Copyright 2002 + * Gary Jennejohn, DENX Software Engineering, g...@denx.de + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ + +#include asm/arch/omap3.h + +/* + * omap3 cache code + */ + +.align 5 +.global invalidate_dcache +.global l2_cache_enable +.global l2_cache_disable + +/* + * invalidate_dcache() + * + * Invalidate the whole D-cache. + * + * Corrupted registers: r0-r5, r7, r9-r11 + * + * - mm- mm_struct describing address space + */ +invalidate_dcache: + stmfd r13!, {r0 - r5, r7, r9 - r12, r14} + + mov r7, r0 @ take a backup of device type + cmp r0, #0x3
[U-Boot] [PATCH] flash: Fix CFI buffer size bug
Fix bug introduced by 9c048b523413ae5f3ff34e00cf57569c3368ab51. The cfi_flash.c driver cast the flash buffer size to a uchar in flash_write_cfibuffer(). On some flash parts, (tested on Numonyx part PC32F512M29EWH), the buffer size is 1KB. Remove the cast to uchar to enable buffer sizes to be larger. Signed-off-by: John Schmoller jschmol...@xes-inc.com --- drivers/mtd/cfi_flash.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c index 12647ef..1152629 100644 --- a/drivers/mtd/cfi_flash.c +++ b/drivers/mtd/cfi_flash.c @@ -971,7 +971,7 @@ static int flash_write_cfibuffer (flash_info_t * info, ulong dest, uchar * cp, #endif flash_write_cmd(info, sector, offset, AMD_CMD_WRITE_TO_BUFFER); cnt = len shift; - flash_write_cmd(info, sector, offset, (uchar)cnt - 1); + flash_write_cmd(info, sector, offset, cnt - 1); switch (info-portwidth) { case FLASH_CFI_8BIT: -- 1.6.0.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] RE ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache
Dear Tom Rix, In message 1246898879-6567-2-git-send-email-tom@windriver.com you wrote: --===0808050101== Since there is only one version of flushing the dcache for arm_cortex8, rename v7_flush_dcache_all to the the generic name flush_dcache. Because the function is intended for only omap3 boards, move the function to the new file cache_flush.S. snip Sorry, this patch does not apply any more: snip Patch failed at 0001. Please rebase and resubmit (also patch 2/2). Best regards, Wolfgang Denk Wolfgang, I have rebased the patch the to the u-boot master branch. It includes the moving of omap3 cache routines to cache.S that Jean requested and renaming flush_dache to invalidate_dcache that Richard requested. Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] smc91111: switch to MULTI_NET api
Jean-Christophe, Jean-Christophe PLAGNIOL-VILLARD wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com I already posted a patch that does this and asked for help testing. It is available in the net/next repo. If you find it to be inadequate, please provide patches to make it work. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] AT91: Add support for blue_LED_* and add coloured_LED_init to at91/led.c
Currently, at91/led.c only provides _on and _off functions for green, yellow and red LEDs. This patch provides a generic coloured_LED_init function, which is a first step towards getting rid of the board-specific (and duplicated) board/*/*/led.c files on at91 This patch alos adds similar support for blue LEDs, mostly for the sake of completeness. Signed-off-by: Albin Tonnerre albin.tonne...@free-electrons.com --- cpu/arm926ejs/at91/led.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/cpu/arm926ejs/at91/led.c b/cpu/arm926ejs/at91/led.c index be68f59..f6b1912 100644 --- a/cpu/arm926ejs/at91/led.c +++ b/cpu/arm926ejs/at91/led.c @@ -27,6 +27,26 @@ #include asm/arch/gpio.h #include asm/arch/io.h +void coloured_LED_init(void) +{ +#ifdef CONFIG_RED_LED + at91_set_gpio_output(CONFIG_RED_LED, 0); + red_LED_off(); +#endif +#ifdef CONFIG_GREEN_LED + at91_set_gpio_output(CONFIG_GREEN_LED, 0); + green_LED_off(); +#endif +#ifdef CONFIG_YELLOW_LED + at91_set_gpio_output(CONFIG_YELLOW_LED, 0); + yellow_LED_off(); +#endif +#ifdef CONFIG_BLUE_LED + at91_set_gpio_output(CONFIG_BLUE_LED, 0); + blue_LED_off(); +#endif +} + #ifdef CONFIG_RED_LED void red_LED_on(void) { @@ -62,3 +82,15 @@ void yellow_LED_off(void) at91_set_gpio_value(CONFIG_YELLOW_LED, 1); } #endif + +#ifdef CONFIG_BLUE_LED +void blue_LED_on(void) +{ + at91_set_gpio_value(CONFIG_BLUE_LED, 0); +} + +void blue_LED_off(void) +{ + at91_set_gpio_value(CONFIG_BLUE_LED, 1); +} +#endif -- 1.6.0.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] MTD:NAND: ADD new ECC mode NAND_ECC_HW_OOB_FIRST
Paulraj, Sandeep wrote: [Sandeep] I agree.At the beginning of the year we had a way to do it with the existing modes. WE had are own read and write funtions in the Davinci NAND driver to achieve what were are doing in this patch. But the solution was not accepted by the MTD community. I have given the link for the original kernel patches. This current solution had the blessings of Thomas Gleixner and David Brownell. OK. We'll do the same for now, then, but at some point (the ever-elusive when I get time) I'd like to try to straighten out the interface, and shrink the footprint. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S
Tom Rix wrote: v7_flush_dcache_all, because it depends on omap ROM code is not generic. Rename the function to 'invalidate_dcache' and move it to the omap cpu directory. Collect the other omap cache routines l2_cache_enable and l2_cache_disable with invalide_dcache into cache.S. This means removing the old cache.c file that contained l2_cache_enable and l2_cache_disable. The conversion from cache.c to cache.S was done most through disassembling the uboot binary. The only significant change was to change the comparision for the return of get_cpu_rev from cmpr0, #0 beqearlier_than_label Which was lost information to cmpr0, #CPU_3XX_ES20 bltearlier_than_label The paths through the enable routine were verified by adding an infinite loop and seeing the hang. Then removing the infinite loop and seeing it continue. The disable routine is similar enough that it was not tested with this method. Run tested by cold booting from nand on beagle and zoom1. Compile tested on MAKEALL arm. Boot tested from SD card on BeagleBoard. Signed-off-by: Tom Rix tom@windriver.com Acked-by: Dirk Behme dirk.be...@googlemail.com --- cpu/arm_cortexa8/cpu.c |2 +- cpu/arm_cortexa8/omap3/Makefile|2 +- cpu/arm_cortexa8/omap3/board.c |2 +- cpu/arm_cortexa8/omap3/cache.S | 191 cpu/arm_cortexa8/omap3/cache.c | 95 cpu/arm_cortexa8/start.S | 85 -- include/asm-arm/arch-omap3/omap3.h |2 + include/asm-arm/arch-omap3/sys_proto.h |2 +- 8 files changed, 197 insertions(+), 184 deletions(-) create mode 100644 cpu/arm_cortexa8/omap3/cache.S delete mode 100644 cpu/arm_cortexa8/omap3/cache.c diff --git a/cpu/arm_cortexa8/cpu.c b/cpu/arm_cortexa8/cpu.c index 5a5981e..a01e0d6 100644 --- a/cpu/arm_cortexa8/cpu.c +++ b/cpu/arm_cortexa8/cpu.c @@ -64,7 +64,7 @@ int cleanup_before_linux(void) /* turn off L2 cache */ l2_cache_disable(); /* invalidate L2 cache also */ - v7_flush_dcache_all(get_device_type()); + invalidate_dcache(get_device_type()); #endif i = 0; /* mem barrier to sync up things */ diff --git a/cpu/arm_cortexa8/omap3/Makefile b/cpu/arm_cortexa8/omap3/Makefile index eef165c..136b163 100644 --- a/cpu/arm_cortexa8/omap3/Makefile +++ b/cpu/arm_cortexa8/omap3/Makefile @@ -26,10 +26,10 @@ include $(TOPDIR)/config.mk LIB = $(obj)lib$(SOC).a SOBJS:= lowlevel_init.o +SOBJS+= cache.o SOBJS+= reset.o COBJS+= board.o -COBJS+= cache.o COBJS+= clock.o COBJS+= gpio.o COBJS+= mem.o diff --git a/cpu/arm_cortexa8/omap3/board.c b/cpu/arm_cortexa8/omap3/board.c index 2337287..43262e7 100644 --- a/cpu/arm_cortexa8/omap3/board.c +++ b/cpu/arm_cortexa8/omap3/board.c @@ -201,7 +201,7 @@ void s_init(void) * Right now flushing at low MPU speed. * Need to move after clock init */ - v7_flush_dcache_all(get_device_type()); + invalidate_dcache(get_device_type()); #ifndef CONFIG_ICACHE_OFF icache_enable(); #endif diff --git a/cpu/arm_cortexa8/omap3/cache.S b/cpu/arm_cortexa8/omap3/cache.S new file mode 100644 index 000..0f63815 --- /dev/null +++ b/cpu/arm_cortexa8/omap3/cache.S @@ -0,0 +1,191 @@ +/* + * Copyright (c) 2009 Wind River Systems, Inc. + * Tom Rix tom@windriver.com + * + * This file is based on and replaces the existing cache.c file + * The copyrights for the cache.c file are: + * + * (C) Copyright 2008 Texas Insturments + * + * (C) Copyright 2002 + * Sysgo Real-Time Solutions, GmbH www.elinos.com + * Marius Groeger mgroe...@sysgo.de + * + * (C) Copyright 2002 + * Gary Jennejohn, DENX Software Engineering, g...@denx.de + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ + +#include asm/arch/omap3.h + +/* + * omap3 cache code + */ + +.align 5 +.global invalidate_dcache +.global l2_cache_enable +.global l2_cache_disable + +/* + * invalidate_dcache() + * + * Invalidate the whole D-cache. + *
[U-Boot] [PATCH] Add support for the galaxy5200 board.
Add support for the DEKA RD galaxy5200 board. The patch is based off of the mpc5xxx branch. _ This e-mail and the information, including any attachments, it contains are intended to be a confidential communication only to the person or entity to whom it is addressed and may contain information that is privileged. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately notify the sender and destroy the original message. Thank you. Please consider the environment before printing this email. V1-Add-support-for-the-galaxy5200.patch Description: V1-Add-support-for-the-galaxy5200.patch ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] MTD:NAND: ADD new ECC mode NAND_ECC_HW_OOB_FIRST
On Wed, Aug 12, 2009 at 11:48:27AM -0500, Paulraj, Sandeep wrote: There are other issues. The NAND manufacturers have changed the format of the 4Th ID byte and some other are supporting ONFI. Current NAND driver has no support for these There are always other issues. :-) Unless the issues show up on hardware I'm working with, there's not much I can do other than apply patches from others. Shrinking the footprint will first need to be done in the MTD GIT and then the changes should trickle down to other trees including U-Boot. That would be preferable, but we are not obligated to follow Linux's lead if they aren't interested. So I take it that you will add these 2 patches to the u-boot-nand-flash/next git soon. Assuming no other issues, yes. -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] CFI Flash write speed
Dear A. Geisreiter, In message 01ca1a94$e0216f50$a0644d...@de you wrote: I have add CFI support to my project. I use Intel strata flash P30 and PXA270 CPU. The flash is connected with 16bit to the PXA data bus. If I write to the flash I have transfer rates of roughly 75kB/sec. I think this is very slow. How can I increase the transfer rate? Did you enable CONFIG_SYS_FLASH_USE_BUFFER_WRITE ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It is much easier to suggest solutions when you know nothing ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] net/eth_device: keep index inside each device
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1250023747-20224-1-git-send-email-plagn...@jcrosoft.com you wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- include/net.h |1 + net/eth.c | 17 + 2 files changed, 6 insertions(+), 12 deletions(-) What exactly is the problem you are addressing with this patch? Please provide a commit message that explains what is going on, and what is being changed or fixed. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When a program is being tested, it is too late to make design changes. -- Geoffrey James, The Tao of Programming ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] net: add getenv/setenv enetaddr function to use ethernet device num
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1250023747-20224-2-git-send-email-plagn...@jcrosoft.com you wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- include/net.h |2 ++ net/eth.c | 28 +--- 2 files changed, 27 insertions(+), 3 deletions(-) NAK. First, there are formal issues: - The subject line is way too long. - There is no commit message and no description what this patch is supposed to do or to fix. Why should we add it? index 2a8a12d..dc4ae41 100644 --- a/include/net.h +++ b/include/net.h @@ -124,6 +124,8 @@ extern void eth_set_enetaddr(int num, char* a); /* Set new MAC address */ extern void eth_parse_enetaddr(const char *addr, uchar *enetaddr); extern int eth_getenv_enetaddr(char *name, uchar *enetaddr); extern int eth_setenv_enetaddr(char *name, const uchar *enetaddr); +extern int eth_getenv_num_enetaddr(int num, uchar *enetaddr); +extern int eth_setenv_num_enetaddr(int num, const uchar *enetaddr); What are these functions god for? Are they by any chance duplicationg existing code, got example eth_getenv_enetaddr_by_index() ? extern int eth_init(bd_t *bis); /* Initialize the device */ extern int eth_send(volatile void *packet, int length); /* Send a packet */ diff --git a/net/eth.c b/net/eth.c index 2316a22..9bdf961 100644 --- a/net/eth.c +++ b/net/eth.c @@ -27,6 +27,12 @@ #include miidev.h #ifdef CONFIG_CMD_NET + +static void get_enetvar(int num, char *enetvar) Should this not be uchar *, to stay consistent with the other code? +{ + sprintf(enetvar, num ? eth%daddr : ethaddr, num); +} + void eth_parse_enetaddr(const char *addr, uchar *enetaddr) { char *end; @@ -53,6 +59,24 @@ int eth_setenv_enetaddr(char *name, const uchar *enetaddr) return setenv(name, buf); } + +int eth_getenv_num_enetaddr(int num, uchar *enetaddr) +{ + char enetvar[32]; + + get_enetvar(num, enetvar); + + return eth_getenv_enetaddr(enetvar, enetaddr); +} Looks very much like eth_getenv_enetaddr_by_index() to me. What do you need this for? Please elucidate... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The algorithm to do that is extremely nasty. You might want to mug someone with it. - M. Devine, Computer Science 340 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] smc91111: switch to MULTI_NET api
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1250023747-20224-3-git-send-email-plagn...@jcrosoft.com you wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com ... #ifdef CONFIG_SMC_USE_32_BIT -#define USE_32_BIT 1 +#define is_use_32bit(x) (x-use_32bit) Does switching from a compile time check to a run time check not cause an avoidable growth of the memory footprint? How much bigger is the new code? -#undef USE_32_BIT +#define is_use_32bit(x) (0) #endif ... -static inline word SMC_inw(dword offset) +static inline word SMC_io_inw(struct smc9_device *smc, dword offset) { word v; - v = *((volatile word*)(SMC_BASE_ADDRESS+offset)); + v = *((volatile word*)(smc-regs+offset)); barrier(); *(volatile u32*)(0xc000); return v; } -static inline void SMC_outw(word value, dword offset) +static inline void SMC_io_outw(struct smc9_device *smc, word value, +dword offset) { - *((volatile word*)(SMC_BASE_ADDRESS+offset)) = value; + *((volatile word*)(smc-regs+offset)) = value; barrier(); *(volatile u32*)(0xc000); } Please use proper I/O accessor functions here. -static inline byte SMC_inb(dword offset) +static inline byte SMC_io_inb(struct smc9_device *smc, dword offset) { word _w; ...and here. @@ -264,18 +234,22 @@ static inline byte SMC_inb(dword offset) return (offset 1) ? (byte)(_w 8) : (byte)(_w); } -static inline void SMC_outb(byte value, dword offset) +static inline void SMC_io_outb(struct smc9_device *smc, byte value, +dword offset) { word _w; _w = SMC_inw(offset ~((dword)1)); if (offset 1) - *((volatile word*)(SMC_BASE_ADDRESS+(offset ~((dword)1 = (value8) | (_w 0x00ff); + *((volatile word*)(smc-regs+(offset ~((dword)1 = + (value8) | (_w 0x00ff); else - *((volatile word*)(SMC_BASE_ADDRESS+offset)) = value | (_w 0xff00); + *((volatile word*)(smc-regs+offset)) = + value | (_w 0xff00); } ...and here. -static inline void SMC_insw(dword offset, volatile uchar* buf, dword len) +static inline void SMC_io_insw(struct smc9_device *smc, dword offset, +volatile uchar* buf, dword len) { volatile word *p = (volatile word *)buf; ...and here. @@ -286,7 +260,8 @@ static inline void SMC_insw(dword offset, volatile uchar* buf, dword len) } } -static inline void SMC_outsw(dword offset, uchar* buf, dword len) +static inline void SMC_io_outsw(struct smc9_device *smc, dword offset, + uchar* buf, dword len) { volatile word *p = (volatile word *)buf; ...and here. -static int smc_close() +static void smc_halt(struct eth_device *netdev) { + struct smc9_device *smc = to_smc9(netdev); PRINTK2(%s: smc_close\n, SMC_DEV_NAME); You should also adapt the debug messages to the changed function names. +#ifdef CONFIG_SMC_USE_32_BIT +#define USE_32BIT 1 +#else +#define USE_32BIT 0 +#endif Above you get rid of the USE_32BIT stuff; here you re-introduce it. Why? diff --git a/drivers/net/smc9.h b/drivers/net/smc9.h index 967addd..b2ed6a5 100644 --- a/drivers/net/smc9.h +++ b/drivers/net/smc9.h @@ -72,6 +72,10 @@ typedef unsigned long int dword; /* Because of bank switching, the LAN91xxx uses only 16 I/O ports */ +#ifndef SMC_BASE_ADDRESS +#define SMC_BASE_ADDRESS smc-regs +#endif + #define SMC_IO_EXTENT 16 #ifdef CONFIG_PXA250 @@ -301,8 +305,6 @@ typedef unsigned long int dword; #endif /* CONFIG_SMC_USE_IOFUNCS */ -#if defined(CONFIG_SMC_USE_32_BIT) - #ifdef CONFIG_XSENGINE #define SMC_inl(r) (*((volatile dword *)(SMC_BASE_ADDRESS+(r1 This should be fixed to use I/O accessors, too. include/configs/ADNPESC1.h |1 + include/configs/DK1C20.h |1 + include/configs/DK1S10.h |1 + include/configs/EP1C20.h |1 + include/configs/EP1S10.h |1 + include/configs/EP1S40.h |1 + include/configs/MigoR.h |1 + include/configs/PK1C20.h |1 + include/configs/bf533-ezkit.h|1 + include/configs/bf533-stamp.h|1 + include/configs/bf538f-ezkit.h |1 + include/configs/bf561-ezkit.h|1 + include/configs/blackstamp.h |1 + include/configs/cerf250.h|1 + include/configs/cm-bf533.h |1 + include/configs/cm-bf561.h |1 + include/configs/cradle.h |1 + include/configs/delta.h |1 + include/configs/dnp1110.h|1 + include/configs/gr_cpci_ax2000.h |1 + include/configs/gr_ep2s60.h |1 +
Re: [U-Boot] Write back flash content to SD/MMC Card
Dear A. Geisreiter, In message 01ca1b14$5b5e4100$121ac3...@de you wrote: I will write back the complete content of my flash memory to a binary File on SD/MMC Card. How can I do this? Is there any support to create a file on SD/MMC card? Yes, there is such support - under Linux. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de One of the advantages of being a captain is being able to ask for ad- vice without necessarily having to take it. -- Kirk, Dagger of the Mind, stardate 2715.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] NAND issues
On Wed, Aug 12, 2009 at 12:30:02AM -0500, alfred steele wrote: I have been using the nand erase.e command with favourable results till now. I was enticed by the CONFIG_JFFS2_NAND option in the platform config. When i turn this config option on and use the NAND. write.jffs2 , and use the resulting image, i get abnormal results including a kernel crash. What is the difference between a nand write.jffs2 and the traditional nand write.e command? I haven't been able to dig up on any relevant documention. I haven't grepped through the common source for the NAND subsystem. Assuming you're talking about a recent version of u-boot, there is no difference in any of the nand write suffixes. They are maintained for compatibility only. They used to indicate that bad blocks should be skipped, but we do that by default now. Are the commands any different , which of the commands is deprecated? i was guessing nand write.e understands bad blocks whereas nand write.jffs2 understands bad blocks as well as jffs2 internals like cleanmarker etc. No, if you want cleanmarkers written you can use nand erase clean. Which one should i be using? Just nand write, unless you have an old u-boot (more than a year or so). -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Why u-boot linux uses different machineid for at91rm9200dk
Dear vibi sreenivasan, In message 1250062753.2419.8.ca...@hunter you wrote: Why u-boot linux uses different machine id for at91rm9200dk. do they? well, which exact versions of U-Boot and Linux are you talking about? is seems that u-boot is using 0x00FB linux is using 0x0106. Can we fix this in u-boot itself ? In U-Boot I see: - grep MACH_TYPE_AT91RM9200DK include/asm-arm/mach-types.h #define MACH_TYPE_AT91RM9200DK 262 # define machine_arch_type MACH_TYPE_AT91RM9200DK # define machine_is_at91rm9200dk() (machine_arch_type == # MACH_TYPE_AT91RM9200DK) 262 = 0x106. This iseems to be what Linux uses, too, and what is officially registered. Maybe you should update your code? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You can't have everything... where would you put it? - Steven Wright ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/2] mpc8349: delete unused SYS_MID_FLASH_JUMP
This was introduced with the MPC8349EMDS board, and then copied to a couple other boards by nature of being the reference implementation. u-boot$git grep CONFIG_SYS_MID_FLASH_JUMP include/configs/MPC8349EMDS.h:#define CONFIG_SYS_MID_FLASH_JUMP 0x7F00 include/configs/sbc8349.h:#define CONFIG_SYS_MID_FLASH_JUMP 0x7F00 include/configs/vme8349.h:#define CONFIG_SYS_MID_FLASH_JUMP 0x7F00 u-boot$ It currently isn't used, so delete it before it spreads further. Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com --- include/configs/MPC8349EMDS.h |1 - include/configs/sbc8349.h |1 - include/configs/vme8349.h |1 - 3 files changed, 0 insertions(+), 3 deletions(-) diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h index 3cf59ef..a8c8a79 100644 --- a/include/configs/MPC8349EMDS.h +++ b/include/configs/MPC8349EMDS.h @@ -172,7 +172,6 @@ #define CONFIG_SYS_FLASH_ERASE_TOUT6 /* Flash Erase Timeout (ms) */ #define CONFIG_SYS_FLASH_WRITE_TOUT500 /* Flash Write Timeout (ms) */ -#define CONFIG_SYS_MID_FLASH_JUMP 0x7F00 #define CONFIG_SYS_MONITOR_BASETEXT_BASE /* start of monitor */ #if (CONFIG_SYS_MONITOR_BASE CONFIG_SYS_FLASH_BASE) diff --git a/include/configs/sbc8349.h b/include/configs/sbc8349.h index 088b283..4f2aef0 100644 --- a/include/configs/sbc8349.h +++ b/include/configs/sbc8349.h @@ -157,7 +157,6 @@ #define CONFIG_SYS_FLASH_ERASE_TOUT6 /* Flash Erase Timeout (ms) */ #define CONFIG_SYS_FLASH_WRITE_TOUT500 /* Flash Write Timeout (ms) */ -#define CONFIG_SYS_MID_FLASH_JUMP 0x7F00 #define CONFIG_SYS_MONITOR_BASETEXT_BASE /* start of monitor */ #if (CONFIG_SYS_MONITOR_BASE CONFIG_SYS_FLASH_BASE) diff --git a/include/configs/vme8349.h b/include/configs/vme8349.h index 1477552..35d367d 100644 --- a/include/configs/vme8349.h +++ b/include/configs/vme8349.h @@ -152,7 +152,6 @@ #define CONFIG_SYS_FLASH_ERASE_TOUT6 /* Flash Erase TO (ms) */ #define CONFIG_SYS_FLASH_WRITE_TOUT500 /* Flash Write TO (ms) */ -#define CONFIG_SYS_MID_FLASH_JUMP 0x7F00 #define CONFIG_SYS_MONITOR_BASETEXT_BASE /* start of monitor */ #if (CONFIG_SYS_MONITOR_BASE CONFIG_SYS_FLASH_BASE) -- 1.6.3.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2] sbc8349: make enabling PCI more user friendly.
Prior to this commit, to enable PCI, you had to go manually edit the board config header, which isn't really user friendly. This adds the typical PCI make targets to the toplevel Makefile in accordance with what is being done with other boards. Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com --- Makefile | 19 +++- doc/README.sbc8349| 50 ++-- include/configs/sbc8349.h | 22 +++ 3 files changed, 64 insertions(+), 27 deletions(-) diff --git a/Makefile b/Makefile index 329e0f5..da98900 100644 --- a/Makefile +++ b/Makefile @@ -2375,8 +2375,23 @@ MPC837XERDB_config: unconfig MVBLM7_config: unconfig @$(MKCONFIG) $(@:_config=) ppc mpc83xx mvblm7 matrix_vision -sbc8349_config:unconfig - @$(MKCONFIG) $(@:_config=) ppc mpc83xx sbc8349 +sbc8349_config \ +sbc8349_PCI_33_config \ +sbc8349_PCI_66_config: unconfig + @mkdir -p $(obj)include + @if [ $(findstring _PCI_,$@) ] ; then \ + $(XECHO) -n ... PCI HOST at ; \ + echo #define CONFIG_PCI $(obj)include/config.h ; \ + fi ; \ + if [ $(findstring _33_,$@) ] ; then \ + $(XECHO) -n 33MHz... ; \ + echo #define PCI_33M $(obj)include/config.h ; \ + fi ; \ + if [ $(findstring _66_,$@) ] ; then \ + $(XECHO) -n 66MHz... ; \ + echo #define PCI_66M $(obj)include/config.h ; \ + fi ; + @$(MKCONFIG) -a sbc8349 ppc mpc83xx sbc8349 SIMPC8313_LP_config \ SIMPC8313_SP_config: unconfig diff --git a/doc/README.sbc8349 b/doc/README.sbc8349 index 908e768..2c35919 100644 --- a/doc/README.sbc8349 +++ b/doc/README.sbc8349 @@ -91,19 +91,37 @@ safety check before resetting the board upon completion of the reflash. PCI: -This board and U-Boot have been tested with PCI built in, on a SBC8349 -and confirmed that the pci command showed the intel e1000 that was -present in the PCI slot. Note that if a 33MHz 32bit card is inserted -in the slot, then the whole board will clock down to a 33MHz base -clock instead of the default 66MHz. This will change the baud clocks -and mess up your serial console output. If you want to use a 33MHz PCI -card, then you should build a U-Boot with #undef PCI_66M in the -include/configs/sbc8349.h and store this to flash prior to powering down -the board and inserting the 33MHz PCI card. - -By default PCI support is disabled to better support very early -revision MPC834x chips with possible PCI issues. Also PCI support is -untested on the sbc8347 variants at this point in time. - - - Paul Gortmaker, 01/2007 +There are three configuration choices: + sbc8349_config + sbc8349_PCI_33_config + sbc8349_PCI_66_config + +The 1st does not enable CONFIG_PCI, and assumes that the PCI slot +will be left empty (M66EN high), and so the board will operate with +a base clock of 66MHz. Note that you need both PCI enabled in u-boot +and linux in order to have functional PCI under linux. The only +reason for choosing to not enable PCI would be if you had a very +early (rev 1.0) CPU with possible PCI issues. + +The second enables PCI support and builds for a 33MHz clock rate. Note +that if a 33MHz 32bit card is inserted in the slot, then the whole board +will clock down to a 33MHz base clock instead of the default 66MHz. This +will change the baud clocks and mess up your serial console output if you +were previously running at 66MHz. If you want to use a 33MHz PCI card, +then you should build a U-Boot with sbc8349_PCI_33_config and store this +to flash prior to powering down the board and inserting the 33MHz PCI +card. + +The third option builds PCI support in, and leaves the clocking at the +default 66MHz. This has been tested with an intel PCI-X e1000 card. +This is also the appropriate choice for people with a recent (non 1.0) +CPU who currently have the PCI slot physically empty, but intend to +possibly add a PCI-X card at a later date. + + = pci + Scanning PCI devices on bus 0 + BusDevFun VendorId DeviceId Device Class Sub-Class + _ + 00.00.00 0x1957 0x0080 Processor 0x20 + 00.11.00 0x8086 0x1026 Network controller 0x00 + = diff --git a/include/configs/sbc8349.h b/include/configs/sbc8349.h index 868bd54..088b283 100644 --- a/include/configs/sbc8349.h +++ b/include/configs/sbc8349.h @@ -40,24 +40,28 @@ #define CONFIG_MPC8349 1 /* MPC8349 specific */ #define CONFIG_SBC8349 1 /* WRS SBC8349 board specific */ -#undef CONFIG_PCI /* Don't enable PCI2 on sbc834x - it doesn't exist physically. */ #undef CONFIG_MPC83XX_PCI2 /* support for 2nd PCI controller */ -#define PCI_66M -#ifdef PCI_66M -#define CONFIG_83XX_CLKIN 6600/* in Hz */ -#else +/*
Re: [U-Boot] taking the time pressure off board init
Dear David Collier, In message memo.20090812101728.100...@postmaster+dexdyne.com.cix.co.uk you wrote: I'm working on an AVR32 with a funny system of warm boots caused by watchdog which don't fully reset the watchdog or real-time-counter hardware. I think the system allows RTC interrupts to be generated during or after the warm boot which can cause havoc with the existing code. It certainly means you have to rush to the watchdog and disable it within a second, or you'll loop. I have to admit that I don't understand what you really mean. Please try again and explain in simple words... Note that if you can actually disable your watchdog in software, then it was not worth the effort of adding it. Also, a second is a very, very long time. U-Boot should be trivially able to trigger the watchdog in this time. It is able to do so with watchdogs with just a few ten milliseconds trigger period. I have found it reasonable to add an cpu_early_init leading into an clock_early_init. I have no idea what you want to do, or why. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Nothing in progression can rest on its original plan. We may as well think of rocking a grown man in the cradle of an infant. - Edmund Burke ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Make TFTP Quiet
On Wed, Aug 12, 2009 at 12:02:33PM +0200, Detlev Zundel wrote: Hi Timur, +#ifdef CONFIG_TFTP_QUIET +#define puts_quiet(fmt) +#else +#define puts_quiet(fmt) puts(fmt); +#endif This looks backwards to me. I would do this: #ifdef CONFIG_TFTP_QUIET #define puts(x) puts_quiet(x) #endif That way, you don't need to change all of the puts calls to puts_quiet. Plus, having the normal calls be puts_quiet that changes to puts when QUIET is *not* enabled just feels wrong. Just as a general remark - I consider it a bad idea to overload well known functions with non-standard behaviour. This breaks the principle of least surprise which turns out to be very valuable. Technically, U-Boot's puts() is already non-standard (no automatic newline)... But there's no redefinition in the original patch. It's just introducing a new puts_quiet(). -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] modem pass-through
Dear David Collier, In message memo.20090812101728.100...@postmaster+dexdyne.com.cix.co.uk you wrote: I was reading the notes about openmoko and saw that they had implemented a serial pass-through to allow the on-board GSM modem to be driven via an external serial port. Did that feature ever make it's way into the standard u-boot code??? No. Only patches that get posted here have a chance for inclusion into mainline. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The first 90% of a project takes 90% of the time, the last 10% takes the other 90% of the time. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Make TFTP Quiet
On Wed 12 Aug 2009 15:48, Scott Wood pondered: On Wed, Aug 12, 2009 at 12:02:33PM +0200, Detlev Zundel wrote: Hi Timur, +#ifdef CONFIG_TFTP_QUIET +#define puts_quiet(fmt) +#else +#define puts_quiet(fmt) puts(fmt); +#endif This looks backwards to me. I would do this: #ifdef CONFIG_TFTP_QUIET #define puts(x) puts_quiet(x) #endif That way, you don't need to change all of the puts calls to puts_quiet. Plus, having the normal calls be puts_quiet that changes to puts when QUIET is *not* enabled just feels wrong. Just as a general remark - I consider it a bad idea to overload well known functions with non-standard behaviour. This breaks the principle of least surprise which turns out to be very valuable. Technically, U-Boot's puts() is already non-standard (no automatic newline)... But there's no redefinition in the original patch. It's just introducing a new puts_quiet(). Yeah, I think Detlev was just commenting on Timur's suggestion to the patch, not on the original patch... I would be happy to change things to a debugX() - but this changes everyone's default behaviour (it becomes opt in, not opt-out), and most likely would cause some puzzlement when normally things don't print like they use to... ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Network defrag
Dear Robin Getz, In message 200908121148.16431.rg...@blackfin.uclinux.org you wrote: Some info for the docs, when I was troubleshooting a Ubuntu 9.04 install. Good info, but bad format. Can you please submit this as a patch? Thanks in advance. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A year spent in artificial intelligence is enough to make one believe in God. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Network defrag
Hi Robin, Robin Getz wrote: On Mon 10 Aug 2009 15:57, Ben Warren pondered: Robin Getz wrote: Thanks to Alessandro for putting it together. Feel free to add my Signed-off (once the docs have been updated explaining what this is all for). I'll do that. Thanks for all your help. Some info for the docs, when I was troubleshooting a Ubuntu 9.04 install. == It appears that some tftp servers (the older BSD version, Debian's tftpd) doesn't support RFC 2348 (blksize), and always use a block size of 512 :( You need to make sure that you install the the Peter Anvin version, which does support RFC 2348, and blksize up to 65,464 bytes (Debian's tftpd-hpa). http://www.kernel.org/pub/software/network/tftp/ Maybe it would make sense to have a message printed if the user specifies a higher blocksize but the TFTP server doesn't respond to the 'blksize' request. Thoughts? Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ext2fs.c/ext2fs_mount() fails when inode_size = 256
Dear Bob Furber, In message 4a82eb38.6060...@steroidmicros.com you wrote: Our SBC have been happily booting uClinux from ext3 partitioned SD cards prepared on a Fedora Linux-2.6.15 PC. ... Any thoughts or comments would be appreciated. You failed to mention some really important fects, like for example which version of U-Boot you are using. Me deems that it must be an old one. This commit most probably fixes your issue: commit 56fdaadc124a8ef9ec0fd8ff578233ec3b1137be Author: Weirich, Bernhard bernhard.weir...@riedel.net Date: Wed Jun 10 14:00:37 2009 +0200 ext2: fix inode size and calculations Signed-off-by: unsik Kim donar...@gmail.com Signed-off-by: Bernhard Weirich bernhard.weir...@riedel.net Signed-off-by: Wolfgang Denk w...@denx.de Tested-by: Wolfgang Denk w...@denx.de I recommend you update your code, and try again. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I'm what passes for a Unix guru in my office. This is a frightening concept. - Lee Ann Goldstein, in 3k55ba$...@butch.lmsc.lockheed.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add support for the galaxy5200 board.
Dear Eric Millbrandt, In message a88094362de0ae49a118ab9b4eb3612403f9e...@dekaexchange.deka.local you wrote: Add support for the DEKA RD galaxy5200 board. The patch is based off of the mpc5xxx branch. Please don't. Please follow the instructions and provide patches ONLY against master resp next. This e-mail and the information, including any attachments, it contains = are intended to be a confidential communication only to the person or = entity to whom it is addressed and may contain information that is = privileged. If the reader of this message is not the intended recipient, = you are hereby notified that any dissemination, distribution or copying = of this communication is strictly prohibited. If you have received this = communication in error, please immediately notify the sender and destroy = the original message. I see. Well, in this case we are unfortunately not able to even look at your patch. Content-Transfer-Encoding: base64 Content-Description: V1-Add-support-for-the-galaxy5200.patch Content-Disposition: attachment; filename=V1-Add-support-for-the-galaxy5200.patch RnJvbSA5MDYwNWZkMWM0MzEyMjAxYjMwMWY2NjAyYTVlNjk5MTA1ZmJkNDNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFcmljIE1pbGxicmFuZHQgPGVtaWxsYnJhbmR0QGRla2FyZXNl YXJjaC5jb20+CkRhdGU6IFdlZCwgMTIgQXVnIDIwMDkgMTI6NDM6NTkgLTA0MDAKU3ViamVjdDog W1BBVENIXSBBZGQgc3VwcG9ydCBmb3IgdGhlIERFS0EgUmVzZWFyY2ggYW5kIERldmVsb3BtZW50 IGdhbGF4eTUyMDAgYm9hcmQuCgpTaWduZWQtb2ZmLWJ5OiBFcmljIE1pbGxicmFuZHQgPGVtaWxs YnJhbmR0QGRla2FyZXNlYXJjaC5jb20+Ci0tLQogTUFJTlRBSU5FUlMgICAgICAgICAgICAgICAg ... And I cannot read this either. It doesn't look like plain text to me. Please make sure to follow the instructions in http://www.denx.de/wiki/U-Boot/Patches --- a/Makefile +++ b/Makefile @@ -557,6 +557,16 @@ digsy_mtc_RAMBOOT_config:unconfig } @$(MKCONFIG) -a digsy_mtc ppc mpc5xxx digsy_mtc +galaxy5200_config \ +galaxy5200_LOWBOOT_config: unconfig + @mkdir -p $(obj)include $(obj)board/galaxy5200 + @ $(obj)include/config.h + @[ -z $(findstring LOWBOOT_,$@) ] || \ + { echo TEXT_BASE = 0xFE00 $(obj)board/galaxy5200/config.tmp ; \ + echo ... with LOWBOOT configuration ; \ + } + @$(MKCONFIG) -a galaxy5200 ppc mpc5xxx galaxy5200 + Please do not add such scripting to the Makefile; do this in your board config file instead; for an example, please see http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/65499 +void init_ide_reset (void) +{ + debug (init_ide_reset\n); + + /* Configure TIMER_5 as GPIO output for ATA reset */ + volatile struct mpc5xxx_gpt *gpt = (struct mpc5xxx_gpt *)MPC5XXX_GPT; Please do not put declarations in the middle of the code, only at the start of a block. +void ide_set_reset (int idereset) +{ + debug (ide_reset(%d)\n, idereset); + + /* Configure TIMER_5 as GPIO output for ATA reset */ + volatile struct mpc5xxx_gpt *gpt = (struct mpc5xxx_gpt *)MPC5XXX_GPT; Ditto. + if (idereset) { + gpt[5].emsr = MPC5XXX_GPT_GPIO_OUT0 | MPC5XXX_GPT_TMS_GPIO; + + /* Make a delay. MPC5200 spec says 25 usec min */ + udelay(50); Why do you exceed the needed delay by a factor of 20,000 ? + } else { + gpt[5].emsr = MPC5XXX_GPT_GPIO_OUT1 | MPC5XXX_GPT_TMS_GPIO; + } Don't we need a delay here, too? +#define CONFIG_EXTRA_ENV_SETTINGS \ + filesize=0\0 \ + baudrate=115200\0 \ + stdin=serial\0\ + stdout=serial\0 \ + stderr=serial\0 \ Are you sure you need these? + ethaddr=unconfigured\0\ + hostname=unconfigured\0 \ PLease delete these. It is counterproductive to put incorrect values there. Rather leave these undefined. +#define CONFIG_BOOTCOMMAND boot What are you trying to do here? boot means: run CONFIG_BOOTCOMMAND, which then will run CONFIG_BOOTCOMMAND, which then will ... ? +#define CONFIG_SYS_FLASH_BASE0xfe00 +/* The flash size is autoconfigured, but cpu/mpc5xxx/cpu_init.c needs this + variable defined */ Incorrect multiline comment style. Please fix globally. +/*--- + Miscellaneous configurable options +---*/ +#define CONFIG_SYS_LONGHELP /* undef to save memory */ +#define CONFIG_SYS_PROMPT uboot /* Monitor Command Prompt */ + +#define CONFIG_CMDLINE_EDITING 1 /* add command line history */ + +#define CONFIG_SYS_CACHELINE_SIZE 32 /* For
Re: [U-Boot] reset environment
Dear David Collier, In message memo.20090812101725.100...@postmaster+dexdyne.com.cix.co.uk you wrote: Dear Dexdyne Postmaster, whoops - fixed that now!!! Thanks. This depends on your configuration. When using an embedded environment, this will get replaced with each install. this will get replaced with each install sorry - I don't know how you mean that will happen If you flash a new U-Boot image, this will also overwrite the embedded environment with the one built into the U-Boot image. OK - I'm working on an AVR32 - if I follow the instructions they give, it I have no idea who they are, nor what instructions they give, but if you follow their advice you should probably ask them for help, too. replaces the u-boot code, and leaves the environment sector in flash unchanged. I have added a 1-byte-write to the sector to my script to corrupt it but a command would be easier. As mentioned above, with an embedded environment this is not needed. OK again - I don't seem to have scripting enabled in my u-boot - I'd like to do that so I can use in by boot sequence. Well, then enable it. What would I put in a script to have the effect of forcing a load of the new defaults??? If there's no single command, do you mean I could make up a script full of set commands? A list of setevn commands, correct. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When the ax entered the forest, the trees said, The handle is one of us! -- Turkish proverb ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] smc91111: switch to MULTI_NET api
On 21:12 Wed 12 Aug , Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1250023747-20224-3-git-send-email-plagn...@jcrosoft.com you wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com ... #ifdef CONFIG_SMC_USE_32_BIT -#define USE_32_BIT 1 +#define is_use_32bit(x) (x-use_32bit) Does switching from a compile time check to a run time check not cause an avoidable growth of the memory footprint? How much bigger is the new code? none for the non 32 bit support it will only impact you if you do enable the 32bits support but the impact depend on the arch you use I've seen different impact on arm and sh but on the board I've test less than 300 bytes for dual support with dual support ... configured to boot from Nand Flash Configuring for nhk8815 board... textdata bss dec hex filename 1893308132 24984 222446 364ee u-boot with 32bit only ... configured to boot from Nand Flash Configuring for nhk8815 board... textdata bss dec hex filename 1890828132 24984 222198 363f6 u-boot with non 32bit ... configured to boot from Nand Flash Configuring for nhk8815 board... textdata bss dec hex filename 1890508132 24984 222166 363d6 u-boot -#undef USE_32_BIT +#define is_use_32bit(x) (0) #endif ... -static inline word SMC_inw(dword offset) +static inline word SMC_io_inw(struct smc9_device *smc, dword offset) { word v; - v = *((volatile word*)(SMC_BASE_ADDRESS+offset)); + v = *((volatile word*)(smc-regs+offset)); barrier(); *(volatile u32*)(0xc000); return v; } -static inline void SMC_outw(word value, dword offset) +static inline void SMC_io_outw(struct smc9_device *smc, word value, + dword offset) { - *((volatile word*)(SMC_BASE_ADDRESS+offset)) = value; + *((volatile word*)(smc-regs+offset)) = value; barrier(); *(volatile u32*)(0xc000); } Please use proper I/O accessor functions here. this will be for an other patch I do not want to mix Net multi api update and I/O cleanup -static int smc_close() +static void smc_halt(struct eth_device *netdev) { + struct smc9_device *smc = to_smc9(netdev); PRINTK2(%s: smc_close\n, SMC_DEV_NAME); You should also adapt the debug messages to the changed function names. +#ifdef CONFIG_SMC_USE_32_BIT +#define USE_32BIT 1 +#else +#define USE_32BIT 0 +#endif Above you get rid of the USE_32BIT stuff; here you re-introduce it. Why? yes it's different here it's to declare that you want to activate the 32bit for the default driver init include/configs/ADNPESC1.h |1 + include/configs/DK1C20.h |1 + include/configs/DK1S10.h |1 + include/configs/EP1C20.h |1 + include/configs/EP1S10.h |1 + include/configs/EP1S40.h |1 + include/configs/MigoR.h |1 + include/configs/PK1C20.h |1 + include/configs/bf533-ezkit.h|1 + include/configs/bf533-stamp.h|1 + include/configs/bf538f-ezkit.h |1 + include/configs/bf561-ezkit.h|1 + include/configs/blackstamp.h |1 + include/configs/cerf250.h|1 + include/configs/cm-bf533.h |1 + include/configs/cm-bf561.h |1 + include/configs/cradle.h |1 + include/configs/delta.h |1 + include/configs/dnp1110.h|1 + include/configs/gr_cpci_ax2000.h |1 + include/configs/gr_ep2s60.h |1 + include/configs/innokom.h|1 + include/configs/integratorcp.h |1 + include/configs/logodl.h |1 + include/configs/lpd7a400-10.h|1 + include/configs/lpd7a404-10.h|1 + include/configs/ms7722se.h |1 + include/configs/netstar.h|1 + include/configs/nhk8815.h|1 + include/configs/pxa255_idp.h |1 + include/configs/versatile.h |1 + include/configs/voiceblue.h |1 + include/configs/xaeniax.h|1 + include/configs/xm250.h |1 + include/configs/xsengine.h |1 + include/configs/zylonite.h |1 + This is a pretty long list of boards which is affected. How many of these have actuaaly been tested with this patch, and which ones, and to what extent? none will be impact as the share the same init and I've not modify any config just active the multi support and the code is tested on custom boards (4 differents) + nhk8815 and compile on arm sh Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] smc91111: switch to MULTI_NET api
On 08:54 Wed 12 Aug , Ben Warren wrote: Jean-Christophe, Jean-Christophe PLAGNIOL-VILLARD wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com I already posted a patch that does this and asked for help testing. It is available in the net/next repo. If you find it to be inadequate, please provide patches to make it work. I've also update the mac support and allow multi chip support does you pacth do the same? as I do need multi chip support and the one I send work fine Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] smc91111: switch to MULTI_NET api
Jean-Christophe PLAGNIOL-VILLARD wrote: On 08:54 Wed 12 Aug , Ben Warren wrote: Jean-Christophe, Jean-Christophe PLAGNIOL-VILLARD wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com I already posted a patch that does this and asked for help testing. It is available in the net/next repo. If you find it to be inadequate, please provide patches to make it work. I've also update the mac support and allow multi chip support does you pacth do the same? Of course it does. I don't know why you'd just ignore it and implement your own. Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Network defrag
On Wed 12 Aug 2009 16:05, Ben Warren pondered: Hi Robin, Robin Getz wrote: On Mon 10 Aug 2009 15:57, Ben Warren pondered: Robin Getz wrote: Thanks to Alessandro for putting it together. Feel free to add my Signed-off (once the docs have been updated explaining what this is all for). I'll do that. Thanks for all your help. Some info for the docs, when I was troubleshooting a Ubuntu 9.04 install. == It appears that some tftp servers (the older BSD version, Debian's tftpd) doesn't support RFC 2348 (blksize), and always use a block size of 512 :( You need to make sure that you install the the Peter Anvin version, which does support RFC 2348, and blksize up to 65,464 bytes (Debian's tftpd-hpa): http://www.kernel.org/pub/software/network/tftp/ Maybe it would make sense to have a message printed if the user specifies a higher blocksize but the TFTP server doesn't respond to the 'blksize' request. Thoughts? It doesn't happen today... We request 1468 (today), and if don't get an respose to the blksize request, it falls back to 512 (with the BSD tftpd) - no message to the user - it just takes longer, and people complain about a crappy network driver... To me - this is independent of the defragmentation patch. If we request 1468 (MTU) or 1469 (which will be fragmented) - the logic in tftp.c is the same... There is already a debug(Blocksize ack... in the code - so I'm assuming that if someone wanted to figure it out - they just need to turn on DEBUG in tftp.c - rather than printing it out all the time... -Robin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Network defrag
Robin Getz wrote: On Wed 12 Aug 2009 16:05, Ben Warren pondered: Hi Robin, Robin Getz wrote: On Mon 10 Aug 2009 15:57, Ben Warren pondered: Robin Getz wrote: Thanks to Alessandro for putting it together. Feel free to add my Signed-off (once the docs have been updated explaining what this is all for). I'll do that. Thanks for all your help. Some info for the docs, when I was troubleshooting a Ubuntu 9.04 install. == It appears that some tftp servers (the older BSD version, Debian's tftpd) doesn't support RFC 2348 (blksize), and always use a block size of 512 :( You need to make sure that you install the the Peter Anvin version, which does support RFC 2348, and blksize up to 65,464 bytes (Debian's tftpd-hpa): http://www.kernel.org/pub/software/network/tftp/ Maybe it would make sense to have a message printed if the user specifies a higher blocksize but the TFTP server doesn't respond to the 'blksize' request. Thoughts? It doesn't happen today... Obviously. I'm asking if you think it would be helpful. We request 1468 (today), and if don't get an respose to the blksize request, it falls back to 512 (with the BSD tftpd) - no message to the user - it just takes longer, and people complain about a crappy network driver... To me - this is independent of the defragmentation patch. If we request 1468 (MTU) or 1469 (which will be fragmented) - the logic in tftp.c is the same... Agreed. The code to request 'blksize' has been in place for a while, but may be more relevant now that we can have blocks MUCH bigger than the default. There is already a debug(Blocksize ack... in the code - so I'm assuming that if someone wanted to figure it out - they just need to turn on DEBUG in tftp.c - rather than printing it out all the time... Sure, if you don't mind re-compiling. I think it might be an opt-outable message via puts_quiet() -Robin regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] net: add getenv/setenv enetaddr function to use ethernet device num
On 20:58 Wed 12 Aug , Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1250023747-20224-2-git-send-email-plagn...@jcrosoft.com you wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- include/net.h |2 ++ net/eth.c | 28 +--- 2 files changed, 27 insertions(+), 3 deletions(-) NAK. First, there are formal issues: - The subject line is way too long. why it's only 67 chars - There is no commit message and no description what this patch is supposed to do or to fix. Why should we add it? just to stop to duplicate this in every driver index 2a8a12d..dc4ae41 100644 --- a/include/net.h +++ b/include/net.h @@ -124,6 +124,8 @@ extern void eth_set_enetaddr(int num, char* a); /* Set new MAC address */ extern void eth_parse_enetaddr(const char *addr, uchar *enetaddr); extern int eth_getenv_enetaddr(char *name, uchar *enetaddr); extern int eth_setenv_enetaddr(char *name, const uchar *enetaddr); +extern int eth_getenv_num_enetaddr(int num, uchar *enetaddr); +extern int eth_setenv_num_enetaddr(int num, const uchar *enetaddr); What are these functions god for? Are they by any chance duplicationg existing code, got example eth_getenv_enetaddr_by_index() ? the get yes but not there is no set Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] net/eth_device: keep index inside each device
On 20:50 Wed 12 Aug , Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1250023747-20224-1-git-send-email-plagn...@jcrosoft.com you wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- include/net.h |1 + net/eth.c | 17 + 2 files changed, 6 insertions(+), 12 deletions(-) What exactly is the problem you are addressing with this patch? Please provide a commit message that explains what is going on, and what is being changed or fixed. simple it impossible to known what will be your device index in the driver specially when you have 2 or more drivers instance once or more so you can not update the mac addres in the env if you want to do it as we do on smc9 as we can not known eth%daddr you are which allow us the avoid to read the eeprom every time we want to use the eth Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] net/eth_device: keep index inside each device
Jean-Christophe PLAGNIOL-VILLARD wrote: On 20:50 Wed 12 Aug , Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1250023747-20224-1-git-send-email-plagn...@jcrosoft.com you wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- include/net.h |1 + net/eth.c | 17 + 2 files changed, 6 insertions(+), 12 deletions(-) What exactly is the problem you are addressing with this patch? Please provide a commit message that explains what is going on, and what is being changed or fixed. simple it impossible to known what will be your device index in the driver specially when you have 2 or more drivers instance once or more so you can not update the mac addres in the env if you want to do it as we do on smc9 as we can not known eth%daddr you are which allow us the avoid to read the eeprom every time we want to use the eth While I'm not completely opposed to the idea of tracking indices, it's simply not true that you don't know the indices of the controllers on your board. They're all instantiated in board_eth_init(), so the first will be 0 and the second will be 1 etc. If you had a mix of devices and they were found by probing as in Linux, it would be different. Here in U-boot, ordering is deterministic and dictated by the developer. BTW - this is hardly the first driver that can have multiple instances. Others, such as TSEC, seem to be managing just fine. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] OMAP3 Move cache routines to cache.S
On 10:42 Wed 12 Aug , Tom Rix wrote: v7_flush_dcache_all, because it depends on omap ROM code is not generic. Rename the function to 'invalidate_dcache' and move it to the omap cpu directory. Collect the other omap cache routines l2_cache_enable and l2_cache_disable with invalide_dcache into cache.S. This means removing the old cache.c file that contained l2_cache_enable and l2_cache_disable. The conversion from cache.c to cache.S was done most through disassembling the uboot binary. The only significant change was to change the comparision for the return of get_cpu_rev from cmpr0, #0 beqearlier_than_label Which was lost information to cmpr0, #CPU_3XX_ES20 bltearlier_than_label The paths through the enable routine were verified by adding an infinite loop and seeing the hang. Then removing the infinite loop and seeing it continue. The disable routine is similar enough that it was not tested with this method. Run tested by cold booting from nand on beagle and zoom1. Compile tested on MAKEALL arm. for the l2 cache ACK for the invalidate cache NACK we do not need to call the rom code as the armv7 flush cache work fine on omap3 and duplicate armv7 code with really few code (non needed) no Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] AT91: Add support for blue_LED_* and add coloured_LED_init to at91/led.c
On 18:10 Wed 12 Aug , Albin Tonnerre wrote: Currently, at91/led.c only provides _on and _off functions for green, yellow and red LEDs. This patch provides a generic coloured_LED_init function, which is a first step towards getting rid of the board-specific (and duplicated) board/*/*/led.c files on at91 This patch alos adds similar support for blue LEDs, mostly for the sake of completeness. we do need to stop adding more and more specific led api we do need to have a common api that we can use on any arch for c asm Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] smc91111: switch to MULTI_NET api
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090812203659.gb21...@game.jcrosoft.org you wrote: +#ifdef CONFIG_SMC_USE_32_BIT +#define USE_32BIT 1 +#else +#define USE_32BIT 0 +#endif Above you get rid of the USE_32BIT stuff; here you re-introduce it. Why? yes it's different here it's to declare that you want to activate the 32bit for the default driver init Why not use the same method as above? This is a pretty long list of boards which is affected. How many of these have actuaaly been tested with this patch, and which ones, and to what extent? none will be impact as the share the same init and I've not modify any config just active the multi support Come on. You make heavy changes to the driver ans claim that none of the boards would be affected? This is... very naïve at best. and the code is tested on custom boards (4 differents) + nhk8815 I see. You should ask board maintainers for feedback, then. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Let the programmers be many and the managers few -- then all will be productive. -- Geoffrey James, The Tao of Programming ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Network defrag
Dear Ben Warren, In message 4a832bce.9060...@gmail.com you wrote: Sure, if you don't mind re-compiling. I think it might be an opt-outable message via puts_quiet() It seems we start having a mess here, with features bound to other features that have not even been agreeds about yet. I have to admit that I am no friend of this puts_quiet() thingy. How much time do we really save on a normal system? Is this worth the inconsistent behaviour and the (IMHO much uglier) code? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The face of war has never changed. Surely it is more logical to heal than to kill. -- Surak of Vulcan, The Savage Curtain, stardate 5906.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] net: add getenv/setenv enetaddr function to use ethernet device num
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090812205833.gd21...@game.jcrosoft.org you wrote: - There is no commit message and no description what this patch is supposed to do or to fix. Why should we add it? just to stop to duplicate this in every driver I would expect then that you remove such duplicated code from every driver, but I do not see any such removal? index 2a8a12d..dc4ae41 100644 --- a/include/net.h +++ b/include/net.h @@ -124,6 +124,8 @@ extern void eth_set_enetaddr(int num, char* a); /* Set new MAC address */ extern void eth_parse_enetaddr(const char *addr, uchar *enetaddr); extern int eth_getenv_enetaddr(char *name, uchar *enetaddr); extern int eth_setenv_enetaddr(char *name, const uchar *enetaddr); +extern int eth_getenv_num_enetaddr(int num, uchar *enetaddr); +extern int eth_setenv_num_enetaddr(int num, const uchar *enetaddr); What are these functions god for? Are they by any chance duplicationg existing code, got example eth_getenv_enetaddr_by_index() ? the get yes but not there is no set Makes no sense to me. Above you claim you want to avoid code duplication, and here you duplicate existing functions? Please use the existing code instead, and add only what might be missing. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de An organization dries up if you don't challenge it with growth. - Mark Shepherd, former President and CEO of Texas Instruments ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] net/eth_device: keep index inside each device
On 14:15 Wed 12 Aug , Ben Warren wrote: Jean-Christophe PLAGNIOL-VILLARD wrote: On 20:50 Wed 12 Aug , Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1250023747-20224-1-git-send-email-plagn...@jcrosoft.com you wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- include/net.h |1 + net/eth.c | 17 + 2 files changed, 6 insertions(+), 12 deletions(-) What exactly is the problem you are addressing with this patch? Please provide a commit message that explains what is going on, and what is being changed or fixed. simple it impossible to known what will be your device index in the driver specially when you have 2 or more drivers instance once or more so you can not update the mac addres in the env if you want to do it as we do on smc9 as we can not known eth%daddr you are which allow us the avoid to read the eeprom every time we want to use the eth While I'm not completely opposed to the idea of tracking indices, it's simply not true that you don't know the indices of the controllers on your board. They're all instantiated in board_eth_init(), so the first will be 0 and the second will be 1 etc. If you had a mix of devices and they were found by probing as in Linux, it would be different. Here in U-boot, ordering is deterministic and dictated by the developer. but you can not known it in the driver specially if you have multi different MAC chip 2 SMC9 + 1 SOC MAC and you will add it in the order of preferance to use for the board to let u-boot try to connect in the order of your preference as example this order SOC_M_0 SMC9111_0 SMC9111_1 so you can do this board_eth_init() { call cpu_eth_init register smc9_0 register smc9_1 } in an other board I can prefer board_eth_init() { call cpu_eth_init register smc9_0 register smc9_1 } so instead of duplicate the info and the code you just allow the driver to known is index BTW - this is hardly the first driver that can have multiple instances. Others, such as TSEC, seem to be managing just fine. each drivers do his own way this one is generic Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] net/eth_device: keep index inside each device
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090812210339.ge21...@game.jcrosoft.org you wrote: What exactly is the problem you are addressing with this patch? Please provide a commit message that explains what is going on, and what is being changed or fixed. simple it impossible to known what will be your device index in the driver specially when you have 2 or more drivers instance once or more Sorry, but we don't have driver instances in U-Boot. Even if you have several Ethernet interfaces of the same type, there will be only a single device driver instance. so you can not update the mac addres in the env if you want to do it as we do on smc9 as we can not known eth%daddr you are which allow us the avoid to read the eeprom every time we want to use the eth At any time, there is (at most) a single active interface. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Time is an illusion perpetrated by the manufacturers of space. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] AT91: Add support for blue_LED_* and add coloured_LED_init to at91/led.c
On Wed, Aug 12, 2009 at 11:15:26PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote : On 18:10 Wed 12 Aug , Albin Tonnerre wrote: Currently, at91/led.c only provides _on and _off functions for green, yellow and red LEDs. This patch provides a generic coloured_LED_init function, which is a first step towards getting rid of the board-specific (and duplicated) board/*/*/led.c files on at91 This patch alos adds similar support for blue LEDs, mostly for the sake of completeness. we do need to stop adding more and more specific led api we do need to have a common api that we can use on any arch for c asm This does not *add* specific LED API, it merely implements the existing one. There /is/ a common led API, which currently has no support for ARM, as you probably know. Does you message mean you'd accept a patch which drops the coloured-LED API (whose only user is currently ARM) and use the one described in include/status_led.h ? Regards, -- Albin Tonnerre, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot