Re: [U-Boot] RFC: U-Boot OneNAND IPL TEXT_BASE
Dne Ne 2. května 2010 05:54:41 Kyungmin Park napsal(a): > Hi, > > Which CPU do you use? In most ARM cpu, CPU load the IPL into its > internal SRAM, and runs at here. PXA270 ... the BootRAM is mapped to 0x0 and the code runs from there. > But in your case it's not. So you maybe redefine IPL address. > > Instead of modifying the config.mk, how about to define IPL_TEXT_BASE. > > e.g., > > In OneNAND IPL code, > > #ifndef BOARD_IPL_TEXT_BASE > #define ONENAND_IPL_TEXT_BASE BOARD_IPL_TEXT_BASE > #endif That won't help -- TEXT_BASE is used while compiling start.S (to setup stack under TEXT_BASE) and the config.mk prepares the gcc options for start.S (the TEXT_BASE is defined in the gcc options).So modifying config.mk is unavoidable I fear. The thing we can do is define STACK_TOP_BASE and that'd certainly do the trick! This would allow me to point stack into SRAM, while running the IPL code from BootRAM. Of course, in case STACK_TOP_BASE wasn't defined, it'd fall back to the old code in start.S. This would of course work without modifying config.mk and I start to like such a solution. Hm? > > load IPL code ONENAND_IPL_TEXT_BASE instead of current code. > > Thank you, > Kyungmin Park Thanks! > > On Sat, May 1, 2010 at 11:48 AM, Marek Vasut wrote: > > Hey, > > > > I've been tinkering with OneNAND IPL in uboot. I found out it wan't to > > load itself to the address specified in board/$(BOARDDIR)/config.mk . > > That's fine in most cases, but in my case that wasn't possible. > > > > In my case, SDRAM init didn't fit into the IPL, so I had to copy U-Boot > > into SRAM, then execute it and let it relocate itself into SDRAM. One > > more time: IPL: OneNAND->SRAM > > U-Boot: SRAM->SDRAM > > > > It all works fine, but when compiling the IPL, I had to alter TEXT_BASE > > not to point into SDRAM but SRAM too (because of stack). I introduced a > > variable called IPL which allows using config.mk from (for example) > > onenand- > > ipl/board/$(BOARDDIR)/config.mk rather than the > > board/$(BOARDDIR)/config.mk one, which is in my opinion a correct > > behaviour. > > > > Any opinions? > > > > Thanks in advance. > > > > diff --git a/config.mk b/config.mk > > index 73b5195..8639580 100644 > > --- a/config.mk > > +++ b/config.mk > > @@ -130,9 +130,13 @@ BOARDDIR = $(VENDOR)/$(BOARD) > > else > > BOARDDIR = $(BOARD) > > endif > > +ifdef IPL > > +sinclude $(TOPDIR)/$(IPL)/board/$(BOARDDIR)/config.mk # include IPL > > specific rules > > +else > > ifdef BOARD > > sinclude $(TOPDIR)/board/$(BOARDDIR)/config.mk # include board specific > > rules endif > > +endif > > > > > > # > > > > ___ > > U-Boot mailing list > > U-Boot@lists.denx.de > > http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] RFC: U-Boot OneNAND IPL TEXT_BASE
Hi, Which CPU do you use? In most ARM cpu, CPU load the IPL into its internal SRAM, and runs at here. But in your case it's not. So you maybe redefine IPL address. Instead of modifying the config.mk, how about to define IPL_TEXT_BASE. e.g., In OneNAND IPL code, #ifndef BOARD_IPL_TEXT_BASE #define ONENAND_IPL_TEXT_BASE BOARD_IPL_TEXT_BASE #endif load IPL code ONENAND_IPL_TEXT_BASE instead of current code. Thank you, Kyungmin Park On Sat, May 1, 2010 at 11:48 AM, Marek Vasut wrote: > Hey, > > I've been tinkering with OneNAND IPL in uboot. I found out it wan't to load > itself to the address specified in board/$(BOARDDIR)/config.mk . That's fine > in > most cases, but in my case that wasn't possible. > > In my case, SDRAM init didn't fit into the IPL, so I had to copy U-Boot into > SRAM, then execute it and let it relocate itself into SDRAM. One more time: > IPL: OneNAND->SRAM > U-Boot: SRAM->SDRAM > > It all works fine, but when compiling the IPL, I had to alter TEXT_BASE not to > point into SDRAM but SRAM too (because of stack). I introduced a variable > called > IPL which allows using config.mk from (for example) onenand- > ipl/board/$(BOARDDIR)/config.mk rather than the board/$(BOARDDIR)/config.mk > one, > which is in my opinion a correct behaviour. > > Any opinions? > > Thanks in advance. > > diff --git a/config.mk b/config.mk > index 73b5195..8639580 100644 > --- a/config.mk > +++ b/config.mk > @@ -130,9 +130,13 @@ BOARDDIR = $(VENDOR)/$(BOARD) > else > BOARDDIR = $(BOARD) > endif > +ifdef IPL > +sinclude $(TOPDIR)/$(IPL)/board/$(BOARDDIR)/config.mk # include IPL specific > rules > +else > ifdef BOARD > sinclude $(TOPDIR)/board/$(BOARDDIR)/config.mk # include board specific rules > endif > +endif > > # > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] ARM pull request
Wolfgang,
Please pull from arm/master.
Tom
The following changes since commit 3699c28e6d16b563629c285311a0ce62a2c4c5d0:
Wolfgang Denk (1):
Merge branch 'master' of git://git.denx.de/u-boot-video
are available in the git repository at:
git://git.denx.de/u-boot-arm master
Alexander Holler (1):
at91: add defines for RTT and GPBR
Asen Dimov (5):
pm9261 converted to at91 soc access
pm9261: remove CONFIG_CMD_AUTOSCRIPT
pm9263: remove CONFIG_CMD_AUTOSCRIPT
at91: define matrix registers bit fields
pm9263 converted to at91 soc access
Fabio Estevam (1):
MX51EVK: Remove CPLD related code
Frans Meulenbroeks (2):
configs/sheevaplug: added a few additional commands
configs/openrd_base.h: reordered macros
Heiko Schocher (2):
arm, mx27: add support for SDHC1 pin init
arm, i.mx27: add support for magnesium board from projectiondesign
John Rigby (1):
MX25 print arm clock instead of mpllclk on boot
Minkyu Kang (2):
SAMSUNG: serial: modify name from s5pc1xx to s5p
SAMSUNG: make s5p common gpio functions
Siddarth Gore (1):
Marvell GuruPlug Board Support
Stefano Babic (9):
Moved board specific values in config file
mkimage: correct spelling error in imximage
mx51evk: correct list of possible BOOT_FROM values
MX31: add accessor function to get a gpio
MX31: add pin definitions for NAND controller
MX31: Add support for NAND to QONG board
MX31: Support 128MB RAM on QONG module
MX31: Add UBI support to QONG module
MX31: Removed erroneous board name from QONG
trix (1):
ARM Update mach-types
MAINTAINERS|8 +
MAKEALL|2 +
Makefile |4 +
arch/arm/cpu/arm926ejs/mx25/generic.c |2 +-
arch/arm/cpu/arm926ejs/mx27/generic.c | 17 +
arch/arm/cpu/arm_cortexa8/mx51/lowlevel_init.S |5 +-
arch/arm/cpu/arm_cortexa8/s5pc1xx/Makefile |1 -
arch/arm/include/asm/arch-at91/at91_matrix.h | 138 +++
arch/arm/include/asm/arch-at91/at91sam9260.h |2 +
arch/arm/include/asm/arch-at91/at91sam9261.h |2 +
arch/arm/include/asm/arch-at91/at91sam9263.h |3 +
arch/arm/include/asm/arch-mx27/imx-regs.h |1 +
arch/arm/include/asm/arch-mx31/mx31-regs.h | 15 +
arch/arm/include/asm/arch-mx31/mx31.h |5 +
arch/arm/include/asm/arch-s5pc1xx/gpio.h | 192 ++--
arch/arm/include/asm/arch-s5pc1xx/uart.h |2 +-
arch/arm/include/asm/mach-types.h | 986 +++-
board/Marvell/guruplug/Makefile| 51 +
board/Marvell/guruplug/config.mk | 27 +
board/Marvell/guruplug/guruplug.c | 167
board/Marvell/guruplug/guruplug.h | 39 +
board/Marvell/guruplug/kwbimage.cfg| 162
board/davedenx/qong/lowlevel_init.S| 130 ++-
board/davedenx/qong/qong.c | 95 ++-
board/davedenx/qong/qong_fpga.h|4 +-
board/freescale/mx51evk/imximage.cfg |2 +-
board/freescale/mx51evk/mx51evk.c | 67 --
board/freescale/mx51evk/mx51evk.h |1 -
board/logicpd/imx27lite/imx27lite.c| 18 +-
board/ronetix/pm9261/led.c | 18 +-
board/ronetix/pm9261/pm9261.c | 152 ++--
board/ronetix/pm9263/led.c | 15 +-
board/ronetix/pm9263/pm9263.c | 195 ++--
common/serial.c| 16 +-
drivers/gpio/Makefile |1 +
drivers/gpio/mx31_gpio.c | 15 +
.../s5pc1xx/gpio.c => drivers/gpio/s5p_gpio.c | 16 +-
drivers/serial/Makefile|2 +-
drivers/serial/{serial_s5pc1xx.c => serial_s5p.c} | 30 +-
include/configs/guruplug.h | 198
include/configs/imx27lite-common.h | 237 +
include/configs/imx27lite.h| 200 +
include/configs/magnesium.h| 71 ++
include/configs/mx51evk.h |3 +
include/configs/openrd_base.h |4 +-
include/configs/pm9261.h | 69 +-
include/configs/pm9263.h | 88 +-
include/configs/qong.h | 40 +-
include/configs/sheevaplug.h | 27 +-
include/serial.h |8 +-
tools/imximage.c |2 +-
51 files changed, 2817 insertions(+), 738 deletions(-)
create mode 10
[U-Boot] [PATCH] video: cfb_console: add weak default video_set_lut()
Do not enforce drivers to provide empty video_set_lut()
if they do not implement indexed color (8 bpp) frame
buffer support. Add default function to the cfb_console
driver and remove empty video_set_lut() functions.
Signed-off-by: Anatolij Gustschin
---
arch/powerpc/cpu/mpc512x/diu.c| 14 --
board/freescale/mpc8610hpcd/mpc8610hpcd_diu.c |9 -
drivers/video/cfb_console.c | 12
drivers/video/sm501.c | 13 -
4 files changed, 12 insertions(+), 36 deletions(-)
diff --git a/arch/powerpc/cpu/mpc512x/diu.c b/arch/powerpc/cpu/mpc512x/diu.c
index f8d19a0..1cce6a2 100644
--- a/arch/powerpc/cpu/mpc512x/diu.c
+++ b/arch/powerpc/cpu/mpc512x/diu.c
@@ -179,18 +179,4 @@ void *video_hw_init(void)
return (void *)pGD;
}
-/**
- * Set the LUT
- *
- * @index: color number
- * @r: red
- * @b: blue
- * @g: green
- */
-void video_set_lut
- (unsigned int index, unsigned char r, unsigned char g, unsigned char b)
-{
- return;
-}
-
#endif /* defined(CONFIG_VIDEO) || defined(CONFIG_CFB_CONSOLE) */
diff --git a/board/freescale/mpc8610hpcd/mpc8610hpcd_diu.c
b/board/freescale/mpc8610hpcd/mpc8610hpcd_diu.c
index 94fb1eb..a7b7f45 100644
--- a/board/freescale/mpc8610hpcd/mpc8610hpcd_diu.c
+++ b/board/freescale/mpc8610hpcd/mpc8610hpcd_diu.c
@@ -183,15 +183,6 @@ void *video_hw_init(void)
return (void *)pGD;
}
-void video_set_lut (unsigned int index,/* color number */
- unsigned char r,/* red */
- unsigned char g,/* green */
- unsigned char b /* blue */
- )
-{
- return;
-}
-
#endif /* defined(CONFIG_VIDEO) || defined(CONFIG_CFB_CONSOLE) */
#endif /* CONFIG_FSL_DIU_FB */
diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
index dbc6d1d..e89b155 100644
--- a/drivers/video/cfb_console.c
+++ b/drivers/video/cfb_console.c
@@ -803,6 +803,18 @@ static void inline fill_555rgb_pswap(uchar *fb, int x,
#endif
/*
+ * Do not enforce drivers (or board code) to provide empty
+ * video_set_lut() if they do not support 8 bpp format.
+ * Implement weak default function instead.
+ */
+void __video_set_lut (unsigned int index, unsigned char r,
+ unsigned char g, unsigned char b)
+{
+}
+void video_set_lut (unsigned int, unsigned char, unsigned char, unsigned char)
+ __attribute__((weak, alias("__video_set_lut")));
+
+/*
* RLE8 bitmap support
*/
diff --git a/drivers/video/sm501.c b/drivers/video/sm501.c
index 283d2d9..8c96316 100644
--- a/drivers/video/sm501.c
+++ b/drivers/video/sm501.c
@@ -131,16 +131,3 @@ void *video_hw_init (void)
return (&sm501);
}
-
-/*-
- * video_set_lut --
- *-
- */
-void video_set_lut (
- unsigned int index, /* color number */
- unsigned char r, /* red */
- unsigned char g, /* green */
- unsigned char b /* blue */
- )
-{
-}
--
1.6.3.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] video: add support for display controller in MB86R0x SoCs
Dear Matthias,
On Thu, 22 Apr 2010 15:03:55 +0200
Matthias Weißer wrote:
...
> >> +/*
> >> + * Set a RGB color in the LUT
> >> + */
> >> +void video_set_lut(unsigned int index, unsigned char r,
> >> + unsigned char g, unsigned char b)
> >> +{
> >> +
> >> +}
> >
> > Code seems to be missing?
>
> The driver doesn't support palletized color format at the moment but
> removing this function leads to a linker error.
>
> Maybe we should add a config option to disable palletized color format
> or add a weak function somewhere. Maybe Anatolij can comment on this
> issue also.
I will send a patch adding weak default video_set_lut() to cfb_console
driver. You can remove empty function then.
Best regards,
Anatolij
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] video: add support for display controller in MB86R0x SoCs
Dear Matthias, On Thu, 22 Apr 2010 12:30:56 +0200 Matthias Weisser wrote: ... > diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c > index d1f47c9..4769cdb 100644 > --- a/drivers/video/cfb_console.c > +++ b/drivers/video/cfb_console.c > @@ -153,6 +153,14 @@ CONFIG_VIDEO_HW_CURSOR: - Uses the hardware cursor > capability of the > #endif > > > /*/ > +/* Defines for the MB86R0xGDC driver */ > +/*/ > +#ifdef CONFIG_VIDEO_MB86R0xGDC > + > +#define VIDEO_FB_16BPP_WORD_SWAP > +#endif Please do not add VIDEO_FB_16BPP_WORD_SWAP #define here. Add it into your include/configs/jadecpu.h file in the video related section like other boards do. Thanks! Best regards, Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] mtdparts: fix write through NULL pointer
Wolfgang Denk wrote: > I tend to prefer my version, as it seems to be more defensive, and it > also adds an assert() for the 3rd parameter. > > If you agree, I'll apply my version? Yes, of course. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Exception in U-Boot
And I thought this mailling-list was dead... :-& //Markus On 29 Apr 2010, at 16:04, Sanjay Kumar wrote: > Hi All, > We are porting U-boot. 2010.03 version for MIPS32 processor > (Au1350). Currently we are facing one problem: > > When I compile u-boot and program to NOR Flash using bdiGDB through > BDI3000 Debugger, I am observing u-boot hangs at exception i.e. at > address 0xbfc00570 after reset . > > error log is below: > > > Au1350>ti >Core number : 0 >Core state: Debug Mode >Debug entry cause : single step >Current PC: 0xbfc00400 >Current SR: 0x0044 >Current LR (r31) : 0xbfc0f6e4 >Current SP (r29) : 0x803fff00 > Au1350>go > Au1350>halt >Core number : 0 >Core state: Debug Mode >Debug entry cause : JTAG break request >Current PC: 0xbfc00570 >Current SR: 0x0042 >Current LR (r31) : 0xbfc0f6e4 >Current SP (r29) : 0x803fff00 > Au1350> > > After reset address 0xbfc00400, code executes lowlevel_init and > subsequently hangs at 0xbfc00570 (RomException). > > I'm attaching start.S and lowlevel_init.S files we are using. > > Please let me know if am doing anything wrong or missing something. > > With Thanks and Regards, > Sanjay Kumar > KPIT Cummins Infosystems Pvt Ltd > > > > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 00/17] Network support for spear platform and spear1300 support
On Fri, Apr 30, 2010 at 6:18 PM, Tom Rix wrote:
> Vipin KUMAR wrote:
>> Hello Tom/Wolfgang,
>> Didn't see any feedbacks on this patchset.
>> Please let me know if the patch is good or should I make changes and resubmit
>>
>
> Vipin,
> I will provide you with complete review of your patch set this weekend.
>
> Please use MAKEALL arm to check for regressions.
> There is a compile error for spear310 and spear320.
> Here is the spear310 error, spear320 is similar
>
> spear310.c: In function 'board_eth_init':
> spear310.c:64: warning: implicit declaration of function
> 'dw_mii_initialize'
> board/spear/spear310/libspear310.a(spear310.o): In function
> `board_eth_init':
> .../u-boot/src/u-boot-arm/board/spear/spear310/spear310.c:64: undefined
> reference to `dw_mii_initialize'
>
Yes, I noticed this problem immediately after sending the patch
Would be resolved in v3.
> This error must be resolved.
>
> FYI my email address has changed to t...@bumblecow.com.
>
Yes, I got a bounce on earlier mail-id
Thanks
Vipin
> Tom
>
>
>> Thanks in advance
>>
>> Regards
>> Vipin
>>
>> On 4/26/2010 8:26 AM, Vipin KUMAR wrote:
>>> Hi,
>>> The following subpatches incorporate review comments given on patch-set v1.
>>> Please consider it for inclusion in mainline
>>>
>>> Thanks and Regards
>>> Vipin
>>>
>>> Vipin Kumar (17):
>>> u-boot.img file not created when srctree and objtree are different
>>> change_bit routine defined
>>> SPEAr : SMI erase and write timeouts increased
>>> SPEAr : Placing ethaddr write and read within CONFIG_CMD_NET
>>> SPEAr : Reducing the max RAM size to 128MB
>>> SPEAr : Basic arch related support added for SPEAr SoCs
>>> SPEAr : Network driver support added
>>> SPEAr : Network support configured for spear SoCs
>>> SPEAr : macb driver support added for spear310 and spear320
>>> SPEAr : FSMC driver support added
>>> SPEAr : Configuring FSMC driver for NAND interface
>>> SPEAr : i2c driver moved completely into drivers/i2c
>>> SPEAr : smi driver moved completely into drivers/mtd
>>> SPEAr : USBD driver support added
>>> SPEAr : Basic spear1300 architecture support added
>>> SPEAr : spear1300 SoC support added
>>> SPEAr : Supporting various configurations for spear3xx and spear6xx
>>> boards
>>>
>>> Makefile | 24 +-
>>> arch/arm/cpu/arm926ejs/spear/Makefile | 3 +-
>>> arch/arm/cpu/arm926ejs/spear/cpu.c | 76 +++
>>> arch/arm/cpu/arm_cortexa8/spear13xx/Makefile | 52 ++
>>> arch/arm/cpu/arm_cortexa8/spear13xx/cache.S | 112
>>> arch/arm/cpu/arm_cortexa8/spear13xx/cpu.c | 99
>>> .../arm_cortexa8/spear13xx/reset.c} | 50 +--
>>> arch/arm/cpu/arm_cortexa8/spear13xx/timer.c | 136 +
>>> arch/arm/include/asm/arch-spear/clk.h | 27 +
>>> arch/arm/include/asm/arch-spear/hardware.h | 16 +-
>>> arch/arm/include/asm/arch-spear/spr_misc.h | 5 +
>>> arch/arm/include/asm/arch-spear13xx/hardware.h | 40 ++
>>> arch/arm/include/asm/arch-spear13xx/spr_gpt.h | 85 +++
>>> arch/arm/include/asm/arch-spear13xx/spr_misc.h | 317
>>> arch/arm/include/asm/arch-spear13xx/sys_proto.h | 32 ++
>>> arch/arm/include/asm/bitops.h | 11 +-
>>> board/spear/common/Makefile | 10 +-
>>> board/spear/common/spr_misc.c | 23 +-
>>> board/spear/spear1300/Makefile | 51 ++
>>> board/spear/spear1300/config.mk | 28 +
>>> board/spear/spear1300/spear1300.c | 86
>>> .../spear/spear1300/spr_lowlevel_init.S | 49 +--
>>> board/spear/spear300/config.mk | 11 -
>>> board/spear/spear300/spear300.c | 10 +-
>>> board/spear/spear310/config.mk | 11 -
>>> board/spear/spear310/spear310.c | 17 +-
>>> board/spear/spear320/config.mk | 11 -
>>> board/spear/spear320/spear320.c | 14 +-
>>> board/spear/spear600/config.mk | 11 -
>>> board/spear/spear600/spear600.c | 10 +-
>>> drivers/i2c/Makefile | 2 +-
>>> drivers/i2c/{spr_i2c.c => designware_i2c.c} | 4 +-
>>> .../spr_i2c.h => drivers/i2c/designware_i2c.h | 6 +-
>>> drivers/mtd/Makefile | 2 +-
>>> drivers/mtd/nand/Makefile | 2 +-
>>> drivers/mtd/nand/fsmc_nand.c | 365 +
>>> drivers/mtd/nand/spr_nand.c | 124 -
>>> drivers/mtd/{spr_smi.c => st_smi.c} | 10 +-
>>> .../arch-spear/spr_smi.h => drivers/mtd/st_smi.h | 10 +-
>>> drivers/net/Makefile | 1 +
>>> drivers/net/designware.c
