Re: [U-Boot] Fw:How can I use yaffs2 in uboot
Dear jackfriend, In message 39c3dad3.3bd4.12910469457.coremail.jackfri...@163.com you wrote: How can I use yaffs2 in uboot ... my2440 # ymount /flash yaffs: Mounting /flash Looks good? my2440 # ywrm a 0x30008000 4 Error opening file: -1 Maybe you try a yls first to check which files are present in your file system. Then test if read accesses are working. I'm not sure if write mode has been tested (or even implemented). Also, it might make sense to enable YAFFS2_DEBUG while testing. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It is better to have tried and failed than to have failed to try, but the result's the same. - Mike Dennison ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Fw:How can I use yaffs2 in uboot
On Mon, Jun 7, 2010 at 08:44, Wolfgang Denk w...@denx.de wrote: Dear jackfriend, In message 39c3dad3.3bd4.12910469457.coremail.jackfri...@163.com you wrote: How can I use yaffs2 in uboot You have to use absolute path with all commands. eg yls /flash/ This path must match your mount points as configured in fs/yaffs/yaffscfg.c my2440 # ywrm a 0x30008000 4 Error opening file: -1 Maybe you try a yls first to check which files are present in your file system. Then test if read accesses are working. I'm not sure if write mode has been tested (or even implemented). Write mode is in use and working. Best regards William Juul Also, it might make sense to enable YAFFS2_DEBUG while testing. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It is better to have tried and failed than to have failed to try, but the result's the same. - Mike Dennison ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] da830: Move common code out of da830evm.c file
Hi,
On Fri, Jun 04, 2010 at 21:02:31, Nick Thompson wrote:
On 04/06/10 15:26, Ben Gardiner wrote:
On Thu, Jun 3, 2010 at 8:58 AM, Sudhakar Rajashekhara
sudhakar@ti.com wrote:
On Thu, Jun 03, 2010 at 16:23:36, Nick Thompson wrote:
On 03/06/10 05:25, Sudhakar Rajashekhara wrote:
TI's DA850/OMAP-L138 platform is similar to DA830/OMAP-L137
in many aspects. So instead of repeating the same code in
multiple files, move the common code to a different file
and call those functions from the respective da830/da850
files.
Signed-off-by: Sudhakar Rajashekhara sudhakar@ti.com
Acked-by: Nick Thompson nick.thomp...@ge.com
Acked-by: Ben Gardiner bengardi...@nanometrics.ca
---
Since v3:
Fixes the following compiler error for other davinci targets:
misc.c: In function 'irq_init':
misc.c:51: error: 'davinci_aintc_regs' undeclared (first use in this
function)
misc.c:51: error: (Each undeclared identifier is reported only once
misc.c:51: error: for each function it appears in.)
make[1]: *** [.../build/board/davinci/common/misc.o] Error 1
make: *** [.../build/board/davinci/common/libdavinci.a] Error 2
make: *** Waiting for unfinished jobs
board/davinci/common/misc.c | 32
board/davinci/common/misc.h |7 +++
board/davinci/da830evm/da830evm.c | 28 +++-
3 files changed, 50 insertions(+), 17 deletions(-)
diff --git a/board/davinci/common/misc.c b/board/davinci/common/misc.c
index 25ca326..dcf3cf2 100644
--- a/board/davinci/common/misc.c
+++ b/board/davinci/common/misc.c
@@ -41,6 +41,24 @@ int dram_init(void)
return(0);
}
+#ifdef CONFIG_SOC_DA8XX
+void irq_init(void)
+{
+ /*
+* Mask all IRQs by clearing the global enable and setting
+* the enable clear for all the 90 interrupts.
+*/
+
+ writel(0, davinci_aintc_regs-ger);
+
+ writel(0, davinci_aintc_regs-hier);
+
+ writel(0x, davinci_aintc_regs-ecr1);
+ writel(0x, davinci_aintc_regs-ecr2);
+ writel(0x, davinci_aintc_regs-ecr3);
+}
+#endif
In the current code base, this code is not included in the da830
compilation
if IRQs are not used. With this patch the code is included, but not called
if IRQs are not used. IRQs are often not used, so this change causes
bloat.
Could you please make this conditional on IRQs?
I added the code between CONFIG_SOC_DA8XX macro because davinci_aintc_regs
declaration is in between this macro in hardware.h file. So they'll not be
available for targets other than DA830 and DA850. Also, AINTC register
mapping is different on DM644x, DM646x, DM355 and DM365. Shall I consider
moving the irq_init function out of misc.c?
Just to be clear on my part: I meant that it should be conditional on both
DA8XX *and* IRQs.
Since it is da8XX specific, irq_init might be best placed somewhere in
the board/davinci/da8xxevm directory that is being introduced in the
da850 support series? Perhaps for this patch it could be extracted to
board/davinci/da830evm/common.c ?
Agreed.
I'll be moving the irq_init and davinci_configure_lpsc_items functions to
common.c under board/davinci/da830.
Also if the register mappings are different across all platforms, maybe
davinci_aintc_regs should be renamed as da8xx_aintc_regs (and the struct
definition name changed as well)?
Yes, AINTC is specific to da8xx platforms, but in future there may be some
davinci platforms which may have this AINTC module. Also, in hardrware.h
the DA8XX specific register definitions have DAVINCI string in them. As of
now I'll retain the name davinci_aintc_regs as it will not cause any harm.
Regards,
Sudhakar
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v5] da830: Move common code out of da830evm.c file
TI's DA850/OMAP-L138 platform is similar to DA830/OMAP-L137
in many aspects. So instead of repeating the same code in
multiple files, move the common code to a different file
and call those functions from the respective da830/da850
files.
Signed-off-by: Sudhakar Rajashekhara sudhakar@ti.com
Acked-by: Nick Thompson nick.thomp...@ge.com
Acked-by: Ben Gardiner bengardi...@nanometrics.ca
---
Since v4:
a. Moved the irq_init() and davinci_configure_lpsc_items() functions
to board/davinci/da830evm/common.c file.
b. Renamed davinci_configure_lpsc_items to da8xx_configure_lpsc_items.
c. Created board/davinci/da830evm/common.h file.
board/davinci/da830evm/Makefile |2 +-
board/davinci/da830evm/common.c | 55 +
board/davinci/da830evm/common.h | 30
board/davinci/da830evm/da830evm.c | 29 ---
4 files changed, 98 insertions(+), 18 deletions(-)
create mode 100644 board/davinci/da830evm/common.c
create mode 100644 board/davinci/da830evm/common.h
diff --git a/board/davinci/da830evm/Makefile b/board/davinci/da830evm/Makefile
index 02636fa..ee00057 100644
--- a/board/davinci/da830evm/Makefile
+++ b/board/davinci/da830evm/Makefile
@@ -27,7 +27,7 @@ include $(TOPDIR)/config.mk
LIB= $(obj)lib$(BOARD).a
-COBJS := da830evm.o
+COBJS := da830evm.o common.o
SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(COBJS))
diff --git a/board/davinci/da830evm/common.c b/board/davinci/da830evm/common.c
new file mode 100644
index 000..9cd5204
--- /dev/null
+++ b/board/davinci/da830evm/common.c
@@ -0,0 +1,55 @@
+/*
+ * Miscellaneous DA8XX functions.
+ *
+ * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#include asm/io.h
+#include asm/arch/hardware.h
+#include common.h
+
+#ifndef CONFIG_USE_IRQ
+void irq_init(void)
+{
+ /*
+* Mask all IRQs by clearing the global enable and setting
+* the enable clear for all the 90 interrupts.
+*/
+
+ writel(0, davinci_aintc_regs-ger);
+
+ writel(0, davinci_aintc_regs-hier);
+
+ writel(0x, davinci_aintc_regs-ecr1);
+ writel(0x, davinci_aintc_regs-ecr2);
+ writel(0x, davinci_aintc_regs-ecr3);
+}
+#endif
+
+/*
+ * Enable PSC for various peripherals.
+ */
+int da8xx_configure_lpsc_items(const struct lpsc_resource *item,
+ const int n_items)
+{
+ int i;
+
+ for (i = 0; i n_items; i++)
+ lpsc_on(item[i].lpsc_no);
+
+ return 0;
+}
diff --git a/board/davinci/da830evm/common.h b/board/davinci/da830evm/common.h
new file mode 100644
index 000..7ae63a6
--- /dev/null
+++ b/board/davinci/da830evm/common.h
@@ -0,0 +1,30 @@
+/*
+ * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#ifndef __COMMON_H
+#define __COMMON_H
+
+struct lpsc_resource {
+ const int lpsc_no;
+};
+
+void irq_init(void);
+int da8xx_configure_lpsc_items(const struct lpsc_resource *item,
+ int n_items);
+
+#endif /* __COMMON_H */
diff --git a/board/davinci/da830evm/da830evm.c
b/board/davinci/da830evm/da830evm.c
index 6385443..57506d6 100644
--- a/board/davinci/da830evm/da830evm.c
+++ b/board/davinci/da830evm/da830evm.c
@@ -41,6 +41,7 @@
#include asm/arch/emac_defs.h
#include asm/io.h
#include ../common/misc.h
+#include common.h
DECLARE_GLOBAL_DATA_PTR;
@@ -120,21 +121,18 @@ static const struct pinmux_resource pinmuxes[] = {
#endif
};
+static
Re: [U-Boot] [PATCH-V3 1/2] AM35x: Add support for AM3517EVM
-Original Message-
From: Hiremath, Vaibhav
Sent: Thursday, June 03, 2010 10:57 PM
To: 'Wolfgang Denk'
Cc: u-boot@lists.denx.de; t...@bumblecow.com; Paulraj, Sandeep; Premi,
Sanjeev
Subject: RE: [PATCH-V3 1/2] AM35x: Add support for AM3517EVM
[Hiremath, Vaibhav] Denk,
Can you please reply to below queries of mine, so that I can incorporate the
changes and submit it again?
Thanks,
Vaibhav
-Original Message-
From: Wolfgang Denk [mailto:w...@denx.de]
Sent: Monday, May 31, 2010 3:11 PM
To: Hiremath, Vaibhav
Cc: u-boot@lists.denx.de; t...@bumblecow.com; Paulraj, Sandeep; Premi,
Sanjeev
Subject: Re: [PATCH-V3 1/2] AM35x: Add support for AM3517EVM
Dear hvaib...@ti.com,
In message 1273166585-26101-1-git-send-email-hvaib...@ti.com you wrote:
From: Vaibhav Hiremath hvaib...@ti.com
This patch adds basic support for the AM3517EVM.
It includes:
- Board int file (.c and .h)
- Default configuration file
- Updates for Makefile
Changes from V2:
- Removed trailing spaces
- Updated MAINTAINERS MAKEALL for am3517_evm
Such comments do not belong into the commit message. Please place thes
ebelow the --- line:
[Hiremath, Vaibhav] Ok will incorporate in next post.
Signed-off-by: Vaibhav Hiremath hvaib...@ti.com
Signed-off-by: Sanjeev Premi pr...@ti.com
---
== Comments should go here.
diff --git a/MAINTAINERS b/MAINTAINERS
index 5cbc845..0bc65e1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -798,6 +798,10 @@ Alex Z
lartSA1100
dnp1110 SA1110
+Vaibhav Hiremath hvaib...@ti.com
+
+ am3517_evm ARM CORTEX-A8 (AM35x SoC)
+
Please keep list sorted.
[Hiremath, Vaibhav] How does this sorted, I could not see any relation
between the entries there.
[Hiremath, Vaibhav] Denk,
...
diff --git a/arch/arm/include/asm/arch-omap3/mux.h
b/arch/arm/include/asm/arch-omap3/mux.h
index 0c01c73..ffeb982 100644
--- a/arch/arm/include/asm/arch-omap3/mux.h
+++ b/arch/arm/include/asm/arch-omap3/mux.h
...
+/* AM3517 specific */
+#define CONTROL_PADCONF_CCDC_PCLK0x01E4
+#define CONTROL_PADCONF_CCDC_FIELD 0x01E6
Board specific defoinitions should not be added to global header
files. Please use a board specific header instead.
[Hiremath, Vaibhav] I think this has been placed at the right place. This is
mux definition and got added to mux.h file. You could see all mux definition
are present in this file.
Do you see any issues with this?
--- /dev/null
+++ b/board/logicpd/am3517evm/am3517evm.c
@@ -0,0 +1,76 @@
...
+int board_init(void)
+{
+ DECLARE_GLOBAL_DATA_PTR;
This is bound to break. DECLARE_GLOBAL_DATA_PTR must always be used on
file scope only; never use this on function scope.
[Hiremath, Vaibhav] Agreed. Actually this code is derived form
board/ti/evm/, so followed the same here.
I will change it in next post.
Please check all
your code.
[Hiremath, Vaibhav] Do you see any other issues? I don't get this statement.
Thanks,
Vaibhav
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Genius doesn't work on an assembly line basis. You can't simply say,
Today I will be brilliant.
-- Kirk, The Ultimate Computer, stardate 4731.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH-V3 1/2] AM35x: Add support for AM3517EVM
Dear Hiremath, Vaibhav, In message 19f8576c6e063c45be387c64729e7394044e7a1...@dbde02.ent.ti.com you wrote: ... diff --git a/MAINTAINERS b/MAINTAINERS index 5cbc845..0bc65e1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -798,6 +798,10 @@ Alex Z lartSA1100 dnp1110 SA1110 +Vaibhav Hiremath hvaib...@ti.com + + am3517_evm ARM CORTEX-A8 (AM35x SoC) + Please keep list sorted. [Hiremath, Vaibhav] How does this sorted, I could not see any relation between the entries there. The list is sorted alphabetically by maintainer' last names, and then by CPU / board names. diff --git a/arch/arm/include/asm/arch-omap3/mux.h b/arch/arm/include/asm/arch-omap3/mux.h index 0c01c73..ffeb982 100644 --- a/arch/arm/include/asm/arch-omap3/mux.h +++ b/arch/arm/include/asm/arch-omap3/mux.h ... +/* AM3517 specific */ +#define CONTROL_PADCONF_CCDC_PCLK 0x01E4 +#define CONTROL_PADCONF_CCDC_FIELD 0x01E6 Board specific defoinitions should not be added to global header files. Please use a board specific header instead. [Hiremath, Vaibhav] I think this has been placed at the right place. This is mux definition and got added to mux.h file. You could see all mux definition are present in this file. Do you see any issues with this? Yes, as I wrote: board specific definitions should not be added to global header files. They should be added to board specific files only, avoiding the need for tons of #ifdef's in global files. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When you die, the first thing you lose is your life. The next thing is the illusions. - Terry Pratchett, _Pyramids_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH][mpc83xx] Update SICRL_USBDR to reflect 4 different settings
On Tue, 1 Jun 2010 17:00:49 -0700 Ron Madrid ron_mad...@sbcglobal.net wrote: This patch changed the SICRL_USBDR define to reflect the 4 different bit settings for this two-bit field. The four different options are '00', '01', '10', and '11'. This patch also corrects the config file for SIMPC8313 and MPC8313ERDB for the appropriate fields. This change only affects the MPC8313 cpu. Signed-off-by: Ron Madrid ron_mad...@sbcglobal.net --- applied. Thanks, Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [GIT PULL] u-boot-mpc83xx fix
Wolfgang Denk, Please pull a fix for the mpc8313 usb setting: The following changes since commit 9bb3b3d4406c1e388a99f6fb189147d6a06cc2cf: Merge branch 'master' of git://git.denx.de/u-boot-mpc85xx (2010-05-30 21:44:07 +0200) are available in the git repository at: git://git.denx.de/u-boot-mpc83xx.git master Ron Madrid (1): Update SICRL_USBDR to reflect 4 different settings include/configs/MPC8313ERDB.h |2 +- include/configs/SIMPC8313.h |2 +- include/mpc83xx.h |5 - 3 files changed, 6 insertions(+), 3 deletions(-) Also, I've noticed main CHANGELOG updates are still being performed: commit c4976807cbbabd281f45466ac5e47e5639bcc9cb Author: Wolfgang Denk w...@denx.de Date: Wed May 26 23:51:22 2010 +0200 Coding style cleanup, update CHANGELOG. Signed-off-by: Wolfgang Denk w...@denx.de Any news wrt implementing a gitattributes based solution instead?: http://lists.denx.de/pipermail/u-boot/2010-May/071118.html Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ARM pull request.
Marek Vasut wrote: Dne Ne 30. května 2010 15:52:04 Tom Rix napsal(a): This is to catch master up to ARM mach-types Is the PXA tree -next and -fix still planned to be pulled guys? Tom, Wolfgang ... hm? Sorry I have been out for a while. Please verify that PXA branch you wish me to pull from is up to date. That the patches are in order and resubmit a pull request. Tom Cheers Tom The following changes since commit 01f03bda5b22e5aeae5f02fd537da97a41485c73: Wolfgang Denk (1): Prepare v2010.06-rc1 are available in the git repository at: git://git.denx.de/u-boot-arm master Tom (2): ARM Update mach-types ARM Update mach-types arch/arm/include/asm/mach-types.h | 1173 - 1 files changed, 1165 insertions(+), 8 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] da830: Move common code out of da830evm.c file
On Mon, Jun 7, 2010 at 4:29 AM, Sudhakar Rajashekhara sudhakar@ti.com wrote: TI's DA850/OMAP-L138 platform is similar to DA830/OMAP-L137 in many aspects. So instead of repeating the same code in multiple files, move the common code to a different file and call those functions from the respective da830/da850 files. Very nice. Thank you, Sudhakar. Acked-by: Ben Gardiner bengardi...@nanometrics.ca It applies cleanly to master (9bb3b3d) of git://git.denx.de/u-boot.git and only the da830evm binary has increased in size by the application of this patch: --- ../davinci-before.out 2010-06-04 09:18:44.130839762 -0400 +++ ../davinci-after.out2010-06-07 10:09:25.300590587 -0400 @@ -24,8 +24,9 @@ Configuring for davinci_dm6467evm board. 91776 4776 26100 122652 1df1c ./u-boot Configuring for da830evm board... text data bss dec hex filename - 147475 4888 295320 447683 6d4c3 ./u-boot + 1475434888 295320 447751 6d507 ./u-boot -- Ben Gardiner Nanometrics Inc. +1 (613) 592-6776 x239 http://www.nanometrics.ca ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH-V3 1/2] AM35x: Add support for AM3517EVM
-Original Message- From: Wolfgang Denk [mailto:w...@denx.de] Sent: Monday, June 07, 2010 5:55 PM To: Hiremath, Vaibhav Cc: u-boot@lists.denx.de; t...@bumblecow.com; Paulraj, Sandeep; Premi, Sanjeev Subject: Re: [PATCH-V3 1/2] AM35x: Add support for AM3517EVM Dear Hiremath, Vaibhav, In message 19f8576c6e063c45be387c64729e7394044e7a1...@dbde02.ent.ti.com you wrote: ... diff --git a/MAINTAINERS b/MAINTAINERS index 5cbc845..0bc65e1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -798,6 +798,10 @@ Alex Z lartSA1100 dnp1110 SA1110 +Vaibhav Hiremath hvaib...@ti.com + + am3517_evm ARM CORTEX-A8 (AM35x SoC) + Please keep list sorted. [Hiremath, Vaibhav] How does this sorted, I could not see any relation between the entries there. The list is sorted alphabetically by maintainer' last names, and then by CPU / board names. [Hiremath, Vaibhav] Thanks, I will update the patch and submit is shortly. diff --git a/arch/arm/include/asm/arch-omap3/mux.h b/arch/arm/include/asm/arch-omap3/mux.h index 0c01c73..ffeb982 100644 --- a/arch/arm/include/asm/arch-omap3/mux.h +++ b/arch/arm/include/asm/arch-omap3/mux.h ... +/* AM3517 specific */ +#define CONTROL_PADCONF_CCDC_PCLK0x01E4 +#define CONTROL_PADCONF_CCDC_FIELD 0x01E6 Board specific defoinitions should not be added to global header files. Please use a board specific header instead. [Hiremath, Vaibhav] I think this has been placed at the right place. This is mux definition and got added to mux.h file. You could see all mux definition are present in this file. Do you see any issues with this? Yes, as I wrote: board specific definitions should not be added to global header files. They should be added to board specific files only, avoiding the need for tons of #ifdef's in global files. [Hiremath, Vaibhav] Yes I agree this has to be there in board header file, but I don't think we are using #ifdefs anywhere for this, since the usage of this is happening through board header file. I am moving these definitions to board/logicpd/am3517evm/am3517evm.h file. Thanks, Vaibhav Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When you die, the first thing you lose is your life. The next thing is the illusions. - Terry Pratchett, _Pyramids_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] arm: cortexa9: adding support for TI OMAP4430 SDP
Hello Wolfgang,
Thanks for your comments. We will fix the issues you have pointed out.
+#endif /* CONFIG_DISPLAY_BOARDINFO */
...
+#ifdef CONFIG_DISPLAY_CPUINFO
These #defines have never been documented. It seems they are being
copied around a lot, but I'm not sure if anybody ever does NOT set
these.
I think we should at least document these - or rather drop them
everywhere. What do you think?
I'm ok with dropping it everywhere.
+{
+
+ printf (CPU : OMAP4430 ES1.0 \n);
puts()?
And: no spaces after function names please (fix globally!).
But how about this rule mentioned in your wiki:
All contributions to U-Boot should conform to the Linux kernel coding style;
see the file Documentation/CodingStyle and the script scripts/Lindent in
your Linux kernel source directory. In sources originating from U-Boot a style
corresponding to Lindent -pcs (adding spaces before parameters to function
calls) is actually used.
http://www.denx.de/wiki/U-Boot/CodingStyle
In fact, I didn't add spaces initially. They got added when I ran Lindent
-pcs. Is this rule not applicable anymore? Or am I missing something?
Best regards,
Aneesh
-Original Message-
From: Wolfgang Denk [mailto:w...@denx.de]
Sent: Sunday, June 06, 2010 1:25 AM
To: V, Aneesh
Cc: u-boot@lists.denx.de; olbp...@list.ti.com - OMAP Linux Baseport
Development Team (May contain non-TIers)
Subject: Re: [U-Boot] [PATCH 2/2] arm: cortexa9: adding support for TI
OMAP4430 SDP
Dear Aneesh V,
In message 1274769577-29021-3-git-send-email-ane...@ti.com you wrote:
Adding support for OMAP4430 SDP board based on the TI OMAP4430 SOC.
TI OMAP4430 is an SOC based on ARM Cortex-A9 cpu.
OMAP4430 SDP is a reference board based on OMAP4430.
This patch adds minimum support for booting the board.
OMAP4430 SDP does not support XIP. U-boot is loaded to SDRAM with the
help of
another small bootloader running from SRAM. U-boot currently relies on
this
bootloader for clock, mux, and SDRAM initialization.
This will change when OMAP4430 Configuration Header(CH) is attached
to u-boot. CH is a feature by which ROM code can be made to intialize
the
clocks and SDRAM and to copy u-boot directly into SDRAM from a non-XIP
device.
More support such as MMC, ethernet etc will be added in subsequent
patches.
Signed-off-by: Aneesh V ane...@ti.com
In addition to John's comments:
Makefile|8 +-
arch/arm/cpu/armv7/omap4/Makefile | 50 +
arch/arm/cpu/armv7/omap4/cache.S| 128
arch/arm/cpu/armv7/omap4/lowlevel_init.S| 49 +
arch/arm/cpu/armv7/omap4/omap4.c| 97 +
arch/arm/cpu/armv7/omap4/reset.S| 36
arch/arm/cpu/armv7/omap4/sys_info.c | 58 ++
arch/arm/cpu/armv7/omap4/timer.c| 140 +
arch/arm/include/asm/arch-omap4/cpu.h | 89 +
arch/arm/include/asm/arch-omap4/omap4.h | 142 ++
arch/arm/include/asm/arch-omap4/sys_proto.h | 36
board/ti/sdp4430/Makefile | 49 +
board/ti/sdp4430/config.mk | 32 +++
board/ti/sdp4430/sdp.c | 56 ++
include/configs/omap4_sdp4430.h | 280
+++
15 files changed, 1249 insertions(+), 1 deletions(-)
create mode 100644 arch/arm/cpu/armv7/omap4/Makefile
create mode 100644 arch/arm/cpu/armv7/omap4/cache.S
create mode 100644 arch/arm/cpu/armv7/omap4/lowlevel_init.S
create mode 100644 arch/arm/cpu/armv7/omap4/omap4.c
create mode 100644 arch/arm/cpu/armv7/omap4/reset.S
create mode 100644 arch/arm/cpu/armv7/omap4/sys_info.c
create mode 100644 arch/arm/cpu/armv7/omap4/timer.c
create mode 100644 arch/arm/include/asm/arch-omap4/cpu.h
create mode 100644 arch/arm/include/asm/arch-omap4/omap4.h
create mode 100644 arch/arm/include/asm/arch-omap4/sys_proto.h
create mode 100644 board/ti/sdp4430/Makefile
create mode 100644 board/ti/sdp4430/config.mk
create mode 100644 board/ti/sdp4430/sdp.c
create mode 100644 include/configs/omap4_sdp4430.h
Entries to MAKEALL and MAINTAINERS files missing.
+int checkboard (void)
+{
+ printf (%s\n, sysinfo.board_string);
+ return 0;
+}
Consider using puts() when you don't need any output formatting.
+#endif /* CONFIG_DISPLAY_BOARDINFO */
...
+#ifdef CONFIG_DISPLAY_CPUINFO
These #defines have never been documented. It seems they are being
copied around a lot, but I'm not sure if anybody ever does NOT set
these.
I think we should at least document these - or rather drop them
everywhere. What do you think?
+{
+
+ printf (CPU : OMAP4430 ES1.0 \n);
puts()?
And: no spaces after function names please (fix globally!).
...
+/*
+ * High Level Configuration Options
+ */
+#define CONFIG_ARMCORTEXA9 1 /* This
[U-Boot] [PATCH-V4 2/2] AM35x: Add support for EMIF4
From: Vaibhav Hiremath hvaib...@ti.com
This patch adds support for the EMIF4 interface
available in the AM35x processors.
Signed-off-by: Vaibhav Hiremath hvaib...@ti.com
Signed-off-by: Sanjeev Premi pr...@ti.com
---
Changes from V2:
- Removed all instances of #ifdef CONFIG_EMIF4
Changes from V3:
- Corrected Makfile entry to keep list sorted
- Unnecessary comments moved here
arch/arm/cpu/arm_cortexa8/omap3/Makefile|1 +
arch/arm/cpu/arm_cortexa8/omap3/emif4.c | 168 +++
arch/arm/include/asm/arch-omap3/cpu.h | 24
arch/arm/include/asm/arch-omap3/emif4.h | 79 +
arch/arm/include/asm/arch-omap3/sys_proto.h |1 +
include/configs/am3517_evm.h|2 +-
6 files changed, 274 insertions(+), 1 deletions(-)
create mode 100644 arch/arm/cpu/arm_cortexa8/omap3/emif4.c
create mode 100644 arch/arm/include/asm/arch-omap3/emif4.h
diff --git a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
index 1e80eb3..7d63c6b 100644
--- a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
+++ b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
@@ -37,6 +37,7 @@ COBJS += syslib.o
COBJS += sys_info.o
COBJS += timer.o
+COBJS-$(CONFIG_EMIF4) += emif4.o
COBJS-$(CONFIG_SDRC) += sdrc.o
SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/arch/arm/cpu/arm_cortexa8/omap3/emif4.c
b/arch/arm/cpu/arm_cortexa8/omap3/emif4.c
new file mode 100644
index 000..fae5b11
--- /dev/null
+++ b/arch/arm/cpu/arm_cortexa8/omap3/emif4.c
@@ -0,0 +1,168 @@
+/*
+ * Author :
+ * Vaibhav Hiremath hvaib...@ti.com
+ *
+ * Based on mem.c and sdrc.c
+ *
+ * Copyright (C) 2010
+ * Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include common.h
+#include asm/io.h
+#include asm/arch/mem.h
+#include asm/arch/sys_proto.h
+#include asm/arch/emif4.h
+
+extern omap3_sysinfo sysinfo;
+
+static emif4_t *emif4_base = (emif4_t *)OMAP34XX_SDRC_BASE;
+
+/*
+ * is_mem_sdr -
+ * - Return 1 if mem type in use is SDR
+ */
+u32 is_mem_sdr(void)
+{
+ return 0;
+}
+
+/*
+ * get_sdr_cs_size -
+ * - Get size of chip select 0/1
+ */
+u32 get_sdr_cs_size(u32 cs)
+{
+ u32 size;
+
+ /* TODO: Calculate the size based on EMIF4 configuration */
+ size = CONFIG_SYS_CS0_SIZE;
+
+ return size;
+}
+
+/*
+ * get_sdr_cs_offset -
+ * - Get offset of cs from cs0 start
+ */
+u32 get_sdr_cs_offset(u32 cs)
+{
+ u32 offset = 0;
+
+ return offset;
+}
+
+/*
+ * do_emif4_init -
+ * - Init the emif4 module for DDR access
+ * - Early init routines, called from flash or SRAM.
+ */
+void do_emif4_init(void)
+{
+ unsigned int regval;
+ /* Set the DDR PHY parameters in PHY ctrl registers */
+ regval = (EMIF4_DDR1_READ_LAT | EMIF4_DDR1_PWRDN_DIS |
+ EMIF4_DDR1_EXT_STRB_DIS);
+ writel(regval, emif4_base-ddr_phyctrl1);
+ writel(regval, emif4_base-ddr_phyctrl1_shdw);
+ writel(0, emif4_base-ddr_phyctrl2);
+
+ /* Reset the DDR PHY and wait till completed */
+ regval = readl(emif4_base-sdram_iodft_tlgc);
+ regval |= (110);
+ writel(regval, emif4_base-sdram_iodft_tlgc);
+ /*Wait till that bit clears*/
+ while ((readl(emif4_base-sdram_iodft_tlgc) (110)) == 0x1);
+ /*Re-verify the DDR PHY status*/
+ while ((readl(emif4_base-sdram_sts) (12)) == 0x0);
+
+ regval |= (10);
+ writel(regval, emif4_base-sdram_iodft_tlgc);
+ /* Set SDR timing registers */
+ regval = (EMIF4_TIM1_T_WTR | EMIF4_TIM1_T_RRD |
+ EMIF4_TIM1_T_RC | EMIF4_TIM1_T_RAS |
+ EMIF4_TIM1_T_WR | EMIF4_TIM1_T_RCD |
+ EMIF4_TIM1_T_RP);
+ writel(regval, emif4_base-sdram_time1);
+ writel(regval, emif4_base-sdram_time1_shdw);
+
+ regval = (EMIF4_TIM2_T_CKE | EMIF4_TIM2_T_RTP |
+ EMIF4_TIM2_T_XSRD | EMIF4_TIM2_T_XSNR |
+ EMIF4_TIM2_T_ODT | EMIF4_TIM2_T_XP);
+ writel(regval, emif4_base-sdram_time2);
+ writel(regval, emif4_base-sdram_time2_shdw);
+
+ regval = (EMIF4_TIM3_T_RAS_MAX | EMIF4_TIM3_T_RFC);
+ writel(regval, emif4_base-sdram_time3);
+ writel(regval, emif4_base-sdram_time3_shdw);
+
+ /* Set the
[U-Boot] [PATCH-V4 1/2] AM35x: Add support for AM3517EVM
From: Vaibhav Hiremath hvaib...@ti.com This patch adds basic support for the AM3517EVM. It includes: - Board files (.c and .h) - Default configuration file - Updates for Makefile Signed-off-by: Vaibhav Hiremath hvaib...@ti.com Signed-off-by: Sanjeev Premi pr...@ti.com --- Changes from V2: - Removed trailing spaces - Updated MAINTAINERS MAKEALL for am3517_evm Changes from V3: - Corrected Maintainer entry to keep list sorted - Moved AM3537 macros to board header file MAINTAINERS |4 + MAKEALL |1 + Makefile|3 + board/logicpd/am3517evm/Makefile| 46 board/logicpd/am3517evm/am3517evm.c | 76 ++ board/logicpd/am3517evm/am3517evm.h | 445 +++ board/logicpd/am3517evm/config.mk | 30 +++ include/configs/am3517_evm.h| 296 +++ 8 files changed, 901 insertions(+), 0 deletions(-) create mode 100644 board/logicpd/am3517evm/Makefile create mode 100644 board/logicpd/am3517evm/am3517evm.c create mode 100644 board/logicpd/am3517evm/am3517evm.h create mode 100644 board/logicpd/am3517evm/config.mk create mode 100644 include/configs/am3517_evm.h diff --git a/MAINTAINERS b/MAINTAINERS index 7a13d28..3f9df78 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -600,6 +600,10 @@ Kshitij Gupta kshi...@ti.com omap1510inn ARM925T omap1610inn ARM926EJS +Vaibhav Hiremath hvaib...@ti.com + + am3517_evm ARM CORTEX-A8 (AM35x SoC) + Grazvydas Ignotas nota...@gmail.com omap3_pandora ARM CORTEX-A8 (OMAP3xx SoC) diff --git a/MAKEALL b/MAKEALL index 2527352..2066587 100755 --- a/MAKEALL +++ b/MAKEALL @@ -641,6 +641,7 @@ LIST_ARM11=\ ## ARM Cortex-A8 Systems # LIST_ARM_CORTEX_A8= \ + am3517_evm \ devkit8000 \ mx51evk \ omap3_beagle\ diff --git a/Makefile b/Makefile index c26e491..b935c1a 100644 --- a/Makefile +++ b/Makefile @@ -3155,6 +3155,9 @@ SMN42_config : unconfig ## ARM CORTEX Systems # +am3517_evm_config :unconfig + @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 am3517evm logicpd omap3 + devkit8000_config :unconfig @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 devkit8000 timll omap3 diff --git a/board/logicpd/am3517evm/Makefile b/board/logicpd/am3517evm/Makefile new file mode 100644 index 000..3a6b1a1 --- /dev/null +++ b/board/logicpd/am3517evm/Makefile @@ -0,0 +1,46 @@ +# +# Author: Vaibhav Hiremath hvaib...@ti.com +# +# Based on ti/evm/Makefile +# +# Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/ +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).a + +COBJS := am3517evm.o + +SRCS := $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) + +$(LIB):$(obj).depend $(OBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) + +clean: + rm -f $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak $(obj).depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend diff --git a/board/logicpd/am3517evm/am3517evm.c b/board/logicpd/am3517evm/am3517evm.c new file mode 100644 index 000..bbb6e83 --- /dev/null +++ b/board/logicpd/am3517evm/am3517evm.c @@ -0,0 +1,76 @@ +/* + * am3517evm.c - board file for TI's AM3517 family of devices. + * + * Author: Vaibhav Hiremath hvaib...@ti.com + * + * Based on ti/evm/evm.c + * + * Copyright (C) 2010 + * Texas Instruments Incorporated - http://www.ti.com/ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A
Re: [U-Boot] [PATCH v5] da830: Move common code out of da830evm.c file
-Original Message- From: Sudhakar Rajashekhara [mailto:sudhakar@ti.com] Sent: Monday, June 07, 2010 4:30 AM To: u-boot@lists.denx.de Cc: Paulraj, Sandeep; Rajashekhara, Sudhakar Subject: [PATCH v5] da830: Move common code out of da830evm.c file TI's DA850/OMAP-L138 platform is similar to DA830/OMAP-L137 in many aspects. So instead of repeating the same code in multiple files, move the common code to a different file and call those functions from the respective da830/da850 files. Signed-off-by: Sudhakar Rajashekhara sudhakar@ti.com Acked-by: Nick Thompson nick.thomp...@ge.com Acked-by: Ben Gardiner bengardi...@nanometrics.ca --- Since v4: a. Moved the irq_init() and davinci_configure_lpsc_items() functions to board/davinci/da830evm/common.c file. b. Renamed davinci_configure_lpsc_items to da8xx_configure_lpsc_items. c. Created board/davinci/da830evm/common.h file. board/davinci/da830evm/Makefile |2 +- board/davinci/da830evm/common.c | 55 + board/davinci/da830evm/common.h | 30 board/davinci/da830evm/da830evm.c | 29 --- 4 files changed, 98 insertions(+), 18 deletions(-) create mode 100644 board/davinci/da830evm/common.c create mode 100644 board/davinci/da830evm/common.h Sudhakar, I tried to apply the other patch in the original series for DA850 support. Unfortunately it would not apply because it seems as if you have modified the Makefile. Could you please submit updated patches for DA850 on top of this patch? Testing both DA 830 and 850 would also be appreciated as I don't have those EVMs Thanks, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 0/3] TI: tnetv107x patch series
TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a bunch on on-chip integrated peripherals. This patch series generalizes current ARM1176 code to allow for the addition of new ARM1176 SOCs. The remaining patches in this series add arch and board support. Cyril Chemparathy (3): ARM1176: Coexist with other ARM1176 platforms ARM1176: TI: TNETV107X soc initial support TI: TNETV107X EVM initial support MAINTAINERS |4 + MAKEALL |1 + Makefile|3 + arch/arm/cpu/arm1176/cpu.c |3 - arch/arm/cpu/arm1176/start.S| 65 +++- arch/arm/cpu/arm1176/tnetv107x/Makefile | 44 +++ arch/arm/cpu/arm1176/tnetv107x/aemif.c | 93 + arch/arm/cpu/arm1176/tnetv107x/clock.c | 451 +++ arch/arm/cpu/arm1176/tnetv107x/init.c | 37 ++ arch/arm/cpu/arm1176/tnetv107x/lowlevel_init.S | 25 ++ arch/arm/cpu/arm1176/tnetv107x/mux.c| 334 + arch/arm/cpu/arm1176/tnetv107x/timer.c | 122 ++ arch/arm/cpu/arm1176/tnetv107x/wdt.c| 180 + arch/arm/include/asm/arch-tnetv107x/clock.h | 68 arch/arm/include/asm/arch-tnetv107x/emif_defs.h |1 + arch/arm/include/asm/arch-tnetv107x/hardware.h | 173 + arch/arm/include/asm/arch-tnetv107x/mux.h | 306 +++ arch/arm/include/asm/arch-tnetv107x/nand_defs.h | 38 ++ board/ti/tnetv107xevm/Makefile | 49 +++ board/ti/tnetv107xevm/config.mk | 20 + board/ti/tnetv107xevm/sdb_board.c | 149 include/configs/smdk6400.h |8 +- include/configs/tnetv107x_evm.h | 153 23 files changed, 2304 insertions(+), 23 deletions(-) create mode 100644 arch/arm/cpu/arm1176/tnetv107x/Makefile create mode 100644 arch/arm/cpu/arm1176/tnetv107x/aemif.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/clock.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/init.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/lowlevel_init.S create mode 100644 arch/arm/cpu/arm1176/tnetv107x/mux.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/timer.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/wdt.c create mode 100644 arch/arm/include/asm/arch-tnetv107x/clock.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/emif_defs.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/hardware.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/mux.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/nand_defs.h create mode 100644 board/ti/tnetv107xevm/Makefile create mode 100644 board/ti/tnetv107xevm/config.mk create mode 100644 board/ti/tnetv107xevm/sdb_board.c create mode 100644 include/configs/tnetv107x_evm.h I'll be adding this patch set to u-boot-ti. This patch modifies Arm specific code but we have not received any comments for more than a month so I'll apply this patch set. Thanks, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init()
The Ethernet initialization functions are supposed to return the number of
devices initialized, so fix tsec_eth_init() and tsec_standard_init() so that
they returns the number of TSECs initialized, instead of just zero. This is
safe because the return value is currently ignored by all callers, but now they
don't have to ignore it.
In general, if an function initializes only one device, then it should return
a negative number if there's an error. If it initializes more than one device,
then it should never return a negative number. This is why these functions
now return an unsigned integer.
Signed-off-by: Timur Tabi ti...@freescale.com
---
drivers/net/tsec.c | 22 --
include/tsec.h |4 ++--
2 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index 3e4c3bd..6ca9735 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -95,17 +95,27 @@ static struct tsec_info_struct tsec_info[] = {
#endif
};
-int tsec_eth_init(bd_t *bis, struct tsec_info_struct *tsecs, int num)
+/*
+ * Initialize all the TSEC devices
+ *
+ * Returns the number of TSEC devices that were initialized
+ */
+unsigned int tsec_eth_init(bd_t *bis, struct tsec_info_struct *tsecs, int num)
{
- int i;
-
- for (i = 0; i num; i++)
- tsec_initialize(bis, tsecs[i]);
+ unsigned int i;
+ unsigned int count = 0;
+ int ret;
+
+ for (i = 0; i num; i++) {
+ ret = tsec_initialize(bis, tsecs[i]);
+ if (ret 0)
+ count += ret;
+ }
- return 0;
+ return count;
}
-int tsec_standard_init(bd_t *bis)
+unsigned int tsec_standard_init(bd_t *bis)
{
return tsec_eth_init(bis, tsec_info, ARRAY_SIZE(tsec_info));
}
diff --git a/include/tsec.h b/include/tsec.h
index 1e90365..9da2740 100644
--- a/include/tsec.h
+++ b/include/tsec.h
@@ -657,7 +657,7 @@ struct tsec_info_struct {
u32 flags;
};
-int tsec_standard_init(bd_t *bis);
-int tsec_eth_init(bd_t *bis, struct tsec_info_struct *tsec_info, int num);
+unsigned int tsec_standard_init(bd_t *bis);
+unsigned int tsec_eth_init(bd_t *bis, struct tsec_info_struct *tsecs, int num);
#endif /* __TSEC_H */
--
1.7.0.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 0/3] TI: tnetv107x patch series
-Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Paulraj, Sandeep Sent: Monday, June 07, 2010 12:02 PM To: Chemparathy, Cyril; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v6 0/3] TI: tnetv107x patch series TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a bunch on on-chip integrated peripherals. This patch series generalizes current ARM1176 code to allow for the addition of new ARM1176 SOCs. The remaining patches in this series add arch and board support. Cyril Chemparathy (3): ARM1176: Coexist with other ARM1176 platforms ARM1176: TI: TNETV107X soc initial support TI: TNETV107X EVM initial support MAINTAINERS |4 + MAKEALL |1 + Makefile|3 + arch/arm/cpu/arm1176/cpu.c |3 - arch/arm/cpu/arm1176/start.S| 65 +++- arch/arm/cpu/arm1176/tnetv107x/Makefile | 44 +++ arch/arm/cpu/arm1176/tnetv107x/aemif.c | 93 + arch/arm/cpu/arm1176/tnetv107x/clock.c | 451 +++ arch/arm/cpu/arm1176/tnetv107x/init.c | 37 ++ arch/arm/cpu/arm1176/tnetv107x/lowlevel_init.S | 25 ++ arch/arm/cpu/arm1176/tnetv107x/mux.c| 334 + arch/arm/cpu/arm1176/tnetv107x/timer.c | 122 ++ arch/arm/cpu/arm1176/tnetv107x/wdt.c| 180 + arch/arm/include/asm/arch-tnetv107x/clock.h | 68 arch/arm/include/asm/arch-tnetv107x/emif_defs.h |1 + arch/arm/include/asm/arch-tnetv107x/hardware.h | 173 + arch/arm/include/asm/arch-tnetv107x/mux.h | 306 +++ arch/arm/include/asm/arch-tnetv107x/nand_defs.h | 38 ++ board/ti/tnetv107xevm/Makefile | 49 +++ board/ti/tnetv107xevm/config.mk | 20 + board/ti/tnetv107xevm/sdb_board.c | 149 include/configs/smdk6400.h |8 +- include/configs/tnetv107x_evm.h | 153 23 files changed, 2304 insertions(+), 23 deletions(-) create mode 100644 arch/arm/cpu/arm1176/tnetv107x/Makefile create mode 100644 arch/arm/cpu/arm1176/tnetv107x/aemif.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/clock.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/init.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/lowlevel_init.S create mode 100644 arch/arm/cpu/arm1176/tnetv107x/mux.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/timer.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/wdt.c create mode 100644 arch/arm/include/asm/arch-tnetv107x/clock.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/emif_defs.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/hardware.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/mux.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/nand_defs.h create mode 100644 board/ti/tnetv107xevm/Makefile create mode 100644 board/ti/tnetv107xevm/config.mk create mode 100644 board/ti/tnetv107xevm/sdb_board.c create mode 100644 include/configs/tnetv107x_evm.h I'll be adding this patch set to u-boot-ti. This patch modifies Arm specific code but we have not received any comments for more than a month so I'll apply this patch set. Thanks, Sandeep Ran MAKEALL on ARM 11 boards and so no issues ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] DaVinci: Improve DaVinci SPI speed.
I have updated this patch based on the comments [1] by Wolfgang Denk and removed unused variables. [1][http://lists.denx.de/pipermail/u-boot/2010-May/071728.html] Reduce the number of reads per byte transferred on the BUF register from 2 to 1 and take advantage of the TX buffer in the SPI module. On LogicPD OMAP-L138 EVM, SPI read throughput goes up from ~0.8Mbyte/s to ~1.3Mbyte/s. Tested with a 2Mbyte image file. Remove unused variables in the spi_xfer() function. Signed-off-by: Delio Brignoli dbrign...@audioscience.com Tested-by: Ben Gardiner bengardi...@nanometrics.ca --- Checkpatch returned 4 errors. Please fix and resubmit Thanks, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] arm: cortexa9: adding support for TI OMAP4430 SDP
Dear V, Aneesh, In message ff55437e1f14da4baeb721a458b6701706bd8cc...@dbde02.ent.ti.com you wrote: And: no spaces after function names please (fix globally!). But how about this rule mentioned in your wiki: All contributions to U-Boot should conform to the Linux kernel coding styl e; see the file Documentation/CodingStyle and the script scripts/Lindent in your Linux kernel source directory. In sources originating from U-Boot a style corresponding to Lindent -pcs (adding spaces before parameters t o function calls) is actually used. [Could you please restrict your ine length to some 70 characters or so? Thanks!] http://www.denx.de/wiki/U-Boot/CodingStyle In fact, I didn't add spaces initially. They got added when I ran Lindent -pcs. Is this rule not applicable anymore? Or am I missing something? Thais was written some time ago by me, and nobody cared to fix it yet. Having the spaces was (and is) my ownporeferred style, but I got overruled by a vast majority... -Original Message- From: Wolfgang Denk [mailto:w...@denx.de] Sent: Sunday, June 06, 2010 1:25 AM To: V, Aneesh Cc: u-boot@lists.denx.de; olbp...@list.ti.com - OMAP Linux Baseport Development Team (May contain non-TIers) Subject: Re: [U-Boot] [PATCH 2/2] arm: cortexa9: adding support for TI OMAP4430 SDP Dear Aneesh V, And please don;t top-post / full quote; please see http://www.netmeister.org/news/learn2quote.html Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A morsel of genuine history is a thing so rare as to be always valuable. - Thomas Jefferson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] u-boot-mpc83xx fix
Dear Kim Phillips, In message 20100607075435.9b556925.kim.phill...@freescale.com you wrote: Wolfgang Denk, Please pull a fix for the mpc8313 usb setting: The following changes since commit 9bb3b3d4406c1e388a99f6fb189147d6a06cc2cf: Merge branch 'master' of git://git.denx.de/u-boot-mpc85xx (2010-05-30 21:44:07 +0200) are available in the git repository at: git://git.denx.de/u-boot-mpc83xx.git master Ron Madrid (1): Update SICRL_USBDR to reflect 4 different settings include/configs/MPC8313ERDB.h |2 +- include/configs/SIMPC8313.h |2 +- include/mpc83xx.h |5 - 3 files changed, 6 insertions(+), 3 deletions(-) Applied, thanks. Also, I've noticed main CHANGELOG updates are still being performed: Yes, as we don't have a new solution implemented yet. Any news wrt implementing a gitattributes based solution instead?: http://lists.denx.de/pipermail/u-boot/2010-May/071118.html I haven't seen any patches implementing this yet - am I missing something? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Writing a book is like washing an elephant: there's no good place to begin or end, and it's hard to keep track of what you've already covered. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] DaVinci: Improve DaVinci SPI speed.
I have updated this patch based on the comments [1] by Wolfgang Denk and removed unused variables. [1][http://lists.denx.de/pipermail/u-boot/2010-May/071728.html] Reduce the number of reads per byte transferred on the BUF register from 2 to 1 and take advantage of the TX buffer in the SPI module. On LogicPD OMAP-L138 EVM, SPI read throughput goes up from ~0.8Mbyte/s to ~1.3Mbyte/s. Tested with a 2Mbyte image file. Remove unused variables in the spi_xfer() function. Signed-off-by: Delio Brignoli dbrign...@audioscience.com Tested-by: Ben Gardiner bengardi...@nanometrics.ca --- Checkpatch returned 4 errors. Please fix and resubmit Thanks, Sandeep I fixed them myself. Pushed to u-boot-ti ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH-V4 1/2] AM35x: Add support for AM3517EVM
From: Vaibhav Hiremath hvaib...@ti.com This patch adds basic support for the AM3517EVM. It includes: - Board files (.c and .h) - Default configuration file - Updates for Makefile Signed-off-by: Vaibhav Hiremath hvaib...@ti.com Signed-off-by: Sanjeev Premi pr...@ti.com --- Changes from V2: - Removed trailing spaces - Updated MAINTAINERS MAKEALL for am3517_evm Changes from V3: - Corrected Maintainer entry to keep list sorted - Moved AM3537 macros to board header file MAINTAINERS |4 + MAKEALL |1 + Makefile|3 + board/logicpd/am3517evm/Makefile| 46 board/logicpd/am3517evm/am3517evm.c | 76 ++ board/logicpd/am3517evm/am3517evm.h | 445 +++ board/logicpd/am3517evm/config.mk | 30 +++ include/configs/am3517_evm.h| 296 +++ 8 files changed, 901 insertions(+), 0 deletions(-) create mode 100644 board/logicpd/am3517evm/Makefile create mode 100644 board/logicpd/am3517evm/am3517evm.c create mode 100644 board/logicpd/am3517evm/am3517evm.h create mode 100644 board/logicpd/am3517evm/config.mk create mode 100644 include/configs/am3517_evm.h I have pushed the following to u-boot-ti AFTER running MAKEALL for ALL CORTEX AB boards I pushed the following patches. There were some checkpatch errors. I fixed them myself. [PATCH-V4 1/2] AM35x: Add support for AM3517EVM [PATCH-V4 2/2] AM35x: Add support for EMIF4 [PATCH-V3 1/2] omap3: Calculate CS1 size only when SDRC is initialized for CS1 [PATCH-V3 2/2] omap3: Consolidate SDRC related operations [PATCH-V4] OMAP3EVM: Added NAND support Thanks, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please Pull u-boot-ti/master
Tom, Please pull u-boot-ti/master. There are some more patches but those would not apply clean. Will send a separate pull request for them. I ran MAKEALL for all ARM 11 and CORTEX A8 boards. Thanks, Sandeep The following changes since commit 9bb3b3d4406c1e388a99f6fb189147d6a06cc2cf: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-mpc85xx are available in the git repository at: git://git.denx.de/u-boot-ti.git master Cyril Chemparathy (3): ARM1176: Coexist with other ARM1176 platforms ARM1176: TI: TNETV107X soc initial support TI: TNETV107X EVM initial support Delio Brignoli (1): DaVinci: Improve DaVinci SPI speed. Vaibhav Hiremath (5): OMAP3EVM: Added NAND support omap3: Calculate CS1 size only when SDRC is omap3: Consolidate SDRC related operations AM35x: Add support for AM3517EVM AM35x: Add support for EMIF4 MAINTAINERS |8 + MAKEALL |2 + Makefile|6 + arch/arm/cpu/arm1176/cpu.c |3 - arch/arm/cpu/arm1176/start.S| 65 +++- arch/arm/cpu/arm1176/tnetv107x/Makefile | 44 +++ arch/arm/cpu/arm1176/tnetv107x/aemif.c | 93 + arch/arm/cpu/arm1176/tnetv107x/clock.c | 451 +++ arch/arm/cpu/arm1176/tnetv107x/init.c | 37 ++ arch/arm/cpu/arm1176/tnetv107x/lowlevel_init.S | 25 ++ arch/arm/cpu/arm1176/tnetv107x/mux.c| 334 + arch/arm/cpu/arm1176/tnetv107x/timer.c | 122 ++ arch/arm/cpu/arm1176/tnetv107x/wdt.c| 180 + arch/arm/cpu/arm_cortexa8/omap3/Makefile|5 +- arch/arm/cpu/arm_cortexa8/omap3/board.c | 34 +-- arch/arm/cpu/arm_cortexa8/omap3/emif4.c | 168 + arch/arm/cpu/arm_cortexa8/omap3/mem.c | 90 - arch/arm/cpu/arm_cortexa8/omap3/sdrc.c | 202 ++ arch/arm/cpu/arm_cortexa8/omap3/sys_info.c | 41 -- arch/arm/include/asm/arch-omap3/cpu.h | 25 ++ arch/arm/include/asm/arch-omap3/emif4.h | 79 arch/arm/include/asm/arch-omap3/mem.h | 13 + arch/arm/include/asm/arch-omap3/sys_proto.h |3 +- arch/arm/include/asm/arch-tnetv107x/clock.h | 68 arch/arm/include/asm/arch-tnetv107x/emif_defs.h |1 + arch/arm/include/asm/arch-tnetv107x/hardware.h | 173 + arch/arm/include/asm/arch-tnetv107x/mux.h | 306 +++ arch/arm/include/asm/arch-tnetv107x/nand_defs.h | 38 ++ board/logicpd/am3517evm/Makefile| 46 +++ board/logicpd/am3517evm/am3517evm.c | 76 board/logicpd/am3517evm/am3517evm.h | 445 ++ board/logicpd/am3517evm/config.mk | 30 ++ board/ti/tnetv107xevm/Makefile | 49 +++ board/ti/tnetv107xevm/config.mk | 20 + board/ti/tnetv107xevm/sdb_board.c | 149 drivers/spi/davinci_spi.c | 77 +++-- include/configs/am3517_evm.h| 296 +++ include/configs/devkit8000.h|2 + include/configs/omap3_beagle.h |2 + include/configs/omap3_evm.h | 10 +- include/configs/omap3_overo.h |2 + include/configs/omap3_pandora.h |2 + include/configs/omap3_sdp3430.h |2 + include/configs/omap3_zoom1.h |2 + include/configs/omap3_zoom2.h |2 + include/configs/smdk6400.h |8 +- include/configs/tnetv107x_evm.h | 153 47 files changed, 3764 insertions(+), 225 deletions(-) create mode 100644 arch/arm/cpu/arm1176/tnetv107x/Makefile create mode 100644 arch/arm/cpu/arm1176/tnetv107x/aemif.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/clock.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/init.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/lowlevel_init.S create mode 100644 arch/arm/cpu/arm1176/tnetv107x/mux.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/timer.c create mode 100644 arch/arm/cpu/arm1176/tnetv107x/wdt.c create mode 100644 arch/arm/cpu/arm_cortexa8/omap3/emif4.c create mode 100644 arch/arm/cpu/arm_cortexa8/omap3/sdrc.c create mode 100644 arch/arm/include/asm/arch-omap3/emif4.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/clock.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/emif_defs.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/hardware.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/mux.h create mode 100644 arch/arm/include/asm/arch-tnetv107x/nand_defs.h create mode 100644 board/logicpd/am3517evm/Makefile create mode 100644 board/logicpd/am3517evm/am3517evm.c create mode 100644
[U-Boot] [PATCH 1/4] Atmel Dataflash: convert to C struct accessors
Instead of using the old-style base + offset accessors, use the new
at91 C struct accessors.
The removal of #ifdef CONFIG_AT91_LEGACY allows to keep the definition
of register values, needed to program the SPI.
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/include/asm/arch-at91/at91_spi.h |4 --
drivers/spi/atmel_dataflash_spi.c | 77 +++-
2 files changed, 41 insertions(+), 40 deletions(-)
diff --git a/arch/arm/include/asm/arch-at91/at91_spi.h
b/arch/arm/include/asm/arch-at91/at91_spi.h
index c520e89..73e23cf 100644
--- a/arch/arm/include/asm/arch-at91/at91_spi.h
+++ b/arch/arm/include/asm/arch-at91/at91_spi.h
@@ -33,8 +33,6 @@ typedef struct at91_spi {
at91_pdc_t pdc;
} at91_spi_t;
-#ifdef CONFIG_AT91_LEGACY
-
#define AT91_SPI_CR0x00/* Control Register */
#defineAT91_SPI_SPIEN (1 0) /* SPI
Enable */
#defineAT91_SPI_SPIDIS (1 1) /* SPI
Disable */
@@ -121,6 +119,4 @@ typedef struct at91_spi {
#define AT91_SPI_PTSR 0x0124 /* PDC Transfer Status
Register */
-#endif /* CONFIG_AT91_LEGACY */
-
#endif
diff --git a/drivers/spi/atmel_dataflash_spi.c
b/drivers/spi/atmel_dataflash_spi.c
index 4a5c4aa..3693c93 100644
--- a/drivers/spi/atmel_dataflash_spi.c
+++ b/drivers/spi/atmel_dataflash_spi.c
@@ -2,6 +2,9 @@
* Driver for ATMEL DataFlash support
* Author : Hamid Ikdoumi (Atmel)
*
+ * Conversion to C struct SoC accessors by Thomas Petazzoni
+ * thomas.petazz...@free-electrons.com.
+ *
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of
@@ -20,10 +23,6 @@
*/
#include common.h
-#ifndef CONFIG_AT91_LEGACY
-#define CONFIG_AT91_LEGACY
-#warning Please update to use C structur SoC access !
-#endif
#include asm/arch/hardware.h
#include asm/arch/clk.h
#include asm/arch/gpio.h
@@ -40,19 +39,21 @@
void AT91F_SpiInit(void)
{
+ at91_spi_t *spi = (at91_spi_t *) AT91_SPI0_BASE;
+
/* Reset the SPI */
- writel(AT91_SPI_SWRST, AT91_BASE_SPI + AT91_SPI_CR);
+ writel(AT91_SPI_SWRST, spi-cr);
/* Configure SPI in Master Mode with No CS selected !!! */
writel(AT91_SPI_MSTR | AT91_SPI_MODFDIS | AT91_SPI_PCS,
- AT91_BASE_SPI + AT91_SPI_MR);
+ spi-mr);
/* Configure CS0 */
writel(AT91_SPI_NCPHA |
(AT91_SPI_DLYBS DATAFLASH_TCSS) |
(AT91_SPI_DLYBCT DATAFLASH_TCHS) |
((get_mck_clk_rate() / AT91_SPI_CLK) 8),
- AT91_BASE_SPI + AT91_SPI_CSR(0));
+ spi-csr[0]);
#ifdef CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS1
/* Configure CS1 */
@@ -60,7 +61,7 @@ void AT91F_SpiInit(void)
(AT91_SPI_DLYBS DATAFLASH_TCSS) |
(AT91_SPI_DLYBCT DATAFLASH_TCHS) |
((get_mck_clk_rate() / AT91_SPI_CLK) 8),
- AT91_BASE_SPI + AT91_SPI_CSR(1));
+ spi-csr[1]);
#endif
#ifdef CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS2
/* Configure CS2 */
@@ -68,7 +69,7 @@ void AT91F_SpiInit(void)
(AT91_SPI_DLYBS DATAFLASH_TCSS) |
(AT91_SPI_DLYBCT DATAFLASH_TCHS) |
((get_mck_clk_rate() / AT91_SPI_CLK) 8),
- AT91_BASE_SPI + AT91_SPI_CSR(2));
+ spi-csr[2]);
#endif
#ifdef CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS3
/* Configure CS3 */
@@ -76,95 +77,99 @@ void AT91F_SpiInit(void)
(AT91_SPI_DLYBS DATAFLASH_TCSS) |
(AT91_SPI_DLYBCT DATAFLASH_TCHS) |
((get_mck_clk_rate() / AT91_SPI_CLK) 8),
- AT91_BASE_SPI + AT91_SPI_CSR(3));
+ spi-csr[3]);
#endif
/* SPI_Enable */
- writel(AT91_SPI_SPIEN, AT91_BASE_SPI + AT91_SPI_CR);
+ writel(AT91_SPI_SPIEN, spi-cr);
- while (!(readl(AT91_BASE_SPI + AT91_SPI_SR) AT91_SPI_SPIENS));
+ while (!(readl(spi-sr) AT91_SPI_SPIENS))
+ ;
/*
* Add tempo to get SPI in a safe state.
* Should not be needed for new silicon (Rev B)
*/
udelay(50);
- readl(AT91_BASE_SPI + AT91_SPI_SR);
- readl(AT91_BASE_SPI + AT91_SPI_RDR);
+ readl(spi-sr);
+ readl(spi-rdr);
}
void AT91F_SpiEnable(int cs)
{
+ at91_spi_t *spi = (at91_spi_t *) AT91_SPI0_BASE;
unsigned long mode;
switch (cs) {
case 0: /* Configure SPI CS0 for Serial DataFlash AT45DBxx */
- mode = readl(AT91_BASE_SPI + AT91_SPI_MR);
+ mode = readl(spi-mr);
mode = 0xFFF0;
writel(mode | ((AT91_SPI_PCS0_DATAFLASH_CARD16)
AT91_SPI_PCS),
- AT91_BASE_SPI + AT91_SPI_MR);
+ spi-mr);
[U-Boot] [PATCH 0/4] Calao USB-A9263 v2
Hello, Here is a resend of the Calao USB-A9263 board support, with the following changes since v1: * checkpatch fixes all over the place. There is a remaining Macros with complex values should be enclosed in parenthesis checkpatch issue, but this is unfortunately how this macro should be used (it's the new AT91 accessors) * build fixes for all AT91 boards. MAKEALL at91 builds all boards sucessfully. There are only one warning per board saying that atmel_usart should be converted to C struct accessors. I intend to work on this when the current patches get merged. Thanks, Thomas Thomas Petazzoni (4): Atmel Dataflash: convert to C struct accessors at91_spi: remove register offsets Add new style definition for SPI0_BASE Support for Calao USB A9263 board based on AT91SAM9263 CPU MAINTAINERS |4 + MAKEALL |1 + Makefile |3 + arch/arm/include/asm/arch-at91/at91_spi.h| 157 ++ arch/arm/include/asm/arch-at91/at91cap9.h|1 + arch/arm/include/asm/arch-at91/at91sam9260.h |1 + arch/arm/include/asm/arch-at91/at91sam9261.h |1 + arch/arm/include/asm/arch-at91/at91sam9263.h |1 + arch/arm/include/asm/arch-at91/at91sam9g45.h |1 + arch/arm/include/asm/arch-at91/at91sam9rl.h |1 + board/calao/usb-a9263/Makefile | 58 board/calao/usb-a9263/config.mk | 24 board/calao/usb-a9263/partition.c| 38 ++ board/calao/usb-a9263/usb-a9263.c| 186 ++ drivers/spi/atmel_dataflash_spi.c| 77 ++- include/configs/usb-a9263.h | 182 + 16 files changed, 611 insertions(+), 125 deletions(-) create mode 100644 board/calao/usb-a9263/Makefile create mode 100644 board/calao/usb-a9263/config.mk create mode 100644 board/calao/usb-a9263/partition.c create mode 100644 board/calao/usb-a9263/usb-a9263.c create mode 100644 include/configs/usb-a9263.h ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/4] Add new style definition for SPI0_BASE
The new C struct accessors define new constants for the base address of the peripherals. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com --- arch/arm/include/asm/arch-at91/at91cap9.h|1 + arch/arm/include/asm/arch-at91/at91sam9260.h |1 + arch/arm/include/asm/arch-at91/at91sam9261.h |1 + arch/arm/include/asm/arch-at91/at91sam9263.h |1 + arch/arm/include/asm/arch-at91/at91sam9g45.h |1 + arch/arm/include/asm/arch-at91/at91sam9rl.h |1 + 6 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/arm/include/asm/arch-at91/at91cap9.h b/arch/arm/include/asm/arch-at91/at91cap9.h index 5af6fdc..732ee95 100644 --- a/arch/arm/include/asm/arch-at91/at91cap9.h +++ b/arch/arm/include/asm/arch-at91/at91cap9.h @@ -53,6 +53,7 @@ #define AT91CAP9_ID_IRQ0 30 /* Advanced Interrupt Controller (IRQ0) */ #define AT91CAP9_ID_IRQ1 31 /* Advanced Interrupt Controller (IRQ1) */ +#define AT91_SPI0_BASE 0xfffa4000 #define AT91_PIO_BASE 0xf200 #define AT91_PMC_BASE 0xfc00 #define AT91_RSTC_BASE 0xfd00 diff --git a/arch/arm/include/asm/arch-at91/at91sam9260.h b/arch/arm/include/asm/arch-at91/at91sam9260.h index ec04318..fda8e59 100644 --- a/arch/arm/include/asm/arch-at91/at91sam9260.h +++ b/arch/arm/include/asm/arch-at91/at91sam9260.h @@ -50,6 +50,7 @@ #define AT91SAM9260_ID_IRQ231 /* Advanced Interrupt Controller (IRQ2) */ #define AT91_EMAC_BASE 0xfffc4000 +#define AT91_SPI0_BASE 0xfffc8000 #define AT91_SDRAMC_BASE 0xea00 #define AT91_SMC_BASE 0xec00 #define AT91_MATRIX_BASE 0xee00 diff --git a/arch/arm/include/asm/arch-at91/at91sam9261.h b/arch/arm/include/asm/arch-at91/at91sam9261.h index 7ca0283..ef57403 100644 --- a/arch/arm/include/asm/arch-at91/at91sam9261.h +++ b/arch/arm/include/asm/arch-at91/at91sam9261.h @@ -43,6 +43,7 @@ #define AT91SAM9261_ID_IRQ130 /* Advanced Interrupt Controller (IRQ1) */ #define AT91SAM9261_ID_IRQ231 /* Advanced Interrupt Controller (IRQ2) */ +#define AT91_SPI0_BASE 0xfffc8000 #define AT91_SDRAMC_BASE 0xea00 #define AT91_SMC_BASE 0xec00 #define AT91_MATRIX_BASE 0xee00 diff --git a/arch/arm/include/asm/arch-at91/at91sam9263.h b/arch/arm/include/asm/arch-at91/at91sam9263.h index 4ada1ce..d6c8982 100644 --- a/arch/arm/include/asm/arch-at91/at91sam9263.h +++ b/arch/arm/include/asm/arch-at91/at91sam9263.h @@ -47,6 +47,7 @@ #define AT91SAM9263_ID_IRQ030 /* Advanced Interrupt Controller (IRQ0) */ #define AT91SAM9263_ID_IRQ131 /* Advanced Interrupt Controller (IRQ1) */ +#define AT91_SPI0_BASE 0xfffa4000 #define AT91_EMAC_BASE 0xfffbc000 #define AT91_ECC0_BASE 0xe000 #define AT91_SDRAMC0_BASE 0xe200 diff --git a/arch/arm/include/asm/arch-at91/at91sam9g45.h b/arch/arm/include/asm/arch-at91/at91sam9g45.h index 445f4b2..9bf4149 100644 --- a/arch/arm/include/asm/arch-at91/at91sam9g45.h +++ b/arch/arm/include/asm/arch-at91/at91sam9g45.h @@ -51,6 +51,7 @@ #define AT91SAM9G45_ID_VDEC30 /* Video Decoder */ #define AT91SAM9G45_ID_IRQ031 /* Advanced Interrupt Controller */ +#define AT91_SPI0_BASE 0xfffa4000 #define AT91_EMAC_BASE 0xfffbc000 #define AT91_SMC_BASE 0xe800 #define AT91_MATRIX_BASE 0xea00 diff --git a/arch/arm/include/asm/arch-at91/at91sam9rl.h b/arch/arm/include/asm/arch-at91/at91sam9rl.h index 8eb0d4f..5807cd2 100644 --- a/arch/arm/include/asm/arch-at91/at91sam9rl.h +++ b/arch/arm/include/asm/arch-at91/at91sam9rl.h @@ -44,6 +44,7 @@ #define AT91SAM9RL_ID_AC97C24 /* AC97 Controller */ #define AT91SAM9RL_ID_IRQ0 31 /* Advanced Interrupt Controller (IRQ0) */ +#define AT91_SPI0_BASE 0xfffcc000 #define AT91_SDRAMC_BASE 0xea00 #define AT91_SMC_BASE 0xec00 #define AT91_MATRIX_BASE 0xee00 -- 1.7.0.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/4] at91_spi: remove register offsets
Since all users of at91_spi have been converted to C struct accessors,
the register offsets definitions are no longer needed.
We take this opportunity to do a little bit of reformatting for the
register bits definitions.
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/include/asm/arch-at91/at91_spi.h | 153 +
1 files changed, 68 insertions(+), 85 deletions(-)
diff --git a/arch/arm/include/asm/arch-at91/at91_spi.h
b/arch/arm/include/asm/arch-at91/at91_spi.h
index 73e23cf..0046256 100644
--- a/arch/arm/include/asm/arch-at91/at91_spi.h
+++ b/arch/arm/include/asm/arch-at91/at91_spi.h
@@ -33,90 +33,73 @@ typedef struct at91_spi {
at91_pdc_t pdc;
} at91_spi_t;
-#define AT91_SPI_CR0x00/* Control Register */
-#defineAT91_SPI_SPIEN (1 0) /* SPI
Enable */
-#defineAT91_SPI_SPIDIS (1 1) /* SPI
Disable */
-#defineAT91_SPI_SWRST (1 7) /* SPI
Software Reset */
-#defineAT91_SPI_LASTXFER (1 24) /* Last
Transfer [SAM9261 only] */
-
-#define AT91_SPI_MR0x04/* Mode Register */
-#defineAT91_SPI_MSTR (1 0)/*
Master/Slave Mode */
-#defineAT91_SPI_PS (1 1)/*
Peripheral Select */
-#defineAT91_SPI_PS_FIXED (0 1)
-#defineAT91_SPI_PS_VARIABLE(1 1)
-#defineAT91_SPI_PCSDEC (1 2)/* Chip
Select Decode */
-#defineAT91_SPI_DIV32 (1 3)/*
Clock Selection [AT91RM9200 only] */
-#defineAT91_SPI_MODFDIS(1 4)/* Mode
Fault Detection */
-#defineAT91_SPI_LLB(1 7)/*
Local Loopback Enable */
-#defineAT91_SPI_PCS(0xf 16)/*
Peripheral Chip Select */
-#defineAT91_SPI_DLYBCS (0xff 24)/*
Delay Between Chip Selects */
-
-#define AT91_SPI_RDR 0x08/* Receive Data
Register */
-#defineAT91_SPI_RD (0x 0) /*
Receive Data */
-#defineAT91_SPI_PCS(0xf 16) /*
Peripheral Chip Select */
-
-#define AT91_SPI_TDR 0x0c/* Transmit Data
Register */
-#defineAT91_SPI_TD (0x 0) /*
Transmit Data */
-#defineAT91_SPI_PCS(0xf 16) /*
Peripheral Chip Select */
-#defineAT91_SPI_LASTXFER (1 24) /* Last
Transfer [SAM9261 only] */
-
-#define AT91_SPI_SR0x10/* Status Register */
-#defineAT91_SPI_RDRF (1 0) /*
Receive Data Register Full */
-#defineAT91_SPI_TDRE (1 1) /*
Transmit Data Register Full */
-#defineAT91_SPI_MODF (1 2) /* Mode
Fault Error */
-#defineAT91_SPI_OVRES (1 3) /*
Overrun Error Status */
-#defineAT91_SPI_ENDRX (1 4) /* End
of RX buffer */
-#defineAT91_SPI_ENDTX (1 5) /* End
of TX buffer */
-#defineAT91_SPI_RXBUFF (1 6) /* RX
Buffer Full */
-#defineAT91_SPI_TXBUFE (1 7) /* TX
Buffer Empty */
-#defineAT91_SPI_NSSR (1 8) /* NSS
Rising [SAM9261 only] */
-#defineAT91_SPI_TXEMPTY(1 9) /*
Transmission Register Empty [SAM9261 only] */
-#defineAT91_SPI_SPIENS (1 16) /* SPI
Enable Status */
-
-#define AT91_SPI_IER 0x14/* Interrupt Enable
Register */
-#define AT91_SPI_IDR 0x18/* Interrupt Disable
Register */
-#define AT91_SPI_IMR 0x1c/* Interrupt Mask
Register */
-
-#define AT91_SPI_CSR(n)(0x30 + ((n) * 4)) /* Chip Select
Registers 0-3 */
-#defineAT91_SPI_CPOL (1 0)/*
Clock Polarity */
-#defineAT91_SPI_NCPHA (1 1)/*
Clock Phase */
-#defineAT91_SPI_CSAAT (1 3)/* Chip
Select Active After Transfer [SAM9261 only] */
-#defineAT91_SPI_BITS (0xf4)/* Bits
Per Transfer */
-#defineAT91_SPI_BITS_8 (0 4)
-#defineAT91_SPI_BITS_9 (1 4)
-#defineAT91_SPI_BITS_10(2 4)
[U-Boot] [PATCH 4/4] Support for Calao USB A9263 board based on AT91SAM9263 CPU
The Calao USB A9263 board is a board manufactured and sold by Calao Systems http://www.calao-systems.com. Its components are very similar to the AT91SAM9263EK board, so its configuration is based on the configuration of this board. There are however some differences: different clocks, no LCD, etc. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com Signed-off-by: Albin Tonnerre albin.tonne...@free-electrons.com --- MAINTAINERS |4 + MAKEALL |1 + Makefile |3 + board/calao/usb-a9263/Makefile| 58 board/calao/usb-a9263/config.mk | 24 + board/calao/usb-a9263/partition.c | 38 board/calao/usb-a9263/usb-a9263.c | 186 + include/configs/usb-a9263.h | 182 8 files changed, 496 insertions(+), 0 deletions(-) create mode 100644 board/calao/usb-a9263/Makefile create mode 100644 board/calao/usb-a9263/config.mk create mode 100644 board/calao/usb-a9263/partition.c create mode 100644 board/calao/usb-a9263/usb-a9263.c create mode 100644 include/configs/usb-a9263.h diff --git a/MAINTAINERS b/MAINTAINERS index 7a13d28..39c04af 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -700,6 +700,10 @@ Peter Pearse peter.pea...@arm.com versatile ARM926EJ-S versatile ARM926EJ-S +Thomas Petazzoni thomas.petazz...@free-electrons.com + + usb-a9263 ARM926EJS (AT91SAM9263 SoC) + Dave Peverley dpever...@mpc-data.co.uk omap730p2 ARM926EJS diff --git a/MAKEALL b/MAKEALL index 2527352..585a79e 100755 --- a/MAKEALL +++ b/MAKEALL @@ -685,6 +685,7 @@ LIST_at91= \ SBC35_A9G20 \ TNY_A9260 \ TNY_A9G20 \ + usb_a9263 \ # diff --git a/Makefile b/Makefile index c26e491..762ccfb 100644 --- a/Makefile +++ b/Makefile @@ -2890,6 +2890,9 @@ TNY_A9260_config : unconfig @echo #define CONFIG_$(@:_config=) 1 $(obj)include/config.h @$(MKCONFIG) -a tny_a9260 arm arm926ejs tny_a9260 calao at91 +usb_a9263_config : unconfig + @$(MKCONFIG) -a usb-a9263 arm arm926ejs usb-a9263 calao at91 + ## ARM Integrator boards - see doc/README-integrator for more info. integratorap_config\ diff --git a/board/calao/usb-a9263/Makefile b/board/calao/usb-a9263/Makefile new file mode 100644 index 000..ec79872 --- /dev/null +++ b/board/calao/usb-a9263/Makefile @@ -0,0 +1,58 @@ +# +# (C) Copyright 2003-2008 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# (C) Copyright 2008 +# Stelian Pop stelian@leadtechdesign.com +# Lead Tech Design www.leadtechdesign.com +# +# (C) Copyright 2009 +# Thomas Petazzoni, Free Electrons, thomas.petazz...@free-electrons.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).a + +COBJS-y += usb-a9263.o +COBJS-$(CONFIG_HAS_DATAFLASH) += partition.o + +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS-y)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB):$(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak $(obj).depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/calao/usb-a9263/config.mk b/board/calao/usb-a9263/config.mk new file mode 100644 index 000..2724a7d --- /dev/null +++ b/board/calao/usb-a9263/config.mk @@ -0,0 +1,24 @@ +# +# (C) Copyright 2009 +# Thomas Petazzoni, Free Electrons, thomas.petazz...@free-electrons.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of
Re: [U-Boot] [GIT PULL] u-boot-mpc83xx fix
On Mon, 7 Jun 2010 22:40:27 +0200 Wolfgang Denk w...@denx.de wrote: Applied, thanks. Thanks. Also, I've noticed main CHANGELOG updates are still being performed: Yes, as we don't have a new solution implemented yet. Any news wrt implementing a gitattributes based solution instead?: http://lists.denx.de/pipermail/u-boot/2010-May/071118.html I haven't seen any patches implementing this yet - am I missing something? rather than provide a (deficient) patch, I decided to provide basic instructions on how to enable the feature, because you still have to do the: echo 'snapshot.commit export-subst' .git/info/attributes to each repo that is subject to exports (and that file, being under .git/, has to be manually patched). The other part (which the patch below does very trivially) is adding the snapshot.commit file, which effectively replaces the CHANGELOG by being filled with the commit id sha upon each git export. I just wasn't sure if you felt like adding more reference data into the file - see man gitattributes (search for export-subst), and placeholders under PRETTY FORMATS of man git log - looking at the list now however, I'm pretty sure just he commit id sha is enough, so here you go. Kim From c6dd2acf44aecfd2f17329f96f60d028932632b0 Mon Sep 17 00:00:00 2001 From: Kim Phillips kim.phill...@freescale.com Date: Mon, 7 Jun 2010 16:18:35 -0500 Subject: [PATCH] add snapshot.commit file --- snapshot.commit |1 + 1 files changed, 1 insertions(+), 0 deletions(-) create mode 100644 snapshot.commit diff --git a/snapshot.commit b/snapshot.commit new file mode 100644 index 000..6828f88 --- /dev/null +++ b/snapshot.commit @@ -0,0 +1 @@ +$Format:%H$ -- 1.7.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init()
On Monday, June 07, 2010 14:31:27 Timur Tabi wrote: In general, if an function initializes only one device, then it should return a negative number if there's an error. If it initializes more than one device, then it should never return a negative number. This is why these functions now return an unsigned integer. i dont think this is a good idea. either the init funcs should all be converted to unsigned int, or they should stay int. doing it piecemeal leads to confusion with zero upside. your fixes no way require these to be unsigned int funcs. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] Atmel Dataflash: convert to C struct accessors
On Monday, June 07, 2010 17:56:21 Thomas Petazzoni wrote: Instead of using the old-style base + offset accessors, use the new at91 C struct accessors. The removal of #ifdef CONFIG_AT91_LEGACY allows to keep the definition of register values, needed to program the SPI. i have to ask ... what exactly is the advantage of the dataflash driver over the common spi flash drivers ? ive looked a bit and cant pick anything out. better to just scuttle the entire code base imo and unify consumers. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init()
Mike Frysinger wrote: On Monday, June 07, 2010 14:31:27 Timur Tabi wrote: In general, if an function initializes only one device, then it should return a negative number if there's an error. If it initializes more than one device, then it should never return a negative number. This is why these functions now return an unsigned integer. i dont think this is a good idea. either the init funcs should all be converted to unsigned int, or they should stay int. doing it piecemeal leads to confusion with zero upside. I don't want to change all of the functions. For most devices, there's no way I can test them. Just because pci_eth_int() is incorrect, that doesn't mean that I can't make tsec_eth_init() correct. your fixes no way require these to be unsigned int funcs. What's the point of making the return value a signed integer if it can never be a negative number? The reason I changed the type to unsigned int is to make it very clear that it will never return an error code. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Fw:How can I use yaffs2 in uboot
Thank you for your help NOW with absolute path can write and read (small files) but When I write large files,such as 50M (Nand flash size is 256M) Display yaffs: Could not allocate Tnodes yaffs: Could not allocate Tnodes yaffs: Could not allocate Tnodes ... (Many) and then restart my2440 # yls /fash yaffs: Mounting /flash yaffs: Could not allocate Tnodes Error mounting /flash, return value: -12 opendir failed ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init()
On Monday, June 07, 2010 18:55:18 Timur Tabi wrote: Mike Frysinger wrote: On Monday, June 07, 2010 14:31:27 Timur Tabi wrote: In general, if an function initializes only one device, then it should return a negative number if there's an error. If it initializes more than one device, then it should never return a negative number. This is why these functions now return an unsigned integer. i dont think this is a good idea. either the init funcs should all be converted to unsigned int, or they should stay int. doing it piecemeal leads to confusion with zero upside. I don't want to change all of the functions. For most devices, there's no way I can test them. i dont think this is a big deal. plenty of tree wide changes are made and people try their best to break things without actually testing them. Just because pci_eth_int() is incorrect, that doesn't mean that I can't make tsec_eth_init() correct. except all the documentation and existing code says use int, so correct is in the eye of the beholder here. i think consistency is more important at this point than an otherwise meaningless value. your fixes no way require these to be unsigned int funcs. What's the point of making the return value a signed integer if it can never be a negative number? The reason I changed the type to unsigned int is to make it very clear that it will never return an error code. the documentation currently states that a negative value is permissible and thus int is correct. as for the code that actually reads the result, that is by large common code, so logic along those lines isnt terribly important. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] U-boot: Beagle board as a USB Mass Storage Device Class
Hi, I want to make the Beagle board (with u-boot) to look like a USB Mass Storage Device when it is connected to the host PC. Can anyone suggest regarding the files that I need to update in u-boot code, to make the Beagle board look like a USB Mass Storage Device. Regards, Yogesh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
