[U-Boot] [PATCH] board/purple/flash.c: removed unneded variable
removed a variable that was not used
Signed-off-by: Frans Meulenbroeks fransmeulenbro...@gmail.com
---
This supersedes 0001-board-purple-flash.c-removed-unneded-test.patch submitted
yesterday
board/purple/flash.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/board/purple/flash.c b/board/purple/flash.c
index 37c7bec..5cee35e 100644
--- a/board/purple/flash.c
+++ b/board/purple/flash.c
@@ -448,7 +448,6 @@ int flash_erase (flash_info_t *info, int s_first, int
s_last)
FPWV *addr;
int flag, prot, sect;
ulong start, now, last;
- int rcode = 0;
FUNCPTR_WR absEntry;
load_cmd(IN_RAM_CMD_WRITE);
@@ -490,7 +489,7 @@ int flash_erase (flash_info_t *info, int s_first, int
s_last)
last = get_timer(0);
/* Start erase on unprotected sectors */
- for (sect = s_first; sect=s_last rcode == 0; sect++) {
+ for (sect = s_first; sect=s_last; sect++) {
if (info-protect[sect] != 0) /* protected, skip it */
continue;
@@ -523,7 +522,7 @@ int flash_erase (flash_info_t *info, int s_first, int
s_last)
}
printf ( done\n);
- return rcode;
+ return 0;
}
/*---
--
1.6.4.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] board/purple/flash.c: removed unneded variable
Hello.
Frans Meulenbroeks wrote:
removed a variable that was not used
Signed-off-by: Frans Meulenbroeks fransmeulenbro...@gmail.com
[...]
diff --git a/board/purple/flash.c b/board/purple/flash.c
index 37c7bec..5cee35e 100644
--- a/board/purple/flash.c
+++ b/board/purple/flash.c
[...]
@@ -490,7 +489,7 @@ int flash_erase (flash_info_t *info, int s_first,
int s_last)
last = get_timer(0);
/* Start erase on unprotected sectors */
- for (sect = s_first; sect=s_last rcode == 0; sect++) {
+ for (sect = s_first; sect=s_last; sect++) {
High time to insert space before and after =...
WBR, Sergei
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/5] usb_storage.c: change progress output in debug() message
Hi Wolfgang, Turn the progress output into a debug message. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Remy Bohmer li...@bohmer.net --- common/usb_storage.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Applied. Remy, I hope this is OK with you? Fine with me. Thanks. Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/5] usb_storage.c: initialize device type
Hi, 2010/7/24 Wolfgang Denk w...@denx.de: Dear Wolfgang Denk, In message 1279532220-5848-2-git-send-email...@denx.de you wrote: The device type was left uninitialized which caused later tests against DEV_TYPE_UNKNOWN to fail. In the result, usb part would attempt to print information about non-existent devices like this: Signed-off-by: Wolfgang Denk w...@denx.de Cc: Remy Bohmer li...@bohmer.net --- common/usb_storage.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Applied. Remy, I hope this is OK with you? OK with me. Thanks. Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 22/28] SPEAr : High speed support for designware peripheral
Hi, 2010/7/14 Vipin KUMAR vipin.ku...@st.com: From: Vipin KUMAR vipin.ku...@st.com This patch adds the support for usb device high speed for designware peripheral. Signed-off-by: Vipin Kumar vipin.ku...@st.com --- drivers/usb/gadget/designware_udc.c | 13 + include/usb/designware_udc.h | 3 +++ 2 files changed, 12 insertions(+), 4 deletions(-) Acked-by: Remy Bohmer li...@bohmer.net ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 12/28] SPEAr : USB Device Controller driver support added
Hi,
2010/7/14 Vipin KUMAR vipin.ku...@st.com:
From: Vipin KUMAR vipin.ku...@st.com
The earlier usb device controller driver was specific to spear platforms. This
patch implements the usb device controller driver as a generic controller
which
can be reused by other platforms using this peripheral.
Signed-off-by: Vipin Kumar vipin.ku...@st.com
---
drivers/serial/usbtty.h | 4 +-
drivers/usb/gadget/Makefile | 2 +-
drivers/usb/gadget/{spr_udc.c = designware_udc.c} | 57
++--
include/configs/spear-common.h | 4 +-
include/usb/{spr_udc.h = designware_udc.h} | 6 +-
5 files changed, 37 insertions(+), 36 deletions(-)
rename drivers/usb/gadget/{spr_udc.c = designware_udc.c} (94%)
rename include/usb/{spr_udc.h = designware_udc.h} (98%)
Acked-by: Remy Bohmer li...@bohmer.net
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 17/28] SPEAr : USB device controller bugfixes
Hi, 2010/7/14 Vipin KUMAR vipin.ku...@st.com: From: Vipin KUMAR vipin.ku...@st.com This patch fixes a few bugs in USB device controller driver. The fixes are as follows 1. Adding error condition checks eg. NULL return 2. Endpoint other than endpoint 0 (control endpoint) are initialized only if usb state machine reaches STATE_ADDRESSED or above 3. Zero length packet handling corrected 4. Dead code removed 5. Bulk out endpoint returns after servicing 1 interrupt and returns back to service if more interrupts are pending Signed-off-by: Vipin Kumar vipin.ku...@st.com --- drivers/usb/gadget/designware_udc.c | 59 ++ 1 files changed, 38 insertions(+), 21 deletions(-) Acked-by: Remy Bohmer li...@bohmer.net ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/4 v2] musb: am35x: Workaround for fifo read issue
Hi, 2010/7/9 Ajay Kumar Gupta ajay.gu...@ti.com: AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- drivers/usb/musb/am35x.c | 32 drivers/usb/musb/musb_core.c | 6 ++ 2 files changed, 38 insertions(+), 0 deletions(-) Acked-by: Remy Bohmer li...@bohmer.net ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/4 v2] musb: MSC host support for AM35x
Hi, 2010/7/9 Ajay Kumar Gupta ajay.gu...@ti.com: Tested MSC Host on AM3517EVM. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- drivers/usb/musb/Makefile | 1 + drivers/usb/musb/am35x.c | 118 +++ drivers/usb/musb/am35x.h | 94 ++ drivers/usb/musb/musb_udc.c | 2 + include/usb.h | 2 +- 5 files changed, 216 insertions(+), 1 deletions(-) create mode 100644 drivers/usb/musb/am35x.c create mode 100644 drivers/usb/musb/am35x.h Acked-by: Remy Bohmer li...@bohmer.net ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] board/purple/flash.c: removed unneded variable
2010/8/1 Sergei Shtylyov sshtyl...@mvista.com
Hello.
Frans Meulenbroeks wrote:
removed a variable that was not used
Signed-off-by: Frans Meulenbroeks fransmeulenbro...@gmail.com
[...]
diff --git a/board/purple/flash.c b/board/purple/flash.c
index 37c7bec..5cee35e 100644
--- a/board/purple/flash.c
+++ b/board/purple/flash.c
[...]
@@ -490,7 +489,7 @@ int flash_erase (flash_info_t *info, int s_first, int
s_last)
last = get_timer(0);
/* Start erase on unprotected sectors */
- for (sect = s_first; sect=s_last rcode == 0; sect++) {
+ for (sect = s_first; sect=s_last; sect++) {
High time to insert space before and after =...
WBR, Sergei
Be my guest :-)
I happen to bump onto the variable issue and decided to fix it, but have no
binding with this board (I don't even know what kind of board it is, and I
have no desire or intention to clean this up)
BTW: if layout is deemed so important I suggest running the code through a
prettyprinter/layout program/code beautifier.
Have fun! Frans
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] gcc optimizing option cause printf() and others crash.why?
well, actually i smile too early. I have ported to version 1.1.6(using gcc3.3.2 instead !!), and the result remain the same. the board is designed by myself. when i run TI test code on IRAM or DDR,it has no problem. but uboot, crash. don't know why yet. it has past 2 weeks :( 2010/8/1 Wolfgang Denk w...@denx.de Dear yaojin liu, In message aanlktik2n941wftvxdjdci4dp9c2_hxbam909usuj...@mail.gmail.com you wrote: I have figured it out,haha!! And would you care to share your wisdom with the rest of the comunity? Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Es sind überhaupt nur die Dummköpfe, die sich den Befehlen der Mäch- tigen widersetzen. Um sie zu ruinieren ist es genug, ihre Befehle treu zu erfüllen. - Peter Hacks: Die schöne Helena ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-mpc85xx.git
The following changes since commit 7385c28e9b5f7d47e6a8f1ad9800e6e70af714e2: Wolfgang Denk (1): fs/fat: Big code cleanup. are available in the git repository at: git://git.denx.de/u-boot-mpc85xx master Kim Phillips (2): powerpc/85xx: configure autocompletion support powerpc/8xxx: query feature reporting register for num cores on unknown cpus Kumar Gala (10): powerpc/85xx: Add additional p4080 platform related defines/structs powerpc/fsl_fman: Add initial fman immap structures powerpc/p4080: Add support for CPC(Corenet platform cache) on CoreNet platforms fdt: Add function to alloc phandle values powerpc/85xx: Add support to initialize LIODN registers and portals powerpc/p4080: Add support for initializing SERDES powerpc/p4080: Add workaround for errata SERDES8 powerpc/p4080: Add workaround for erratum CPU22 powerpc/8xxx: Enabled hwconfig for memory interleaving powerpc/p4080: Add support for the P4080DS board york (8): powerpc/85xx: Move INIT_RAM_ADDR physical address to 36-bit space powerpc/p2020: Move INIT_RAM_ADDR physical address higher for 36-bit for P2020DS powerpc/8xxx: Fix bug in memctrl interleaving bank interleaving on cs0~cs4 powerpc/8xxx: Enable quad-rank DIMMs. powerpc/8xxx: Enabled address hashing for 85xx powerpc/8xxx: Enable DDR3 RDIMM support powerpc/8xxx: Improvement to DDR parameters powerpc/p2020ds: Integrated with P2020DS DDR change and enabled hwconfig MAKEALL|1 + Makefile |1 + arch/powerpc/cpu/mpc85xx/Makefile |8 + arch/powerpc/cpu/mpc85xx/cmd_errata.c |6 + arch/powerpc/cpu/mpc85xx/cpu_init.c| 52 ++- arch/powerpc/cpu/mpc85xx/ddr-gen3.c|2 + arch/powerpc/cpu/mpc85xx/fdt.c | 39 ++ arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c | 495 ++ arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.h | 44 ++ arch/powerpc/cpu/mpc85xx/liodn.c | 187 ++ arch/powerpc/cpu/mpc85xx/p4080_ids.c | 115 arch/powerpc/cpu/mpc85xx/p4080_serdes.c| 98 +++ arch/powerpc/cpu/mpc85xx/portals.c | 238 +++ arch/powerpc/cpu/mpc85xx/release.S |6 + arch/powerpc/cpu/mpc85xx/start.S | 10 + arch/powerpc/cpu/mpc8xxx/cpu.c | 10 +- .../powerpc/cpu/mpc8xxx/ddr/common_timing_params.h |3 + arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c | 264 +--- arch/powerpc/cpu/mpc8xxx/ddr/ddr.h |1 + arch/powerpc/cpu/mpc8xxx/ddr/ddr3_dimm_params.c|6 +- .../cpu/mpc8xxx/ddr/lc_common_dimm_params.c| 30 +- arch/powerpc/cpu/mpc8xxx/ddr/main.c| 40 +- arch/powerpc/cpu/mpc8xxx/ddr/options.c | 154 - arch/powerpc/include/asm/fsl_ddr_dimm_params.h |3 + arch/powerpc/include/asm/fsl_ddr_sdram.h |3 + arch/powerpc/include/asm/fsl_fman.h| 212 ++ arch/powerpc/include/asm/fsl_law.h |3 +- arch/powerpc/include/asm/fsl_liodn.h | 142 arch/powerpc/include/asm/fsl_portals.h | 59 ++ arch/powerpc/include/asm/fsl_serdes.h | 11 +- arch/powerpc/include/asm/immap_85xx.h | 219 ++- arch/powerpc/include/asm/processor.h |1 + board/freescale/common/Makefile|1 + board/freescale/corenet_ds/Makefile| 55 ++ board/freescale/corenet_ds/config.mk | 30 + board/freescale/corenet_ds/corenet_ds.c| 259 board/freescale/corenet_ds/ddr.c | 176 + board/freescale/corenet_ds/law.c | 40 ++ board/freescale/corenet_ds/pci.c | 127 board/freescale/corenet_ds/tlb.c | 112 board/freescale/mpc8641hpcn/mpc8641hpcn.c |2 + board/freescale/p2020ds/ddr.c | 56 +- board/freescale/p2020ds/p2020ds.c |7 +- board/freescale/p2020ds/tlb.c |8 +- boards.cfg |1 + common/fdt_support.c | 18 + doc/README.fsl-ddr | 39 +- include/configs/MPC8536DS.h|1 + include/configs/MPC8540ADS.h |3 +- include/configs/MPC8541CDS.h |3 +- include/configs/MPC8544DS.h|3 +- include/configs/MPC8548CDS.h |3 +- include/configs/MPC8555CDS.h |3 +- include/configs/MPC8560ADS.h |3 +- include/configs/MPC8568MDS.h |3 +-
Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support
-Original Message- From: Albert ARIBAUD [mailto:albert.arib...@free.fr] Sent: Friday, July 23, 2010 4:21 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support ...snip... Secondly I tried to generate similar patches for Kirkwood oneprd_base (attached) on the top of this patch series But somehow ide reset is unable to detect device on port. If you have openrd_base board, can you pls give a try? May be you may need to look at mpp config. I have an OpenRD Client, not base; client has a SATA connector to which I have a disk connected, so I could give it a try but we'll need to make sur how many SATA ports kirkwood has and which ones are used on either openrd client and base (orion5x has two sata ports and edmini uses port 1, not 0, for its sole SATA conector). I am away from home right now, but I will be able to give it a try as soon as August 1st. Hi Albert Ping ...if you are back Pls include my email address in your white list, the mails to you bounces back to me. Regards.. Prafulla . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support
Hi Prafulla et al., Le 01/08/2010 18:48, Prafulla Wadaskar a écrit : -Original Message- From: Albert ARIBAUD [mailto:albert.arib...@free.fr] Sent: Friday, July 23, 2010 4:21 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support ...snip... Secondly I tried to generate similar patches for Kirkwood oneprd_base (attached) on the top of this patch series But somehow ide reset is unable to detect device on port. If you have openrd_base board, can you pls give a try? May be you may need to look at mpp config. I have an OpenRD Client, not base; client has a SATA connector to which I have a disk connected, so I could give it a try but we'll need to make sur how many SATA ports kirkwood has and which ones are used on either openrd client and base (orion5x has two sata ports and edmini uses port 1, not 0, for its sole SATA conector). I am away from home right now, but I will be able to give it a try as soon as August 1st. Hi Albert Ping ...if you are back I am, and I have done some work on your problem, but for the moment I am still at the same stage as you -- a continuous sequence of dots when doing an ide reset, right? I have #define'd DEBUG in cmd_ide.c and compared the debug messages for my ED Mini V2 (working) and my OpenRD-Client (not working). I have also performed manual SATA and IDE reset sequences. Short story: 1) the board code correctly initializes the SATA link, which correctly detects a disk if there is one: Marvell md.l f1082300 4 f1082300: 0113 1401 0300 010300b0 Marvell md.l f1084300 4 f1084300: 0300 010300b0 Marvell (this is consistent with my system which has a 1.5 GBps disk on port 0). 2) The problem is that the drive appears continuously non-RDY (SStatus register remains at 0x80 while on the ED Mini V2 it ends up at 0x50, which basically means it is ready). I will now compare the MPP / GPIO settings performed by the FLASH-resident U-Boot (its 'ide reset' command works ok) to those in effect when the patched u-boot fails. Maybe one GPIO controls power to the internal SATA port, although I doubt it -- if the drive was off, the controller would not see it at all, and SStatus at F1082300 would not report it present. Pls include my email address in your white list, the mails to you bounces back to me. It's not an issue of (not) whitelisting your e-mail address; it's your mail server being blacklisted by my email provider. If you have a recent non-delivery report please send it to me in private to my gmail account (albert.arib...@gmail.com), I'll try to sort things out and contact your mail server's admin with the relevant details. Regards.. Prafulla . . Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support
-Original Message- From: Albert ARIBAUD [mailto:albert.arib...@free.fr] Sent: Sunday, August 01, 2010 11:05 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support Hi Prafulla et al., Le 01/08/2010 18:48, Prafulla Wadaskar a écrit : -Original Message- From: Albert ARIBAUD [mailto:albert.arib...@free.fr] Sent: Friday, July 23, 2010 4:21 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support ...snip... Secondly I tried to generate similar patches for Kirkwood oneprd_base (attached) on the top of this patch series But somehow ide reset is unable to detect device on port. If you have openrd_base board, can you pls give a try? May be you may need to look at mpp config. I have an OpenRD Client, not base; client has a SATA connector to which I have a disk connected, so I could give it a try but we'll need to make sur how many SATA ports kirkwood has and which ones are used on either openrd client and base (orion5x has two sata ports and edmini uses port 1, not 0, for its sole SATA conector). I am away from home right now, but I will be able to give it a try as soon as August 1st. Hi Albert Ping ...if you are back I am, and I have done some work on your problem, but for the moment I am still at the same stage as you -- a continuous sequence of dots when doing an ide reset, right? Right.. I have #define'd DEBUG in cmd_ide.c and compared the debug messages for my ED Mini V2 (working) and my OpenRD-Client (not working). I have also performed manual SATA and IDE reset sequences. Short story: 1) the board code correctly initializes the SATA link, which correctly detects a disk if there is one: Marvell md.l f1082300 4 f1082300: 0113 1401 0300 010300b0 Marvell md.l f1084300 4 f1084300: 0300 010300b0 Marvell (this is consistent with my system which has a 1.5 GBps disk on port 0). 2) The problem is that the drive appears continuously non-RDY (SStatus register remains at 0x80 while on the ED Mini V2 it ends up at 0x50, which basically means it is ready). I will now compare the MPP / GPIO settings performed by the FLASH-resident U-Boot (its 'ide reset' command works ok) to those in effect when the patched u-boot fails. Maybe one GPIO controls power to the internal SATA port, although I doubt it -- if the drive was off, the controller would not see it at all, and SStatus at F1082300 would not report it present. I tried tweaking MPP setup for SATA related stuff, it's multiplexed with UART and other I/Os (NAND), What I observed: if I boot kernel with sata support, kernel sata driver works properly and I can detect and use IDE devices. So I doubt MPP, I don't know kernel (latest stable) overrides MPP settings done by u-boot?? We can get some reference from there. Pls include my email address in your white list, the mails to you bounces back to me. It's not an issue of (not) whitelisting your e-mail address; it's your mail server being blacklisted by my email provider. If you have a recent non-delivery report please send it to me in private to my gmail account (albert.arib...@gmail.com), I'll try to sort things out and contact your mail server's admin with the relevant details. I will post you log seperately Regards.. Prafulla . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/4 v2] musb: MSC host support for AM35x
Hi, 2010/7/9 Ajay Kumar Gupta ajay.gu...@ti.com: Tested MSC Host on AM3517EVM. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- drivers/usb/musb/Makefile | 1 + drivers/usb/musb/am35x.c | 118 +++ drivers/usb/musb/am35x.h | 94 ++ drivers/usb/musb/musb_udc.c | 2 + include/usb.h | 2 +- 5 files changed, 216 insertions(+), 1 deletions(-) create mode 100644 drivers/usb/musb/am35x.c create mode 100644 drivers/usb/musb/am35x.h Acked-by: Remy Bohmer li...@bohmer.net Remy, Please merge the patch set supporting AM3517 musb in your uboot-usb tree. Regards, Ajay ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
