Re: [U-Boot] [PATCH 2/7] Expand POST memory test to support arch-depended implementation.
Dear York Sun, In message <1282944356-4020-2-git-send-email-york...@freescale.com> you wrote: > Add progress indicator for slow test. It is useful when the testing > takes too longer to finish. The indicator is reused from flash > programming. > > Hwconfig is used to turn on slow test when not enabled by flag. NAK. POST is supposed to be an automatic, unmonitored functionality. Results are suposed to be reported through a mechanism compatible to Linux' syslog system. There is no place for progress indicators here. Please note that your subject "support arch-depended implementation" and the commit message "Add progress indicator" are seriously out of sync as well. Another reason for a NAK. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Voodoo Programming: Things programmers do that they know shouldn't work but they try anyway, and which sometimes actually work, such as recompiling everything. - Karl Lehenbauer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Why does logo_plot() not use video_display_bitmap()?
Dear Timur Tabi, In message <4c7832b3.8020...@freescale.com> you wrote: > logo_plot() has its own code for rendering a bitmap, but this code is much > less capable than video_display_bitmap(). Why doesn't logo_plot() just call > video_display_bitmap() to draw the actual bitmap? Because logo_plot() predates video_display_bitmap(), and the implementors of the latter function did not bother to clean up existing code? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How many Unix hacks does it take to change a light bulb? Let's see, can you use a shell script for that or does it need a C program? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/7] Enable POST memory test for corenet_ds
Dear York Sun, In message <1282944356-4020-5-git-send-email-york...@freescale.com> you wrote: > Signed-off-by: York Sun > --- > include/configs/corenet_ds.h |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/configs/corenet_ds.h b/include/configs/corenet_ds.h > index cf316e0..627f851 100644 > --- a/include/configs/corenet_ds.h > +++ b/include/configs/corenet_ds.h > @@ -87,6 +87,7 @@ > #define CONFIG_SYS_NUM_ADDR_MAP 64 /* number of TLB1 > entries */ > #endif > > +#define CONFIG_POST CONFIG_SYS_POST_MEMORY /* test POST memory test */ > #define CONFIG_SYS_MEMTEST_START 0x0020 /* memtest works on */ > #define CONFIG_SYS_MEMTEST_END 0x0040 > #define CONFIG_SYS_ALT_MEMTEST > @@ -272,6 +273,7 @@ > > #define CONFIG_SYS_GBL_DATA_SIZE 128 /* num bytes initial data */ > #define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_END - > CONFIG_SYS_GBL_DATA_SIZE) > +#define CONFIG_SYS_POST_WORD_ADDR(CONFIG_SYS_MPC85xx_PIC_ADDR + > offsetof(ccsr_pic_t, tfrr)) The previous patch suggested that you were "Using PIC TFRR register for post word load/store for generic" - then no such define should be needed for any 85xx board. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de That Microsoft, the Trabant of the operating system world, may be glancing over the Berlin Wall at the Audis and BMWs and Mercedes. In their own universe Trabants and Ladas were mainstream too... -- Evan Leibovitch ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 7/8] APM82xxx: Add bluestone board support
Dear Feng Kan, In message you wrote: > Our legal is out at the moment. Why is this an issue, since it is > on many of the files in U-Boot. Our legal indicated without the > statement the Copyright would not stand. Please tell your legal to get a clue. Fact is, that any files where a "All rights reserved." is found have zero chance to go into mainline. [And any existing files with such notes are already on the kill list.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de KLB is an acronym for `Known Lazy Bastard', aka non-FAQ reader, aka person who would rather make someone take their time to explain something basic than look it up in a FAQ. -- Tom Christiansen in <6aq547$mn...@csnews.cs.colorado.edu> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/7] Enabled POST for generic mpc85xx
Dear York Sun, In message <1282944356-4020-4-git-send-email-york...@freescale.com> you wrote: > Using PIC TFRR register for post word load/store for generic. > Fix post_word_store, post_word_load offset for mpc85xx with cpm Subject and commit messsage don't match. Please fix. Probably you want to split this into two commits. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de PUBLIC NOTICE AS REQUIRED BY LAW: Any Use of This Product, in Any Manner Whatsoever, Will Increase the Amount of Disorder in the Universe. Although No Liability Is Implied Herein, the Consumer Is Warned That This Process Will Ultimately Lead to the Heat Death of the Universe. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/8] APM82xxx: Add Common register definitions
Dear tma...@apm.com, In message <1282856749-24425-1-git-send-email-tma...@apm.com> you wrote: > From: Tirumala Marri > > This patch adds APM82XXX specific definitions, which include > clock and boot strap. > > Signed-off-by: Tirumala R Marri > --- > include/ppc440.h | 57 - > include/ppc4xx.h |7 +++-- > 2 files changed, 59 insertions(+), 5 deletions(-) It makes no sense to split this into a spearate patch. Please squash into the commit where these defines are first referenced. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How does a project get to be a year late? ... One day at a time. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes
Dear tma...@apm.com, In message <1282856780-24660-1-git-send-email-tma...@apm.com> you wrote: > From: Tirumala Marri > > Add bluestone board name to the board.cfg. NAK. This must not ne a separate commit. > Change Makefile to include bluestone board support. NAK. This is not needed and not allowed any more. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Prof:So the American government went to IBM to come up with a data encryption standard and they came up with ... Student: EBCDIC! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/8] APM82xxx: Add DDR support
Dear tma...@apm.com, In message <1282856759-24503-1-git-send-email-tma...@apm.com> you wrote: > From: Tirumala Marri > > This patch adds 32bit DDR2 static as well as dynamic > setting of different DRAM parameters like CAS and read/write > delays. > > Signed-off-by: Tirumala R Marri > --- > arch/powerpc/include/asm/ppc4xx-sdram.h | 25 +++-- > 1 files changed, 19 insertions(+), 6 deletions(-) This is not a separate, independent commit either. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Killing is wrong. -- Losira, "That Which Survives", stardate unknown ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support
Dear tma...@apm.com, In message <1282856765-24544-1-git-send-email-tma...@apm.com> you wrote: > From: Tirumala Marri > > This patch adds Universal Interrupt Controller support for > APM82XXX processor. Again. This is NOT a separate, independent commit. Please reread the documentation andfix your patch splitting. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Vulcans never bluff. -- Spock, "The Doomsday Machine", stardate 4202.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 7/8] APM82xxx: Add bluestone board support
Dear tma...@apm.com, In message <1282856775-24619-1-git-send-email-tma...@apm.com> you wrote: > From: Tirumala Marri > > Add support code for bluestone board wth APM82XXX processor based. > This patch includes early board init, misc init, configure EBC, > and initializes UIC. > > Signed-off-by: Tirumala R Marri > --- > arch/powerpc/include/asm/ppc4xx-ebc.h |4 + > board/amcc/bluestone/Makefile | 52 > board/amcc/bluestone/bluestone.c | 213 > board/amcc/bluestone/config.mk| 40 ++ > board/amcc/bluestone/init.S | 55 > include/configs/bluestone.h | 218 > + > 6 files changed, 582 insertions(+), 0 deletions(-) Entry to boards.cfg, MAINTAINERS and MAKEALL missing. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Do not follow where the path may leadgo instead where there is no path and leave a trail. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] at91_emac.h: fix typo in register definition
Signed-off-by: Andreas Bießmann
---
arch/arm/include/asm/arch-at91/at91_emac.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/include/asm/arch-at91/at91_emac.h
b/arch/arm/include/asm/arch-at91/at91_emac.h
index 45ae333..0e2ff78 100644
--- a/arch/arm/include/asm/arch-at91/at91_emac.h
+++ b/arch/arm/include/asm/arch-at91/at91_emac.h
@@ -61,7 +61,7 @@ typedef struct at91_emac {
u32 reserved2[3];
u32 hsh;
u32 hsl;
- u32 sh1l;
+ u32 sa1l;
u32 sa1h;
u32 sa2l;
u32 sa2h;
--
1.7.2.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Why does logo_plot() not use video_display_bitmap()?
On Sun, Aug 29, 2010 at 3:56 AM, Wolfgang Denk wrote: > Because logo_plot() predates video_display_bitmap(), and the > implementors of the latter function did not bother to clean up > existing code? Ok, I just wanted to make sure there wasn't some technical limitations I didn't notice. I'll look into merging the two functions together. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC][PATCH] mkimage: Add compatibility option for legacy Multi-File images
Hi! Do you want to apply the patch that Thibaut Girka posted earlier in mainline U-Boot? [0] We need it for Debian Installer when we make images for the Neo FreeRunner. The patch is useful for use with devices that use broken U-Boot versions. [0] http://lists.denx.de/pipermail/u-boot/2010-August/075823.html Best, Per ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/7] Expand POST memory test to support arch-depended implementation.
Wolfgang, Without progress indicator, slowe test on memory takes minutes and it looks like hanging. You probably don't want to run it every time the board boots up. York Sun - Original Message - From:"Wolfgang Denk" To:"York Sun" Cc:"u-boot@lists.denx.de" Sent:8/29/2010 3:56 AM Subject:Re: [U-Boot] [PATCH 2/7] Expand POST memory test to support arch-depended implementation. Dear York Sun, In message <1282944356-4020-2-git-send-email-york...@freescale.com> you wrote: > Add progress indicator for slow test. It is useful when the testing > takes too longer to finish. The indicator is reused from flash > programming. > > Hwconfig is used to turn on slow test when not enabled by flag. NAK. POST is supposed to be an automatic, unmonitored functionality. Results are suposed to be reported through a mechanism compatible to Linux' syslog system. There is no place for progress indicators here. Please note that your subject "support arch-depended implementation" and the commit message "Add progress indicator" are seriously out of sync as well. Another reason for a NAK. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Voodoo Programming: Things programmers do that they know shouldn't work but they try anyway, and which sometimes actually work, such as recompiling everything. - Karl Lehenbauer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] TFTP timeout issue while downloading the linux kernel in openpxa vpac270 u-boot source code
-Original Message- From: Marek Vasut [mailto:marek.va...@gmail.com] Sent: Friday, August 27, 2010 3:00 PM To: StephenPaulraj Chinnadurai-ERS,HCLTech Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] TFTP timeout issue while downloading the linux kernel in openpxa vpac270 u-boot source code Dne Pá 27. srpna 2010 10:52:45 StephenPaulraj Chinnadurai-ERS,HCLTech napsal(a): > -Original Message- > From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On > Behalf Of Marek Vasut Sent: Thursday, August 26, 2010 9:00 PM > To: StephenPaulraj Chinnadurai-ERS,HCLTech > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] TFTP timeout issue while downloading the linux kernel > in openpxa vpac270 u-boot source code > > Dne Čt 26. srpna 2010 17:06:08 StephenPaulraj Chinnadurai-ERS,HCLTech napsal(a): > > -Original Message- > > From: Marek Vasut [mailto:marek.va...@gmail.com] > > Sent: Thursday, August 26, 2010 5:56 PM > > To: StephenPaulraj Chinnadurai-ERS,HCLTech > > Cc: u-boot@lists.denx.de; Wolfgang Denk > > Subject: Re: [U-Boot] TFTP timeout issue while downloading the linux > > kernel in openpxa vpac270 u-boot source code > > > > Dne St 25. srpna 2010 11:03:30 StephenPaulraj Chinnadurai-ERS,HCLTech > > napsal(a): > > > Hello Marek, > > > > > > I increased the memory clock speed from 104 MHz to 208 MHz in the > > > PXA270 controller by including the following lines of in the .macro > > > pxa_clock_setup (macro.h file) > > > > > > ldr r0, =0x8 > > > mcr p14, 0, r0, c6, c0, 0 > > > > > > After increasing the memory clock speed, I can download the zImage > > > (2.8MB) through tftp without any timeout. > > > > Your memory seems misconfigured. Can you run "mtest" on it ? > > > > I executed the mtest command and waited for an hour, u-boot doesn't > > displayed any error. > > > > The memory start and end address is defined as follow in the > > include/configs/myboard.h file. > > > > #define CONFIG_SYS_MEMTEST_START0xa040 /* memtest works > > on */ #define CONFIG_SYS_MEMTEST_END 0xa080 /* 4 ... 8 > > MB in DRAM */ > > > > #define CONFIG_SYS_LOAD_ADDR(0xa100) > > > > Pattern 04BF Writing...Reading... > > Pattern FB40 Writing...Reading... > > Pattern 04C0 Writing...Reading... > > Pattern FB3F Writing...Reading... > > Pattern 04C1 Writing...Reading... > > Test some bigger area then ... at best the one where you're downloading the > image. > > I changed the board/myboard/config.mk to load the u-boot at the 0xa7F0 > location in the SDRAM. The environment variable is placed at the > 0xa7e0 loation. > > Memory test with: > 1. start address a000 & end address a3ff is successful. > 2. start address a400 & end address a7df is successful. > 3. start address a350 & end address a500 is successful. > > But the memory test with start address a000 and end address a500 > misbehaved. Check my observation 4: (mtest a000 a500 a55aa55a 3) > > The giving pattern (a55aa55a) is written only once into the memory but the > u-boot read the pattern from the memory 3 times (iteration count). The > write loop is not executed. I don't know the reason. I executed the (mtest > a000 a500 a55aa55a 3) command several times and every time the > write loop is not executed and the mtest result also not displayed. > > Kindly find the memory test observation below: > Observation 1: > MDT-Boot> mtest a000 a3ff a5a55a5a 5 > > Pattern A5A55A5A Writing...Reading... > Pattern 5A5AA5A6 Writing...Reading... > Pattern A5A55A59 Writing...Reading... > Pattern 5A5AA5A7 Writing...Reading... > Pattern A5A55A58 Writing...Reading...Tested 5 > iteration(s) with 0 errors. > > Observation 2: > MDT-Boot> mtest a400 a7df a5a5a5a5 3 > > Pattern A5A5A5A5 Writing...Reading... > Pattern 5A5A5A5B Writing...Reading... > Pattern A5A5A5A4 Writing...Reading...Tested 3 > iteration(s) with 0 errors. > > Observation 3: > MDT-Boot> mtest a350 a500 a5a55a5a 3 > > Pattern A5A55A5A Writing...Reading... > Pattern 5A5AA5A6 Writing...Reading... > Pattern A5A55A59 Writing...Reading...Tested 3 > iteration(s) with 0 errors. > > Observation 4: > MDT-Boot> mtest a000 a500 a55aa55a 3 > > Pattern A55AA55A Writing... > Reading...Reading...Reading...MDT-Boot> Just run ... mtest 0xa000 0xa700 and see if it screams. If it does, your memory's misconfigured. (I assume you have at least 0x0800 bytes of RAM and uboot is loaded past 0xa700). Executed the mtest axa000 0xa700, the memory test is successful,
Re: [U-Boot] TFTP timeout issue while downloading the linux kernel in openpxa vpac270 u-boot source code
Dne Ne 29. srpna 2010 16:28:45 StephenPaulraj Chinnadurai-ERS,HCLTech napsal(a): > -Original Message- > From: Marek Vasut [mailto:marek.va...@gmail.com] > Sent: Friday, August 27, 2010 3:00 PM > To: StephenPaulraj Chinnadurai-ERS,HCLTech > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] TFTP timeout issue while downloading the linux kernel > in openpxa vpac270 u-boot source code > > Dne Pá 27. srpna 2010 10:52:45 StephenPaulraj Chinnadurai-ERS,HCLTech napsal(a): > > -Original Message- > > From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] > > On Behalf Of Marek Vasut Sent: Thursday, August 26, 2010 9:00 PM > > To: StephenPaulraj Chinnadurai-ERS,HCLTech > > Cc: u-boot@lists.denx.de > > Subject: Re: [U-Boot] TFTP timeout issue while downloading the linux > > kernel in openpxa vpac270 u-boot source code > > > > Dne Čt 26. srpna 2010 17:06:08 StephenPaulraj Chinnadurai-ERS,HCLTech > > napsal(a): > > > -Original Message- > > > From: Marek Vasut [mailto:marek.va...@gmail.com] > > > Sent: Thursday, August 26, 2010 5:56 PM > > > To: StephenPaulraj Chinnadurai-ERS,HCLTech > > > Cc: u-boot@lists.denx.de; Wolfgang Denk > > > Subject: Re: [U-Boot] TFTP timeout issue while downloading the linux > > > kernel in openpxa vpac270 u-boot source code > > > > > > Dne St 25. srpna 2010 11:03:30 StephenPaulraj Chinnadurai-ERS,HCLTech > > > > napsal(a): > > > > Hello Marek, > > > > > > > > I increased the memory clock speed from 104 MHz to 208 MHz in the > > > > PXA270 controller by including the following lines of in the .macro > > > > pxa_clock_setup (macro.h file) > > > > > > > > ldr r0, =0x8 > > > > mcr p14, 0, r0, c6, c0, 0 > > > > > > > > After increasing the memory clock speed, I can download the zImage > > > > (2.8MB) through tftp without any timeout. > > > > > > Your memory seems misconfigured. Can you run "mtest" on it ? > > > > > > I executed the mtest command and waited for an hour, u-boot doesn't > > > displayed any error. > > > > > > The memory start and end address is defined as follow in the > > > include/configs/myboard.h file. > > > > > > #define CONFIG_SYS_MEMTEST_START0xa040 /* memtest > > > works on */ #define CONFIG_SYS_MEMTEST_END 0xa080 /* > > > 4 ... 8 MB in DRAM */ > > > > > > #define CONFIG_SYS_LOAD_ADDR(0xa100) > > > > > > Pattern 04BF Writing...Reading... > > > Pattern FB40 Writing...Reading... > > > Pattern 04C0 Writing...Reading... > > > Pattern FB3F Writing...Reading... > > > Pattern 04C1 Writing...Reading... > > > > Test some bigger area then ... at best the one where you're downloading > > the image. > > > > I changed the board/myboard/config.mk to load the u-boot at the > > 0xa7F0 location in the SDRAM. The environment variable is placed at > > the 0xa7e0 loation. > > > > Memory test with: > > 1. start address a000 & end address a3ff is successful. > > 2. start address a400 & end address a7df is successful. > > 3. start address a350 & end address a500 is successful. > > > > But the memory test with start address a000 and end address a500 > > misbehaved. Check my observation 4: (mtest a000 a500 a55aa55a 3) > > > > The giving pattern (a55aa55a) is written only once into the memory but > > the u-boot read the pattern from the memory 3 times (iteration count). > > The write loop is not executed. I don't know the reason. I executed the > > (mtest a000 a500 a55aa55a 3) command several times and every > > time the write loop is not executed and the mtest result also not > > displayed. > > > > Kindly find the memory test observation below: > > Observation 1: > > MDT-Boot> mtest a000 a3ff a5a55a5a 5 > > > > Pattern A5A55A5A Writing...Reading... > > Pattern 5A5AA5A6 Writing...Reading... > > Pattern A5A55A59 Writing...Reading... > > Pattern 5A5AA5A7 Writing...Reading... > > Pattern A5A55A58 Writing...Reading...Tested 5 > > iteration(s) with 0 errors. > > > > Observation 2: > > MDT-Boot> mtest a400 a7df a5a5a5a5 3 > > > > Pattern A5A5A5A5 Writing...Reading... > > Pattern 5A5A5A5B Writing...Reading... > > Pattern A5A5A5A4 Writing...Reading...Tested 3 > > iteration(s) with 0 errors. > > > > Observation 3: > > MDT-Boot> mtest a350 a500 a5a55a5a 3 > > > > Pattern A5A55A5A Writing...Reading... > > Pattern 5A5AA5A6 Writing...Reading... > > Pattern A5A55A59 Writing...Reading...Tested 3 > > iteration(s) with 0 errors. > > > > Observation 4: > > MDT-Boot> mtest a000 a500 a55aa55a 3 > > > > Pattern A55
Re: [U-Boot] [PATCH 3/7] Add memory test feature for mpc85xx POST.
Dear York Sun,
In message <1282944356-4020-3-git-send-email-york...@freescale.com> you wrote:
> If enabled in config file and hwconfig, the memory test is performed
POST memory testing is not controlled through hwconfig, but through
it's own set of environment variable settings. Please don't mix
these.
NAK for the current implementation.
> after DDR initialization when U-boot stills runs in flash and cache.
> Whole memory is testable. It is mapped 2GB at a time using a sliding
> TLB window. After the testing, DDR is remapped with up to 2GB memory
> from the lowest address as normal.
>
> Memory testing has different patterns which may be improved later.
What does that mean?
> If memory test fails, DDR DIMM SPD and DDR controller registers are
> dumped. All zero values are omitted for better viewing.
Do yoxpu consider this a good idea? I don't.
> A worker function __setup_ddr_tlbs() is introduced to implement more
> control on physical address mapping.
>
> Signed-off-by: York Sun
> ---
> arch/powerpc/cpu/mpc85xx/cpu.c | 195
>
> arch/powerpc/cpu/mpc85xx/tlb.c | 16 ++--
> doc/README.fsl-ddr | 21 -
> 3 files changed, 225 insertions(+), 7 deletions(-)
Should the code not live in the post/ directory?
> diff --git a/arch/powerpc/cpu/mpc85xx/cpu.c b/arch/powerpc/cpu/mpc85xx/cpu.c
> index 00696f8..634a0cd 100644
> --- a/arch/powerpc/cpu/mpc85xx/cpu.c
> +++ b/arch/powerpc/cpu/mpc85xx/cpu.c
> @@ -34,6 +34,9 @@
> #include
> #include
> #include
> +#include
> +#include
> +#include
>
> DECLARE_GLOBAL_DATA_PTR;
>
> @@ -282,3 +285,195 @@ void mpc85xx_reginfo(void)
> print_laws();
> print_lbc_regs();
> }
> +
> +#if CONFIG_POST & CONFIG_SYS_POST_MEMORY
> +
> +/* Board-specific functions defined in each board's ddr.c */
> +void fsl_ddr_get_spd(generic_spd_eeprom_t *ctrl_dimms_spd,
> + unsigned int ctrl_num);
> +void read_tlbcam_entry(int idx, u32 *valid, u32 *tsize, unsigned long *epn,
> +phys_addr_t *rpn);
> +unsigned int __setup_ddr_tlbs(phys_addr_t p_addr, unsigned int
> memsize_in_meg);
> +
> +static void dump_spd_ddr_reg(void)
> +{
> + int i, j, k, m;
> + u8 *p_8;
> + u32 *p_32;
> + ccsr_ddr_t *ddr[CONFIG_NUM_DDR_CONTROLLERS];
> + generic_spd_eeprom_t
> +spd[CONFIG_NUM_DDR_CONTROLLERS][CONFIG_DIMM_SLOTS_PER_CTLR];
Indentation by TABs only, please.
Blank line between declarations and code.
> + for (i = 0; i < CONFIG_NUM_DDR_CONTROLLERS; i++)
> + fsl_ddr_get_spd(spd[i], i);
Blank line here, too.
> + puts("SPD data of all dimms (zero vaule is omitted)...\n");
> + puts("Byte (hex) ");
> + k = 1;
> + for (i = 0; i < CONFIG_NUM_DDR_CONTROLLERS; i++)
> + for (j = 0; j < CONFIG_DIMM_SLOTS_PER_CTLR; j++)
> + printf("Dimm%d ", k++);
Need braces for multiline statements.
> + In order to enable the POST memory test, CONFIG_POST needs to be
> + defined in board configuraiton header file. By default, POST memory test
> performs
> + a fast test. A slow test can be enabled by changing the flag, or hwconfig
> can
> + be used to active slow test. To test memory bigger than 2GB, 36BIT
> support is
NAK. We provide exactly one way to control the POST system. hwconfig
has nothing to do with that, so please don't pull that in here.
> -hwconfig=fsl_ddr:addr_hash=true,ctlr_intlv=cacheline,bank_intlv=cs0_cs1_cs2_cs3
> +hwconfig=fsl_ddr:addr_hash=true,ctlr_intlv=cacheline,bank_intlv=cs0_cs1_cs2_cs3,;memtest=slow
NAK.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Software suppliers are trying to make their software packages more
``user-friendly''. . . . Their best approach, so far, has been to
take all the old brochures, and stamp the words, ``user-friendly'' on
the cover. - Bill Gates
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] android fastboot support on U-boot
hi, Now I working on porting android fastboot protocol to U-boot,does somebody add fastboot protocol patches to U-boot? shulin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARMV7: S5P: separate the peripheral clocks
On 24 August 2010 16:51, Minkyu Kang wrote: > Because of peripheral devices can select clock sources, > separate the peripheral clocks. (pwm, uart and so on) > It just return the pclk at s5pc1xx SoC, > but s5pc210 SoC must be calculated by own clock register setting. > > Signed-off-by: Minkyu Kang > Signed-off-by: Kyungmin Park > --- > arch/arm/cpu/armv7/s5p-common/timer.c | 4 ++-- > arch/arm/cpu/armv7/s5pc1xx/clock.c | 25 ++--- > arch/arm/include/asm/arch-s5pc1xx/clk.h | 3 ++- > drivers/serial/serial_s5p.c | 4 ++-- > 4 files changed, 28 insertions(+), 8 deletions(-) > applied to u-boot-samsung -- from. prom. www.promsoft.net ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARMV7: S5P: rename the member of gpio structure
On 25 August 2010 14:05, Minkyu Kang wrote: > Typically we declare the name of gpio structure to "gpio", > so it was duplicated around the name. (e.g: gpio->gpio_a) > This patch modified the naming that is removing "gpio_". > > Signed-off-by: Minkyu Kang > Signed-off-by: Kyungmin Park > --- > arch/arm/include/asm/arch-s5pc1xx/gpio.h | 172 > +++--- > board/samsung/goni/goni.c | 8 +- > board/samsung/smdkc100/smdkc100.c | 2 +- > 3 files changed, 91 insertions(+), 91 deletions(-) > applied to u-boot-samsung -- from. prom. www.promsoft.net ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V3] AT91 Fix: return value of get_tbclk
Hello Eric, On Wednesday 18 August 2010, 09:17:26 you wrote: > > Hello, > > > > Am Samstag, 7. August 2010, 19:49:42 schrieb Jens Scharsig: > > > * Fix: return value of get_tbclk > > > * this fixes issue with prematurely restart/retry, if > > > > > > BOOT_RETRY_TIMEOUT is used > > > > This issue also arises, if you use CONFIG_AUTOBOOT_KEYED & friends > > I tried both BOOT_RETRY_TIMEOUT and CONFIG_AUTOBOOT_KEYED & > CONFIG_AUTOBOOT_STOP_STR, Both work well on AT91SAM9260EK > > Which board did you tried? That's some time ago and I don't remember which u-boot version that was. I think i came across that problem on the AT91SAM9G20EK and our own SAM9G20 board. Best regards, Alexander ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] TFTP load for file over 50MB fails
Dear Marek, The thread ([U-Boot] TFTP timeout issue while downloading the linux kernel in openpxa vpac270 u-boot source code) is restarted to avoid the mess with new subject TFTP load for file over 50MB fails. Previous issue summary & Test observations: Microcontroller used in the board- PXA270 Ethernet Controller- SMCS LAN91C111Ii-NU Microcontroller & Ethernet interface - Static memory chip select 4 Speed - System Clock: 208MHz & Memory Clock: 208MHz U-boot location in SDRAM - 0xa7F0 Issue: 1. When the board is connected to network, through tftp the u-boot is downloading only 9 MB size file. When tried to download 10 MB size file, the u-boot is displaying "Retry count exceeded; starting again" message and the file download is not getting completed. 2. When the board is connected to Linux machine directly using cross cable, through tftp the u-boot is downloading 47 MB size file without any retry, but when tried to download 53 MB size file, the u-boot is displaying "Retry count exceeded; starting again" message and download is not getting completed. Tests Performed: Memory test is performed to verify whether the memory was misconfigured, but the memory test executed from the start address 0xA000 to end address 0xA700 was successful without any error. Test concludes that the problem in downloading 50MB file is not because of memory error. Thanks and Regards Stephen Paulraj C DISCLAIMER: --- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or HCL or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any mail and attachments please check them for viruses and defect. --- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
