Re: [U-Boot] Please pull u-boot-ti/master
Hi Sandeep, Le 09/09/2011 22:35, s-paul...@ti.com a écrit : > Albert, > > Stefano just sent a patch to fix an issue with the hawk board > > Regards, > Sandeep > > The following changes since commit 6c01fdfbf64958f3b9390f271897fc18c7909c5f: >Sandeep Paulraj (1): > Merge branch 'master' of git://git.denx.de/u-boot-ti > > are available in the git repository at: > >git://git.denx.de/u-boot-ti.git master > > Stefano Babic (1): >ARM: hawkboard: fix compilation of nand_spl > > nand_spl/board/davinci/da8xxevm/Makefile |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) Applied to u-boot-arm/master (by cherry-picking the commit, as u-boot-ti was not rebased on u-boot-arm/master at the time of the pull request), thanks! Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-ti/master
Le 09/09/2011 23:26, Albert ARIBAUD a écrit : > Hi Sandeep, > > Le 09/09/2011 22:35, s-paul...@ti.com a écrit : >> Albert, >> >> Stefano just sent a patch to fix an issue with the hawk board >> >> Regards, >> Sandeep >> >> The following changes since commit 6c01fdfbf64958f3b9390f271897fc18c7909c5f: >> Sandeep Paulraj (1): >> Merge branch 'master' of git://git.denx.de/u-boot-ti >> >> are available in the git repository at: >> >> git://git.denx.de/u-boot-ti.git master >> >> Stefano Babic (1): >> ARM: hawkboard: fix compilation of nand_spl >> >>nand_spl/board/davinci/da8xxevm/Makefile |6 +- >>1 files changed, 5 insertions(+), 1 deletions(-) > > Can you please rebase on u-boot-arm/master and then resubmit a pull request? Alright, as Sandeep did not respond quickly, I'll assume he isn't available right now. Since there is only one commit, I'll cherry-pick it (and then run some builds and send an ARM pull req). > Amicalement, Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Error Noticed Code 573FKx9.
Email account User Due to recent trace by our admin staff, we have noticed that different computers have logged into your email, and multiple passwords failures were present before the login. Therefore your account has been limited. Access our portal management for the restoration of auditing and management staff. Just click reply to this email immediately and enter your account details below. E-mail to confirm your identity below: Username : E-mail Username : Password : Confirm Password : Date of Birth : Password future : Note: Only restored account will not be blocked. Thank you for your cooperation. Webmail Help Desk. System Administrator ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] (no subject)
I am Mr. Wen Lee an account officer with the Bank of Taipei, I need your partnership in re-profiling funds and you will be paid 30% for your management fees; Contact me for details. (wen@permaflex.co.th) Wen Lee ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix warning: "assert" redefined
Hi Wolfgang, On Fri, Sep 9, 2011 at 3:38 PM, Wolfgang Denk wrote: > Commit 21726a7 "Add assert() for debug assertions" caused build > warnings for many systems: > > In file included from bedbug.c:6: > /home/wd/git/u-boot/work/include/bedbug/bedbug.h:24:1: warning: "assert" > redefined > In file included from bedbug.c:3: > /home/wd/git/u-boot/work/include/common.h:144:1: warning: this is the > location of the previous definition > In file included from cmd_bedbug.c:10: > /home/wd/git/u-boot/work/include/bedbug/bedbug.h:24:1: warning: "assert" > redefined > In file included from cmd_bedbug.c:5: > /home/wd/git/u-boot/work/include/common.h:144:1: warning: this is the > location of the previous definition > I was wondering about that one :-) Thank you. I also ignored ubifs since it seemed to have its own system, and one in yaffs which was commented out. If it helps: Acked-by: Simon Glass Regards, Simon > Signed-off-by: Wolfgang Denk > Cc: Simon Glass > --- > include/bedbug/bedbug.h | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/include/bedbug/bedbug.h b/include/bedbug/bedbug.h > index 471215e..0c5d687 100644 > --- a/include/bedbug/bedbug.h > +++ b/include/bedbug/bedbug.h > @@ -21,8 +21,6 @@ > #endif > #endif > > -#define assert( condition ) if( (condition) ) _exit(0) > - > #endif /* _BEDBUG_H */ > > > -- > 1.7.6 > > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] UBIFS: fix warning: format '%lX' expects type 'long unsigned int'
Commit 46d7274 "UBIFS: Change ubifsload to set the filesize variable"
introduced the follwing compiler warning:
ubifs.c: In function 'ubifs_load':
ubifs.c:742: warning: format '%lX' expects type 'long unsigned int', but
argument 3 has type 'u32'
Signed-off-by: Wolfgang Denk
Cc: Bastian Ruppert
---
fs/ubifs/ubifs.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
index 2e6313a..604eb8f 100644
--- a/fs/ubifs/ubifs.c
+++ b/fs/ubifs/ubifs.c
@@ -739,7 +739,7 @@ int ubifs_load(char *filename, u32 addr, u32 size)
if (err)
printf("Error reading file '%s'\n", filename);
else {
- sprintf(buf, "%lX", size);
+ sprintf(buf, "%X", size);
setenv("filesize", buf);
printf("Done\n");
}
--
1.7.6
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [HELP] coldfire, bss.variable offset greater than __bss_end
Hi all,
after a recent update and compiling u-boot, bootloader get locked trying to set
a global variable, just after sdram relocation.
Exactly, the program lock here:
1529 void mem_malloc_init(ulong start, ulong size)
1530 {
1531mem_malloc_start = start; <<<---program paralize here
Tracing the variable offset in memory, i have seen this variable is located a
little bit outside (higher address) of the total 16M SDRAM memory size.
Investigating further, in the map file, the issue seems to be that u-boot
assign a memory space that is:
len = (ulong)&__bss_end__ - CONFIG_SYS_MONITOR_BASE;
But from the map file the variable seems to have an offset greater than
__bss_end :
.bss.mem_malloc_start
0xffc159c80x4
.bss.mem_malloc_start
0xffc159c80x4 common/libcommon.o
0xffc159c8mem_malloc_start
.
.bss0xffc13e00 0x1544
0xffc13e00_sbss = .
*(.sbss)
*(.bss)
*(COMMON)
COMMON 0xffc13e000x4 arch/m68k/lib/libm68k.o
0xffc13e00monitor_flash_len
u-boot.lds has been checked many times, i don't see any issue on it.
I am using this compiler:
m68k-elf-gcc --version
m68k-elf-gcc (GCC) 4.2.4
Copyright (C) 2007 Free Software Foundation, Inc.
Any help is really appreciated.
regards,
angelo
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Fix warning: "assert" redefined
Commit 21726a7 "Add assert() for debug assertions" caused build warnings for many systems: In file included from bedbug.c:6: /home/wd/git/u-boot/work/include/bedbug/bedbug.h:24:1: warning: "assert" redefined In file included from bedbug.c:3: /home/wd/git/u-boot/work/include/common.h:144:1: warning: this is the location of the previous definition In file included from cmd_bedbug.c:10: /home/wd/git/u-boot/work/include/bedbug/bedbug.h:24:1: warning: "assert" redefined In file included from cmd_bedbug.c:5: /home/wd/git/u-boot/work/include/common.h:144:1: warning: this is the location of the previous definition Signed-off-by: Wolfgang Denk Cc: Simon Glass --- include/bedbug/bedbug.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/bedbug/bedbug.h b/include/bedbug/bedbug.h index 471215e..0c5d687 100644 --- a/include/bedbug/bedbug.h +++ b/include/bedbug/bedbug.h @@ -21,8 +21,6 @@ #endif #endif -#define assert( condition ) if( (condition) ) _exit(0) - #endif /* _BEDBUG_H */ -- 1.7.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] KS8695: move TIMER_ definitions before code use
Dear Greg, In message <1315570750-472-1-git-send-email-greg.unge...@opengear.com> you wrote: > Move the TIMER_ definitions before they are used in KS8695 timer.c code. > Fixes: Could you please also fix the remaining warnings: Configuring for cm4008 board... eth.c:546:2: warning: #warning Ethernet driver is deprecated. Please update to use CONFIG_NET_MULTI cm4008.c: In function 'env_flash_cmdline': cm4008.c:67: warning: pointer targets in passing argument 2 of 'setenv' differ in signedness textdata bss dec hex filename 1168402512 37480 156832 264a0 /work/wd/tmp-arm/u-boot Configuring for cm41xx board... eth.c:546:2: warning: #warning Ethernet driver is deprecated. Please update to use CONFIG_NET_MULTI cm41xx.c: In function 'env_flash_cmdline': cm41xx.c:67: warning: pointer targets in passing argument 2 of 'setenv' differ in signedness textdata bss dec hex filename 1168562512 37464 156832 264a0 /work/wd/tmp-arm/u-boot Thanks in advance. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It would be illogical to kill without reason -- Spock, "Journey to Babel", stardate 3842.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-mpc85xx
Dear Kumar Gala, In message you wrote: > The following changes since commit 49ea2e342b6b9c35623915125e4e0af734cfa594: > Wolfgang Denk (1): > Merge branch 'master' of git://git.denx.de/u-boot-mmc > > are available in the git repository at: > > git://git.denx.de/u-boot-mpc85xx master > > Zhao Chenhui (3): > powerpc/mpc8568mds: set pci1_hose.config_table after fsl_setup_hose > powerpc/mpc8548cds: set pci1_hose.config_table after fsl_setup_hose > powerpc/mpc8610hpcd: set pci1_hose.config_table after fsl_setup_hose > > board/freescale/mpc8548cds/mpc8548cds.c |6 +++--- > board/freescale/mpc8568mds/mpc8568mds.c | 11 +-- > board/freescale/mpc8610hpcd/mpc8610hpcd.c | 11 +-- > 3 files changed, 13 insertions(+), 15 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de An Ada exception is when a routine gets in trouble and says 'Beam me up, Scotty'. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] CM4000: fix broken flash base for OpenGear boards
Dear Greg Ungerer, In message <1315571014-564-1-git-send-email-greg.unge...@opengear.com> you wrote: > Use _bss_start_ofs as the size of the boot loader code+data that we want > to protect in the flash. This replaces use of the no longer defined > _armboot_start. > > Fixes: > > flash.c: In function `flash_init´: > flash.c:75: error: `_bss_start´ undeclared (first use in this function) > flash.c:75: error: (Each undeclared identifier is reported only once > flash.c:75: error: for each function it appears in.) > flash.c:75: error: `_armboot_start´ undeclared (first use in this function) > > Signed-off-by: > --- > board/cm4008/flash.c |2 +- > board/cm41xx/flash.c |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "355/113 -- Not the famous irrational number PI, but an incredible simulation!" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] CM4000: fix missing RAM definitions for OpenGear boards
Dear Greg Ungerer, In message <1315570998-528-1-git-send-email-greg.unge...@opengear.com> you wrote: > The OpenGear boards CM4008, CM4116 and CM4148 need their DRAM base > and RAM stack base addresses defined. > > Fixes: > > board.c: In function `__dram_init_banksize´: > board.c:227: error: `CONFIG_SYS_SDRAM_BASE´ undeclared (first use in this > function) > board.c:227: error: (Each undeclared identifier is reported only once > board.c:227: error: for each function it appears in.) > board.c: In function `board_init_f´: > board.c:270: error: `CONFIG_SYS_INIT_SP_ADDR´ undeclared (first use in this > function) > board.c:303: error: `CONFIG_SYS_SDRAM_BASE´ undeclared (first use in this > function) > > Signed-off-by: Greg Ungerer > --- > include/configs/cm4008.h |3 +++ > include/configs/cm41xx.h |3 +++ > 2 files changed, 6 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de HANDLE WITH EXTREME CARE: This Product Contains Minute Electrically Charged Particles Moving at Velocities in Excess of Five Hundred Million Miles Per Hour. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] KS8695: move TIMER_ definitions before code use
Dear Greg Ungerer, In message <1315570750-472-1-git-send-email-greg.unge...@opengear.com> you wrote: > Move the TIMER_ definitions before they are used in KS8695 timer.c code. > Fixes: > > timer.c: In function `timer_init´: > timer.c:37: error: `TIMER_COUNT´ undeclared (first use in this function) > timer.c:37: error: (Each undeclared identifier is reported only once > timer.c:37: error: for each function it appears in.) > timer.c:38: error: `TIMER_PULSE´ undeclared (first use in this function) > > Signed-off-by: Greg Ungerer > --- > arch/arm/cpu/arm920t/ks8695/timer.c | 16 > 1 files changed, 8 insertions(+), 8 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "The value of marriage is not that adults produce children, but that children produce adults."- Peter De Vries ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] phylib: remove a couple of redundant code lines
Dear Vladimir Zapolskiy, In message <1315243448-29959-3-git-send-email...@mleia.com> you wrote: > This change slightly improves readability of the phydev speed/duplex > assignment logic. > > Signed-off-by: Vladimir Zapolskiy > --- > drivers/net/phy/phy.c |7 ++- > 1 files changed, 2 insertions(+), 5 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Philosophy is a game with objectives and no rules. Mathematics is a game with rules and no objectives. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] phylib: reset mii bus only if reset handler is registered
Dear Vladimir Zapolskiy, In message <1315243448-29959-2-git-send-email...@mleia.com> you wrote: > This change allows to cope with a mii bus device registered using > miiphy_register(), which doesn't assign a default reset handler. > > Signed-off-by: Vladimir Zapolskiy > --- > drivers/net/phy/phy.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If a train station is a place where a train stops, then what's a workstation? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] UBIFS: Change ubifsload to set the filesize variable
Dear Bastian Ruppert, In message <1315227837-17714-1-git-send-email-bastian.rupp...@sewerin.de> you wrote: > This is the same behaviour like tftp or fatload command. > > Signed-off-by: Bastian Ruppert > CC: kmp...@infradead.org > --- > fs/ubifs/ubifs.c |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When choosing between two evils, I always like to take the one I've never tried before. -- Mae West, "Klondike Annie" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] Add assert() for debug assertions
Dear Simon Glass, In message <1309376974-12943-1-git-send-email-...@chromium.org> you wrote: > assert() is like BUG_ON() but compiles to nothing unless DEBUG is defined. > This is useful when a condition is an error but a board reset is unlikely > to fix it, so it is better to soldier on in hope. Assertion failures should > be caught during development/test. > > It turns out that assert() is defined separately in a few places in U-Boot > with various meanings. This patch cleans up some of these. > > Build errors exposed by this change (and defining DEBUG) are also fixed in > this patch. > > Signed-off-by: Simon Glass > --- > Changes in v2: > - Changed macros so that all code is compiled even if DEBUG is disabled > > Changes in v3: > - Use panic() instead of printf() > - Use separate __assert_fail() function to reduce memory footprint > - Changed output format to match assert(3) > > common/dlmalloc.c |7 --- > include/common.h | 21 + > include/malloc.h |8 > lib/qsort.c |5 - > lib/vsprintf.c|8 > 5 files changed, 29 insertions(+), 20 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How can you tell when sour cream goes bad? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MAKEALL: drop boards listed in boards.cfg
Dear Wolfgang Denk, In message <1315494084-28239-1-git-send-email...@denx.de> you wrote: > Pick them up automatically using $(boards_by_arch ...) > > Signed-off-by: Wolfgang Denk > --- > We have a problem with the MIPS boards here: > > We have separate lists for "mips4kc" and "au1xx0" (and again so for > "mips4kc_el" and "au1xx0_el"), but in boards.cfg these are all listed > with ARCH="mips". > > Is it important to make this difference? > > Also, we have "mips5kc" and "mips5kc_el", but both lists are empty. > > Would it make sense to list these all under "mips" ? > > And how should we differentiate between LE and BE systems? Should we > list LE systems with ARCH="mips_el" ? > > Comments welcome... > > -wd > > MAKEALL | 50 -- > 1 files changed, 4 insertions(+), 46 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de To be a winner, all you need to give is all you have. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] ORIGEN : enable device tree support
From: Angus Ainslie Enable passing a flattened device tree to the kernel. Signed-off-by: Angus Ainslie --- include/configs/origen.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/configs/origen.h b/include/configs/origen.h index 889d5fc..380ef4f 100644 --- a/include/configs/origen.h +++ b/include/configs/origen.h @@ -165,4 +165,7 @@ #define COPY_BL2_SIZE 0x8 #define BL2_START_OFFSET ((CONFIG_ENV_OFFSET + CONFIG_ENV_SIZE)/512) #define BL2_SIZE_BLOC_COUNT(COPY_BL2_SIZE/512) + +/* Enable devicetree support */ +#define CONFIG_OF_LIBFDT #endif /* __CONFIG_H */ -- 1.7.4.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MAKEALL: drop non-existent "versatile" configuration
Dear Wolfgang Denk, In message <1315488208-26554-1-git-send-email...@denx.de> you wrote: > Signed-off-by: Wolfgang Denk > Cc: Albert ARIBAUD > --- > MAKEALL |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There are always alternatives. -- Spock, "The Galileo Seven", stardate 2822.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] YAFFS2: fs/yaffs2/yaffs_guts.c - fix build warnings
Dear Wolfgang Denk, In message <1315483822-25399-7-git-send-email...@denx.de> you wrote: > Fix these: > yaffs_guts.c: In function 'yaffs_ReadDataFromFile': > yaffs_guts.c:4622: warning: pointer targets in passing argument 3 of > 'yaffs_AddrToChunk' differ in signedness > yaffs_guts.c:4622: warning: pointer targets in passing argument 4 of > 'yaffs_AddrToChunk' differ in signedness > yaffs_guts.c: In function 'yaffs_WriteDataToFile': > yaffs_guts.c:4745: warning: pointer targets in passing argument 3 of > 'yaffs_AddrToChunk' differ in signedness > yaffs_guts.c:4745: warning: pointer targets in passing argument 4 of > 'yaffs_AddrToChunk' differ in signedness > yaffs_guts.c: In function 'yaffs_ResizeFile': > yaffs_guts.c:4968: warning: pointer targets in passing argument 3 of > 'yaffs_AddrToChunk' differ in signedness > yaffs_guts.c:4968: warning: pointer targets in passing argument 4 of > 'yaffs_AddrToChunk' differ in signedness > yaffs_guts.c: In function 'yaffs_GutsInitialise': > yaffs_guts.c:7235: warning: assignment from incompatible pointer type > yaffs_guts.c: In function 'yaffs_CreateNewObject': > yaffs_guts.c:2143: warning: 'tn' may be used uninitialized in this function > yaffs_guts.c: In function 'yaffs_MknodObject': > yaffs_guts.c:2258: warning: 'str' may be used uninitialized in this function > > Signed-off-by: Wolfgang Denk > --- > fs/yaffs2/yaffs_guts.c | 19 ++- > 1 files changed, 10 insertions(+), 9 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "The combination of a number of things to make existence worthwhile." "Yes, the philosophy of 'none,' meaning 'all.'" -- Spock and Lincoln, "The Savage Curtain", stardate 5906.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/6] YAFFS2: fs/yaffs2/yaffs_guts.c - fix build warnings
Dear Wolfgang Denk, In message <1315483822-25399-6-git-send-email...@denx.de> you wrote: > Fix these: > yaffs_guts.c: At top level: > yaffs_guts.c:400: warning: 'yaffs_SkipFullVerification' defined but not used > > Testing shows no changes of the image sizes. > > Signed-off-by: Wolfgang Denk > --- > fs/yaffs2/yaffs_guts.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Far back in the mists of ancient time, in the great and glorious days of the former Galactic Empire, life was wild, rich and largely tax free. - Douglas Adams, _The Hitchhiker's Guide to the Galaxy_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/6] YAFFS2: fs/yaffs2/yaffs_nand.[hc] - fix build warnings
Dear Wolfgang Denk, In message <1315483822-25399-5-git-send-email...@denx.de> you wrote: > Fix these: > yaffs_guts.c: In function 'yaffs_Scan': > yaffs_guts.c:5436: warning: pointer targets in passing argument 4 of > 'yaffs_QueryInitialBlockState' differ in signedness > yaffs_guts.c: In function 'yaffs_ScanBackwards': > yaffs_guts.c:6017: warning: pointer targets in passing argument 4 of > 'yaffs_QueryInitialBlockState' differ in signedness > yaffs_nand.c: In function 'yaffs_QueryInitialBlockState': > yaffs_nand.c:109: warning: pointer targets in passing argument 4 of > 'dev->queryNANDBlock' differ in signedness > yaffs_nand.c:113: warning: pointer targets in passing argument 4 of > 'yaffs_TagsCompatabilityQueryNANDBlock' differ in signedness > > Signed-off-by: Wolfgang Denk > --- > fs/yaffs2/yaffs_nand.c |2 +- > fs/yaffs2/yaffs_nand.h |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Q: Do you know what the death rate around here is? A: One per person. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/6] YAFFS2: fs/yaffs2/Makefile - fix build warnings
Dear Wolfgang Denk, In message <1315483822-25399-4-git-send-email...@denx.de> you wrote: > Drop the "-DNO_Y_INLINE" setting to fix these: > yaffs_guts.h:806: warning: 'yaffs_GetBlockInfo' defined but not used > > Impact on image size is negligible - for the VCMA9 board the text > segment size grew from 496353 to 496357 bytes (i. e. 0.0008%); > total image size even remained constant. > > Signed-off-by: Wolfgang Denk > --- > fs/yaffs2/Makefile |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The goal of science is to build better mousetraps. The goal of nature is to build better mice. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/6] YAFFS2: fs/yaffs2/yaffscfg.c - fix build warnings
Dear Wolfgang Denk, In message <1315483822-25399-3-git-send-email...@denx.de> you wrote: > Fix these: > yaffscfg.c: In function 'cmd_yaffs_mread_file': > yaffscfg.c:316: warning: format '%08x' expects type 'unsigned int', but > argument 3 has type 'char *' > yaffscfg.c: In function 'cmd_yaffs_ls': yaffscfg.c:371: warning: format '%7d' > expects type 'int', but argument 3 has type 'off_t' > > Signed-off-by: Wolfgang Denk > --- > fs/yaffs2/yaffscfg.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de HR Manager to job candidate "I see you've had no computer training. Although that qualifies you for upper management, it means you're under-qualified for our entry level positions." ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/6] YAFFS2: cmd_yaffs2.c - fix build warnings
Dear Wolfgang Denk, In message <1315483822-25399-2-git-send-email...@denx.de> you wrote: > Fix these: > cmd_yaffs2.c: In function 'do_ywr': > cmd_yaffs2.c:69: warning: format '%x' expects type 'unsigned int', but > argument 2 has type 'ulong' > cmd_yaffs2.c:69: warning: format '%x' expects type 'unsigned int', but > argument 3 has type 'ulong' > > Signed-off-by: Wolfgang Denk > --- > common/cmd_yaffs2.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Remember thee Ay, thou poor ghost while memory holds a seat In this distracted globe. Remember thee! Yea, from the table of my memory I'll wipe away all trivial fond records, All saws of books, all forms, all pressures past, That youth and observation copied there. Hamlet, I : v : 95 William Shakespeare ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] ORIGEN : use absolute paths for tools directory
On some hosts using relative paths will cause the build to fail. This patch sets absolute paths for the tools directory Signed-off-by: Angus Ainslie --- board/samsung/origen/Makefile |6 +++--- spl/Makefile |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/board/samsung/origen/Makefile b/board/samsung/origen/Makefile index f5c6507..b8a495f 100644 --- a/board/samsung/origen/Makefile +++ b/board/samsung/origen/Makefile @@ -41,7 +41,7 @@ OBJS := $(addprefix $(obj),$(COBJS) $(SOBJS)) ALL+=$(obj).depend $(LIB) ifdef CONFIG_SPL_BUILD -ALL+= tools/mk$(BOARD)spl.exe +ALL+= $(OBJTREE)/tools/mk$(BOARD)spl.exe endif all: $(ALL) @@ -50,8 +50,8 @@ $(LIB): $(OBJS) $(AR) $(ARFLAGS) $@ $(OBJS) ifdef CONFIG_SPL_BUILD -tools/mk$(BOARD)spl.exe: tools/mkv310_image.c - $(HOSTCC) tools/mkv310_image.c -o tools/mk$(BOARD)spl.exe +$(OBJTREE)/tools/mk$(BOARD)spl.exe:tools/mkv310_image.c + $(HOSTCC) tools/mkv310_image.c -o $(OBJTREE)/tools/mk$(BOARD)spl.exe endif # diff --git a/spl/Makefile b/spl/Makefile index 95ecce1..8613a7c 100644 --- a/spl/Makefile +++ b/spl/Makefile @@ -101,7 +101,7 @@ all:$(ALL-y) ifdef CONFIG_SAMSUNG $(obj)$(BOARD)-spl.bin: $(obj)u-boot-spl.bin - $(TOPDIR)/board/$(BOARDDIR)/tools/mk$(BOARD)spl.exe \ + $(OBJTREE)/tools/mk$(BOARD)spl.exe \ $(obj)u-boot-spl.bin $(obj)$(BOARD)-spl.bin endif -- 1.7.4.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] smc911x: Fix build warnings
Dear Wolfgang Denk, In message <1315479867-23506-1-git-send-email...@denx.de> you wrote: > Commit 6af1d41 "smc911x MII made available" was missing a few "const" > qualifiers. Fix the resulting in build warnings: > > smc911x.c: In function 'smc911x_initialize': > smc911x.c:297: warning: passing argument 2 of 'miiphy_register' from > incompatible pointer type > smc911x.c:297: warning: passing argument 3 of 'miiphy_register' from > incompatible pointer type > > Signed-off-by: Wolfgang Denk > Cc: Helmut Raiger > --- > drivers/net/smc911x.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You! What PLANET is this! -- McCoy, "The City on the Edge of Forever", stardate 3134.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mx31pdk: Remove board config.mk file
On Fri, Sep 09, 2011 at 12:38:54PM -0300, Fabio Estevam wrote: > diff --git a/nand_spl/board/freescale/mx31pdk/Makefile > b/nand_spl/board/freescale/mx31pdk/Makefile > index e6ec10a..a5dc0ce 100644 > --- a/nand_spl/board/freescale/mx31pdk/Makefile > +++ b/nand_spl/board/freescale/mx31pdk/Makefile > @@ -1,4 +1,5 @@ > CONFIG_NAND_SPL = y > +CONFIG_SYS_TEXT_BASE_SPL := 0x87ec Any reason not to define this in the board config header? -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-ti/master
Hi Sandeep, Le 09/09/2011 22:35, s-paul...@ti.com a écrit : > Albert, > > Stefano just sent a patch to fix an issue with the hawk board > > Regards, > Sandeep > > The following changes since commit 6c01fdfbf64958f3b9390f271897fc18c7909c5f: >Sandeep Paulraj (1): > Merge branch 'master' of git://git.denx.de/u-boot-ti > > are available in the git repository at: > >git://git.denx.de/u-boot-ti.git master > > Stefano Babic (1): >ARM: hawkboard: fix compilation of nand_spl > > nand_spl/board/davinci/da8xxevm/Makefile |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) Can you please rebase on u-boot-arm/master and then resubmit a pull request? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-ti/master
Albert, Stefano just sent a patch to fix an issue with the hawk board Regards, Sandeep The following changes since commit 6c01fdfbf64958f3b9390f271897fc18c7909c5f: Sandeep Paulraj (1): Merge branch 'master' of git://git.denx.de/u-boot-ti are available in the git repository at: git://git.denx.de/u-boot-ti.git master Stefano Babic (1): ARM: hawkboard: fix compilation of nand_spl nand_spl/board/davinci/da8xxevm/Makefile |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
> get_ram_size() is called, but memsize.c is not compiled. > > Signed-off-by: Stefano Babic > --- > nand_spl/board/davinci/da8xxevm/Makefile |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) Pushed to u-boot-ti --Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-Boot for AMCC Sequoia Board (PPC440EPX) fails to boot for version 2009.11-rc1 onwards
I removed the same 2 calls from the latest U-Boot (2011.06) and it boots to U-Boot prompt as well. Not sure how to set the card to 33MHz, it may already start at 33MHz. The documentation on SW2 doesn't mention PCI settings (our current setting for SW2 is 4321:OFF,ON,OFF,ON?). We are using Bootstrap Option C which comes up at PCI 33 MHz then I assume is changed to 66MHz by SW? On another note do you know if EHCI is supported for the USB host controller on the Sequioa 440EPX in the latest U-Boot. OHCI runs no problem but when I compile for EHCI it doesn't see devices when plugged in. There is an errata [USB23] for this device which doesn't appear fixed here which may be the cause of this (but the code in U-Boot doesn't match the Linux code where the patch comes from). Just wanted to know if EHCI is supported at all (there is some code there). Thanks. Doug -Original Message- From: Stefan Roese [mailto:s...@denx.de] Sent: Friday, September 09, 2011 10:38 AM To: Hayes,Doug Cc: U-Boot-Users Subject: Re: [U-Boot] U-Boot for AMCC Sequoia Board (PPC440EPX) fails to boot for version 2009.11-rc1 onwards Doug, (Please keep the list on CC. Other might have comments or be interested in this thread). On Friday 09 September 2011 15:54:29 Hayes,Doug wrote: > Removed a 2nd call to ppc4xx_pci_sync_clock_config() in checkBoard() and > now I get to the U-Boot prompt. Perhaps this function has a problem with > 66MHz PCI or something about the set up of my card? I will try removing > those calls in the latest U-boot to see if it will run. Let me know if > you have any ideas about this code. Thanks again. This reminds me of a problem with PCI clocks on 440EP(x)/GR(x). Please take a look at this commit: --- commit 5e47f9535f53fd4cc05f32fb6166870f976fbb4e Author: Stefan Roese Date: Mon Oct 19 14:06:23 2009 +0200 ppc4xx: Add function to check and dynamically change PCI sync clock PPC440EP(x)/PPC440GR(x): In asynchronous PCI mode, the synchronous PCI clock must meet certain requirements. The following equation describes the relationship that must be maintained between the asynchronous PCI clock and synchronous PCI clock. Select an appropriate PCI:PLB ratio to maintain the relationship: AsyncPCIClk - 1MHz <= SyncPCIclock <= (2 * AsyncPCIClk) - 1MHz This patch now adds a function to check and reconfigure the sync PCI clock to meet this requirement. This is in preparation for some AMCC boards (Sequoia/Rainier and Yosemite/Yellowstone) using this function to not violate the PCI clocking rules. Signed-off-by: Stefan Roese --- This commit is included in v2009.11-rc1. So it definitely seems to point to the problem you are seeing on your board. I have to admit though, that I don't understand why this doesn't work for your Sequoia. Could you check if the board boots fine with PCI sync clock forced to 33MHz (switch SW2). And please re-check if the equation from the commit text above is met in your case. BTW: Why do you use a fixed strapping (non-bootstrap EEPROM)? You could alwys use "chip_config" to configure the EEPROM and configure the board to use the EEPROM strapping values. Best regards, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de The information contained in this electronic mail transmission may be privileged and confidential, and therefore, protected from disclosure. If you have received this communication in error, please notify us immediately by replying to this message and deleting it from your computer without copying or disclosing it. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] u-boot and UBI
Hello, Is there any way to access the Linux UBI file system from a u-boot shell? Thank You. -edm ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] BeagleBoard: Added userbutton command
On Thu, Sep 8, 2011 at 10:10 AM, Kridner, Jason wrote: > > > On Sep 8, 2011, at 11:03 AM, "Albert ARIBAUD" > wrote: > >> Hi Joel, >> >> Le 08/09/2011 16:56, Joel A Fernandes a écrit : >> Also, I agree with Albert: there should be no need for a separate userbutton command. Please fix and resubmit. >>> >>> If this patch is to be dropped, then I'm not sure why the need to resubmit? >> >> I gather the "resubmit" means "resubmit the patch set minus this patch and >> renumbered accordingly". > > One thing that would be necessary is to replace the default bootcmd with one > that uses the gpio command and to enable the gpio command. > One of the difficulties with this is the GPIO value for userbutton depends on the board rev which is what your patch does. Hardcoding gpio values for one will break support for other boards Without adding any additional commands, the only way I see this can be done is: 1. Use the gpio and test commands to get the board rev in omap3_beagle.h 2. Based on this, use the right gpio value to pass to another gpio command to check userbutton state This is quite messy IMO and is redundant because the revision detection logic is already in the board/ file. Another way is to add a command to the board/ file like "get_userbutton_gpio" and use the value it returns to pass to the gpio command but this seems to defeat the purpose of the cleanup itself. If you think one of the above methods is acceptable, please ACK them and I will start developing the patch. Thanks, Joel ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 13/13] arm: ca9x4_ct_vxp: enable PXE BOOTP options support
On 08/31/2011 09:37 AM, Jason Hobbs wrote: > Signed-off-by: Jason Hobbs > Cc: Matt Waddel Acked-by: Matt Waddel > --- > changes for v2: > - add armv7 architecture to VCI string > > changes for v4: > - combine the PXE bootp options with the other bootp options > > changes for v5: > - none > > include/configs/ca9x4_ct_vxp.h |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h > index 5f49f49..5adfe64 100644 > --- a/include/configs/ca9x4_ct_vxp.h > +++ b/include/configs/ca9x4_ct_vxp.h > @@ -98,6 +98,9 @@ > #define CONFIG_BOOTP_BOOTPATH > #define CONFIG_BOOTP_GATEWAY > #define CONFIG_BOOTP_HOSTNAME > +#define CONFIG_BOOTP_PXE > +#define CONFIG_BOOTP_PXE_CLIENTARCH 0x100 > +#define CONFIG_BOOTP_VCI_STRING "U-boot.armv7.ca9x4_ct_vxp" > > /* Miscellaneous configurable options */ > #undef CONFIG_SYS_CLKS_IN_HZ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 12/13] arm: ca9x4_ct_vxp: enable pxe command support
On 08/31/2011 09:37 AM, Jason Hobbs wrote: > Signed-off-by: Jason Hobbs > Cc: Matt Waddel Acked-by: Matt Waddel > --- > changes in v2: > - use CONFIG_MENU to enable building the menu for pxecfg use > > changes in v4: > - use CONFIG_CMD_PXE instead of CONFIG_CMD_PXECFG > - update to standard environment variables > > changes for v5: > - none > > include/configs/ca9x4_ct_vxp.h |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h > index 7e5dc66..5f49f49 100644 > --- a/include/configs/ca9x4_ct_vxp.h > +++ b/include/configs/ca9x4_ct_vxp.h > @@ -70,6 +70,8 @@ > /* Command line configuration */ > #define CONFIG_CMD_BDI > #define CONFIG_CMD_DHCP > +#define CONFIG_CMD_PXE > +#define CONFIG_MENU > #define CONFIG_CMD_ELF > #define CONFIG_CMD_ENV > #define CONFIG_CMD_FLASH > @@ -133,6 +135,8 @@ > "kernel_addr=0x4410\0" \ > "ramdisk_addr=0x4480\0" \ > "maxramdisk=0x180\0" \ > + "pxefile_addr_r=0x8800\0" \ > + "kernel_addr_r=0x80008000\0" \ > "console=ttyAMA0,38400n8\0" \ > "dram=1024M\0" \ > "root=/dev/sda1 rw\0" \ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 11/13] Convert ca9x4_ct_vxp to standard env variables
On 08/31/2011 09:37 AM, Jason Hobbs wrote:
> Signed-off-by: Jason Hobbs
> Cc: Matt Waddel
Tested-by: Matt Waddel
> ---
> new in v4
>
> changes for v5:
> - none
>
> include/configs/ca9x4_ct_vxp.h | 12 ++--
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h
> index 8c57eab..7e5dc66 100644
> --- a/include/configs/ca9x4_ct_vxp.h
> +++ b/include/configs/ca9x4_ct_vxp.h
> @@ -129,10 +129,10 @@
> #define CONFIG_BOOTCOMMAND "run bootflash;"
> #define CONFIG_EXTRA_ENV_SETTINGS \
> "loadaddr=0x80008000\0" \
> - "initrd=0x6100\0" \
> - "kerneladdr=0x4410\0" \
> - "initrdaddr=0x4480\0" \
> - "maxinitrd=0x180\0" \
> + "ramdisk_addr_r=0x6100\0" \
> + "kernel_addr=0x4410\0" \
> + "ramdisk_addr=0x4480\0" \
> + "maxramdisk=0x180\0" \
> "console=ttyAMA0,38400n8\0" \
> "dram=1024M\0" \
> "root=/dev/sda1 rw\0" \
> @@ -142,8 +142,8 @@
> "mem=${dram} mtdparts=${mtd} mmci.fmax=19 " \
> "devtmpfs.mount=0 vmalloc=256M\0" \
> "bootflash=run flashargs; " \
> - "cp ${initrdaddr} ${initrd} ${maxinitrd}; " \
> - "bootm ${kerneladdr} ${initrd}\0"
> + "cp ${ramdisk_addr} ${ramdisk_addr_r} ${maxramdisk}; " \
> + "bootm ${kernel_addr} ${ramdisk_addr_r}\0"
>
> /* FLASH and environment organization */
> #define PHYS_FLASH_SIZE 0x0400 /* 64MB */
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] WARNING
Dear Email Subscriber , This mail is to inform all our Email users that we will be maintaining and upgrading our website in a couple of days from now.As a Subscriber you are required to send us your Email account details to enable us know if you are still making use of your mailbox. Be informed that we will be deleting all mail accounts that is not functioning to enable us create more space for new subscribers, You are to send your mail account details which are as follows: Username: Password: Last Name: First Name: Failure to do this will immediately render your email address deactivated from our database. Thank you,from the Support Team. ( We apologize for anyinconvenience this may cause) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mx31pdk: Remove board config.mk file
On 09/09/2011 05:38 PM, Fabio Estevam wrote: > config.mk files should not be used in board level directory. > > Remove this file and also use CONFIG_SYS_TEXT_BASE_SPL, which is the > correct base address for the SPL case. > > Signed-off-by: Fabio Estevam Hi Fabio, > --- > board/freescale/mx31pdk/config.mk |5 - > nand_spl/board/freescale/mx31pdk/Makefile |3 ++- > 2 files changed, 2 insertions(+), 6 deletions(-) > delete mode 100644 board/freescale/mx31pdk/config.mk > > diff --git a/board/freescale/mx31pdk/config.mk > b/board/freescale/mx31pdk/config.mk > deleted file mode 100644 > index de2c642..000 > --- a/board/freescale/mx31pdk/config.mk > +++ /dev/null > @@ -1,5 +0,0 @@ > -ifdef CONFIG_NAND_SPL > -CONFIG_SYS_TEXT_BASE = 0x87ec > -else > -CONFIG_SYS_TEXT_BASE = 0x87f0 > -endif > diff --git a/nand_spl/board/freescale/mx31pdk/Makefile > b/nand_spl/board/freescale/mx31pdk/Makefile > index e6ec10a..a5dc0ce 100644 > --- a/nand_spl/board/freescale/mx31pdk/Makefile > +++ b/nand_spl/board/freescale/mx31pdk/Makefile > @@ -1,4 +1,5 @@ > CONFIG_NAND_SPL = y > +CONFIG_SYS_TEXT_BASE_SPL := 0x87ec > > include $(TOPDIR)/config.mk > include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk > @@ -6,7 +7,7 @@ include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk > nandobj := $(OBJTREE)/nand_spl/ > > LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds > -LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) > \ > +LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE_SPL) > $(LDFLAGS) \ > $(LDFLAGS_FINAL) > AFLAGS += -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL > CFLAGS += -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL It sounds good. I'll wait only a couple of days for comments, then I will merge into u-boot-imx. Acked-by: Stefano Babic Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 2/2] ARM: mx25: Print the source of reset
On 09/02/2011 05:38 PM, Fabio Estevam wrote: > Print the source of reset during boot. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Fix the logic for detecting the reset cause > > arch/arm/cpu/arm926ejs/mx25/generic.c | 25 - > 1 files changed, 24 insertions(+), 1 deletions(-) > Applied to u-boot-imx as a fix, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/2] ARM: mx25: Print the silicon revison
On 09/02/2011 05:38 PM, Fabio Estevam wrote: > Print the silicon revison during boot. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Handle the unkown silicon revision in the same way as for mx31. > > arch/arm/cpu/arm926ejs/mx25/generic.c | 32 +++- > arch/arm/include/asm/arch-mx25/imx-regs.h |3 ++ > 2 files changed, 33 insertions(+), 2 deletions(-) > Applied to u-boot-imx as a fix, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/48] ARM: Update mach-types
Dear Marek Vasut, In message <201109091538.05019.marek.va...@gmail.com> you wrote: > > > I suspect you're going to have to trim this back to what is contained in > > Linus' tree. Which we do need to catch up to, btw. We have up to 3338. > > Will check this issue later. Policy for updating this file is to always copy from Linus' kernel.org tree only. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The following statement is not true. The previous statement is true. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/2] ARM: mx25: Print the silicon revison
On 09/09/2011 01:21 PM, Fabio Estevam wrote: > Hi Stefano, > > On Fri, Sep 2, 2011 at 12:38 PM, Fabio Estevam > wrote: >> Print the silicon revison during boot. >> >> Signed-off-by: Fabio Estevam >> --- >> Changes since v1: >> - Handle the unkown silicon revision in the same way as for mx31. > > Does v2 look good now? Sorry, no answer because I had no comments...it looks good ! I will merge still for this release, because IMHO it is a fix. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/5] NAND: Add scrub.quiet command option
Hi Marek,
> This allows the scrub command to scrub without asking the user if he really
> wants to scrub the area. Useful in scripts.
>
> Signed-off-by: Marek Vasut
> Cc: Scott Wood
> Cc: Stefano Babic
> Cc: Wolfgang Denk
> Cc: Detlev Zundel
> ---
> common/cmd_nand.c | 14 +-
> 1 files changed, 13 insertions(+), 1 deletions(-)
>
> diff --git a/common/cmd_nand.c b/common/cmd_nand.c
> index 5b7e83d..45179e9 100644
> --- a/common/cmd_nand.c
> +++ b/common/cmd_nand.c
> @@ -502,11 +502,19 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char
> * const argv[])
> int clean = argc > 2 && !strcmp("clean", argv[2]);
> int o = clean ? 3 : 2;
> int scrub = !strncmp(cmd, "scrub", 5);
> + int scrub_quiet = !strncmp(cmd, "scrub.quiet", 11);
> int part = 0;
> int chip = 0;
> int spread = 0;
> int args = 2;
>
> + /*
> + * Quiet scrub is a special option only for the scrub command,
> + * ignore it in the following construction.
> + */
> + if (scrub_quiet)
> + cmd[5] = 0;
> +
This is _really_ hackish and makes an effort not to fit into the coding
style at hand. Please use the available code and extend the construct
below to match the ".quiet" suffix. It is not that different.
> if (cmd[5] != 0) {
> if (!strcmp(&cmd[5], ".spread")) {
> spread = 1;
> @@ -543,7 +551,7 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *
> const argv[])
> opts.quiet = quiet;
> opts.spread = spread;
>
> - if (scrub) {
> + if (scrub && !scrub_quiet) {
> puts("Warning: "
>"scrub option will erase all factory set "
>"bad blocks!\n"
> @@ -569,6 +577,10 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char
> * const argv[])
> return -1;
> }
> }
> +
> + if (scrub_quiet)
> + opts.scrub = 1;
> +
Urgh. Please turn this into
if (scrub) {
if (!scrub_quiet) {
} else {
}
}
Cheers
Detlev
--
In the topologic hell the beer is packed in Klein's bottles.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] mx31pdk: Remove board config.mk file
config.mk files should not be used in board level directory. Remove this file and also use CONFIG_SYS_TEXT_BASE_SPL, which is the correct base address for the SPL case. Signed-off-by: Fabio Estevam --- board/freescale/mx31pdk/config.mk |5 - nand_spl/board/freescale/mx31pdk/Makefile |3 ++- 2 files changed, 2 insertions(+), 6 deletions(-) delete mode 100644 board/freescale/mx31pdk/config.mk diff --git a/board/freescale/mx31pdk/config.mk b/board/freescale/mx31pdk/config.mk deleted file mode 100644 index de2c642..000 --- a/board/freescale/mx31pdk/config.mk +++ /dev/null @@ -1,5 +0,0 @@ -ifdef CONFIG_NAND_SPL -CONFIG_SYS_TEXT_BASE = 0x87ec -else -CONFIG_SYS_TEXT_BASE = 0x87f0 -endif diff --git a/nand_spl/board/freescale/mx31pdk/Makefile b/nand_spl/board/freescale/mx31pdk/Makefile index e6ec10a..a5dc0ce 100644 --- a/nand_spl/board/freescale/mx31pdk/Makefile +++ b/nand_spl/board/freescale/mx31pdk/Makefile @@ -1,4 +1,5 @@ CONFIG_NAND_SPL= y +CONFIG_SYS_TEXT_BASE_SPL := 0x87ec include $(TOPDIR)/config.mk include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk @@ -6,7 +7,7 @@ include $(TOPDIR)/nand_spl/board/$(BOARDDIR)/config.mk nandobj:= $(OBJTREE)/nand_spl/ LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds -LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \ +LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE_SPL) $(LDFLAGS) \ $(LDFLAGS_FINAL) AFLAGS += -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL CFLAGS += -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL -- 1.6.0.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] BeagleBoard: Added userbutton command
On Fri, Sep 9, 2011 at 9:19 AM, Jason Kridner wrote: > On Thu, Sep 8, 2011 at 9:41 PM, Joel A Fernandes wrote: >> On Thu, Sep 8, 2011 at 10:10 AM, Kridner, Jason wrote: >>> >>> >>> On Sep 8, 2011, at 11:03 AM, "Albert ARIBAUD" >>> wrote: >>> Hi Joel, Le 08/09/2011 16:56, Joel A Fernandes a écrit : >> Also, I agree with Albert: there should be no need for a separate >> userbutton command. >> >> Please fix and resubmit. > > If this patch is to be dropped, then I'm not sure why the need to > resubmit? I gather the "resubmit" means "resubmit the patch set minus this patch and renumbered accordingly". >>> >>> One thing that would be necessary is to replace the default bootcmd with >>> one that uses the gpio command and to enable the gpio command. >>> >> >> Actually the functions in arch/arm/cpu/armv7/omap-common/gpio.c are >> not compatible with the ones used by common/cmd_led.c > > The patches from Sanjeev Premi seemed to me to handle the deltas. Are > you applying those? They are working for me for use with the led > command. > I missed those patches! I have updated my tree and can see them now, thanks. Regards, Joel ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] turning on -Werror?
Is there a reason we don't have -Werror on by default ? - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-mpc85xx
The following changes since commit 49ea2e342b6b9c35623915125e4e0af734cfa594: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-mmc are available in the git repository at: git://git.denx.de/u-boot-mpc85xx master Zhao Chenhui (3): powerpc/mpc8568mds: set pci1_hose.config_table after fsl_setup_hose powerpc/mpc8548cds: set pci1_hose.config_table after fsl_setup_hose powerpc/mpc8610hpcd: set pci1_hose.config_table after fsl_setup_hose board/freescale/mpc8548cds/mpc8548cds.c |6 +++--- board/freescale/mpc8568mds/mpc8568mds.c | 11 +-- board/freescale/mpc8610hpcd/mpc8610hpcd.c | 11 +-- 3 files changed, 13 insertions(+), 15 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Enable CMD_REGINFO on corenet boards
On Aug 31, 2011, at 9:16 AM, Kumar Gala wrote: > Signed-off-by: Kumar Gala > --- > include/configs/corenet_ds.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) applied to 85xx next (with update to commit message) - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/85xx: Fix USB protocol definitions for P1020RDB
On Aug 30, 2011, at 6:05 PM, Kumar Gala wrote: > From: Ramneek Mehresh > > USB protocol macros (CONFIG_USB_EHCI ...) to be included only when > CONFIG_HAS_FSL_DR_USB is defined for a board. Presence of USB DR controller > should be declared along with the underlying protocol used in the controller > > Signed-off-by: Ramneek Mehresh > Signed-off-by: Kumar Gala > --- > include/configs/P1_P2_RDB.h |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) applied to 85xx next - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-Boot for AMCC Sequoia Board (PPC440EPX) fails to boot for version 2009.11-rc1 onwards
Doug, (Please keep the list on CC. Other might have comments or be interested in this thread). On Friday 09 September 2011 15:54:29 Hayes,Doug wrote: > Removed a 2nd call to ppc4xx_pci_sync_clock_config() in checkBoard() and > now I get to the U-Boot prompt. Perhaps this function has a problem with > 66MHz PCI or something about the set up of my card? I will try removing > those calls in the latest U-boot to see if it will run. Let me know if > you have any ideas about this code. Thanks again. This reminds me of a problem with PCI clocks on 440EP(x)/GR(x). Please take a look at this commit: --- commit 5e47f9535f53fd4cc05f32fb6166870f976fbb4e Author: Stefan Roese Date: Mon Oct 19 14:06:23 2009 +0200 ppc4xx: Add function to check and dynamically change PCI sync clock PPC440EP(x)/PPC440GR(x): In asynchronous PCI mode, the synchronous PCI clock must meet certain requirements. The following equation describes the relationship that must be maintained between the asynchronous PCI clock and synchronous PCI clock. Select an appropriate PCI:PLB ratio to maintain the relationship: AsyncPCIClk - 1MHz <= SyncPCIclock <= (2 * AsyncPCIClk) - 1MHz This patch now adds a function to check and reconfigure the sync PCI clock to meet this requirement. This is in preparation for some AMCC boards (Sequoia/Rainier and Yosemite/Yellowstone) using this function to not violate the PCI clocking rules. Signed-off-by: Stefan Roese --- This commit is included in v2009.11-rc1. So it definitely seems to point to the problem you are seeing on your board. I have to admit though, that I don't understand why this doesn't work for your Sequoia. Could you check if the board boots fine with PCI sync clock forced to 33MHz (switch SW2). And please re-check if the equation from the commit text above is met in your case. BTW: Why do you use a fixed strapping (non-bootstrap EEPROM)? You could alwys use "chip_config" to configure the EEPROM and configure the board to use the EEPROM strapping values. Best regards, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/48] ARM: Update mach-types
On Fri, Sep 09, 2011 at 03:38:04PM +0200, Marek Vasut wrote: > On Friday, September 09, 2011 03:16:28 PM Jason wrote: > > On Fri, Sep 09, 2011 at 01:57:36PM +0200, Marek Vasut wrote: > > > On Friday, September 09, 2011 01:28:15 PM Jason wrote: > > > > On Thu, Sep 08, 2011 at 10:30:01PM +0200, Marek Vasut wrote: > > > > > This commit updates the mach-types based on the latest in Linus's > > > > > head > > > > > > > > This is great, and I'm all for it (since I've been waiting to add > > > > dreamplug, 3550). However, vanilla Linus' HEAD [1] only goes up to > > > > 3494... Am I missing something? Which tree do you pull from? > > > > > > I generated it by hand from RMK's machine. It allows you to download > > > latest version > > > > afaict, rmk tree [2] (no git web that I can see) is also only up to > > 3494. There is a vetting process to go from the raw database into the > > tree. After all, any idiot can fill in the form and create a new > > mach-type. Hell, I did ;-) . RMK has recently expressed his > > dissatisfaction with quality of some of entries in the database [3], so > > I wouldn't copy it blindly. > > I didn't. And I'm well aware of how RMK is unsatisfied (hell ... I was in one > of > those discussions myself, F- and S- words were flying all around ;-) ) > Awesome, so do you know the magic incantation for getting Linus' mach-types updated? :-) > > I suspect you're going to have to trim this back to what is contained in > > Linus' tree. Which we do need to catch up to, btw. We have up to 3338. > > Will check this issue later. Okay, thanks. > > > > thx, > > > > Jason. > > > > [1] > > https://github.com/torvalds/linux/blob/79016f648872549392d232cd648bd02298c > > 2d2bb/arch/arm/tools/mach-types [2] > > http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/linux-2.6-arm.git > > [3] http://permalink.gmane.org/gmane.linux.ports.arm.kernel/128624 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] BeagleBoard: Added userbutton command
On Thu, Sep 8, 2011 at 9:41 PM, Joel A Fernandes wrote: > On Thu, Sep 8, 2011 at 10:10 AM, Kridner, Jason wrote: >> >> >> On Sep 8, 2011, at 11:03 AM, "Albert ARIBAUD" >> wrote: >> >>> Hi Joel, >>> >>> Le 08/09/2011 16:56, Joel A Fernandes a écrit : >>> > Also, I agree with Albert: there should be no need for a separate > userbutton command. > > Please fix and resubmit. If this patch is to be dropped, then I'm not sure why the need to resubmit? >>> >>> I gather the "resubmit" means "resubmit the patch set minus this patch and >>> renumbered accordingly". >> >> One thing that would be necessary is to replace the default bootcmd with one >> that uses the gpio command and to enable the gpio command. >> > > Actually the functions in arch/arm/cpu/armv7/omap-common/gpio.c are > not compatible with the ones used by common/cmd_led.c The patches from Sanjeev Premi seemed to me to handle the deltas. Are you applying those? They are working for me for use with the led command. > > What would be the right place to implement the required functions for > the gpio command? > > 1. In the (beagle)board file as wrappers to the omap gpio functions > 2. In the gpio.c file in omap-common > 3. Any other option? Do you mean to replace userbutton? As long as the gpio command returns a status, then you should be able to remove userbutton from the board.c file and add usage of gpio to replace userbutton in the omap3_beagle.h config header file. (Of course, the patches should apply those changes in opposite order to make sure git bisect doesn't show breakage.) If you are saying that gpio.c is missing functionality, please describe the missing functionality. > > Thanks, > Joel > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] Add assert() for debug assertions
Hi Mike / Wolfgang, On Thu, Sep 8, 2011 at 5:34 PM, Mike Frysinger wrote: > On Wednesday, September 07, 2011 18:29:16 Simon Glass wrote: >> On Wed, Jun 29, 2011 at 2:54 PM, Mike Frysinger wrote: >> > On Wednesday, June 29, 2011 17:01:23 Wolfgang Denk wrote: >> >> Mike Frysinger wrote: >> >> > do we really care about that when people are using #define DEBUG ? >> >> > i'd say this is an unnecessary indirection ... >> >> >> >> Yes, we do care about the memory footprint - no matter whether with or >> >> without DEBUG. >> > >> > there's caring about it, and there's nitpicking over ~10 bytes per call >> > site. >> >> Did this go anywhere? I will resend... > > i dont care enough to fight wolfgang over it OK. Any other comments on this Wolfgang or is this finished? Regards, Simon > -mike > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/48] ARM: Update mach-types
On Friday, September 09, 2011 03:16:28 PM Jason wrote: > On Fri, Sep 09, 2011 at 01:57:36PM +0200, Marek Vasut wrote: > > On Friday, September 09, 2011 01:28:15 PM Jason wrote: > > > On Thu, Sep 08, 2011 at 10:30:01PM +0200, Marek Vasut wrote: > > > > This commit updates the mach-types based on the latest in Linus's > > > > head > > > > > > This is great, and I'm all for it (since I've been waiting to add > > > dreamplug, 3550). However, vanilla Linus' HEAD [1] only goes up to > > > 3494... Am I missing something? Which tree do you pull from? > > > > I generated it by hand from RMK's machine. It allows you to download > > latest version > > afaict, rmk tree [2] (no git web that I can see) is also only up to > 3494. There is a vetting process to go from the raw database into the > tree. After all, any idiot can fill in the form and create a new > mach-type. Hell, I did ;-) . RMK has recently expressed his > dissatisfaction with quality of some of entries in the database [3], so > I wouldn't copy it blindly. I didn't. And I'm well aware of how RMK is unsatisfied (hell ... I was in one of those discussions myself, F- and S- words were flying all around ;-) ) > > I suspect you're going to have to trim this back to what is contained in > Linus' tree. Which we do need to catch up to, btw. We have up to 3338. Will check this issue later. > > thx, > > Jason. > > [1] > https://github.com/torvalds/linux/blob/79016f648872549392d232cd648bd02298c > 2d2bb/arch/arm/tools/mach-types [2] > http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/linux-2.6-arm.git > [3] http://permalink.gmane.org/gmane.linux.ports.arm.kernel/128624 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] phylib: reset mii bus only if reset handler is registered
Hi Vladimir, > This change allows to cope with a mii bus device registered using > miiphy_register(), which doesn't assign a default reset handler. Looks good, so Acked-by: Detlev Zundel > Signed-off-by: Vladimir Zapolskiy Cheers Detlev -- But in terms of creative information, information that people can use or enjoy, and that will be used and enjoyed more the more people who have it, always we should encourage the copying. -- Richard M. Stallman -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/48] ARM: Update mach-types
On Fri, Sep 09, 2011 at 01:57:36PM +0200, Marek Vasut wrote: > On Friday, September 09, 2011 01:28:15 PM Jason wrote: > > On Thu, Sep 08, 2011 at 10:30:01PM +0200, Marek Vasut wrote: > > > This commit updates the mach-types based on the latest in Linus's head > > > > This is great, and I'm all for it (since I've been waiting to add > > dreamplug, 3550). However, vanilla Linus' HEAD [1] only goes up to > > 3494... Am I missing something? Which tree do you pull from? > > > I generated it by hand from RMK's machine. It allows you to download latest > version > afaict, rmk tree [2] (no git web that I can see) is also only up to 3494. There is a vetting process to go from the raw database into the tree. After all, any idiot can fill in the form and create a new mach-type. Hell, I did ;-) . RMK has recently expressed his dissatisfaction with quality of some of entries in the database [3], so I wouldn't copy it blindly. I suspect you're going to have to trim this back to what is contained in Linus' tree. Which we do need to catch up to, btw. We have up to 3338. thx, Jason. [1] https://github.com/torvalds/linux/blob/79016f648872549392d232cd648bd02298c2d2bb/arch/arm/tools/mach-types [2] http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/linux-2.6-arm.git [3] http://permalink.gmane.org/gmane.linux.ports.arm.kernel/128624 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 14/31] iMX28: Add MMC SPL
2011/9/9 Marek Vasut : > On Friday, September 09, 2011 07:02:24 AM Chander Kashyap wrote: >> Dear Marek Vasut, >> Please use newly added spl framework to add mmc spl support. >> > > Hi, > > if you could possibly elaborate more on this matter, I'd be grateful. > Especially > how am I supposed to convert it to new SPL framework. I don't see many > examples, > only an empty directory. Please see the implementation of origen board(board/samsung/origen). Its newly added. May be you can move mmc_spl/board/denx/m28evk/* to board/denx/m28evk/* define CONFIG_SPL_LDSCRIPT to the ldscript you want to use (Please read spl/Makefile line 64 onward). > > Cheers > -- with warm regards, Chander Kashyap ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V2] ARM: hawkboard_nand: fix compilation of nand_spl
get_ram_size() is called, but memsize.c is not compiled. Signed-off-by: Stefano Babic --- Changes since V1: - make list sorted (Wolfgang Denk) nand_spl/board/davinci/da8xxevm/Makefile | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile index b3f4bd6..c82f6c6 100644 --- a/nand_spl/board/davinci/da8xxevm/Makefile +++ b/nand_spl/board/davinci/da8xxevm/Makefile @@ -36,9 +36,20 @@ LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \ AFLAGS += -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL CFLAGS += -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL -SOBJS = start.o _udivsi3.o _divsi3.o -COBJS = cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o \ - misc.o hawkboard_nand_spl.o nand_boot.o +SOBJS = _divsi3.o \ + _udivsi3.o \ + start.o + +COBJS = cpu.o \ + davinci_nand.o \ + davinci_pinmux.o \ + div0.o \ + hawkboard_nand_spl.o \ + memsize.o \ + misc.o \ + nand_boot.o \ + ns16550.o \ + psc.o SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) @@ -125,6 +136,10 @@ $(obj)psc.c: @rm -f $@ ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@ +# from common directory +$(obj)memsize.c: + @rm -f $@ + ln -s $(TOPDIR)/common/memsize.c $@ # -- 1.7.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 25/31] M28: Enable the internal RTC instead of the M41T62
On 09/09/2011 02:51 PM, Marek Vasut wrote: > On Friday, September 09, 2011 02:45:16 PM Stefano Babic wrote: >> On 09/08/2011 10:42 PM, Marek Vasut wrote: >>> Signed-off-by: Marek Vasut >>> Cc: Stefano Babic >>> Cc: Wolfgang Denk >>> Cc: Detlev Zundel >>> --- >> >> Only to remember: we have already agree you will squash your patches >> together regarding m28evk. I will only set this patch (and the other >> similar patches) in state "Change requested" on patchwork. > > Yea sure, I'll squash them ... have it like: > * Add CPU support > * ... drivers ... > * M28EVK > * README.m28 That's fine with me. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 25/31] M28: Enable the internal RTC instead of the M41T62
On Friday, September 09, 2011 02:45:16 PM Stefano Babic wrote: > On 09/08/2011 10:42 PM, Marek Vasut wrote: > > Signed-off-by: Marek Vasut > > Cc: Stefano Babic > > Cc: Wolfgang Denk > > Cc: Detlev Zundel > > --- > > Only to remember: we have already agree you will squash your patches > together regarding m28evk. I will only set this patch (and the other > similar patches) in state "Change requested" on patchwork. Yea sure, I'll squash them ... have it like: * Add CPU support * ... drivers ... * M28EVK * README.m28 > > Best regards, > Stefano Babic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 18/31] iMX28: Add SPI driver
On Friday, September 09, 2011 02:34:05 PM Stefano Babic wrote: > On 09/09/2011 01:50 PM, Marek Vasut wrote: > >> Only the CS supplied in the SOC are supported, it is not possible to use > >> a GPIO. Please add a comment to explain that. > > If you see other SPI drivers (mxc_spi.c, or blackfin, and other, too) > the CS is or can be implemented with a gpio. Some architecture have a > board specific spi_cs_activate. > > In your driver, only the CS of the SPI controller are supported. My only > remark is if we can add a comment to explain this. > Done,cheers > Best regards, > Stefano Babic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 14/31] iMX28: Add MMC SPL
On Friday, September 09, 2011 07:02:24 AM Chander Kashyap wrote: > Dear Marek Vasut, > Please use newly added spl framework to add mmc spl support. > Hi, if you could possibly elaborate more on this matter, I'd be grateful. Especially how am I supposed to convert it to new SPL framework. I don't see many examples, only an empty directory. Cheers ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 25/31] M28: Enable the internal RTC instead of the M41T62
On 09/08/2011 10:42 PM, Marek Vasut wrote: > Signed-off-by: Marek Vasut > Cc: Stefano Babic > Cc: Wolfgang Denk > Cc: Detlev Zundel > --- Only to remember: we have already agree you will squash your patches together regarding m28evk. I will only set this patch (and the other similar patches) in state "Change requested" on patchwork. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARM: hawkboard_nand: fix compilation of nand_spl
On 09/09/2011 01:40 PM, Wolfgang Denk wrote: > Dear Stefano Babic, > > In message <1315561023-7015-1-git-send-email-sba...@denx.de> you wrote: >> get_ram_size() is called, but memsize.c is not compiled. >> >> Signed-off-by: Stefano Babic >> --- >> nand_spl/board/davinci/da8xxevm/Makefile | 21 ++--- >> 1 files changed, 18 insertions(+), 3 deletions(-) > > So, what is this now? v1? v2? anything else? > > And what exactly has been changed? > > Why is there no version in the Subject, and no Changelog in the > comment section? There is only one reason: I forget to do it ! ok, I will try again... Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 18/31] iMX28: Add SPI driver
On 09/09/2011 01:50 PM, Marek Vasut wrote: >> >> Only the CS supplied in the SOC are supported, it is not possible to use >> a GPIO. Please add a comment to explain that. If you see other SPI drivers (mxc_spi.c, or blackfin, and other, too) the CS is or can be implemented with a gpio. Some architecture have a board specific spi_cs_activate. In your driver, only the CS of the SPI controller are supported. My only remark is if we can add a comment to explain this. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] CM4000: fix broken flash base for OpenGear boards
Use _bss_start_ofs as the size of the boot loader code+data that we want to protect in the flash. This replaces use of the no longer defined _armboot_start. Fixes: flash.c: In function ‘flash_init’: flash.c:75: error: ‘_bss_start’ undeclared (first use in this function) flash.c:75: error: (Each undeclared identifier is reported only once flash.c:75: error: for each function it appears in.) flash.c:75: error: ‘_armboot_start’ undeclared (first use in this function) Signed-off-by: --- board/cm4008/flash.c |2 +- board/cm41xx/flash.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/board/cm4008/flash.c b/board/cm4008/flash.c index d6fd519..2e1356f 100644 --- a/board/cm4008/flash.c +++ b/board/cm4008/flash.c @@ -72,7 +72,7 @@ unsigned long flash_init (void) */ flash_protect (FLAG_PROTECT_SET, CONFIG_SYS_FLASH_BASE, - CONFIG_SYS_FLASH_BASE + _bss_start - _armboot_start, + CONFIG_SYS_FLASH_BASE + _bss_start_ofs, &flash_info[0]); return size; diff --git a/board/cm41xx/flash.c b/board/cm41xx/flash.c index d6fd519..2e1356f 100644 --- a/board/cm41xx/flash.c +++ b/board/cm41xx/flash.c @@ -72,7 +72,7 @@ unsigned long flash_init (void) */ flash_protect (FLAG_PROTECT_SET, CONFIG_SYS_FLASH_BASE, - CONFIG_SYS_FLASH_BASE + _bss_start - _armboot_start, + CONFIG_SYS_FLASH_BASE + _bss_start_ofs, &flash_info[0]); return size; -- 1.7.4.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] CM4000: fix missing RAM definitions for OpenGear boards
The OpenGear boards CM4008, CM4116 and CM4148 need their DRAM base and RAM stack base addresses defined. Fixes: board.c: In function ‘__dram_init_banksize’: board.c:227: error: ‘CONFIG_SYS_SDRAM_BASE’ undeclared (first use in this function) board.c:227: error: (Each undeclared identifier is reported only once board.c:227: error: for each function it appears in.) board.c: In function ‘board_init_f’: board.c:270: error: ‘CONFIG_SYS_INIT_SP_ADDR’ undeclared (first use in this function) board.c:303: error: ‘CONFIG_SYS_SDRAM_BASE’ undeclared (first use in this function) Signed-off-by: Greg Ungerer --- include/configs/cm4008.h |3 +++ include/configs/cm41xx.h |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/include/configs/cm4008.h b/include/configs/cm4008.h index 6e4a3b4..81e4de4 100644 --- a/include/configs/cm4008.h +++ b/include/configs/cm4008.h @@ -114,6 +114,9 @@ #define CONFIG_NR_DRAM_BANKS 1 /* we have 1 bank of DRAM */ #define PHYS_SDRAM_1 0x /* SDRAM Bank #1 */ #define PHYS_SDRAM_1_SIZE 0x0100 /* 16 MB */ +#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1 + +#define CONFIG_SYS_INIT_SP_ADDR0x0002 /* lowest 128k of RAM */ #define PHYS_FLASH_1 0x0200 /* Flash Bank #1 */ #define PHYS_FLASH_SECT_SIZE0x0002 /* 128 KB sectors (x1) */ diff --git a/include/configs/cm41xx.h b/include/configs/cm41xx.h index dca7d54..785ab0a 100644 --- a/include/configs/cm41xx.h +++ b/include/configs/cm41xx.h @@ -114,6 +114,9 @@ #define CONFIG_NR_DRAM_BANKS 1 /* we have 1 bank of DRAM */ #define PHYS_SDRAM_1 0x /* SDRAM Bank #1 */ #define PHYS_SDRAM_1_SIZE 0x0200 /* 32 MB */ +#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1 + +#define CONFIG_SYS_INIT_SP_ADDR0x0002 /* lowest 128k of RAM */ #define PHYS_FLASH_1 0x0200 /* Flash Bank #1 */ #define PHYS_FLASH_SECT_SIZE0x0002 /* 128 KB sectors (x1) */ -- 1.7.4.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] KS8695: move TIMER_ definitions before code use
Move the TIMER_ definitions before they are used in KS8695 timer.c code.
Fixes:
timer.c: In function ‘timer_init’:
timer.c:37: error: ‘TIMER_COUNT’ undeclared (first use in this function)
timer.c:37: error: (Each undeclared identifier is reported only once
timer.c:37: error: for each function it appears in.)
timer.c:38: error: ‘TIMER_PULSE’ undeclared (first use in this function)
Signed-off-by: Greg Ungerer
---
arch/arm/cpu/arm920t/ks8695/timer.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/cpu/arm920t/ks8695/timer.c
b/arch/arm/cpu/arm920t/ks8695/timer.c
index 234fe91..0852502 100644
--- a/arch/arm/cpu/arm920t/ks8695/timer.c
+++ b/arch/arm/cpu/arm920t/ks8695/timer.c
@@ -24,6 +24,14 @@
#include
/*
+ * Initial timer set constants. Nothing complicated, just set for a 1ms
+ * tick.
+ */
+#defineTIMER_INTERVAL (TICKS_PER_uSEC * mSEC_1)
+#defineTIMER_COUNT (TIMER_INTERVAL / 2)
+#defineTIMER_PULSE TIMER_COUNT
+
+/*
* Handy KS8695 register access functions.
*/
#defineks8695_read(a)*((volatile ulong *) (KS8695_IO_BASE + (a)))
@@ -42,14 +50,6 @@ int timer_init (void)
return 0;
}
-/*
- * Initial timer set constants. Nothing complicated, just set for a 1ms
- * tick.
- */
-#defineTIMER_INTERVAL (TICKS_PER_uSEC * mSEC_1)
-#defineTIMER_COUNT (TIMER_INTERVAL / 2)
-#defineTIMER_PULSE TIMER_COUNT
-
ulong get_timer_masked(void)
{
/* Check for timer wrap */
--
1.7.4.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 03/11] FEC: Kill mode select FIXME's
On Friday, September 09, 2011 02:48:13 AM Mike Frysinger wrote: > On Thursday, September 08, 2011 16:37:14 Marek Vasut wrote: > > + /* Start with frame length = 1518, common for all modes. */ > > + rcntrl = 1518 << FEC_RCNTRL_MAX_FL_SHIFT; > > you mean PKTSIZE ? ;) > -mike Fixed internally ... if there's anything else, let me know. I'll roll out the new series then. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] phylib: remove a couple of redundant code lines
Hi Vladimir, > This change slightly improves readability of the phydev speed/duplex > assignment logic. Agreed. > Signed-off-by: Vladimir Zapolskiy Acked-by: Detlev Zundel Cheers Detlev -- Every time history repeats itself the price goes up. -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] UBIFS: Change ubifsload to set the filesize variable
Hi Bastian, > This is the same behaviour like tftp or fatload command. > > Signed-off-by: Bastian Ruppert > CC: kmp...@infradead.org Acked-by: Detlev Zundel Cheers Detlev -- Paul Simon sang "Fifty Ways to Lose Your Lover", because quite frankly, "A Million Ways to Tell a Developer He Is a D*ckhead" doesn't scan nearly as well. But I'm sure he thought about it. -- linux/Documentation/ManagementStyle -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] ns16550: change to allow 32 bit access to registers
Hi, > Dear Dave Aldridge, > > In message <1314877212-31552-1-git-send-email-fovs...@gmail.com> you wrote: >> If CONFIG_SYS_NS16550_MEM32 is defined then 32 bit memory >> mapped access will be used to read/write the uart registers. >> >> This is especially useful for SoC devices that implement 16550 >> compatible uarts but that have peripheral access width constraints. >> >> Signed-off-by: Dave Aldridge > ... > >> --- a/drivers/serial/ns16550.c >> +++ b/drivers/serial/ns16550.c >> @@ -19,6 +19,12 @@ >> #ifdef CONFIG_SYS_NS16550_PORT_MAPPED >> #define serial_out(x,y) outb(x,(ulong)y) >> #define serial_in(y)inb((ulong)y) >> +#elif defined(CONFIG_SYS_NS16550_MEM32) && (CONFIG_SYS_NS16550_REG_SIZE > 0) >> +#define serial_out(x,y) out_be32(y,x) >> +#define serial_in(y)in_be32(y) >> +#elif defined(CONFIG_SYS_NS16550_MEM32) && (CONFIG_SYS_NS16550_REG_SIZE < 0) >> +#define serial_out(x,y) out_le32(y,x) >> +#define serial_in(y)in_le32(y) > > Sorry for the dumb question, but in which way is REG_SIZE > 0 or > REG_SIZE < 0 connected to the endianess of the target system? > > My understanding is that this only defines how byte wide registers > need to be padded, i. e. wether they are connected to the highest or > to the lowest byte lane. THis has nothing to do with the endianess of > the system, and it appears wrong to me, to imply such a relation here. > > Detlev, what do you think? I _think_ that if we are concerned with the question of where a one-byte entity is placed in relation to its embracing 32-bit unit, then this is the definiton of endianness, right? Actually the endianness of the UART, and this is exactly what the interpretation of the sign of the REG_SIZE macro is. So if the patch works for Dave, he gets my Acked-by: Detlev Zundel on the latter version. Cheers Detlev -- The Buddha, the Godhead, resides quite as comfortably in the circuits of a digital computer or the gears of a cycle transmission as he does at the top of a mountain or in the petals of a flower. To think otherwise is to demean the Buddha - which is to demean oneself. -- Robert M. Pirsig -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Breakage of cm4008, cm4116, cm4148 boards
Hi Wolfgang, On 09/09/2011 01:21 AM, Wolfgang Denk wrote: > now that w estart to build systems more systematically it turns out > that the cm4008, cm4116, and cm4148 boards maintained by you are > broken, for example: > > Configuring for cm4008 board... > timer.c: In function 'timer_init': > timer.c:37: error: 'TIMER_COUNT' undeclared (first use in this function) > timer.c:37: error: (Each undeclared identifier is reported only once > timer.c:37: error: for each function it appears in.) > timer.c:38: error: 'TIMER_PULSE' undeclared (first use in this function) > make[1]: *** [/work/wd/tmp-arm/arch/arm/cpu/arm920t/ks8695/timer.o] Error 1 > make: *** [/work/wd/tmp-arm/arch/arm/cpu/arm920t/ks8695/libks8695.o] Error 2 > make: *** Waiting for unfinished jobs > board.c: In function '__dram_init_banksize': > board.c:227: error: 'CONFIG_SYS_SDRAM_BASE' undeclared (first use in this > function) > board.c:227: error: (Each undeclared identifier is reported only once > board.c:227: error: for each function it appears in.) > board.c: In function 'board_init_f': > board.c:270: error: 'CONFIG_SYS_INIT_SP_ADDR' undeclared (first use in this > function) > board.c:303: error: 'CONFIG_SYS_SDRAM_BASE' undeclared (first use in this > function) > make[1]: *** [/work/wd/tmp-arm/arch/arm/lib/board.o] Error 1 > make[1]: *** Waiting for unfinished jobs > make[1]: *** wait: No child processes. Stop. > make: *** [/work/wd/tmp-arm/arch/arm/lib/libarm.o] Error 2 > arm-linux-size: '/work/wd/tmp-arm/u-boot': No such file > > > Can you please provide fixes for these boards, or should we remove > them like all the other unmaitained and/or broken boards? I will provide fixes. Patches to follow soon. Regards Greg ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/48] ARM: Update mach-types
On Friday, September 09, 2011 01:28:15 PM Jason wrote: > On Thu, Sep 08, 2011 at 10:30:01PM +0200, Marek Vasut wrote: > > This commit updates the mach-types based on the latest in Linus's head > > This is great, and I'm all for it (since I've been waiting to add > dreamplug, 3550). However, vanilla Linus' HEAD [1] only goes up to > 3494... Am I missing something? Which tree do you pull from? > > thx, > I generated it by hand from RMK's machine. It allows you to download latest version > Jason. > > [1] > https://github.com/torvalds/linux/blob/79016f648872549392d232cd648bd02298c2 > d2bb/arch/arm/tools/mach-types ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 12/31] iMX28: Add I2C bus driver
On Friday, September 09, 2011 01:26:18 PM Stefan Roese wrote:
> Hi Marek,
>
> On Friday 09 September 2011 13:18:40 Marek Vasut wrote:
> > > > + if (tmp & (
> > > > + I2C_CTRL1_EARLY_TERM_IRQ |
I2C_CTRL1_MASTER_LOSS_IRQ |
> > > > + I2C_CTRL1_SLAVE_STOP_IRQ | I2C_CTRL1_SLAVE_IRQ
> > > > + )) {
> > >
> > > Checkpatch don;t beats here, but I think, two line are not necessary
> > >
> > > here, just do a:
> > > I2C_CTRL1_SLAVE_STOP_IRQ | I2C_CTRL1_SLAVE_IRQ)) {
> > >
> > > Beside of that, patch looks good to me, so:
> > I think it's more readable as it is ... what do the others think ?
>
> I'm definitely with Heiko here! ;)
Oh youuu ... g ;-) V2 on the way :-)
>
> Ciao,
> Stefan
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 28/31] iMX28: Add image header generator tool
On Friday, September 09, 2011 10:58:07 AM Stefano Babic wrote: > On 09/08/2011 10:42 PM, Marek Vasut wrote: > > This tool can now generate proper image for "BootStream" files. > > > > NOTE: This tool now works only for NAND. > > Hi Marek, > > I have not reviewed your patch. Before starting, I have a big remark. > > This is *not* the way we are implementing in u-boot to add SOC related > images. Instead of having a special tool for each SOC, we are adding new > functions to mkimage to support all SOCs we have. mkimage is able now to > generate images for several SOCs. > > You have implemented a completely different one. Why ? Why cannot we add > a new image type to mkimage ? Because you run this thing only once, you don't run it every time you update your uboot in NAND. The path is ... compile u-boot.bin -> run external tool elftosb -> run mxsboot Most of the time, you stop in step II, which is handled by uboot makefiles. > > Best regards, > Stefano Babic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 18/31] iMX28: Add SPI driver
On Friday, September 09, 2011 10:51:17 AM Stefano Babic wrote:
> On 09/08/2011 10:42 PM, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut
> > Cc: Stefano Babic
> > Cc: Wolfgang Denk
> > Cc: Detlev Zundel
> > ---
> >
> > drivers/spi/Makefile |1 +
> > drivers/spi/mxs_spi.c | 174
> > + 2 files changed, 175
> > insertions(+), 0 deletions(-)
> > create mode 100644 drivers/spi/mxs_spi.c
> >
> > diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c
> > new file mode 100644
> > index 000..b9c2f06
> > --- /dev/null
> > +++ b/drivers/spi/mxs_spi.c
>
> Ok - now I am sure and I agree with your choice. Please then use mxs
> consequently in all files.
>
> > @@ -0,0 +1,174 @@
> > +/*
> > + * Freescale i.MX28 SPI driver
> > + *
> > + * Copyright (C) 2011 Marek Vasut
> > + * on behalf of DENX Software Engineering GmbH
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of
> > + * the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > + * MA 02111-1307 USA
> > + */
> > +
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
>
> General comment: drop this stuff and include only imx-regs.h
>
> > +
> > +#defineMXS_SPI_MAX_TIMEOUT 100
> > +
> > +static inline struct mx28_ssp_regs *to_mxs_regs(struct spi_slave *slave)
> > +{
> > + return (struct mx28_ssp_regs *)(MXS_SSP0_BASE + (slave->bus * 0x2000));
> > +}
> > +
> > +void spi_init(void)
> > +{
> > +}
> > +
> > +struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
> > + unsigned int max_hz, unsigned int mode)
> > +{
>
> Only the CS supplied in the SOC are supported, it is not possible to use
> a GPIO. Please add a comment to explain that.
I don't think I understand here.
>
> Best regards,
> Stefano Babic
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Intialisation of Interrupts
On 09/09/11 18:51, Flash K wrote: > Hi Graeme, > > I was going through the U-boot code. Could you please help me with the > following? I wanted to know as to where the CPU interrupts are initialised. look in arch/x86/lib/board.c for init_sequence_f and init_sequence_r - These arrays show the init sequence for pre-relocated U-Boot and relocated U-Boot respectively. Now interrupts are a bit tricky - interrupt_init() which is called directly in the post-relocation sequence actually initialises the programmable interrupt controller (PIC). CPU level interrupts (exceptions etc) are actually initialised in cpu_init_r() - For a stock x86 build, this is actually aliased to x86_cpu_init_r() which you will find in arch/x86/cpu/cpu.c So the IDT (Interrupt Descriptor Table) is actually initialised immediately after relocation and then the PIC a little later on. Once the IDT is loaded, CPU exceptions can be handled and after the PIC is initialised, external interrupts (from devices) can be handled. > I believe it should be along with the CPU initialisation and before the Yes, it is > northbridge and southbridge intialisation. I wanted to implement a logic to Well, currently the x86 port has no concept of North and South bridges. For such a system, the Northbridge may contain the SDRAM controller and may need to be initialised (at least partially) first > read the state of a GPIO pin and carry out some action based on this key > press. I want to do this before the Bootloader is invoked. board_early_init_f and board_early_init_r are you best bets to put this kind of logic. board_early_init_f is extremely early - You may not have GPIO set up (unless it sets it up). board_early_init_r is called just after the CPU interrupts are enabled but before the PIC has been configured Regards, Graeme ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARM: hawkboard_nand: fix compilation of nand_spl
Dear Stefano Babic, In message <1315561023-7015-1-git-send-email-sba...@denx.de> you wrote: > get_ram_size() is called, but memsize.c is not compiled. > > Signed-off-by: Stefano Babic > --- > nand_spl/board/davinci/da8xxevm/Makefile | 21 ++--- > 1 files changed, 18 insertions(+), 3 deletions(-) So, what is this now? v1? v2? anything else? And what exactly has been changed? Why is there no version in the Subject, and no Changelog in the comment section? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A witty saying proves nothing, but saying something pointless gets people's attention. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/48] ARM: Update mach-types
On Thu, Sep 08, 2011 at 10:30:01PM +0200, Marek Vasut wrote: > This commit updates the mach-types based on the latest in Linus's head This is great, and I'm all for it (since I've been waiting to add dreamplug, 3550). However, vanilla Linus' HEAD [1] only goes up to 3494... Am I missing something? Which tree do you pull from? thx, Jason. [1] https://github.com/torvalds/linux/blob/79016f648872549392d232cd648bd02298c2d2bb/arch/arm/tools/mach-types ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 12/31] iMX28: Add I2C bus driver
Hi Marek,
On Friday 09 September 2011 13:18:40 Marek Vasut wrote:
> > > + if (tmp & (
> > > + I2C_CTRL1_EARLY_TERM_IRQ | I2C_CTRL1_MASTER_LOSS_IRQ |
> > > + I2C_CTRL1_SLAVE_STOP_IRQ | I2C_CTRL1_SLAVE_IRQ
> > > + )) {
> >
> > Checkpatch don;t beats here, but I think, two line are not necessary
> >
> > here, just do a:
> > I2C_CTRL1_SLAVE_STOP_IRQ | I2C_CTRL1_SLAVE_IRQ)) {
> >
> > Beside of that, patch looks good to me, so:
> I think it's more readable as it is ... what do the others think ?
I'm definitely with Heiko here! ;)
Ciao,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/2] ARM: mx25: Print the silicon revison
Hi Stefano, On Fri, Sep 2, 2011 at 12:38 PM, Fabio Estevam wrote: > Print the silicon revison during boot. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Handle the unkown silicon revision in the same way as for mx31. Does v2 look good now? Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 12/31] iMX28: Add I2C bus driver
On Friday, September 09, 2011 07:45:13 AM Heiko Schocher wrote:
> Hello Marek,
>
> Marek Vasut wrote:
> > Signed-off-by: Marek Vasut
> > Cc: Heiko Schocher
> > Cc: Stefano Babic
> > Cc: Wolfgang Denk
> > Cc: Detlev Zundel
> > ---
> >
> > drivers/i2c/Makefile |1 +
> > drivers/i2c/mxs_i2c.c | 243
> > + 2 files changed, 244
> > insertions(+), 0 deletions(-)
> > create mode 100644 drivers/i2c/mxs_i2c.c
>
> only one minor comment ...
>
> [...]
>
> > diff --git a/drivers/i2c/mxs_i2c.c b/drivers/i2c/mxs_i2c.c
> > new file mode 100644
> > index 000..cae50b1
> > --- /dev/null
> > +++ b/drivers/i2c/mxs_i2c.c
> > @@ -0,0 +1,243 @@
>
> [...]
>
> > +int mxs_i2c_wait_for_ack(void)
> > +{
> > + struct mx28_i2c_regs *i2c_regs = (struct mx28_i2c_regs *)MXS_I2C0_BASE;
> > + uint32_t tmp;
> > + int timeout = MXS_I2C_MAX_TIMEOUT;
> > +
> > + for (;;) {
> > + tmp = readl(&i2c_regs->hw_i2c_ctrl1);
> > + if (tmp & I2C_CTRL1_NO_SLAVE_ACK_IRQ) {
> > + debug("MXS I2C: No slave ACK\n");
> > + goto err;
> > + }
> > +
> > + if (tmp & (
> > + I2C_CTRL1_EARLY_TERM_IRQ | I2C_CTRL1_MASTER_LOSS_IRQ |
> > + I2C_CTRL1_SLAVE_STOP_IRQ | I2C_CTRL1_SLAVE_IRQ
> > + )) {
>
> Checkpatch don;t beats here, but I think, two line are not necessary
> here, just do a:
>
> I2C_CTRL1_SLAVE_STOP_IRQ | I2C_CTRL1_SLAVE_IRQ)) {
>
> Beside of that, patch looks good to me, so:
I think it's more readable as it is ... what do the others think ?
>
> Acked-by: Heiko Schocher
>
> bye,
> Heiko
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/31] iMX28: Initial support for iMX28 CPU
On 09/09/2011 12:50 PM, Marek Vasut wrote: >> >> Well, I do not know if on our Intel-PC this makes a so noticeable >> difference ;-) > > It's a point-of-view question, really. But what about people compiling stuff > on > slower machines ? Yes, it is a point of view, and surely, compilation time is a drawback. However, if I compare the advantages between clear interface and compilation time, I choose the first one. >> What I remark here, it is to have a clear and identical interface among >> the several SOCs. This is not only easier for board developers, but also >> removes some nasty #ifdef CONFIG_MX from the drivers. > > Yes, I understand. btw there's no CONFIG_MX stuff. Not yet, but only because you are adding a new SOC without using IMX drivers. Things will be changed when the MX23 will be added. Or some newer SOC of the mxs family will be added by Freescale. Once we had only the MX31. Drivers were done only for this SOC. After using the same driver with different SOCs, a lot of CONFIG_MX was added, and most of code was really not readable - and it tooks time to remove most of them. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/31] iMX28: Initial support for iMX28 CPU
On Friday, September 09, 2011 12:29:01 PM Stefano Babic wrote: > On 09/09/2011 12:12 PM, Marek Vasut wrote: > >> Another general remark here: we tend to have the same structure and the > >> same files for all IMX SOC. This means that all IMX SOC have a > >> imx-regs.h that contain the required register definitions (really a > >> subset what we have in kernel). Is it really necessary to split the > >> definitions in several small files ? > > > > Just like Heiko said ... it'd produce terribly big and messy file. I'd > > prefer to avoid that. > > This is ok, and it is ok also that your imx-regs.h file contains only > the reg-specific include files. What is not ok, is that you do not use > imx-regs.h and you still includes each separate file. And as I see, they > must be included in a specific order. I patched the reg definition files. This should be solved. > > This order must be defined only in imx-regs.h, as you have already done > and then each driver/board requires to include only imx-regs.h, without > having to care of the single files. Ok > > > Honestly, I need to check if the file is used at all. We replaced the > > original driver with pl011 driver. > > Ok > > >> Again, regarding file splitting for register. If you prefer to have > >> several files, I think it is better that imx-regs.h include them. Then > >> we have still a common header imx-regs.h that contains all needed > >> register definitions. This is a better interface for a board maintainer. > > > > Won't it make the compiler slower at compile time if it has to go through > > all of the included files instead of a subset ? > > Well, I do not know if on our Intel-PC this makes a so noticeable > difference ;-) It's a point-of-view question, really. But what about people compiling stuff on slower machines ? > > What I remark here, it is to have a clear and identical interface among > the several SOCs. This is not only easier for board developers, but also > removes some nasty #ifdef CONFIG_MX from the drivers. Yes, I understand. btw there's no CONFIG_MX stuff. > > >> To understand: does a reset mean on the i.MX28 a power off ? Do you turn > >> off the power ? If this is the case, some features are not possible (as > >> PRAM, for example) on this SOC. > > > > This should just reset the chip. No poweroff. > > Ok - thanks for clarification. > > > I'll probably wait for someone to clearly say how this should be to avoid > > reworking it for the fourth time. > > Right. > > Best regards, > Stefano Babic Cheers ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/31] iMX28: Initial support for iMX28 CPU
On 09/09/2011 12:12 PM, Marek Vasut wrote: >> >> Another general remark here: we tend to have the same structure and the >> same files for all IMX SOC. This means that all IMX SOC have a >> imx-regs.h that contain the required register definitions (really a >> subset what we have in kernel). Is it really necessary to split the >> definitions in several small files ? > > Just like Heiko said ... it'd produce terribly big and messy file. I'd prefer > to > avoid that. This is ok, and it is ok also that your imx-regs.h file contains only the reg-specific include files. What is not ok, is that you do not use imx-regs.h and you still includes each separate file. And as I see, they must be included in a specific order. This order must be defined only in imx-regs.h, as you have already done and then each driver/board requires to include only imx-regs.h, without having to care of the single files. > Honestly, I need to check if the file is used at all. We replaced the > original > driver with pl011 driver. Ok >> Again, regarding file splitting for register. If you prefer to have >> several files, I think it is better that imx-regs.h include them. Then >> we have still a common header imx-regs.h that contains all needed >> register definitions. This is a better interface for a board maintainer. > > Won't it make the compiler slower at compile time if it has to go through all > of > the included files instead of a subset ? Well, I do not know if on our Intel-PC this makes a so noticeable difference ;-) What I remark here, it is to have a clear and identical interface among the several SOCs. This is not only easier for board developers, but also removes some nasty #ifdef CONFIG_MX from the drivers. >> >> To understand: does a reset mean on the i.MX28 a power off ? Do you turn >> off the power ? If this is the case, some features are not possible (as >> PRAM, for example) on this SOC. > > This should just reset the chip. No poweroff. Ok - thanks for clarification. > > I'll probably wait for someone to clearly say how this should be to avoid > reworking it for the fourth time. Right. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] some USB cleanup on EfikaMX
On 09/08/2011 11:06 PM, Jana Rapava wrote: > --- a/board/efikamx/efikamx-usb.c > +++ b/board/efikamx/efikamx-usb.c > @@ -154,6 +154,7 @@ void efika_usb_phy_reset(void) > gpio_set_value(IOMUX_TO_GPIO(MX51_PIN_EIM_D27), 1); > } Hi Jana, Wolfgang has already addressed most of the issues in your patch. Some further comments from my site: > > - tmp = readl(OTG_BASE_ADDR + 0x80c); > - tmp &= ~0x3; > - tmp |= 0x1; > - writel(tmp, OTG_BASE_ADDR + 0x80c); > + tmp = readl(OTG_BASE_ADDR + MX51_PHY_CTRL1_OFFSET); > + tmp &= ~0x3; /* make sure bits 0 and 1 are set to zero */ The comment adds no information - we already know that bits 0 and 1 are set to 0, but we do not still know why. Substitute this comment with an explanation about the meaning of the bits and the *reason* they must be 0. Or set defines as you have already done in the rest of the file. > + tmp &= ~(MX51_H2_ULPI_IE_BIT | MX51_H2_WUE_BIT); > + //Host 2 VBUS enable controlled by Host 2 controller Do not use C++ comments. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/31] iMX28: Initial support for iMX28 CPU
On Friday, September 09, 2011 10:23:09 AM Stefano Babic wrote:
> On 09/08/2011 10:42 PM, Marek Vasut wrote:
> > This patch supports:
> > - Timers
> > - Debug UART
> > - Clock
>
> Hi Marek,
>
> a general remark. It seems to me that your patchset comes directly from
> your development, as it looks like what I normally have when I develop a
> new board ;-)
>
> However, to put into mainline and to make review easier, because this is
> a porting to a new SOC, I am expecting that all patches related to a new
> file are squashed together. It makes no sense to have several patches
> regarding, for example, m28evk.h, because this is a new file.
Done, I'll retest and send V2 of the series
>
> Another general remark here: we tend to have the same structure and the
> same files for all IMX SOC. This means that all IMX SOC have a
> imx-regs.h that contain the required register definitions (really a
> subset what we have in kernel). Is it really necessary to split the
> definitions in several small files ?
Just like Heiko said ... it'd produce terribly big and messy file. I'd prefer
to
avoid that.
>
> > Signed-off-by: Marek Vasut
> > Cc: Stefano Babic
> > Cc: Wolfgang Denk
> > Cc: Detlev Zundel
> > ---
> >
> > arch/arm/cpu/arm926ejs/mx28/Makefile | 46 +++
> > arch/arm/cpu/arm926ejs/mx28/clock.c | 359
> > ++ arch/arm/cpu/arm926ejs/mx28/mx28.c|
> > 131
> > arch/arm/cpu/arm926ejs/mx28/timer.c | 143 +
> > arch/arm/include/asm/arch-mx28/clock.h| 48 +++
> > arch/arm/include/asm/arch-mx28/imx-regs.h | 33 ++
> > arch/arm/include/asm/arch-mx28/mx28.h | 30 ++
> > arch/arm/include/asm/arch-mx28/regs-base.h| 88 ++
> > arch/arm/include/asm/arch-mx28/regs-clkctrl.h | 308 +++
> > arch/arm/include/asm/arch-mx28/regs-common.h | 66
> > arch/arm/include/asm/arch-mx28/regs-power.h | 409
> > + arch/arm/include/asm/arch-mx28/regs-ssp.h
> > | 345 +
> > arch/arm/include/asm/arch-mx28/regs-timrot.h | 167 ++
> > arch/arm/include/asm/arch-mx28/regs-uartdbg.h | 182 +++ 14
> > files changed, 2355 insertions(+), 0 deletions(-)
> > create mode 100644 arch/arm/cpu/arm926ejs/mx28/Makefile
> > create mode 100644 arch/arm/cpu/arm926ejs/mx28/clock.c
> > create mode 100644 arch/arm/cpu/arm926ejs/mx28/mx28.c
> > create mode 100644 arch/arm/cpu/arm926ejs/mx28/timer.c
> > create mode 100644 arch/arm/include/asm/arch-mx28/clock.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/imx-regs.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/mx28.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-base.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-clkctrl.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-common.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-power.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-ssp.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-timrot.h
> > create mode 100644 arch/arm/include/asm/arch-mx28/regs-uartdbg.h
>
> regs-uartdbg.h is used only by the driver, right ? The driver should be
> in the driver directory, and also its header. See drivers/serial/
Honestly, I need to check if the file is used at all. We replaced the original
driver with pl011 driver.
>
> > +
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
>
> Again, regarding file splitting for register. If you prefer to have
> several files, I think it is better that imx-regs.h include them. Then
> we have still a common header imx-regs.h that contains all needed
> register definitions. This is a better interface for a board maintainer.
Won't it make the compiler slower at compile time if it has to go through all
of
the included files instead of a subset ?
>
> > +
> > +/* The PLL frequency is always 480MHz, see section 10.2 in iMX28
> > datasheet. */ +#define PLL_FREQ_KHZ48
> > +#definePLL_FREQ_COEF 18
> > +/* The XTAL frequency is always 24MHz, see section 10.2 in iMX28
> > datasheet. */ +#define XTAL_FREQ_KHZ 24000
> > +
> > +#definePLL_FREQ_MHZ(PLL_FREQ_KHZ / 1000)
> > +#defineXTAL_FREQ_MHZ (XTAL_FREQ_KHZ / 1000)
> > +
> > +uint32_t mx28_get_pclk(void)
>
> This function must be static.
>
[...]
Fixed all the stuff
> > +/* Lowlevel init isn't used on i.MX28, so just have a dummy here */
> > +inline void lowlevel_init(void) {}
>
> Ok.
>
> > +
> > +void reset_cpu(ulong ignored) __attribute__((noreturn));
> > +
> > +void reset_cpu(ulong ignored)
> > +{
> > + struct mx28_clkctrl_regs *clkctrl_regs =
> > + (struct mx28_clkctrl_regs *)MXS_CLKCTRL_BASE;
> > + struct mx28_power_regs *power_regs =
> > + (struct mx28_power_regs *)MXS_POWER_BASE;
> > +
> > + writel(0, &power_regs->hw_power_charge);
>
[U-Boot] MPC512x FEC/MII
Hi all,
I have recently updated the U-Boot on one of our MPC512x-based boards from
2009.11 (+some patches) to a current u-boot build and noticed that the git
commit 525856d59910c72687ab6201f39cdf1c04cfc15 apparenty broke the mii
commands (see below) on this board. The patch moved PHY initialization from
probe into init routine. The mii read commands return zero values regardless of
previous FEC usage. Has anyone else come across similar behavior?
Thanks a lot,
Kolja
/* with git commit 525856d59910c72687ab6201f39cdf1c04cfc15 */
EM10A=> mii i
PHY 0x00: OUI = 0x, Model = 0x00, Rev = 0x00, 10baseT, HDX
PHY 0x01: OUI = 0x, Model = 0x00, Rev = 0x00, 10baseT, HDX
PHY 0x02: OUI = 0x, Model = 0x00, Rev = 0x00, 10baseT, HDX
PHY 0x03: OUI = 0x, Model = 0x00, Rev = 0x00, 10baseT, HDX
/* snip */
/* without git commit 525856d59910c72687ab6201f39cdf1c04cfc15 */
EM10A=> mii i
PHY 0x00: OUI = 0x0885, Model = 0x11, Rev = 0x03, 100baseT, FDX
PHY 0x01: OUI = 0x0885, Model = 0x11, Rev = 0x03, 100baseT, FDX
=== modified file 'drivers/net/mpc512x_fec.c'
--- drivers/net/mpc512x_fec.c 2010-05-03 21:52:48 +
+++ drivers/net/mpc512x_fec.c 2010-05-03 21:52:48 +
@@ -160,7 +160,7 @@
}
//
-static void mpc512x_fec_set_hwaddr (mpc512x_fec_priv *fec, char *mac)
+static void mpc512x_fec_set_hwaddr (mpc512x_fec_priv *fec, unsigned char *mac)
{
u8 currByte;/* byte for which to compute the CRC */
int byte; /* loop - counter */
@@ -226,6 +226,12 @@
printf ("mpc512x_fec_init... Begin\n");
#endif
+ mpc512x_fec_set_hwaddr (fec, dev->enetaddr);
+ out_be32(&fec->eth->gaddr1, 0x);
+ out_be32(&fec->eth->gaddr2, 0x);
+
+ mpc512x_fec_init_phy (dev, bis);
+
/* Set interrupt mask register */
out_be32(&fec->eth->imask, 0x);
@@ -611,8 +617,6 @@
volatile immap_t *im = (immap_t *) CONFIG_SYS_IMMR;
mpc512x_fec_priv *fec;
struct eth_device *dev;
- int i;
- char *tmp, *end, env_enetaddr[6];
void * bd;
fec = (mpc512x_fec_priv *) malloc (sizeof(*fec));
@@ -663,25 +667,6 @@
*/
out_be32(&fec->eth->ievent, 0x);
- /*
-* Try to set the mac address now. The fec mac address is
-* a garbage after reset. When not using fec for booting
-* the Linux fec driver will try to work with this garbage.
-*/
- tmp = getenv ("ethaddr");
- if (tmp) {
- for (i=0; i<6; i++) {
- env_enetaddr[i] = tmp ? simple_strtoul (tmp, &end, 16)
: 0;
- if (tmp)
- tmp = (*end) ? end+1 : end;
- }
- mpc512x_fec_set_hwaddr (fec, env_enetaddr);
- out_be32(&fec->eth->gaddr1, 0x);
- out_be32(&fec->eth->gaddr2, 0x);
- }
-
- mpc512x_fec_init_phy (dev, bis);
-
return 1;
}
Kolja Schneider, Software Design
MEN Mikro Elektronik GmbH
Neuwieder Straße 5-7
90411 Nürnberg, Germany
Phone +49-911-99 33 5-251
Fax +49-911-99 33 5-910
kolja.schnei...@men.de
www.men.de
MEN Mikro Elektronik GmbH - Manfred Schmitz (CTO), Udo Fuchs (CFO) -
Handelsregister/Trade Register AG Nürnberg HRB 5540
Please consider the environment before printing this e-mail
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] ARM: hawkboard_nand: fix compilation of nand_spl
get_ram_size() is called, but memsize.c is not compiled. Signed-off-by: Stefano Babic --- nand_spl/board/davinci/da8xxevm/Makefile | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile index b3f4bd6..c82f6c6 100644 --- a/nand_spl/board/davinci/da8xxevm/Makefile +++ b/nand_spl/board/davinci/da8xxevm/Makefile @@ -36,9 +36,20 @@ LDFLAGS := -T $(nandobj)u-boot.lds -Ttext $(CONFIG_SYS_TEXT_BASE) $(LDFLAGS) \ AFLAGS += -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL CFLAGS += -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL -SOBJS = start.o _udivsi3.o _divsi3.o -COBJS = cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o \ - misc.o hawkboard_nand_spl.o nand_boot.o +SOBJS = _divsi3.o \ + _udivsi3.o \ + start.o + +COBJS = cpu.o \ + davinci_nand.o \ + davinci_pinmux.o \ + div0.o \ + hawkboard_nand_spl.o \ + memsize.o \ + misc.o \ + nand_boot.o \ + ns16550.o \ + psc.o SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) @@ -125,6 +136,10 @@ $(obj)psc.c: @rm -f $@ ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@ +# from comon directory +$(obj)memsize.c: + @rm -f $@ + ln -s $(TOPDIR)/common/memsize.c $@ # -- 1.7.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
On 09/09/2011 11:23 AM, Stefano Babic wrote: > get_ram_size() is called, but memsize.c is not compiled. > > Signed-off-by: Stefano Babic > --- Sorry, forget it. I sent again V1 of the patch... Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
get_ram_size() is called, but memsize.c is not compiled. Signed-off-by: Stefano Babic --- nand_spl/board/davinci/da8xxevm/Makefile |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/nand_spl/board/davinci/da8xxevm/Makefile b/nand_spl/board/davinci/da8xxevm/Makefile index b3f4bd6..65ed055 100644 --- a/nand_spl/board/davinci/da8xxevm/Makefile +++ b/nand_spl/board/davinci/da8xxevm/Makefile @@ -38,7 +38,7 @@ CFLAGS+= -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL SOBJS = start.o _udivsi3.o _divsi3.o COBJS = cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o \ - misc.o hawkboard_nand_spl.o nand_boot.o + misc.o hawkboard_nand_spl.o nand_boot.o memsize.o SRCS := $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c)) OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) @@ -125,6 +125,10 @@ $(obj)psc.c: @rm -f $@ ln -s $(TOPDIR)/arch/arm/cpu/arm926ejs/davinci/psc.c $@ +# from comon directory +$(obj)memsize.c: + @rm -f $@ + ln -s $(TOPDIR)/common/memsize.c $@ # -- 1.7.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 05/11] FEC: Allow selection of MII mode via CONFIG_FEC_XCV_TYPE
On Friday, September 09, 2011 02:48:46 AM Mike Frysinger wrote:
> On Thursday, September 08, 2011 16:37:16 Marek Vasut wrote:
> > --- a/drivers/net/fec_mxc.c
> > +++ b/drivers/net/fec_mxc.c
> > @@ -38,6 +38,10 @@ DECLARE_GLOBAL_DATA_PTR;
> >
> > #error "CONFIG_MII has to be defined!"
> > #endif
> >
> > +#ifndefCONFIG_FEC_XCV_TYPE
> > +#defineCONFIG_FEC_XCV_TYPE MII100
> > +#endif
> > +
> >
> > #undef DEBUG
> >
> > struct nbuf {
> >
> > @@ -711,7 +715,7 @@ static int fec_probe(bd_t *bd)
> >
> > fec->eth = (struct ethernet_regs *)IMX_FEC_BASE;
> > fec->bd = bd;
> >
> > - fec->xcv_type = MII100;
> > + fec->xcv_type = CONFIG_FEC_XCV_TYPE;
>
> shouldnt this be a parameter to fec_probe() ?
> -mike
We plan to add a driver model eventually. Until then, let's not polute this
more
than necessary.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
On 09/09/2011 09:36 AM, Wolfgang Denk wrote: > Dear Stefano Babic, > > In message <1315552622-27566-1-git-send-email-sba...@denx.de> you wrote: >> get_ram_size() is called, but memsize.c is not compiled. >> >> Signed-off-by: Stefano Babic >> --- >> nand_spl/board/davinci/da8xxevm/Makefile |6 +- >> 1 files changed, 5 insertions(+), 1 deletions(-) >> >> diff --git a/nand_spl/board/davinci/da8xxevm/Makefile >> b/nand_spl/board/davinci/da8xxevm/Makefile >> index b3f4bd6..65ed055 100644 >> --- a/nand_spl/board/davinci/da8xxevm/Makefile >> +++ b/nand_spl/board/davinci/da8xxevm/Makefile >> @@ -38,7 +38,7 @@ CFLAGS += -DCONFIG_SPL_BUILD -DCONFIG_NAND_SPL >> >> SOBJS = start.o _udivsi3.o _divsi3.o >> COBJS = cpu.o davinci_nand.o ns16550.o div0.o davinci_pinmux.o psc.o >> \ >> -misc.o hawkboard_nand_spl.o nand_boot.o >> +misc.o hawkboard_nand_spl.o nand_boot.o memsize.o > > Please split these litst (one object name per line), and sort them. Ok. > >> +# from comon directory >> +$(obj)memsize.c: >> +@rm -f $@ >> +ln -s $(TOPDIR)/common/memsize.c $@ > > Can we not rather compile the file in the common directory instead? This is only for nand_spl, not for u-boot. The nand_spl/board/Makefile has the list of files that must be compiled. Of course, the file was already compiled in common for u-boot.bin. Not sure why this issue appears now. Rebuilding all ARM boards I see that hawkboard is broken, I have not bisect to check when it happened. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 28/31] iMX28: Add image header generator tool
On 09/08/2011 10:42 PM, Marek Vasut wrote: > This tool can now generate proper image for "BootStream" files. > > NOTE: This tool now works only for NAND. > Hi Marek, I have not reviewed your patch. Before starting, I have a big remark. This is *not* the way we are implementing in u-boot to add SOC related images. Instead of having a special tool for each SOC, we are adding new functions to mkimage to support all SOCs we have. mkimage is able now to generate images for several SOCs. You have implemented a completely different one. Why ? Why cannot we add a new image type to mkimage ? Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Intialisation of Interrupts
Hi Graeme, I was going through the U-boot code. Could you please help me with the following? I wanted to know as to where the CPU interrupts are initialised. I believe it should be along with the CPU initialisation and before the northbridge and southbridge intialisation. I wanted to implement a logic to read the state of a GPIO pin and carry out some action based on this key press. I want to do this before the Bootloader is invoked. Regards, Flash ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/31] iMX28: Initial support for iMX28 CPU
Hello Stefano, Stefano Babic wrote: > On 09/08/2011 10:42 PM, Marek Vasut wrote: >> This patch supports: >> - Timers >> - Debug UART >> - Clock > > Hi Marek, > > a general remark. It seems to me that your patchset comes directly from > your development, as it looks like what I normally have when I develop a > new board ;-) I also tend to do such things ;-) > However, to put into mainline and to make review easier, because this is > a porting to a new SOC, I am expecting that all patches related to a new > file are squashed together. It makes no sense to have several patches > regarding, for example, m28evk.h, because this is a new file. Yep, for new files, it makes sense to make only one patch. > Another general remark here: we tend to have the same structure and the > same files for all IMX SOC. This means that all IMX SOC have a > imx-regs.h that contain the required register definitions (really a > subset what we have in kernel). Is it really necessary to split the > definitions in several small files ? Hmm... is this really a good thing? If I look in the statistic below, this results in a big (lines > 1000) file ... I don;t like such big files, but this is just a personal taste ... > >> Signed-off-by: Marek Vasut >> Cc: Stefano Babic >> Cc: Wolfgang Denk >> Cc: Detlev Zundel >> --- >> arch/arm/cpu/arm926ejs/mx28/Makefile | 46 +++ >> arch/arm/cpu/arm926ejs/mx28/clock.c | 359 ++ >> arch/arm/cpu/arm926ejs/mx28/mx28.c| 131 >> arch/arm/cpu/arm926ejs/mx28/timer.c | 143 + >> arch/arm/include/asm/arch-mx28/clock.h| 48 +++ >> arch/arm/include/asm/arch-mx28/imx-regs.h | 33 ++ >> arch/arm/include/asm/arch-mx28/mx28.h | 30 ++ >> arch/arm/include/asm/arch-mx28/regs-base.h| 88 ++ >> arch/arm/include/asm/arch-mx28/regs-clkctrl.h | 308 +++ >> arch/arm/include/asm/arch-mx28/regs-common.h | 66 >> arch/arm/include/asm/arch-mx28/regs-power.h | 409 >> + >> arch/arm/include/asm/arch-mx28/regs-ssp.h | 345 + >> arch/arm/include/asm/arch-mx28/regs-timrot.h | 167 ++ >> arch/arm/include/asm/arch-mx28/regs-uartdbg.h | 182 +++ bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 18/31] iMX28: Add SPI driver
On 09/08/2011 10:42 PM, Marek Vasut wrote:
> Signed-off-by: Marek Vasut
> Cc: Stefano Babic
> Cc: Wolfgang Denk
> Cc: Detlev Zundel
> ---
> drivers/spi/Makefile |1 +
> drivers/spi/mxs_spi.c | 174
> +
> 2 files changed, 175 insertions(+), 0 deletions(-)
> create mode 100644 drivers/spi/mxs_spi.c
> diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c
> new file mode 100644
> index 000..b9c2f06
> --- /dev/null
> +++ b/drivers/spi/mxs_spi.c
Ok - now I am sure and I agree with your choice. Please then use mxs
consequently in all files.
> @@ -0,0 +1,174 @@
> +/*
> + * Freescale i.MX28 SPI driver
> + *
> + * Copyright (C) 2011 Marek Vasut
> + * on behalf of DENX Software Engineering GmbH
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
General comment: drop this stuff and include only imx-regs.h
> +
> +#define MXS_SPI_MAX_TIMEOUT 100
> +
> +static inline struct mx28_ssp_regs *to_mxs_regs(struct spi_slave *slave)
> +{
> + return (struct mx28_ssp_regs *)(MXS_SSP0_BASE + (slave->bus * 0x2000));
> +}
> +
> +void spi_init(void)
> +{
> +}
> +
> +struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
> + unsigned int max_hz, unsigned int mode)
> +{
Only the CS supplied in the SOC are supported, it is not possible to use
a GPIO. Please add a comment to explain that.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
