Re: [U-Boot] [PATCH v5] serial: uartlite: Support for SERIAL_MULTI
Dear Michal Simek, In message 1317020588-12083-1-git-send-email-mon...@monstr.eu you wrote: Add support for SERIAL MULTI for uartlite. Signed-off-by: Michal Simek mon...@monstr.eu --- v2: Use in/out_be32 functions v3: Clean coding style v4: Simplify userial_ports array initialization v5: const userial_ports Do not use u32 Separate declarations and code by a single blank line Update copyright --- common/serial.c | 14 drivers/serial/serial_xuartlite.c | 140 - include/serial.h |7 ++ 3 files changed, 142 insertions(+), 19 deletions(-) This commit causes new warnings for the following boards: ml507 v5fx30teval_flash xilinx-ppc440-generic ml507_flash xilinx-ppc405-generic xilinx-ppc440-generic_f v5fx30teval xilinx-ppc405-generic_f For example: Configuring for xilinx-ppc440-generic - Board: xilinx-ppc440-generic, Options: SYS_TEXT_BASE=0x0400,RESET_VECTOR_ADDRESS=0x0410,BOOT_FROM_XMD=1 serial_xuartlite.c: In function 'uartlite_serial_putc': serial_xuartlite.c:60: warning: initialization discards qualifiers from pointer target type serial_xuartlite.c: In function 'uartlite_serial_getc': serial_xuartlite.c:78: warning: initialization discards qualifiers from pointer target type serial_xuartlite.c: In function 'uartlite_serial_tstc': serial_xuartlite.c:87: warning: initialization discards qualifiers from pointer target type Please fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There is no distinctly American criminal class except Congress. - Mark Twain ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] Move timestamp and version files into 'generated' subdir
Dear Simon Glass, In message 1318272919-17706-1-git-send-email-...@chromium.org you wrote: There is a rather subtle build problem where the build time stamp is not updated for out-of-tree builds if there exists an in-tree build which has a valid timestamp file. So if you do an in-tree build, then an out-of-tree build your timestamp will not change. ... Makefile |4 ++-- arch/arm/cpu/armv7/omap-common/spl.c |3 +-- arch/arm/cpu/armv7/omap-common/spl_mmc.c |3 +-- arch/arm/cpu/armv7/omap-common/spl_nand.c |3 +-- drivers/serial/usbtty.h |2 +- include/.gitignore|2 -- include/timestamp.h |2 +- include/version.h |2 +- 8 files changed, 8 insertions(+), 13 deletions(-) This change breaks building for the following boards: BMW MUSENKI debris CPC45 MVBLUE eXalion CPC45_ROMBOOT OXC kvme080 CU824 PN62linkstation_HGLAN HIDDEN_DRAGON Sandpoint8240 utx8245 MOUSSE Sandpoint8245 For example: + ./MAKEALL CPC45 Configuring for CPC45 board... ppc_6xx-gcc: /work/wd/tmp-ppc/arch/powerpc/cpu/mpc824x/bedbug_603e.c: No such file or directory ppc_6xx-gcc: no input files make[1]: *** No rule to make target `/work/wd/tmp-ppc/arch/powerpc/cpu/mpc824x/.depend', needed by `_depend'. Stop. Please fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Punishment becomes ineffective after a certain point. Men become in- sensitive. -- Eneg, Patterns of Force, stardate 2534.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [STATUS] Quality of patches / testing.
Hi all, the patches that have been submitted for this release turn out to of of shockingly bad quality. About every other batch of patches I apply will break building not only for a single board r a few boards, but for large numbers of boards, including whole processor families and even whole architectures. Not to mention the huge number of patches that have to be rejected because they raise tons or errors and warnings from checkpatch.pl The time I have available is limited even without such avoidable problems, and I really, really rather spend it on constructive work instead of continuously running git bisect to track down the culprits. What's even worse is that it appears that I am the only person in this whole community who runs any build tests. Or how comes that it's always me who detects such build breakages? Note # 3 at http://www.denx.de/wiki/U-Boot/Patches says: Before sending the patch, you must run the MAKEALL script on your patched source tree and make sure that no errors or warnings are reported for any of the boards. Well, at least not any more warnings than without your patch. It is strongly recommended to verify that out-of-tree building (with -O make option resp. BUILD_DIR environment variable) is still working. For example, run: $ BUILD_DIR=/tmp/u-boot-build ./MAKEALL Why is nobody doing this? I cannot continue like that. We need to find ways to improve the quality of the submitted patches, and to distribute the work load for testing. I need your help. Thanks. Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There are no data that cannot be plotted on a straight line if the axis are chosen correctly. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2 2/2] api: export LCD and video to external apps
Hi Anatolij,
Thanks for testing this patch. Please see below.
On Tue, Oct 18, 2011 at 5:13 AM, Anatolij Gustschin ag...@denx.de wrote:
Hi,
thanks for the patch and style fixes! I've some comments on it.
Please see below.
On Fri, 7 Oct 2011 16:28:12 +0800
Che-Liang Chiou clch...@chromium.org wrote:
This patch exports LCD and video information and bitmap-rendering
functions to external apps.
This patch is tested on a Seaboard, which does not have a video output.
So I only tested LCD code paths.
NOTE: The Seaboard LCD driver is not yet upstreamed; the test was done
in a local downstream repo.
Many boards defining CONFIG_LCD also define CONFIG_LCD_LOGO.
Enabling CONFIG_API for such board configurations will break
compiling, e.g.:
$ ./MAKEALL TQM823L_LCD
Configuring for TQM823L_LCD - Board: TQM823L, Options: LCD,NEC_NL6448BC20
api_display.c: In function 'display_get_info':
api_display.c:40: error: 'BMP_LOGO_HEIGHT' undeclared (first use in this
function)
api_display.c:40: error: (Each undeclared identifier is reported only once
api_display.c:40: error: for each function it appears in.)
make[1]: *** [api_display.o] Error 1
make: *** [api/libapi.o] Error 2
Any idea how to fix this issue?
BMP_LOGO_HEIGHT is defined bmp_logo.h, which is automatically
generated by tools/bmp_logo.c when CONFIG_LCD_LOGO or
CONFIG_VIDEO_LOGO is set. So I guess this is quite easy to fix. We
could include bmp_logo.h in api_display.c.
Similar problem exists for boards using cfb_console driver, e.g. enabling
CONFIG_API breaks compiling for tqm5200 board:
$ ./MAKEALL TQM5200
Configuring for TQM5200 board...
api_display.c: In function 'display_get_info':
api_display.c:47: error: 'VIDEO_VISIBLE_COLS' undeclared (first use in this
function)
api_display.c:47: error: (Each undeclared identifier is reported only once
api_display.c:47: error: for each function it appears in.)
api_display.c:48: error: 'VIDEO_VISIBLE_ROWS' undeclared (first use in this
function)
make[1]: *** [api_display.o] Error 1
make: *** [api/libapi.o] Error 2
We need to resolve these issues before committing this patch, i think.
VIDEO_VISIBLE_{COLS,ROLS} are just macros defined in cfb_console.c,
this is my mistake. I should use GraphicDevice-{winSizeX,winSizeY}
that are VIDEO_VISIBLE_{COLS,ROLS} defined upon.
Thanks,
Anatolij
Signed-off-by: Che-Liang Chiou clch...@chromium.org
---
Changes since V1
Fix style errors
api/Makefile | 3 +-
api/api.c | 51 +
api/api_display.c | 86
++
api/api_private.h | 4 ++
examples/api/demo.c | 31 ++
examples/api/glue.c | 31 ++
examples/api/glue.h | 5 +++
include/api_public.h | 16 +
include/video_font.h | 6 +++
9 files changed, 232 insertions(+), 1 deletions(-)
create mode 100644 api/api_display.c
Regards,
Che-Liang
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 7/7][v2] fsl_ifc: Add the workaround for erratum IFC A-003399(enabled on P1010)
Dear Kumar Gala, In message 1312555480-13401-8-git-send-email-ga...@kernel.crashing.org you wrote: From: Poonam Aggrwal poonam.aggr...@freescale.com Issue: Address masking doesn't work properly. When sum of the base address, defined by BA, and memory bank size, defined by AM, exceeds 4GB (0x_) then AMASKn[AM] doesn't mask CSPRn[BA] bits. Impact: This will impact booting when we are reprogramming CSPR0(BA) and AMASK0(AMASK) while executing from NOR Flash. Workaround: Re-programming of CSPR(BA) and AMASK is done while not executing from NOR Flash. The code which programs the BA and AMASK is executed from L2-SRAM. Signed-off-by: Poonam Aggrwal poonam.aggr...@freescale.com Signed-off-by: Kumar Gala ga...@kernel.crashing.org This commit introdces new build warnings for the following boards: P1010RDB_36BIT_NOR P1010RDB_NOR P1010RDB_36BIT_NOR_SECBOOT P1010RDB_NOR_SECBOOT For example: Configuring for P1010RDB_NOR - Board: P1010RDB, Options: P1010RDB cpu_init_early.c: In function 'cpu_init_early_f': cpu_init_early.c:74: warning: 'l2srbar' may be used uninitialized in this function Please fix! Kumar, Poonam - I'm really p*ssed off. Both of you have more than enough of experience to know that you should not submit untested patches. especially here, where I already had to reject this patch because it did not even pass checkpatch: I wrote in message 20110804212403.3d53221c...@gemini.denx.de: | Dear Kumar Gala, | | In message 08144324-be32-4a54-bc2d-b920f18f3...@kernel.crashing.org | you wrote: | | Kumar, could you __please__ get used to running your patches | throuch | checkpatch __before__ submitting? Thanks. | | I try to, but not all of them are by me ;) | | I know. But you submitted them, so you are responsible. This level of neglect is really disappointing. Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de 1000 pains = 1 Megahertz ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] PPC: Cleanup tqm8xx_pcmcia.c
Dear Marek Vasut, In message 1317819115-9089-1-git-send-email-marek.va...@gmail.com you wrote: Signed-off-by: Marek Vasut marek.va...@gmail.com --- drivers/pcmcia/tqm8xx_pcmcia.c | 154 +--- 1 files changed, 81 insertions(+), 73 deletions(-) This commit causes new warnings on the virtlab2 board: Configuring for virtlab2 board... tqm8xx_pcmcia.c: In function 'power_off': tqm8xx_pcmcia.c:46: warning: passing argument 1 of 'out_be32' makes pointer from integer without a cast tqm8xx_pcmcia.c: In function 'power_on_5_0': tqm8xx_pcmcia.c:52: warning: passing argument 1 of 'out_be32' makes pointer from integer without a cast tqm8xx_pcmcia.c: In function 'power_on_3_3': tqm8xx_pcmcia.c:58: warning: passing argument 1 of 'out_be32' makes pointer from integer without a cast Why did you not run MAKEALL??? Please fix! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Brain fried - Core dumped ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
Hi Wolfgang, On 10/18/2011 08:23 AM, Wolfgang Denk wrote: [SNIP] Why is nobody doing this? One of my big problems with this was that you not only have to run a MAKEALL with your own changes but also have to do that with the former state of the repo to identifie the differences. So one suggestion I have is to do at least a reference build of each custodian repo and store the output somewhere so one can diff with these. [SNIP] Regards Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V2] examples: api: allow build with private libgcc
The examples/api is not configured with USE_PRIVATE_LIBGCC. This makes
building examples/api break on certain boards that do not/cannot use the
public libgcc.
Nevertheless, this patch has to also touch the top-level Makefile to fix
this problem because the current top-level Makefile does not specify
libgcc as a prerequisite of examples/api, and explicitly builds
examples/api _before_ libgcc.
For testing this patch, I added the following to configs/seaboard.h and
ran demo.bin on a Seaboard.
+#define CONFIG_API
+#define CONFIG_SYS_MMC_MAX_DEVICE 2
+#define CONFIG_CMD_NET
+#define CONFIG_NET_MULTI
Signed-off-by: Che-Liang Chiou clch...@chromium.org
Acked-by: Mike Frysinger vap...@gentoo.org
---
Changes in V2
Rebase to ToT
Makefile | 18 +-
examples/api/Makefile |4 +---
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/Makefile b/Makefile
index e9d75f8..26956ae 100644
--- a/Makefile
+++ b/Makefile
@@ -141,7 +141,10 @@ unexport CDPATH
# is yes), so compile examples after U-Boot is compiled.
SUBDIR_TOOLS = tools
SUBDIR_EXAMPLES = examples/standalone examples/api
-SUBDIRS = $(SUBDIR_TOOLS) $(SUBDIR_EXAMPLES)
+SUBDIRS = $(SUBDIR_TOOLS)
+ifndef CONFIG_SANDBOX
+SUBDIRS += $(SUBDIR_EXAMPLES)
+endif
.PHONY : $(SUBDIRS) $(VERSION_FILE) $(TIMESTAMP_FILE)
@@ -158,11 +161,6 @@ sinclude $(obj)include/autoconf.mk
include $(obj)include/config.mk
export ARCH CPU BOARD VENDOR SOC
-ifndef CONFIG_SANDBOX
-SUBDIRS += examples/standalone \
- examples/api
-endif
-
# set default to nothing for native builds
ifeq ($(HOSTARCH),$(ARCH))
CROSS_COMPILE ?=
@@ -359,7 +357,7 @@ ONENAND_BIN ?= $(obj)onenand_ipl/onenand-ipl-2k.bin
ALL-$(CONFIG_MMC_U_BOOT) += $(obj)mmc_spl/u-boot-mmc-spl.bin
ALL-$(CONFIG_SPL) += $(obj)spl/u-boot-spl.bin
-all: $(ALL-y)
+all: $(ALL-y) $(SUBDIR_EXAMPLES)
$(obj)u-boot.hex: $(obj)u-boot
$(OBJCOPY) ${OBJCFLAGS} -O ihex $ $@
@@ -422,7 +420,7 @@ GEN_UBOOT = \
endif
$(obj)u-boot: depend \
- $(SUBDIRS) $(OBJS) $(LIBBOARD) $(LIBS) $(LDSCRIPT)
$(obj)u-boot.lds
+ $(SUBDIR_TOOLS) $(OBJS) $(LIBBOARD) $(LIBS) $(LDSCRIPT)
$(obj)u-boot.lds
$(GEN_UBOOT)
ifeq ($(CONFIG_KALLSYMS),y)
smap=`$(call SYSTEM_MAP,u-boot) | \
@@ -435,7 +433,7 @@ endif
$(OBJS): depend
$(MAKE) -C $(CPUDIR) $(if $(REMOTE_BUILD),$@,$(notdir $@))
-$(LIBS): depend $(SUBDIRS)
+$(LIBS): depend $(SUBDIR_TOOLS)
$(MAKE) -C $(dir $(subst $(obj),,$@))
$(LIBBOARD): depend $(LIBS)
@@ -444,6 +442,8 @@ $(LIBBOARD):depend $(LIBS)
$(SUBDIRS):depend
$(MAKE) -C $@ all
+$(SUBDIR_EXAMPLES): $(obj)u-boot
+
$(LDSCRIPT): depend
$(MAKE) -C $(dir $@) $(notdir $@)
diff --git a/examples/api/Makefile b/examples/api/Makefile
index 5b5f7a6..bad05af 100644
--- a/examples/api/Makefile
+++ b/examples/api/Makefile
@@ -62,8 +62,6 @@ OBJS += $(addprefix $(obj),$(COBJ_FILES-y))
OBJS += $(addprefix $(obj),$(notdir $(EXT_COBJ_FILES-y)))
OBJS += $(addprefix $(obj),$(notdir $(EXT_SOBJ_FILES-y)))
-gcclibdir := $(shell dirname `$(CC) -print-libgcc-file-name`)
-
CPPFLAGS += -I..
all: $(obj).depend $(OUTPUT)
@@ -71,7 +69,7 @@ all: $(obj).depend $(OUTPUT)
#
$(OUTPUT): $(OBJS)
- $(LD) -Ttext $(LOAD_ADDR) -o $@ $^ -L$(gcclibdir) -lgcc
+ $(LD) -Ttext $(LOAD_ADDR) -o $@ $^ $(PLATFORM_LIBS)
$(OBJCOPY) -O binary $@ $(OUTPUT).bin 2/dev/null
# Rule to build generic library C files
--
1.7.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V2] examples: api: allow build with private libgcc
The examples/api is not configured with USE_PRIVATE_LIBGCC. This makes
building examples/api break on certain boards that do not/cannot use the
public libgcc.
Nevertheless, this patch has to also touch the top-level Makefile to fix
this problem because the current top-level Makefile does not specify
libgcc as a prerequisite of examples/api, and explicitly builds
examples/api _before_ libgcc.
For testing this patch, I added the following to configs/seaboard.h and
ran demo.bin on a Seaboard.
+#define CONFIG_API
+#define CONFIG_SYS_MMC_MAX_DEVICE 2
+#define CONFIG_CMD_NET
+#define CONFIG_NET_MULTI
Signed-off-by: Che-Liang Chiou clch...@chromium.org
Acked-by: Mike Frysinger vap...@gentoo.org
---
Sorry, please ignore the previous V2 patch. I missed to git-add a
couple of lines to that patch.
Changes in V2
Rebase to ToT
Makefile | 22 +-
examples/api/Makefile |4 +---
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/Makefile b/Makefile
index e9a153c..26956ae 100644
--- a/Makefile
+++ b/Makefile
@@ -137,7 +137,14 @@ unexport CDPATH
# The tools are needed early, so put this first
# Don't include stuff already done in $(LIBS)
-SUBDIRS= tools
+# The examples conditionally depend on U-Boot (say, when USE_PRIVATE_LIBGCC
+# is yes), so compile examples after U-Boot is compiled.
+SUBDIR_TOOLS = tools
+SUBDIR_EXAMPLES = examples/standalone examples/api
+SUBDIRS = $(SUBDIR_TOOLS)
+ifndef CONFIG_SANDBOX
+SUBDIRS += $(SUBDIR_EXAMPLES)
+endif
.PHONY : $(SUBDIRS) $(VERSION_FILE) $(TIMESTAMP_FILE)
@@ -154,11 +161,6 @@ sinclude $(obj)include/autoconf.mk
include $(obj)include/config.mk
export ARCH CPU BOARD VENDOR SOC
-ifndef CONFIG_SANDBOX
-SUBDIRS += examples/standalone \
- examples/api
-endif
-
# set default to nothing for native builds
ifeq ($(HOSTARCH),$(ARCH))
CROSS_COMPILE ?=
@@ -355,7 +357,7 @@ ONENAND_BIN ?= $(obj)onenand_ipl/onenand-ipl-2k.bin
ALL-$(CONFIG_MMC_U_BOOT) += $(obj)mmc_spl/u-boot-mmc-spl.bin
ALL-$(CONFIG_SPL) += $(obj)spl/u-boot-spl.bin
-all: $(ALL-y)
+all: $(ALL-y) $(SUBDIR_EXAMPLES)
$(obj)u-boot.hex: $(obj)u-boot
$(OBJCOPY) ${OBJCFLAGS} -O ihex $ $@
@@ -418,7 +420,7 @@ GEN_UBOOT = \
endif
$(obj)u-boot: depend \
- $(SUBDIRS) $(OBJS) $(LIBBOARD) $(LIBS) $(LDSCRIPT)
$(obj)u-boot.lds
+ $(SUBDIR_TOOLS) $(OBJS) $(LIBBOARD) $(LIBS) $(LDSCRIPT)
$(obj)u-boot.lds
$(GEN_UBOOT)
ifeq ($(CONFIG_KALLSYMS),y)
smap=`$(call SYSTEM_MAP,u-boot) | \
@@ -431,7 +433,7 @@ endif
$(OBJS): depend
$(MAKE) -C $(CPUDIR) $(if $(REMOTE_BUILD),$@,$(notdir $@))
-$(LIBS): depend $(SUBDIRS)
+$(LIBS): depend $(SUBDIR_TOOLS)
$(MAKE) -C $(dir $(subst $(obj),,$@))
$(LIBBOARD): depend $(LIBS)
@@ -440,6 +442,8 @@ $(LIBBOARD):depend $(LIBS)
$(SUBDIRS):depend
$(MAKE) -C $@ all
+$(SUBDIR_EXAMPLES): $(obj)u-boot
+
$(LDSCRIPT): depend
$(MAKE) -C $(dir $@) $(notdir $@)
diff --git a/examples/api/Makefile b/examples/api/Makefile
index 5b5f7a6..bad05af 100644
--- a/examples/api/Makefile
+++ b/examples/api/Makefile
@@ -62,8 +62,6 @@ OBJS += $(addprefix $(obj),$(COBJ_FILES-y))
OBJS += $(addprefix $(obj),$(notdir $(EXT_COBJ_FILES-y)))
OBJS += $(addprefix $(obj),$(notdir $(EXT_SOBJ_FILES-y)))
-gcclibdir := $(shell dirname `$(CC) -print-libgcc-file-name`)
-
CPPFLAGS += -I..
all: $(obj).depend $(OUTPUT)
@@ -71,7 +69,7 @@ all: $(obj).depend $(OUTPUT)
#
$(OUTPUT): $(OBJS)
- $(LD) -Ttext $(LOAD_ADDR) -o $@ $^ -L$(gcclibdir) -lgcc
+ $(LD) -Ttext $(LOAD_ADDR) -o $@ $^ $(PLATFORM_LIBS)
$(OBJCOPY) -O binary $@ $(OUTPUT).bin 2/dev/null
# Rule to build generic library C files
--
1.7.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2 2/2] api: export LCD and video to external apps
Hi, On Tue, 18 Oct 2011 14:12:59 +0800 Che-liang Chiou clch...@chromium.org wrote: ... Many boards defining CONFIG_LCD also define CONFIG_LCD_LOGO. Enabling CONFIG_API for such board configurations will break compiling, e.g.: $ ./MAKEALL TQM823L_LCD Configuring for TQM823L_LCD - Board: TQM823L, Options: LCD,NEC_NL6448BC20 api_display.c: In function 'display_get_info': api_display.c:40: error: 'BMP_LOGO_HEIGHT' undeclared (first use in this function) api_display.c:40: error: (Each undeclared identifier is reported only once api_display.c:40: error: for each function it appears in.) make[1]: *** [api_display.o] Error 1 make: *** [api/libapi.o] Error 2 Any idea how to fix this issue? BMP_LOGO_HEIGHT is defined bmp_logo.h, which is automatically generated by tools/bmp_logo.c when CONFIG_LCD_LOGO or CONFIG_VIDEO_LOGO is set. So I guess this is quite easy to fix. We could include bmp_logo.h in api_display.c. This won't work I'm afraid. bmp_logo.h is included elsewhere an including it in libapi will cause multiple definition of `bmp_logo_bitmap' and `bmp_logo_palette' compile errors. Thanks, Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3] tools/env: add posibility to inject configuration
If one wants to use fw_printenv/fw_setenv in special variants (eg compiled in
MTD parameters without configuration file) he needs to change the sources.
This patch add the posibillity to change the behaviour of fw_printenv by
defining a specific configuration header at compile time.
Signed-off-by: Andreas Bießmann biessm...@corscience.de
---
total: 0 errors, 0 warnings, 134 lines checked
0001-tools-env-add-posibility-to-inject-configuration.patch has no obvious
style problems and is ready for submission.
changes since v1:
- use ?= style in Makefile as suggested by Mike
- remove c++ style comments in header
changes since v2:
- place copied/generated fw_env_config.h in include/generated
- adopt tools/env/Makefile to new placement of fw_env_config.h
tools/env/Makefile | 15 +++--
tools/env/fw_env.h | 28 +++---
tools/env/fw_env_config.h.in | 65 ++
3 files changed, 81 insertions(+), 27 deletions(-)
create mode 100644 tools/env/fw_env_config.h.in
diff --git a/tools/env/Makefile b/tools/env/Makefile
index 28b73da..996e75d 100644
--- a/tools/env/Makefile
+++ b/tools/env/Makefile
@@ -24,12 +24,12 @@
include $(TOPDIR)/config.mk
HOSTSRCS := $(SRCTREE)/lib/crc32.c fw_env.c fw_env_main.c
-HEADERS:= fw_env.h
+HEADERS:= fw_env.h $(OBJTREE)/include/generated/fw_env_config.h
+FW_ENV_CONFIG ?= fw_env_config.h.in
# Compile for a hosted environment on the target
HOSTCPPFLAGS = -idirafter $(SRCTREE)/include \
- -idirafter $(OBJTREE)/include2 \
- -idirafter $(OBJTREE)/include \
+ -idirafter $(OBJTREE)/include/generated \
-DUSE_HOSTCC
ifeq ($(MTD_VERSION),old)
@@ -42,8 +42,15 @@ all: $(obj)fw_printenv
$(obj)fw_printenv: $(HOSTSRCS) $(HEADERS)
$(HOSTCC) $(HOSTCFLAGS_NOPED) $(HOSTLDFLAGS) -o $@ $(HOSTSRCS)
+$(OBJTREE)/include/generated/fw_env_config.h: $(FW_ENV_CONFIG)
+ @mkdir -p $(dir $@)
+ @cp -f $ $@
+
+# add additional dependency for .depend
+$(obj).depend: $(OBJTREE)/include/generated/fw_env_config.h
+
clean:
- rm -f $(obj)fw_printenv
+ rm -f $(obj)fw_printenv $(OBJTREE)/include/generated/fw_env_config.h
#
diff --git a/tools/env/fw_env.h b/tools/env/fw_env.h
index 9258c79..c237154 100644
--- a/tools/env/fw_env.h
+++ b/tools/env/fw_env.h
@@ -20,30 +20,10 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston,
* MA 02111-1307 USA
*/
+#ifndef _FW_ENV_H_
+#define _FW_ENV_H_
-/*
- * To build the utility with the run-time configuration
- * uncomment the next line.
- * See included fw_env.config sample file
- * for notes on configuration.
- */
-#define CONFIG_FILE /etc/fw_env.config
-
-#define HAVE_REDUND /* For systems with 2 env sectors */
-#define DEVICE1_NAME /dev/mtd1
-#define DEVICE2_NAME /dev/mtd2
-#define DEVICE1_OFFSET0x
-#define ENV1_SIZE 0x4000
-#define DEVICE2_OFFSET0x
-#define ENV2_SIZE 0x4000
-
-#define CONFIG_BAUDRATE115200
-#define CONFIG_BOOTDELAY 5 /* autoboot after 5 seconds */
-#define CONFIG_BOOTCOMMAND
\
- bootp;
\
- setenv bootargs root=/dev/nfs nfsroot=${serverip}:${rootpath}
\
- ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}:${hostname}::off;
\
- bootm
+#include fw_env_config.h
extern int fw_printenv(int argc, char *argv[]);
extern char *fw_getenv (char *name);
@@ -54,3 +34,5 @@ extern int fw_env_write(char *name, char *value);
extern int fw_env_close(void);
extern unsignedlong crc32 (unsigned long, const unsigned char *,
unsigned);
+
+#endif
diff --git a/tools/env/fw_env_config.h.in b/tools/env/fw_env_config.h.in
new file mode 100644
index 000..d4671f0
--- /dev/null
+++ b/tools/env/fw_env_config.h.in
@@ -0,0 +1,65 @@
+/*
+ * (C) Copyright 2002-2008
+ * Wolfgang Denk, DENX Software Engineering, w...@denx.de.
+ *
+ * (C) Copyright 2011
+ * Andreas Bießmann, Corscience GmbHCo.KG, biessm...@corscience.de
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ *
Re: [U-Boot] [PATCH V2 2/2] api: export LCD and video to external apps
Hi Anatolij, On Tue, Oct 18, 2011 at 3:17 PM, Anatolij Gustschin ag...@denx.de wrote: Hi, On Tue, 18 Oct 2011 14:12:59 +0800 Che-liang Chiou clch...@chromium.org wrote: ... Many boards defining CONFIG_LCD also define CONFIG_LCD_LOGO. Enabling CONFIG_API for such board configurations will break compiling, e.g.: $ ./MAKEALL TQM823L_LCD Configuring for TQM823L_LCD - Board: TQM823L, Options: LCD,NEC_NL6448BC20 api_display.c: In function 'display_get_info': api_display.c:40: error: 'BMP_LOGO_HEIGHT' undeclared (first use in this function) api_display.c:40: error: (Each undeclared identifier is reported only once api_display.c:40: error: for each function it appears in.) make[1]: *** [api_display.o] Error 1 make: *** [api/libapi.o] Error 2 Any idea how to fix this issue? BMP_LOGO_HEIGHT is defined bmp_logo.h, which is automatically generated by tools/bmp_logo.c when CONFIG_LCD_LOGO or CONFIG_VIDEO_LOGO is set. So I guess this is quite easy to fix. We could include bmp_logo.h in api_display.c. This won't work I'm afraid. bmp_logo.h is included elsewhere an including it in libapi will cause multiple definition of `bmp_logo_bitmap' and `bmp_logo_palette' compile errors. Thanks, Anatolij I was planning to add a 'static __attribute__((unused))' to it to avoid this problem. What do you think? Regards, Che-Liang ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 03/20] sandbox: Add architecture image support
HI Simon,
2011/10/18 Wolfgang Denk w...@denx.de:
Dear Simon Glass,
Changes in v5:
- Define IH_ARCH_DEFAULT which is now required
arch/sandbox/include/asm/u-boot.h | 3 +++
include/image.h | 1 +
2 files changed, 4 insertions(+), 0 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Sorry for late to reply your mail.
I'm doing PATCH v17 fix about NDS32 architecture against to your patches.
Ive found here you've defined IH_ARCH_SANDBOX in /include/image.h
Just wondering about don't you need to also add this into
../common/image.c in the following table?
static const table_entry_t uimage_arch[]
[deleted]
{ IH_ARCH_BLACKFIN, blackfin, Blackfin, },
{ IH_ARCH_AVR32, avr32,AVR32,},
{ -1, , , },
};
Because I'm wondering about if I need to fix this if you need to add
IH_ARCH_SANDBOX into this structure.
Thanks!
--
Best regards,
Macpaul Lin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Makefile: prevent libgcc to be linked twice
On 10/17/2011 07:25 PM, Mike Frysinger : On Monday 17 October 2011 09:41:15 Nicolas Ferre wrote: If we define USE_PRIVATE_LIBGCC, PLATFORM_LIBS is used during link. During this last link editing, libgcc may be listed twice and fail. Prevent this using filter-out in top Makefile. could you please provide more details ? libgcc should not be listed twice. I compile current u-boot with the flowing command line: make -j5 CROSS_COMPILE=arm-linux-gnueabi- USE_PRIVATE_LIBGCC=yes at91sam9m10g45ek_nandflash On an Ubuntu 11.10 with Linaro's cross-toolchain (targeting ARMv7). My SoC is an ARM926 so I use the USE_PRIVATE_LIBGCC=yes switch. This will prevent the build to take libgcc from my host but compile the u-boot embedded libgcc: everything is fine, good feature. But, here is the final link editing stage: UNDEF_SYM=`arm-linux-gnueabi-objdump -x board/atmel/at91sam9m10g45ek/libat91sam9m10g45ek.o api/libapi.o arch/arm/cpu/arm926ejs/at91/libat91.o arch/arm/cpu/arm926ejs/libarm926ejs.o arch/arm/lib/libarm.o common/libcommon.o disk/libdisk.o drivers/bios_emulator/libatibiosemu.o drivers/block/libblock.o drivers/dma/libdma.o drivers/fpga/libfpga.o drivers/gpio/libgpio.o drivers/hwmon/libhwmon.o drivers/i2c/libi2c.o drivers/input/libinput.o drivers/misc/libmisc.o drivers/mmc/libmmc.o drivers/mtd/libmtd.o drivers/mtd/nand/libnand.o drivers/mtd/onenand/libonenand.o drivers/mtd/spi/libspi_flash.o drivers/mtd/ubi/libubi.o drivers/net/libnet.o drivers/net/phy/libphy.o drivers/pci/libpci.o drivers/pcmcia/libpcmcia.o drivers/power/libpower.o drivers/rtc/librtc.o drivers/serial/libserial.o drivers/spi/libspi.o drivers/twserial/libtws.o drivers/usb/eth/libusb_eth.o drivers/usb/gadget/libusb_gadget.o drivers/usb/host/libusb_host.o drivers/usb/musb/libusb_musb.o drivers/usb/phy/libusb_phy.o dri vers/video/libvideo.o drivers/watchdog/libwatchdog.o fs/cramfs/libcramfs.o fs/ext2/libext2fs.o fs/fat/libfat.o fs/fdos/libfdos.o fs/jffs2/libjffs2.o fs/reiserfs/libreiserfs.o fs/ubifs/libubifs.o fs/yaffs2/libyaffs2.o lib/libfdt/libfdt.o lib/libgeneric.o lib/lzma/liblzma.o lib/lzo/liblzo.o lib/zlib/libz.o net/libnet.o post/libpost.o | sed -n -e 's/.*\(__u_boot_cmd_.*\)/-u\1/p'|sort|uniq`; cd /home/nferre/workspace/u-boot/u-boot-git arm-linux-gnueabi-ld -pie -T u-boot.lds -Bstatic -Ttext 0x73f0 $UNDEF_SYM arch/arm/cpu/arm926ejs/start.o --start-group api/libapi.o arch/arm/cpu/arm926ejs/at91/libat91.o arch/arm/cpu/arm926ejs/libarm926ejs.o arch/arm/lib/libarm.o common/libcommon.o disk/libdisk.o drivers/bios_emulator/libatibiosemu.o drivers/block/libblock.o drivers/dma/libdma.o drivers/fpga/libfpga.o drivers/gpio/libgpio.o drivers/hwmon/libhwmon.o drivers/i2c/libi2c.o drivers/input/libinput.o drivers/misc/libmisc.o drivers/mmc/libmmc.o drivers/mtd/libmtd.o drivers/mtd/nand /libnand.o drivers/mtd/onenand/libonenand.o drivers/mtd/spi/libspi_flash.o drivers/mtd/ubi/libubi.o drivers/net/libnet.o drivers/net/phy/libphy.o drivers/pci/libpci.o drivers/pcmcia/libpcmcia.o drivers/power/libpower.o drivers/rtc/librtc.o drivers/serial/libserial.o drivers/spi/libspi.o drivers/twserial/libtws.o drivers/usb/eth/libusb_eth.o drivers/usb/gadget/libusb_gadget.o drivers/usb/host/libusb_host.o drivers/usb/musb/libusb_musb.o drivers/usb/phy/libusb_phy.o drivers/video/libvideo.o drivers/watchdog/libwatchdog.o fs/cramfs/libcramfs.o fs/ext2/libext2fs.o fs/fat/libfat.o fs/fdos/libfdos.o fs/jffs2/libjffs2.o fs/reiserfs/libreiserfs.o fs/ubifs/libubifs.o fs/yaffs2/libyaffs2.o lib/libfdt/libfdt.o lib/libgeneric.o lib/lzma/liblzma.o lib/lzo/liblzo.o lib/zlib/libz.o net/libnet.o post/libpost.o board/atmel/at91sam9m10g45ek/libat91sam9m10g45ek.o --end-group /home/nferre/workspace/u-boot/u-boot-git/arch/arm/lib/eabi_compat.o /home/nferre/workspace/u-boot/u-boot-git/arch/arm/lib /libgcc.o /home/nferre/workspace/u-boot/u-boot-git/arch/arm/lib/libgcc.o -Map u-boot.map -o u-boot And you see that there is arch/arm/lib/libgcc.o included twice in object files that have to be linked together. I think that it is coming from the PLATFORM_LIBS variable so I modified like in my patch which solves the problem. Best regards, -- Nicolas Ferre ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v16 1/9] nds32: add header files support for nds32
Hi Wolfgang, 2011/10/12 Macpaul Lin macp...@andestech.com: Add generic header files support for nds32 architecture. Cache, ptregs, data type and other definitions are included. Signed-off-by: Macpaul Lin macp...@andestech.com Just wondering if you have comment to these patch v16. I've fixed volatiles which complained by checkpatch.pl in v16. However, now I have to fix patch v16 to patch v17 because architecture Sandbox has been add into mainline. And now I'm waiting for if Sandbox if they have more thing need to be added in common/image.c. Hope you can give comment for patch v16 hence I can to fix within patch v17. Thanks! -- Best regards, Macpaul Lin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 07/20] sandbox: Add sandbox board
HI Simon 2011/10/11 Simon Glass s...@chromium.org: This adds basic files for the sandbox board. The lds file is very simple since we can rely mostly on the linker defaults. Signed-off-by: Simon Glass s...@chromium.org --- Changes in v5: - Simplify the declaration of gd_t in sandbox's board.c board/sandbox/sandbox/Makefile | 42 + board/sandbox/sandbox/sandbox.c | 49 +++ boards.cfg | 1 + 3 files changed, 92 insertions(+), 0 deletions(-) create mode 100644 board/sandbox/sandbox/Makefile +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).o + +COBJS := $(BOARD).o + +SRCS := $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) + +$(LIB): $(obj).depend $(OBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) It has been suggested by Mike that you should use something like the following because $(AR) might broken. $(LIB):$(OBJS) $(call cmd_link_o_target, $(OBJS)) Please checkout if this help http://www.mail-archive.com/u-boot@lists.denx.de/msg59966.html Thanks. -- Best regards, Macpaul Lin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mx5 configs: CONFIG_PRIME should really be CONFIG_ETHPRIME
On 10/17/2011 08:21 PM, Wolfgang Grandegger wrote: Signed-off-by: Wolfgang Grandegger w...@denx.de --- Resend due to missing [PATCH] prefix. include/configs/mx51evk.h |2 +- include/configs/mx53ard.h |2 +- include/configs/mx53evk.h |2 +- include/configs/mx53loco.h |2 +- include/configs/mx53smd.h |2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h index 0c10870..de540e1 100644 --- a/include/configs/mx51evk.h +++ b/include/configs/mx51evk.h @@ -122,7 +122,7 @@ #define CONFIG_BOOTDELAY 3 -#define CONFIG_PRIME FEC0 +#define CONFIG_ETHPRIME FEC0 This is a bug, thanks for catching ! I wonder it was not noted before... Acked-by: Stefano Babic sba...@denx.de Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
On Tue, 18 Oct 2011 08:23:10 +0200 Wolfgang Denk w...@denx.de wrote: I need your help. I'd propose to sent result from a night build (for a respective architecture/the whole u-boot) to the u-boot mailing list. Then, in the morning (well, depends on the part of the world) a custodian or culprit of the error would know that his stuff needs to be fixed. -- Best regards, Lukasz Majewski Samsung Poland RD Center Platform Group ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] STx AMC8548: initial support for Silicon Turnkey Express AMC8548 board
- Original Message - From: Kumar Gala ga...@kernel.crashing.org On Apr 12, 2011, at 12:04 AM, Alex Dubov wrote: From: Alex Dubov oa...@yahoo.com AMC8548 is a RapidIO development board in AMC form factor, featuring MPC8548E Patch needs some minor updates to apply build with current HEAD. Please make those. I've already told Wolgang that I will probably be unable to maintain this thing anyway. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V3 0/4] api: export LCD and video to external apps
This patch set exports LCD and video clearing and bitmap-rendering on screen functions to external apps, and provides a unified interface of accessing them. Che-Liang Chiou (4): lcd: video: add clear and draw bitmap declaration tools: logo: add static and unused to bmp arrays video: add access to GraphicDevice struct api: export LCD and video to external apps api/Makefile |3 +- api/api.c | 51 + api/api_display.c | 97 + api/api_private.h |4 ++ board/eltec/mhpc/mhpc.c |7 +++ common/lcd.c | 16 --- drivers/video/ati_radeon_fb.c |5 ++ drivers/video/ct69000.c |5 ++ drivers/video/fsl_diu_fb.c|8 +++- drivers/video/mb862xx.c |5 ++ drivers/video/mb86r0xgdc.c|5 ++ drivers/video/mx3fb.c |5 ++ drivers/video/mxc_ipuv3_fb.c |5 ++ drivers/video/sed13806.c |6 +++ drivers/video/sm501.c |5 ++ drivers/video/smiLynxEM.c |5 ++ examples/api/demo.c | 31 + examples/api/glue.c | 31 + examples/api/glue.h |5 ++ include/api_public.h | 16 +++ include/lcd.h |2 + include/video.h |2 + include/video_fb.h|6 ++- include/video_font.h |6 +++ tools/bmp_logo.c |6 ++- 25 files changed, 326 insertions(+), 11 deletions(-) create mode 100644 api/api_display.c -- 1.7.3.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V3 1/4] lcd: video: add clear and draw bitmap declaration
The functions for clearing and drawing bitmaps on the screen were not
exposed publicly and are made public in this patch in preparation for
implementing the display interface of api_public.h.
Signed-off-by: Che-Liang Chiou clch...@chromium.org
---
Changes in V3
Rebase to ToT
Changes in V2
Fix style errors
common/lcd.c| 16 ++--
include/lcd.h |2 ++
include/video.h |2 ++
3 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/common/lcd.c b/common/lcd.c
index d9cb8ca..20e97b9 100644
--- a/common/lcd.c
+++ b/common/lcd.c
@@ -78,7 +78,6 @@ static inline void lcd_putc_xy (ushort x, ushort y, uchar c);
static int lcd_init (void *lcdbase);
-static int lcd_clear (cmd_tbl_t * cmdtp, int flag, int argc, char * const
argv[]);
static void *lcd_logo (void);
static int lcd_getbgcolor (void);
@@ -353,7 +352,14 @@ int drv_lcd_init (void)
}
/*--*/
-static int lcd_clear (cmd_tbl_t * cmdtp, int flag, int argc, char * const
argv[])
+static
+int do_lcd_clear(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
+{
+ lcd_clear();
+ return 0;
+}
+
+void lcd_clear(void)
{
#if LCD_BPP == LCD_MONOCHROME
/* Setting the palette */
@@ -394,12 +400,10 @@ static int lcd_clear (cmd_tbl_t * cmdtp, int flag, int
argc, char * const argv[]
console_col = 0;
console_row = 0;
-
- return (0);
}
U_BOOT_CMD(
- cls,1, 1, lcd_clear,
+ cls,1, 1, do_lcd_clear,
clear screen,
);
@@ -413,7 +417,7 @@ static int lcd_init (void *lcdbase)
lcd_ctrl_init (lcdbase);
lcd_is_enabled = 1;
- lcd_clear (NULL, 1, 1, NULL); /* dummy args */
+ lcd_clear();
lcd_enable ();
/* Initialize the console */
diff --git a/include/lcd.h b/include/lcd.h
index 0e098d9..39af14a 100644
--- a/include/lcd.h
+++ b/include/lcd.h
@@ -210,6 +210,8 @@ voidlcd_disable (void);
void lcd_putc(const char c);
void lcd_puts(const char *s);
void lcd_printf (const char *fmt, ...);
+void lcd_clear(void);
+intlcd_display_bitmap(ulong bmp_image, int x, int y);
/* Allow boards to customize the information displayed */
void lcd_show_board_info(void);
diff --git a/include/video.h b/include/video.h
index efcc682..280bb76 100644
--- a/include/video.h
+++ b/include/video.h
@@ -15,5 +15,7 @@ int video_init (void *videobase);
void video_putc (const char c);
void video_puts (const char *s);
void video_printf(const char *fmt, ...);
+void video_clear(void);
+intvideo_display_bitmap(ulong bmp_image, int x, int y);
#endif
--
1.7.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V3 2/4] tools: logo: add static and unused to bmp arrays
The generated header bmp_logo.h is useful even outside common/lcd.c for
the logo dimension. However, the problem is, the generated bmp_logo.h
cannot be included multiple times because bmp_logo_palette[] and
bmp_logo_bitmap[] are defined in the bmp_logo.h.
We may remedy this by adding
static __attribute__((unused))
to the array definitions so that bmp_logo.h can be included multiple
times, and these arrays is used in only one inclusion (lcd.c).
Signed-off-by: Che-Liang Chiou clch...@chromium.org
---
Changes in V3
Add to the patch set
tools/bmp_logo.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/bmp_logo.c b/tools/bmp_logo.c
index 47228d2..3d11284 100644
--- a/tools/bmp_logo.c
+++ b/tools/bmp_logo.c
@@ -113,7 +113,8 @@ int main (int argc, char *argv[])
error (Error allocating memory for file, fp);
/* read and print the palette information */
- printf (unsigned short bmp_logo_palette[] = {\n);
+ printf(static __attribute__((unused))
+ unsigned short bmp_logo_palette[] = {\n);
for (i=0; in_colors; ++i) {
b-palette[(int)(i*3+2)] = fgetc(fp);
@@ -137,7 +138,8 @@ int main (int argc, char *argv[])
printf (\n);
printf (};\n);
printf (\n);
- printf (unsigned char bmp_logo_bitmap[] = {\n);
+ printf(static __attribute__((unused))
+ unsigned char bmp_logo_bitmap[] = {\n);
for (i=(b-height-1)*b-width; i=0; i-=b-width) {
for (x = 0; x b-width; x++) {
b-data[(uint16_t) i + x] = (uint8_t) fgetc (fp) \
--
1.7.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V3 3/4] video: add access to GraphicDevice struct
video_hw_init() returns this struct, which is quite useful, but it is
probably not okay to call this function multiple times. So this patch
adds video_devinfo() that does nothing but return this struct.
video_devinfo() does not guarantee that this struct is initialized. It
is user's responsibility to make sure that the video device is properly
initialized.
Signed-off-by: Che-Liang Chiou clch...@chromium.org
---
Changes in V3
Add to the patch set
board/eltec/mhpc/mhpc.c |7 +++
drivers/video/ati_radeon_fb.c |5 +
drivers/video/ct69000.c |5 +
drivers/video/fsl_diu_fb.c|8 +++-
drivers/video/mb862xx.c |5 +
drivers/video/mb86r0xgdc.c|5 +
drivers/video/mx3fb.c |5 +
drivers/video/mxc_ipuv3_fb.c |5 +
drivers/video/sed13806.c |6 ++
drivers/video/sm501.c |5 +
drivers/video/smiLynxEM.c |5 +
include/video_fb.h|6 +-
12 files changed, 65 insertions(+), 2 deletions(-)
diff --git a/board/eltec/mhpc/mhpc.c b/board/eltec/mhpc/mhpc.c
index 7cca6b2..0d2c8c9 100644
--- a/board/eltec/mhpc/mhpc.c
+++ b/board/eltec/mhpc/mhpc.c
@@ -466,6 +466,13 @@ void *video_hw_init (void)
/* - */
+void *video_devinfo(void)
+{
+ return (void *)gdev;
+}
+
+/* - */
+
void video_set_lut (unsigned int index,
unsigned char r, unsigned char g, unsigned char b)
{
diff --git a/drivers/video/ati_radeon_fb.c b/drivers/video/ati_radeon_fb.c
index 4a9bd07..77509e1 100644
--- a/drivers/video/ati_radeon_fb.c
+++ b/drivers/video/ati_radeon_fb.c
@@ -770,6 +770,11 @@ void *video_hw_init(void)
return ((void *) pGD);
}
+void *video_devinfo(void)
+{
+ return (void *)ctfb;
+}
+
void video_set_lut (unsigned int index,/* color number */
unsigned char r, /* red */
unsigned char g, /* green */
diff --git a/drivers/video/ct69000.c b/drivers/video/ct69000.c
index 3db614d..660a64c 100644
--- a/drivers/video/ct69000.c
+++ b/drivers/video/ct69000.c
@@ -1176,6 +1176,11 @@ video_hw_init (void)
return ((void *) ctfb);
}
+void *video_devinfo(void)
+{
+ return (void *)ctfb;
+}
+
/***
*
* Set a RGB color in the LUT (8 bit index)
diff --git a/drivers/video/fsl_diu_fb.c b/drivers/video/fsl_diu_fb.c
index cb43904..6ed6c32 100644
--- a/drivers/video/fsl_diu_fb.c
+++ b/drivers/video/fsl_diu_fb.c
@@ -367,9 +367,10 @@ int fsl_diu_init(u16 xres, u16 yres, u32 pixel_format, int
gamma_fix)
return 0;
}
+static GraphicDevice ctfb;
+
void *video_hw_init(void)
{
- static GraphicDevice ctfb;
const char *options;
unsigned int depth = 0, freq = 0;
@@ -408,3 +409,8 @@ void *video_hw_init(void)
return ctfb;
}
+
+void *video_devinfo(void)
+{
+ return (void *)ctfb;
+}
diff --git a/drivers/video/mb862xx.c b/drivers/video/mb862xx.c
index 1a4ba82..36dbdc1 100644
--- a/drivers/video/mb862xx.c
+++ b/drivers/video/mb862xx.c
@@ -444,6 +444,11 @@ void *video_hw_init (void)
return dev;
}
+void *video_devinfo(void)
+{
+ return (void *)mb862xx;
+}
+
/*
* Set a RGB color in the LUT
*/
diff --git a/drivers/video/mb86r0xgdc.c b/drivers/video/mb86r0xgdc.c
index 345a73b..455aea3 100644
--- a/drivers/video/mb86r0xgdc.c
+++ b/drivers/video/mb86r0xgdc.c
@@ -182,3 +182,8 @@ void *video_hw_init(void)
return pGD;
}
+
+void *video_devinfo(void)
+{
+ return (void *)mb86r0x;
+}
diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
index f30deb3..4ff84c8 100644
--- a/drivers/video/mx3fb.c
+++ b/drivers/video/mx3fb.c
@@ -922,6 +922,11 @@ void *video_hw_init(void)
return (void *) panel;
}
+void *video_devinfo(void)
+{
+ return (void *)panel;
+}
+
void video_set_lut(unsigned int index, /* color number */
unsigned char r,/* red */
unsigned char g,/* green */
diff --git a/drivers/video/mxc_ipuv3_fb.c b/drivers/video/mxc_ipuv3_fb.c
index 1bee54c..fd27828 100644
--- a/drivers/video/mxc_ipuv3_fb.c
+++ b/drivers/video/mxc_ipuv3_fb.c
@@ -590,6 +590,11 @@ void *video_hw_init(void)
return (void *)panel;
}
+void *video_devinfo(void)
+{
+ return (void *)panel;
+}
+
void video_set_lut(unsigned int index, /* color number */
unsigned char r,/* red */
unsigned char g,/* green */
diff --git a/drivers/video/sed13806.c b/drivers/video/sed13806.c
index 0bf9ba6..ee7b9b9 100644
--- a/drivers/video/sed13806.c
+++ b/drivers/video/sed13806.c
@@ -108,6 +108,12 @@ void *video_hw_init (void)
return (sed13806);
}
+
+void *video_devinfo(void)
+{
+ return (void *)sed13806;
+}
+
[U-Boot] [PATCH V3 4/4] api: export LCD and video to external apps
This patch exports LCD and video information and bitmap-rendering
functions to external apps.
This patch is tested on a Seaboard, which does not have a video output.
So I only tested LCD code paths.
NOTE: The Seaboard LCD driver is not yet upstreamed; the test was done
in a local downstream repo.
Signed-off-by: Che-Liang Chiou clch...@chromium.org
---
Changes in V3
Rebase to ToT
Changes in V2
Fix style errors
api/Makefile |3 +-
api/api.c| 51 ++
api/api_display.c| 97 ++
api/api_private.h|4 ++
examples/api/demo.c | 31
examples/api/glue.c | 31
examples/api/glue.h |5 +++
include/api_public.h | 16
include/video_font.h |6 +++
9 files changed, 243 insertions(+), 1 deletions(-)
create mode 100644 api/api_display.c
diff --git a/api/Makefile b/api/Makefile
index 2a64c4d..0e99f74 100644
--- a/api/Makefile
+++ b/api/Makefile
@@ -24,7 +24,8 @@ include $(TOPDIR)/config.mk
LIB= $(obj)libapi.o
-COBJS-$(CONFIG_API) += api.o api_net.o api_storage.o api_platform-$(ARCH).o
+COBJS-$(CONFIG_API) += api.o api_display.o api_net.o api_storage.o \
+ api_platform-$(ARCH).o
COBJS := $(COBJS-y)
SRCS := $(COBJS:.o=.c)
diff --git a/api/api.c b/api/api.c
index 853f010..ddf2edd 100644
--- a/api/api.c
+++ b/api/api.c
@@ -553,6 +553,54 @@ static int API_env_enum(va_list ap)
return 0;
}
+/*
+ * pseudo signature:
+ *
+ * int API_display_get_info(int type, struct display_info *di)
+ */
+static int API_display_get_info(va_list ap)
+{
+ int type;
+ struct display_info *di;
+
+ type = (int)va_arg(ap, u_int32_t);
+ di = (struct display_info *)va_arg(ap, u_int32_t);
+ if (!di)
+ return API_EINVAL;
+
+ return display_get_info(type, di);
+}
+
+/*
+ * pseudo signature:
+ *
+ * int API_display_draw_bitmap(void *bitmap, int x, int y)
+ */
+static int API_display_draw_bitmap(va_list ap)
+{
+ ulong bitmap;
+ int x, y;
+
+ bitmap = (ulong)va_arg(ap, ulong);
+ if (!bitmap)
+ return API_EINVAL;
+ x = (int)va_arg(ap, u_int32_t);
+ y = (int)va_arg(ap, u_int32_t);
+
+ return display_draw_bitmap(bitmap, x, y);
+}
+
+/*
+ * pseudo signature:
+ *
+ * void API_display_clear(void)
+ */
+static int API_display_clear(va_list ap)
+{
+ display_clear();
+ return 0;
+}
+
static cfp_t calls_table[API_MAXCALL] = { NULL, };
/*
@@ -616,6 +664,9 @@ void api_init(void)
calls_table[API_ENV_GET] = API_env_get;
calls_table[API_ENV_SET] = API_env_set;
calls_table[API_ENV_ENUM] = API_env_enum;
+ calls_table[API_DISPLAY_GET_INFO] = API_display_get_info;
+ calls_table[API_DISPLAY_DRAW_BITMAP] = API_display_draw_bitmap;
+ calls_table[API_DISPLAY_CLEAR] = API_display_clear;
calls_no = API_MAXCALL;
debugf(API initialized with %d calls\n, calls_no);
diff --git a/api/api_display.c b/api/api_display.c
new file mode 100644
index 000..b162f7f
--- /dev/null
+++ b/api/api_display.c
@@ -0,0 +1,97 @@
+/*
+ * Copyright (c) 2011 The Chromium OS Authors.
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include common.h
+#include lcd.h
+#include video.h
+#include video_fb.h
+#include video_font.h /* Get font width and height */
+#include api_public.h
+
+/* lcd.h needs BMP_LOGO_HEIGHT to calculate CONSOLE_ROWS */
+#if defined(CONFIG_LCD_LOGO) !defined(CONFIG_LCD_INFO_BELOW_LOGO)
+#include bmp_logo.h
+#endif
+
+int display_get_info(int type, struct display_info *di)
+{
+#if defined(CONFIG_VIDEO) || defined(CONFIG_CFB_CONSOLE)
+ GraphicDevice *gdev;
+#endif
+
+ switch (type) {
+ default:
+ debug(%s: unsupport display device type: %d\n,
+ __FILE__, type);
+ return API_ENODEV;
+
+#ifdef CONFIG_LCD
+ case DISPLAY_TYPE_LCD:
+ di-pixel_width = panel_info.vl_col;
+ di-pixel_height = panel_info.vl_row;
+ di-screen_rows = CONSOLE_ROWS;
+ di-screen_cols = CONSOLE_COLS;
+ break;
+#endif
Re: [U-Boot] [STATUS] Quality of patches / testing.
Dear Simon, Am 18.10.2011 08:51, schrieb Simon Schwarz: Hi Wolfgang, On 10/18/2011 08:23 AM, Wolfgang Denk wrote: [SNIP] Why is nobody doing this? One of my big problems with this was that you not only have to run a MAKEALL with your own changes but also have to do that with the former state of the repo to identifie the differences. We should first get a state of all boards build clean for a sort of toolchains (I think arm is now at this state after a lot of tumult in the last two releases). So one suggestion I have is to do at least a reference build of each custodian repo and store the output somewhere so one can diff with these. This is some kind of CI as suggested by Lukasz Majewski. I also favor CI for fast feedback to the submitter if his change breaks something. There was already a suggestion by Graeme Russ to run checkpatch on every submitted patch. While this requires really low computing power it will produce a lot of mail overhead. The second suggestion by Graeme was to add an marker into the patch which states this patch as checkpatch-clean. If we would build some CI system with automatic build we will need even more computing power to build each patch with all/a subset of MAKEALL. Not to mention the mail overhead for clean/broken patches. Therefor some marker in the patch could do the job here again. I guess it will be doable to have some scripts/prepare-patch which runs a) git format-patch b) checkpatch on the patch c) (configurable subset of) MAKEALL on some clean tree with that patch applied d) append the results to the patch This tool would implement some kind of CI but utilize the computing power of submitter. best regards Andreas Bießmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
Dear Simon Schwarz, In message 4e9d21f8.40...@gmail.com you wrote: One of my big problems with this was that you not only have to run a MAKEALL with your own changes but also have to do that with the former state of the repo to identifie the differences. So one suggestion I have is to do at least a reference build of each custodian repo and store the output somewhere so one can diff with these. That would be a task for all custodians, then? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I'd like to meet the man who invented sex and see what he's working on now. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
Dear Andreas, In message 4e9d4552.5040...@gmail.com you wrote: We should first get a state of all boards build clean for a sort of toolchains (I think arm is now at this state after a lot of tumult in the last two releases). PowerPC has traditionally always been build-clean (all boards succeed to build, with very few [2...3] causing harmelss build warnings). Now ARM is close to that, too. MIPS has also always been building mostly fine. This is some kind of CI as suggested by Lukasz Majewski. I also favor CI for fast feedback to the submitter if his change breaks something. I'm not sure how to do that. To provide feedback to individual submitters, you would have to runn a full build cycle for each patch we apply. That would obviously be best, but I don't have machine power to do that. What I do is testing batches - say, after applying 20...30 patches, or after major changes. I have Jenkins running every night for a few selected CPU families, which already catches a number of issues, but even then it's directly pointing to a submitted patch. I guess it will be doable to have some scripts/prepare-patch which runs a) git format-patch b) checkpatch on the patch c) (configurable subset of) MAKEALL on some clean tree with that patch applied d) append the results to the patch This tool would implement some kind of CI but utilize the computing power of submitter. Sounds good. Any takers? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Drun'? 'm not drun'! You woudn' dare call m' drun' if I was sober! - Terry Pratchett, _Men at Arms_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] PPC: Cleanup tqm8xx_pcmcia.c
Dear Marek Vasut, In message 1317819115-9089-1-git-send-email-marek.va...@gmail.com you wrote: Signed-off-by: Marek Vasut marek.va...@gmail.com --- drivers/pcmcia/tqm8xx_pcmcia.c | 154 +--- 1 files changed, 81 insertions(+), 73 deletions(-) This commit causes new warnings on the virtlab2 board: Configuring for virtlab2 board... tqm8xx_pcmcia.c: In function 'power_off': tqm8xx_pcmcia.c:46: warning: passing argument 1 of 'out_be32' makes pointer from integer without a cast tqm8xx_pcmcia.c: In function 'power_on_5_0': tqm8xx_pcmcia.c:52: warning: passing argument 1 of 'out_be32' makes pointer from integer without a cast tqm8xx_pcmcia.c: In function 'power_on_3_3': tqm8xx_pcmcia.c:58: warning: passing argument 1 of 'out_be32' makes pointer from integer without a cast Why did you not run MAKEALL??? Please fix! Best regards, Wolfgang Denk Fix for this is in my patchqueue for a while now. I'm still hunting down those +/- four byte growths/decreases though. I suspect the fact that such things happens is because the optimization graph is too complicated and gcc4.2 can't cope with it anymore. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC] general ULPI support
Hi Marek, [...] Anyway, do you really need the linux ulpi code as is or can you implement more lightweight thing? Especially with respect to usb I'd like to encourage code sharing. The first USB implementation in U-Boot was such a we do it ourself thing and effectively cut us off from the hepful of bugfixes/new features that Linux saw in the meantime. Let's try to share as much as possible in such areas of complex code (with that I mean not algorithmic complexity but work-arounds and special cases). Cheers Detlev -- Man against god... God against Man... Man against nature... Nature against man... God against nature... Nature against god... a very, very funny religion. -- Zen Master D.T. Suzuki commenting on Christianity -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2] microblaze: Fix strict-aliasign rules for in_be32
readl should work with unsigned int instead of unsigned long.
Signed-off-by: Michal Simek mon...@monstr.eu
---
arch/microblaze/include/asm/io.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/microblaze/include/asm/io.h b/arch/microblaze/include/asm/io.h
index 7e190d1..187ae73 100644
--- a/arch/microblaze/include/asm/io.h
+++ b/arch/microblaze/include/asm/io.h
@@ -25,7 +25,7 @@
#define readw(addr) \
({ unsigned short __v = (*(volatile unsigned short *) (addr)); __v; })
#define readl(addr) \
- ({ unsigned long __v = (*(volatile unsigned long *) (addr)); __v; })
+ ({ unsigned int __v = (*(volatile unsigned int *) (addr)); __v; })
#define writeb(b, addr) \
(void)((*(volatile unsigned char *) (addr)) = (b))
--
1.7.5.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/2] serial: uartlite: Fix compilation warnings
Do not setup userial_ports array as const because
in uartlite_serial_putc is out_be32 which can't write
to tx_fifo if is const.
Warning log:
serial_xuartlite.c: In function 'uartlite_serial_putc':
serial_xuartlite.c:60: warning: initialization discards qualifiers from pointer
target type
serial_xuartlite.c: In function 'uartlite_serial_getc':
serial_xuartlite.c:78: warning: initialization discards qualifiers from pointer
target type
serial_xuartlite.c: In function 'uartlite_serial_tstc':
serial_xuartlite.c:87: warning: initialization discards qualifiers from pointer
target type
Signed-off-by: Michal Simek mon...@monstr.eu
---
There are several approach how to solve it in uartlite_serial_putc.
1. add retype to out_be32 function
2. retype in assignment
3. do not define userial_ports as const - used solution
---
drivers/serial/serial_xuartlite.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/serial_xuartlite.c
b/drivers/serial/serial_xuartlite.c
index 2dc6bd1..3a38f9e 100644
--- a/drivers/serial/serial_xuartlite.c
+++ b/drivers/serial/serial_xuartlite.c
@@ -40,7 +40,7 @@ struct uartlite {
unsigned int status;
};
-static const struct uartlite *userial_ports[4] = {
+static struct uartlite *userial_ports[4] = {
#ifdef XILINX_UARTLITE_BASEADDR
[0] = (struct uartlite *)XILINX_UARTLITE_BASEADDR,
#endif
--
1.7.5.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
Hi, I guess it will be doable to have some scripts/prepare-patch which runs a) git format-patch b) checkpatch on the patch I'm a bit confused. Joe Hershberger has prepared a following patch: http://patchwork.ozlabs.org/patch/119083/ Is this THE ONE checkpatch version which we shall use (including its config file)? I've used it for my patch sets and I can say that warnings like: WARNING: min() should probably be min_t(unsigned int, amount_left, mod_data.buflen) and WARNING: consider using kstrto* in preference to simple_strtoul #4358: are still present. Those are Linux kernel specific. Shall I not care about them and submit patches with non zero warnings output from checkpatch? -- Best regards, Lukasz Majewski Samsung Poland RD Center Platform Group ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] microblaze: Fix strict-aliasign rules for in_be32
readl should work with unsigned int instead of unsigned long.
Signed-off-by: Michal Simek mon...@monstr.eu
---
v2: Fix coding style issue.
---
arch/microblaze/include/asm/io.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/microblaze/include/asm/io.h b/arch/microblaze/include/asm/io.h
index 7e190d1..584cbce 100644
--- a/arch/microblaze/include/asm/io.h
+++ b/arch/microblaze/include/asm/io.h
@@ -25,7 +25,7 @@
#define readw(addr) \
({ unsigned short __v = (*(volatile unsigned short *) (addr)); __v; })
#define readl(addr) \
- ({ unsigned long __v = (*(volatile unsigned long *) (addr)); __v; })
+ ({ unsigned int __v = (*(volatile unsigned int *) (addr)); __v; })
#define writeb(b, addr) \
(void)((*(volatile unsigned char *) (addr)) = (b))
--
1.7.5.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] microblaze: Fix strict-aliasign rules for in_be32
Michal Simek wrote: readl should work with unsigned int instead of unsigned long. Signed-off-by: Michal Simek mon...@monstr.eu --- arch/microblaze/include/asm/io.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Reject - coding style issue - I was too fast. Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/5] pxa: convert pxa27x_udc to use read and write functions
Am 17.10.2011 19:31, schrieb Marek Vasut: On Monday, October 17, 2011 05:22:48 PM Stefan Herbrechtsmeier wrote: Signed-off-by: Stefan Herbrechtsmeiersherb...@cit-ec.uni-bielefeld.de CC: Marek Vasutmarek.va...@gmail.com CC: Remy Bohmerli...@bohmer.net --- Hi Stefan, this patch is awesome, I really need this one. But ... Do you plan do add support for this driver to one of the upstream boards? Can you possibly convert the register definitions to struct based access ? I can do this, but then this is the only pxa driver which use a struct for this. Regards, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] gplug: fixed build error as a result of code cleanup patch
Signed-off-by: Prafulla Wadaskar prafu...@marvell.com --- board/Marvell/gplugd/gplugd.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/board/Marvell/gplugd/gplugd.c b/board/Marvell/gplugd/gplugd.c index 42c8389..a697c19 100644 --- a/board/Marvell/gplugd/gplugd.c +++ b/board/Marvell/gplugd/gplugd.c @@ -30,6 +30,7 @@ #include common.h #include mvmfp.h +#include asm/arch/cpu.h #include asm/arch/mfp.h #include asm/arch/armada100.h #include asm/gpio.h -- 1.5.3.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
Dear Lukasz Majewski, In message 20111018122416.483205d6@lmajewski.digital.local you wrote: Joe Hershberger has prepared a following patch: http://patchwork.ozlabs.org/patch/119083/ Is this THE ONE checkpatch version which we shall use (including its config file)? It shall become it, yes. I've used it for my patch sets and I can say that warnings like: WARNING: min() should probably be min_t(unsigned int, amount_left, mod_data.buflen) and WARNING: consider using kstrto* in preference to simple_strtoul #4358: are still present. Those are Linux kernel specific. Shall I not care about them and submit patches with non zero warnings output from checkpatch? Neither one nore the other. Help adapting the checkpatch config file to our needs, so that things like simple_strtoul() don't throw such warnings in U-Boot context. Then submit zero warning patches... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de People seldom know what they want until you give them what they ask for. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] microblaze: Fix strict-aliasign rules for in_be32
Dear Michal Simek, In message 1318933530-18161-1-git-send-email-mon...@monstr.eu you wrote: readl should work with unsigned int instead of unsigned long. Please also fix the typo in the Subject: s/aliasign/aliasing/ Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Even historians fail to learn from history -- they repeat the same mistakes. -- John Gill, Patterns of Force, stardate 2534.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request for u-boot-marvell.git
Hi Albert Please kindly pull The following changes since commit 0e005ee09d3424e2780efc6895fcbfbdf7a492fa: Prafulla Wadaskar (1): Merge branch 'master' of git://git.marvell.com/mirror/denx.de/u-boot-arm into armmaster are available in the git repository at: u-boot-marvell.git master branch. Ajay Bhargav (4): SPI: Add SPI driver support for Marvell Armada100 Armada100: Add SPI support for Marvell gplugD Armada100: Add SPI flash support for Marvell gplugD Armada100: Add env storage support for Marvell gplugD Jason Cooper (1): dreamplug: initial board support. Lei Wen (5): ARM: pantheon: reduce dependence of including platform file ARM: armada100: reduce dependence of including platform file ARM: kirkwood: reduce dependence of including platform file serial: reduce include platform file for marvell chip gpio: mvmfp: reduce include platform file Michael Walle (1): kirkwood_spi: add dummy spi_init() Prafulla Wadaskar (1): gplug: fixed build error as a result of code cleanup patch MAINTAINERS |4 + arch/arm/cpu/arm926ejs/armada100/cpu.c |2 +- arch/arm/cpu/arm926ejs/armada100/dram.c |1 + arch/arm/cpu/arm926ejs/armada100/timer.c|1 + arch/arm/cpu/arm926ejs/kirkwood/cpu.c |2 + arch/arm/cpu/arm926ejs/kirkwood/dram.c |2 + arch/arm/cpu/arm926ejs/kirkwood/mpp.c |2 + arch/arm/cpu/arm926ejs/kirkwood/timer.c |1 + arch/arm/cpu/arm926ejs/pantheon/cpu.c |2 +- arch/arm/cpu/arm926ejs/pantheon/dram.c |1 + arch/arm/cpu/arm926ejs/pantheon/timer.c |1 + arch/arm/include/asm/arch-armada100/armada100.h | 120 + arch/arm/include/asm/arch-armada100/config.h|1 + arch/arm/include/asm/arch-armada100/cpu.h | 125 + arch/arm/include/asm/arch-armada100/mfp.h |6 + arch/arm/include/asm/arch-armada100/spi.h | 95 ++ arch/arm/include/asm/arch-kirkwood/config.h |1 + arch/arm/include/asm/arch-kirkwood/kirkwood.h |6 - arch/arm/include/asm/arch-pantheon/config.h |2 + arch/arm/include/asm/arch-pantheon/pantheon.h |7 - board/Marvell/aspenite/aspenite.c |1 + board/Marvell/dreamplug/Makefile| 54 ++ board/Marvell/dreamplug/dreamplug.c | 151 +++ board/Marvell/dreamplug/dreamplug.h | 42 board/Marvell/dreamplug/kwbimage.cfg| 163 board/Marvell/gplugd/gplugd.c | 13 ++ board/Marvell/guruplug/guruplug.c |1 + board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c |1 + board/Marvell/openrd/openrd.c |1 + board/Marvell/rd6281a/rd6281a.c |1 + board/Marvell/sheevaplug/sheevaplug.c |1 + board/keymile/km_arm/km_arm.c |1 + boards.cfg |1 + drivers/gpio/kw_gpio.c |1 + drivers/gpio/mvmfp.c|7 - drivers/net/mvgbe.c |2 + drivers/serial/serial.c |9 - drivers/spi/Makefile|1 + drivers/spi/armada100_spi.c | 228 +++ drivers/spi/kirkwood_spi.c |5 + drivers/usb/host/ehci-kirkwood.c|1 + include/configs/dreamplug.h | 151 +++ include/configs/gplugd.h| 19 ++- 43 files changed, 1088 insertions(+), 149 deletions(-) create mode 100644 arch/arm/cpu/arm926ejs/kirkwood/asm-offsets.s create mode 100644 arch/arm/include/asm/arch-armada100/spi.h create mode 100644 board/Marvell/dreamplug/Makefile create mode 100644 board/Marvell/dreamplug/dreamplug.c create mode 100644 board/Marvell/dreamplug/dreamplug.h create mode 100644 board/Marvell/dreamplug/kwbimage.cfg create mode 100644 drivers/spi/armada100_spi.c create mode 100644 include/configs/dreamplug.h Regards.. Prafulla . . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2 2/5] ARM: armada100: reduce dependence of including platform file
-Original Message-
From: Lei Wen [mailto:lei...@marvell.com]
Sent: Friday, October 14, 2011 8:04 PM
To: Prafulla Wadaskar; Wolfgang Denk; u-boot@lists.denx.de
Subject: [PATCH V2 2/5] ARM: armada100: reduce dependence of including
platform file
For files like the drivers/serial/serial.c, it must include the
platform file, as the CONFIG_SYS_NS16550_COM1 must reference to the
definition in the platform definition files.
Include the platform definition file in the config file, so that it
would decouple the dependence for the driver files.
Signed-off-by: Lei Wen lei...@marvell.com
---
Changelog:
V2: no change
arch/arm/cpu/arm926ejs/armada100/cpu.c |2 +-
arch/arm/cpu/arm926ejs/armada100/dram.c |1 +
arch/arm/cpu/arm926ejs/armada100/timer.c|1 +
arch/arm/include/asm/arch-armada100/armada100.h | 131
---
arch/arm/include/asm/arch-armada100/config.h|1 +
arch/arm/include/asm/arch-armada100/cpu.h | 57 ++
Hi Lei
You have not added the same set of lines to cpu.h those are removed from
armada100.h, that gives build error for gplugd board.
I have updated this patch and committed.
Regards..
Prafulla . .
board/Marvell/aspenite/aspenite.c |1 +
7 files changed, 62 insertions(+), 132 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/armada100/cpu.c
b/arch/arm/cpu/arm926ejs/armada100/cpu.c
index c21938e..14121a0 100644
--- a/arch/arm/cpu/arm926ejs/armada100/cpu.c
+++ b/arch/arm/cpu/arm926ejs/armada100/cpu.c
@@ -24,8 +24,8 @@
*/
#include common.h
+#include asm/arch/cpu.h
#include asm/arch/armada100.h
-#include asm/io.h
#define UARTCLK14745KHZ (APBC_APBCLK | APBC_FNCLK | APBC_FNCLKSEL(1))
#define SET_MRVL_ID (18)
diff --git a/arch/arm/cpu/arm926ejs/armada100/dram.c
b/arch/arm/cpu/arm926ejs/armada100/dram.c
index eacec23..8609004 100644
--- a/arch/arm/cpu/arm926ejs/armada100/dram.c
+++ b/arch/arm/cpu/arm926ejs/armada100/dram.c
@@ -24,6 +24,7 @@
*/
#include common.h
+#include asm/io.h
#include asm/arch/armada100.h
DECLARE_GLOBAL_DATA_PTR;
diff --git a/arch/arm/cpu/arm926ejs/armada100/timer.c
b/arch/arm/cpu/arm926ejs/armada100/timer.c
index 82a6d7b..fbade4b 100644
--- a/arch/arm/cpu/arm926ejs/armada100/timer.c
+++ b/arch/arm/cpu/arm926ejs/armada100/timer.c
@@ -24,6 +24,7 @@
*/
#include common.h
+#include asm/arch/cpu.h
#include asm/arch/armada100.h
/*
diff --git a/arch/arm/include/asm/arch-armada100/armada100.h
b/arch/arm/include/asm/arch-armada100/armada100.h
index a8181b6..0ed3a8e 100644
--- a/arch/arm/include/asm/arch-armada100/armada100.h
+++ b/arch/arm/include/asm/arch-armada100/armada100.h
@@ -26,13 +26,7 @@
#ifndef _ASM_ARCH_ARMADA100_H
#define _ASM_ARCH_ARMADA100_H
-#ifndef __ASSEMBLY__
-#include asm/types.h
-#include asm/io.h
-#endif /* __ASSEMBLY__ */
-
#if defined (CONFIG_ARMADA100)
-#include asm/arch/cpu.h
/* Common APB clock register bit definitions */
#define APBC_APBCLK (10) /* APB Bus Clock Enable */
@@ -69,130 +63,5 @@
#define ARMD1_APMU_BASE 0xD4282800
#define ARMD1_CPU_BASE 0xD4282C00
-/*
- * Main Power Management (MPMU) Registers
- * Refer Datasheet Appendix A.8
- */
-struct armd1mpmu_registers {
- u8 pad0[0x08 - 0x00];
- u32 fccr; /*0x0008*/
- u32 pocr; /*0x000c*/
- u32 posr; /*0x0010*/
- u32 succr; /*0x0014*/
- u8 pad1[0x030 - 0x014 - 4];
- u32 gpcr; /*0x0030*/
- u8 pad2[0x200 - 0x030 - 4];
- u32 wdtpcr; /*0x0200*/
- u8 pad3[0x1000 - 0x200 - 4];
- u32 apcr; /*0x1000*/
- u32 apsr; /*0x1004*/
- u8 pad4[0x1020 - 0x1004 - 4];
- u32 aprr; /*0x1020*/
- u32 acgr; /*0x1024*/
- u32 arsr; /*0x1028*/
-};
-
-/*
- * Application Subsystem Power Management
- * Refer Datasheet Appendix A.9
- */
-struct armd1apmu_registers {
- u32 pcr;/* 0x000 */
- u32 ccr;/* 0x004 */
- u32 pad1;
- u32 ccsr; /* 0x00C */
- u32 fc_timer; /* 0x010 */
- u32 pad2;
- u32 ideal_cfg; /* 0x018 */
- u8 pad3[0x04C - 0x018 - 4];
- u32 lcdcrc; /* 0x04C */
- u32 cciccrc;/* 0x050 */
- u32 sd1crc; /* 0x054 */
- u32 sd2crc; /* 0x058 */
- u32 usbcrc; /* 0x05C */
- u32 nfccrc; /* 0x060 */
- u32 dmacrc; /* 0x064 */
- u32 pad4;
- u32 buscrc; /* 0x06C */
- u8 pad5[0x07C - 0x06C - 4];
- u32 wake_clr; /* 0x07C */
- u8 pad6[0x090 - 0x07C - 4];
- u32 core_status;/* 0x090 */
- u32 rfsc; /* 0x094 */
- u32 imr;/* 0x098 */
- u32 irwc; /* 0x09C */
- u32 isr;/* 0x0A0 */
-
Re: [U-Boot] [PATCH V2 0/5] Marvell: reduce dependence files
-Original Message- From: Lei Wen [mailto:lei...@marvell.com] Sent: Friday, October 14, 2011 8:04 PM To: Prafulla Wadaskar; Wolfgang Denk; u-boot@lists.denx.de Subject: [PATCH V2 0/5] Marvell: reduce dependence files Changelog: V2: rebase over latest u-boot-marvell.git Lei Wen (5): ARM: pantheon: reduce dependence of including platform file ARM: armada100: reduce dependence of including platform file ARM: kirkwood: reduce dependence of including platform file serial: reduce include platform file for marvell chip gpio: mvmfp: reduce include platform file arch/arm/cpu/arm926ejs/armada100/cpu.c |2 +- arch/arm/cpu/arm926ejs/armada100/dram.c |1 + arch/arm/cpu/arm926ejs/armada100/timer.c|1 + arch/arm/cpu/arm926ejs/kirkwood/cpu.c |2 + arch/arm/cpu/arm926ejs/kirkwood/dram.c |2 + arch/arm/cpu/arm926ejs/kirkwood/mpp.c |2 + arch/arm/cpu/arm926ejs/kirkwood/timer.c |1 + arch/arm/cpu/arm926ejs/pantheon/cpu.c |2 +- arch/arm/cpu/arm926ejs/pantheon/dram.c |1 + arch/arm/cpu/arm926ejs/pantheon/timer.c |1 + arch/arm/include/asm/arch-armada100/armada100.h | 131 --- arch/arm/include/asm/arch-armada100/config.h|1 + arch/arm/include/asm/arch-armada100/cpu.h | 57 ++ arch/arm/include/asm/arch-kirkwood/config.h |1 + arch/arm/include/asm/arch-kirkwood/kirkwood.h |6 - arch/arm/include/asm/arch-pantheon/config.h |2 + arch/arm/include/asm/arch-pantheon/pantheon.h |7 -- board/Marvell/aspenite/aspenite.c |1 + board/Marvell/guruplug/guruplug.c |1 + board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c |1 + board/Marvell/openrd/openrd.c |1 + board/Marvell/rd6281a/rd6281a.c |1 + board/Marvell/sheevaplug/sheevaplug.c |1 + board/keymile/km_arm/km_arm.c |1 + drivers/gpio/kw_gpio.c |1 + drivers/gpio/mvmfp.c|7 -- drivers/net/mvgbe.c |2 + drivers/serial/serial.c |9 -- drivers/spi/kirkwood_spi.c |1 + drivers/usb/host/ehci-kirkwood.c|1 + 30 files changed, 86 insertions(+), 162 deletions(-) Applied the patch series to u-boot-marvell.git master branch Regards.. Prafulla . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] gplug: fixed build error as a result of code cleanup patch
-Original Message- From: Prafulla Wadaskar [mailto:prafu...@marvell.com] Sent: Tuesday, October 18, 2011 8:07 PM To: u-boot@lists.denx.de Cc: Lei Wen; Ashish Karkare; Prafulla Wadaskar Subject: [PATCH] gplug: fixed build error as a result of code cleanup patch Signed-off-by: Prafulla Wadaskar prafu...@marvell.com --- board/Marvell/gplugd/gplugd.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/board/Marvell/gplugd/gplugd.c b/board/Marvell/gplugd/gplugd.c index 42c8389..a697c19 100644 --- a/board/Marvell/gplugd/gplugd.c +++ b/board/Marvell/gplugd/gplugd.c @@ -30,6 +30,7 @@ #include common.h #include mvmfp.h +#include asm/arch/cpu.h #include asm/arch/mfp.h #include asm/arch/armada100.h #include asm/gpio.h -- Applied to u-boot-marvell.git master branch Regards.. Prafulla . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init()
-Original Message-
From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
On Behalf Of Michael Walle
Sent: Friday, October 07, 2011 3:54 AM
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kirkwood_spi: add dummy spi_init()
The spi_init() function is missing. Add it.
Signed-off-by: Michael Walle mich...@walle.cc
---
drivers/spi/kirkwood_spi.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
index a1c3070..8c35d5e 100644
--- a/drivers/spi/kirkwood_spi.c
+++ b/drivers/spi/kirkwood_spi.c
@@ -106,6 +106,10 @@ int spi_cs_is_valid(unsigned int bus, unsigned int
cs)
}
#endif
+void spi_init(void)
+{
+}
+
void spi_cs_activate(struct spi_slave *slave)
{
writel(readl(spireg-ctrl) | KWSPI_IRQUNMASK, spireg-ctrl);
--
1.7.2.5
Applied to u-boot-marvell.git master branch
Regards..
Prafulla . .
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] USB protocol error
Hi Sir, I am facing problem with USB UHCI protocol but my u-boot code is able to detect the connected usb decive but facing problem with communication. The below message is debuging code when I execute USB reset command. I am using u-boot-2009.01 code for PPC405GPr processor. The board design is similar to MPL MIP405T and the board consist of southbridge the usb spec is in southbridge and the usb device is accessed by PCI bus. =usb reset (Re)start USB... USB: Interrupt Line = 28, is -289406972 Interrupt Pin = 4 IO Base Address = 0xe001 scanning bus for devices... Inside usb scan devices Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Inside scan for loop Before usb alloc new device call New Device 0 Device return val from Alloc = 133928760 Inside usb else new device 1 usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 0x40 Pipe Val = 0x8083, DevNum = 0 - Root-Hub Request: Get Descriptor Root-Hub: adr: 0 cmd(8): 8006 0100 0040 Root-Hub stat 0 port1: 1a3 port2: 80 Dev-status val = 0x0 dev-act_len = 0x19 Dev max pk size = 8 set address 1 usb_control_msg: request: 0x5, requesttype: 0x0, value 0x1 index 0x0 length 0x0 Pipe Val = 0x8000, DevNum = 0 - Root-Hub Request: Set Address Root-Hub: adr: 1 cmd(8): 0005 0001 Root-Hub stat 0 port1: 1a3 port2: 80 Dev-status val = 0x0 dev-act_len = 0x0 usb_control_msg: request: 0x6, requesttype: 0x80, value 0x100 index 0x0 length 0x12 Pipe Val = 0x8180, DevNum = 1 - Root-Hub Request: Get Descriptor Root-Hub: adr: 1 cmd(8): 8006 0100 0012 Root-Hub stat 0 port1: 1a3 port2: 80 Dev-status val = 0x0 dev-act_len = 0x12 usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 0x9 Pipe Val = 0x8180, DevNum = 1 - Root-Hub Request: Get Descriptor Root-Hub: adr: 1 cmd(8): 8006 0200 0009 Root-Hub stat 0 port1: 1a3 port2: 80 Dev-status val = 0x0 dev-act_len = 0x9 usb_control_msg: request: 0x6, requesttype: 0x80, value 0x200 index 0x0 length 0x19 Pipe Val = 0x8180, DevNum = 1 - Root-Hub Request: Get Descriptor Root-Hub: adr: 1 cmd(8): 8006 0200 0019 Root-Hub stat 0 port1: 1a3 port2: 80 Dev-status val = 0x0 dev-act_len = 0x19 get_conf_no 0 Result 25, wLength 25 if 0, ep 0 ##EP epmaxpacketin[1] = 8 set configuration 1 usb_control_msg: request: 0x9, requesttype: 0x0, value 0x1 index 0x0 length 0x0 Pipe Val = 0x8100, DevNum = 1 - Root-Hub Request: Get Configuration Root-Hub: adr: 1 cmd(8): 0009 0001 Root-Hub stat 0 port1: 1a3 port2: 80 Dev-status val = 0x0 dev-act_len = 0x0 new device strings: Mfr=1, Product=0, SerialNumber=0 usb_control_msg: request: 0x6, requesttype: 0x80, value 0x300 index 0x0 length 0xFF Pipe Val = 0x8180, DevNum = 1 - Root-Hub Request: Get Descriptor Root-Hub: adr: 1 cmd(8): 8006 0300 00ff Root-Hub stat 0 port1: 1a3 port2: 80 Dev-status val = 0x0 dev-act_len = 0x4 USB device number 1 default language ID 0x409 usb_control_msg: request: 0x6, requesttype: 0x80, value 0x301 index 0x409 length 0xFF Pipe Val = 0x8180, DevNum = 1 - Root-Hub Request: Get Descriptor Root-Hub: adr: 1 cmd(8): 8006 0301 0409 00ff Root-Hub stat 0 port1: 1a3 port2: 80 Dev-status val = 0x0 dev-act_len = 0x1c Manufacturer UHCI Root Hub Product SerialNumber USB hub found usb_control_msg: request: 0x6, requesttype: 0xA0, value 0x2900 index 0x0 length 0x4 Pipe Val = 0x8180, DevNum = 1 - Root-Hub Request: Get Descriptor Class Root-Hub: adr: 1 cmd(8): a006 2900 0004 Root-Hub stat 0 port1: 1a3 port2: 80 Dev-status val = 0x0 dev-act_len = 0x4 usb_control_msg: request: 0x6, requesttype: 0xA0, value 0x2900 index 0x0 length 0x9 Pipe Val = 0x8180, DevNum = 1 - Root-Hub Request: Get Descriptor Class Root-Hub: adr: 1 cmd(8): a006 2900 0009 Root-Hub stat 0 port1: 1a3 port2: 80 Dev-status val = 0x0 dev-act_len = 0x9 2 ports detected ganged power switching standalone hub global over-current protection power on to power good time: 2ms hub controller current requirement: 0mA port 1 is not removable port 2 is removable usb_control_msg: request: 0x0, requesttype: 0xA0, value 0x0 index 0x0 length 0x4 Pipe Val = 0x8180, DevNum = 1 - Root-Hub Request: Get Status Class Root-Hub: adr: 1 cmd(8): a000 0004 Root-Hub stat 0 port1: 1a3 port2: 80 Dev-status val = 0x0 dev-act_len = 0x4 get_hub_status returned status 0,
Re: [U-Boot] [PATCH 7/7][v2] fsl_ifc: Add the workaround for erratum IFC A-003399(enabled on P1010)
On Oct 18, 2011, at 1:35 AM, Wolfgang Denk wrote: Dear Kumar Gala, In message 1312555480-13401-8-git-send-email-ga...@kernel.crashing.org you wrote: From: Poonam Aggrwal poonam.aggr...@freescale.com Issue: Address masking doesn't work properly. When sum of the base address, defined by BA, and memory bank size, defined by AM, exceeds 4GB (0x_) then AMASKn[AM] doesn't mask CSPRn[BA] bits. Impact: This will impact booting when we are reprogramming CSPR0(BA) and AMASK0(AMASK) while executing from NOR Flash. Workaround: Re-programming of CSPR(BA) and AMASK is done while not executing from NOR Flash. The code which programs the BA and AMASK is executed from L2-SRAM. Signed-off-by: Poonam Aggrwal poonam.aggr...@freescale.com Signed-off-by: Kumar Gala ga...@kernel.crashing.org This commit introdces new build warnings for the following boards: P1010RDB_36BIT_NOR P1010RDB_NOR P1010RDB_36BIT_NOR_SECBOOT P1010RDB_NOR_SECBOOT For example: Configuring for P1010RDB_NOR - Board: P1010RDB, Options: P1010RDB cpu_init_early.c: In function 'cpu_init_early_f': cpu_init_early.c:74: warning: 'l2srbar' may be used uninitialized in this function Please fix! Kumar, Poonam - I'm really p*ssed off. Both of you have more than enough of experience to know that you should not submit untested patches. especially here, where I already had to reject this patch because it did not even pass checkpatch: I wrote in message 20110804212403.3d53221c...@gemini.denx.de: | Dear Kumar Gala, | | In message 08144324-be32-4a54-bc2d-b920f18f3...@kernel.crashing.org | you wrote: | | Kumar, could you __please__ get used to running your patches | throuch | checkpatch __before__ submitting? Thanks. | | I try to, but not all of them are by me ;) | | I know. But you submitted them, so you are responsible. This level of neglect is really disappointing. Wolfgang Denk If you look at the code I have NO IDEA how to fix this for older GCC. Gripping at me about this isn't fair. I'm sure if I hack something to make gcc-4.2 happy I'm going to piss off gcc-4.6. We can't win. At some point we have to move off gcc-4.2 as the baseline compiler w/regards to warning and code generation. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 7/7][v2] fsl_ifc: Add the workaround for erratum IFC A-003399(enabled on P1010)
Kumar, Wolfgang I think this is my mistake, I did not take care of checkpatch. Please let me know , I can submit it again. Regards Poonam -Original Message- From: Kumar Gala [mailto:ga...@kernel.crashing.org] Sent: Tuesday, October 18, 2011 5:18 PM To: Wolfgang Denk Cc: u-boot@lists.denx.de; Aggrwal Poonam-B10812 Subject: Re: [U-Boot] [PATCH 7/7][v2] fsl_ifc: Add the workaround for erratum IFC A-003399(enabled on P1010) On Oct 18, 2011, at 1:35 AM, Wolfgang Denk wrote: Dear Kumar Gala, In message 1312555480-13401-8-git-send-email- ga...@kernel.crashing.org you wrote: From: Poonam Aggrwal poonam.aggr...@freescale.com Issue: Address masking doesn't work properly. When sum of the base address, defined by BA, and memory bank size, defined by AM, exceeds 4GB (0x_) then AMASKn[AM] doesn't mask CSPRn[BA] bits. Impact: This will impact booting when we are reprogramming CSPR0(BA) and AMASK0(AMASK) while executing from NOR Flash. Workaround: Re-programming of CSPR(BA) and AMASK is done while not executing from NOR Flash. The code which programs the BA and AMASK is executed from L2-SRAM. Signed-off-by: Poonam Aggrwal poonam.aggr...@freescale.com Signed-off-by: Kumar Gala ga...@kernel.crashing.org This commit introdces new build warnings for the following boards: P1010RDB_36BIT_NOR P1010RDB_NOR P1010RDB_36BIT_NOR_SECBOOT P1010RDB_NOR_SECBOOT For example: Configuring for P1010RDB_NOR - Board: P1010RDB, Options: P1010RDB cpu_init_early.c: In function 'cpu_init_early_f': cpu_init_early.c:74: warning: 'l2srbar' may be used uninitialized in this function Please fix! Kumar, Poonam - I'm really p*ssed off. Both of you have more than enough of experience to know that you should not submit untested patches. especially here, where I already had to reject this patch because it did not even pass checkpatch: I wrote in message 20110804212403.3d53221c...@gemini.denx.de: | Dear Kumar Gala, | | In message | 08144324-be32-4a54-bc2d-b920f18f3...@kernel.crashing.org | you wrote: | | Kumar, could you __please__ get used to running your patches | throuch checkpatch __before__ submitting? Thanks. | | I try to, but not all of them are by me ;) | | I know. But you submitted them, so you are responsible. This level of neglect is really disappointing. Wolfgang Denk If you look at the code I have NO IDEA how to fix this for older GCC. Gripping at me about this isn't fair. I'm sure if I hack something to make gcc-4.2 happy I'm going to piss off gcc-4.6. We can't win. At some point we have to move off gcc-4.2 as the baseline compiler w/regards to warning and code generation. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] USB protocol error
Hi, please don't send the same message over and over again. On Tuesday 18 October 2011 13:24:37 Sadashiva wrote: I am facing problem with USB UHCI protocol but my u-boot code is able to detect the connected usb decive but facing problem with communication. The below message is debuging code when I execute USB reset command. I am using u-boot-2009.01 code for PPC405GPr processor. The board design is similar to MPL MIP405T and the board consist of southbridge the usb spec is in southbridge and the usb device is accessed by PCI bus. As I already suggest in my previous mail, I strongly suggest to upgrade to the latest U-Boot version and give it another try. And you might contact the manufacturer of the MIP405 board, as I have no idea which USB controller is equipped on this board. Best regards, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] common: fix missing function pointer relocation in fixup_cmdtable()
Dear Wolfgang, On Sat, Oct 15, 2011 at 10:19 PM, Wolfgang Denk w...@denx.de wrote: Dear Daniel Schwierzeck, In message 1318522059-16182-1-git-send-email-daniel.schwierz...@googlemail.com you wrote: The command auto-completion does not work on architectures relying ... Applied, thanks. you have missed v2 of the patch. See also http://patchwork.ozlabs.org/patch/119777/ Maybe because I forgot to cc you in the second mail, sorry for that. Shall I send an updated patch? Best regards, Daniel ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/3] ARM: vexpress: move files in preparation for adding a new platform
The current ca9x4_ct_vxp platform contains support for a Versatile Express
motherboard with a quad core A9 core tile.
This patch is the first stage of making separating the Versatile Express
motherboard code and the A9 specific code, before adding support for the
dual core A5 core tile.
Signed-off-by: Ryan Harkin ryan.har...@linaro.org
---
MAINTAINERS|2 +-
board/armltd/vexpress/Makefile |2 +-
.../vexpress/{ca9x4_ct_vxp.c = vexpress_common.c} |0
boards.cfg |2 +-
.../configs/{ca9x4_ct_vxp.h = vexpress_common.h} |0
5 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index dc5a913..bc89a4e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -858,7 +858,7 @@ Hugo Villeneuve hugo.villene...@lyrtech.com
Matt Waddel matt.wad...@linaro.org
- ca9x4_ct_vxpARM ARMV7 (Quad Core)
+ vexpress_common ARM ARMV7 (Quad Core)
Prafulla Wadaskar prafu...@marvell.com
diff --git a/board/armltd/vexpress/Makefile b/board/armltd/vexpress/Makefile
index 49c4b81..cdfe70e 100644
--- a/board/armltd/vexpress/Makefile
+++ b/board/armltd/vexpress/Makefile
@@ -25,7 +25,7 @@ include $(TOPDIR)/config.mk
LIB= $(obj)lib$(BOARD).o
-COBJS := ca9x4_ct_vxp.o
+COBJS := vexpress_common.o
SRCS := $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(COBJS))
diff --git a/board/armltd/vexpress/ca9x4_ct_vxp.c
b/board/armltd/vexpress/vexpress_common.c
similarity index 100%
rename from board/armltd/vexpress/ca9x4_ct_vxp.c
rename to board/armltd/vexpress/vexpress_common.c
diff --git a/boards.cfg b/boards.cfg
index fb4c1b7..31202b8 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -154,7 +154,7 @@ edminiv2 arm arm926ejs -
LaCie
dkb arm arm926ejs -
Marvellpantheon
integratorap_cm946es arm arm946esintegrator
armltd - integratorap
integratorcp_cm946es arm arm946esintegrator
armltd - integratorcp
-ca9x4_ct_vxp arm armv7 vexpressarmltd
+vexpress_common arm armv7 vexpressarmltd
highbank arm armv7 highbank-
highbank
efikamx arm armv7 efikamx -
mx5efikamx:IMX_CONFIG=board/efikamx/imximage.cfg
mx51evk arm armv7 mx51evk
freescale mx5
mx51evk:IMX_CONFIG=board/freescale/mx51evk/imximage.cfg
diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/vexpress_common.h
similarity index 100%
rename from include/configs/ca9x4_ct_vxp.h
rename to include/configs/vexpress_common.h
--
1.7.4.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/3] ARM: vexpress: create A9 specific board config
This patch creates a new config for the A9 quad core tile that includes the generic config for the Versatile Express platform. Signed-off-by: Ryan Harkin ryan.har...@linaro.org --- MAINTAINERS |2 +- boards.cfg|2 +- include/configs/vexpress_ca9x4.h | 34 ++ include/configs/vexpress_common.h |1 - 4 files changed, 36 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index bc89a4e..c1973d3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -858,7 +858,7 @@ Hugo Villeneuve hugo.villene...@lyrtech.com Matt Waddel matt.wad...@linaro.org - vexpress_common ARM ARMV7 (Quad Core) + vexpress_ca9x4 ARM ARMV7 (Quad Core) Prafulla Wadaskar prafu...@marvell.com diff --git a/boards.cfg b/boards.cfg index 31202b8..1043e98 100644 --- a/boards.cfg +++ b/boards.cfg @@ -154,7 +154,7 @@ edminiv2 arm arm926ejs - LaCie dkb arm arm926ejs - Marvellpantheon integratorap_cm946es arm arm946esintegrator armltd - integratorap integratorcp_cm946es arm arm946esintegrator armltd - integratorcp -vexpress_common arm armv7 vexpressarmltd +vexpress_ca9x4 arm armv7 vexpressarmltd highbank arm armv7 highbank- highbank efikamx arm armv7 efikamx - mx5efikamx:IMX_CONFIG=board/efikamx/imximage.cfg mx51evk arm armv7 mx51evk freescale mx5 mx51evk:IMX_CONFIG=board/freescale/mx51evk/imximage.cfg diff --git a/include/configs/vexpress_ca9x4.h b/include/configs/vexpress_ca9x4.h new file mode 100644 index 000..f8066a2 --- /dev/null +++ b/include/configs/vexpress_ca9x4.h @@ -0,0 +1,34 @@ +/* + * (C) Copyright 2011 Linaro + * Ryan Harkin, ryan.har...@linaro.org + * + * Configuration for Versatile Express. Parts were derived from other ARM + * configurations. + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ + +#ifndef __VEXPRESS_CA9X4_H +#define __VEXPRESS_CA9X4_H + +#define CONFIG_VEXPRESS_ORIGINAL_MEMORY_MAP +#include vexpress_common.h +#define CONFIG_BOOTP_VCI_STRING U-boot.armv7.vexpress_ca9x4 + +#endif // VEXPRESS_CA9X4_H diff --git a/include/configs/vexpress_common.h b/include/configs/vexpress_common.h index 5adfe64..d37924f 100644 --- a/include/configs/vexpress_common.h +++ b/include/configs/vexpress_common.h @@ -100,7 +100,6 @@ #define CONFIG_BOOTP_HOSTNAME #define CONFIG_BOOTP_PXE #define CONFIG_BOOTP_PXE_CLIENTARCH0x100 -#define CONFIG_BOOTP_VCI_STRINGU-boot.armv7.ca9x4_ct_vxp /* Miscellaneous configurable options */ #undef CONFIG_SYS_CLKS_IN_HZ -- 1.7.4.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/3] ARM: vexpress: add support for A5 core tile
Add support for the A5 Core Tile on the Versatile Express motherboard.
Ryan Harkin (3):
ARM: vexpress: move files in preparation for adding a new platform
ARM: vexpress: create A9 specific board config
ARM: vexpress: create A5 specific board config
MAINTAINERS|3 +-
board/armltd/vexpress/Makefile |2 +-
.../vexpress/{ca9x4_ct_vxp.c = vexpress_common.c} | 29 ++-
boards.cfg |3 +-
include/configs/ca9x4_ct_vxp.h | 206 -
include/configs/vexpress_ca5x2.h | 34 +++
include/configs/vexpress_ca9x4.h | 34 +++
include/configs/vexpress_common.h | 314
8 files changed, 410 insertions(+), 215 deletions(-)
rename board/armltd/vexpress/{ca9x4_ct_vxp.c = vexpress_common.c} (90%)
delete mode 100644 include/configs/ca9x4_ct_vxp.h
create mode 100644 include/configs/vexpress_ca5x2.h
create mode 100644 include/configs/vexpress_ca9x4.h
create mode 100644 include/configs/vexpress_common.h
--
1.7.4.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/3] ARM: vexpress: create A5 specific board config
This patch creates a new config for the A5 dual core tile that includes the
generic config for the Versatile Express platform.
The generic config has been modified to provide support for the Extended
Memory Map, as used on the A5 core tile. A5 does not support the legacy
memory map.
Signed-off-by: Ryan Harkin ryan.har...@linaro.org
---
MAINTAINERS |1 +
board/armltd/vexpress/vexpress_common.c | 29 +--
boards.cfg |1 +
include/configs/vexpress_ca5x2.h| 34 +++
include/configs/vexpress_common.h | 147 +++
5 files changed, 187 insertions(+), 25 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index c1973d3..578f38e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -859,6 +859,7 @@ Hugo Villeneuve hugo.villene...@lyrtech.com
Matt Waddel matt.wad...@linaro.org
vexpress_ca9x4 ARM ARMV7 (Quad Core)
+ vexpress_ca5x2 ARM ARMV7 (Dual Core)
Prafulla Wadaskar prafu...@marvell.com
diff --git a/board/armltd/vexpress/vexpress_common.c
b/board/armltd/vexpress/vexpress_common.c
index da6f14d..df20ee9 100644
--- a/board/armltd/vexpress/vexpress_common.c
+++ b/board/armltd/vexpress/vexpress_common.c
@@ -43,8 +43,7 @@
static ulong timestamp;
static ulong lastdec;
-static struct wdt *wdt_base = (struct wdt *)WDT_BASE;
-static struct systimer *systimer_base = (struct systimer *)SYSTIMER_BASE;
+static struct systimer *systimer_base = (struct systimer *)V2M_TIMER01;
static struct sysctrl *sysctrl_base = (struct sysctrl *)SCTL_BASE;
static void flash__init(void);
@@ -154,13 +153,31 @@ static void vexpress_timer_init(void)
reset_timer_masked();
}
+int v2m_cfg_write(u32 devfn, u32 data)
+{
+ /* Configuration interface broken? */
+ u32 val;
+
+ devfn |= SYS_CFG_START | SYS_CFG_WRITE;
+
+ val = readl(V2M_SYS_CFGSTAT);
+ writel(val ~SYS_CFG_COMPLETE, V2M_SYS_CFGSTAT);
+
+ writel(data, V2M_SYS_CFGDATA);
+ writel(devfn, V2M_SYS_CFGCTRL);
+
+ do {
+ val = readl(V2M_SYS_CFGSTAT);
+ } while (val == 0);
+
+ return !!(val SYS_CFG_ERR);
+}
+
/* Use the ARM Watchdog System to cause reset */
void reset_cpu(ulong addr)
{
- writeb(WDT_EN, wdt_base-wdogcontrol);
- writel(WDT_RESET_LOAD, wdt_base-wdogload);
- while (1)
- ;
+ if (v2m_cfg_write(SYS_CFG_REBOOT | SYS_CFG_SITE_MB, 0))
+ printf(Unable to reboot\n);
}
/*
diff --git a/boards.cfg b/boards.cfg
index 1043e98..ad51b73 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -154,6 +154,7 @@ edminiv2 arm arm926ejs -
LaCie
dkb arm arm926ejs -
Marvellpantheon
integratorap_cm946es arm arm946esintegrator
armltd - integratorap
integratorcp_cm946es arm arm946esintegrator
armltd - integratorcp
+vexpress_ca5x2 arm armv7 vexpressarmltd
vexpress_ca9x4 arm armv7 vexpressarmltd
highbank arm armv7 highbank-
highbank
efikamx arm armv7 efikamx -
mx5efikamx:IMX_CONFIG=board/efikamx/imximage.cfg
diff --git a/include/configs/vexpress_ca5x2.h b/include/configs/vexpress_ca5x2.h
new file mode 100644
index 000..5998530
--- /dev/null
+++ b/include/configs/vexpress_ca5x2.h
@@ -0,0 +1,34 @@
+/*
+ * (C) Copyright 2011 Linaro
+ * Ryan Harkin, ryan.har...@linaro.org
+ *
+ * Configuration for Versatile Express. Parts were derived from other ARM
+ * configurations.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __VEXPRESS_CA5X2_h
+#define __VEXPRESS_CA5X2_h
+
+#define CONFIG_VEXPRESS_EXTENDED_MEMORY_MAP
+#include vexpress_common.h
+#define CONFIG_BOOTP_VCI_STRING U-boot.armv7.vexpress_ca5x2
+
+#endif // __VEXPRESS_CA5X2_h
diff --git a/include/configs/vexpress_common.h
b/include/configs/vexpress_common.h
index d37924f..a4ae5a8
Re: [U-Boot] [STATUS] Quality of patches / testing.
Wolfgang, On Tue, Oct 18, 2011 at 11:44:37AM +0200, Wolfgang Denk wrote: Dear Andreas, In message 4e9d4552.5040...@gmail.com you wrote: I guess it will be doable to have some scripts/prepare-patch which runs a) git format-patch b) checkpatch on the patch c) (configurable subset of) MAKEALL on some clean tree with that patch applied d) append the results to the patch This tool would implement some kind of CI but utilize the computing power of submitter. Sounds good. Any takers? I've been mulling this over, and here's my approach: 1.) modify git to add a hook in format-patch, output is dumped after the '---' and before the diff. We use this the run checkpatch.pl with our config. Our script includes a version tag of checkpatch.pl? 2.) Add a '--versioning' option to format-patch which will scan the output directory for previous versions of the patch. a.) Use the Message-Id of the first version as an In-Reply-To b.) Migrate patch changelog over from previous version, append '*** ADD CHANGELOG ENTRY HERE ***' c.) enforce [PATCH 1/7 V#] Subject line format. I think this would be more flexible, and would help many projects, not just u-boot. thx, Jason. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
On 10/18/2011 11:34 AM, Wolfgang Denk wrote: Dear Simon Schwarz, In message4e9d21f8.40...@gmail.com you wrote: One of my big problems with this was that you not only have to run a MAKEALL with your own changes but also have to do that with the former state of the repo to identifie the differences. So one suggestion I have is to do at least a reference build of each custodian repo and store the output somewhere so one can diff with these. That would be a task for all custodians, then? Yes. Or a script which does this automatically. Best regards, Wolfgang Denk Regards Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] STx AMC8548: initial support for Silicon Turnkey Express AMC8548 board
On Oct 18, 2011, at 4:02 AM, Alex Dubov wrote: - Original Message - From: Kumar Gala ga...@kernel.crashing.org On Apr 12, 2011, at 12:04 AM, Alex Dubov wrote: From: Alex Dubov oa...@yahoo.com AMC8548 is a RapidIO development board in AMC form factor, featuring MPC8548E Patch needs some minor updates to apply build with current HEAD. Please make those. I've already told Wolgang that I will probably be unable to maintain this thing anyway. Ok, will consider it dropped - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
Of course, I had another idea _after_ I hit send... On Tue, Oct 18, 2011 at 09:05:07AM -0400, Jason wrote: 1.) modify git to add a hook in format-patch, output is dumped after the '---' and before the diff. We use this the run checkpatch.pl with our config. Our script includes a version tag of checkpatch.pl? Add the ability to run a series of scripts, with the output appended as above. So, 00_checkpatch 10_makeall Where 10_makeall would provide some concise output, eg (0 errors, 3 warnings) or similar. thx, Jason. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
On 10/18/2011 03:05 PM, Jason wrote: Wolfgang, On Tue, Oct 18, 2011 at 11:44:37AM +0200, Wolfgang Denk wrote: Dear Andreas, In message4e9d4552.5040...@gmail.com you wrote: I guess it will be doable to have some scripts/prepare-patch which runs a) git format-patch b) checkpatch on the patch c) (configurable subset of) MAKEALL on some clean tree with that patch applied d) append the results to the patch This tool would implement some kind of CI but utilize the computing power of submitter. Sounds good. Any takers? I've been mulling this over, and here's my approach: 1.) modify git to add a hook in format-patch, output is dumped after the '---' and before the diff. We use this the run checkpatch.pl with our config. Our script includes a version tag of checkpatch.pl? cool! 2.) Add a '--versioning' option to format-patch which will scan the output directory for previous versions of the patch. a.) Use the Message-Id of the first version as an In-Reply-To - Where do you get the Message-Id from? Isn't the message-id assigned by the mail system? - I would prefer the last version b.) Migrate patch changelog over from previous version, append '*** ADD CHANGELOG ENTRY HERE ***' c.) enforce [PATCH 1/7 V#] Subject line format. Don't forget to remove V# for the first version. I think this would be more flexible, and would help many projects, not just u-boot. Totally agreed! thx, Jason. Regards Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
Dear Jason, Am 18.10.2011 15:05, schrieb Jason: Wolfgang, On Tue, Oct 18, 2011 at 11:44:37AM +0200, Wolfgang Denk wrote: Dear Andreas, In message 4e9d4552.5040...@gmail.com you wrote: I guess it will be doable to have some scripts/prepare-patch which runs a) git format-patch b) checkpatch on the patch c) (configurable subset of) MAKEALL on some clean tree with that patch applied d) append the results to the patch This tool would implement some kind of CI but utilize the computing power of submitter. Sounds good. Any takers? I've been mulling this over, and here's my approach: 1.) modify git to add a hook in format-patch, output is dumped after the '---' and before the diff. We use this the run checkpatch.pl with our config. Our script includes a version tag of checkpatch.pl? I think of some script that utilizes git rather than changing git. 2.) Add a '--versioning' option to format-patch which will scan the output directory for previous versions of the patch. nice, but ... a.) Use the Message-Id of the first version as an In-Reply-To b.) Migrate patch changelog over from previous version, append '*** ADD CHANGELOG ENTRY HERE ***' c.) enforce [PATCH 1/7 V#] Subject line format. I never hold old patches long, they are on the list, patchwork or in my tree. But feel free to discuss this on git ML. And I doubt this will help us in near future (remember the debian users ;) Best regards Andreas Bießmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
On Tue, Oct 18, 2011 at 03:13:45PM +0200, Simon Schwarz wrote: On 10/18/2011 03:05 PM, Jason wrote: 2.) Add a '--versioning' option to format-patch which will scan the output directory for previous versions of the patch. a.) Use the Message-Id of the first version as an In-Reply-To - Where do you get the Message-Id from? Isn't the message-id assigned by the mail system? 'git format-patch' can create it, or 'git send-mail' will add it. Nothing prevents there from being more than one. - I would prefer the last version I suppose an example in threaded view might help (yes, not a practical series, but bear with me :-) ): [PATCH 0/3] add xyz support. [PATCH 1/3] fix some junk [PATCH 2/3] add support for xyz board [PATCH 3/3] add xyz board to MAKEALL [PATCH 0/3 V2] add xyz support. [PATCH 1/3 V2] whitespace cleanup [PATCH 2/3 V2] add support for xyz board [PATCH 3/3 V2] add xyz board to MAKEALL [PATCH 0/2 V3] add xyz support. [PATCH 1/2 V3] whitespace cleanup [PATCH 2/2 V3] add support for xyz board [PATCH 1/1 V4] add xyz support. [PATCH 1/1 V5] add xyz support. And the cooresponding changelog: Changes from v1 to v2: - proper subject line for whitespace cleanup Changes from v2 to v3: - collapse patch 3 into 2 advised by Prafulla Changes from v3 to v4: - whitespace cleanup was merged Changes from v4 to v5: - rebased against new tag, v2011.09 By always being In-Reply-To the original coverletter, it's imho, much easier to find the next version. Especially once comments and replies are in the thread. I suppose '--thread=shallow' could trigger my approach... b.) Migrate patch changelog over from previous version, append '*** ADD CHANGELOG ENTRY HERE ***' c.) enforce [PATCH 1/7 V#] Subject line format. Don't forget to remove V# for the first version. Yes, see above. thx, Jason. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
Hi, On Tue, Oct 18, 2011 at 2:44 AM, Wolfgang Denk w...@denx.de wrote: Dear Andreas, In message 4e9d4552.5040...@gmail.com you wrote: We should first get a state of all boards build clean for a sort of toolchains (I think arm is now at this state after a lot of tumult in the last two releases). PowerPC has traditionally always been build-clean (all boards succeed to build, with very few [2...3] causing harmelss build warnings). Now ARM is close to that, too. MIPS has also always been building mostly fine. This is some kind of CI as suggested by Lukasz Majewski. I also favor CI for fast feedback to the submitter if his change breaks something. I'm not sure how to do that. To provide feedback to individual submitters, you would have to runn a full build cycle for each patch we apply. That would obviously be best, but I don't have machine power to do that. What I do is testing batches - say, after applying 20...30 patches, or after major changes. I have Jenkins running every night for a few selected CPU families, which already catches a number of issues, but even then it's directly pointing to a submitted patch. I guess it will be doable to have some scripts/prepare-patch which runs a) git format-patch b) checkpatch on the patch c) (configurable subset of) MAKEALL on some clean tree with that patch applied d) append the results to the patch This tool would implement some kind of CI but utilize the computing power of submitter. Sounds good. Any takers? I'm keen to take a look at this, as I have a and b already and a tool which munges patches. Also it something that causes me a bit of pain. I have so far written a tool which automates patch creation based on tags in the commits - it works out how many patches are in your branch (or you can tell it), creates the patches with format-patch, runs patches through checkpatch, its own checks and does a 'git am' on each. Then it creates a cover letter and (if the patches are clean) optionally does a 'git send-email' on the series. Information is collected from tags in the commits (which are removed from the patch). Version changes are collected from each commit and added to the cover letter, the subject is set correctly, etc. For example, here is my top commit for branch us-printf: Series-to: u-boot Series-cc: wolfgang Cover-letter: Buffer overruns in printf The printf family of functions in U-Boot cannot deal with a situation where the caller provides a buffer which turns out to be too small for the format string. This can result in buffer overflows, stack overflows and other bad behavior. This patch series tidies this up in the common vsprintf.c code. END Series-version: 3 Series-changes: 2 - Use sizeof(printbuffer) instead of CONFIG_SYS_PBSIZE - Drop patch which changes network code to use snprintf() and another commit has: Series-changes: 3 - Move prototypes from common.h to vsprintf.h Other tags are Series-prefix (for 'RFC' for example) and Series-notes for notes which should appear at the end of the cover letter. It also looks for tags like 'arm:' and 'net:' in the in the subject field and CCs the maintainer. It does enforce a certain workflow, but allows you to easily change branches, make a change and create some new patches. It does not handle In-reply-to yet. Anyway, with this and Mike's little script for calling MAKEALL it doesn't seem like a huge job to add building to this script. and then append the results into the patch. I have already been wondering how to send this out for review - perhaps as something in tools/scripts? Regads, Simon Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Drun'? 'm not drun'! You woudn' dare call m' drun' if I was sober! - Terry Pratchett, _Men at Arms_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 18/20] Adjust dependency rules to permit per-file flags
Hi Wolfgang, On Mon, Oct 17, 2011 at 10:46 PM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message 1318270953-32482-19-git-send-email-...@chromium.org you wrote: The dependency rules are currently done in a shell 'for' loop. This does not permit Makefile variables to adjust preprocessor flags as is done with normal compile flags, using the CFLAGS_path/file.o syntax. This change moves the dependency generation into the Makefile itself, and permits a CPPFLAGS_path/file.o to adjust preprocessor flags on a file or directory basis. The CPPFLAGS_... variable is also folded into CFLAGS during the build. Signed-off-by: Simon Glass s...@chromium.org This commit breaks building a number of PPC boards like that: Configuring for acadia_nand - Board: acadia, Options: NAND_U_BOOT,SYS_TEXT_BASE=0x0100 ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/start.S: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/resetvec.S: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/cache.S: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/gpio.c: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/nand_boot.c: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/nand_ecc.c: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/memory.c: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/ndfc.c: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/pll.c: No such file or directory ppc_6xx-gcc: no input files make[1]: *** No rule to make target `/work/wd/tmp-ppc/nand_spl/board/amcc/acadia/.depend', needed by `all'. Stop. Affected boards: MPC8313ERDB_NAND_33 P1020RDB_NAND SIMPC8313_LP MPC8313ERDB_NAND_66 P1021RDB-PC_36BIT_NAND SIMPC8313_SP MPC8315ERDB_NAND P1021RDB-PC_NAND acadia_nand MPC8536DS_NAND P1023RDS_NAND bamboo_nand MPC8569MDS_NAND P1024RDB_NAND canyonlands_nand MPC8572DS_NAND P1025RDB_NAND glacier_nand P1010RDB_36BIT_NAND P2010RDB_NAND haleakala_nand P1010RDB_NAND P2020RDB-PC_36BIT_NAND kilauea_nand P1011RDB_NAND P2020RDB-PC_NAND rainier_nand P1020RDB-PC_36BIT_NAND P2020RDB_NAND sequoia_nand P1020RDB-PC_NAND This might be something to do with SPL - I am looking at it today. Regards, Simon Please fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Documentation is the castor oil of programming. Managers know it must be good because the programmers hate it so much. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/1] ARM: vexpress: Change maintainer for ARM Versatile Express platforms
Change maintainer for ARM Versatile Express platforms. Signed-off-by: Ryan Harkin ryan.har...@linaro.org --- MAINTAINERS |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 578f38e..dbc9269 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -856,7 +856,8 @@ Hugo Villeneuve hugo.villene...@lyrtech.com SFFSDR ARM926EJS -Matt Waddel matt.wad...@linaro.org +Ryan Harkin ryan.har...@linaro.org +Jon Medhurst (Tixy) jon.medhu...@linaro.org vexpress_ca9x4 ARM ARMV7 (Quad Core) vexpress_ca5x2 ARM ARMV7 (Dual Core) -- 1.7.4.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 0/3] usb:gadget: USB Mass Storage Gadget
This patch series provide the USB Mass Storage Gadget (UMS) support. Tested at S5P GONI reference target. Lukasz Majewski (3): usb:gadget: USB Mass Storage - files from Linux kernel usb:gadget: USB Mass Storage Gadget support usb:gadget:s5p Support for USB Mass Storage Gadget on GONI board/samsung/goni/goni.c | 69 + common/Makefile |1 + common/cmd_usb_mass_storage.c | 79 + drivers/usb/gadget/Makefile |1 + drivers/usb/gadget/file_storage.c | 3584 +++ drivers/usb/gadget/storage_common.c | 768 include/configs/s5p_goni.h |6 + include/usb_mass_storage.h | 56 + 8 files changed, 4564 insertions(+), 0 deletions(-) create mode 100644 common/cmd_usb_mass_storage.c create mode 100644 drivers/usb/gadget/file_storage.c create mode 100644 drivers/usb/gadget/storage_common.c create mode 100644 include/usb_mass_storage.h -- 1.7.2.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 3/3] usb:gadget:s5p Support for USB Mass Storage Gadget at GONI
This patch adds support for USB Mass Storage Gadget on the
Samsung's GONI reference target
Signed-off-by: Lukasz Majewski l.majew...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Remy Bohmer li...@bohmer.net
Cc: Minkyu Kang mk7.k...@samsung.com
---
Changes for v2:
- #include usb/s3c_udc.h added for fixing build warning
---
board/samsung/goni/goni.c | 69
include/configs/s5p_goni.h |6
2 files changed, 75 insertions(+), 0 deletions(-)
diff --git a/board/samsung/goni/goni.c b/board/samsung/goni/goni.c
index c4fc3e9..cba4219 100644
--- a/board/samsung/goni/goni.c
+++ b/board/samsung/goni/goni.c
@@ -29,6 +29,9 @@
#include asm/arch/hs_otg.h
#include asm/arch/cpu.h
#include max8998_pmic.h
+#include usb_mass_storage.h
+#include usb/s3c_udc.h
+
DECLARE_GLOBAL_DATA_PTR;
static struct s5pc110_gpio *s5pc110_gpio;
@@ -145,3 +148,69 @@ struct s3c_plat_otg_data s5pc110_otg_data = {
.regs_otg = S5PC110_OTG_BASE,
};
#endif
+
+#ifdef CONFIG_USB_GADGET_MASS_STORAGE
+static int ums_read_sector(struct ums_device *ums_dev,
+ unsigned int n, void *buf)
+{
+ if (ums_dev-mmc-block_dev.block_read(ums_dev-dev_num,
+ n + ums_dev-offset, 1, buf) != 1)
+ return -1;
+
+ return 0;
+}
+
+static int ums_write_sector(struct ums_device *ums_dev,
+ unsigned int n, void *buf)
+{
+ if (ums_dev-mmc-block_dev.block_write(ums_dev-dev_num,
+ n + ums_dev-offset, 1, buf) != 1)
+ return -1;
+
+ return 0;
+}
+
+static void ums_get_capacity(struct ums_device *ums_dev,
+long long int *capacity)
+{
+ long long int tmp_capacity;
+
+ tmp_capacity = (long long int) ((ums_dev-offset + ums_dev-part_size)
+ * SECTOR_SIZE);
+ *capacity = ums_dev-mmc-capacity - tmp_capacity;
+}
+
+static struct ums_board_info ums_board = {
+ .read_sector = ums_read_sector,
+ .write_sector = ums_write_sector,
+ .get_capacity = ums_get_capacity,
+ .name = GONI UMS disk,
+ .ums_dev = {
+ .mmc = NULL,
+ .dev_num = 0,
+ .offset = 0,
+ .part_size = 0.
+ },
+};
+
+struct ums_board_info *board_ums_init(unsigned int dev_num, unsigned int
offset,
+ unsigned int part_size)
+{
+ struct mmc *mmc;
+
+ mmc = find_mmc_device(dev_num);
+ if (!mmc)
+ return NULL;
+
+ ums_board.ums_dev.mmc = mmc;
+ ums_board.ums_dev.dev_num = dev_num;
+ ums_board.ums_dev.offset = offset;
+ ums_board.ums_dev.part_size = part_size;
+
+ /* Init MMC */
+ mmc_init(mmc);
+
+ s3c_udc_probe(s5pc110_otg_data);
+ return ums_board;
+}
+#endif
diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
index 969e060..53bd79f 100644
--- a/include/configs/s5p_goni.h
+++ b/include/configs/s5p_goni.h
@@ -90,6 +90,8 @@
#define CONFIG_CMD_MTDPARTS
#define CONFIG_CMD_MMC
+#define CONFIG_CMD_USB_MASS_STORAGE
+
#define CONFIG_BOOTDELAY 1
#define CONFIG_ZERO_BOOTDELAY_CHECK
@@ -244,4 +246,8 @@
#define CONFIG_USB_GADGET_S3C_UDC_OTG 1
#define CONFIG_USB_GADGET_DUALSPEED1
+#if defined(CONFIG_CMD_USB_MASS_STORAGE)
+#define CONFIG_USB_GADGET_MASS_STORAGE
+#endif
+
#endif /* __CONFIG_H */
--
1.7.2.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 2/3] usb:gadget: USB Mass Storage Gadget support
This patch adds the USB Mass Storage Gadget to u-boot
New command called ums is implemented to provide access
to on-device embedded persistent memory.
USB Mass Storage is supposed to work on top of the USB
Gadget framework
Signed-off-by: Lukasz Majewski l.majew...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Minkyu Kang mk7.k...@samsung.com
Cc: Remy Bohmer li...@bohmer.net
---
Changes for v2:
- None
---
common/Makefile |1 +
common/cmd_usb_mass_storage.c | 79 +
drivers/usb/gadget/Makefile |1 +
include/usb_mass_storage.h| 56 +
4 files changed, 137 insertions(+), 0 deletions(-)
create mode 100644 common/cmd_usb_mass_storage.c
create mode 100644 include/usb_mass_storage.h
diff --git a/common/Makefile b/common/Makefile
index 371a0d9..67477bf 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -158,6 +158,7 @@ COBJS-y += cmd_usb.o
COBJS-y += usb.o
COBJS-$(CONFIG_USB_STORAGE) += usb_storage.o
endif
+COBJS-$(CONFIG_CMD_USB_MASS_STORAGE) += cmd_usb_mass_storage.o
COBJS-$(CONFIG_CMD_XIMG) += cmd_ximg.o
COBJS-$(CONFIG_YAFFS2) += cmd_yaffs2.o
diff --git a/common/cmd_usb_mass_storage.c b/common/cmd_usb_mass_storage.c
new file mode 100644
index 000..074c26a
--- /dev/null
+++ b/common/cmd_usb_mass_storage.c
@@ -0,0 +1,79 @@
+/*
+ * Copyright (C) 2011 Samsung Electrnoics
+ * Lukasz Majewski l.majew...@samsung.com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include errno.h
+#include common.h
+#include command.h
+#include usb_mass_storage.h
+
+#undef UMS_DBG
+#define UMS_DBG(fmt, args...) printf(fmt, ##args)
+/* #define UMS_DBG(...) */
+
+int do_usb_mass_storage(cmd_tbl_t *cmdtp, int flag,
+ int argc, char * const argv[])
+{
+ char *ep;
+ unsigned int dev_num = 0, offset = 0, part_size = 0;
+
+ struct ums_board_info *ums_info;
+
+ if (argc 2) {
+ printf(usage: ums dev - e.g. ums 0\n);
+ return 0;
+ }
+
+ dev_num = (int)simple_strtoul(argv[1], ep, 16);
+
+ if (dev_num) {
+ puts(\nSet eMMC device to 0! - e.g. ums 0\n);
+ goto fail;
+ }
+
+ ums_info = board_ums_init(dev_num, offset, part_size);
+
+ if (!ums_info) {
+ printf(MMC: %d - NOT available\n, dev_num);
+ goto fail;
+ }
+
+ fsg_init(ums_info);
+ while (1) {
+ int irq_res;
+ /* Handle control-c and timeouts */
+ if (ctrlc()) {
+ printf(The remote end did not respond in time.\n);
+ goto fail;
+ }
+
+ irq_res = usb_gadget_handle_interrupts();
+
+ /* Check if USB cable has been detached */
+ if (fsg_main_thread(NULL) == EIO)
+ goto fail;
+ }
+fail:
+ return -1;
+}
+
+U_BOOT_CMD(ums, CONFIG_SYS_MAXARGS, 1, do_usb_mass_storage,
+ Use the UMS [User Mass Storage],
+ ums - User Mass Storage Gadget
+);
diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
index cd22bbe..e9452c6 100644
--- a/drivers/usb/gadget/Makefile
+++ b/drivers/usb/gadget/Makefile
@@ -28,6 +28,7 @@ LIB := $(obj)libusb_gadget.o
# new USB gadget layer dependencies
ifdef CONFIG_USB_GADGET
COBJS-y += epautoconf.o config.o usbstring.o
+COBJS-$(CONFIG_USB_GADGET_MASS_STORAGE) += file_storage.o
COBJS-$(CONFIG_USB_GADGET_S3C_UDC_OTG) += s3c_udc_otg.o
endif
ifdef CONFIG_USB_ETHER
diff --git a/include/usb_mass_storage.h b/include/usb_mass_storage.h
new file mode 100644
index 000..3154f49
--- /dev/null
+++ b/include/usb_mass_storage.h
@@ -0,0 +1,56 @@
+/*
+ * Copyright (C) 2011 Samsung Electrnoics
+ * Lukasz Majewski l.majew...@samsung.com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR
Re: [U-Boot] [PATCH] gpio: Add PCA9698 40-bit I2C I/O port
Hi Dirk, On Tuesday 04 October 2011 11:13:51 eib...@gdsys.de wrote: From: Dirk Eibach eib...@gdsys.de Checkpatch output: ERROR: memset size is 3rd argument, not the second. #239: FILE: drivers/gpio/pca9698.c:120: + memset(data, sizeof(data), 0); total: 1 errors, 0 warnings, 139 lines checked So, this now really is a good checkpatch feature. I wasn't ware, that it checked for such bugs as well. Nice. :) Please fix and resubmit. Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] arm:fix:cleanup: Volatile keyword removal
Volatile keyword removal from
./arch/arm/include/asm/bitops.h
Signed-off-by: Lukasz Majewski l.majew...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/include/asm/bitops.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/include/asm/bitops.h b/arch/arm/include/asm/bitops.h
index 879e20e..b00ae30 100644
--- a/arch/arm/include/asm/bitops.h
+++ b/arch/arm/include/asm/bitops.h
@@ -25,11 +25,11 @@
/*
* Function prototypes to keep gcc -Wall happy.
*/
-extern void set_bit(int nr, volatile void * addr);
+extern void set_bit(int nr, void *addr);
-extern void clear_bit(int nr, volatile void * addr);
+extern void clear_bit(int nr, void *addr);
-extern void change_bit(int nr, volatile void * addr);
+extern void change_bit(int nr, void *addr);
static inline void __change_bit(int nr, volatile void *addr)
{
--
1.7.2.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V4 0/5] fix and enhancement patches for sdhci
Hi Andy, On Sat, Oct 8, 2011 at 10:14 PM, Lei Wen lei...@marvell.com wrote: This seris fix several issue like flush cache and build warning. And give this generic driver enhancement for timeout when transferring data and additional structure member to access in platform self driver. Changelog: V2: code style change. V3: add another fix of sdma handling bug including in this series V4: minor code style change Lei Wen (5): mmc: sdhci: fix cache flush mmc: sdhci: fix build warning mmc: sdhci: add mmc structure for host mmc: sdhci: add timeout for data transfer mmc: sdhci: fix sdma bug for large file transfer drivers/mmc/sdhci.c | 14 +++--- include/sdhci.h | 6 ++ 2 files changed, 17 insertions(+), 3 deletions(-) Any comment for this patch series? Thanks, Lei ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/3] enable dcache for pantheon and armada100
Hi Prafulla, On Sat, Oct 8, 2011 at 9:59 PM, Lei Wen lei...@marvell.com wrote: This patch seris use Marvell its own special op code to flush the dcache Lei Wen (3): ARM: add special dcache flush op code for 88SV331xV5 ARM: pantheon: enable dcache by default ARM: armada100: enable dcache by default arch/arm/cpu/arm926ejs/armada100/cpu.c | 8 arch/arm/cpu/arm926ejs/pantheon/cpu.c | 8 arch/arm/lib/cache.c | 5 + 3 files changed, 21 insertions(+), 0 deletions(-) Do you have any comment over this patch series? Thanks, Lei ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 03/20] sandbox: Add architecture image support
On Tuesday 18 October 2011 04:28:23 馬克泡 wrote:
2011/10/18 Wolfgang Denk w...@denx.de:
Dear Simon Glass,
Changes in v5:
- Define IH_ARCH_DEFAULT which is now required
arch/sandbox/include/asm/u-boot.h |3 +++
include/image.h |1 +
2 files changed, 4 insertions(+), 0 deletions(-)
Applied, thanks.
Sorry for late to reply your mail.
I'm doing PATCH v17 fix about NDS32 architecture against to your patches.
Ive found here you've defined IH_ARCH_SANDBOX in /include/image.h
Just wondering about don't you need to also add this into
../common/image.c in the following table?
static const table_entry_t uimage_arch[]
[deleted]
{ IH_ARCH_BLACKFIN, blackfin, Blackfin, },
{ IH_ARCH_AVR32, avr32,AVR32,},
{ -1, , , },
};
Because I'm wondering about if I need to fix this if you need to add
IH_ARCH_SANDBOX into this structure.
for now, i don't think so. sandbox isn't an arch you can create uimages for
(atm?).
-mike
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 07/20] sandbox: Add sandbox board
On Tuesday 18 October 2011 04:43:09 馬克泡 wrote: 2011/10/11 Simon Glass : +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).o + +COBJS := $(BOARD).o + +SRCS := $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) + +$(LIB):$(obj).depend $(OBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) It has been suggested by Mike that you should use something like the following because $(AR) might broken. $(LIB):$(OBJS) $(call cmd_link_o_target, $(OBJS)) yeah i missed this chunk of Simon's patch (i caught some others in his patchset). i've fixed this in my tree-wide $(AR) fixup, so Simon won't have to worry about posting an update. -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2 v2] build: add missing $(AR)-$(cmd_link_o_target) update
Seems people fixed their files to use libfoo.o, but didn't actually update the creation targets to use $(cmd_link_o_target). Update the rest of the Makefile's found with grep. Signed-off-by: Mike Frysinger vap...@gentoo.org --- v2 - fixup new sandbox makefile too arch/arm/cpu/arm926ejs/armada100/Makefile |2 +- arch/arm/cpu/arm926ejs/pantheon/Makefile |2 +- arch/arm/cpu/armv7/tegra2/Makefile|2 +- board/Marvell/aspenite/Makefile |2 +- board/Marvell/dkb/Makefile|2 +- board/Marvell/gplugd/Makefile |2 +- board/cm_t35/Makefile |2 +- board/davinci/ea20/Makefile |2 +- board/freescale/p1023rds/Makefile |2 +- board/matrix_vision/mergerbox/Makefile|2 +- board/nvidia/harmony/Makefile |2 +- board/nvidia/seaboard/Makefile|2 +- board/samsung/origen/Makefile |2 +- board/samsung/smdkv310/Makefile |2 +- board/sandbox/sandbox/Makefile|2 +- board/shmin/Makefile |2 +- 16 files changed, 16 insertions(+), 16 deletions(-) diff --git a/arch/arm/cpu/arm926ejs/armada100/Makefile b/arch/arm/cpu/arm926ejs/armada100/Makefile index 76bd06d..d30d608 100644 --- a/arch/arm/cpu/arm926ejs/armada100/Makefile +++ b/arch/arm/cpu/arm926ejs/armada100/Makefile @@ -34,7 +34,7 @@ OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS-y)) all: $(obj).depend $(LIB) $(LIB):$(OBJS) - $(AR) $(ARFLAGS) $@ $(OBJS) + $(call cmd_link_o_target, $(OBJS)) # diff --git a/arch/arm/cpu/arm926ejs/pantheon/Makefile b/arch/arm/cpu/arm926ejs/pantheon/Makefile index ab94985..8f962b0 100644 --- a/arch/arm/cpu/arm926ejs/pantheon/Makefile +++ b/arch/arm/cpu/arm926ejs/pantheon/Makefile @@ -34,7 +34,7 @@ OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS-y)) all: $(obj).depend $(LIB) $(LIB):$(OBJS) - $(AR) $(ARFLAGS) $@ $(OBJS) + $(call cmd_link_o_target, $(OBJS)) # diff --git a/arch/arm/cpu/armv7/tegra2/Makefile b/arch/arm/cpu/armv7/tegra2/Makefile index f673f03..f0dc2ff 100644 --- a/arch/arm/cpu/armv7/tegra2/Makefile +++ b/arch/arm/cpu/armv7/tegra2/Makefile @@ -36,7 +36,7 @@ OBJS := $(addprefix $(obj),$(COBJS) $(SOBJS)) all:$(obj).depend $(LIB) $(LIB):$(OBJS) - $(AR) $(ARFLAGS) $@ $(OBJS) + $(call cmd_link_o_target, $(OBJS)) # diff --git a/board/Marvell/aspenite/Makefile b/board/Marvell/aspenite/Makefile index 4a807be..6d771ed 100644 --- a/board/Marvell/aspenite/Makefile +++ b/board/Marvell/aspenite/Makefile @@ -34,7 +34,7 @@ OBJS := $(addprefix $(obj),$(COBJS)) SOBJS := $(addprefix $(obj),$(SOBJS)) $(LIB):$(obj).depend $(OBJS) $(SOBJS) - $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) # diff --git a/board/Marvell/dkb/Makefile b/board/Marvell/dkb/Makefile index ddb799d..754c889 100644 --- a/board/Marvell/dkb/Makefile +++ b/board/Marvell/dkb/Makefile @@ -33,7 +33,7 @@ OBJS := $(addprefix $(obj),$(COBJS)) SOBJS := $(addprefix $(obj),$(SOBJS)) $(LIB):$(obj).depend $(OBJS) $(SOBJS) - $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) # diff --git a/board/Marvell/gplugd/Makefile b/board/Marvell/gplugd/Makefile index 3ce4f81..40188c6 100644 --- a/board/Marvell/gplugd/Makefile +++ b/board/Marvell/gplugd/Makefile @@ -39,7 +39,7 @@ OBJS := $(addprefix $(obj),$(COBJS)) SOBJS := $(addprefix $(obj),$(SOBJS)) $(LIB):$(obj).depend $(OBJS) $(SOBJS) - $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) # diff --git a/board/cm_t35/Makefile b/board/cm_t35/Makefile index d08c024..27693f0 100644 --- a/board/cm_t35/Makefile +++ b/board/cm_t35/Makefile @@ -31,7 +31,7 @@ SRCS := $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS)) $(LIB):$(obj).depend $(OBJS) - $(AR) $(ARFLAGS) $@ $(OBJS) + $(call cmd_link_o_target, $(OBJS)) # diff --git a/board/davinci/ea20/Makefile b/board/davinci/ea20/Makefile index 1725f2b..265f8b2 100644 --- a/board/davinci/ea20/Makefile +++ b/board/davinci/ea20/Makefile @@ -36,7 +36,7 @@ OBJS := $(addprefix $(obj),$(COBJS)) SOBJS := $(addprefix $(obj),$(SOBJS)) $(LIB):$(obj).depend $(OBJS) $(SOBJS) - $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS))
Re: [U-Boot] [STATUS] Quality of patches / testing.
Let's try that example again... [PATCH 0/3] add xyz support. |-[PATCH 1/3] fix some junk |-[PATCH 2/3] add support for xyz board |-[PATCH 3/3] add xyz board to MAKEALL |-[PATCH 0/3 V2] add xyz support. | |-[PATCH 1/3 V2] whitespace cleanup | |-[PATCH 2/3 V2] add support for xyz board | \-[PATCH 3/3 V2] add xyz board to MAKEALL |-[PATCH 0/2 V3] add xyz support. | |-[PATCH 1/2 V3] whitespace cleanup | \-[PATCH 2/2 V3] add support for xyz board |-[PATCH 1/1 V4] add xyz support. \-[PATCH 1/1 V5] add xyz support. Hopefully, that didn't get munged. thx, Jason. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 03/20] sandbox: Add architecture image support
Hi Mike,
2011/10/18 Mike Frysinger vap...@gentoo.org:
On Tuesday 18 October 2011 04:28:23 馬克泡 wrote:
2011/10/18 Wolfgang Denk w...@denx.de:
[deleted]
static const table_entry_t uimage_arch[]
[deleted]
{ IH_ARCH_BLACKFIN, blackfin, Blackfin, },
{ IH_ARCH_AVR32, avr32,AVR32,},
{ -1, , , },
};
Because I'm wondering about if I need to fix this if you need to add
IH_ARCH_SANDBOX into this structure.
for now, i don't think so. sandbox isn't an arch you can create uimages for
(atm?).
-mike
Is there no plan to run Chrome OS from flash storage?
Sorry I'm not familiar about the hardware planning about the Chrome OS.
Just wondering if there is planning low-price Chrome netbook, the
uimage might be
necessary for such kind of hardware.
--
Best regards,
Macpaul Lin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] ARM: vexpress: Change maintainer for ARM Versatile Express platforms
On 10/18/2011 08:22 AM, Ryan Harkin wrote: Change maintainer for ARM Versatile Express platforms. Signed-off-by: Ryan Harkin ryan.har...@linaro.org Acked-by: Matt Waddel matt.wad...@linaro.org --- MAINTAINERS |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 578f38e..dbc9269 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -856,7 +856,8 @@ Hugo Villeneuve hugo.villene...@lyrtech.com SFFSDR ARM926EJS -Matt Waddel matt.wad...@linaro.org +Ryan Harkin ryan.har...@linaro.org +Jon Medhurst (Tixy) jon.medhu...@linaro.org vexpress_ca9x4 ARM ARMV7 (Quad Core) vexpress_ca5x2 ARM ARMV7 (Dual Core) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Correct dependency rule to fix SPL build
Commit 4750884 introduced a change in the dependency generation which breaks SPL, because the source files being built are not initially present and are symlinked as part of the build. The .depend file must depend not only on the files in the DEPS list but also on the sources which did not contribute files to the DEPS list, since these sources will otherwise not get a dependency and will not be built. Signed-off-by: Simon Glass s...@chromium.org --- rules.mk |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/rules.mk b/rules.mk index 22562f3..fa929f9 100644 --- a/rules.mk +++ b/rules.mk @@ -38,7 +38,8 @@ DEPS := $(basename $(patsubst %,$(obj).depend.%,$(PWD_SRCS))) # 1 .Concatenate all the generated depend files together # 2. Add in the deps from OTHER_SRCS which we couldn't process # 3. Add in the HOSTSRCS -$(obj).depend: $(src)Makefile $(TOPDIR)/config.mk $(DEPS) $(HOSTSRCS) +$(obj).depend: $(src)Makefile $(TOPDIR)/config.mk $(DEPS) $(OTHER_SRCS) \ + $(HOSTSRCS) cat /dev/null $(DEPS) $@ @for f in $(OTHER_SRCS); do \ g=`basename $$f | sed -e 's/\(.*\)\.[[:alnum:]_]/\1.o/'`; \ -- 1.7.3.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
Andreas, On Tue, Oct 18, 2011 at 03:36:21PM +0200, Andreas Bießmann wrote: Dear Jason, Am 18.10.2011 15:05, schrieb Jason: ... I've been mulling this over, and here's my approach: 1.) modify git to add a hook in format-patch, output is dumped after the '---' and before the diff. We use this the run checkpatch.pl with our config. Our script includes a version tag of checkpatch.pl? I think of some script that utilizes git rather than changing git. As long as the end effect puts all of the versions of a patch series into one thread, and injects the output of checkpatch, a changelog and possibly the output of MAKEALL; then I'm all for it. I'd prefer to create a generic solution so that other projects could take advantage of it and adapt it to their needs. 2.) Add a '--versioning' option to format-patch which will scan the output directory for previous versions of the patch. nice, but ... a.) Use the Message-Id of the first version as an In-Reply-To b.) Migrate patch changelog over from previous version, append '*** ADD CHANGELOG ENTRY HERE ***' c.) enforce [PATCH 1/7 V#] Subject line format. I never hold old patches long, they are on the list, patchwork or in my tree. Hmmm, if I can get a better handle on rfc 2822 [1], particularly section 3.6.4, then the threading would be maintained even when the old messages are deleted from your mail queue. But feel free to discuss this on git ML. And I doubt this will help us in near future (remember the debian users ;) Possibly, there's no reason why the wrapper script and the git hook can't both be pursued. Looks like Simon Glass already has a good start on the wrapper script. thx, Jason. [1] http://www.faqs.org/rfcs/rfc2822.html ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3] arm926ejs: add NXP LPC32x0 cpu series support
This change adds initial support for NXP LPC32x0 SoC series.
Signed-off-by: Vladimir Zapolskiy v...@mleia.com
---
Changes from v2 to v3:
* checkpatch.pl reports zero errors and warnings
Changes from v1 to v2:
* BIT(n) and SBF(s, v) macro are not used anymore
* removed NS16550 and 14-clock UART definitions from uart.h
* added devices.c file, which contains standard UART preinitialization routine
* added get_serial_clock() function, it returns actual frequency of UART clock
* __udelay() realization is simplified, no need of interrupt handling
arch/arm/cpu/arm926ejs/lpc32xx/Makefile| 45
arch/arm/cpu/arm926ejs/lpc32xx/clkpwr.c| 101 ++
arch/arm/cpu/arm926ejs/lpc32xx/cpu.c | 46
arch/arm/cpu/arm926ejs/lpc32xx/devices.c | 47 +
arch/arm/cpu/arm926ejs/lpc32xx/timer.c | 94 +
arch/arm/include/asm/arch-lpc32xx/clk.h| 155
arch/arm/include/asm/arch-lpc32xx/config.h | 50 +
arch/arm/include/asm/arch-lpc32xx/cpu.h| 62 +++
arch/arm/include/asm/arch-lpc32xx/timer.h | 74 +
arch/arm/include/asm/arch-lpc32xx/uart.h | 54 ++
arch/arm/include/asm/arch-lpc32xx/wdt.h| 51 +
11 files changed, 779 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/cpu/arm926ejs/lpc32xx/Makefile
create mode 100644 arch/arm/cpu/arm926ejs/lpc32xx/clkpwr.c
create mode 100644 arch/arm/cpu/arm926ejs/lpc32xx/cpu.c
create mode 100644 arch/arm/cpu/arm926ejs/lpc32xx/devices.c
create mode 100644 arch/arm/cpu/arm926ejs/lpc32xx/timer.c
create mode 100644 arch/arm/include/asm/arch-lpc32xx/clk.h
create mode 100644 arch/arm/include/asm/arch-lpc32xx/config.h
create mode 100644 arch/arm/include/asm/arch-lpc32xx/cpu.h
create mode 100644 arch/arm/include/asm/arch-lpc32xx/timer.h
create mode 100644 arch/arm/include/asm/arch-lpc32xx/uart.h
create mode 100644 arch/arm/include/asm/arch-lpc32xx/wdt.h
diff --git a/arch/arm/cpu/arm926ejs/lpc32xx/Makefile
b/arch/arm/cpu/arm926ejs/lpc32xx/Makefile
new file mode 100644
index 000..29b4dc8
--- /dev/null
+++ b/arch/arm/cpu/arm926ejs/lpc32xx/Makefile
@@ -0,0 +1,45 @@
+#
+# (C) Copyright 2000-2006
+# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB = $(obj)lib$(SOC).o
+
+COBJS = cpu.o clkpwr.o devices.o timer.o
+
+SRCS:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS:= $(addprefix $(obj),$(COBJS) $(SOBJS))
+
+all:$(obj).depend $(LIB)
+
+$(LIB): $(OBJS)
+ $(call cmd_link_o_target, $(OBJS))
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#
diff --git a/arch/arm/cpu/arm926ejs/lpc32xx/clkpwr.c
b/arch/arm/cpu/arm926ejs/lpc32xx/clkpwr.c
new file mode 100644
index 000..adae8b0
--- /dev/null
+++ b/arch/arm/cpu/arm926ejs/lpc32xx/clkpwr.c
@@ -0,0 +1,101 @@
+/*
+ * Copyright (C) 2011 by Vladimir Zapolskiy v...@mleia.com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301, USA.
+ */
+
+#include common.h
+#include div64.h
+#include asm/arch/cpu.h
+#include asm/arch/clk.h
+#include asm/io.h
+
+static struct clk_t *clk = (struct clk_t *)CLK_PM_BASE;
+
+unsigned int get_sys_clk_rate(void)
+{
+ if (readl(clk-sysclk_ctrl) CLK_SYSCLK_PLL397)
+ return RTC_CLK_FREQUENCY * 397;
+ else
+ return
Re: [U-Boot] [PATCH v6 18/20] Adjust dependency rules to permit per-file flags
Hi Wolfgang, On Tue, Oct 18, 2011 at 7:08 AM, Simon Glass s...@chromium.org wrote: Hi Wolfgang, On Mon, Oct 17, 2011 at 10:46 PM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message 1318270953-32482-19-git-send-email-...@chromium.org you wrote: The dependency rules are currently done in a shell 'for' loop. This does not permit Makefile variables to adjust preprocessor flags as is done with normal compile flags, using the CFLAGS_path/file.o syntax. This change moves the dependency generation into the Makefile itself, and permits a CPPFLAGS_path/file.o to adjust preprocessor flags on a file or directory basis. The CPPFLAGS_... variable is also folded into CFLAGS during the build. Signed-off-by: Simon Glass s...@chromium.org This commit breaks building a number of PPC boards like that: Configuring for acadia_nand - Board: acadia, Options: NAND_U_BOOT,SYS_TEXT_BASE=0x0100 ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/start.S: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/resetvec.S: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/cache.S: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/gpio.c: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/nand_boot.c: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/nand_ecc.c: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/memory.c: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/ndfc.c: No such file or directory ppc_6xx-gcc: no input files ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/pll.c: No such file or directory ppc_6xx-gcc: no input files make[1]: *** No rule to make target `/work/wd/tmp-ppc/nand_spl/board/amcc/acadia/.depend', needed by `all'. Stop. Affected boards: MPC8313ERDB_NAND_33 P1020RDB_NAND SIMPC8313_LP MPC8313ERDB_NAND_66 P1021RDB-PC_36BIT_NAND SIMPC8313_SP MPC8315ERDB_NAND P1021RDB-PC_NAND acadia_nand MPC8536DS_NAND P1023RDS_NAND bamboo_nand MPC8569MDS_NAND P1024RDB_NAND canyonlands_nand MPC8572DS_NAND P1025RDB_NAND glacier_nand P1010RDB_36BIT_NAND P2010RDB_NAND haleakala_nand P1010RDB_NAND P2020RDB-PC_36BIT_NAND kilauea_nand P1011RDB_NAND P2020RDB-PC_NAND rainier_nand P1020RDB-PC_36BIT_NAND P2020RDB_NAND sequoia_nand P1020RDB-PC_NAND This might be something to do with SPL - I am looking at it today. Regards, Simon Please fix. I have submitted a patch for this, tested on acadia like this: ARCH=powerpc make O=ppc -s acadia_nand_config ARCH=powerpc make O=ppc -s and similarly without the O= part. Regards, Simon Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Documentation is the castor oil of programming. Managers know it must be good because the programmers hate it so much. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] Move timestamp and version files into 'generated' subdir
Hi Wolfgang, On Mon, Oct 17, 2011 at 11:13 PM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message 1318272919-17706-1-git-send-email-...@chromium.org you wrote: There is a rather subtle build problem where the build time stamp is not updated for out-of-tree builds if there exists an in-tree build which has a valid timestamp file. So if you do an in-tree build, then an out-of-tree build your timestamp will not change. ... Makefile | 4 ++-- arch/arm/cpu/armv7/omap-common/spl.c | 3 +-- arch/arm/cpu/armv7/omap-common/spl_mmc.c | 3 +-- arch/arm/cpu/armv7/omap-common/spl_nand.c | 3 +-- drivers/serial/usbtty.h | 2 +- include/.gitignore | 2 -- include/timestamp.h | 2 +- include/version.h | 2 +- 8 files changed, 8 insertions(+), 13 deletions(-) This change breaks building for the following boards: BMW MUSENKI debris CPC45 MVBLUE eXalion CPC45_ROMBOOT OXC kvme080 CU824 PN62 linkstation_HGLAN HIDDEN_DRAGON Sandpoint8240 utx8245 MOUSSE Sandpoint8245 For example: + ./MAKEALL CPC45 Configuring for CPC45 board... ppc_6xx-gcc: /work/wd/tmp-ppc/arch/powerpc/cpu/mpc824x/bedbug_603e.c: No such file or directory ppc_6xx-gcc: no input files make[1]: *** No rule to make target `/work/wd/tmp-ppc/arch/powerpc/cpu/mpc824x/.depend', needed by `_depend'. Stop. Please fix. Actually I think this is the dependency patch rather than this one. Certainly I can repeat this problem on master and it is fixed with that patch. Regards, Simon Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Punishment becomes ineffective after a certain point. Men become in- sensitive. -- Eneg, Patterns of Force, stardate 2534.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm, doc: add CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST documentation
Ah, but we asked (and you agreed) to name the option generically since it's about OOB position rather than ECC size. And the help should reflect that it's about changing the OOB position relative to data as foudn on some davinci platforms rather than just being to enable support in davinci SoCs. Other boards might need this :) On Tue, Oct 11, 2011 at 10:34 PM, Heiko Schocher h...@denx.de wrote: Signed-off-by: Heiko Schocher h...@denx.de Cc: Paulraj Sandeep s-paul...@ti.com Cc: Scott Wood scottw...@freescale.com --- README | 4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/README b/README index 0868531..f6fa2c1 100644 --- a/README +++ b/README @@ -3075,6 +3075,10 @@ Low Level (hardware related) configuration options: - CONFIG_SYS_SRIOn_MEM_SIZE: Size of SRIO port 'n' memory region +- CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST + enable 4bit ECC hardware calculation algorithm, used on + davinci soc. + - CONFIG_SYS_NDFC_16 Defined to tell the NDFC that the NAND chip is using a 16 bit bus. -- 1.7.6.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot -- Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
On Tuesday 18 October 2011 09:13:45 Simon Schwarz wrote: On 10/18/2011 03:05 PM, Jason wrote: a.) Use the Message-Id of the first version as an In-Reply-To - Where do you get the Message-Id from? Isn't the message-id assigned by the mail system? fairly certain the MTA never does that. it's on the client's head (e.g. git- send-email) to add message-id tags. -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Makefile: prevent libgcc to be linked twice
On Tuesday 18 October 2011 04:30:27 Nicolas Ferre wrote: On 10/17/2011 07:25 PM, Mike Frysinger : On Monday 17 October 2011 09:41:15 Nicolas Ferre wrote: If we define USE_PRIVATE_LIBGCC, PLATFORM_LIBS is used during link. During this last link editing, libgcc may be listed twice and fail. Prevent this using filter-out in top Makefile. could you please provide more details ? libgcc should not be listed twice. I compile current u-boot with the flowing command line: make -j5 CROSS_COMPILE=arm-linux-gnueabi- USE_PRIVATE_LIBGCC=yes at91sam9m10g45ek_nandflash the issue shows up when using the board shortcut, and only when your tree is already configured. if you use at91sam9m10g45ek_nandflash_config and then another make, it works fine. if you start from a clean tree (git clean -x -d), it works fine. this is due to PLATFORM_LIBS appending PLATFORM_LIBGCC when the tree has been configured, then exporting PLATFORM_LIBS, then the board shortcut running $(MAKE). the exported PLATFORM_LIBS gets LIBGCC appended a second time. this issue will show up with any value that gets appended to PLATFORM_LIBS and not just libgcc. the arm code already hits this and deals with it locally. seems like we should instead unify this logic, or redo PLATFORM_LIBS so that it isn't an issue in the first place. -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 03/20] sandbox: Add architecture image support
On Tuesday 18 October 2011 11:43:49 馬克泡 wrote:
2011/10/18 Mike Frysinger:
On Tuesday 18 October 2011 04:28:23 馬克泡 wrote:
2011/10/18 Wolfgang Denk w...@denx.de:
[deleted]
static const table_entry_t uimage_arch[]
[deleted]
{ IH_ARCH_BLACKFIN, blackfin, Blackfin,
}, { IH_ARCH_AVR32, avr32,AVR32,
}, { -1, , ,
},
};
Because I'm wondering about if I need to fix this if you need to add
IH_ARCH_SANDBOX into this structure.
for now, i don't think so. sandbox isn't an arch you can create
uimages for (atm?).
Is there no plan to run Chrome OS from flash storage?
Sorry I'm not familiar about the hardware planning about the Chrome OS.
Just wondering if there is planning low-price Chrome netbook, the
uimage might be
necessary for such kind of hardware.
sandbox isn't actual hardware. it's a native application on your system
like `ls` or `mv` or `mutt`. it's purely for testing on your local machine.
-mike
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request for u-boot-coldfire.git
Hi, Wolfgang,
Please kindly pull
The following changes since commit efb2172ece93ef48f34fb8bdf963d3b72880cc7d:
Move timestamp and version files into 'generated' subdir (2011-10-17 23:57:00
+0200)
are available in the git repository at:
git://git.denx.de/u-boot-coldfire.git master
stany MARCEL (6):
ColdFire: Cleanup lds files for multiple defined symbols
ColdFire: Add $(obj) before cpu lib to correct build
ColdFire: Merge differentiated linking files into a sigle one by board
ColdFire: Fix compilation with CONFIG_SYS_DRAMSZ1 defined
ColdFire: Move boards with simple _config rules to boards.cfg
ColdFire: Clean Makefile _config rules
MAKEALL|6 -
Makefile | 115 +--
arch/m68k/cpu/mcf5227x/Makefile|2 +-
arch/m68k/cpu/mcf523x/Makefile |2 +-
arch/m68k/cpu/mcf532x/Makefile |2 +-
arch/m68k/cpu/mcf5445x/Makefile|2 +-
arch/m68k/cpu/mcf547x_8x/Makefile |2 +-
board/BuS/EB+MCF-EV123/u-boot.lds | 73 ++
board/cobra5272/u-boot.lds | 67 ++---
board/esd/tasreg/u-boot.lds| 69 ++
.../freescale/m52277evb/{u-boot.spa = u-boot.lds} |0
board/freescale/m52277evb/u-boot.stm | 136 -
board/freescale/m5235evb/u-boot.16 | 144 --
board/freescale/m5235evb/u-boot.32 | 152
.../{m54455evb/u-boot.int = m5235evb/u-boot.lds} |8 +-
board/freescale/m5249evb/u-boot.lds| 68 ++---
board/freescale/m5253evbe/u-boot.lds | 67 ++---
board/freescale/m5271evb/u-boot.lds| 66 ++---
board/freescale/m5272c3/u-boot.lds | 67 ++---
board/freescale/m5275evb/u-boot.lds| 68 ++---
board/freescale/m5282evb/u-boot.lds| 70 ++
.../freescale/m54451evb/{u-boot.stm = u-boot.lds} |0
board/freescale/m54451evb/u-boot.spa | 97 -
.../freescale/m54455evb/{u-boot.atm = u-boot.lds} |0
board/freescale/m54455evb/u-boot.stm | 136 -
board/freescale/m548xevb/m548xevb.c|3 +
board/idmr/u-boot.lds | 69 ++
boards.cfg | 21 +++-
include/configs/M5329EVB.h |8 +-
29 files changed, 168 insertions(+), 1352 deletions(-)
rename board/freescale/m52277evb/{u-boot.spa = u-boot.lds} (100%)
delete mode 100644 board/freescale/m52277evb/u-boot.stm
delete mode 100644 board/freescale/m5235evb/u-boot.16
delete mode 100644 board/freescale/m5235evb/u-boot.32
rename board/freescale/{m54455evb/u-boot.int = m5235evb/u-boot.lds} (92%)
rename board/freescale/m54451evb/{u-boot.stm = u-boot.lds} (100%)
delete mode 100644 board/freescale/m54451evb/u-boot.spa
rename board/freescale/m54455evb/{u-boot.atm = u-boot.lds} (100%)
delete mode 100644 board/freescale/m54455evb/u-boot.stm
Best Regards,
Jason
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
On Tue, Oct 18, 2011 at 7:05 AM, Simon Glass s...@chromium.org wrote: Hi, On Tue, Oct 18, 2011 at 2:44 AM, Wolfgang Denk w...@denx.de wrote: Dear Andreas, In message 4e9d4552.5040...@gmail.com you wrote: We should first get a state of all boards build clean for a sort of toolchains (I think arm is now at this state after a lot of tumult in the last two releases). PowerPC has traditionally always been build-clean (all boards succeed to build, with very few [2...3] causing harmelss build warnings). Now ARM is close to that, too. MIPS has also always been building mostly fine. This is some kind of CI as suggested by Lukasz Majewski. I also favor CI for fast feedback to the submitter if his change breaks something. I'm not sure how to do that. To provide feedback to individual submitters, you would have to runn a full build cycle for each patch we apply. That would obviously be best, but I don't have machine power to do that. What I do is testing batches - say, after applying 20...30 patches, or after major changes. I have Jenkins running every night for a few selected CPU families, which already catches a number of issues, but even then it's directly pointing to a submitted patch. I guess it will be doable to have some scripts/prepare-patch which runs a) git format-patch b) checkpatch on the patch c) (configurable subset of) MAKEALL on some clean tree with that patch applied d) append the results to the patch This tool would implement some kind of CI but utilize the computing power of submitter. Sounds good. Any takers? I'm keen to take a look at this, as I have a and b already and a tool which munges patches. Also it something that causes me a bit of pain. I have so far written a tool which automates patch creation based on tags in the commits - it works out how many patches are in your branch (or you can tell it), creates the patches with format-patch, runs patches through checkpatch, its own checks and does a 'git am' on each. Then it creates a cover letter and (if the patches are clean) optionally does a 'git send-email' on the series. Information is collected from tags in the commits (which are removed from the patch). Version changes are collected from each commit and added to the cover letter, the subject is set correctly, etc. For example, here is my top commit for branch us-printf: Series-to: u-boot Series-cc: wolfgang Cover-letter: Buffer overruns in printf The printf family of functions in U-Boot cannot deal with a situation where the caller provides a buffer which turns out to be too small for the format string. This can result in buffer overflows, stack overflows and other bad behavior. This patch series tidies this up in the common vsprintf.c code. END Series-version: 3 Series-changes: 2 - Use sizeof(printbuffer) instead of CONFIG_SYS_PBSIZE - Drop patch which changes network code to use snprintf() and another commit has: Series-changes: 3 - Move prototypes from common.h to vsprintf.h Other tags are Series-prefix (for 'RFC' for example) and Series-notes for notes which should appear at the end of the cover letter. It also looks for tags like 'arm:' and 'net:' in the in the subject field and CCs the maintainer. It does enforce a certain workflow, but allows you to easily change branches, make a change and create some new patches. It does not handle In-reply-to yet. Anyway, with this and Mike's little script for calling MAKEALL it doesn't seem like a huge job to add building to this script. and then append the results into the patch. I have already been wondering how to send this out for review - perhaps as something in tools/scripts? Regads, Simon Amusingly (since Simon and I work a few feet apart from each other), I have something similar that I've written and am using to automate generation of patches and running of checkpatch. I'll sync up with him today and see if it makes sense to merge our efforts and post the result. -Anton Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Drun'? 'm not drun'! You woudn' dare call m' drun' if I was sober! - Terry Pratchett, _Men at Arms_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] MAKEALL
On Tuesday 18 October 2011 02:23:10 Wolfgang Denk wrote: Before sending the patch, you must run the MAKEALL script on your patched source tree and make sure that no errors or warnings are reported for any of the boards. Well, at least not any more warnings than without your patch. It is strongly recommended to verify that out-of-tree building (with -O make option resp. BUILD_DIR environment variable) is still working. For example, run: $ BUILD_DIR=/tmp/u-boot-build ./MAKEALL Why is nobody doing this? because MAKEALL is a pita to use. it has no automatic CROSS_COMPILE support, and the current logic only allows one-CROSS_COMPILE-setting-per-run. so you have to run MAKEALL by hand once per arch. the documentation you quote only shows running MAKEALL for powerpc (since that's the default), so even the docs are a bit unclear. ideally, MAKEALL should be intelligent and automatically find an appropriate toolchain if one isn't setup in the env. much like the buildall script i posted recently. -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
On Mon, Oct 17, 2011 at 11:23 PM, Wolfgang Denk w...@denx.de wrote: Hi all, the patches that have been submitted for this release turn out to of of shockingly bad quality. About every other batch of patches I apply will break building not only for a single board r a few boards, but for large numbers of boards, including whole processor families and even whole architectures. Not to mention the huge number of patches that have to be rejected because they raise tons or errors and warnings from checkpatch.pl The time I have available is limited even without such avoidable problems, and I really, really rather spend it on constructive work instead of continuously running git bisect to track down the culprits. What's even worse is that it appears that I am the only person in this whole community who runs any build tests. Or how comes that it's always me who detects such build breakages? Note # 3 at http://www.denx.de/wiki/U-Boot/Patches says: Before sending the patch, you must run the MAKEALL script on your patched source tree and make sure that no errors or warnings are reported for any of the boards. Well, at least not any more warnings than without your patch. It is strongly recommended to verify that out-of-tree building (with -O make option resp. BUILD_DIR environment variable) is still working. For example, run: $ BUILD_DIR=/tmp/u-boot-build ./MAKEALL Why is nobody doing this? I would like to start a thread addressing this question. I don't think the people submitting are running MAKEALL because it has a very high barrier to entry. In particular I spent a few days trying to get as many architecture toolchains up and running as I could so that I could run MAKEALL to fully test my builds. The result was frustrating. I was only able to get ARM to build (Our local toolchain works, but I also got the ELDK toolchain to work for me). I was not able to get the ELDK toolchain for PowerPC to work however. -Anton Ahh, looks like Mike agrees... I cannot continue like that. We need to find ways to improve the quality of the submitted patches, and to distribute the work load for testing. I need your help. Thanks. Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There are no data that cannot be plotted on a straight line if the axis are chosen correctly. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] OMAP3: mvblx: Initial support for mvBlueLYNX-X
On Wed, Oct 5, 2011 at 8:08 AM, Michael Jones michael.jo...@matrix-vision.de wrote: Add support for the MATRIX VISION mvBlueLYNX-X, an OMAP3-based intelligent camera. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de Configuring for omap3_mvblx board... mv_common.c:32:14: warning: 'entries_to_keep' defined but not used textdata bss dec hex filename 2255834696 215012 445291 6cb6b ./u-boot Please fix the warning, thanks. -- Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] MAKEALL
Hi, On Tue, Oct 18, 2011 at 10:01 AM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 18 October 2011 02:23:10 Wolfgang Denk wrote: Before sending the patch, you must run the MAKEALL script on your patched source tree and make sure that no errors or warnings are reported for any of the boards. Well, at least not any more warnings than without your patch. It is strongly recommended to verify that out-of-tree building (with -O make option resp. BUILD_DIR environment variable) is still working. For example, run: $ BUILD_DIR=/tmp/u-boot-build ./MAKEALL Why is nobody doing this? because MAKEALL is a pita to use. it has no automatic CROSS_COMPILE support, and the current logic only allows one-CROSS_COMPILE-setting-per-run. so you have to run MAKEALL by hand once per arch. the documentation you quote only shows running MAKEALL for powerpc (since that's the default), so even the docs are a bit unclear. ideally, MAKEALL should be intelligent and automatically find an appropriate toolchain if one isn't setup in the env. much like the buildall script i posted recently. Yes I think this is along the right track. I tried MAKEALL a long time ago and it didn't work (just got an error about incorrect architecture) so I assumed it was broken. Apart from full docs, it would be good to have a place to download all the toolchains needed for MAKEALL. Regards, Simon -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
Le 18/10/2011 19:16, Anton Staaf a écrit : I would like to start a thread addressing this question. I don't think the people submitting are running MAKEALL because it has a very high barrier to entry. In particular I spent a few days trying to get as many architecture toolchains up and running as I could so that I could run MAKEALL to fully test my builds. The result was frustrating. I was only able to get ARM to build (Our local toolchain works, but I also got the ELDK toolchain to work for me). I was not able to get the ELDK toolchain for PowerPC to work however. -Anton Ahh, looks like Mike agrees... As far as I am concerned, I do run ./MAKEALL arm (or a subset) usually before requesting pulls and before applying pull requests, and I have ELD and CS ARM toolchains in place, but I never run MAKEALL on other arches than ARM. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request for u-boot-marvell.git
Hi Prafulla, Le 18/10/2011 13:12, Prafulla Wadaskar a écrit : Hi Albert Please kindly pull The following changes since commit 0e005ee09d3424e2780efc6895fcbfbdf7a492fa: Prafulla Wadaskar (1): Merge branch 'master' of git://git.marvell.com/mirror/denx.de/u-boot-arm into armmaster This commit is not present in u-boot-arm... It is the result of a merge of u-boot-arm/master into u-boot-marvell/master. This is not the way a pull request should be prepared according to the U-Boot Wiki. I would much prefer you to fetch u-boot-arm/master, then rebase your master branch onto it, then request a pull relative to u-boot-arm/master, i.e. use the following commands (assuming your git setup has a remote called u-boot-arm) git fetch u-boot-arm git checkout master git rebase u-boot-arm/master git push ... git request-pull Regards.. Prafulla . . . Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] MAKEALL
On Tue, Oct 18, 2011 at 10:01 AM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 18 October 2011 02:23:10 Wolfgang Denk wrote: Before sending the patch, you must run the MAKEALL script on your patched source tree and make sure that no errors or warnings are reported for any of the boards. Well, at least not any more warnings than without your patch. It is strongly recommended to verify that out-of-tree building (with -O make option resp. BUILD_DIR environment variable) is still working. For example, run: $ BUILD_DIR=/tmp/u-boot-build ./MAKEALL Why is nobody doing this? because MAKEALL is a pita to use. it has no automatic CROSS_COMPILE support, and the current logic only allows one-CROSS_COMPILE-setting-per-run. so you have to run MAKEALL by hand once per arch. the documentation you quote only shows running MAKEALL for powerpc (since that's the default), so even the docs are a bit unclear. ideally, MAKEALL should be intelligent and automatically find an appropriate toolchain if one isn't setup in the env. much like the buildall script i posted recently. If we're going to throw out feature requests, I'd like more than one SoC family support. I've got a wrapper around MAKEALL right now to build omap3 then omap4 then davinci. -- Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [STATUS] Quality of patches / testing.
On Tue, Oct 18, 2011 at 10:44 AM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: Le 18/10/2011 19:16, Anton Staaf a écrit : I would like to start a thread addressing this question. I don't think the people submitting are running MAKEALL because it has a very high barrier to entry. In particular I spent a few days trying to get as many architecture toolchains up and running as I could so that I could run MAKEALL to fully test my builds. The result was frustrating. I was only able to get ARM to build (Our local toolchain works, but I also got the ELDK toolchain to work for me). I was not able to get the ELDK toolchain for PowerPC to work however. -Anton Ahh, looks like Mike agrees... As far as I am concerned, I do run ./MAKEALL arm (or a subset) usually before requesting pulls and before applying pull requests, and I have ELD and CS ARM toolchains in place, but I never run MAKEALL on other arches than ARM. Simon pointed me to another thread where Mike published his buildall script and a repository of toolchains. I'm going to try and set that up and see if it works for me. I would love to be able to do a full MAKEALL for all architectures. Especially since I plan to do more architecture independent work in U-Boot. Thanks, Anton Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] tegra2: Enable CONFIG_SYS_RELATIVE_IMAGES
Stephen Warren wrote at Tuesday, October 11, 2011 10:16 AM: v2: New patch Signed-off-by: Stephen Warren swar...@nvidia.com Wolfgang, Does this new patch series look good? It doesn't look like patch 1/3 (the cleanup patch for pre-existing checkpatch failures) ever made it to the mailing list; it was deemed too large and held for moderation, but was never accepted. How should I handle this? Thanks. -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] MAKEALL
On Tuesday 18 October 2011 13:58:22 Tom Rini wrote: On Tue, Oct 18, 2011 at 10:01 AM, Mike Frysinger wrote: On Tuesday 18 October 2011 02:23:10 Wolfgang Denk wrote: Before sending the patch, you must run the MAKEALL script on your patched source tree and make sure that no errors or warnings are reported for any of the boards. Well, at least not any more warnings than without your patch. It is strongly recommended to verify that out-of-tree building (with -O make option resp. BUILD_DIR environment variable) is still working. For example, run: $ BUILD_DIR=/tmp/u-boot-build ./MAKEALL Why is nobody doing this? because MAKEALL is a pita to use. it has no automatic CROSS_COMPILE support, and the current logic only allows one-CROSS_COMPILE-setting-per-run. so you have to run MAKEALL by hand once per arch. the documentation you quote only shows running MAKEALL for powerpc (since that's the default), so even the docs are a bit unclear. ideally, MAKEALL should be intelligent and automatically find an appropriate toolchain if one isn't setup in the env. much like the buildall script i posted recently. If we're going to throw out feature requests, I'd like more than one SoC family support. I've got a wrapper around MAKEALL right now to build omap3 then omap4 then davinci. well, i think yours has a much easier chance of being implemented. and should be trivial to do with boards_by_soc. although i think i have a better idea. i'll post a patch. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request: u-boot-imx
Le 17/10/2011 10:05, Stefano Babic a écrit : Hi Albert, please pull from u-boot-imx, thanks. Generating the pull request I see that three patches are missing (the three patches by Łukasz Majewski). However, everything in the tree seems correct and the tree is already rebased on uboot_arm. Let me know if you find any issue. The following changes since commit e36544d37385c4a4b525e18326feb3664d2268fa: omap: overo: Disable pull-ups on camera PCLK, HS and VS signals (2011-10-14 22:15:13 +0200) are available in the git repository at: git://www.denx.de/git/u-boot-imx.git master Fabio Estevam (2): mx31pdk: Remove unneeded config imx: fix coding style Helmut Raiger (1): mx31: provide readable WEIM CS accessor Marek Vasut (1): I2C: Add i2c_get/set_speed() to mxc_i2c.c Stefano Babic (15): MX51: vision2: Set global macros misc: pmic: Freescale PMIC switches to generic PMIC driver MX5: vision2: use new pmic driver RTC: Switch mc13783 to generic pmic code MX3: qong: use new pmic driver MX5: efikamx/efikasb: use new pmic driver misc: pmic: use I2C_SET_BUS in pmic I2C misc: pmic: addI2C support to pmic_fsl driver MX35: mx35pdk: use new pmic driver MX5: mx51evk: use new pmic driver MX5: mx53evk: use new pmic driver MX31: mx31_litekit: use new pmic driver MX31: mx31ads: use new pmic driver Weird: these two commits: misc:pmic:max8998 MAX8998 support at a new PMIC driver. misc:pmic:samsung Enable PMIC driver at GONI target are attributed to you whereas in your branch they are attributed to Łukasz Majewski -- plus a third one not mentioned above. I did a git request-pull on my side, and find the following entries: Stefano Babic (15): MX51: vision2: Set global macros misc: pmic: Freescale PMIC switches to generic PMIC driver MX5: vision2: use new pmic driver RTC: Switch mc13783 to generic pmic code MX3: qong: use new pmic driver MX5: efikamx/efikasb: use new pmic driver misc: pmic: use I2C_SET_BUS in pmic I2C misc: pmic: addI2C support to pmic_fsl driver MX35: mx35pdk: use new pmic driver MX5: mx51evk: use new pmic driver MX5: mx53evk: use new pmic driver MX31: mx31_litekit: use new pmic driver MX31: mx31ads: use new pmic driver (the next two commits are missing in your list) MX31: mx31pdk: use new pmic driver misc: pmic: drop old Freescale's pmic driver Łukasz Majewski (3): (the next commit is missing in your list) misc:pmic:core New generic PMIC driver (the next two commits are misattributed in your list) misc:pmic:max8998 MAX8998 support at a new PMIC driver. misc:pmic:samsung Enable PMIC driver at GONI target Note that I find the same list of modifications as stated below, which implies that only the attribution list above is incorrect. arch/arm/cpu/arm1136/mx31/generic.c | 11 ++ arch/arm/cpu/arm1136/mx31/timer.c | 23 ++- arch/arm/cpu/arm1136/mx35/generic.c |2 +- arch/arm/cpu/arm926ejs/mx25/generic.c | 110 +++--- arch/arm/cpu/arm926ejs/mx25/reset.c |2 +- arch/arm/cpu/arm926ejs/mx25/timer.c | 16 +- arch/arm/cpu/arm926ejs/mx27/reset.c |2 +- arch/arm/cpu/arm926ejs/mx27/timer.c | 14 +- arch/arm/cpu/armv7/mx5/soc.c| 10 +- arch/arm/include/asm/arch-mx31/imx-regs.h | 35 - arch/arm/include/asm/arch-mx31/sys_proto.h | 35 arch/arm/include/asm/arch-mx5/sys_proto.h |8 + board/davedenx/qong/qong.c | 107 ++--- board/efikamx/efikamx.c | 51 --- board/freescale/mx31ads/mx31ads.c | 16 ++- board/freescale/mx31pdk/mx31pdk.c | 14 ++- board/freescale/mx35pdk/mx35pdk.c | 18 ++- board/freescale/mx51evk/mx51evk.c | 47 +++--- board/freescale/mx53evk/mx53evk.c | 17 ++- board/imx31_phycore/imx31_phycore.c | 41 - board/karo/tx25/tx25.c |2 +- board/logicpd/imx27lite/imx27lite.c |6 +- board/logicpd/imx31_litekit/imx31_litekit.c | 30 +++- board/samsung/goni/goni.c |4 + board/ttcontrol/vision2/vision2.c | 33 +++-- boards.cfg |3 +- drivers/i2c/mxc_i2c.c | 31 +++- drivers/misc/Makefile |6 +- drivers/misc/fsl_pmic.c | 235 --- drivers/misc/pmic_core.c| 147 + drivers/misc/pmic_fsl.c | 66 drivers/misc/pmic_i2c.c | 92 +++ drivers/misc/pmic_max8998.c | 43 +
Re: [U-Boot] [PATCH v6 1/5] tegra2: Use cmd_link_o_target in board Makefiles
Stephen Warren wrote at Wednesday, October 12, 2011 4:53 PM: [Patch series relating to SD/MMC support on Tegra boards.] Does this patch series look good? Since these are my first U-Boot patches, I'm not sure exactly who would pick these up and apply them (I assume the ARM custodians, who are CC'd) nor what I should expect in terms of when they'd be applied. Thanks. -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] MAKEALL
On Tuesday 18 October 2011 13:58:22 Tom Rini wrote: If we're going to throw out feature requests, I'd like more than one SoC family support. I've got a wrapper around MAKEALL right now to build omap3 then omap4 then davinci. hmm, actually doesn't the newish -s flag do what you want ? ./MAKEALL -s omap3 arm -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6 1/5] tegra2: Use cmd_link_o_target in board Makefiles
Hi Tom, On Tue, Oct 18, 2011 at 11:14 AM, Stephen Warren swar...@nvidia.com wrote: Stephen Warren wrote at Wednesday, October 12, 2011 4:53 PM: [Patch series relating to SD/MMC support on Tegra boards.] Does this patch series look good? Since these are my first U-Boot patches, I'm not sure exactly who would pick these up and apply them (I assume the ARM custodians, who are CC'd) nor what I should expect in terms of when they'd be applied. This patch set looks good to me, and is the next series that needs to be applied to move Tegra along. I have based my latest series 'tegra2: Tidy up boot path' on your series. Albert are you happy to apply Stephen's patch series? Regards, Simon Thanks. -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
