Re: [U-Boot] [PATCH] Add initial support for mx6slevk board
Hi Fabio, Am 30.03.2013 22:08, schrieb Fabio Estevam: From: Fabio Estevam mx6slevk board is a development board from Freescale based on the mx6 solo lite processor. For details about mx6slevk, please refer to: http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=IMX6SLEVK&parentCode=i.MX6SL&fpsp=1 Signed-off-by: Fabio Estevam --- MAINTAINERS|1 + arch/arm/cpu/armv7/mx6/clock.c | 38 +- arch/arm/include/asm/arch-mx6/crm_regs.h |1 + arch/arm/include/asm/arch-mx6/imx-regs.h | 63 +- arch/arm/include/asm/arch-mx6/mx6-pins.h |4 + arch/arm/include/asm/arch-mx6/mx6sl_pins.h | 1374 Would it make sense to split this patch into two parts? One general "add i.MX6 SoloLite support" and then the "add mx6slevk board board support"? board/freescale/mx6slevk/Makefile | 28 + board/freescale/mx6slevk/imximage.cfg | 118 +++ board/freescale/mx6slevk/mx6slevk.c| 102 +++ boards.cfg |1 + include/configs/mx6slevk.h | 189 11 files changed, 1916 insertions(+), 3 deletions(-) create mode 100644 arch/arm/include/asm/arch-mx6/mx6sl_pins.h create mode 100644 board/freescale/mx6slevk/Makefile create mode 100644 board/freescale/mx6slevk/imximage.cfg create mode 100644 board/freescale/mx6slevk/mx6slevk.c create mode 100644 include/configs/mx6slevk.h ... +# diff --git a/board/freescale/mx6slevk/imximage.cfg b/board/freescale/mx6slevk/imximage.cfg new file mode 100644 index 000..df39a16 --- /dev/null +++ b/board/freescale/mx6slevk/imximage.cfg @@ -0,0 +1,118 @@ +/* + * Copyright (C) 2013 Freescale Semiconductor, Inc. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License or (at your option) any later version. + * + * Refer docs/README.imxmage for more details about how-to configure + * and create imximage boot image + * + * The syntax is taken as close as possible with the kwbimage + */ + +/* image version */ + +IMAGE_VERSION 2 + +/* + * Boot Device : one of + * spi, sd (the board has no nand neither onenand) + */ + +BOOT_FROM sd + +/* + * Device Configuration Data (DCD) + * + * Each entry must have the format: + * Addr-type AddressValue + * + * where: + * Addr-type register length (1,2 or 4 bytes) + * Address absolute address of the register + * value value to be stored in the register + */ +DATA 4 0x020c4018 0x00260324 + +DATA 4 0x020c4068 0x +DATA 4 0x020c406c 0x +DATA 4 0x020c4070 0x +DATA 4 0x020c4074 0x +DATA 4 0x020c4078 0x +DATA 4 0x020c407c 0x +DATA 4 0x020c4080 0x I haven't looked into the manual, but are these the clock registers? If so, is it necessary to set them to 0x? Or are these already the default reset values? ... diff --git a/include/configs/mx6slevk.h b/include/configs/mx6slevk.h new file mode 100644 index 000..67b63f4 --- /dev/null +++ b/include/configs/mx6slevk.h @@ -0,0 +1,189 @@ +/* + * Copyright 2013 Freescale Semiconductor, Inc. + * + * Configuration settings for the Freescale i.MX6SL EVK board. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + */ + +#ifndef __CONFIG_H +#define __CONFIG_H + +#include +#include + +#define CONFIG_MX6 +#define CONFIG_DISPLAY_CPUINFO +#define CONFIG_DISPLAY_BOARDINFO + +#define MACH_TYPE_MX6SLEVK 4307 Below, you seem to boot with device tree. Is this necessary, then? +#define CONFIG_MACH_TYPE MACH_TYPE_MX6SLEVK + +#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS +#define CONFIG_INITRD_TAG +#define CONFIG_REVISION_TAG + +/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN (3 * SZ_1M) + +#define CONFIG_BOARD_EARLY_INIT_F +#define CONFIG_MXC_GPIO + +#define CONFIG_MXC_UART +#define CONFIG_MXC_UART_BASE UART1_IPS_BASE_ADDR + +/* MMC Configs */ +#define CONFIG_FSL_ESDHC +#define CONFIG_FSL_USDHC +#define CONFIG_SYS_FSL_ESDHC_ADDR 0 + +#define CONFIG_MMC +#define CONFIG_CMD_MMC +#define CONFIG_GENERIC_MMC +#define CONFIG_CMD_FAT +#define CONFIG_DOS_PARTITION + +/* allow to overwrite serial and ethaddr */ +#define CONFIG_ENV_OVERWRITE +#define CONFIG_CONS_INDEX 1 +#define CONFIG_BAUDRATE115200 + +/* Command definition */ +#include + +#undef CONFIG_CMD_IMLS + +#define CONFIG_BOOTDELAY 3 + +#define CONFIG_LOADADDR0x8080 +#define CONFIG_SYS_TEXT_BASE
Re: [U-Boot] Handling images(.jpg, .bmp etc) in u-boot
I created a partition in my eMMC, used fastboot to flash a "example.bmp".. How do I get the base address of the partition ? I have the following partitions on my device running android, has a u-boot bootloader U-Boot 1.1.4.XTRAVERSION-g6c554dbc-dirty (Mar 26 2013 - 14:26:11 Load address: 0x80e8 DRAM: 512 MB Flash: 0 kB Using default environment In: serial Out: serial Err: serial efi partition table: ptbl slot:EMMC:(1). 256 128K xloader 512 3M bootloader 6656 512K splash 7680 128K misc 8704 64M efs 13977616Kcrypto 13980816Mrecovery 1725768M boot 188960512M system 1237536 256M cache 1761824 128M apk 2023968 2787Muserdata How do I get the base address of each partition, I tried the following commands in u-boot but It either gives me an error or doesn't return anything 1. # flinfo Bank # 1: missing or unknown FLASH type Bank # 2: missing or unknown FLASH type 2. fsinfo Device Hangs up 3. # fli Bank # 1: missing or unknown FLASH type Bank # 2: missing or unknown FLASH type Please help me find the base address of each of the partition. -- View this message in context: http://u-boot.10912.n7.nabble.com/Handling-images-jpg-bmp-etc-in-u-boot-tp150524p151089.html Sent from the U-Boot mailing list archive at Nabble.com. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 0/31] Create generic board init for ARM, x86, PPC
Hi Wolfgang, On Wed, Mar 13, 2013 at 1:46 AM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1363020460-14307-1-git-send-email-...@chromium.org> you wrote: > > This series creates a generic board init implementation which contains > > the essential functions of the major arch/xxx/lib/board.c files. It is > > split into two parts: board_f.c for pre-relocation and board_r.c for > > post-relocation. > ... > > ARM is a relatively large board.c file and one which I can test, > therefore > > I think it is a good target for this series. On the other hand, x86 is > > relatively small and simple, but different enough that it introduces a > > few issues to be solved. So I have chosen both ARM and x86 for this > series. > > After a suggestion from Wolfgang I have added PPC also. This is the > > largest and most feature-full board, so hopefully we have all bases > > covered in this series. Other archs are mostly a subset of these. > > I did some testing on Power Architecture systems - to be precise: > > CPU Board > -- > MPC860T TQM860L > MPC5200 TQM5200S > PPC405EXKilauea > PPC440EPYosemite > PPC440EXSequoia > PPC440SPe Katmai > PPC460EXCanyonlands > > On all boards I verified at least environment access (printenv, > saveenv) and network operation (TFTP download); where available also > PCI. Everything appears to work fine, no problems noted. > > A well done job, thanks a lot! > Thanks for your comments which are much appreciated. There is still work to do, in cleaning up the implementation to reduce the differences between arch code (e.g. all the #ifdefs in board_f/r.c). But this is a great first step and I am pleased to get this in. > > For the whole series: > > Tested-by: Wolfgang Denk > Acked-by: Wolfgang Denk > > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > Certain old men prefer to rise at dawn, taking a cold bath and a long > walk with an empty stomach and otherwise mortifying the flesh. They > then point with pride to these practices as the cause of their sturdy > health and ripe years; the truth being that they are hearty and old, > not because of their habits, but in spite of them. The reason we find > only robust persons doing this thing is that it has killed all the > others who have tried it. - Ambrose Bierce, "The Devil's Dictionary" > But I wonder if this is trying to tell me to stop these tricky refactors :-) Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC] MAKEALL: Fix case substitution for old bash
+U-Boot Hi Allen, York, On Fri, Mar 29, 2013 at 11:05 AM, Allen Martin wrote: > On Fri, Mar 29, 2013 at 10:56:33AM -0700, York Sun wrote: > > On 03/29/2013 10:52 AM, Allen Martin wrote: > > > On Fri, Mar 29, 2013 at 10:49:06AM -0700, York Sun wrote: > > >> On 03/29/2013 10:29 AM, Allen Martin wrote: > > >>> On Fri, Mar 29, 2013 at 09:56:41AM -0700, York Sun wrote: > > On 03/27/2013 12:55 PM, Tom Rini wrote: > > > On Thu, Mar 21, 2013 at 01:38:37PM -0700, York Sun wrote: > > >> On 03/21/2013 01:28 PM, Allen Martin wrote: > > > [snip] > > >>> PS: What happened with your bool fixup patch? I'm a big fan of > that > > >>> patch :^) > > >>> > > >> > > >> Tom asked on March 4th. I think he will accept it. > > > > > > I never got the expected acks on v7 that I thought would be > forthcoming. > > > > > > > Allen, > > > > Can you ack the v7 of the bool fixup patch? Tom seems waiting for > you. > > >>> > > >>> Oh sorry, I didn't realize there was a newer version of the patch I > > >>> hadn't ack'ed yet. I'll take a look today. Do you know if it still > > >>> applies cleanly to TOT u-boot/master, or will it need to be rebased? > > >>> > > >> > > >> It almost applies cleanly. > > >> > > >> Checking patch board/xilinx/common/xbasic_types.h... > > >> error: board/xilinx/common/xbasic_types.h: does not exist in index > > >> > > >> due to commit > > >> > > >> commit 151eeeb2754da4b2d26bb878206d45ce58276fe0 > > >> Author: Michal Simek > > >> Date: Wed Jan 23 14:11:50 2013 +0100 > > >> > > >> board: xilinx: Remove common folder > > >> > > >> All these files was used for ancient xilinx drivers > > >> which are finally gone. > > >> > > >> Signed-off-by: Michal Simek > > >> Tested-by: Rommel Custodio > > >> > > >> board/xilinx/common/xbasic_types.c | 165 > > >> board/xilinx/common/xbasic_types.h | 283 -- > > >> board/xilinx/common/xbuf_descriptor.h | 252 -- > > >> board/xilinx/common/xdma_channel.c | 738 > > >> board/xilinx/common/xdma_channel.h | 291 -- > > >> board/xilinx/common/xdma_channel_i.h | 110 --- > > >> board/xilinx/common/xdma_channel_sg.c | 1317 > > >> > > >> board/xilinx/common/xio.h | 81 -- > > >> board/xilinx/common/xipif_v1_23_b.c| 331 --- > > >> board/xilinx/common/xipif_v1_23_b.h| 746 > > >> board/xilinx/common/xpacket_fifo_v1_00_b.c | 448 -- > > >> board/xilinx/common/xpacket_fifo_v1_00_b.h | 306 --- > > >> board/xilinx/common/xstatus.h | 347 > > >> board/xilinx/common/xversion.c | 350 > > >> board/xilinx/common/xversion.h | 97 -- > > >> board/xilinx/zynq/Makefile |3 - > > >> 16 files changed, 5865 deletions(-) > > >> > > >> > > >> Do I need to send a newer version? > > >> > > > > > > Tom will probably make you send a newer one anyway. I'll fix it up > > > locally and start testing in the mean time. > > > > > > > Allen, > > > > I didn't change anything for the version, only removed "RFC" from the > > subject. I have been there for quite a while. I thought Tom was going to > > pick it up. > > Yeah sorry, I would have re-acked it if I saw there was a new > version. Since it no longer applies cleanly I'm pretty sure he'll ask > you to send a new version that does even if there are no other > differences. > > Maybe we can talk Simon Glass into testing it out with his super fast > multi-arch u-boot builder. It's way fancier than the perl script I > use. Adding Simon. > > The patch in question is: > http://patchwork.ozlabs.org/patch/217088/ Yes, it needs a rebase, but the change is minor - I hope we can get this in. York can you do a rebase? Here are the boards that seem to fail: EVB64260 ZUMA EVB64260_750CX P3G4 Full output: 02: Consolidate bool type powerpc: + EVB64260 ZUMA EVB64260_750CX P3G4 +In file included from memory.c:9:0: +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:62:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:63:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:66:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:70:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:77:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:82:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:83:1: error: unknown type name 'bool' +/c/cosarm/src/third_party/u-boot/try-york/.bm-work/12/include/galileo/memory.h:8
Re: [U-Boot] [PATCH] Exynos: uart: s5p: enabling the uart tx/rx fifo
Hi Akshay
On Thu, Mar 21, 2013 at 11:33 PM, Akshay Saraswat wrote:
> This patch enables the uart tx/rx fifo. Now that fifo is enabled,
> the uart read/write functions are modfied to check the UFSTAT register
> for fifo status instead of UTRSTAT (as required with fifo's enabled).
> Tested by booting linux kernel. Before enabling tx/rx fifo
> "Uncompressing linux" message is garbled and after enabling it is proper.
>
Is this because Linux enables the FIFOs?
Anyway this seems fine to me, but I have a question below.
>
> Signed-off-by: Alim Akhtar
> Signed-off-by: Akshay Saraswat
> ---
> drivers/serial/serial_s5p.c | 13 +
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c
> index 3c41242..e65125c 100644
> --- a/drivers/serial/serial_s5p.c
> +++ b/drivers/serial/serial_s5p.c
> @@ -30,6 +30,10 @@
>
> DECLARE_GLOBAL_DATA_PTR;
>
> +#define RX_FIFO_COUNT_MASK 0xff
> +#define RX_FIFO_FULL_MASK (1 << 8)
> +#define TX_FIFO_FULL_MASK (1 << 24)
> +
> static inline struct s5p_uart *s5p_get_base_uart(int dev_index)
> {
> u32 offset = dev_index * sizeof(struct s5p_uart);
> @@ -87,8 +91,8 @@ int serial_init_dev(const int dev_index)
> {
> struct s5p_uart *const uart = s5p_get_base_uart(dev_index);
>
> - /* reset and enable FIFOs, set triggers to the maximum */
> - writel(0, &uart->ufcon);
> + /* enable FIFOs */
> + writel(0x1, &uart->ufcon);
>
It is odd that you seem to be saying that the old code did not enable
FIFOs, but this code does? Or should you update your comment?
> writel(0, &uart->umcon);
> /* 8N1 */
> writel(0x3, &uart->ulcon);
> @@ -130,7 +134,8 @@ int serial_getc_dev(const int dev_index)
> struct s5p_uart *const uart = s5p_get_base_uart(dev_index);
>
> /* wait for character to arrive */
> - while (!(readl(&uart->utrstat) & 0x1)) {
> + while (!(readl(&uart->ufstat) & (RX_FIFO_COUNT_MASK |
> +RX_FIFO_FULL_MASK))) {
> if (serial_err_check(dev_index, 0))
> return 0;
> }
> @@ -146,7 +151,7 @@ void serial_putc_dev(const char c, const int dev_index)
> struct s5p_uart *const uart = s5p_get_base_uart(dev_index);
>
> /* wait for room in the tx FIFO */
> - while (!(readl(&uart->utrstat) & 0x2)) {
> + while ((readl(&uart->ufstat) & TX_FIFO_FULL_MASK)) {
> if (serial_err_check(dev_index, 1))
> return;
> }
> --
> 1.8.0
>
>
Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 7/7] cros: enable cros-ec for smdk5250
On Thu, Mar 28, 2013 at 12:46 AM, Hung-ying Tyan wrote: > This patch initiates cros-ec in board_init() to enable it for smdk5250. > > Signed-off-by: Simon Glass > Signed-off-by: Vincent Palatin > Signed-off-by: Hung-ying Tyan > > --- > Changes in v3: None > Changes in v2: > - Moved code from smdk5250.c (non-FDT) to exynos5-dt.c (FDT). > - Moved code from smdk5250.h to exynos5250-dt.h. > - Added commit message. > - Dropped the period from commit subject. > Acked-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 6/7] cros: exynos: add cros-ec device nodes to exynos5250-snow.dts
Hi Hung-ying, On Thu, Mar 28, 2013 at 12:45 AM, Hung-ying Tyan wrote: > Signed-off-by: Hung-ying Tyan > This seems to have lost its commit message? > > --- > Changes in v3: None > Changes in v2: > - Added gpio node to exynos5250.dtsi. > - Added commit message. > - Dropped the period from commit subject. > > arch/arm/dts/exynos5250.dtsi | 3 ++ > board/samsung/dts/exynos5250-snow.dts | 82 > +++ > 2 files changed, 85 insertions(+) > > Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 5/7] cros: adds cros_ec keyboard driver
On Thu, Mar 28, 2013 at 12:45 AM, Hung-ying Tyan wrote: > This patch adds the driver for keyboard that's controlled by ChromeOS EC. > > Signed-off-by: Randall Spangler > Signed-off-by: Simon Glass > Signed-off-by: Vincent Palatin > Signed-off-by: Hung-ying Tyan > > --- > Changes in v3: > - Rearranged #include directives in alphabetical order. > - Removed outdated TODO and irrelevant bug reference in comments. > > Changes in v2: > - Fixed warnings of exceeding 80 chars in a line. > - Added commit message. > - Dropped the period from commit subject. > > Acked-by: Simon Glass > README | 5 + > drivers/input/Makefile | 1 + > drivers/input/cros_ec_keyb.c | 261 > +++ > include/fdtdec.h | 1 + > lib/fdtdec.c | 1 + > 5 files changed, 269 insertions(+) > create mode 100644 drivers/input/cros_ec_keyb.c > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 4/7] cros: add LPC support for cros_ec
On Thu, Mar 28, 2013 at 12:45 AM, Hung-ying Tyan wrote: > This patch adds LPC support for carrying out the cros_ec protocol. > > Signed-off-by: Randall Spangler > Signed-off-by: Simon Glass > Signed-off-by: Hung-ying Tyan > > --- > Changes in v3: None > Changes in v2: > - Fixed warnings of exceeding 80 chars in a line. > - Added commit message. > - Dropped the period from commit subject. > Acked-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 3/7] cros: add SPI support for cros_ec
Hi Hung-ying,
On Thu, Mar 28, 2013 at 12:45 AM, Hung-ying Tyan wrote:
> This patch adds SPI support for carrying out the cros_ec protocol.
>
> Signed-off-by: Hung-ying Tyan
> Signed-off-by: Randall Spangler
> Signed-off-by: Simon Glass
>
> ---
> Changes in v3: None
> Changes in v2:
> - Fixed warnings of exceeding 80 chars in a line.
> - Added commit message.
> - Dropped the period from commit subject.
>
> drivers/misc/Makefile | 1 +
> drivers/misc/cros_ec_spi.c | 166
> +
> drivers/spi/exynos_spi.c | 22 ++
> include/spi.h | 16 +
> 4 files changed, 205 insertions(+)
> create mode 100644 drivers/misc/cros_ec_spi.c
>
> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> index 9363ef9..18209ec 100644
> --- a/drivers/misc/Makefile
> +++ b/drivers/misc/Makefile
> @@ -32,6 +32,7 @@ COBJS-$(CONFIG_GPIO_LED) += gpio_led.o
> COBJS-$(CONFIG_FSL_MC9SDZ60) += mc9sdz60.o
> COBJS-$(CONFIG_CROS_EC) += cros_ec.o
> COBJS-$(CONFIG_CROS_EC_I2C) += cros_ec_i2c.o
> +COBJS-$(CONFIG_CROS_EC_SPI) += cros_ec_spi.o
> COBJS-$(CONFIG_NS87308) += ns87308.o
> COBJS-$(CONFIG_PDSP188x) += pdsp188x.o
> COBJS-$(CONFIG_STATUS_LED) += status_led.o
> diff --git a/drivers/misc/cros_ec_spi.c b/drivers/misc/cros_ec_spi.c
> new file mode 100644
> index 000..82cc1bb
> --- /dev/null
> +++ b/drivers/misc/cros_ec_spi.c
> @@ -0,0 +1,166 @@
> +/*
> + * Chromium OS cros_ec driver - SPI interface
> + *
> + * Copyright (c) 2012 The Chromium OS Authors.
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +/*
> + * The Matrix Keyboard Protocol driver handles talking to the keyboard
> + * controller chip. Mostly this is for keyboard functions, but some other
> + * things have slipped in, so we provide generic services to talk to the
> + * KBC.
> + */
> +
> +#include
> +#include
> +#include
> +
> +#ifdef CONFIG_NEW_SPI_XFER
> +#error "CONFIG_NEW_SPI_XFER not supported in CROS_EC"
> +#endif
>
This is an artifact of old code and can be removed.
> +
> +/**
> + * Send a command to a LPC CROS_EC device and return the reply.
> + *
> + * The device's internal input/output buffers are used.
> + *
> + * @param dev CROS_EC device
> + * @param cmd Command to send (EC_CMD_...)
> + * @param cmd_version Version of command to send (EC_VER_...)
> + * @param dout Output data (may be NULL If dout_len=0)
> + * @param dout_len Size of output data in bytes
> + * @param dinp Returns pointer to response data. This will be
> + * untouched unless we return a value > 0.
> + * @param din_len Maximum size of response in bytes
> + * @return number of bytes in response, or -1 on error
> + */
> +int cros_ec_spi_command(struct cros_ec_dev *dev, uint8_t cmd, int
> cmd_version,
> +const uint8_t *dout, int dout_len,
> +uint8_t **dinp, int din_len)
> +{
> + int in_bytes = din_len + 4; /* status, length, checksum,
> trailer */
> + uint8_t *out;
> + uint8_t *p;
> + int csum, len;
> + int rv;
> +
> + /*
> +* Sanity-check input size to make sure it plus transaction
> overhead
> +* fits in the internal device buffer.
> +*/
> + if (in_bytes > sizeof(dev->din)) {
> + debug("%s: Cannot receive %d bytes\n", __func__, din_len);
> + return -1;
> + }
> +
> + /* We represent message length as a byte */
> + if (dout_len > 0xff) {
> + debug("%s: Cannot send %d bytes\n", __func__, dout_len);
> + return -1;
> + }
> +
> + /*
> +* TODO(s...@chromium.org): Clear input buffer so we don't get
> false
> +* hits for MSG_HEADER
>
You can keep the comment but remove the TODO(...)
> +*/
> + memset(dev->din, '\0', in_bytes);
> +
>
Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 2/7] cros: add I2C support for cros_ec
On Thu, Mar 28, 2013 at 12:45 AM, Hung-ying Tyan wrote: > This patch adds I2C support for carrying out the cros_ec protocol. > > Signed-off-by: Randall Spangler > Signed-off-by: Simon Glass > Signed-off-by: Hung-ying Tyan > > --- > Changes in v3: None > Changes in v2: > - Fixed warnings of exceeding 80 chars in a line. > - Added Commit message. > - Dropped the period from commit subject. > > drivers/misc/Makefile | 1 + > drivers/misc/cros_ec_i2c.c | 199 > + > 2 files changed, 200 insertions(+) > create mode 100644 drivers/misc/cros_ec_i2c.c > > Acked-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 1/7] cros: add cros_ec driver
Hi Hung-ying, On Thu, Mar 28, 2013 at 12:45 AM, Hung-ying Tyan wrote: > This patch adds the cros_ec driver that implements the protocol for > communicating with Google's ChromeOS embedded controller. > > Signed-off-by: Bernie Thompson > Signed-off-by: Bill Richardson > Signed-off-by: Che-Liang Chiou > Signed-off-by: Doug Anderson > Signed-off-by: Gabe Black > Signed-off-by: Hung-ying Tyan > Signed-off-by: Louis Yung-Chieh Lo > Signed-off-by: Randall Spangler > Signed-off-by: Sean Paul > Signed-off-by: Simon Glass > Signed-off-by: Vincent Palatin > > --- > Changes in v3: None > Changes in v2: > - Fixed warnings of exceeding 80 chars in a line. > - Added commit message. > - Dropped the period from commit subject. > > doc/device-tree-bindings/input/cros-ec-keyb.txt | 79 ++ > doc/device-tree-bindings/misc/cros-ec.txt | 38 + > doc/device-tree-bindings/spi/exynos-spi.txt | 55 + > drivers/misc/Makefile |1 + > drivers/misc/cros_ec.c | 1304 > > include/cros_ec.h | 449 +++ > include/cros_ec_message.h | 44 + > include/ec_commands.h | 1440 > +++ > include/fdtdec.h|1 + > lib/fdtdec.c|1 + > Can you please remove the exynos-spi.txt file from here? This is related to the exynos SPI code, not this driver. Also the cros-ec-keyb.txt binding should go with the cros_ec_keyb.c patch I think. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARM: tegra: support T33 SKU of Tegra30
On Wed, Mar 27, 2013 at 12:37 PM, Stephen Warren wrote: > From: Stephen Warren > > Make U-Boot aware of the T33 SKU of Tegra30, and treat it identically > to any other Tegra30. > > An alternative would be to simply remove the SKU checking from > tegra_get_chip_type(); most use of the value most likely simply wants > to know the current chip, not the specific SKU. Or, the function could > be split into separate tegra_get_chip() and tegra_get_sku() for the > cases where differentiation really is required. > > I wonder whether tegra_get_chip_type() should printf() whenever any > unkown chip/SKU is found, although perhaps the function is called so > early that the printf() wouldn't actually make it to the UART anyway. > > Signed-off-by: Stephen Warren > Acked-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] mpc512x: remove dead code
The prt_mpc512x_clks() function isn't referenced
anywhere and its prototype is wrong. Remove it.
Signed-off-by: Anatolij Gustschin
---
arch/powerpc/cpu/mpc512x/speed.c |6 --
include/common.h |3 ---
2 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc/cpu/mpc512x/speed.c b/arch/powerpc/cpu/mpc512x/speed.c
index 9a8f315..6761877 100644
--- a/arch/powerpc/cpu/mpc512x/speed.c
+++ b/arch/powerpc/cpu/mpc512x/speed.c
@@ -151,9 +151,3 @@ U_BOOT_CMD(clocks, 1, 0, do_clocks,
"print clock configuration",
"clocks"
);
-
-int prt_mpc512x_clks (void)
-{
- do_clocks (NULL, 0, 0, NULL);
- return (0);
-}
diff --git a/include/common.h b/include/common.h
index 69eeea4..96e3504 100644
--- a/include/common.h
+++ b/include/common.h
@@ -631,9 +631,6 @@ int prt_8260_clks (void);
#elif defined(CONFIG_MPC5xxx)
intprt_mpc5xxx_clks (void);
#endif
-#if defined(CONFIG_MPC512X)
-intprt_mpc512xxx_clks (void);
-#endif
#if defined(CONFIG_MPC8220)
intprt_mpc8220_clks (void);
#endif
--
1.7.5.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Generalize "cls" command
From: Pali Rohár
Add unified command "cls". Previously this command existed only
as part of the LCD driver, now it is available for other users
as well and supports clearing ANSI terminal. The command is
enabled for all boards defining CONFIG_LCD to be backward
compatible.
Also add command description to README and fix nokia_rx51
board config file to enable the "cls" command.
Signed-off-by: Pali Rohár
Cc: Marcel Mol
Signed-off-by: Anatolij Gustschin
---
This patch is a rework based on the original patch
http://patchwork.ozlabs.org/patch/217492/
README |1 +
common/Makefile |1 +
common/cmd_cls.c | 37 +
common/lcd.c | 13 -
include/common.h |9 +
include/configs/nokia_rx51.h |2 +-
6 files changed, 49 insertions(+), 14 deletions(-)
create mode 100644 common/cmd_cls.c
diff --git a/README b/README
index 7f2506a..b0ea592 100644
--- a/README
+++ b/README
@@ -819,6 +819,7 @@ The following options need to be configured:
CONFIG_CMD_BSP * Board specific commands
CONFIG_CMD_BOOTD bootd
CONFIG_CMD_CACHE* icache, dcache
+ CONFIG_CMD_CLSclear screen
CONFIG_CMD_CONSOLEconinfo
CONFIG_CMD_CRC32* crc32
CONFIG_CMD_DATE * support for RTC, date/time...
diff --git a/common/Makefile b/common/Makefile
index f631311..a4f780a 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -80,6 +80,7 @@ COBJS-$(CONFIG_CMD_BOOTLDR) += cmd_bootldr.o
COBJS-$(CONFIG_CMD_BOOTSTAGE) += cmd_bootstage.o
COBJS-$(CONFIG_CMD_CACHE) += cmd_cache.o
COBJS-$(CONFIG_CMD_CBFS) += cmd_cbfs.o
+COBJS-$(CONFIG_CMD_CLS) += cmd_cls.o
COBJS-$(CONFIG_CMD_CONSOLE) += cmd_console.o
COBJS-$(CONFIG_CMD_CPLBINFO) += cmd_cplbinfo.o
COBJS-$(CONFIG_DATAFLASH_MMC_SELECT) += cmd_dataflash_mmc_mux.o
diff --git a/common/cmd_cls.c b/common/cmd_cls.c
new file mode 100644
index 000..c220558
--- /dev/null
+++ b/common/cmd_cls.c
@@ -0,0 +1,37 @@
+/*
+ * Copyright 2011
+ * Marcel Mol, MESA Consulting, mar...@mesa.nl
+ *
+ * Copyright 2011
+ * Pali Rohár, pali.ro...@gmail.com
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ */
+
+#include
+#include
+#include
+#include
+
+static int do_clear(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+{
+#ifdef CONFIG_LCD
+ lcd_clear();
+#else
+ puts(ANSI_CLEAR_CONSOLE);
+ printf(ANSI_CURSOR_POSITION, 1, 1);
+#endif
+ return 0;
+}
+
+U_BOOT_CMD(
+ cls,1, 1, do_clear,
+ "clear screen",
+ ""
+);
diff --git a/common/lcd.c b/common/lcd.c
index 590bbb9..c511193 100644
--- a/common/lcd.c
+++ b/common/lcd.c
@@ -449,19 +449,6 @@ void lcd_clear(void)
lcd_sync();
}
-static int do_lcd_clear(cmd_tbl_t *cmdtp, int flag, int argc,
- char *const argv[])
-{
- lcd_clear();
- return 0;
-}
-
-U_BOOT_CMD(
- cls,1, 1, do_lcd_clear,
- "clear screen",
- ""
-);
-
/*--*/
static int lcd_init(void *lcdbase)
diff --git a/include/common.h b/include/common.h
index d41aeb4..69eeea4 100644
--- a/include/common.h
+++ b/include/common.h
@@ -1015,4 +1015,13 @@ static inline void unmap_sysmem(const void *vaddr)
# include
#endif
+/*
+ * Boards with LCD support always provided the "cls" command.
+ * Enable this command for these boards to be backward
+ * compatible.
+ */
+#if defined(CONFIG_LCD)
+#define CONFIG_CMD_CLS
+#endif
+
#endif /* __COMMON_H_ */
diff --git a/include/configs/nokia_rx51.h b/include/configs/nokia_rx51.h
index 8506604..1a9b365 100644
--- a/include/configs/nokia_rx51.h
+++ b/include/configs/nokia_rx51.h
@@ -148,7 +148,7 @@
#define CONFIG_CMDLINE_EDITING /* add command line history */
#define CONFIG_AUTO_COMPLETE /* add autocompletion support */
-#define CONFIG_CMD_CLEAR /* ANSI terminal clear screen command */
+#define CONFIG_CMD_CLS /* ANSI terminal clear screen command */
#ifdef ONENAND_SUPPORT
--
1.7.5.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v9 01/30] mtd: nand: Introduce CONFIG_SYS_NAND_BUSWIDTH_16BIT
Hi Albert, On Saturday, March 30, 2013 9:52:31 AM, Albert ARIBAUD wrote: > Hi Benoît, > > On Wed, 6 Mar 2013 19:59:07 +0100, Benoît Thébaudeau > wrote: > > > From: Fabio Estevam > > > > Introduce CONFIG_SYS_NAND_BUSWIDTH_16BIT option so that other NAND > > controller > > drivers could use it when a 16-bit NAND is deployed. > > > > drivers/mtd/nand/ndfc has CONFIG_SYS_NDFC_16BIT, so just rename it, so that > > other NAND drivers could reuse the same symbol. > > > > Signed-off-by: Fabio Estevam > > Reviewed-by: Benoît Thébaudeau > > --- > > Changes in v9: None > > Changes in v8: > > - New patch. > > > > Changes in v7: None > > Changes in v6: None > > Changes in v5: None > > Changes in v4: None > > Changes in v3: None > > Changes in v2: None > > > > README |9 ++--- > > drivers/mtd/nand/ndfc.c |4 ++-- > > 2 files changed, 8 insertions(+), 5 deletions(-) > > > > diff --git a/README b/README > > index d8cb394..830c45e 100644 > > --- a/README > > +++ b/README > > @@ -3713,9 +3713,12 @@ Low Level (hardware related) configuration options: > > - CONFIG_SYS_SRIOn_MEM_SIZE: > > Size of SRIO port 'n' memory region > > > > -- CONFIG_SYS_NDFC_16 > > - Defined to tell the NDFC that the NAND chip is using a > > - 16 bit bus. > > +- CONFIG_SYS_NAND_BUSWIDTH_16BIT > > + Defined to tell the NAND controller that the NAND chip is using > > + a 16 bit bus. > > + Not all NAND drivers use this symbol. > > + Example of driver that uses it: > > + - drivers/mtd/nand/ndfc.c > > > > - CONFIG_SYS_NDFC_EBC0_CFG > > Sets the EBC0_CFG register for the NDFC. If not defined > > diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c > > index 6ebbb5e..213d2c9 100644 > > --- a/drivers/mtd/nand/ndfc.c > > +++ b/drivers/mtd/nand/ndfc.c > > @@ -156,7 +156,7 @@ static uint8_t ndfc_read_byte(struct mtd_info *mtd) > > > > struct nand_chip *chip = mtd->priv; > > > > -#ifdef CONFIG_SYS_NDFC_16BIT > > +#ifdef CONFIG_SYS_NAND_BUSWIDTH_16BIT > > return (uint8_t) readw(chip->IO_ADDR_R); > > #else > > return readb(chip->IO_ADDR_R); > > @@ -218,7 +218,7 @@ int board_nand_init(struct nand_chip *nand) > > nand->ecc.bytes = 3; > > nand->select_chip = ndfc_select_chip; > > > > -#ifdef CONFIG_SYS_NDFC_16BIT > > +#ifdef CONFIG_SYS_NAND_BUSWIDTH_16BIT > > nand->options |= NAND_BUSWIDTH_16; > > #endif > > > > Series does not apply cleanly on current mainline/ARM trees (actually, > it does not rebase cleanly). I am trying fixing this manually for > testings, but a rebased V10 will be necessary anyway. OK, I'll send that on Monday, April 8, in the evening. Best regards, Benoît ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] replace last __bss_end__ occurrences with __bss_end
Simon Glass' commit 3929fb0a141530551b3fce15ee08629f80d5ef2a, which changed all occurrences of __bss__end__ into __bss_end, left behind some untouched __bss_end__ occurrences in all 33 u-boot.lds.debug files, in board/mousse/u-boot.lds.ram and in board/mousse/u-boot.lds.rom. These are replaced here. Signed-off-by: Albert ARIBAUD --- board/LEOX/elpt860/u-boot.lds.debug |2 +- board/RPXClassic/u-boot.lds.debug |2 +- board/RPXlite/u-boot.lds.debug|2 +- board/RPXlite_dw/u-boot.lds.debug |2 +- board/cogent/u-boot.lds.debug |2 +- board/cray/L1/u-boot.lds.debug|2 +- board/eltec/mhpc/u-boot.lds.debug |2 +- board/emk/top860/u-boot.lds.debug |2 +- board/flagadm/u-boot.lds.debug|2 +- board/genietv/u-boot.lds.debug|2 +- board/hermes/u-boot.lds.debug |2 +- board/hymod/u-boot.lds.debug |2 +- board/icu862/u-boot.lds.debug |2 +- board/ip860/u-boot.lds.debug |2 +- board/ivm/u-boot.lds.debug|2 +- board/kup/kup4k/u-boot.lds.debug |2 +- board/kup/kup4x/u-boot.lds.debug |2 +- board/lwmon/u-boot.lds.debug |2 +- board/mbx8xx/u-boot.lds.debug |2 +- board/mousse/u-boot.lds.ram |2 +- board/mousse/u-boot.lds.rom |2 +- board/mpl/pip405/u-boot.lds.debug |2 +- board/netphone/u-boot.lds.debug |2 +- board/netta/u-boot.lds.debug |2 +- board/netta2/u-boot.lds.debug |2 +- board/netvia/u-boot.lds.debug |2 +- board/nx823/u-boot.lds.debug |2 +- board/quantum/u-boot.lds.debug|2 +- board/sandburst/karef/u-boot.lds.debug|2 +- board/sandburst/metrobox/u-boot.lds.debug |2 +- board/spd8xx/u-boot.lds.debug |2 +- board/stx/stxxtc/u-boot.lds.debug |2 +- board/svm_sc8xx/u-boot.lds.debug |2 +- board/w7o/u-boot.lds.debug|2 +- board/xes/xpedite1000/u-boot.lds.debug|2 +- 35 files changed, 35 insertions(+), 35 deletions(-) diff --git a/board/LEOX/elpt860/u-boot.lds.debug b/board/LEOX/elpt860/u-boot.lds.debug index 92901b1..592d9e3 100644 --- a/board/LEOX/elpt860/u-boot.lds.debug +++ b/board/LEOX/elpt860/u-boot.lds.debug @@ -134,6 +134,6 @@ SECTIONS *(.bss) *(COMMON) } - __bss_end__ = . ; + __bss_end = . ; PROVIDE (end = .); } diff --git a/board/RPXClassic/u-boot.lds.debug b/board/RPXClassic/u-boot.lds.debug index e88bd97..40f17e9 100644 --- a/board/RPXClassic/u-boot.lds.debug +++ b/board/RPXClassic/u-boot.lds.debug @@ -132,6 +132,6 @@ SECTIONS *(.bss) *(COMMON) } - __bss_end__ = . ; + __bss_end = . ; PROVIDE (end = .); } diff --git a/board/RPXlite/u-boot.lds.debug b/board/RPXlite/u-boot.lds.debug index e88bd97..40f17e9 100644 --- a/board/RPXlite/u-boot.lds.debug +++ b/board/RPXlite/u-boot.lds.debug @@ -132,6 +132,6 @@ SECTIONS *(.bss) *(COMMON) } - __bss_end__ = . ; + __bss_end = . ; PROVIDE (end = .); } diff --git a/board/RPXlite_dw/u-boot.lds.debug b/board/RPXlite_dw/u-boot.lds.debug index 88c410c..7b89b4f 100644 --- a/board/RPXlite_dw/u-boot.lds.debug +++ b/board/RPXlite_dw/u-boot.lds.debug @@ -132,6 +132,6 @@ SECTIONS *(.bss) *(COMMON) } - __bss_end__ = . ; + __bss_end = . ; PROVIDE (end = .); } diff --git a/board/cogent/u-boot.lds.debug b/board/cogent/u-boot.lds.debug index e88bd97..40f17e9 100644 --- a/board/cogent/u-boot.lds.debug +++ b/board/cogent/u-boot.lds.debug @@ -132,6 +132,6 @@ SECTIONS *(.bss) *(COMMON) } - __bss_end__ = . ; + __bss_end = . ; PROVIDE (end = .); } diff --git a/board/cray/L1/u-boot.lds.debug b/board/cray/L1/u-boot.lds.debug index 99cbed4..1b45e5e 100644 --- a/board/cray/L1/u-boot.lds.debug +++ b/board/cray/L1/u-boot.lds.debug @@ -132,6 +132,6 @@ SECTIONS *(.bss) *(COMMON) } - __bss_end__ = . ; + __bss_end = . ; PROVIDE (end = .); } diff --git a/board/eltec/mhpc/u-boot.lds.debug b/board/eltec/mhpc/u-boot.lds.debug index 614bbb2..a33b0a6 100644 --- a/board/eltec/mhpc/u-boot.lds.debug +++ b/board/eltec/mhpc/u-boot.lds.debug @@ -132,6 +132,6 @@ SECTIONS *(.bss) *(COMMON) } - __bss_end__ = . ; + __bss_end = . ; PROVIDE (end = .); } diff --git a/board/emk/top860/u-boot.lds.debug b/board/emk/top860/u-boot.lds.debug index 39807d4..704e8c9 100644 --- a/board/emk/top860/u-boot.lds.debug +++ b/board/emk/top860/u-boot.lds.debug @@ -126,6 +126,6 @@ SECTIONS *(.bss) *(COMMON) } - __bss_end__ = . ; + __bss_end = . ; PROVIDE (end = .); } diff --git a/board/flagadm/u-boot.lds.debug b/board/flagadm/u-boot.lds.debug index 614bbb2..a33b0a6 100644 --- a/board/flagadm/u-boot.lds.debug +++ b/board/flagadm/u-boot.lds.debug @@ -132,6 +132,6 @@ SECTIONS *(.bss) *(COMMON)
Re: [U-Boot] [PATCH v9 01/30] mtd: nand: Introduce CONFIG_SYS_NAND_BUSWIDTH_16BIT
Hi Benoît, On Wed, 6 Mar 2013 19:59:07 +0100, Benoît Thébaudeau wrote: > From: Fabio Estevam > > Introduce CONFIG_SYS_NAND_BUSWIDTH_16BIT option so that other NAND controller > drivers could use it when a 16-bit NAND is deployed. > > drivers/mtd/nand/ndfc has CONFIG_SYS_NDFC_16BIT, so just rename it, so that > other NAND drivers could reuse the same symbol. > > Signed-off-by: Fabio Estevam > Reviewed-by: Benoît Thébaudeau > --- > Changes in v9: None > Changes in v8: > - New patch. > > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > README |9 ++--- > drivers/mtd/nand/ndfc.c |4 ++-- > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/README b/README > index d8cb394..830c45e 100644 > --- a/README > +++ b/README > @@ -3713,9 +3713,12 @@ Low Level (hardware related) configuration options: > - CONFIG_SYS_SRIOn_MEM_SIZE: > Size of SRIO port 'n' memory region > > -- CONFIG_SYS_NDFC_16 > - Defined to tell the NDFC that the NAND chip is using a > - 16 bit bus. > +- CONFIG_SYS_NAND_BUSWIDTH_16BIT > + Defined to tell the NAND controller that the NAND chip is using > + a 16 bit bus. > + Not all NAND drivers use this symbol. > + Example of driver that uses it: > + - drivers/mtd/nand/ndfc.c > > - CONFIG_SYS_NDFC_EBC0_CFG > Sets the EBC0_CFG register for the NDFC. If not defined > diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c > index 6ebbb5e..213d2c9 100644 > --- a/drivers/mtd/nand/ndfc.c > +++ b/drivers/mtd/nand/ndfc.c > @@ -156,7 +156,7 @@ static uint8_t ndfc_read_byte(struct mtd_info *mtd) > > struct nand_chip *chip = mtd->priv; > > -#ifdef CONFIG_SYS_NDFC_16BIT > +#ifdef CONFIG_SYS_NAND_BUSWIDTH_16BIT > return (uint8_t) readw(chip->IO_ADDR_R); > #else > return readb(chip->IO_ADDR_R); > @@ -218,7 +218,7 @@ int board_nand_init(struct nand_chip *nand) > nand->ecc.bytes = 3; > nand->select_chip = ndfc_select_chip; > > -#ifdef CONFIG_SYS_NDFC_16BIT > +#ifdef CONFIG_SYS_NAND_BUSWIDTH_16BIT > nand->options |= NAND_BUSWIDTH_16; > #endif > Series does not apply cleanly on current mainline/ARM trees (actually, it does not rebase cleanly). I am trying fixing this manually for testings, but a rebased V10 will be necessary anyway. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
