Re: [U-Boot] [PATCH 08/11] efi_selftest: allow to select a single test for exexution
On 09.10.17 08:14, Heinrich Schuchardt wrote: > On 10/09/2017 06:46 AM, Alexander Graf wrote: >> >> >> On 08.10.17 06:57, Heinrich Schuchardt wrote: >>> The second argument of bootefi is passed as a configuration >>> table to the selftest application. It is used to select >>> a single test to be executed. >>> >>> Tests get an on_request property. If this property is set >>> the tests are only executed if explicitly requested. >>> >>> A new command 'bootefi selftest list' is added that allows to list >>> all tests. >>> >>> The invocation of efi_selftest is changed to reflect that >>> bootefi selftest list will call the Exit bootservice. >>> >>> Signed-off-by: Heinrich Schuchardt >> >> Wouldn't it make more sense to just pass "bootargs" to the EFI payload >> as command line arguments? >> >> We could then just >> >> U-Boot# setenv bootargs list >> U-Boot# bootefi selftest >> >> to list the available self tests. Same for selecting them. > > Why bootargs? > Because bootargs is the variable that "bootm" pushes into a payload as command line arguments. >> >> That way we would also be able to directly load Linux as EFI binary and >> pass command line arguments to it without jumping through fdt patching >> hoops. > > Does the Linux EFI stub or grub.efi have a capability to receive the > command line? Linux does: https://github.com/torvalds/linux/blob/master/drivers/firmware/efi/libstub/efi-stub-helper.c#L773 I don't think grub implements it today, but I don't see why it should. Any UEFI application that expects to be executed from the UEFI Shell certainly interprets the passed in command line. Alex ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] armv8: configs: ls1012a: correct the generic timer frequency issue
From: Yuantian Tang Generic Timer frequency should be 25Mhz. Current setting is CONFIG_SYS_CLK_FREQ/4 which is about 31Mhz, which is not correct. So correct it. Signed-off-by: Tang Yuantian --- include/configs/ls1012a_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/ls1012a_common.h b/include/configs/ls1012a_common.h index 096799eb64..a4e78f335f 100644 --- a/include/configs/ls1012a_common.h +++ b/include/configs/ls1012a_common.h @@ -32,7 +32,7 @@ #define CONFIG_SYS_DDR_BLOCK2_BASE 0x88000ULL /* Generic Timer Definitions */ -#define COUNTER_FREQUENCY CONFIG_SYS_CLK_FREQ/4 /* 25MHz */ +#define COUNTER_FREQUENCY 2500/* 25MHz */ /* CSU */ #define CONFIG_LAYERSCAPE_NS_ACCESS -- 2.14.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case
On Sun, Oct 08, 2017 at 11:12:28PM -0400, Tom Rini wrote: > On Sun, Oct 08, 2017 at 10:56:26PM -0300, Fabio Estevam wrote: > > On Sun, Oct 8, 2017 at 11:04 AM, Jonathan Gray wrote: > > > > > It turns out to be > > > > > > commit 2460098cffacd18729262e3ed36656e6943783ed > > > Author: Tom Rini > > > Date: Fri Sep 22 07:37:43 2017 -0400 > > > > > > fs/fat: Reduce stack usage > > > > > > We have limited stack in SPL builds. Drop itrblock and move to > > > malloc/free of itr to move this off of the stack. As part of this > > > fix a > > > double-free issue in fat_size(). > > > > > > Signed-off-by: Tom Rini > > > --- > > > Rework to use malloc/free as moving this to a global overflows some SH > > > targets. > > > > > > fs/fat/fat.c | 14 ++ > > > 1 file changed, 10 insertions(+), 4 deletions(-) > > > > > > With that reverted I just get the efi loader problem, no alignment errors. > > > > Thanks for doing the bisect. > > > > Tom, can you prepare a fix for this? > > No, this is a required fix for other platforms. Why is this failing in > the particular case that it's failing in? Switching the malloc calls for malloc_cache_aligned also avoids the problem. U-Boot SPL 2017.11-rc1-00026-g14b55fc833 (Oct 05 2017 - 15:17:47) Trying to boot from MMC1 U-Boot 2017.11-rc1-00026-g14b55fc833 (Oct 05 2017 - 15:17:47 +1100) CPU: Freescale i.MX6Q rev1.5 996 MHz (running at 792 MHz) CPU: Extended Commercial temperature grade (-20C to 105C) at 34C Reset cause: WDOG Board: MX6 Cubox-i DRAM: 2 GiB MMC: FSL_SDHC: 0 *** Warning - bad CRC, using default environment No panel detected: default to HDMI Display: HDMI (1024x768) In:serial Out: serial Err: serial Net: FEC Hit any key to stop autoboot: 0 switch to partitions #0, OK mmc0 is current device Scanning mmc 0:1... CACHE: Misaligned operation at range [8f89da30, 8f89e230] CACHE: Misaligned operation at range [8f89da30, 8f89e230] ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x8f89da30 ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0x8f89e230 CACHE: Misaligned operation at range [8f89da30, 8f89e230] CACHE: Misaligned operation at range [8f89da30, 8f89e230] ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x8f89da30 ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0x8f89e230 CACHE: Misaligned operation at range [8f89dca0, 8f89e4a0] CACHE: Misaligned operation at range [8f89dca0, 8f89e4a0] CACHE: Misaligned operation at range [8f89dca0, 8f89e4a0] CACHE: Misaligned operation at range [8f89dca0, 8f89e4a0] CACHE: Misaligned operation at range [8f89dc68, 8f89e468] CACHE: Misaligned operation at range [8f89dc68, 8f89e468] ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x8f89dc68 ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0x8f89e468 CACHE: Misaligned operation at range [8f89dc68, 8f89e468] CACHE: Misaligned operation at range [8f89dc68, 8f89e468] ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x8f89dc68 ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0x8f89e468 CACHE: Misaligned operation at range [8f89dab0, 8f89e2b0] CACHE: Misaligned operation at range [8f89dab0, 8f89e2b0] ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x8f89dab0 ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0x8f89e2b0 CACHE: Misaligned operation at range [8f89dab0, 8f89e2b0] CACHE: Misaligned operation at range [8f89dab0, 8f89e2b0] ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x8f89dab0 ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0x8f89e2b0 CACHE: Misaligned operation at range [8f89dca8, 8f89e4a8] CACHE: Misaligned operation at range [8f89dca8, 8f89e4a8] ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x8f89dca8 ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0x8f89e4a8 CACHE: Misaligned operation at range [8f89dca8, 8f89e4a8] CACHE: Misaligned operation at range [8f89dca8, 8f89e4a8] ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x8f89dca8 ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0x8f89e4a8 CACHE: Misaligned operation at range [8f89dc70, 8f89e470] CACHE: Misaligned operation at range [8f89dc70, 8f89e470] ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x8f89dc70 ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0x8f89e470 CACHE: Misaligned operation at range [8f89dc70, 8f89e470] CACHE: Misaligned operation at range [8f89dc70, 8f89e470] ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x8f89dc70 ERROR: v7_outer_cache_inval_range - stop address is not aligned - 0x8f89e470 CACHE: Misaligned operation at range [8f89e488, 8f89ec88] CACHE: Misaligned operation at range [8f89e488, 8f89ec88] ERROR: v7_outer_cache_inval_range - start address is not aligned - 0x8f89e488 ERROR: v7_out
Re: [U-Boot] [PATCH 10/11] test/py: test reboot by EFI watchdog
On 10/09/2017 06:49 AM, Simon Glass wrote:
> On 7 October 2017 at 22:57, Heinrich Schuchardt wrote:
>> Provide a test verifying that the EFI watchdog
>> reboots the system upon timeout.
>>
>> The test depends on CONFIG_CMD_EFI_SELFTEST=y.
>>
>> Signed-off-by: Heinrich Schuchardt
>> ---
>> test/py/tests/test_efi_selftest.py | 11 ++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)Reviewed-by: Simon Glass
>>
>
> Reviewed-by: Simon Glass
>
> But why are you removing the NVIDIA copyright?
It was only by a copy mistake that it got in.
It is all my code.
Regards
Heinrich
>
>>
>> diff --git a/test/py/tests/test_efi_selftest.py
>> b/test/py/tests/test_efi_selftest.py
>> index 76e282a6c7..b0a86ea8b8 100644
>> --- a/test/py/tests/test_efi_selftest.py
>> +++ b/test/py/tests/test_efi_selftest.py
>> @@ -1,4 +1,3 @@
>> -# Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
>> # Copyright (c) 2017, Heinrich Schuchardt
>> #
>> # SPDX-License-Identifier: GPL-2.0
>> @@ -23,3 +22,13 @@ def test_efi_selftest(u_boot_console):
>> if m != 0:
>> raise Exception('Reset failed during the EFI selftest')
>> u_boot_console.restart_uboot();
>> +
>> +@pytest.mark.buildconfigspec('cmd_bootefi_selftest')
>> +def test_efi_selftest_watchdog_reboot(u_boot_console):
>> + output = u_boot_console.run_command('bootefi selftest list')
>> + assert '\'watchdog reboot\'' in output
>> + u_boot_console.run_command(cmd='bootefi selftest \'watchdog
>> reboot\'', wait_for_prompt=False)
>> + m = u_boot_console.p.expect(['resetting', 'U-Boot'])
>> + if m != 0:
>> + raise Exception('Reset failed in \'watchdog reboot\' test')
>> + u_boot_console.restart_uboot();
>> --
>> 2.14.1
>>
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 08/11] efi_selftest: allow to select a single test for exexution
On 10/09/2017 06:46 AM, Alexander Graf wrote: > > > On 08.10.17 06:57, Heinrich Schuchardt wrote: >> The second argument of bootefi is passed as a configuration >> table to the selftest application. It is used to select >> a single test to be executed. >> >> Tests get an on_request property. If this property is set >> the tests are only executed if explicitly requested. >> >> A new command 'bootefi selftest list' is added that allows to list >> all tests. >> >> The invocation of efi_selftest is changed to reflect that >> bootefi selftest list will call the Exit bootservice. >> >> Signed-off-by: Heinrich Schuchardt > > Wouldn't it make more sense to just pass "bootargs" to the EFI payload > as command line arguments? > > We could then just > > U-Boot# setenv bootargs list > U-Boot# bootefi selftest > > to list the available self tests. Same for selecting them. Why bootargs? > > That way we would also be able to directly load Linux as EFI binary and > pass command line arguments to it without jumping through fdt patching > hoops. Does the Linux EFI stub or grub.efi have a capability to receive the command line? Regards Heinrich ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Edison's U-Boot Architecture
Hello Andy, Thank you very much for the reply. Instead reply-ing to you in Open Source fashion, I'll answer to you in the form of the new @. Easier and more clean/clear approach. Nevertheless, Edison is cancelled. But since it is already out there, and you do it, and using it as the test vehicle Let me start asking in the Edison/Tangier core design light the similar questions, I already have asked on this list about U-Boot E3900 and BDW-DX architectures. We all know (or I assume U-Boot list knows about Coreboot) and I also assume majority of the people heard how x86 does work for Coreboot. Quick recap: https://www.intel.com/content/www/us/en/intelligent-systems/ intel-firmware-support-package/intel-fsp-overview.html And we have here in nutshell the following peculiar architecture as the result of FSP: FSP/Coreboot inter-mingled with U-Boot as a Coreboot's payload!? Practically three boot-loaders to bring x86 architecture to YOCTO... FSP being binary blob, actually translating to three binary blobs in FSP 2.0 spec. And we know that U-Boot maintainers do not allow binary blobs in U-Boot. Not like this. So, what we really want: independent U-Boot on x86, don't we? I am curious about the following x86 HW/FW configuration with regards to the U-Boot? In order to protect INTEL Intellectual Properly (IP), FSP is invented. Seems that FSP did NOT solve any of the issues. Furthermore, I have no idea how big projects/players are using x86 with U-Boot (example: BMW, their Ulm and Munich IT Car depts.) are using YOCTO with x86. My best guess is that they have private U-Boot (NOT public one), already adjusted to work as two stage boot-loader, with very clean division of the layers. Something like this (in the lieu of Tangier, as an example): Edison/Tangier cores -> IFWI -> MBR -> U-Boot -> eLinux/YOCTO ?! Here are some explanations regarding the terms/context: *IFWI is the Intel FirmWare Interface, a binary blob loaded from the eMMC boot partition that executes a secondary loader (in this case U-Boot) from the main eMMC. IFWI blobs for the x86 are provided by Intel.* *Normal IFWI eMMC boot process* 1. *On-chip boot rom inits eMMC and loads IFWI from the MMC boot partitions* 2. *IFWI looks for OSIP header at top of eMMC (MBR boot block)* 3. *The header directs IFWI to the start, size, load address, and entry of U-Boot in eMMC* 4. *(need clarification) If u-boot is not found, try the alt u-boot image at 5MB into the eMMC* 5. *U-Boot is loaded into RAM and executed* *OSIP stands for OS Image Profile, and it is nothing more and less than INTEL name for very known old fashion MBR, considering DATA structure.* Andy/Andrej, Question here: Did I get the correct idea how Edison works with U-Boot? Could you, please, elaborate how this is done with Edison? (Vopros sdes6: Ja praviljno ugadal kak eto sdelano/rabotaet? Mozno bolee dannih kad celaja eta arhitectura rabotaet so Edisonom?) (I da, esli est6 informacii na Russkom, davaite ih... Rasberus6! Ja boltaju Russij jazik tocno kak Russkie rozdennie). ;-) Thank you in advance, Zoran ___ On Sun, Oct 8, 2017 at 3:45 PM, Andy Shevchenko wrote: > On Sat, 2017-10-07 at 16:32 +0800, Bin Meng wrote: > > +Cc: Ferry (he might be interested in this thread) > > > > Edison?! Edison is dead (end), as I know it... > > Some people don't think so, there are ones who like the board. > > Actually, while working for Linux kernel at Intel I'm using that board > on almost daily basis to do many tests which are not related strictly to > Edison or even Tangier. > > > > The project is cancelled. > > That's correct [1]. > > But be honest, don't you like the idea to have an example of the board, > which was never designed to be ACPI compatible, actually to become one > (as much as hardware and ACPI specification allow to, of course)? > > Besides that I have started looking into Edison's stuff around spring > time of 2015. You may see my progress here [2] (first article dated > 27.03.2015, the chapter "6 What is working and what doesn't" shows > progress of upstreaming). U-Boot was appeared on my radar when the stock > one stopped working with vanilla kernels. > > > > Correct me if I am wrong! > > See above. > > > I don't know that story. Loop Andy in to comment. > > Thanks, Bin, for including me in the loop. > > > But my understanding > > is that these are pretty much Intel Tangier SoC related, > > ...and Merrifield as a platform, which had been used in some x86-based > phones. > > > and Edison is > > just a reference board. > > Edison is one of the Intel's IoT boards, but the only board from Intel > MID family [3]. > > > > Much more important INTEL U-Boot businesses are ATOM E3900/APL-I > > > family and > > > CORE-5 BDW-DE (possible also BDW-DE NS), > > > > > > What about these? > > I can't answer on this. Work on Edison stuff may be considered as my > hobby project (I have never been a part of an official team which had > done Edison). > > [1]: https://
Re: [U-Boot] [PATCH 06/11] efi_loader: implement SetWatchdogTimer
On 10/09/2017 06:42 AM, Alexander Graf wrote:
>
>
> On 08.10.17 06:57, Heinrich Schuchardt wrote:
>> The watchdog is initialized with a 5 minute timeout period.
>> It can be reset by SetWatchdogTimer.
>> It is stopped by ExitBoottimeServices.
>>
>> Signed-off-by: Heinrich Schuchardt
>> ---
>> cmd/bootefi.c | 1 +
>> include/efi_loader.h | 4 +++
>> lib/efi_loader/Makefile | 2 +-
>> lib/efi_loader/efi_boottime.c | 15 ++-
>> lib/efi_loader/efi_watchdog.c | 59
>> +++
>> 5 files changed, 67 insertions(+), 14 deletions(-)
>> create mode 100644 lib/efi_loader/efi_watchdog.c
>>
>> diff --git a/cmd/bootefi.c b/cmd/bootefi.c
>> index b7087e3da8..24958ada46 100644
>> --- a/cmd/bootefi.c
>> +++ b/cmd/bootefi.c
>> @@ -43,6 +43,7 @@ static void efi_init_obj_list(void)
>> #ifdef CONFIG_GENERATE_SMBIOS_TABLE
>> efi_smbios_register();
>> #endif
>> +efi_watchdog_register();
>>
>> /* Initialize EFI runtime services */
>> efi_reset_system_init();
>> diff --git a/include/efi_loader.h b/include/efi_loader.h
>> index e1179b7dcd..223d8d8222 100644
>> --- a/include/efi_loader.h
>> +++ b/include/efi_loader.h
>> @@ -163,6 +163,8 @@ int efi_disk_register(void);
>> int efi_gop_register(void);
>> /* Called by bootefi to make the network interface available */
>> int efi_net_register(void);
>> +/* Called by bootefi to make the watchdog available */
>> +int efi_watchdog_register(void);
>> /* Called by bootefi to make SMBIOS tables available */
>> void efi_smbios_register(void);
>>
>> @@ -171,6 +173,8 @@ efi_fs_from_path(struct efi_device_path *fp);
>>
>> /* Called by networking code to memorize the dhcp ack package */
>> void efi_net_set_dhcp_ack(void *pkt, int len);
>> +/* Called by efi_set_watchdog_timer to reset the timer */
>> +efi_status_t efi_set_watchdog(unsigned long timeout);
>>
>> /* Called from places to check whether a timer expired */
>> void efi_timer_check(void);
>> diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile
>> index ddb978f650..83d879b686 100644
>> --- a/lib/efi_loader/Makefile
>> +++ b/lib/efi_loader/Makefile
>> @@ -17,7 +17,7 @@ endif
>> obj-$(CONFIG_CMD_BOOTEFI_HELLO) += helloworld_efi.o
>> obj-y += efi_image_loader.o efi_boottime.o efi_runtime.o efi_console.o
>> obj-y += efi_memory.o efi_device_path_to_text.o efi_device_path.o
>> -obj-y += efi_file.o efi_variable.o efi_bootmgr.o
>> +obj-y += efi_file.o efi_variable.o efi_bootmgr.o efi_watchdog.o
>> obj-$(CONFIG_LCD) += efi_gop.o
>> obj-$(CONFIG_DM_VIDEO) += efi_gop.o
>> obj-$(CONFIG_PARTITIONS) += efi_disk.o
>> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
>> index 30577f717e..81e7d818fc 100644
>> --- a/lib/efi_loader/efi_boottime.c
>> +++ b/lib/efi_loader/efi_boottime.c
>> @@ -155,18 +155,6 @@ void efi_signal_event(struct efi_event *event)
>> event->is_queued = false;
>> }
>>
>> -/*
>> - * Write a debug message for an EPI API service that is not implemented yet.
>> - *
>> - * @funcnamefunction that is not yet implemented
>> - * @return EFI_UNSUPPORTED
>> - */
>> -static efi_status_t efi_unsupported(const char *funcname)
>> -{
>> -debug("EFI: App called into unimplemented function %s\n", funcname);
>> -return EFI_EXIT(EFI_UNSUPPORTED);
>> -}
>> -
>> /*
>> * Raise the task priority level.
>> *
>> @@ -1454,6 +1442,7 @@ static efi_status_t EFIAPI efi_exit_boot_services(void
>> *image_handle,
>> bootm_disable_interrupts();
>>
>> /* Give the payload some time to boot */
>> +efi_set_watchdog(0);
>> WATCHDOG_RESET();
>>
>> return EFI_EXIT(EFI_SUCCESS);
>> @@ -1514,7 +1503,7 @@ static efi_status_t EFIAPI
>> efi_set_watchdog_timer(unsigned long timeout,
>> {
>> EFI_ENTRY("%ld, 0x%"PRIx64", %ld, %p", timeout, watchdog_code,
>>data_size, watchdog_data);
>> -return efi_unsupported(__func__);
>> +return EFI_EXIT(efi_set_watchdog(timeout));
>> }
>>
>> /*
>> diff --git a/lib/efi_loader/efi_watchdog.c b/lib/efi_loader/efi_watchdog.c
>> new file mode 100644
>> index 00..50e95290ea
>> --- /dev/null
>> +++ b/lib/efi_loader/efi_watchdog.c
>> @@ -0,0 +1,59 @@
>> +/*
>> + * EFI device path interface
>
> Not quite I guess?
>
>> + *
>> + * Copyright (c) 2017 Heinrich Schuchardt
>> + *
>> + * SPDX-License-Identifier: GPL-2.0+
>> + */
>> +
>> +#include
>> +#include
>> +
>> +static struct efi_event *watchdog_timer_event;
>> +
>> +static void EFIAPI efi_watchdog_timer_notify(struct efi_event *event,
>> + void *context)
>> +{
>> +EFI_ENTRY("%p, %p", event, context);
>> +
>> +printf("\nEFI: Watchdog timeout\n");
>> +EFI_CALL_VOID(efi_runtime_services.reset_system(EFI_RESET_COLD,
>> +EFI_SUCCESS, 0, NULL));
>> +
>> +EFI_EXIT(EFI_UNSUPPORTED);
>> +}
>> +
>> +efi_status_t efi_set_watchdog(unsigned long
Re: [U-Boot] [PATCH v2] arm64: ls1012afrdm: Add distro boot support
> -Original Message-
> From: York Sun
> Sent: Thursday, October 05, 2017 8:30 PM
> To: Rajesh Bhagat ; u-boot@lists.denx.de
> Cc: Bhaskar Upadhaya
> Subject: Re: [PATCH v2] arm64: ls1012afrdm: Add distro boot support
>
> On 10/05/2017 01:47 AM, Rajesh Bhagat wrote:
> > Include common config_distro_defaults.h and config_distro_bootcmd.h
> > for u-boot enviroments to support automatical distro boot which scan
> > boot.scr from external storage devices(e.g. SD and USB) and execute
> > autoboot script.
> >
> > Signed-off-by: Bhaskar Upadhaya
> > Signed-off-by: Rajesh Bhagat
> > ---
> > Depends on:
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
> >
> hwork.ozlabs.org%2Fpatch%2F808617%2F&data=01%7C01%7Cyork.sun%40nxp.com
> >
> %7C83457d3a96b74d7dd33d08d50bcdb2c9%7C686ea1d3bc2b4c6fa92cd99c5c301635
> >
> %7C0&sdata=sKmaJpoaeK1JXMf%2F%2Ba%2BPlUQtY3HumeB08I6MKTWchzc%3D&re
> serv
> > ed=0
> >
> > Changes in v2:
> > - Removed the extra "\" character from macro definition
> > - Dropped the #if for CONFIG_BOOTCOMMAND
> >
> > configs/ls1012afrdm_qspi_defconfig | 1 +
> > include/configs/ls1012afrdm.h | 57
> --
> > 2 files changed, 49 insertions(+), 9 deletions(-)
> >
> > diff --git a/configs/ls1012afrdm_qspi_defconfig
> > b/configs/ls1012afrdm_qspi_defconfig
> > index fe95f04..42acff0 100644
> > --- a/configs/ls1012afrdm_qspi_defconfig
> > +++ b/configs/ls1012afrdm_qspi_defconfig
> > @@ -46,3 +46,4 @@ CONFIG_DM_USB=y
> > CONFIG_USB_XHCI_HCD=y
> > CONFIG_USB_XHCI_DWC3=y
> > CONFIG_USB_STORAGE=y
> > +CONFIG_DISTRO_DEFAULTS=y
> > diff --git a/include/configs/ls1012afrdm.h
> > b/include/configs/ls1012afrdm.h index 6b1ba57..4d6448b 100644
> > --- a/include/configs/ls1012afrdm.h
> > +++ b/include/configs/ls1012afrdm.h
> > @@ -20,16 +20,55 @@
> > #define CONFIG_SYS_MEMTEST_START 0x8000
> > #define CONFIG_SYS_MEMTEST_END 0x9fff
> >
> > +#ifndef CONFIG_SPL_BUILD
> > +#undef BOOT_TARGET_DEVICES
> > +#define BOOT_TARGET_DEVICES(func) \
> > + func(USB, usb, 0)
> > +#endif
> > +
> > #undef CONFIG_EXTRA_ENV_SETTINGS
> > -#define CONFIG_EXTRA_ENV_SETTINGS \
> > - "verify=no\0" \
> > - "loadaddr=0x8010\0" \
> > - "kernel_addr=0x10\0"\
> > - "fdt_high=0x\0" \
> > - "initrd_high=0x\0" \
> > - "kernel_start=0xa0\0" \
> > - "kernel_load=0x9600\0" \
> > - "kernel_size=0x280\0"
> > +#define CONFIG_EXTRA_ENV_SETTINGS \
> > + "verify=no\0" \
> > + "fdt_high=0x\0" \
> > + "initrd_high=0x\0" \
> > + "fdt_addr=0x00f0\0" \
> > + "kernel_addr=0x0100\0" \
> > + "scriptaddr=0x8000\0" \
> > + "fdtheader_addr_r=0x8010\0" \
> > + "kernelheader_addr_r=0x8020\0" \
> > + "kernel_addr_r=0x9600\0"\
> > + "fdt_addr_r=0x9000\0" \
> > + "load_addr=0x9600\0"\
> > + "kernel_size=0x280\0" \
> > + "console=ttyS0,115200\0"\
> > + BOOTENV \
> > + "boot_scripts=ls1012afrdm_boot.scr\0" \
> > + "scan_dev_for_boot_part=" \
> > +"part list ${devtype} ${devnum} devplist; "\
> > +"env exists devplist || setenv devplist 1; " \
> > +"for distro_bootpart in ${devplist}; do " \
> > + "if fstype ${devtype} " \
> > + "${devnum}:${distro_bootpart} " \
> > + "bootfstype; then " \
> > + "run scan_dev_for_boot; " \
> > + "fi; "\
> > + "done\0" \
> > + "scan_dev_for_boot=" \
> > + "echo Scanning ${devtype} " \
> > + "${devnum}:${distro_bootpart}...; " \
> > + "for prefix in ${boot_prefixes}; do " \
> > + "run scan_dev_for_scripts; " \
> > + "done;" \
> > + "\0" \
> > + "installer=load usb 0:2 $load_addr "\
> > + "/flex_installer_arm64.itb; "\
> > + "bootm $load_addr#$board\0" \
> > + "qspi_bootcmd=echo Trying load from qspi..;"\
> > + "sf probe && sf read $load_addr " \
> > + "$kernel_addr $kernel_size && bootm $load_addr#$board\0"
> > +
>
> http://patchwork.ozlabs.org/patch/808617/ changes CONFIG_EXTRA_ENV_SETTINGS
> which you just redefined. Do you really depend on that patch? That patch
> needs an
> update.
>
Yes, this patch depends on
Re: [U-Boot] efi_loader: arch/arm/include/asm/setjmp.h
On 07.10.17 22:23, Heinrich Schuchardt wrote:
> Hello Alex,
>
> our current logic for removing the handler of the loaded image is wrong:
>
> If a driver image calls Exit() with EFI_SUCCESS the image has to remain.
>
> I tried to rework the logic and needed a second setjmp in cmd/bootefi.c
> to handle 'bootefi selftest'.
>
> On arm this resulted in:
>
> Building current source for 1 boards (1 thread, 4 jobs per thread)
>arm: + vexpress_ca15_tc2
> +{standard input}: Assembler messages:
> +{standard input}:638: Error: symbol `jmp_target' is already defined
> +{standard input}:633: Error: symbol .text.do_bootefi_exec is in a
> different section
> +make[2]: *** [cmd/bootefi.o] Error 1
> +make[1]: *** [cmd] Error 2
> +make: *** [sub-make] Error 2
>
> All registers that have to be restored should be stored in jmp_buf and
> not at any static address (jmp_target).
jmp_target is not an address to store things at, it's an address to jump
to :). We just happen to define the same label twice because of inlining.
Does the patch below fix it for you?
Either way, Philipp rewrote all of the setjmp/longjmp code anyway in his
rockchip patch set.
Philipp, what path do you expect that to take? Should we fix the in-tree
setjmp or just apply yours?
Alex
diff --git a/arch/arm/include/asm/setjmp.h b/arch/arm/include/asm/setjmp.h
index c3399a7e15..2c58e2819e 100644
--- a/arch/arm/include/asm/setjmp.h
+++ b/arch/arm/include/asm/setjmp.h
@@ -22,13 +22,13 @@ static inline int setjmp(jmp_buf jmp)
#ifdef CONFIG_ARM64
asm volatile(
- "adr x1, jmp_target\n"
+ "adr x1, 1f\n"
"str x1, %0\n"
"stp x26, x27, %1\n"
"stp x28, x29, %2\n"
"mov x1, sp\n"
"str x1, %3\n"
- "jmp_target: "
+ "1: "
: "=m" (jmp->target), "=m" (jmp->regs[0]),
"=m" (jmp->regs[2]), "=m" (jmp->regs[4])
:
@@ -41,16 +41,16 @@ static inline int setjmp(jmp_buf jmp)
asm volatile(
#if CONFIG_IS_ENABLED(SYS_THUMB_BUILD)
".align 2\n"
- "adr r0, jmp_target\n"
+ "adr r0, 1f\n"
"add r0, r0, $1\n"
#else
- "adr r0, jmp_target\n"
+ "adr r0, 1f\n"
#endif
"mov r1, %0\n"
"mov r2, sp\n"
"stm r1!, {r0, r2, r4, r5, r6, r7}\n"
".align 2\n"
- "jmp_target: \n"
+ "1: \n"
:
: "l" (&jmp->target)
: "r0", "r1", "r2", "r3", /* "r4", "r5", "r6", "r7", */
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 11/11] test/py: fix typo in test_efi_loader.py
On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > Make a comment line easier to read. > > Signed-off-by: Heinrich Schuchardt > --- > test/py/tests/test_efi_loader.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4] arm64: ls1012ardb: Add distro boot support
> -Original Message-
> From: York Sun
> Sent: Thursday, October 05, 2017 8:27 PM
> To: Rajesh Bhagat ; u-boot@lists.denx.de
> Cc: Bhaskar Upadhaya
> Subject: Re: [PATCH v4] arm64: ls1012ardb: Add distro boot support
>
> On 10/05/2017 01:47 AM, Rajesh Bhagat wrote:
> > Include common config_distro_defaults.h and config_distro_bootcmd.h
> > for u-boot enviroments to support automatical distro boot which scan
> > boot.scr from external storage devices(e.g. SD and USB) and execute
> > autoboot script.
> >
> > Signed-off-by: Bhaskar Upadhaya
> > Signed-off-by: Rajesh Bhagat
> > ---
> > Depends on:
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
> >
> hwork.ozlabs.org%2Fpatch%2F808617%2F&data=01%7C01%7Cyork.sun%40nxp.com
> > %7C4712a6e59b864697f6c108d50bcdaeac%7C686ea1d3bc2b4c6fa92cd99c5c301635
> >
> %7C0&sdata=dzkaNe45yeHuhF8P0%2F3DXSfZIX1c%2FWf9%2FMAMUwwIpV4%3D&re
> serv
> > ed=0
> >
> > Changes in v4:
> > - Removed the extra "\" character from macro definition
> > - Dropped the #if for CONFIG_BOOTCOMMAND
> >
> > Changes in v3:
> > Removed pfe stop command from BOOTCMD
> >
> > Changes in v2:
> > Rebased to latest u-boot
> >
> > configs/ls1012ardb_qspi_defconfig | 1 +
> > include/configs/ls1012a_common.h | 10 -
> > include/configs/ls1012ardb.h | 43
> +++
> > 3 files changed, 53 insertions(+), 1 deletion(-)
> >
> > diff --git a/configs/ls1012ardb_qspi_defconfig
> > b/configs/ls1012ardb_qspi_defconfig
> > index 81702e3..39d7a54 100644
> > --- a/configs/ls1012ardb_qspi_defconfig
> > +++ b/configs/ls1012ardb_qspi_defconfig
> > @@ -50,3 +50,4 @@ CONFIG_DM_USB=y
> > CONFIG_USB_XHCI_HCD=y
> > CONFIG_USB_XHCI_DWC3=y
> > CONFIG_USB_STORAGE=y
> > +CONFIG_DISTRO_DEFAULTS=y
> > diff --git a/include/configs/ls1012a_common.h
> > b/include/configs/ls1012a_common.h
> > index 096799e..b2d2307 100644
> > --- a/include/configs/ls1012a_common.h
> > +++ b/include/configs/ls1012a_common.h
> > @@ -90,6 +90,14 @@
> > #define CONFIG_HWCONFIG
> > #define HWCONFIG_BUFFER_SIZE 128
> >
> > +#include
> > +#ifndef CONFIG_SPL_BUILD
> > +#define BOOT_TARGET_DEVICES(func) \
> > + func(MMC, mmc, 0) \
> > + func(USB, usb, 0)
> > +#include
> > +#endif
> > +
> > /* Initial environment variables */
> > #define CONFIG_EXTRA_ENV_SETTINGS \
> > "verify=no\0" \
> > @@ -101,6 +109,7 @@
> > "kernel_load=0xa000\0" \
> > "kernel_size=0x280\0" \
> >
> > +#undef CONFIG_BOOTCOMMAND
> > #define CONFIG_BOOTCOMMAND "sf probe 0:0; sf read $kernel_load "\
> > "$kernel_start $kernel_size && "\
> > "bootm $kernel_load"
> > @@ -108,7 +117,6 @@
> > /* Monitor Command Prompt */
> > #define CONFIG_SYS_CBSIZE 512 /* Console I/O Buffer Size */
> > #define CONFIG_SYS_LONGHELP
> > -#define CONFIG_CMDLINE_EDITING 1
> > #define CONFIG_AUTO_COMPLETE
> > #define CONFIG_SYS_MAXARGS 64 /* max command args */
> >
> > diff --git a/include/configs/ls1012ardb.h
> > b/include/configs/ls1012ardb.h index e9edcd2..e612840 100644
> > --- a/include/configs/ls1012ardb.h
> > +++ b/include/configs/ls1012ardb.h
> > @@ -70,6 +70,49 @@
> > #define CONFIG_SYS_MEMTEST_START 0x8000
> > #define CONFIG_SYS_MEMTEST_END 0x9fff
> >
> > +#undef CONFIG_EXTRA_ENV_SETTINGS
> > +#define CONFIG_EXTRA_ENV_SETTINGS \
> > + "verify=no\0" \
> > + "fdt_high=0x\0" \
> > + "initrd_high=0x\0" \
> > + "fdt_addr=0x00f0\0" \
> > + "kernel_addr=0x0100\0" \
> > + "scriptaddr=0x8000\0" \
> > + "fdtheader_addr_r=0x8010\0" \
> > + "kernelheader_addr_r=0x8020\0" \
> > + "kernel_addr_r=0x8100\0"\
> > + "fdt_addr_r=0x9000\0" \
> > + "load_addr=0xa000\0"\
> > + "kernel_size=0x280\0" \
> > + "console=ttyS0,115200\0"\
> > + BOOTENV \
> > + "boot_scripts=ls1012ardb_boot.scr\0"\
> > + "scan_dev_for_boot_part=" \
> > +"part list ${devtype} ${devnum} devplist; "\
> > +"env exists devplist || setenv devplist 1; " \
> > +"for distro_bootpart in ${devplist}; do " \
> > + "if fstype ${devtype} " \
> > + "${devnum}:${distro_bootpart} " \
> > + "bootfstype; then " \
> > + "run scan_dev_for_boot; " \
> > + "fi; "\
> > + "done\0" \
> > + "scan_dev_for_boot=" \
> > + "echo Scanning ${devtype} " \
Re: [U-Boot] [PATCH 031/080] serial: ns16550: Fix address translation
Hi Mario, On 29 September 2017 at 06:51, Mario Six wrote: > The dev_read_addr function does not do any bus translations, and just > returns the raw address read from the device tree, which makes the > driver not work on systems that need bus translations to get the actual > memory address of the device's register space. Aside from any current functionality, what is the correct thing for dev_read_addr() to do? I worry that the two parts (live/flat tree) might do different things. In any case, we should not compound the problem if dev_read_addr() is wrong. > > Since the dev_read_addr function is widely used, we refrain from > modifying it, and instead read the raw address from the device tree, and > apply the bus translations using the recently introduced > dev_translate_address function. > > Signed-off-by: Mario Six > --- > drivers/serial/ns16550.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) REgards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 070/080] common: board_f: Fix style violations
On 29 September 2017 at 06:52, Mario Six wrote: > Fix some style violations in the board_f file. > > Signed-off-by: Mario Six > --- > common/board_f.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 02/11] efi_loader: avoid NULL dereference in efi_dp_match
On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > When calling bootefi hello twice a kernel dump occurs. > > Neither bootefi hello nor bootefi selftest have an image > device patch. So do not try to dereference the NULL > value. > > Fixes: 95c5553ea26 efi_loader: refactor boot device and loaded_image handling > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_boottime.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 08/11] efi_selftest: allow to select a single test for exexution
On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > The second argument of bootefi is passed as a configuration > table to the selftest application. It is used to select > a single test to be executed. > > Tests get an on_request property. If this property is set > the tests are only executed if explicitly requested. > > A new command 'bootefi selftest list' is added that allows to list > all tests. > > The invocation of efi_selftest is changed to reflect that > bootefi selftest list will call the Exit bootservice. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/bootefi.c| 24 -- > include/efi_selftest.h | 18 > lib/efi_selftest/efi_selftest.c | 88 > ++-- > lib/efi_selftest/efi_selftest_util.c | 9 > 4 files changed, 132 insertions(+), 7 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] cmd/fdt.c align data buffer to avoid unaligned word access
On 28 September 2017 at 03:29, Bernhard Messerklinger wrote: > Since the compiler is free to place a char array to any address in > memory (in this case the stack), also to a non word aligned address the > function "fdt_prop_parse" runs into troubles upon it wants to write some > (fdt32_t *) to such a variable (if it has been placed to a none word > aligned address). > > To avoid this we tell the compiler to always align this scratchpad to a > word aligned address. > > Signed-off-by: Bernhard Messerklinger > > --- > > cmd/fdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG
Hi Lokesh,
On 27 September 2017 at 00:27, Lokesh Vutla wrote:
>
>
> On Monday 25 September 2017 07:45 AM, Simon Glass wrote:
>> Hi,
>>
>> On 16 September 2017 at 23:12, Lokesh Vutla wrote:
>>> Simon,
>>>
>>> On 9/16/2017 9:43 PM, Simon Glass wrote:
Hi,
On 16 September 2017 at 07:43, Tom Rini wrote:
> On Sat, Sep 16, 2017 at 05:14:31PM +0530, Lokesh Vutla wrote:
>> Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting")
>> fixes the loop delay when using a hw watchdog. But assuming that Watchdog
>> kicking is taken care of by getc(). This is not true in case of
>> DM_SERIAL.
>> So, kick the watchdog before loop waiting, instead of relying on other
>> functions.
>>
>> Signed-off-by: Lokesh Vutla
>> ---
>> - This fixes UART boot on AM335x-evm.
>>
>> common/xyzModem.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/common/xyzModem.c b/common/xyzModem.c
>> index a0c5dfeece..8c4679473f 100644
>> --- a/common/xyzModem.c
>> +++ b/common/xyzModem.c
>> @@ -26,6 +26,7 @@
>> #include
>> #include
>> #include
>> +#include
>>
>> /* Assumption - run xyzModem protocol over the console port */
>>
>> @@ -64,6 +65,7 @@ CYGACC_COMM_IF_GETC_TIMEOUT (char chan, char *c)
>> {
>>
>>ulong now = get_timer(0);
>> + WATCHDOG_RESET();
>>while (!tstc ())
>> {
>>if (get_timer(now) > xyzModem_CHAR_TIMEOUT)
>
> My worry is that other places also assume watchdog petted by getc().
> Simon, is there a reason DM_SERIAL isn't doing what was done before?
> Thanks!
This should really be fixed at source. Is the problems in
_serial_tstc()? The watchdog is reset with _serial_getc().
>>>
>>> Sorry, my bad. WATCHDOG_RESET() is being called in __serial_getc() when
>>> err is -EAGAIN. But looks like it is never hitting this case. This way
>>> ymodem fails as watchdog gets reset when downloading large files.
>>
>> So every time we read a character there is one available? How can that
>> happen? Surely the CPU can run faster than the serial port?
>
> For a quick experiment, I added a infinite while loop[1] instead of
> -EAGAIN. I never hit this case when downloading with ymodem. File
> downloaded successfully with $patch even with the infinite while loop.
> Am I missing something?
>
> [1] http://pastebin.ubuntu.com/25625299/
Well it is very strange. I cannot imagine that a serial line could
keep up with the CPU requesting bytes. I think this needs more
investigation.
Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 029/080] gpio: pca953x_gpio: Make live-tree compatible
On 29 September 2017 at 06:51, Mario Six wrote: > Make the pca953x_gpio driver compatible with a live device tree. > > Signed-off-by: Mario Six > --- > drivers/gpio/pca953x_gpio.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 024/080] net: tsec: Make live-tree compatible
On 29 September 2017 at 06:51, Mario Six wrote: > Make the tsec ethernet driver compatible with a live device tree. > > Signed-off-by: Mario Six > --- > drivers/net/tsec.c | 41 ++--- > 1 file changed, 18 insertions(+), 23 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v3 1/7] spl: fix assignment of board info to global data
On 28 September 2017 at 09:42, York Sun wrote:
> Commit 15eb1d43bf47 ("spl: reorder the assignment of board info to
> global data") intended to move assignment of board info earlier,
> into board_init_r(). However, function preload_console_init() is
> called either from spl_board_init() or from board_init_f(). For the
> latter case, the board info assignment is much earlier than proposed
> board_init_r(). Create a new function to fill gd->bd and call this
> function when needed.
>
> Signed-off-by: York Sun
> CC: Lokesh Vutla
> CC: Ravi Babu
> CC: Lukasz Majewski
> CC: Tom Rini
>
> ---
>
> Changes in v3:
> Create new function to fill gd->bd for spl.
> Use git commit description style when mentioning previous commit.
>
> Changes in v2:
> New patch to fix spl after rebasing to latest master.
>
> arch/arm/cpu/armv8/fsl-layerscape/spl.c | 1 +
> common/spl/spl.c| 10 +-
> include/spl.h | 1 +
> 3 files changed, 11 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 017/080] spi: Remove spi_setup_slave_fdt
On 29 September 2017 at 06:51, Mario Six wrote: > A previous patch removed the spi_flash_probe_fdt function, which > contained the last call of the spi_setup_slave_fdt function, which is > now equally obsolete. > > This patch removes the function. > > Signed-off-by: Mario Six > --- > drivers/spi/spi-uclass.c | 16 > include/spi.h| 13 - > 2 files changed, 29 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 013/080] clk: Remove superfluous gd declarations
On 29 September 2017 at 06:51, Mario Six wrote: > The clk uclass was converted to support a live device tree recently, > hence the global data pointer declarations are no longer needed. > > Signed-off-by: Mario Six > --- > drivers/clk/clk-uclass.c | 2 -- > drivers/clk/clk_fixed_rate.c | 2 -- > 2 files changed, 4 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 005/080] lib: fdtdec: Fix whitespace style violations
On 29 September 2017 at 06:51, Mario Six wrote: > Fix some whitespace-related style violations in fdtdec.c. > > Signed-off-by: Mario Six > --- > lib/fdtdec.c | 56 ++-- > 1 file changed, 30 insertions(+), 26 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 021/080] sf_probe: Merge spi_flash_probe_tail into spi_flash_probe
On 29 September 2017 at 06:51, Mario Six wrote: > spi_flash_probe_tail is now only called from spi_flash_probe, hence we > can merge its body into spi_flash_probe. > > Signed-off-by: Mario Six > --- > drivers/mtd/spi/sf_probe.c | 19 +++ > 1 file changed, 7 insertions(+), 12 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 012/080] clk: clk_fixed_rate: Fix style violation
On 29 September 2017 at 06:51, Mario Six wrote: > Fix a mis-indented function call in clk_fixed_rate.c > > Signed-off-by: Mario Six > --- > drivers/clk/clk_fixed_rate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] ARM: dts: OMAP5+: Add support for bandgap sensor in SPL
On 6 October 2017 at 05:35, Faiz Abbas wrote: > Mark bandgap node as uboot,dm-spl so that it can be accessed in spl > > Signed-off-by: Faiz Abbas > --- > arch/arm/dts/omap5-u-boot.dtsi | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 08/19] fs: Enable generic filesystems interface support in SPL.
On 25 September 2017 at 02:40, wrote: > From: Tien Fong Chee > > Enable generic filesystem interface drivers(fs.c and fat/) build > for SPL. This would allow generic filesystem being used in SPL. > > Signed-off-by: Tien Fong Chee > --- > common/spl/Kconfig | 8 > doc/README.SPL | 1 + > fs/Makefile| 1 + > 3 files changed, 10 insertions(+) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] linux/bitfield.h: import from Linux 4.13
On 25 September 2017 at 21:12, Masahiro Yamada wrote: > Copied from Linux 4.13. > > Commit log of 3e9b3112ec74 of Linux explains well why this header > is useful. > > Signed-off-by: Masahiro Yamada > --- > > In order to use this header, > http://patchwork.ozlabs.org/patch/814471/ > must be applied. > > is highly dependent on > > > include/linux/bitfield.h | 106 > +++ > 1 file changed, 106 insertions(+) > create mode 100644 include/linux/bitfield.h Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 05/11] efi_loader: move efi_search_obj up in code
On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > To avoid a forward declaration move efi_search_obj before > all protocol services functions. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_boottime.c | 41 + > 1 file changed, 21 insertions(+), 20 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 03/11] efi_loader: comments for functions add missing @return
On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > For some functions the @return description is missing. > > Fix typo. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_boottime.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 06/11] efi_loader: implement SetWatchdogTimer
On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > The watchdog is initialized with a 5 minute timeout period. > It can be reset by SetWatchdogTimer. > It is stopped by ExitBoottimeServices. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/bootefi.c | 1 + > include/efi_loader.h | 4 +++ > lib/efi_loader/Makefile | 2 +- > lib/efi_loader/efi_boottime.c | 15 ++- > lib/efi_loader/efi_watchdog.c | 59 > +++ > 5 files changed, 67 insertions(+), 14 deletions(-) > create mode 100644 lib/efi_loader/efi_watchdog.c Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 016/080] spi: Remove spi_flash_probe_fdt
On 29 September 2017 at 06:51, Mario Six wrote:
> Commit ba45756 ("dm: x86: spi: Convert ICH SPI driver to driver model")
> removed the last usage of the spi_flash_probe_fdt function, rendering it
> obsolete.
>
> This patch removes the function.
>
> Signed-off-by: Mario Six
> ---
> drivers/mtd/spi/sf_probe.c | 13 -
> include/spi_flash.h| 12
> 2 files changed, 25 deletions(-)
Reviewed-by: Simon Glass
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 004/080] include: dm: Fix 'devioe'/'devuce' typos
On 29 September 2017 at 06:51, Mario Six wrote: > There are some typos in the documentation of some functions in read.h; > fix those. > > Signed-off-by: Mario Six > --- > include/dm/read.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: serial: Wait for ongoing transmission to finish before serial reset
Hi Lukasz,
On 3 October 2017 at 03:16, Lukasz Majewski wrote:
> It may happen that the MXC serial IP block is performing some ongoing
> transmission (started at e.g. board_init()) when the "initr_serial" is
> called.
>
> As a result the serial port IP block is reset, so transmitted data is
> corrupted:
>
> I2C: ready
> DRAM: 1 GiB
> jSS('HH��SL_SDHC: 04 rev 0x0
>
> This patch prevents from this situation, by waiting for transmission
> complete bit set (UART Status Register 2 (UARTx_USR2), bit TXDC):
>
> I2C: ready
> DRAM: 1 GiB
> ID:unit type 0x4 rev 0x0
>
> Signed-off-by: Lukasz Majewski
> ---
>
> drivers/serial/serial_mxc.c | 7 +++
> 1 file changed, 7 insertions(+)
Is it possible to use driver model to do this in a generic way for all
serial drivers? The pending() method allows you to check if there are
any characters in the output FIFO.
Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 01/11] efi_selftest: avoid dereferencing NULL in tpl test
On 7 October 2017 at 22:57, Heinrich Schuchardt wrote:
> The task priority levels test uses two events one passes the
> notification counter as context. The other passes NULL.
> Both use the same notification function. So we need to check
> for NULL here.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_selftest/efi_selftest_tpl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/efi_selftest/efi_selftest_tpl.c
> b/lib/efi_selftest/efi_selftest_tpl.c
> index 0b78ee7595..b8c0e70262 100644
> --- a/lib/efi_selftest/efi_selftest_tpl.c
> +++ b/lib/efi_selftest/efi_selftest_tpl.c
> @@ -26,7 +26,8 @@ static void EFIAPI notify(struct efi_event *event, void
> *context)
> {
> unsigned int *count = context;
Ick, this should go in a struct.
struct something *ctx = context;
ctx->count++
>
> - ++*count;
> + if (count)
> + ++*count;
> }
>
> /*
> --
> 2.14.1
>
Anyway, for this patch:
Reviewed-by: Simon Glass
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 020/080] spi: spi-uclass: Fix style violations
On 29 September 2017 at 06:51, Mario Six wrote: > Remove a superfluous newline, and reduce the scope of a variable. > > Signed-off-by: Mario Six > --- > drivers/spi/spi-uclass.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 07/11] efi_selftest: provide test for watchdog timer
On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > The test verifies that resetting the watchdog timer ensures > that it is not called during the timeout period. > > Testing that the watchdog timer actually executes a reset > would require a test outside the efi_selftest framework. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/Makefile| 5 +- > lib/efi_selftest/efi_selftest_watchdog.c | 185 > +++ > 2 files changed, 189 insertions(+), 1 deletion(-) > create mode 100644 lib/efi_selftest/efi_selftest_watchdog.c Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 10/11] test/py: test reboot by EFI watchdog
On 7 October 2017 at 22:57, Heinrich Schuchardt wrote:
> Provide a test verifying that the EFI watchdog
> reboots the system upon timeout.
>
> The test depends on CONFIG_CMD_EFI_SELFTEST=y.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> test/py/tests/test_efi_selftest.py | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)Reviewed-by: Simon Glass
>
Reviewed-by: Simon Glass
But why are you removing the NVIDIA copyright?
>
> diff --git a/test/py/tests/test_efi_selftest.py
> b/test/py/tests/test_efi_selftest.py
> index 76e282a6c7..b0a86ea8b8 100644
> --- a/test/py/tests/test_efi_selftest.py
> +++ b/test/py/tests/test_efi_selftest.py
> @@ -1,4 +1,3 @@
> -# Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
> # Copyright (c) 2017, Heinrich Schuchardt
> #
> # SPDX-License-Identifier: GPL-2.0
> @@ -23,3 +22,13 @@ def test_efi_selftest(u_boot_console):
> if m != 0:
> raise Exception('Reset failed during the EFI selftest')
> u_boot_console.restart_uboot();
> +
> +@pytest.mark.buildconfigspec('cmd_bootefi_selftest')
> +def test_efi_selftest_watchdog_reboot(u_boot_console):
> + output = u_boot_console.run_command('bootefi selftest list')
> + assert '\'watchdog reboot\'' in output
> + u_boot_console.run_command(cmd='bootefi selftest \'watchdog
> reboot\'', wait_for_prompt=False)
> + m = u_boot_console.p.expect(['resetting', 'U-Boot'])
> + if m != 0:
> + raise Exception('Reset failed in \'watchdog reboot\' test')
> + u_boot_console.restart_uboot();
> --
> 2.14.1
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] thermal: ti-bandgap: Add support for temperature sensor
Hi Faiz,
On 6 October 2017 at 05:35, Faiz Abbas wrote:
> The dra7xx series of SOCs contain a temperature sensor and an
> associated analog-to-digital converter (ADC) which produces
> an output which is proportional to the SOC temperature.
> Add support for this temperature sensor.
>
> Signed-off-by: Faiz Abbas
> ---
> common/spl/Kconfig | 8 +
> configs/dra7xx_evm_defconfig | 3 +
> .../thermal/ti_soc_thermal.txt | 35
> drivers/Makefile | 2 +-
> drivers/thermal/Kconfig| 5 +
> drivers/thermal/Makefile | 1 +
> drivers/thermal/ti-bandgap.c | 197
> +
> 7 files changed, 250 insertions(+), 1 deletion(-)
> create mode 100644 doc/device-tree-bindings/thermal/ti_soc_thermal.txt
> create mode 100644 drivers/thermal/ti-bandgap.c
>
Reviewed-by: Simon Glass
But please see comments below.
> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> index 0bd8370..81f75ec 100644
> --- a/common/spl/Kconfig
> +++ b/common/spl/Kconfig
> @@ -604,6 +604,14 @@ config SPL_SPI_SUPPORT
> enable SPI drivers that are needed for other purposes also, such
> as a SPI PMIC.
>
> +config SPL_THERMAL_SUPPORT
Can we drop the _SUPPORT suffix? I don't think it is needed
> + bool "Driver support for thermal devices"
> + help
> + Enable support for temperature-sensing devices. Some SoCs have
> on-chip
> + temperature sensors to permit warnings, speed throttling or even
> + automatic power-off when the temperature gets too high or low.
> Other
> + devices may be discrete but connected on a suitable bus.
> +
> config SPL_USB_HOST_SUPPORT
> bool "Support USB host drivers"
> help
> diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig
> index 468c288..e40a6c8 100644
> --- a/configs/dra7xx_evm_defconfig
> +++ b/configs/dra7xx_evm_defconfig
> @@ -90,3 +90,6 @@ CONFIG_USB_GADGET=y
> CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0451
> CONFIG_USB_GADGET_PRODUCT_NUM=0xd022
> +CONFIG_SPL_THERMAL_SUPPORT=y
> +CONFIG_DM_THERMAL=y
> +CONFIG_TI_DRA7_THERMAL=y
> diff --git a/doc/device-tree-bindings/thermal/ti_soc_thermal.txt
> b/doc/device-tree-bindings/thermal/ti_soc_thermal.txt
> new file mode 100644
> index 000..b4e88c2
> --- /dev/null
> +++ b/doc/device-tree-bindings/thermal/ti_soc_thermal.txt
> @@ -0,0 +1,35 @@
> +* Texas Instrument dra7xx SCM bandgap bindings
> +
> +In the System Control Module, SoC supplies a voltage reference
> +and a temperature sensor feature that are gathered in the band
> +gap voltage and temperature sensor (VBGAPTS) module. The band
> +gap provides current and voltage reference for its internal
> +circuits and other analog IP blocks. The analog-to-digital
> +converter (ADC) produces an output value that is proportional
> +to the silicon temperature.
> +
> +Required properties:
> +- compatible : Should be:
> + - "ti,dra752-bandgap"
> +- interrupts : this entry should indicate which interrupt line
> +the talert signal is routed to;
> +- regs : this is specific to each bandgap version, because
> +the mapping may change from soc to soc, apart from depending
> +on available features.
> +
> +Optional:
> +- gpios : this entry should be used to inform which GPIO
> +line the tshut signal is routed to. The informed GPIO will
> +be treated as an IRQ;
> +
> +Example:
> +bandgap {
> + reg = <0x4a0021e0 0xc
> + 0x4a00232c 0xc
> + 0x4a002380 0x2c
> + 0x4a0023C0 0x3c
> + 0x4a002564 0x8
> + 0x4a002574 0x50>;
> + compatible = "ti,dra752-bandgap";
> + interrupts = <0 126 4>; /* talert */
> +};
> diff --git a/drivers/Makefile b/drivers/Makefile
> index dab5c18..0809187 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -50,7 +50,7 @@ obj-$(CONFIG_SPL_SATA_SUPPORT) += ata/ scsi/
> obj-$(CONFIG_SPL_USB_HOST_SUPPORT) += block/
> obj-$(CONFIG_SPL_MMC_SUPPORT) += block/
> obj-$(CONFIG_SPL_FPGA_SUPPORT) += fpga/
> -
> +obj-$(CONFIG_SPL_THERMAL_SUPPORT) += thermal/
> endif
> endif
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 886f5fa..5ffb87a 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -17,4 +17,9 @@ config IMX_THERMAL
>cpufreq is used as the cooling device to throttle CPUs when the
>passive trip is crossed.
>
> +config TI_DRA7_THERMAL
> +bool "Temperature sensor driver for TI dra7xx SOCs"
> +help
> + Enable thermal support for for the Texas Instruments DRA752 SoC
> family.
Please can you expand this? What features are provided? What bus does it use?
> +
> endif # if DM_THERMAL
> diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
> index d768f5e..f
Re: [U-Boot] [PATCH v2 12/17] efi_loader: fix efi_net_get_status
On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > The returned interrupt status was wrong. > > As out transmit buffer is empty we need to always set > EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT. > > When we have received a packet we need to set > EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT. > > Furthermore we should call efi_timer_check() to handle events. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_api.h| 6 ++ > lib/efi_loader/efi_net.c | 11 --- > 2 files changed, 14 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 006/080] lib: fdtdec: Fix some style violations
On 29 September 2017 at 06:51, Mario Six wrote: > Fix some style violations in fdtdec.c, and reduce the scope of some > variables. > > Signed-off-by: Mario Six > --- > lib/fdtdec.c | 31 --- > 1 file changed, 16 insertions(+), 15 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 09/11] efi_selftest: test reboot by watchdog
On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > A test is added that verifies that the watchdog timer actually > causes a reboot upon timeout. The test in only executed on > request using > > bootefi selftest 'watchdog reboot' > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest_watchdog.c | 65 > +++- > 1 file changed, 55 insertions(+), 10 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 011/080] clk: clk-uclass: Fix style violations
On 29 September 2017 at 06:51, Mario Six wrote:
> checkpatch.pl complains that the clk_ops structures used in clk-uclass.c
> ought to be static, so we mark them as static.
Do you mean static, or const?
Otherwise:
Reviewed-by: Simon Glass
>
> Signed-off-by: Mario Six
> ---
> drivers/clk/clk-uclass.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c
> index 83ba13374c..32be2e85c5 100644
> --- a/drivers/clk/clk-uclass.c
> +++ b/drivers/clk/clk-uclass.c
> @@ -15,9 +15,9 @@
>
> DECLARE_GLOBAL_DATA_PTR;
>
> -static inline struct clk_ops *clk_dev_ops(struct udevice *dev)
> +static inline const struct clk_ops *clk_dev_ops(struct udevice *dev)
> {
> - return (struct clk_ops *)dev->driver->ops;
> + return (const struct clk_ops *)dev->driver->ops;
> }
>
> #if CONFIG_IS_ENABLED(OF_CONTROL)
> @@ -60,7 +60,7 @@ int clk_get_by_index(struct udevice *dev, int index, struct
> clk *clk)
> int ret;
> struct ofnode_phandle_args args;
> struct udevice *dev_clk;
> - struct clk_ops *ops;
> + const struct clk_ops *ops;
>
> debug("%s(dev=%p, index=%d, clk=%p)\n", __func__, dev, index, clk);
>
> @@ -68,7 +68,7 @@ int clk_get_by_index(struct udevice *dev, int index, struct
> clk *clk)
> clk->dev = NULL;
>
> ret = dev_read_phandle_with_args(dev, "clocks", "#clock-cells", 0,
> - index, &args);
> +index, &args);
> if (ret) {
> debug("%s: fdtdec_parse_phandle_with_args failed: err=%d\n",
> __func__, ret);
> @@ -142,7 +142,7 @@ int clk_release_all(struct clk *clk, int count)
>
> int clk_request(struct udevice *dev, struct clk *clk)
> {
> - struct clk_ops *ops = clk_dev_ops(dev);
> + const struct clk_ops *ops = clk_dev_ops(dev);
>
> debug("%s(dev=%p, clk=%p)\n", __func__, dev, clk);
>
> @@ -156,7 +156,7 @@ int clk_request(struct udevice *dev, struct clk *clk)
>
> int clk_free(struct clk *clk)
> {
> - struct clk_ops *ops = clk_dev_ops(clk->dev);
> + const struct clk_ops *ops = clk_dev_ops(clk->dev);
>
> debug("%s(clk=%p)\n", __func__, clk);
>
> @@ -168,7 +168,7 @@ int clk_free(struct clk *clk)
>
> ulong clk_get_rate(struct clk *clk)
> {
> - struct clk_ops *ops = clk_dev_ops(clk->dev);
> + const struct clk_ops *ops = clk_dev_ops(clk->dev);
>
> debug("%s(clk=%p)\n", __func__, clk);
>
> @@ -180,7 +180,7 @@ ulong clk_get_rate(struct clk *clk)
>
> ulong clk_set_rate(struct clk *clk, ulong rate)
> {
> - struct clk_ops *ops = clk_dev_ops(clk->dev);
> + const struct clk_ops *ops = clk_dev_ops(clk->dev);
>
> debug("%s(clk=%p, rate=%lu)\n", __func__, clk, rate);
>
> @@ -192,7 +192,7 @@ ulong clk_set_rate(struct clk *clk, ulong rate)
>
> int clk_enable(struct clk *clk)
> {
> - struct clk_ops *ops = clk_dev_ops(clk->dev);
> + const struct clk_ops *ops = clk_dev_ops(clk->dev);
>
> debug("%s(clk=%p)\n", __func__, clk);
>
> @@ -204,7 +204,7 @@ int clk_enable(struct clk *clk)
>
> int clk_disable(struct clk *clk)
> {
> - struct clk_ops *ops = clk_dev_ops(clk->dev);
> + const struct clk_ops *ops = clk_dev_ops(clk->dev);
>
> debug("%s(clk=%p)\n", __func__, clk);
>
> --
> 2.11.0
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 009/080] core: Add {ofnode, dev}_translate_address functions
On 29 September 2017 at 06:51, Mario Six wrote: > Signed-off-by: Mario Six > --- > drivers/core/ofnode.c | 8 > drivers/core/read.c | 5 + > include/dm/ofnode.h | 13 + > include/dm/read.h | 17 + > 4 files changed, 43 insertions(+) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 007/080] core: ofnode: Fix style violations
On 29 September 2017 at 06:51, Mario Six wrote: > There are some style violations in ofnode.c; fix those. > > Signed-off-by: Mario Six > --- > drivers/core/ofnode.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 018/080] spi: Remove CONFIG_OF_SPI_FLASH
On 29 September 2017 at 06:51, Mario Six wrote: > Previous patches removed the last usages of this config variable, so > that it is now obsolete. > > This patch removes it from the whitelist. > > Signed-off-by: Mario Six > --- > scripts/config_whitelist.txt | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 10/17] efi_loader: use events for efi_net_receive
On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > A timer event is defined. The timer handler cares for receiving new > packets. > > efi_timer_check is called both in efi_net_transmit and efi_net_receive > to enable events during network communication. > > Calling efi_timer_check in efi_net_get_status is implemented in a > separate patch. Can you explain in the commit message why this patch is needed? > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_net.c | 53 > +--- > 1 file changed, 50 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 015/080] spi: Remove obsolete spi_base_setup_slave_fdt
On 29 September 2017 at 06:51, Mario Six wrote:
> 0efc024 ("spi_flash: Add spi_flash_probe_fdt() to locate SPI by FDT
> node") added a helper function spi_base_setup_slave_fdt to to set up a
> SPI slave from a given FDT blob. The only user was the exynos SPI
> driver.
>
> But commit 73186c9 ("dm: exynos: Convert SPI to driver model") removed
> the use of this function, hence rendering it obsolete.
>
> Remove this function, as well as the CONFIG_OF_SPI option, which guarded
> only this function.
>
> Signed-off-by: Mario Six
> ---
> drivers/spi/spi.c| 20
> include/spi.h| 14 --
> scripts/config_whitelist.txt | 1 -
> 3 files changed, 35 deletions(-)
Reviewed-by: Simon Glass
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 071/080] common: board_r: Fix style violations
On 29 September 2017 at 06:52, Mario Six wrote: > Fix some style violations in the board_r file. > > Signed-off-by: Mario Six > --- > common/board_r.c | 27 ++- > 1 file changed, 14 insertions(+), 13 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] ARM: SPL: FIT: fix DTC warnings on FIT generation
Hi Andre, On 4 October 2017 at 17:24, Andre Przywara wrote: > Newer versions of the device tree compiler (rightfully) complain about > mismatches between attributed node names (name@) and a missing > reg property in that node. > Adjust the FIT build script for 64-bit Allwinner boards to remove the > bogus addresses from the node names and avoid the warnings. > > Signed-off-by: Andre Przywara > --- > board/sunxi/mksunxi_fit_atf.sh | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) It looks like we have this problem all over the place. The documentation in doc/uImage now seems to have this problem too. I wonder if instead we should add reg / #address-cells / #size-cells properties? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 010/080] core: Make device_is_compatible live-tree compatible
On 29 September 2017 at 06:51, Mario Six wrote: > Judging from its name and parameters, device_is_compatible looks like it > is compatible with a live device tree, but it actually isn't. > > Make is compatible with a live device tree. > > Signed-off-by: Mario Six > --- > drivers/core/device.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 09/19] arm: socfpga: Add drivers for programing FPGA from flash
Hi, On 25 September 2017 at 02:40, wrote: > From: Tien Fong Chee > > These drivers handle FPGA program operation from flash loading > RBF to memory and then to program FPGA. > > Signed-off-by: Tien Fong Chee > --- > .../include/mach/fpga_manager_arria10.h| 27 ++ > drivers/fpga/socfpga_arria10.c | 391 > - > include/altera.h | 6 + > include/configs/socfpga_common.h | 4 + > 4 files changed, 425 insertions(+), 3 deletions(-) Agreed on the generic loader, but also, can you please use driver model? Am I missing something? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 07/26] mmc: Add a function to dump the mmc capabilities
On 2 October 2017 at 02:57, Jean-Jacques Hiblot wrote: > Hi Jaehoon, > > > On 22/09/2017 15:54, Jaehoon Chung wrote: >> >> Hi, >> >> On 09/21/2017 11:29 PM, Jean-Jacques Hiblot wrote: >>> >>> This adds a simple helper function to display information (bus width and >>> mode) based on a capability mask. Useful for debug. >> >> I agreed this is useful.. but there is no usage in your patch. >> How did you use this? and Where does call this function.. >> >> I think it can be used the one of mmc command. how about? > > At first I added it to "mmc info" but it's more for the developer than the > user, so I removed it from there. > At the moment it is not referenced anywhere the code, but I left it in place > because it's indeed useful when debugging the initialization. > Thinking of it I could add something right after the card capabilities are > discovered if debug is enabled. What do you think? > > Jean-Jacques That seems reasonable. In any case, we cannot add dead code. - Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 080/080] clk: Makefile: Sort entries alphabetically
On 29 September 2017 at 06:52, Mario Six wrote: > The Makefile entries in the clk driver directory were not alphabetically > sorted. Correct this. > > Signed-off-by: Mario Six > --- > drivers/clk/Makefile | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 04/11] efi_selftest: error handling in SNP test
On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > Avoid NULL pointer dereference after setup failed due to a > missing network. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest_snp.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 13/17] efi_loader: size fields in SimpleNetworkProtocol
On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > The size fields in the Simple Network Protocol are all > UINTN in the UEFI spec. So use size_t. > > Provide a function description of the receive function. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_api.h| 4 ++-- > lib/efi_loader/efi_net.c | 24 > 2 files changed, 22 insertions(+), 6 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: kbd: Don't fail with iomux
+Tom On 26 September 2017 at 19:19, Rob Clark wrote: > stdin might not be set, which would cause iomux_doenv() to fail > therefore causing probe_usb_keyboard() to fail. Furthermore if we do > have iomux enabled, the sensible thing (in terms of user experience) > would be to simply add ourselves to the list of stdin devices. > > This fixes an issue with usbkbd on dragonboard410c with distro- > bootcmd, where stdin is not set (so stdinname is null). > > Signed-off-by: Rob Clark > --- > Somehow this patch was dropped on the floor. I don't remember > which version # this is up to, search the list if you care. But > this is the latest. I only noticed it was missing because u-boot > crashes when you boot with usb-keyboard plugged in (at least on > db410c) without it. So someone please apply this patch before it > gets lost again. > > common/usb_kbd.c | 46 +++--- > include/console.h | 2 -- > 2 files changed, 31 insertions(+), 17 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 14/17] efi_loader: fill return values in SimpleNetworkProtocol
On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > In the receive function all return values should be filled. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_net.c | 27 +-- > 1 file changed, 25 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass (in so far as I understand it) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 08/11] efi_selftest: allow to select a single test for exexution
On 08.10.17 06:57, Heinrich Schuchardt wrote: > The second argument of bootefi is passed as a configuration > table to the selftest application. It is used to select > a single test to be executed. > > Tests get an on_request property. If this property is set > the tests are only executed if explicitly requested. > > A new command 'bootefi selftest list' is added that allows to list > all tests. > > The invocation of efi_selftest is changed to reflect that > bootefi selftest list will call the Exit bootservice. > > Signed-off-by: Heinrich Schuchardt Wouldn't it make more sense to just pass "bootargs" to the EFI payload as command line arguments? We could then just U-Boot# setenv bootargs list U-Boot# bootefi selftest to list the available self tests. Same for selecting them. That way we would also be able to directly load Linux as EFI binary and pass command line arguments to it without jumping through fdt patching hoops. Alex ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 17/17] efi_loader: supply EFI network test
On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > This patch provices an EFI application to check the correct function > of the Simple Network Protocol implementation. > > It sends a DHCP request and analyzes the DHCP offer. > > Different error conditions including a 10s timeout are checked. > > A successful execution will look like this: > > => bootefi nettest > Scanning disk ide.blk#0... > Found 1 disks > WARNING: Invalid device tree, expect boot to fail > Network test > DHCP Discover > DHCP reply received from 192.168.76.2 (52:55:c0:a8:4c:02) > as broadcast message. > OK. The test was completed successfully. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > move efi_st_memcmp to efi_selftest_util.c > The function can be reused for other tests. > > Use constants for return values. > --- > include/efi_selftest.h | 11 + > lib/efi_selftest/Makefile| 8 +- > lib/efi_selftest/efi_selftest_snp.c | 424 > +++ > lib/efi_selftest/efi_selftest_util.c | 25 +++ > 4 files changed, 467 insertions(+), 1 deletion(-) > create mode 100644 lib/efi_selftest/efi_selftest_snp.c > create mode 100644 lib/efi_selftest/efi_selftest_util.c Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 01/17] efi_loader: call EFI_EXIT in efi_copy_mem, efi_set_mem
On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > EFI_ENTRY and EFI_EXIT calls must match. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_boottime.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 16/17] efi_selftest: allow printing MAC addresses
On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > Add %pm as format string to print a MAC address. > This is helpful when analyzing network problems. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_selftest/efi_selftest_console.c | 41 > - > 1 file changed, 40 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass I wonder if we could use U-Boot's existing printf() code? ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 09/17] efi_net: return EFI_UNSUPPORTED where appropriate
On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > U-Boot does not implement all functions of the simple network > protocol. The unimplemented functions return either of > EFI_SUCCESS and EFI_INVALID_PARAMETER. > > The UEFI spec foresees to return EFI_UNSUPPORTED in these cases. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_net.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 030/080] serial: ns16550: Fix style violation
On 29 September 2017 at 06:51, Mario Six wrote: > Clarify the computation precedence in two ternary operator > constructions. > > Signed-off-by: Mario Six > --- > drivers/serial/ns16550.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 05/17] efi_loader: incorrect definition of EFI_SIMPLE_NETWORK_PROTOCOL
On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > WaitForPacket is an event and not a function pointer. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_api.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 008/080] core: read: Fix style violations
On 29 September 2017 at 06:51, Mario Six wrote: > There are some whitespace-related style violations in read.c; fix those. > > Signed-off-by: Mario Six > --- > drivers/core/read.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 15/17] efi_selftest: correct definition of efi_st_error
On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > Enclose definition in parantheses to allow using efi_st_error > like a void function. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_selftest.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 04/17] efi_loader: wrong type in wait_for_event
On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > The UEFI spec defines parameter index of WaitForEvent as UINTN*. > So we should use size_t here. > > I deliberately do not use UINTN because I hold a following patch > that will eliminate UINTN because uppercase types to not match > the U-Boot coding style. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_api.h | 2 +- > lib/efi_loader/efi_boottime.c | 2 +- > lib/efi_selftest/efi_selftest_events.c | 2 +- > lib/efi_selftest/efi_selftest_tpl.c| 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 07/17] efi_loader: fill simple network protocol revision
On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > Provide the simple network protocol revision. > This revision number could be used to identify backwards compatible > enhancements of the protocol. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_api.h| 3 +++ > lib/efi_loader/efi_net.c | 1 + > 2 files changed, 4 insertions(+) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 08/17] efi_loader: efi_net: hwaddr_size = 6
On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > The length of a MAC address is 6. > We have to set this length in the EFI_SIMPLE_NETWORK_MODE > structure of the EFI_SIMPLE_NETWORK_PROTOCOL. > > Without this patch iPXE fails to initialize the network with > error message > SNP MAC(001e0633bcbf,0x0) has invalid hardware address length 0 > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_net.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] efi_loader: Fix disk dp's for pre-DM/legacy devices
> This fixes an issue with OpenBSD's bootloader, and I think should also > fix a similar issue with grub2 on legacy devices. In the legacy case > we were creating disk objects for the partitions, but not also the > parent device. > > Reported-by: Jonathan Gray > Signed-off-by: Rob Clark Thanks, applied to efi-next Alex ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 03/17] efi_loader: pass GUIDs as const efi_guid_t *
On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > We need to call some boottime services internally. > Our GUIDs are stored as const efi_guid_t *. > > The boottime services never change GUIDs. > So we can define the parameters as const efi_guid_t *. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_api.h | 27 ++- > lib/efi_loader/efi_boottime.c | 40 +--- > 2 files changed, 35 insertions(+), 32 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 06/11] efi_loader: implement SetWatchdogTimer
On 08.10.17 06:57, Heinrich Schuchardt wrote:
> The watchdog is initialized with a 5 minute timeout period.
> It can be reset by SetWatchdogTimer.
> It is stopped by ExitBoottimeServices.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> cmd/bootefi.c | 1 +
> include/efi_loader.h | 4 +++
> lib/efi_loader/Makefile | 2 +-
> lib/efi_loader/efi_boottime.c | 15 ++-
> lib/efi_loader/efi_watchdog.c | 59
> +++
> 5 files changed, 67 insertions(+), 14 deletions(-)
> create mode 100644 lib/efi_loader/efi_watchdog.c
>
> diff --git a/cmd/bootefi.c b/cmd/bootefi.c
> index b7087e3da8..24958ada46 100644
> --- a/cmd/bootefi.c
> +++ b/cmd/bootefi.c
> @@ -43,6 +43,7 @@ static void efi_init_obj_list(void)
> #ifdef CONFIG_GENERATE_SMBIOS_TABLE
> efi_smbios_register();
> #endif
> + efi_watchdog_register();
>
> /* Initialize EFI runtime services */
> efi_reset_system_init();
> diff --git a/include/efi_loader.h b/include/efi_loader.h
> index e1179b7dcd..223d8d8222 100644
> --- a/include/efi_loader.h
> +++ b/include/efi_loader.h
> @@ -163,6 +163,8 @@ int efi_disk_register(void);
> int efi_gop_register(void);
> /* Called by bootefi to make the network interface available */
> int efi_net_register(void);
> +/* Called by bootefi to make the watchdog available */
> +int efi_watchdog_register(void);
> /* Called by bootefi to make SMBIOS tables available */
> void efi_smbios_register(void);
>
> @@ -171,6 +173,8 @@ efi_fs_from_path(struct efi_device_path *fp);
>
> /* Called by networking code to memorize the dhcp ack package */
> void efi_net_set_dhcp_ack(void *pkt, int len);
> +/* Called by efi_set_watchdog_timer to reset the timer */
> +efi_status_t efi_set_watchdog(unsigned long timeout);
>
> /* Called from places to check whether a timer expired */
> void efi_timer_check(void);
> diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile
> index ddb978f650..83d879b686 100644
> --- a/lib/efi_loader/Makefile
> +++ b/lib/efi_loader/Makefile
> @@ -17,7 +17,7 @@ endif
> obj-$(CONFIG_CMD_BOOTEFI_HELLO) += helloworld_efi.o
> obj-y += efi_image_loader.o efi_boottime.o efi_runtime.o efi_console.o
> obj-y += efi_memory.o efi_device_path_to_text.o efi_device_path.o
> -obj-y += efi_file.o efi_variable.o efi_bootmgr.o
> +obj-y += efi_file.o efi_variable.o efi_bootmgr.o efi_watchdog.o
> obj-$(CONFIG_LCD) += efi_gop.o
> obj-$(CONFIG_DM_VIDEO) += efi_gop.o
> obj-$(CONFIG_PARTITIONS) += efi_disk.o
> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
> index 30577f717e..81e7d818fc 100644
> --- a/lib/efi_loader/efi_boottime.c
> +++ b/lib/efi_loader/efi_boottime.c
> @@ -155,18 +155,6 @@ void efi_signal_event(struct efi_event *event)
> event->is_queued = false;
> }
>
> -/*
> - * Write a debug message for an EPI API service that is not implemented yet.
> - *
> - * @funcname function that is not yet implemented
> - * @return EFI_UNSUPPORTED
> - */
> -static efi_status_t efi_unsupported(const char *funcname)
> -{
> - debug("EFI: App called into unimplemented function %s\n", funcname);
> - return EFI_EXIT(EFI_UNSUPPORTED);
> -}
> -
> /*
> * Raise the task priority level.
> *
> @@ -1454,6 +1442,7 @@ static efi_status_t EFIAPI efi_exit_boot_services(void
> *image_handle,
> bootm_disable_interrupts();
>
> /* Give the payload some time to boot */
> + efi_set_watchdog(0);
> WATCHDOG_RESET();
>
> return EFI_EXIT(EFI_SUCCESS);
> @@ -1514,7 +1503,7 @@ static efi_status_t EFIAPI
> efi_set_watchdog_timer(unsigned long timeout,
> {
> EFI_ENTRY("%ld, 0x%"PRIx64", %ld, %p", timeout, watchdog_code,
> data_size, watchdog_data);
> - return efi_unsupported(__func__);
> + return EFI_EXIT(efi_set_watchdog(timeout));
> }
>
> /*
> diff --git a/lib/efi_loader/efi_watchdog.c b/lib/efi_loader/efi_watchdog.c
> new file mode 100644
> index 00..50e95290ea
> --- /dev/null
> +++ b/lib/efi_loader/efi_watchdog.c
> @@ -0,0 +1,59 @@
> +/*
> + * EFI device path interface
Not quite I guess?
> + *
> + * Copyright (c) 2017 Heinrich Schuchardt
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#include
> +#include
> +
> +static struct efi_event *watchdog_timer_event;
> +
> +static void EFIAPI efi_watchdog_timer_notify(struct efi_event *event,
> + void *context)
> +{
> + EFI_ENTRY("%p, %p", event, context);
> +
> + printf("\nEFI: Watchdog timeout\n");
> + EFI_CALL_VOID(efi_runtime_services.reset_system(EFI_RESET_COLD,
> + EFI_SUCCESS, 0, NULL));
> +
> + EFI_EXIT(EFI_UNSUPPORTED);
> +}
> +
> +efi_status_t efi_set_watchdog(unsigned long timeout)
> +{
> + efi_status_t r;
> +
> + if (timeout)
> + /* Reset watchdog */
> + r = efi_set_timer(watchdog_timer_event, EFI_TIMER_RELATIVE,
Re: [U-Boot] [PATCH 1/1] rockchip: provide installation instruction for Firefly-RK3399.
On 27 September 2017 at 21:35, Heinrich Schuchardt wrote: > Unfortunately installing U-Boot on an SD card for the Firefly-RK3399 > is not trivial. > > I could not get U-Boot running with SPL. So I ended up using the > Rockchip miniloader. > > Adding a README hopefully will give other users an easier start. > > Signed-off-by: Heinrich Schuchardt > --- > board/rockchip/firefly_rk3399/README | 55 > > 1 file changed, 55 insertions(+) > create mode 100644 board/rockchip/firefly_rk3399/README Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 02/17] efi_loader: parameters of CopyMem and SetMem
On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > The UEFI spec defines the length parameters of CopyMem and SetMem > as UINTN. We should size_t here. > > The source buffer of CopyMem should be marked as const. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_api.h | 7 +++ > lib/efi_loader/efi_boottime.c | 10 +- > 2 files changed, 8 insertions(+), 9 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 10/10] efi_selftest: check notification of ExitBootServices
Hi Heinrich, On 25 September 2017 at 00:01, Heinrich Schuchardt wrote: > > On 09/25/2017 04:12 AM, Simon Glass wrote: > > Hi Heinrich, > > > > On 15 September 2017 at 02:06, Heinrich Schuchardt > > wrote: > >> Check that the notification function of an > >> EVT_SIGNAL_EXIT_BOOT_SERVICES event is called > >> exactly once. > >> > >> Signed-off-by: Heinrich Schuchardt > >> --- > >> lib/efi_selftest/Makefile| 3 + > >> lib/efi_selftest/efi_selftest_exitbootservices.c | 106 > >> +++ > >> 2 files changed, 109 insertions(+) > >> create mode 100644 lib/efi_selftest/efi_selftest_exitbootservices.c > >> > >> diff --git a/lib/efi_selftest/Makefile b/lib/efi_selftest/Makefile > >> index ddf304e1fa..30f1960933 100644 > >> --- a/lib/efi_selftest/Makefile > >> +++ b/lib/efi_selftest/Makefile > >> @@ -13,6 +13,8 @@ CFLAGS_efi_selftest_console.o := $(CFLAGS_EFI) > >> CFLAGS_REMOVE_efi_selftest_console.o := $(CFLAGS_NON_EFI) > >> CFLAGS_efi_selftest_events.o := $(CFLAGS_EFI) > >> CFLAGS_REMOVE_efi_selftest_events.o := $(CFLAGS_NON_EFI) > >> +CFLAGS_efi_selftest_exitbootservices.o := $(CFLAGS_EFI) > >> +CFLAGS_REMOVE_efi_selftest_exitbootservices.o := $(CFLAGS_NON_EFI) > >> CFLAGS_efi_selftest_tpl.o := $(CFLAGS_EFI) > >> CFLAGS_REMOVE_efi_selftest_tpl.o := $(CFLAGS_NON_EFI) > >> > >> @@ -20,4 +22,5 @@ obj-$(CONFIG_CMD_BOOTEFI_SELFTEST) += \ > >> efi_selftest.o \ > >> efi_selftest_console.o \ > >> efi_selftest_events.o \ > >> +efi_selftest_exitbootservices.o \ > >> efi_selftest_tpl.o > >> diff --git a/lib/efi_selftest/efi_selftest_exitbootservices.c > >> b/lib/efi_selftest/efi_selftest_exitbootservices.c > >> new file mode 100644 > >> index 00..60271e6180 > >> --- /dev/null > >> +++ b/lib/efi_selftest/efi_selftest_exitbootservices.c > >> @@ -0,0 +1,106 @@ > >> +/* > >> + * efi_selftest_events > >> + * > >> + * Copyright (c) 2017 Heinrich Schuchardt > >> + * > >> + * SPDX-License-Identifier: GPL-2.0+ > >> + * > >> + * This unit test checks that the notification function of an > >> + * EVT_SIGNAL_EXIT_BOOT_SERVICES event is called exactly once. > >> + */ > >> + > >> +#include > >> + > >> +static struct efi_boot_services *boottime; > >> +static struct efi_event *event_notify; > >> +static unsigned int counter; > > > > I wonder if the solution to the context thin in the notify() function > > is to put all of these in a struct? > > This would mean replacing > boottime->something > by > config->boottime->something. > > This does not make the code easier to read. I don't understand that comment. In general only the outermost function accesses the global, then passes what is needed to the inner functions. So in practice you seldom see config->boottime->something. You might define a local variable boottime as config->boottime, perhaps. But I agree that two levels of access would be bad. > > > > > It is nice to group globals into a struct to allow future one-to-many > > conversion, reduce the number of symbols in the map and provide a > > logical grouping. So this would kill two birds with one stone. > > I typically do not read map files. > > With your suggestion the code will be slower and the binary will be larger. Actually it is often faster and smaller. E.g. on ARM every global access requires a literal pool entry and access. You can compare the compiler output and see what you find. > > How would putting all private variables into a structure provide logical > grouping? A structure is a way of grouping. > > > > > Another idea is to have setup() return the context (e.g. as a void ** > > final arg). Then that same context can be passed to execute and > > teardown. This is similar to how the unit tests work in U-Boot. > > Passing structures as void* is error prone. > > Private variables should stay private. There is no reason to make these > accessible outside the unit test. That was not my suggestion. > > Passing a void *this would make sense if we would envision having > multiple instances of the same unit test. I can't see that. Well you have set up a test framework of sorts, but it does not use the existing unit test code in U-Boot. That framework uses a test struct which is passed to all functions. It works quite well. > > > > > Other than that, see my comments to the previous patch which also apply > > here. > > @Alex > You already accepted the patch series to efi-next and afterwards merged > a bunch of other patches. > > I could not see any comment by Simon concerning functionality. > Everything seemed to focus on style. > > Shall I provide add-on patches covering Simon's comments or should I > create a new version of the patch series. If you think there is value in these changes then I suggest doing a follow-on patch. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 06/17] efi_loader: correct bits of receive_filters bit mask
On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > Remove extraneous commas. > Add comment. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_api.h | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] efi_selftest: use efi_st_error for all error messages
On 4 October 2017 at 04:37, Heinrich Schuchardt wrote: > All error messages in the selftests should use efi_st_error. > efi_st_error will print the file name and line number of the error. > > Splitting message texts due to lines being over 80 > characters is avoided. This resolves the issue reported > by Simon Glass in > https://lists.denx.de/pipermail/u-boot/2017-September/307387.html > > Reported-by: Simon Glass > Fixes: 623b3a579765 efi_selftest: provide an EFI selftest application > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest.c | 22 ++ > 1 file changed, 10 insertions(+), 12 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/1] efi_selftest: make tests easier to read
Hi Heinrich, On 4 October 2017 at 07:31, Heinrich Schuchardt wrote: > Rename counter to more illustrative names. > Update notification function description. > Simplify notification function. > Add comment for arbitrary non-zero value. > Document @return. > Use constants for return values of setup, execute, teardown. > > Reported-by: Simon Glass > Signed-off-by: Heinrich Schuchardt > --- > v2: > Remove superfluous blank in a message text. > --- > include/efi_selftest.h | 3 + > lib/efi_selftest/efi_selftest.c | 15 +++-- > lib/efi_selftest/efi_selftest_events.c | 80 -- > lib/efi_selftest/efi_selftest_exitbootservices.c | 46 +++-- > lib/efi_selftest/efi_selftest_tpl.c | 85 > +--- > 5 files changed, 129 insertions(+), 100 deletions(-) Reviewed-by: Simon Glass But I am not that keen on returning SUCCESS instead of 0. I think 0 is well understood and easier on the eye. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices
On Sun, Oct 08, 2017 at 11:33:08AM -0400, Rob Clark wrote: > This fixes an issue with OpenBSD's bootloader, and I think should also > fix a similar issue with grub2 on legacy devices. In the legacy case > we were creating disk objects for the partitions, but not also the > parent device. > > Reported-by: Jonathan Gray > Signed-off-by: Rob Clark Thanks for looking into this. While this lets armv7/bootarm.efi boot again on cubox-i and bbb it doesn't help rpi3. What is the easiest way to get U-Boot to display these paths to be able to compare the current behaviour to 2017.09? U-Boot 2017.11-rc1-00112-g936028a089 (Oct 09 2017 - 13:39:34 +1100) DRAM: 948 MiB RPI 3 Model B (0xa02082) MMC: sdhci@7e30: 0 reading uboot.env In:serial Out: vidconsole Err: vidconsole Net: No ethernet found. starting USB... USB0: Core Release: 2.80a scanning bus 0 for devices... 4 USB Device(s) found scanning usb for storage devices... 1 Storage Device(s) found Hit any key to stop autoboot: 0 U-Boot> printenv boot_targets boot_targets=usb0 mmc0 pxe dhcp U-Boot> boot Device 0: Vendor: SanDisk Rev: 1.00 Prod: Ultra Type: Removable Hard Disk Capacity: 29327.3 MB = 28.6 GB (60062500 x 512) ... is now current device Scanning usb 0:1... Found EFI removable media binary efi/boot/bootaa64.efi reading efi/boot/bootaa64.efi 78287 bytes read in 86 ms (888.7 KiB/s) ## Starting EFI application at 0100 ... Scanning disk sd...@7e30.blk... Scanning disk usb_mass_storage.lun0... Found 2 disks >> OpenBSD/arm64 BOOTAA64 0.8 boot> cannot open sd0a:/etc/random.seed: Device not configured booting sd0a:/bsd: open sd0a:/bsd: Device not configured failed(6). will try /bsd boot> ls sd0a:/ stat(sd0a:/): Device not configured boot> ls sd1a:/ stat(sd1a:/): Device not configured boot> ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case
On Sun, Oct 08, 2017 at 10:56:26PM -0300, Fabio Estevam wrote: > On Sun, Oct 8, 2017 at 11:04 AM, Jonathan Gray wrote: > > > It turns out to be > > > > commit 2460098cffacd18729262e3ed36656e6943783ed > > Author: Tom Rini > > Date: Fri Sep 22 07:37:43 2017 -0400 > > > > fs/fat: Reduce stack usage > > > > We have limited stack in SPL builds. Drop itrblock and move to > > malloc/free of itr to move this off of the stack. As part of this fix a > > double-free issue in fat_size(). > > > > Signed-off-by: Tom Rini > > --- > > Rework to use malloc/free as moving this to a global overflows some SH > > targets. > > > > fs/fat/fat.c | 14 ++ > > 1 file changed, 10 insertions(+), 4 deletions(-) > > > > With that reverted I just get the efi loader problem, no alignment errors. > > Thanks for doing the bisect. > > Tom, can you prepare a fix for this? No, this is a required fix for other platforms. Why is this failing in the particular case that it's failing in? -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case
On Sun, Oct 8, 2017 at 11:04 AM, Jonathan Gray wrote: > It turns out to be > > commit 2460098cffacd18729262e3ed36656e6943783ed > Author: Tom Rini > Date: Fri Sep 22 07:37:43 2017 -0400 > > fs/fat: Reduce stack usage > > We have limited stack in SPL builds. Drop itrblock and move to > malloc/free of itr to move this off of the stack. As part of this fix a > double-free issue in fat_size(). > > Signed-off-by: Tom Rini > --- > Rework to use malloc/free as moving this to a global overflows some SH > targets. > > fs/fat/fat.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > With that reverted I just get the efi loader problem, no alignment errors. Thanks for doing the bisect. Tom, can you prepare a fix for this? ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case
On Sat, Oct 7, 2017 at 1:23 PM, Rob Clark wrote:
> On Fri, Oct 6, 2017 at 10:08 PM, Jonathan Gray wrote:
>> On Fri, Oct 06, 2017 at 08:21:26AM -0400, Rob Clark wrote:
>>> On Fri, Oct 6, 2017 at 12:35 AM, Jonathan Gray wrote:
>>> > On Thu, Oct 05, 2017 at 05:05:49AM -0400, Rob Clark wrote:
>>> >> On Thu, Oct 5, 2017 at 12:36 AM, Jonathan Gray wrote:
>>> >> > On Wed, Oct 04, 2017 at 01:12:48PM -0400, Rob Clark wrote:
>>> >> >> On Wed, Oct 4, 2017 at 12:29 PM, Fabio Estevam
>>> >> >> wrote:
>>> >> >> > Since commit ff98cb90514d ("part: extract MBR signature from
>>> >> >> > partitions")
>>> >> >> > SPL boot on i.MX6 starts to fail:
>>> >> >> >
>>> >> >> > U-Boot SPL 2017.09-00221-g0d6ab32 (Oct 02 2017 - 15:13:19)
>>> >> >> > Trying to boot from MMC1
>>> >> >> > (keep in loop)
>>> >> >> >
>>> >> >> > Use the original allocation scheme for the SPL case, so that MX6
>>> >> >> > boards
>>> >> >> > can boot again.
>>> >> >> >
>>> >> >> > This is a temporary solution to avoid the boot regression.
>>> >> >> >
>>> >> >> > Signed-off-by: Fabio Estevam
>>> >> >> > ---
>>> >> >> > Hi Tom,
>>> >> >> >
>>> >> >> > I do not have time this week to further investigate and narrow down
>>> >> >> > this problem.
>>> >> >> >
>>> >> >> > Using the old allocation scheme fixes the mx6 SPL boot problem.
>>> >> >> >
>>> >> >>
>>> >> >> Hi Tom, if you are ok with this as a temporary fix, then this is:
>>> >> >>
>>> >> >> Acked-by: Rob Clark
>>> >> >>
>>> >> >> I'm getting some help from some of the fedora-arm folks so hopefully I
>>> >> >> can get some idea what is going wrong, but I'd like to unblock folks
>>> >> >> w/ mx6 boards..
>>> >> >>
>>> >> >> BR,
>>> >> >> -R
>>> >> >
>>> >> > This does not seem to be a complete fix, cubox is still broken when
>>> >> > U-Boot proper loads, unless the efi loader commits are to blame
>>> >> > for introducing unaligned accesses.
>>> >> >
>>> >> > Works with 2017.09.
>>> >> >
>>> >> > U-Boot SPL 2017.11-rc1-00026-g14b55fc833 (Oct 05 2017 - 15:17:47)
>>> >> > Trying to boot from MMC1
>>> >> >
>>> >> >
>>> >> > U-Boot 2017.11-rc1-00026-g14b55fc833 (Oct 05 2017 - 15:17:47 +1100)
>>> >> >
>>> >> > CPU: Freescale i.MX6Q rev1.5 996 MHz (running at 792 MHz)
>>> >> > CPU: Extended Commercial temperature grade (-20C to 105C) at 34C
>>> >> > Reset cause: WDOG
>>> >> > Board: MX6 Cubox-i
>>> >> > DRAM: 2 GiB
>>> >> > MMC: FSL_SDHC: 0
>>> >> > *** Warning - bad CRC, using default environment
>>> >> >
>>> >> > No panel detected: default to HDMI
>>> >> > Display: HDMI (1024x768)
>>> >> > In:serial
>>> >> > Out: serial
>>> >> > Err: serial
>>> >> > Net: FEC
>>> >> > Hit any key to stop autoboot: 0
>>> >> > switch to partitions #0, OK
>>> >> > mmc0 is current device
>>> >> > Scanning mmc 0:1...
>>> >>
>>> >> I don't think any efi_loader code is running here, you would see a
>>> >> message like:
>>> >>
>>> >> ## Starting EFI application at XYZ
>>> >>
>>> >> But to be sure you can disable CONFIG_EFI_LOADER in menuconfig to
>>> >> confirm.
>>> >>
>>> >> I guess this is some unrelated change. I suspect Tom's change to
>>> >> malloc the fat_itr's which would make the buffers used for
>>> >> fs_exists()/etc not cache aligned. I thought there was a patch
>>> >> floating around to change that to memalign().
>>> >
>>> > The imx6 problems still occur with CONFIG_EFI_LOADER disabled indeed.
>>> >
>>> > I can no longer load a kernel via efi on bbb though:
>>> >
>>> > U-Boot SPL 2017.11-rc1-00066-g4ac7de9239 (Oct 06 2017 - 14:21:51)
>>> > Trying to boot from MMC1
>>> > reading u-boot.img
>>> > reading u-boot.img
>>> >
>>> >
>>> > U-Boot 2017.11-rc1-00066-g4ac7de9239 (Oct 06 2017 - 14:21:51 +1100)
>>> >
>>> > CPU : AM335X-GP rev 2.1
>>> > I2C: ready
>>> > DRAM: 512 MiB
>>> > No match for driver 'omap_hsmmc'
>>> > No match for driver 'omap_hsmmc'
>>> > Some drivers were not found
>>> > MMC: OMAP SD/MMC: 0, OMAP SD/MMC: 1
>>> > not set. Validating first E-fuse MAC
>>> > Net: cpsw, usb_ether
>>> > Press SPACE to abort autoboot in 2 seconds
>>> > switch to partitions #0, OK
>>> > mmc0 is current device
>>> > SD/MMC found on device 0
>>> > ** Unable to read file boot.scr **
>>> > ** Unable to read file uEnv.txt **
>>> > switch to partitions #0, OK
>>> > mmc0 is current device
>>> > Scanning mmc 0:1...
>>> > reading /am335x-boneblack.dtb
>>> > 35712 bytes read in 10 ms (3.4 MiB/s)
>>> > Found EFI removable media binary efi/boot/bootarm.efi
>>> > reading efi/boot/bootarm.efi
>>> > 65448 bytes read in 16 ms (3.9 MiB/s)
>>> > ## Starting EFI application at 8200 ...
>>> > Scanning disks on usb...
>>> > Scanning disks on mmc...
>>> > MMC Device 2 not found
>>> > MMC Device 3 not found
>>> > Found 6 disks
>>> >>> OpenBSD/armv7 BOOTARM 0.9
>>> > boot>
>>> > cannot open sd0a:/etc/random.seed: Device not configured
>>> > booting sd0a:/bsd: open sd0a:/bsd: Device not configured
>>> > failed(6). will try /bsd
>>> > boot>
>>> > cannot open sd0a:/etc/random.seed: Device not configured
>>> > booti
[U-Boot] efi_loader: enough-uefi-for-shell: [PATCH 06/11] efi_loader: implement SetWatchdogTimer
On 10/08/2017 06:57 AM, Heinrich Schuchardt wrote:
> The watchdog is initialized with a 5 minute timeout period.
> It can be reset by SetWatchdogTimer.
> It is stopped by ExitBoottimeServices.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> cmd/bootefi.c | 1 +
> include/efi_loader.h | 4 +++
> lib/efi_loader/Makefile | 2 +-
> lib/efi_loader/efi_boottime.c | 15 ++-
> lib/efi_loader/efi_watchdog.c | 59
> +++
> 5 files changed, 67 insertions(+), 14 deletions(-)
> create mode 100644 lib/efi_loader/efi_watchdog.c
>
> diff --git a/cmd/bootefi.c b/cmd/bootefi.c
> index b7087e3da8..24958ada46 100644
> --- a/cmd/bootefi.c
> +++ b/cmd/bootefi.c
> @@ -43,6 +43,7 @@ static void efi_init_obj_list(void)
> #ifdef CONFIG_GENERATE_SMBIOS_TABLE
> efi_smbios_register();
> #endif
> + efi_watchdog_register();
>
> /* Initialize EFI runtime services */
> efi_reset_system_init();
> diff --git a/include/efi_loader.h b/include/efi_loader.h
> index e1179b7dcd..223d8d8222 100644
> --- a/include/efi_loader.h
> +++ b/include/efi_loader.h
> @@ -163,6 +163,8 @@ int efi_disk_register(void);
> int efi_gop_register(void);
> /* Called by bootefi to make the network interface available */
> int efi_net_register(void);
> +/* Called by bootefi to make the watchdog available */
> +int efi_watchdog_register(void);
> /* Called by bootefi to make SMBIOS tables available */
> void efi_smbios_register(void);
>
> @@ -171,6 +173,8 @@ efi_fs_from_path(struct efi_device_path *fp);
>
> /* Called by networking code to memorize the dhcp ack package */
> void efi_net_set_dhcp_ack(void *pkt, int len);
> +/* Called by efi_set_watchdog_timer to reset the timer */
> +efi_status_t efi_set_watchdog(unsigned long timeout);
>
> /* Called from places to check whether a timer expired */
> void efi_timer_check(void);
> diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile
> index ddb978f650..83d879b686 100644
> --- a/lib/efi_loader/Makefile
> +++ b/lib/efi_loader/Makefile
> @@ -17,7 +17,7 @@ endif
> obj-$(CONFIG_CMD_BOOTEFI_HELLO) += helloworld_efi.o
> obj-y += efi_image_loader.o efi_boottime.o efi_runtime.o efi_console.o
> obj-y += efi_memory.o efi_device_path_to_text.o efi_device_path.o
> -obj-y += efi_file.o efi_variable.o efi_bootmgr.o
> +obj-y += efi_file.o efi_variable.o efi_bootmgr.o efi_watchdog.o
> obj-$(CONFIG_LCD) += efi_gop.o
> obj-$(CONFIG_DM_VIDEO) += efi_gop.o
> obj-$(CONFIG_PARTITIONS) += efi_disk.o
> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
> index 30577f717e..81e7d818fc 100644
> --- a/lib/efi_loader/efi_boottime.c
> +++ b/lib/efi_loader/efi_boottime.c
> @@ -155,18 +155,6 @@ void efi_signal_event(struct efi_event *event)
> event->is_queued = false;
> }
>
> -/*
> - * Write a debug message for an EPI API service that is not implemented yet.
> - *
> - * @funcname function that is not yet implemented
> - * @return EFI_UNSUPPORTED
> - */
> -static efi_status_t efi_unsupported(const char *funcname)
> -{
> - debug("EFI: App called into unimplemented function %s\n", funcname);
> - return EFI_EXIT(EFI_UNSUPPORTED);
> -}
> -
> /*
> * Raise the task priority level.
> *
> @@ -1454,6 +1442,7 @@ static efi_status_t EFIAPI efi_exit_boot_services(void
> *image_handle,
> bootm_disable_interrupts();
>
> /* Give the payload some time to boot */
> + efi_set_watchdog(0);
> WATCHDOG_RESET();
>
> return EFI_EXIT(EFI_SUCCESS);
> @@ -1514,7 +1503,7 @@ static efi_status_t EFIAPI
> efi_set_watchdog_timer(unsigned long timeout,
> {
> EFI_ENTRY("%ld, 0x%"PRIx64", %ld, %p", timeout, watchdog_code,
> data_size, watchdog_data);
> - return efi_unsupported(__func__);
> + return EFI_EXIT(efi_set_watchdog(timeout));
> }
>
> /*
> diff --git a/lib/efi_loader/efi_watchdog.c b/lib/efi_loader/efi_watchdog.c
> new file mode 100644
> index 00..50e95290ea
> --- /dev/null
> +++ b/lib/efi_loader/efi_watchdog.c
> @@ -0,0 +1,59 @@
> +/*
> + * EFI device path interface
> + *
> + * Copyright (c) 2017 Heinrich Schuchardt
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#include
> +#include
> +
> +static struct efi_event *watchdog_timer_event;
> +
> +static void EFIAPI efi_watchdog_timer_notify(struct efi_event *event,
> + void *context)
> +{
> + EFI_ENTRY("%p, %p", event, context);
> +
> + printf("\nEFI: Watchdog timeout\n");
> + EFI_CALL_VOID(efi_runtime_services.reset_system(EFI_RESET_COLD,
> + EFI_SUCCESS, 0, NULL));
Hello Rob,
referring to:
https://github.com/robclark/u-boot/commits/enough-uefi-for-shell
The patch that you have in your series has to be updated. I had to
change the line above to make the watchdog work.
If your series goes in first I could also create a follow up patch.
Regards
[U-Boot] [PATCH] ARM: tegra: Remove unused define CONFIG_ARMCORTEXA9
This macro isn't used by anything, and in fact hasn't ever been used according to the Git logs. Signed-off-by: Tuomas Tynkkynen --- include/configs/tegra-common.h | 1 - scripts/config_whitelist.txt | 1 - 2 files changed, 2 deletions(-) diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h index e2225cd812..430c9a7623 100644 --- a/include/configs/tegra-common.h +++ b/include/configs/tegra-common.h @@ -13,7 +13,6 @@ /* * High Level Configuration Options */ -#define CONFIG_ARMCORTEXA9 /* This is an ARM V7 CPU core */ #define CONFIG_SYS_L2CACHE_OFF /* No L2 cache */ #include /* get chip and board defs */ diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index 78bcf06878..32afd3921e 100644 --- a/scripts/config_whitelist.txt +++ b/scripts/config_whitelist.txt @@ -73,7 +73,6 @@ CONFIG_ARMADA100 CONFIG_ARMADA100_FEC CONFIG_ARMADA168 CONFIG_ARMADA_39X -CONFIG_ARMCORTEXA9 CONFIG_ARMV7_PSCI_1_0 CONFIG_ARMV7_SECURE_BASE CONFIG_ARMV7_SECURE_MAX_SIZE -- 2.14.2 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 2/2] configs: Re-sync CONFIG_CMD_IMLS with moveconfig
The option is specified in Kconfig, but still a few config header files are overriding the choice by #undef'ing it. Re-sync the option with moveconfig to rid of the #undefs. Signed-off-by: Tuomas Tynkkynen --- configs/ls1012afrdm_qspi_defconfig | 1 - configs/ls1012aqds_qspi_defconfig | 1 - configs/ls1012ardb_qspi_defconfig | 1 - configs/ls1021aiot_qspi_defconfig | 1 - configs/ls1021aiot_sdcard_defconfig | 1 - configs/ls1088aqds_qspi_defconfig | 1 - configs/ls1088ardb_qspi_defconfig | 1 - configs/ls2080aqds_nand_defconfig | 1 - configs/ls2080aqds_qspi_defconfig | 1 - configs/ls2080aqds_sdcard_defconfig | 1 - configs/mx7ulp_evk_defconfig| 1 - configs/mx7ulp_evk_plugin_defconfig | 1 - configs/s32v234evb_defconfig| 1 - configs/zc5202_defconfig| 1 - configs/zc5601_defconfig| 1 - include/configs/el6x_common.h | 3 --- include/configs/ls1012a_common.h| 3 --- include/configs/ls1021aiot.h| 4 include/configs/ls1088aqds.h| 1 - include/configs/ls1088ardb.h| 1 - include/configs/ls2080aqds.h| 1 - include/configs/mx7ulp_evk.h| 1 - include/configs/s32v234evb.h| 2 -- 23 files changed, 31 deletions(-) diff --git a/configs/ls1012afrdm_qspi_defconfig b/configs/ls1012afrdm_qspi_defconfig index 44161613a4..fe95f048be 100644 --- a/configs/ls1012afrdm_qspi_defconfig +++ b/configs/ls1012afrdm_qspi_defconfig @@ -14,7 +14,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 root=/dev/ram0 earlycon=uart8250,mmio,0x21c0500 quiet lpj=25" # CONFIG_DISPLAY_BOARDINFO is not set CONFIG_HUSH_PARSER=y -CONFIG_CMD_IMLS=y CONFIG_CMD_GREPENV=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y diff --git a/configs/ls1012aqds_qspi_defconfig b/configs/ls1012aqds_qspi_defconfig index 57df881275..4073db6583 100644 --- a/configs/ls1012aqds_qspi_defconfig +++ b/configs/ls1012aqds_qspi_defconfig @@ -14,7 +14,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 root=/dev/ram0 earlycon=uart8250,mmio,0x21c0500 quiet lpj=25" # CONFIG_DISPLAY_BOARDINFO is not set CONFIG_HUSH_PARSER=y -CONFIG_CMD_IMLS=y CONFIG_CMD_GREPENV=y CONFIG_CMD_EEPROM=y CONFIG_CMD_GPT=y diff --git a/configs/ls1012ardb_qspi_defconfig b/configs/ls1012ardb_qspi_defconfig index acdad5bc24..81702e374d 100644 --- a/configs/ls1012ardb_qspi_defconfig +++ b/configs/ls1012ardb_qspi_defconfig @@ -14,7 +14,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 root=/dev/ram0 earlycon=uart8250,mmio,0x21c0500 quiet lpj=25" # CONFIG_DISPLAY_BOARDINFO is not set CONFIG_HUSH_PARSER=y -CONFIG_CMD_IMLS=y CONFIG_CMD_GREPENV=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y diff --git a/configs/ls1021aiot_qspi_defconfig b/configs/ls1021aiot_qspi_defconfig index 39b9766959..04d36581c8 100644 --- a/configs/ls1021aiot_qspi_defconfig +++ b/configs/ls1021aiot_qspi_defconfig @@ -3,7 +3,6 @@ CONFIG_TARGET_LS1021AIOT=y CONFIG_DEFAULT_DEVICE_TREE="ls1021a-iot-duart" CONFIG_SYS_EXTRA_OPTIONS="QSPI_BOOT" CONFIG_BOARD_EARLY_INIT_F=y -CONFIG_CMD_IMLS=y CONFIG_CMD_GPT=y CONFIG_CMD_EXT2=y CONFIG_CMD_FAT=y diff --git a/configs/ls1021aiot_sdcard_defconfig b/configs/ls1021aiot_sdcard_defconfig index 029cde1a2e..0b8014683f 100644 --- a/configs/ls1021aiot_sdcard_defconfig +++ b/configs/ls1021aiot_sdcard_defconfig @@ -6,7 +6,6 @@ CONFIG_BOARD_EARLY_INIT_F=y CONFIG_SPL=y CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0xe8 -CONFIG_CMD_IMLS=y CONFIG_CMD_GPT=y CONFIG_CMD_EXT2=y CONFIG_CMD_FAT=y diff --git a/configs/ls1088aqds_qspi_defconfig b/configs/ls1088aqds_qspi_defconfig index 37f5dff7fc..6a542ed5f8 100644 --- a/configs/ls1088aqds_qspi_defconfig +++ b/configs/ls1088aqds_qspi_defconfig @@ -9,7 +9,6 @@ CONFIG_OF_STDOUT_VIA_ALIAS=y CONFIG_SYS_EXTRA_OPTIONS="SYS_FSL_DDR4, QSPI_BOOT" # CONFIG_DISPLAY_BOARDINFO is not set CONFIG_HUSH_PARSER=y -CONFIG_CMD_IMLS=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y CONFIG_CMD_SF=y diff --git a/configs/ls1088ardb_qspi_defconfig b/configs/ls1088ardb_qspi_defconfig index cf073f6cc1..52b10af96a 100644 --- a/configs/ls1088ardb_qspi_defconfig +++ b/configs/ls1088ardb_qspi_defconfig @@ -9,7 +9,6 @@ CONFIG_OF_STDOUT_VIA_ALIAS=y CONFIG_SYS_EXTRA_OPTIONS="SYS_FSL_DDR4, QSPI_BOOT" # CONFIG_DISPLAY_BOARDINFO is not set CONFIG_HUSH_PARSER=y -CONFIG_CMD_IMLS=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y CONFIG_CMD_SF=y diff --git a/configs/ls2080aqds_nand_defconfig b/configs/ls2080aqds_nand_defconfig index 4ba5b79c3d..e6f1e533c2 100644 --- a/configs/ls2080aqds_nand_defconfig +++ b/configs/ls2080aqds_nand_defconfig @@ -18,7 +18,6 @@ CONFIG_SPL=y CONFIG_SPL_ENV_SUPPORT=y CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT=y -CONFIG_CMD_IMLS=y CONFIG_CMD_GREPENV=y CONFIG_CMD_EEPROM=y CONFIG_CMD_GPT=y diff --git a/configs/ls2080aqds_qspi_defconfig b/configs/ls2080aqds_qspi_defconfig index 6519cdb16f..79307f8359 100644 --- a/configs/ls2080aqds_qspi_defconfig +++ b/co
Re: [U-Boot] [PATCH] usb: xhci: Add Renesas R-Car xHCI driver
On Sun, Oct 08, 2017 at 08:34:46PM +0200, Marek Vasut wrote: > Add firmware V3, firmware loader and XHCI glue for the Renesas R-Car > Gen3 SoCs XHCI controller. Thus far only the R-Car Gen3 R8A7795 ES2.0+ > and R8A7796 are supported. > > Signed-off-by: Marek Vasut > Cc: Nobuhiro Iwamatsu Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] usb: xhci: Add Renesas R-Car xHCI driver
Add firmware V3, firmware loader and XHCI glue for the Renesas R-Car Gen3 SoCs XHCI controller. Thus far only the R-Car Gen3 R8A7795 ES2.0+ and R8A7796 are supported. Signed-off-by: Marek Vasut Cc: Nobuhiro Iwamatsu --- Licenses/r8a779x_usb3.txt| 26 ++ drivers/usb/host/Kconfig | 8 + drivers/usb/host/Makefile| 1 + drivers/usb/host/xhci-rcar-r8a779x_usb3_v3.h | 643 +++ drivers/usb/host/xhci-rcar.c | 161 +++ 5 files changed, 839 insertions(+) create mode 100644 Licenses/r8a779x_usb3.txt create mode 100644 drivers/usb/host/xhci-rcar-r8a779x_usb3_v3.h create mode 100644 drivers/usb/host/xhci-rcar.c diff --git a/Licenses/r8a779x_usb3.txt b/Licenses/r8a779x_usb3.txt new file mode 100644 index 00..e2afcc9e81 --- /dev/null +++ b/Licenses/r8a779x_usb3.txt @@ -0,0 +1,26 @@ +Copyright (c) 2014, Renesas Electronics Corporation +All rights reserved. + +Redistribution and use in binary form, without modification, are permitted +provided that the following conditions are met: + +1. Redistribution in binary form must reproduce the above copyright notice, + this list of conditions and the following disclaimer in the documentation + and/or other materials provided with the distribution. +2. The name of Renesas Electronics Corporation may not be used to endorse or + promote products derived from this software without specific prior written + permission. +3. Reverse engineering, decompilation, or disassembly of this software is + not permitted. + +THIS SOFTWARE IS PROVIDED "AS IS" AND RENESAS ELECTRONICS CORPORATION DISCLAIMS +ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE, AND +NONINFRINGEMENT OF THIRD PARTY RIGHTS. IN NO EVENT SHALL RENESAS ELECTRONICS +CORPORATION BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, +OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF +SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS +INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN +CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) +ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +POSSIBILITY OF SUCH DAMAGE. diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index f5f19ed775..cad9af6977 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -47,6 +47,14 @@ config USB_XHCI_ROCKCHIP help Enables support for the on-chip xHCI controller on Rockchip SoCs. +config USB_XHCI_RCAR + bool "Renesas RCar USB 3.0 support" + default y + depends on ARCH_RMOBILE + help + Choose this option to add support for USB 3.0 driver on Renesas + RCar Gen3 SoCs. + config USB_XHCI_STI bool "Support for STMicroelectronics STiH407 family on-chip xHCI USB controller" depends on ARCH_STI diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile index 83903fcf99..79df888fce 100644 --- a/drivers/usb/host/Makefile +++ b/drivers/usb/host/Makefile @@ -59,6 +59,7 @@ obj-$(CONFIG_USB_XHCI_FSL) += xhci-fsl.o obj-$(CONFIG_USB_XHCI_MVEBU) += xhci-mvebu.o obj-$(CONFIG_USB_XHCI_OMAP) += xhci-omap.o obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o +obj-$(CONFIG_USB_XHCI_RCAR) += xhci-rcar.o obj-$(CONFIG_USB_XHCI_STI) += dwc3-sti-glue.o # designware diff --git a/drivers/usb/host/xhci-rcar-r8a779x_usb3_v3.h b/drivers/usb/host/xhci-rcar-r8a779x_usb3_v3.h new file mode 100644 index 00..f0f48a3354 --- /dev/null +++ b/drivers/usb/host/xhci-rcar-r8a779x_usb3_v3.h @@ -0,0 +1,643 @@ +/* + * Renesas RCar xHCI controller firmware version 3 + * + * Copyright (c) 2014, Renesas Electronics Corporation + * All rights reserved. + * + * Redistribution and use in binary form, without modification, are permitted + * provided that the following conditions are met: + * + * 1. Redistribution in binary form must reproduce the above copyright notice, + *this list of conditions and the following disclaimer in the documentation + *and/or other materials provided with the distribution. + * 2. The name of Renesas Electronics Corporation may not be used to endorse or + *promote products derived from this software without specific prior written + *permission. + * 3. Reverse engineering, decompilation, or disassembly of this software is + *not permitted. + * + * THIS SOFTWARE IS PROVIDED "AS IS" AND RENESAS ELECTRONICS CORPORATION DISCLAIMS + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE, AND + * NONINFRINGEMENT OF THIRD PARTY RIGHTS. IN NO EVENT SHALL RENESAS ELECTRONICS + * CORPORATION BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, + * OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NO
Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states
On Sun, Oct 8, 2017 at 12:41 PM, Alexander Graf wrote: > > >> Am 08.10.2017 um 17:54 schrieb Rob Clark : >> >>> On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt >>> wrote: >>> Patch efi_loader: add stub HII protocols uses UINTN heavily. In a recent >>> comment Simon remarked that types should not be uppercase. So I was >>> planning to replace all occurences of UINTN by size_t in an upcoming patch. >> >> btw, how would you feed about: >> >> typedef size_t efi_uintn_t; >> >> instead of using size_t directly? UINTN is used in a bunch of places >> where size_t, although it might be the right size, does not feel >> appropriate.. > > I like the idea :) > btw, 2nd benefit that I didn't immediately think of.. but if I'm comparing UEFI spec and edk2 headers, if I see size_t in u-boot's headers but UINTN in UEFI spec / edk2, then I have to stop and think and remember how UINTN is defined in the spec. If I see efi_uintn_t, I don't ;-) I'll convert the efi_loader patches for Shell.efi to efi_uintn_t/efi_intn_t.. we can handle the rest of conversion and removal of UINTN as a follow-on patch, imho. BR, -R ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states
> Am 08.10.2017 um 17:54 schrieb Rob Clark : > >> On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt >> wrote: >> Patch efi_loader: add stub HII protocols uses UINTN heavily. In a recent >> comment Simon remarked that types should not be uppercase. So I was >> planning to replace all occurences of UINTN by size_t in an upcoming patch. > > btw, how would you feed about: > > typedef size_t efi_uintn_t; > > instead of using size_t directly? UINTN is used in a bunch of places > where size_t, although it might be the right size, does not feel > appropriate.. I like the idea :) Alex ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states
On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt wrote: > Patch efi_loader: add stub HII protocols uses UINTN heavily. In a recent > comment Simon remarked that types should not be uppercase. So I was > planning to replace all occurences of UINTN by size_t in an upcoming patch. btw, how would you feed about: typedef size_t efi_uintn_t; instead of using size_t directly? UINTN is used in a bunch of places where size_t, although it might be the right size, does not feel appropriate.. BR, -R ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices
This fixes an issue with OpenBSD's bootloader, and I think should also
fix a similar issue with grub2 on legacy devices. In the legacy case
we were creating disk objects for the partitions, but not also the
parent device.
Reported-by: Jonathan Gray
Signed-off-by: Rob Clark
---
lib/efi_loader/efi_disk.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c
index eb9ce772d1..47b487aa30 100644
--- a/lib/efi_loader/efi_disk.c
+++ b/lib/efi_loader/efi_disk.c
@@ -340,6 +340,8 @@ int efi_disk_register(void)
for (i = 0; i < 4; i++) {
struct blk_desc *desc;
char devname[32] = { 0 }; /* dp->str is u16[32] long */
+ disk_partition_t info;
+ int part = 1;
desc = blk_get_devnum_by_type(if_type, i);
if (!desc)
@@ -349,6 +351,15 @@ int efi_disk_register(void)
snprintf(devname, sizeof(devname), "%s%d",
if_typename, i);
+
+ /* add devices for each partition: */
+ while (!part_get_info(desc, part, &info)) {
+ efi_disk_add_dev(devname, if_typename, desc,
+i, 0, part);
+ part++;
+ }
+
+ /* ... and add block device: */
efi_disk_add_dev(devname, if_typename, desc, i, 0, 0);
disks++;
--
2.13.6
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] cmd/gpt.c, cmd/nvedit.c, tools/fit_image.c: Rework recent fixes for Coverity
On Sat, Oct 07, 2017 at 08:19:21PM -0400, Tom Rini wrote: > The recent changes to these files did not completely fix the previous > issues, or introduced different (minor) issues. In cmd/gpt.c we need to > dereference str_disk_guid to be sure that malloc worked. In > cmd/nvedit.c we need to be careful that we can also fit in that leading > space when adding to the string. And in tools/fit_image.c we need to > re-work the error handling slightly in fit_import_data() so that we only > call munmap() once. We have two error paths here, one where we have an > fd to close and one where we do not. Adjust labels to match this. > > Reported-by: Coverity (CID: 167366, 167367, 167370) > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] Travis-CI: Fix microblaze and xilinx jobs
On Sat, Oct 07, 2017 at 08:19:22PM -0400, Tom Rini wrote: > Given how we handle the ARM toolchain we can't easily combine these two > jobs, so don't. Give xilinx/ARM a separate build. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-x86
On Sat, Oct 07, 2017 at 03:16:26PM +0800, Bin Meng wrote: > Hi Tom, > > The following changes since commit 3ea0520512089cffbe02b7d6eb645cdfddb09c5c: > > disk: part_dos: Use the original allocation scheme for the SPL case > (2017-10-05 10:45:33 -0400) > > are available in the git repository at: > > git://git.denx.de/u-boot-x86.git > > for you to fetch changes up to 256df1e1c6664e94926affe9318faa8258c18582: > > x86: edison: Bring minimal ACPI support to the board (2017-10-07 > 15:07:59 +0800) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case
On Sun, Oct 08, 2017 at 09:56:15AM -0300, Fabio Estevam wrote: > On Sat, Oct 7, 2017 at 10:06 PM, Jonathan Gray wrote: > > > I wonder if you have the same kind of fat filesystem. > > No, I have only used ext4 file system. > > > Can you try writing > > https://ftp.openbsd.org/pub/OpenBSD/snapshots/armv7/miniroot-cubox-62.fs > > to an sd card then write a new SPL/U-Boot at the standard raw offsets? > > Maybe it will be easier if you try a 'git bisect' to find out where > the regression is coming from. It turns out to be commit 2460098cffacd18729262e3ed36656e6943783ed Author: Tom Rini Date: Fri Sep 22 07:37:43 2017 -0400 fs/fat: Reduce stack usage We have limited stack in SPL builds. Drop itrblock and move to malloc/free of itr to move this off of the stack. As part of this fix a double-free issue in fat_size(). Signed-off-by: Tom Rini --- Rework to use malloc/free as moving this to a global overflows some SH targets. fs/fat/fat.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) With that reverted I just get the efi loader problem, no alignment errors. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-x86
On Sat, 2017-10-07 at 16:32 +0800, Bin Meng wrote: +Cc: Ferry (he might be interested in this thread) > > Edison?! Edison is dead (end), as I know it... Some people don't think so, there are ones who like the board. Actually, while working for Linux kernel at Intel I'm using that board on almost daily basis to do many tests which are not related strictly to Edison or even Tangier. > > The project is cancelled. That's correct [1]. But be honest, don't you like the idea to have an example of the board, which was never designed to be ACPI compatible, actually to become one (as much as hardware and ACPI specification allow to, of course)? Besides that I have started looking into Edison's stuff around spring time of 2015. You may see my progress here [2] (first article dated 27.03.2015, the chapter "6 What is working and what doesn't" shows progress of upstreaming). U-Boot was appeared on my radar when the stock one stopped working with vanilla kernels. > > Correct me if I am wrong! See above. > I don't know that story. Loop Andy in to comment. Thanks, Bin, for including me in the loop. > But my understanding > is that these are pretty much Intel Tangier SoC related, ...and Merrifield as a platform, which had been used in some x86-based phones. > and Edison is > just a reference board. Edison is one of the Intel's IoT boards, but the only board from Intel MID family [3]. > > Much more important INTEL U-Boot businesses are ATOM E3900/APL-I > > family and > > CORE-5 BDW-DE (possible also BDW-DE NS), > > > > What about these? I can't answer on this. Work on Edison stuff may be considered as my hobby project (I have never been a part of an official team which had done Edison). [1]: https://communities.intel.com/docs/DOC-112093 [2]: https://edison.internet-share.com/wiki/Using_a_vanilla_Linux_kernel _with_Intel_Edison [3]: https://en.wikipedia.org/wiki/Mobile_Internet_device#Intel_MID_plat forms -- Andy Shevchenko Intel Finland Oy ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case
On Sat, Oct 7, 2017 at 10:06 PM, Jonathan Gray wrote: > I wonder if you have the same kind of fat filesystem. No, I have only used ext4 file system. > Can you try writing > https://ftp.openbsd.org/pub/OpenBSD/snapshots/armv7/miniroot-cubox-62.fs > to an sd card then write a new SPL/U-Boot at the standard raw offsets? Maybe it will be easier if you try a 'git bisect' to find out where the regression is coming from. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] moveconfig: Fix error message for a missing toolchain
Due to misplaced quote the error message is literally e.g.: MigoR_defconfig Tool chain for '%s' is missing. Do nothing. % arch Fix it to correctly show the architecture: MigoR_defconfig Tool chain for 'sh' is missing. Do nothing. Signed-off-by: Tuomas Tynkkynen --- tools/moveconfig.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/moveconfig.py b/tools/moveconfig.py index e3116461ba..bdd4899fcd 100755 --- a/tools/moveconfig.py +++ b/tools/moveconfig.py @@ -1170,7 +1170,7 @@ class Slot: toolchain = self.toolchains.Select(arch) except ValueError: self.log += color_text(self.options.color, COLOR_YELLOW, -"Tool chain for '%s' is missing. Do nothing.\n % arch") +"Tool chain for '%s' is missing. Do nothing.\n" % arch) self.finish(False) return env = toolchain.MakeEnvironment(False) -- 2.14.2 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
