Re: [U-Boot] [PULL] efi patch queue 2018-07-25
On Sat, Jul 28, 2018 at 11:32:56PM +0200, Heinrich Schuchardt wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 07/28/2018 08:33 PM, Tom Rini wrote: > > On Sat, Jul 28, 2018 at 07:10:39PM +0200, Heinrich Schuchardt > > wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 > >> > >> On 07/28/2018 06:32 PM, Tom Rini wrote: > >>> On Sat, Jul 28, 2018 at 06:21:58PM +0200, Heinrich Schuchardt > >>> wrote: > -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 > > On 07/28/2018 06:13 PM, Tom Rini wrote: > > On Sat, Jul 28, 2018 at 06:07:20PM +0200, Heinrich > > Schuchardt wrote: > > > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 > >> > >> On 07/28/2018 05:55 PM, Tom Rini wrote: > >>> On Wed, Jul 25, 2018 at 03:04:27PM +0200, Alexander > >>> Graf wrote: > >>> > Hi Tom, > > This is my current patch queue for efi. Please > pull. > > Alex > > > The following changes since commit > 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784: > > mtd: nand: add new enum for storing ECC algorithm > (2018-07-23 14:33:21 -0400) > > are available in the git repository at: > > git://github.com/agraf/u-boot.git > tags/signed-efi-next > > for you to fetch changes up to > 0b8a88ab6aa24de0ef2bf1e8109409f71e770a8e: > > MAINTAINERS: assign lib/charset.c (2018-07-25 > 15:00:24 +0200) > > >>> > >>> NAK, this breaks one of the filesystem tests. > >>> Specifically: commit > >>> 0dc1bfb7302d220a48364263d5632d6d572b069b Author: > >>> Heinrich Schuchardt Date: Mon > >>> Jul 2 02:41:23 2018 +0200 > >>> > >>> fs: fat: cannot write to subdirectories > >>> > >>> Breaks TC13: 1MB write to ./1MB.file.w2 > >>> > >> > >> Hello Tom, > >> > >> please, provide the link to the Travis log with the > >> failure. > > > > It's actually not in travis. Running test/fs/fs-test.sh is > > annoying to automate: FSTST=`./test/fs/fs-test.sh 2>&1 | > > tail -n 3 | head -n 1` echo $FSTST | grep -q "TOTAL PASS: > > 204 TOTAL FAIL: 12" && exit 0 || exit 1 > > > > but I should see if I can get that into .travis.yml. > > > > ./test/fs/fs-test.sh Missing mkfs binary. Exiting! > > You wouldn't run tests as root? Is this test meant to be run > with fakeroot? > >>> > >>> It requires sudo to work along with various utilities to make > >>> the various filesystems. > >>> > >> > >> Tom please, have a look at the files created by the tests w/o my > >> patch. > >> > >> This is what the find command returns: > >> > >> sandbox/test/fs/mnt sandbox/test/fs/mnt/SUBDIR > >> sandbox/test/fs/mnt/2.5GB.file sandbox/test/fs/mnt/1MB.file > >> sandbox/test/fs/mnt/1MB.file.w sandbox/test/fs/mnt/1MB.file.w2 > >> sandbox/test/fs/mnt/./1MB.file.w2 > >> > >> You observe that the last file has an illegal file name (yes, > >> the filename itself is "./1MB.file.w2". It should never have been > >> created. > >> > >> Without my patch this illegal file is not created. > >> > >> Why should this be a reason to dismiss my patch? > > > > Ah, OK, thanks for looking. Please submit a patch that updates > > the tests. > > > > With Takahiro's patch series > > fs: fat: extend FAT write operations > https://patchwork.ozlabs.org/project/uboot/list/?series=56580 > https://lists.denx.de/pipermail/u-boot/2018-July/335683.html > > the FAT driver will finally correctly support paths with subdirectories. > > With that patch series the created files are: > > sandbox/test/fs/mnt > sandbox/test/fs/mnt/SUBDIR > sandbox/test/fs/mnt/2.5GB.file > sandbox/test/fs/mnt/1MB.file > sandbox/test/fs/mnt/1MB.file.w > sandbox/test/fs/mnt/1MB.file.w2 > > There is nothing wrong with the TC13 test. After writing it tries to > do the verification with (b) and without (c) a relative path. If both > subtests are passed the file system is working as expected. And as you > already will have observed TC13b and TC13c are not passed without > Takahiro's patch series. Then I guess the answer is an update to fs-test.sh to note that the expected, for now, results should be 200/16 and to make sure that Takahiro's series also updates fs-test.sh results. Thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [BUG] qemu-x86_defconfig does not build with GCC 8.1
Hi Heinrich,
On Sat, Jul 28, 2018 at 11:42 PM, Heinrich Schuchardt
wrote:
> Debian Buster has upgraded gcc to version 8.1.
Do you know any pre-built gcc 8.1 that can be used on other
distributions than Debian Buster, so that I can take a look? I am
currently on Ubuntu 16.04.
>
> With gcc 8.1 I get an error when trying to build qemu-x86_defconfig
>
> {standard input}: Assembler messages:
> {standard input}:7465: Error: junk at end of line, first unrecognized
> character is `@'
>
> The problematic line in the generated assembler code is
>
> .long end.6133@gotoff-start.6130@gotoff
>
> This difference relates to the length of a linker generated list and is
> only needed for debugging. It is not generated when compiling without
> option -g.
>
Without '-g', does gcc 8.1 build?
> Compilation on x86 works fine with gcc 7.3.
> gcc 7.3 simply does not generate the line at all.
>
Does gcc 8.1 on Debin Buster come with multilib support? I vaguely
remember old version did not which would cause build error.
> To generate the complete assembler code use gcc with options
> -S -fverbose-asm.
>
Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] dm: sysreset: x86: missing build dependency
Hi Heinrich,
On Sun, Jul 29, 2018 at 5:44 AM, Heinrich Schuchardt wrote:
> On 07/23/2018 03:51 AM, Bin Meng wrote:
>> Hi Heinrich,
>>
>> On Sun, Jul 22, 2018 at 5:48 PM, Heinrich Schuchardt
>> wrote:
>>> make qemu-x86_defconfig
>>> with additional
>>>
>>> #CONFIG_SYSRESET is not set
>>>
>>
>> I don't understand the changes. Why do you want to add
>> "#CONFIG_SYSRESET is not set"?
>
> I was astonished that a configuration file I was using suddenly was
> failing after your patch was merged. I analyzed the problem and found
> the missing dependency.
>
> In general it should not be possible to create a configuration that
> cannot be built. One tool to verify this is the U-Boot randconfig target.
>
Yes, that's the goal, however I doubt currently we achieved such goal.
Using "Fixes: fabb2b4c7f28 ("dm: sysreset: x86: Add a sysreset
driver")" misleads people, as you are not using the default
configuration. If we want to support such random build for sysreset, I
think we should put the below driver under "if SYSRESET" too, not just
x86.
41 config SYSRESET_SYSCON
42 bool "Enable support for mfd syscon reboot driver"
43 select REGMAP
44 select SYSCON
45 help
46 Reboot support for generic SYSCON mapped register reset.
47
48 config SYSRESET_WATCHDOG
49 bool "Enable support for watchdog reboot driver"
50 select WDT
51 help
52 Reboot support for generic watchdog reset.
53
Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] dm: sysreset: x86: missing build dependency
On 07/23/2018 03:51 AM, Bin Meng wrote:
> Hi Heinrich,
>
> On Sun, Jul 22, 2018 at 5:48 PM, Heinrich Schuchardt
> wrote:
>> make qemu-x86_defconfig
>> with additional
>>
>> #CONFIG_SYSRESET is not set
>>
>
> I don't understand the changes. Why do you want to add
> "#CONFIG_SYSRESET is not set"?
I was astonished that a configuration file I was using suddenly was
failing after your patch was merged. I analyzed the problem and found
the missing dependency.
In general it should not be possible to create a configuration that
cannot be built. One tool to verify this is the U-Boot randconfig target.
Best regards
Heinrich
>
>> results in
>>
>> LD u-boot
>> lib/built-in.o: In function `efi_reset_system_boottime':
>> lib/efi_loader/efi_runtime.c:122: undefined reference to `do_reset'
>>
>> Fixes: fabb2b4c7f28 ("dm: sysreset: x86: Add a sysreset driver")
>> Signed-off-by: Heinrich Schuchardt
>> ---
>> drivers/sysreset/Kconfig | 12 ++--
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/sysreset/Kconfig b/drivers/sysreset/Kconfig
>> index 9b2fda4d25..a5a58e6d83 100644
>> --- a/drivers/sysreset/Kconfig
>> +++ b/drivers/sysreset/Kconfig
>> @@ -36,6 +36,12 @@ config SYSRESET_PSCI
>> Enable PSCI SYSTEM_RESET function call. To use this, PSCI firmware
>> must be running on your system.
>>
>> +config SYSRESET_X86
>> + bool "Enable support for x86 processor reboot driver"
>> + depends on X86
>> + help
>> + Reboot support for generic x86 processor reset.
>> +
>> endif
>>
>> config SYSRESET_SYSCON
>> @@ -51,10 +57,4 @@ config SYSRESET_WATCHDOG
>> help
>> Reboot support for generic watchdog reset.
>>
>> -config SYSRESET_X86
>> - bool "Enable support for x86 processor reboot driver"
>> - depends on X86
>> - help
>> - Reboot support for generic x86 processor reset.
>> -
>> endmenu
>> --
>
> Regards,
> Bin
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PULL] efi patch queue 2018-07-25
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 07/28/2018 08:33 PM, Tom Rini wrote: > On Sat, Jul 28, 2018 at 07:10:39PM +0200, Heinrich Schuchardt > wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 >> >> On 07/28/2018 06:32 PM, Tom Rini wrote: >>> On Sat, Jul 28, 2018 at 06:21:58PM +0200, Heinrich Schuchardt >>> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 07/28/2018 06:13 PM, Tom Rini wrote: > On Sat, Jul 28, 2018 at 06:07:20PM +0200, Heinrich > Schuchardt wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 >> >> On 07/28/2018 05:55 PM, Tom Rini wrote: >>> On Wed, Jul 25, 2018 at 03:04:27PM +0200, Alexander >>> Graf wrote: >>> Hi Tom, This is my current patch queue for efi. Please pull. Alex The following changes since commit 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784: mtd: nand: add new enum for storing ECC algorithm (2018-07-23 14:33:21 -0400) are available in the git repository at: git://github.com/agraf/u-boot.git tags/signed-efi-next for you to fetch changes up to 0b8a88ab6aa24de0ef2bf1e8109409f71e770a8e: MAINTAINERS: assign lib/charset.c (2018-07-25 15:00:24 +0200) >>> >>> NAK, this breaks one of the filesystem tests. >>> Specifically: commit >>> 0dc1bfb7302d220a48364263d5632d6d572b069b Author: >>> Heinrich Schuchardt Date: Mon >>> Jul 2 02:41:23 2018 +0200 >>> >>> fs: fat: cannot write to subdirectories >>> >>> Breaks TC13: 1MB write to ./1MB.file.w2 >>> >> >> Hello Tom, >> >> please, provide the link to the Travis log with the >> failure. > > It's actually not in travis. Running test/fs/fs-test.sh is > annoying to automate: FSTST=`./test/fs/fs-test.sh 2>&1 | > tail -n 3 | head -n 1` echo $FSTST | grep -q "TOTAL PASS: > 204 TOTAL FAIL: 12" && exit 0 || exit 1 > > but I should see if I can get that into .travis.yml. > ./test/fs/fs-test.sh Missing mkfs binary. Exiting! You wouldn't run tests as root? Is this test meant to be run with fakeroot? >>> >>> It requires sudo to work along with various utilities to make >>> the various filesystems. >>> >> >> Tom please, have a look at the files created by the tests w/o my >> patch. >> >> This is what the find command returns: >> >> sandbox/test/fs/mnt sandbox/test/fs/mnt/SUBDIR >> sandbox/test/fs/mnt/2.5GB.file sandbox/test/fs/mnt/1MB.file >> sandbox/test/fs/mnt/1MB.file.w sandbox/test/fs/mnt/1MB.file.w2 >> sandbox/test/fs/mnt/./1MB.file.w2 >> >> You observe that the last file has an illegal file name (yes, >> the filename itself is "./1MB.file.w2". It should never have been >> created. >> >> Without my patch this illegal file is not created. >> >> Why should this be a reason to dismiss my patch? > > Ah, OK, thanks for looking. Please submit a patch that updates > the tests. > With Takahiro's patch series fs: fat: extend FAT write operations https://patchwork.ozlabs.org/project/uboot/list/?series=56580 https://lists.denx.de/pipermail/u-boot/2018-July/335683.html the FAT driver will finally correctly support paths with subdirectories. With that patch series the created files are: sandbox/test/fs/mnt sandbox/test/fs/mnt/SUBDIR sandbox/test/fs/mnt/2.5GB.file sandbox/test/fs/mnt/1MB.file sandbox/test/fs/mnt/1MB.file.w sandbox/test/fs/mnt/1MB.file.w2 There is nothing wrong with the TC13 test. After writing it tries to do the verification with (b) and without (c) a relative path. If both subtests are passed the file system is working as expected. And as you already will have observed TC13b and TC13c are not passed without Takahiro's patch series. Best regards Heinrich -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEbcT5xx8ppvoGt20zxIHbvCwFGsQFAltc4P8ACgkQxIHbvCwF GsSfXg/9G6RqPbMGb3wl3SOZSnPM2VzTv9tvnnpqZq8Bmaao4I7sgnI3w/Ts6r/k iBU0c4iOrcytOiVWiQU9FPJ3L8zKOMqfK7vE9186NUZFh1u10sJrmLfESV6pbKF8 +pxKy6xM2y8F7AWE0VhgAf7lxFbA2tnhFAQPbP687mJaFKYKG48CQ0r7GwXO/iEl YvE5KflSOEIuTJ6VD7sVuOdEWw8v9yXZTevxcjYSMQppvGg2JIpILtUc89aMlNNC rFTesESdkqcm5V8NUaaMLv404QiW1z93ya+za7IwoUiXAlxYFuXCWJtOqWXxz4Mu EbGOXTYXUq0xXqNJDZDjtwzOQilUANvFGAwXUJc1F6q3F0XJNLOStC7Vr6SrBjij ibiJAj1XOgEbNip6m1yDB0ycyCjKjASr+l6RrfWzFli1AiQon4Fk6P38Rb27RAiU DGTMKp6gqhj1tTLaNQTEzwdgcr19GvRfJQpfDYkZX0ujESETwMCyO+1i4VuM7bJo v2h7C+1m7uk7qVDbwJAtTS0YiL7k7ZqyFv55AmGtRH0ZNVNIgIFByfXYchukrHqo q89l1mYtMba05ZZ4JVp/21AcEFH94WbtlPvkizXhpcxeH2ZpGR1GhmZEXNJ/a9uP d9eDngVapglWzJCya+ojtMh+RZi4Rn01Y3Qv45PfRptmzxJn2CI= =aYo7 -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] omap3_logic: Fix CONS_INDEX
The console index for SPL should be 1 not 3 in order to see text during
SPL.
Fixes 6f6b7cfa89e5 ("Convert all of CONFIG_CONS_INDEX to Kconfig")
Signed-off-by: Adam Ford
diff --git a/configs/omap3_logic_defconfig b/configs/omap3_logic_defconfig
index ed9f454a5d..0420493a0e 100644
--- a/configs/omap3_logic_defconfig
+++ b/configs/omap3_logic_defconfig
@@ -46,7 +46,7 @@ CONFIG_NETDEVICES=y
CONFIG_SMC911X=y
CONFIG_SMC911X_BASE=0x0800
CONFIG_SMC911X_32_BIT=y
-CONFIG_CONS_INDEX=3
+CONFIG_CONS_INDEX=1
CONFIG_SYS_NS16550=y
CONFIG_SPI=y
CONFIG_DM_SPI=y
--
2.17.1
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] board: sun50i: h6: Add OrangePi One Plus initial support
OrangePi One Plus is Allwinner H6 based open-source SBC,
which support:
- Allwinner H6 Quad-core 64-bit ARM Cortex-A53
- GPU Mali-T720
- 1GB LPDDR3 RAM
- AXP805 PMIC
- 1Gbps GMAC via RTL8211
- USB 2.0 Host, OTG
- HDMI port
- 5V/2A DC power supply
Signed-off-by: Jagan Teki
---
arch/arm/dts/Makefile| 1 +
arch/arm/dts/sun50i-h6-orangepi-one-plus.dts | 150 +++
board/sunxi/MAINTAINERS | 5 +
configs/orangepi_one_plus_defconfig | 14 ++
4 files changed, 170 insertions(+)
create mode 100644 arch/arm/dts/sun50i-h6-orangepi-one-plus.dts
create mode 100644 configs/orangepi_one_plus_defconfig
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 791ae01132..89032bb545 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -391,6 +391,7 @@ dtb-$(CONFIG_MACH_SUN50I_H5) += \
sun50i-h5-orangepi-prime.dtb \
sun50i-h5-orangepi-zero-plus2.dtb
dtb-$(CONFIG_MACH_SUN50I_H6) += \
+ sun50i-h6-orangepi-one-plus.dtb \
sun50i-h6-pine-h64.dtb
dtb-$(CONFIG_MACH_SUN50I) += \
sun50i-a64-amarula-relic.dtb \
diff --git a/arch/arm/dts/sun50i-h6-orangepi-one-plus.dts
b/arch/arm/dts/sun50i-h6-orangepi-one-plus.dts
new file mode 100644
index 00..0612c19cd9
--- /dev/null
+++ b/arch/arm/dts/sun50i-h6-orangepi-one-plus.dts
@@ -0,0 +1,150 @@
+// SPDX-License-Identifier: (GPL-2.0+ or MIT)
+/*
+ * Copyright (C) 2018 Amarula Solutions
+ * Author: Jagan Teki
+ */
+
+/dts-v1/;
+
+#include "sun50i-h6.dtsi"
+
+#include
+
+/ {
+ model = "OrangePi One Plus";
+ compatible = "xunlong,orangepi-one-plus", "allwinner,sun50i-h6";
+
+ aliases {
+ serial0 =
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+};
+
+ {
+ pinctrl-names = "default";
+ pinctrl-0 = <_pins>;
+ vmmc-supply = <_cldo1>;
+ cd-gpios = < 5 6 GPIO_ACTIVE_LOW>;
+ bus-width = <4>;
+ status = "okay";
+};
+
+_i2c {
+ status = "okay";
+
+ axp805: pmic@36 {
+ compatible = "x-powers,axp805", "x-powers,axp806";
+ reg = <0x36>;
+ interrupt-parent = <_intc>;
+ interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ x-powers,self-working-mode;
+
+ regulators {
+ reg_aldo1: aldo1 {
+ regulator-always-on;
+ regulator-min-microvolt = <330>;
+ regulator-max-microvolt = <330>;
+ regulator-name = "vcc-pl";
+ };
+
+ reg_aldo2: aldo2 {
+ regulator-min-microvolt = <330>;
+ regulator-max-microvolt = <330>;
+ regulator-name = "vcc-ac200";
+ };
+
+ reg_aldo3: aldo3 {
+ regulator-always-on;
+ regulator-min-microvolt = <330>;
+ regulator-max-microvolt = <330>;
+ regulator-name = "vcc25-dram";
+ };
+
+ reg_bldo1: bldo1 {
+ regulator-always-on;
+ regulator-min-microvolt = <180>;
+ regulator-max-microvolt = <180>;
+ regulator-name = "vcc-bias-pll";
+ };
+
+ reg_bldo2: bldo2 {
+ regulator-always-on;
+ regulator-min-microvolt = <180>;
+ regulator-max-microvolt = <180>;
+ regulator-name = "vcc-efuse-pcie-hdmi-io";
+ };
+
+ reg_bldo3: bldo3 {
+ regulator-always-on;
+ regulator-min-microvolt = <180>;
+ regulator-max-microvolt = <180>;
+ regulator-name = "vcc-dcxoio";
+ };
+
+ bldo4 {
+ /* unused */
+ };
+
+ reg_cldo1: cldo1 {
+ regulator-always-on;
+ regulator-min-microvolt = <330>;
+ regulator-max-microvolt = <330>;
+ regulator-name = "vcc-3v3";
+ };
+
+ reg_cldo2: cldo2 {
+ regulator-min-microvolt = <330>;
+ regulator-max-microvolt = <330>;
+ regulator-name =
Re: [U-Boot] [PULL] efi patch queue 2018-07-25
On Sat, Jul 28, 2018 at 07:10:39PM +0200, Heinrich Schuchardt wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 07/28/2018 06:32 PM, Tom Rini wrote: > > On Sat, Jul 28, 2018 at 06:21:58PM +0200, Heinrich Schuchardt > > wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 > >> > >> On 07/28/2018 06:13 PM, Tom Rini wrote: > >>> On Sat, Jul 28, 2018 at 06:07:20PM +0200, Heinrich Schuchardt > >>> wrote: > >>> > -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 > > On 07/28/2018 05:55 PM, Tom Rini wrote: > > On Wed, Jul 25, 2018 at 03:04:27PM +0200, Alexander Graf > > wrote: > > > >> Hi Tom, > >> > >> This is my current patch queue for efi. Please pull. > >> > >> Alex > >> > >> > >> The following changes since commit > >> 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784: > >> > >> mtd: nand: add new enum for storing ECC algorithm > >> (2018-07-23 14:33:21 -0400) > >> > >> are available in the git repository at: > >> > >> git://github.com/agraf/u-boot.git tags/signed-efi-next > >> > >> for you to fetch changes up to > >> 0b8a88ab6aa24de0ef2bf1e8109409f71e770a8e: > >> > >> MAINTAINERS: assign lib/charset.c (2018-07-25 15:00:24 > >> +0200) > >> > > > > NAK, this breaks one of the filesystem tests. > > Specifically: commit > > 0dc1bfb7302d220a48364263d5632d6d572b069b Author: Heinrich > > Schuchardt Date: Mon Jul 2 02:41:23 > > 2018 +0200 > > > > fs: fat: cannot write to subdirectories > > > > Breaks TC13: 1MB write to ./1MB.file.w2 > > > > Hello Tom, > > please, provide the link to the Travis log with the failure. > >>> > >>> It's actually not in travis. Running test/fs/fs-test.sh is > >>> annoying to automate: FSTST=`./test/fs/fs-test.sh 2>&1 | tail > >>> -n 3 | head -n 1` echo $FSTST | grep -q "TOTAL PASS: 204 TOTAL > >>> FAIL: 12" && exit 0 || exit 1 > >>> > >>> but I should see if I can get that into .travis.yml. > >>> > >> > >> ./test/fs/fs-test.sh Missing mkfs binary. Exiting! > >> > >> You wouldn't run tests as root? Is this test meant to be run > >> with fakeroot? > > > > It requires sudo to work along with various utilities to make the > > various filesystems. > > > > Tom please, have a look at the files created by the tests w/o my patch. > > This is what the find command returns: > > sandbox/test/fs/mnt > sandbox/test/fs/mnt/SUBDIR > sandbox/test/fs/mnt/2.5GB.file > sandbox/test/fs/mnt/1MB.file > sandbox/test/fs/mnt/1MB.file.w > sandbox/test/fs/mnt/1MB.file.w2 > sandbox/test/fs/mnt/./1MB.file.w2 > > You observe that the last file has an illegal file name (yes, the > filename itself is "./1MB.file.w2". It should never have been created. > > Without my patch this illegal file is not created. > > Why should this be a reason to dismiss my patch? Ah, OK, thanks for looking. Please submit a patch that updates the tests. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PULL] efi patch queue 2018-07-25
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 07/28/2018 06:32 PM, Tom Rini wrote: > On Sat, Jul 28, 2018 at 06:21:58PM +0200, Heinrich Schuchardt > wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 >> >> On 07/28/2018 06:13 PM, Tom Rini wrote: >>> On Sat, Jul 28, 2018 at 06:07:20PM +0200, Heinrich Schuchardt >>> wrote: >>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 07/28/2018 05:55 PM, Tom Rini wrote: > On Wed, Jul 25, 2018 at 03:04:27PM +0200, Alexander Graf > wrote: > >> Hi Tom, >> >> This is my current patch queue for efi. Please pull. >> >> Alex >> >> >> The following changes since commit >> 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784: >> >> mtd: nand: add new enum for storing ECC algorithm >> (2018-07-23 14:33:21 -0400) >> >> are available in the git repository at: >> >> git://github.com/agraf/u-boot.git tags/signed-efi-next >> >> for you to fetch changes up to >> 0b8a88ab6aa24de0ef2bf1e8109409f71e770a8e: >> >> MAINTAINERS: assign lib/charset.c (2018-07-25 15:00:24 >> +0200) >> > > NAK, this breaks one of the filesystem tests. > Specifically: commit > 0dc1bfb7302d220a48364263d5632d6d572b069b Author: Heinrich > Schuchardt Date: Mon Jul 2 02:41:23 > 2018 +0200 > > fs: fat: cannot write to subdirectories > > Breaks TC13: 1MB write to ./1MB.file.w2 > Hello Tom, please, provide the link to the Travis log with the failure. >>> >>> It's actually not in travis. Running test/fs/fs-test.sh is >>> annoying to automate: FSTST=`./test/fs/fs-test.sh 2>&1 | tail >>> -n 3 | head -n 1` echo $FSTST | grep -q "TOTAL PASS: 204 TOTAL >>> FAIL: 12" && exit 0 || exit 1 >>> >>> but I should see if I can get that into .travis.yml. >>> >> >> ./test/fs/fs-test.sh Missing mkfs binary. Exiting! >> >> You wouldn't run tests as root? Is this test meant to be run >> with fakeroot? > > It requires sudo to work along with various utilities to make the > various filesystems. > Tom please, have a look at the files created by the tests w/o my patch. This is what the find command returns: sandbox/test/fs/mnt sandbox/test/fs/mnt/SUBDIR sandbox/test/fs/mnt/2.5GB.file sandbox/test/fs/mnt/1MB.file sandbox/test/fs/mnt/1MB.file.w sandbox/test/fs/mnt/1MB.file.w2 sandbox/test/fs/mnt/./1MB.file.w2 You observe that the last file has an illegal file name (yes, the filename itself is "./1MB.file.w2". It should never have been created. Without my patch this illegal file is not created. Why should this be a reason to dismiss my patch? Best regards Heinrich -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEbcT5xx8ppvoGt20zxIHbvCwFGsQFAltco4YACgkQxIHbvCwF GsSTxhAAhPbNHg16YZg7DZE6pMPZ5v64eVrAPPiM6LoIb8rXyLtKP9lDh/V1tk33 t7nHRfPfS5Ow3KYjneBxoxnw3A4uxU4Rf16xb5KZX9UvLPUusumwjaRUW9/FytiQ MkZeZQGdtAHLy9cFL3sRkIM4Vz3kWo5XBNgYjJaYQAN0/BlWt6oknTUKAYrciGCz O+B7i6Vf7hXj1d1RdFjLfS4sinSibjUMd1Bn5HoAZvjLo3Gfmi+e/ZIPXKb75QfP fQwH6oGuEOL6WqL+OyS5CVXiBeGbOtrJoH7o5C8TEixcPwp2cKGP7p/L8UBIOBbM a/zXIgumFZhAyDhRdLcvevvUxfBRX4opCgGYk8aG8/QlpnoZO7eeQJxKU7+t/JxY UCRQNZXzh6WbTDLkRkP5u3vIA0qGqpGNkH9D7lGU8W9Iq9awkr3gtLls1HGuyGI+ zdYpLeC9JYYRPPZSG/Guy58NphuYRG3vCj6D8tvLqMzE3dYCIBwxobWESV26s40h do3oqPTpmFYWJNJG4C1x0H3JfMW32X5ibrk8Hn6AFvHn4DYsdD4c24Ofol9IcIqf nbgsYwrf5rdyiqgK5MUVXoFztNkPot6BSI+sU/ft3CcxX+0/cpSYiZ3M3QOk8BGt J5Q7/57oBxcLrZrlEmE9PE+rmGDpw6F60DqZpGo5EwyzZmb4nKM= =V/cr -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PULL] efi patch queue 2018-07-25
On Sat, Jul 28, 2018 at 06:21:58PM +0200, Heinrich Schuchardt wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 07/28/2018 06:13 PM, Tom Rini wrote: > > On Sat, Jul 28, 2018 at 06:07:20PM +0200, Heinrich Schuchardt > > wrote: > > > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 > >> > >> On 07/28/2018 05:55 PM, Tom Rini wrote: > >>> On Wed, Jul 25, 2018 at 03:04:27PM +0200, Alexander Graf > >>> wrote: > >>> > Hi Tom, > > This is my current patch queue for efi. Please pull. > > Alex > > > The following changes since commit > 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784: > > mtd: nand: add new enum for storing ECC algorithm > (2018-07-23 14:33:21 -0400) > > are available in the git repository at: > > git://github.com/agraf/u-boot.git tags/signed-efi-next > > for you to fetch changes up to > 0b8a88ab6aa24de0ef2bf1e8109409f71e770a8e: > > MAINTAINERS: assign lib/charset.c (2018-07-25 15:00:24 > +0200) > > >>> > >>> NAK, this breaks one of the filesystem tests. Specifically: > >>> commit 0dc1bfb7302d220a48364263d5632d6d572b069b Author: > >>> Heinrich Schuchardt Date: Mon Jul 2 > >>> 02:41:23 2018 +0200 > >>> > >>> fs: fat: cannot write to subdirectories > >>> > >>> Breaks TC13: 1MB write to ./1MB.file.w2 > >>> > >> > >> Hello Tom, > >> > >> please, provide the link to the Travis log with the failure. > > > > It's actually not in travis. Running test/fs/fs-test.sh is > > annoying to automate: FSTST=`./test/fs/fs-test.sh 2>&1 | tail -n 3 > > | head -n 1` echo $FSTST | grep -q "TOTAL PASS: 204 TOTAL FAIL: 12" > > && exit 0 || exit 1 > > > > but I should see if I can get that into .travis.yml. > > > > ./test/fs/fs-test.sh > Missing mkfs binary. Exiting! > > You wouldn't run tests as root? Is this test meant to be run with > fakeroot? It requires sudo to work along with various utilities to make the various filesystems. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PULL] efi patch queue 2018-07-25
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 07/28/2018 06:13 PM, Tom Rini wrote: > On Sat, Jul 28, 2018 at 06:07:20PM +0200, Heinrich Schuchardt > wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 >> >> On 07/28/2018 05:55 PM, Tom Rini wrote: >>> On Wed, Jul 25, 2018 at 03:04:27PM +0200, Alexander Graf >>> wrote: >>> Hi Tom, This is my current patch queue for efi. Please pull. Alex The following changes since commit 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784: mtd: nand: add new enum for storing ECC algorithm (2018-07-23 14:33:21 -0400) are available in the git repository at: git://github.com/agraf/u-boot.git tags/signed-efi-next for you to fetch changes up to 0b8a88ab6aa24de0ef2bf1e8109409f71e770a8e: MAINTAINERS: assign lib/charset.c (2018-07-25 15:00:24 +0200) >>> >>> NAK, this breaks one of the filesystem tests. Specifically: >>> commit 0dc1bfb7302d220a48364263d5632d6d572b069b Author: >>> Heinrich Schuchardt Date: Mon Jul 2 >>> 02:41:23 2018 +0200 >>> >>> fs: fat: cannot write to subdirectories >>> >>> Breaks TC13: 1MB write to ./1MB.file.w2 >>> >> >> Hello Tom, >> >> please, provide the link to the Travis log with the failure. > > It's actually not in travis. Running test/fs/fs-test.sh is > annoying to automate: FSTST=`./test/fs/fs-test.sh 2>&1 | tail -n 3 > | head -n 1` echo $FSTST | grep -q "TOTAL PASS: 204 TOTAL FAIL: 12" > && exit 0 || exit 1 > > but I should see if I can get that into .travis.yml. > ./test/fs/fs-test.sh Missing mkfs binary. Exiting! You wouldn't run tests as root? Is this test meant to be run with fakeroot? Best regards Heinrich -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEbcT5xx8ppvoGt20zxIHbvCwFGsQFAltcmB8ACgkQxIHbvCwF GsRfyg/7ByTTAsNNZOa1jXxqY4Swp+F495ybdjRlUMkiIF+zxgQJLCcLpkVO1HLR 4TP62LTq+gGdnHvEOjQmxVGCGXNjlFCyBDbGL7rB8eLZFIBgJ1343Q1V4V0FURir HdCpIVFRHUNwMV3DU6iK04QwjldC7MurJG/yJaE6RySrRxdGSNxSP9kYDkDrolU+ BOibDleXhxaGT65Vb7V77dAmkGwGWYhvCD/3AgDxlztGKOCSIW1XotUyWrORQvhf dUL3VddKaVqQoUc3MZJllc5II/qCdFO8e4jXlPMXvm6iHeqGBdt7oHssylbAZkuS V+9Ocfi1/qz7c4ZR7MhC7Lqs8zmVBO8gnseLnt4nI3HbrSa4etR1Aqr+YY57id24 stCe7miK71DK7FiBVdgeJqRLiT82pcMZHSRCCW0DlJM70v4SPRZ/rNOyGnQnxSvo /2SJQz/jVOMhk2SqjT9mjtEfHPjyt1EUllqjQUjEYtMvqCgx2b5sWKQUEkiGiJTB Ydj+LqnRCBzKUVbS1JVU56jhuHA8zqM67QRaTRgj1MQqkrNEDqj4CHA7a3tol159 OWY2Sv7BcxXozHTVF5l0yImh2w1Bx3ot0XYY5u2L35eEQl60Xyi9TmSrC1l1qv29 PHVYLwynvecQP56RbqHpAws1TuiIPWpnW5Rc66/Y1j8hplD2F6w= =g8NU -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PULL] efi patch queue 2018-07-25
On Sat, Jul 28, 2018 at 06:07:20PM +0200, Heinrich Schuchardt wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 07/28/2018 05:55 PM, Tom Rini wrote: > > On Wed, Jul 25, 2018 at 03:04:27PM +0200, Alexander Graf wrote: > > > >> Hi Tom, > >> > >> This is my current patch queue for efi. Please pull. > >> > >> Alex > >> > >> > >> The following changes since commit > >> 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784: > >> > >> mtd: nand: add new enum for storing ECC algorithm (2018-07-23 > >> 14:33:21 -0400) > >> > >> are available in the git repository at: > >> > >> git://github.com/agraf/u-boot.git tags/signed-efi-next > >> > >> for you to fetch changes up to > >> 0b8a88ab6aa24de0ef2bf1e8109409f71e770a8e: > >> > >> MAINTAINERS: assign lib/charset.c (2018-07-25 15:00:24 +0200) > >> > > > > NAK, this breaks one of the filesystem tests. Specifically: commit > > 0dc1bfb7302d220a48364263d5632d6d572b069b Author: Heinrich > > Schuchardt Date: Mon Jul 2 02:41:23 2018 > > +0200 > > > > fs: fat: cannot write to subdirectories > > > > Breaks TC13: 1MB write to ./1MB.file.w2 > > > > Hello Tom, > > please, provide the link to the Travis log with the failure. It's actually not in travis. Running test/fs/fs-test.sh is annoying to automate: FSTST=`./test/fs/fs-test.sh 2>&1 | tail -n 3 | head -n 1` echo $FSTST | grep -q "TOTAL PASS: 204 TOTAL FAIL: 12" && exit 0 || exit 1 but I should see if I can get that into .travis.yml. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PULL] efi patch queue 2018-07-25
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 07/28/2018 05:55 PM, Tom Rini wrote: > On Wed, Jul 25, 2018 at 03:04:27PM +0200, Alexander Graf wrote: > >> Hi Tom, >> >> This is my current patch queue for efi. Please pull. >> >> Alex >> >> >> The following changes since commit >> 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784: >> >> mtd: nand: add new enum for storing ECC algorithm (2018-07-23 >> 14:33:21 -0400) >> >> are available in the git repository at: >> >> git://github.com/agraf/u-boot.git tags/signed-efi-next >> >> for you to fetch changes up to >> 0b8a88ab6aa24de0ef2bf1e8109409f71e770a8e: >> >> MAINTAINERS: assign lib/charset.c (2018-07-25 15:00:24 +0200) >> > > NAK, this breaks one of the filesystem tests. Specifically: commit > 0dc1bfb7302d220a48364263d5632d6d572b069b Author: Heinrich > Schuchardt Date: Mon Jul 2 02:41:23 2018 > +0200 > > fs: fat: cannot write to subdirectories > > Breaks TC13: 1MB write to ./1MB.file.w2 > Hello Tom, please, provide the link to the Travis log with the failure. Best regards Heinrich -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEbcT5xx8ppvoGt20zxIHbvCwFGsQFAltclK0ACgkQxIHbvCwF GsTc9w/8Cqd6WakCF+v2WI95qSG2EF9wl0ruM900n/IeOsh22vCkzBd7L0L3Zqbj hIiYUVmEfw7Q5DHWfo+nXXqEmjfsmewI9vcMQNYJtUbCeBq+uv0GPDjJupQ8wJyT B8nnFTWt5jKSFmF+zOdcVa8JPesSD6kmQs0SysVIRb5532rpO0LKjRwCR1uJ4f12 7PRZ1d0Mf4JcY/3RlaaVS480zqo/GRlk7ViwFaq82DDg5MWzjql9AEbYZPb1c+r5 NAyFYEk2X3OPwkRxMvPpmlV5M8xiV58Ht9KnXeqa5aivKsUFBsBoy5Yb4eLQkPAe H385U0yueZUsKil1cFYvOhkm/Nnj3JMa7eT4LovnvnGF23hu+hp2jSCamskyW06a IPHdaUDU8Wnog9loHt4yko0nNHLJ4x9Ryi9WvsFE6P6rS/58t3UcNEhLOkR6oCiJ 44hpE1MxvOzVFkIWrw1ze/86ZzMz2Cj5I65bseBMHcJIOnsZhjTpU2VFYax6gWno mNtSj8OZcwT1dd0XUB3FQofXYpIcgOlc1/cn4fhwQiH8/ZoCRlTUCseSOoa0EOCr W1QgbbR9GTpYKYV6yEy2RmC4qteWB7PvUyfddiOvaTtHeqkp8R8dWeyAmevQxIh6 RFzsXW7EZA0qa95P/5MtrkMzDKzMoD8rbjv0/9Y08TQ2vsGF1vg= =iTo4 -END PGP SIGNATURE- ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PULL] efi patch queue 2018-07-25
On Wed, Jul 25, 2018 at 03:04:27PM +0200, Alexander Graf wrote: > Hi Tom, > > This is my current patch queue for efi. Please pull. > > Alex > > > The following changes since commit 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784: > > mtd: nand: add new enum for storing ECC algorithm (2018-07-23 14:33:21 > -0400) > > are available in the git repository at: > > git://github.com/agraf/u-boot.git tags/signed-efi-next > > for you to fetch changes up to 0b8a88ab6aa24de0ef2bf1e8109409f71e770a8e: > > MAINTAINERS: assign lib/charset.c (2018-07-25 15:00:24 +0200) > NAK, this breaks one of the filesystem tests. Specifically: commit 0dc1bfb7302d220a48364263d5632d6d572b069b Author: Heinrich Schuchardt Date: Mon Jul 2 02:41:23 2018 +0200 fs: fat: cannot write to subdirectories Breaks TC13: 1MB write to ./1MB.file.w2 -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [BUG] qemu-x86_defconfig does not build with GCC 8.1
Debian Buster has upgraded gcc to version 8.1.
With gcc 8.1 I get an error when trying to build qemu-x86_defconfig
{standard input}: Assembler messages:
{standard input}:7465: Error: junk at end of line, first unrecognized
character is `@'
The problematic line in the generated assembler code is
.long end.6133@gotoff-start.6130@gotoff
This difference relates to the length of a linker generated list and is
only needed for debugging. It is not generated when compiling without
option -g.
Compilation on x86 works fine with gcc 7.3.
gcc 7.3 simply does not generate the line at all.
To generate the complete assembler code use gcc with options
-S -fverbose-asm.
Best regards
Heinrich
gcc -Wp,-MD,common/.command.o.d -nostdinc -isystem
/usr/lib/gcc/x86_64-linux-gnu/8/include -Iinclude -I./arch/x86/include
-include ./include/linux/kconfig.h -D__KERNEL__ -D__UBOOT__ -Wall
-Wstrict-prototypes -Wno-format-security -fno-builtin -ffreestanding
-std=gnu11 -fshort-wchar -Os -fno-stack-protector
-fno-delete-null-pointer-checks -fmacro-prefix-map=./= -g -fstack-usage
-Wno-format-nonliteral -Werror=date-time -fno-strict-aliasing
-fomit-frame-pointer -fno-toplevel-reorder -fno-dwarf2-cfi-asm
-march=i386 -m32 -mregparm=3 -D__I386__ -ffunction-sections
-fvisibility=hidden -pipe-D"KBUILD_STR(s)=#s"
-D"KBUILD_BASENAME=KBUILD_STR(command)"
-D"KBUILD_MODNAME=KBUILD_STR(command)" -c -o common/command.o
common/command.c
{standard input}: Assembler messages:
{standard input}:7465: Error: junk at end of line, first unrecognized
character is `@'
{standard input}:10573: Error: junk at end of line, first unrecognized
character is `@'
{standard input}:10587: Error: junk at end of line, first unrecognized
character is `@'
{standard input}:7465: Error: can't resolve `end.6133'
{.u_boot_list_2_cmd_3 section} - `start.6130' {.u_boot_list_2_cmd_1 section}
{standard input}:10573: Error: can't resolve `end.6164'
{.u_boot_list_2_cmd_3 section} - `start.6161' {.u_boot_list_2_cmd_1 section}
{standard input}:10587: Error: can't resolve `end.6164'
{.u_boot_list_2_cmd_3 section} - `start.6161' {.u_boot_list_2_cmd_1 section}
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] tpmv2: Make it select CMD_LOG
The TPMv2 code requires the log functionality, so select it. Signed-off-by: Tom Rini --- cmd/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index 6a471020f844..ef43ed8dda45 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1544,6 +1544,7 @@ config CMD_TPM_V1 config CMD_TPM_V2 bool + select CMD_LOG config CMD_TPM bool "Enable the 'tpm' command" -- 2.7.4 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] env: common: load read-only variables after reset
Dear Yaniv, In message <20180727153444.5602-1-yaniv.levin...@compulab.co.il> you wrote: > U-Boot fails to load read-only variables from storage after a reset. It > happens because the environment hash table prevents creating read-only > variables unless the H_FORCE flag is passed. This is NOT a good idea. "env import" should respect read-only settings in exactly the same way as "env set" does. Please keep in minf that the user my set a variable to read-only exactly just to prevent if from bein (accidentially) overwritten when importing an (not exactly know) set of environment settings. Your patch would kill any such protection. IMO the correct approach would be to add a "-f" flag to "env import" and the, and ONLY then, also set the H_FORCE flag. Naked-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I'm a programmer: I don't buy software, I write it. -- Tom Christiansen ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v1] arm: at91: wdt: Convert watchdog driver to dm
Convert the Watchdog driver for AT91SAM9x processors to support
the driver model and device tree
Signed-off-by: Prasanthi Chellakumar
---
arch/arm/mach-at91/include/mach/at91_wdt.h | 12 +++-
drivers/watchdog/Kconfig | 7 ++
drivers/watchdog/Makefile | 2 +-
drivers/watchdog/at91sam9_wdt.c| 105 +
4 files changed, 95 insertions(+), 31 deletions(-)
diff --git a/arch/arm/mach-at91/include/mach/at91_wdt.h
b/arch/arm/mach-at91/include/mach/at91_wdt.h
index 99b0cc8..df9f131 100644
--- a/arch/arm/mach-at91/include/mach/at91_wdt.h
+++ b/arch/arm/mach-at91/include/mach/at91_wdt.h
@@ -4,7 +4,7 @@
*
* Copyright (C) 2008 Jean-Christophe PLAGNIOL-VILLARD
* Copyright (C) 2007 Andrew Victor
- * Copyright (C) 2007 Atmel Corporation.
+ * Copyright (C) 2018 Microchip Technology Inc.
*
* Watchdog Timer (WDT) - System peripherals regsters.
* Based on AT91SAM9261 datasheet revision D.
@@ -27,15 +27,21 @@ typedef struct at91_wdt {
#endif
+/* Watchdog Control Register */
+#define AT91_WDT_CR0x00
#define AT91_WDT_CR_WDRSTT 1
#define AT91_WDT_CR_KEY0xa500 /* KEY Password
*/
-#define AT91_WDT_MR_WDV(x) (x & 0xfff)
+/* Watchdog Mode Register*/
+#define AT91_WDT_MR0X04
+#define AT91_WDT_MR_WDV(0xfff << 0)
+#defineAT91_WDT_MR_SET_WDV(x) ((x) & AT91_WDT_MR_WDV)
#define AT91_WDT_MR_WDFIEN 0x1000
#define AT91_WDT_MR_WDRSTEN0x2000
#define AT91_WDT_MR_WDRPROC0x4000
#define AT91_WDT_MR_WDDIS 0x8000
-#define AT91_WDT_MR_WDD(x) ((x & 0xfff) << 16)
+#defineAT91_WDT_MR_WDD (0xfff << 16)
+#defineAT91_WDT_MR_SET_WDD(x) (((x) << 16) &
AT91_WDT_MR_WDD)
#define AT91_WDT_MR_WDDBGHLT 0x1000
#define AT91_WDT_MR_WDIDLEHLT 0x2000
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index d545b3e..001a8d0 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -111,4 +111,11 @@ config XILINX_TB_WATCHDOG
Select this to enable Xilinx Axi watchdog timer, which can be found
on some
Xilinx Microblaze Platforms.
+config WDT_AT91
+ bool "AT91 watchdog timer support"
+ depends on WDT
+ help
+ Select this to enable Microchip watchdog timer, which can be found on
+ some AT91 devices.
+
endmenu
diff --git a/drivers/watchdog/Makefile b/drivers/watchdog/Makefile
index f405f51..3f4fd59 100644
--- a/drivers/watchdog/Makefile
+++ b/drivers/watchdog/Makefile
@@ -3,7 +3,7 @@
# (C) Copyright 2008
# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
-obj-$(CONFIG_AT91SAM9_WATCHDOG) += at91sam9_wdt.o
+obj-$(CONFIG_WDT_AT91) += at91sam9_wdt.o
obj-$(CONFIG_FTWDT010_WATCHDOG) += ftwdt010_wdt.o
ifneq (,$(filter $(SOC), mx31 mx35 mx5 mx6 mx7 vf610))
obj-y += imx_watchdog.o
diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
index fca2849..d3f8fa6 100644
--- a/drivers/watchdog/at91sam9_wdt.c
+++ b/drivers/watchdog/at91sam9_wdt.c
@@ -2,7 +2,7 @@
/*
* [origin: Linux kernel drivers/watchdog/at91sam9_wdt.c]
*
- * Watchdog driver for Atmel AT91SAM9x processors.
+ * Watchdog driver for AT91SAM9x processors.
*
* Copyright (C) 2008 Jean-Christophe PLAGNIOL-VILLARD
* Copyright (C) 2008 Renaud CERRATO r.cerr...@til-technologies.fr
@@ -14,38 +14,47 @@
* write to this register. Inform Linux to it too
*/
-#include
-#include
-#include
#include
#include
+#include
+#include
+#include
+#include
+
+DECLARE_GLOBAL_DATA_PTR;
/*
* AT91SAM9 watchdog runs a 12bit counter @ 256Hz,
* use this to convert a watchdog
- * value from/to milliseconds.
+ * value from seconds.
*/
-#define ms_to_ticks(t) (((t << 8) / 1000) - 1)
-#define ticks_to_ms(t) (((t + 1) * 1000) >> 8)
+#define WDT_SEC2TICKS(s) (((s) << 8) - 1)
/* Hardware timeout in seconds */
-#if !defined(CONFIG_AT91_HW_WDT_TIMEOUT)
-#define WDT_HW_TIMEOUT 2
-#else
-#define WDT_HW_TIMEOUT CONFIG_AT91_HW_WDT_TIMEOUT
-#endif
+#define WDT_MAX_TIMEOUT 16
+#define WDT_MIN_TIMEOUT 0
+
+struct at91_wdt_priv {
+ void __iomem *regs;
+ u32 regval;
+};
/*
* Set the watchdog time interval in 1/256Hz (write-once)
* Counter is 12 bit.
*/
-static int at91_wdt_settimeout(unsigned int timeout)
+static int at91_wdt_start(struct udevice *dev, u64 timeout_s, ulong flags)
{
- unsigned int reg;
- at91_wdt_t *wd = (at91_wdt_t *) ATMEL_BASE_WDT;
+ struct at91_wdt_priv *priv = dev_get_priv(dev);
+ u32 timeout = WDT_SEC2TICKS(timeout_s);
+
+ if (timeout_s > WDT_MAX_TIMEOUT || timeout_s < WDT_MIN_TIMEOUT) {
+ printf("Invalid watchdog counter value\n");
+ return -1;
+ }
/* Check if disabled */
-
Re: [U-Boot] [PATCH 2/9] rockchip: support 4GB DRAM on 32bit systems
On Thu, 2018-07-26 at 15:59 +0200, Philipp Tomsich wrote: > The calculation in `rockchip_sdram_size` would overflow for 4GB on > 32bit systems (i.e. when PHYS_64BIT is not defined). > > This makes the internal variables and the signature prototype use a > u64 to ensure that we can represent the 33rd bit (as in '4GB'). > Hi Philipp, just to let you know that this is still not working on the veyron jerry chromebook with 4GB I have here (RK3288). The boot stops at: U-Boot SPL 2018.07-00403-gdbe6ef8276 (Jul 26 2018 - 17:21:11 +0100) Trying to boot from SPI U-Boot 2018.07-00403-gdbe6ef8276 (Jul 26 2018 - 17:21:11 +0100) Model: Google Jerry DRAM: 0 Bytes I'm still investigating why but for sure there are several points to fix to have a proper debug, see [0]. Also I was wondering if we should also fix get_effective_memsize() and gd->bd->bi_dram[].size [0]https://gist.github.com/carlocaione/b93cfd9ee71e07fcf68d5c02256ff0fa Cheers, -- Carlo Caione ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Please pull fsl-qoriq master
On Fri, Jul 27, 2018 at 03:46:36PM +, York Sun wrote: > Tom, > > The following changes since commit 08fcdd332f3d6bc7842e21a97c80789d9233e147: > > Makefile: Fix 'clean' target (2018-07-26 07:12:31 -0400) > > are available in the git repository at: > > git://git.denx.de/u-boot-fsl-qoriq.git > > for you to fetch changes up to 86b840b78d0eba652f65841a870d232ab743612e: > > drivers/ddr/fsl: fix '__hwconfig without a buffer' messages > (2018-07-26 11:54:00 -0700) > > Travis build log is here > https://travis-ci.org/yorksun/u-boot/builds/408648511. I see one > compiling warning caused by recent commit 68c7025d99db. > > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
