Re: [U-Boot] AM335X: Set fdt_high for AM335X devices to enable booting with Device Tree

[Hiremath, Vaibhav]

On Sat, Jan 26, 2013 at 03:40:51, Rini, Tom wrote:
> On Tue, Sep 18, 2012 at 09:26:05AM -, hvaib...@ti.com wrote:
> 
> > For AM335X boards, such as the EVM and Bone Linux kernel fails to
> > locate the device tree blob on boot. The reason being is that
> > u-boot is copying the DT blob to the upper part of RAM when booting
> > the kernel and the kernel is unable to access the blob.
> > By setting the fdt_high variable to 0x (to prevent the copy)
> > the kernel is able to locate the DT blob and boot.
> > 
> > This patch is tested on BeagleBone platform.
> > 
> > Signed-off-by: Vaibhav Hiremath 
> > Cc: Tom Rini 
> 
> So, a "funny" thing happened along the way since this patch.  The newest
> revision of the EVM includes 1GB of DDR and thus we do now need this
> patch.  Applied to u-boot-ti/master, thanks!
> 

Ohhh Great, Thanks for pulling in this patch Tom.

Thanks,
Vaibhav

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] ARM: omap3: Set SPL stack size to 8KB, image to 54KB.

[Hiremath, Vaibhav]

On Tue, May 08, 2012 at 23:45:19, Rini, Tom wrote:
> On 05/08/2012 10:40 AM, Hiremath, Vaibhav wrote:
> > On Tue, May 08, 2012 at 22:59:31, Rini, Tom wrote:
> >> With older toolchains it is possible to not fit entirely into the 45KB
> >> that we had assigned to SPL.  Adjust to allow for 8KB of stack (which
> >> should be more than required) and 54KB of text/data.
> >>
> >
> > Tom,
> >
> > Can you provide more details on why 45Kb is not sufficient for SPL?
> 
> A combination of toolchains and enabled options will break this limit 
> (for example, beagle is size-broken once we enable i2c to whack the 
> twl4030 with ELDK4.2).  Rather than giving just one more KB to fix the 
> problem today, but run into it tomorrow, I'm pushing towards the biggest 
> split we can use.
> 

Exactly, I understand the need here. Can you please update the commit 
description with above details, the original patch commit description only 
talks about toolchain, but it is not only the toolchain, right?

Else looks ok to me.

Acked-by: Vaibhav Hiremath 

Thanks,
Vaibhav

> > You may have done some memory analysis on this; can you share that here?
> > Also, do we know how much ROM code is using out of 64KB of RAM?
> 
> We know that ROM loads us to 0x40200800 and we're allowed from there to 
> the end of SRAM to do as we please.  This is just adjusting the split 
> SPL makes into text+data and stack.
> 
> -- 
> Tom
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] ARM: omap3: Set SPL stack size to 8KB, image to 54KB.

[Hiremath, Vaibhav]

On Tue, May 08, 2012 at 22:59:31, Rini, Tom wrote:
> With older toolchains it is possible to not fit entirely into the 45KB
> that we had assigned to SPL.  Adjust to allow for 8KB of stack (which
> should be more than required) and 54KB of text/data.
> 

Tom,

Can you provide more details on why 45Kb is not sufficient for SPL?
You may have done some memory analysis on this; can you share that here? 
Also, do we know how much ROM code is using out of 64KB of RAM?

Thanks,
Vaibhav


> Cc: Vaibhav Hiremath 
> Cc: Nagendra T S 
> Cc: Thomas Weber 
> Cc: Ilya Yanok 
> Cc: Steve Sakoman 
> Cc: Stefano Babic 
> Signed-off-by: Tom Rini 
> ---
>  doc/SPL/README.omap3   |4 ++--
>  include/configs/am3517_crane.h |2 +-
>  include/configs/am3517_evm.h   |2 +-
>  include/configs/devkit8000.h   |2 +-
>  include/configs/mcx.h  |2 +-
>  include/configs/omap3_beagle.h |2 +-
>  include/configs/omap3_evm_common.h |2 +-
>  include/configs/omap3_overo.h  |2 +-
>  include/configs/tam3517-common.h   |2 +-
>  include/configs/tricorder.h|2 +-
>  10 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/doc/SPL/README.omap3 b/doc/SPL/README.omap3
> index cc5d5c0..a543e65 100644
> --- a/doc/SPL/README.omap3
> +++ b/doc/SPL/README.omap3
> @@ -34,14 +34,14 @@ DDR1: 0x8000 - 0xBFFF
>  
>  Option 1 (SPL only):
>  0x40200800 - 0x4020BBFF: Area for SPL text, data and rodata
> -0x4020BC00 - 0x4020FFFC: Area for the SPL stack.
> +0x4020E000 - 0x4020FFFC: Area for the SPL stack.
>  0x8000 - 0x8007: Area for the SPL BSS.
>  0x8010: CONFIG_SYS_TEXT_BASE of U-Boot
>  0x80208000 - 0x80307FFF: malloc() pool available to SPL.
>  
>  Option 2 (SPL or X-Loader):
>  0x40200800 - 0x4020BBFF: Area for SPL text, data and rodata
> -0x4020BC00 - 0x4020FFFC: Area for the SPL stack.
> +0x4020E000 - 0x4020FFFC: Area for the SPL stack.
>  0x80008000: CONFIG_SYS_TEXT_BASE of U-Boot
>  0x8700 - 0x8707: Area for the SPL BSS.
>  0x8708 - 0x870F: malloc() pool available to SPL.
> diff --git a/include/configs/am3517_crane.h b/include/configs/am3517_crane.h
> index b0dd2f0..9843eae 100644
> --- a/include/configs/am3517_crane.h
> +++ b/include/configs/am3517_crane.h
> @@ -326,7 +326,7 @@
>  #define CONFIG_SPL
>  #define CONFIG_SPL_NAND_SIMPLE
>  #define CONFIG_SPL_TEXT_BASE 0x40200800
> -#define CONFIG_SPL_MAX_SIZE  (45 * 1024)
> +#define CONFIG_SPL_MAX_SIZE  (54 * 1024) /* 8 KB for stack */
>  #define CONFIG_SPL_STACK LOW_LEVEL_SRAM_STACK
>  
>  #define CONFIG_SPL_BSS_START_ADDR0x8000
> diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
> index b5f75d1..49e665d 100644
> --- a/include/configs/am3517_evm.h
> +++ b/include/configs/am3517_evm.h
> @@ -326,7 +326,7 @@
>  #define CONFIG_SPL
>  #define CONFIG_SPL_NAND_SIMPLE
>  #define CONFIG_SPL_TEXT_BASE 0x40200800
> -#define CONFIG_SPL_MAX_SIZE  (45 * 1024)
> +#define CONFIG_SPL_MAX_SIZE  (54 * 1024) /* 8 KB for stack */
>  #define CONFIG_SPL_STACK LOW_LEVEL_SRAM_STACK
>  
>  #define CONFIG_SPL_BSS_START_ADDR0x8000
> diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
> index eb7c376..248a5b2 100644
> --- a/include/configs/devkit8000.h
> +++ b/include/configs/devkit8000.h
> @@ -324,7 +324,7 @@
>  #define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR 0x300 /* address 0x6 */
>  
>  #define CONFIG_SPL_TEXT_BASE 0x4020 /*CONFIG_SYS_SRAM_START*/
> -#define CONFIG_SPL_MAX_SIZE  0xB400  /* 45 K */
> +#define CONFIG_SPL_MAX_SIZE  (54 * 1024) /* 8 KB for stack */
>  #define CONFIG_SPL_STACK LOW_LEVEL_SRAM_STACK
>  
>  #define CONFIG_SPL_BSS_START_ADDR   0x8500 /* leave space for 
> bootargs*/
> diff --git a/include/configs/mcx.h b/include/configs/mcx.h
> index 1315c3c..fd6a435 100644
> --- a/include/configs/mcx.h
> +++ b/include/configs/mcx.h
> @@ -327,7 +327,7 @@
>  #define CONFIG_SPL_LDSCRIPT  "$(CPUDIR)/omap-common/u-boot-spl.lds"
>  
>  #define CONFIG_SPL_TEXT_BASE 0x4020 /*CONFIG_SYS_SRAM_START*/
> -#define CONFIG_SPL_MAX_SIZE  (45 << 10)
> +#define CONFIG_SPL_MAX_SIZE  (54 * 1024) /* 8 KB for stack */
>  #define CONFIG_SPL_STACK LOW_LEVEL_SRAM_STACK
>  
>  /* move malloc and bss high to prevent clashing with the main image */
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index ddeb414..6bdc2c3 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -399,7 +399,7 @@
>  #define CONFIG_SPL
>  #define CONFIG_SPL_NAND_SIMPLE
>  #define CONFIG_SPL_TEXT_BASE 0x40200800
> -#define CONFIG_SPL_MAX_SIZE  (45 * 1024)
> +#define CONFIG_SPL_MAX_SIZE  (54 * 1024) /* 8 KB for stack */
>  #define CONFIG_SPL_STACK LOW_LEVEL_SRAM_STACK
>  
>  #define CONFIG_SPL_B

Re: [U-Boot] [PATCH 3/8] AM3517: Add NOR Flash boot mode Support

[Hiremath, Vaibhav]

> -Original Message-
> From: Igor Grinberg [mailto:grinb...@compulab.co.il]
> Sent: Thursday, December 08, 2011 7:18 PM
> To: Hiremath, Vaibhav
> Cc: Rini, Tom; u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 3/8] AM3517: Add NOR Flash boot mode Support
> 
> Hi Vaibhav,
> 
> On 12/08/11 13:11, Hiremath, Vaibhav wrote:
> >
> >> -Original Message-
> >> From: Igor Grinberg [mailto:grinb...@compulab.co.il]
> >> Sent: Wednesday, December 07, 2011 7:55 PM
> >> To: Rini, Tom
> >> Cc: u-boot@lists.denx.de; Hiremath, Vaibhav
> >> Subject: Re: [U-Boot] [PATCH 3/8] AM3517: Add NOR Flash boot mode
> Support
> >>
> >> Hi Tom,
> >>
> >> On 12/06/11 17:49, Tom Rini wrote:
> >>> From: Vaibhav Hiremath 
> >>>
> >>> Please note that NOR Flash is located on Application board and
> requires
> >>> hardware modification to get NOR boot mode working.
> >>>
> >>> NOR Flash boot mode configuration -
> >>>
> >>> - From baseboard remove R235 resistor.
> >>>   - Set switch S11.3 position to "ON"
> >>>   - Set S7 switch position to
> >>>1  2   3   4   5
> >>>-
> >>>   on off off off off
> >>>
> >>> Please note that, once you remove R235 resistor from the baseboard,
> you
> >>> will not be able to boot from NAND without Application board.
> >>> The GPMC_nCS0 is now routed through Application board.
> >>>
> >>> Please note that,  >>> work with NOR Flash due to HW issue.
> >>>
> >>> Signed-off-by: Vaibhav Hiremath 
> >>> Signed-off-by: Tom Rini 
> >>> ---
> >>>  arch/arm/cpu/armv7/omap3/mem.c|   61
> >> +++-
> >>>  arch/arm/include/asm/arch-omap3/mem.h |   15 +---
> >>>  board/logicpd/am3517evm/am3517evm.h   |2 +-
> >>>  3 files changed, 61 insertions(+), 17 deletions(-)
> >>>
> >>> diff --git a/arch/arm/cpu/armv7/omap3/mem.c
> >> b/arch/arm/cpu/armv7/omap3/mem.c
> >>> index 4a8c025..4ad3d12 100644
> >>> --- a/arch/arm/cpu/armv7/omap3/mem.c
> >>> +++ b/arch/arm/cpu/armv7/omap3/mem.c
> >>> @@ -51,6 +51,17 @@ static const u32 gpmc_m_nand[GPMC_MAX_REG] = {
> >>>
> >>>  #endif
> >>>
> >>> +#if defined (CONFIG_CMD_FLASH)
> >>> +static const u32 gpmc_nor[GPMC_MAX_REG] = {
> >>> + STNOR_GPMC_CONFIG1,
> >>> + STNOR_GPMC_CONFIG2,
> >>> + STNOR_GPMC_CONFIG3,
> >>> + STNOR_GPMC_CONFIG4,
> >>> + STNOR_GPMC_CONFIG5,
> >>> + STNOR_GPMC_CONFIG6, 0
> >>> +};
> >>> +#endif
> >>
> >> This does not seem to be the right place for these settings...
> >> I think those must be board specific.
> >>
> > [Hiremath, Vaibhav] I think, yes this information is board specific,
> since NOR flash is mounted on board.
> >
> > Actually we have followed existing NAND/OneNAND implementation here, and
> that's where we have this here.
> 
> Yeah, I know you did.
> The thing is we can continue adding crap code, just because
> it was like that before, but that is not a good argument.
> Instead, IMO, if you need to touch that code, make an effort and
> clean this at least a bit and then add a clean version of the code.
> I think it worked like this at least last year.
> 
> > Also note that, in case of OMAP3/AM37x we have POP package where
> NAND/OneNAND part is fixed, so it makes sense to bring here.
> 
> No, not really, because, there are other packages besides POP,
> and information on them should come from the board.
> 
> What can be done is, move the NOR information to a separate function/file
> so it can be reused by all boards, but the board gets to decide
> whether to use this or may be some other setting.
> 
> Also, are you certain that POP package will always have the same
> parts on top of the SoC, because the pin out can stay the same, but
> timing information can vary and that's where you need that separation.
> 
Fair enough,

I was just trying to say, this could be the reason behind why this definitions 
kept here in this file.

Thanks,
Vaibhav

> >
> >>> +
> >>>  #if defined(CONFIG_CMD_ONENAND)
> >>>  static const u32 gpmc_onenand[GPMC_MAX_REG] = {
> >>>   ONENAND_GPMC_CONFIG1,
> >>> @@ -118,21 +129,34 @@ void enable_gpmc_

Re: [U-Boot] [PATCH 3/8] AM3517: Add NOR Flash boot mode Support

[Hiremath, Vaibhav]

> -Original Message-
> From: Igor Grinberg [mailto:grinb...@compulab.co.il]
> Sent: Wednesday, December 07, 2011 7:55 PM
> To: Rini, Tom
> Cc: u-boot@lists.denx.de; Hiremath, Vaibhav
> Subject: Re: [U-Boot] [PATCH 3/8] AM3517: Add NOR Flash boot mode Support
> 
> Hi Tom,
> 
> On 12/06/11 17:49, Tom Rini wrote:
> > From: Vaibhav Hiremath 
> >
> > Please note that NOR Flash is located on Application board and requires
> > hardware modification to get NOR boot mode working.
> >
> > NOR Flash boot mode configuration -
> >
> > - From baseboard remove R235 resistor.
> > - Set switch S11.3 position to "ON"
> > - Set S7 switch position to
> >  1  2   3   4   5
> >  -
> > on off off off off
> >
> > Please note that, once you remove R235 resistor from the baseboard, you
> > will not be able to boot from NAND without Application board.
> > The GPMC_nCS0 is now routed through Application board.
> >
> > Please note that,  > work with NOR Flash due to HW issue.
> >
> > Signed-off-by: Vaibhav Hiremath 
> > Signed-off-by: Tom Rini 
> > ---
> >  arch/arm/cpu/armv7/omap3/mem.c|   61
> +++-
> >  arch/arm/include/asm/arch-omap3/mem.h |   15 +---
> >  board/logicpd/am3517evm/am3517evm.h   |2 +-
> >  3 files changed, 61 insertions(+), 17 deletions(-)
> >
> > diff --git a/arch/arm/cpu/armv7/omap3/mem.c
> b/arch/arm/cpu/armv7/omap3/mem.c
> > index 4a8c025..4ad3d12 100644
> > --- a/arch/arm/cpu/armv7/omap3/mem.c
> > +++ b/arch/arm/cpu/armv7/omap3/mem.c
> > @@ -51,6 +51,17 @@ static const u32 gpmc_m_nand[GPMC_MAX_REG] = {
> >
> >  #endif
> >
> > +#if defined (CONFIG_CMD_FLASH)
> > +static const u32 gpmc_nor[GPMC_MAX_REG] = {
> > +   STNOR_GPMC_CONFIG1,
> > +   STNOR_GPMC_CONFIG2,
> > +   STNOR_GPMC_CONFIG3,
> > +   STNOR_GPMC_CONFIG4,
> > +   STNOR_GPMC_CONFIG5,
> > +   STNOR_GPMC_CONFIG6, 0
> > +};
> > +#endif
> 
> This does not seem to be the right place for these settings...
> I think those must be board specific.
> 
[Hiremath, Vaibhav] I think, yes this information is board specific, since NOR 
flash is mounted on board.

Actually we have followed existing NAND/OneNAND implementation here, and that's 
where we have this here.
Also note that, in case of OMAP3/AM37x we have POP package where NAND/OneNAND 
part is fixed, so it makes sense to bring here.

> > +
> >  #if defined(CONFIG_CMD_ONENAND)
> >  static const u32 gpmc_onenand[GPMC_MAX_REG] = {
> > ONENAND_GPMC_CONFIG1,
> > @@ -118,21 +129,34 @@ void enable_gpmc_cs_config(const u32 *gpmc_config,
> struct gpmc_cs *cs, u32 base,
> > sdelay(2000);
> >  }
> >
> > -/*
> > +/*
> >   * gpmc_init(): init gpmc bus
> > - * Init GPMC for x16, MuxMode (SDRAM in x32).
> > - * This code can only be executed from SRAM or SDRAM.
> > - */
> > + * Init GPMC for x16, MuxMode (SDRAM in x32).  This code can only be
> > + * executed from SRAM or SDRAM.  In the common case, we will disable
> > + * and then configure chip select 0 for our needs (NAND or OneNAND).
> > + * However, on the AM3517 EVM the way that NOR can be exposed requires
> us
> > + * to rethink this.  When NOR is enabled, it will be chip select 0 if
> > + * we are booting from NOR or chip select 2 otherwise.  This requires
> us
> > + * to check the value we get from the SYSBOOT pins.
> 
> All the above looks like board specific...
> 
> > + */
> >  void gpmc_init(void)
> >  {
> > /* putting a blanket check on GPMC based on ZeBu for now */
> > gpmc_cfg = (struct gpmc *)GPMC_BASE;
> > -#if defined(CONFIG_CMD_NAND) || defined(CONFIG_CMD_ONENAND)
> > +#if defined(CONFIG_CMD_NAND) || defined(CONFIG_CMD_ONENAND) || \
> > +   (defined(CONFIG_OMAP3_AM3517EVM) &&
> defined(CONFIG_SYS_HAS_NORFLASH))
> > const u32 *gpmc_config = NULL;
> > u32 base = 0;
> > -   u32 size = 0;
> > +   u32 sz = 0;
> >  #endif
> > u32 config = 0;
> > +   u32 nor_boot = 0;
> > +
> > +#if defined(CONFIG_OMAP3_AM3517EVM) && defined(CONFIG_SYS_HAS_NORFLASH)
> > +   /* 0xD means NOR boot on AM35x */
> > +   if (get_boot_type() == 0xD)
> > +   nor_boot = 1;
> > +#endif
> >
> > /* global settings */
> > writel(0, &gpmc_cfg->irqenable); /* isr's sources masked *

Re: [U-Boot] [PATCH] OMAP3/4: Increase console I/O buffer size

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Monday, August 01, 2011 7:49 PM
> To: U-Boot@lists.denx.de
> Cc: Paulraj, Sandeep; albert.u.b...@aribaud.net; Hiremath, Vaibhav
> Subject: [PATCH] OMAP3/4: Increase console I/O buffer size
> 
> From: Vaibhav Hiremath 
> 
> Increase the console I/O buffer size (SYS_CBSIZE) to 512 (from 256)
> required especially for bootargs string, as multiple options
> (e.g Video settings) are passed to the kernel through bootargs.
> 
> Signed-off-by: Vaibhav Hiremath 
> ---
>  include/configs/omap3_beagle.h  |2 +-
>  include/configs/omap3_evm.h |2 +-
>  include/configs/omap3_overo.h   |2 +-
>  include/configs/omap3_pandora.h |2 +-
>  include/configs/omap3_sdp3430.h |2 +-
>  include/configs/omap3_zoom1.h   |2 +-
>  include/configs/omap3_zoom2.h   |2 +-
>  include/configs/omap4_panda.h   |2 +-
>  include/configs/omap4_sdp4430.h |    2 +-
>  9 files changed, 9 insertions(+), 9 deletions(-)
> 
[Hiremath, Vaibhav] Sandeep & Albert,

I have not received any comments on this and they all are trivial patches; so 
can you merge these patches?

List of patches -

- [PATCH] OMAP3/4: Increase console I/O buffer size
- [PATCH] omap3:clock: check cpu_family before enabling clks for IVA & 
CAM
- [PATCH] omap3:clock: configure GFX clock to 200MHz for AM/DM37x
- [PATCH] omap3evm: Use generic MMC driver
- [PATCH] am3517evm: Use generic MMC driver


Thanks,
Vaibhav

> diff --git a/include/configs/omap3_beagle.h
> b/include/configs/omap3_beagle.h
> index 9fd80ed..14586eb 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -262,7 +262,7 @@
>  #define CONFIG_SYS_HUSH_PARSER   /* use "hush" command parser */
>  #define CONFIG_SYS_PROMPT_HUSH_PS2   "> "
>  #define CONFIG_SYS_PROMPT"OMAP3 beagleboard.org # "
> -#define CONFIG_SYS_CBSIZE256 /* Console I/O Buffer Size */
> +#define CONFIG_SYS_CBSIZE512 /* Console I/O Buffer Size */
>  /* Print Buffer Size */
>  #define CONFIG_SYS_PBSIZE(CONFIG_SYS_CBSIZE + \
>   sizeof(CONFIG_SYS_PROMPT) + 16)
> diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
> index 13a4fbf..ed230b6 100644
> --- a/include/configs/omap3_evm.h
> +++ b/include/configs/omap3_evm.h
> @@ -238,7 +238,7 @@
>  #define CONFIG_SYS_HUSH_PARSER   /* use "hush" command parser */
>  #define CONFIG_SYS_PROMPT_HUSH_PS2   "> "
>  #define CONFIG_SYS_PROMPT"OMAP3_EVM # "
> -#define CONFIG_SYS_CBSIZE256 /* Console I/O Buffer Size */
> +#define CONFIG_SYS_CBSIZE512 /* Console I/O Buffer Size */
>  /* Print Buffer Size */
>  #define CONFIG_SYS_PBSIZE(CONFIG_SYS_CBSIZE + \
>   sizeof(CONFIG_SYS_PROMPT) + 16)
> diff --git a/include/configs/omap3_overo.h b/include/configs/omap3_overo.h
> index 242b317..8cf67fd 100644
> --- a/include/configs/omap3_overo.h
> +++ b/include/configs/omap3_overo.h
> @@ -214,7 +214,7 @@
>  #define CONFIG_SYS_HUSH_PARSER   /* use "hush" command parser */
>  #define CONFIG_SYS_PROMPT_HUSH_PS2   "> "
>  #define CONFIG_SYS_PROMPT"Overo # "
> -#define CONFIG_SYS_CBSIZE256 /* Console I/O Buffer Size */
> +#define CONFIG_SYS_CBSIZE512 /* Console I/O Buffer Size */
>  /* Print Buffer Size */
>  #define CONFIG_SYS_PBSIZE(CONFIG_SYS_CBSIZE + \
>   sizeof(CONFIG_SYS_PROMPT) + 16)
> diff --git a/include/configs/omap3_pandora.h
> b/include/configs/omap3_pandora.h
> index 39c87a8..88f421b 100644
> --- a/include/configs/omap3_pandora.h
> +++ b/include/configs/omap3_pandora.h
> @@ -197,7 +197,7 @@
>  #define CONFIG_SYS_HUSH_PARSER   /* use "hush" command parser */
>  #define CONFIG_SYS_PROMPT_HUSH_PS2   "> "
>  #define CONFIG_SYS_PROMPT"Pandora # "
> -#define CONFIG_SYS_CBSIZE256 /* Console I/O Buffer Size */
> +#define CONFIG_SYS_CBSIZE512 /* Console I/O Buffer Size */
>  /* Print Buffer Size */
>  #define CONFIG_SYS_PBSIZE(CONFIG_SYS_CBSIZE + \
>   sizeof(CONFIG_SYS_PROMPT) + 16)
> diff --git a/include/configs/omap3_sdp3430.h
> b/include/configs/omap3_sdp3430.h
> index 55bbcd4..f957354 100644
> --- a/include/configs/omap3_sdp3430.h
> +++ b/include/configs/omap3_sdp3430.h
> @@ -270,7 +270,7 @@
>  #define CONFIG_SYS_H

Re: [U-Boot] Build error in davinci_emac driver

[Hiremath, Vaibhav]

> -Original Message-
> From: Paulraj, Sandeep
> Sent: Tuesday, August 02, 2011 9:19 PM
> To: Hiremath, Vaibhav
> Cc: U-Boot@lists.denx.de
> Subject: RE: Build error in davinci_emac driver
> 
> >
> > Sandeep,
> >
> > Few of your commits will not allow using davinci_emac driver for non-
> > davinci family of devices. For example,
> 
> This has happened in the kernel also. 
[Hiremath, Vaibhav] I am not saying kernel is 100% clean, there could be issues 
there as well.

> How is a developer supposed to know
> which new devices are in the pipeline.
> 
[Hiremath, Vaibhav] There is NO need to know about this, we can very well 
implement/design considering other devices. 

> Infact we recently had a case in the kernel NAND driver, where the same IP
> was being used in a DSP. Even after so much cleanup in the Davinci NAND
> driver we figured that the driver was specific to devices with an ARM and
> so I had to submit a patch which would result in it working on devices
> with only a DSP.
> 
[Hiremath, Vaibhav] I am not sure about this; if it is the case then definitely 
it required fix/cleanup.

> >
> > commit 840f8923a076b02b983cf58c9466b5bdf5957133
> > Author: Sandeep Paulraj 
> > Date:   Tue Dec 28 15:43:16 2010 -0500
> >
> > DaVinci DM6467: Added ET1011C (LSI) PHY support
> >
> > This adds new file,
> > +COBJS-$(CONFIG_DRIVER_TI_EMAC) += lxt972.o dp83848.o et1011c.o
> >
> > We will have to clean up this implementation, let me submit all other
> > trivial patches first then I will come to this.
> 
> Improvements are always welcome.
> You can submit a patch to mailing list.
> 
[Hiremath, Vaibhav] Thanks. Will do the same.

Sandeep,
Have you reviewed other patches which I have submitted to the list? If not can 
you review and merge it for your next pull request? 

Thanks,
Vaibhav
> --Sandeep

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Build error in davinci_emac driver

[Hiremath, Vaibhav]

Sandeep,

Few of your commits will not allow using davinci_emac driver for non-davinci 
family of devices. For example,

commit 840f8923a076b02b983cf58c9466b5bdf5957133
Author: Sandeep Paulraj 
Date:   Tue Dec 28 15:43:16 2010 -0500

DaVinci DM6467: Added ET1011C (LSI) PHY support

This adds new file,
+COBJS-$(CONFIG_DRIVER_TI_EMAC) += lxt972.o dp83848.o et1011c.o

And also modifies the davinci_emac.x file for new API added in et1011c.c.


Ideally all the platform specific drivers should be part of some callback API 
and should not be hardcoded to driver file.

We will have to clean up this implementation, let me submit all other trivial 
patches first then I will come to this.

Thanks,
Vaibhav

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Build failure for ARM devices

[Hiremath, Vaibhav]

> -Original Message-
> From: Heiko Schocher [mailto:h...@denx.de]
> Sent: Monday, August 01, 2011 3:09 PM
> To: Hiremath, Vaibhav
> Cc: U-Boot@lists.denx.de
> Subject: Re: [U-Boot] Build failure for ARM devices
> 
> Hello Vaibhav,
> 
> Hiremath, Vaibhav wrote:
> > Hi,
> >
> > Today when I have rebased all my patches to latest denx/master, I have
> observed that the following commit has broken the build for ARM family of
> devices (in my case it's OMAP3). I have patch fixing this issue, which I
> will submit shortly.
> 
> see fix from Wolfgang here:
> 
> http://patchwork.ozlabs.org/patch/107519/
> 
[Hiremath, Vaibhav] Hmmm ok.  Thanks for pointing to this. 

Thanks,
Vaibhav

> bye,
> Heiko
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Build failure for ARM devices

[Hiremath, Vaibhav]

Hi,

Today when I have rebased all my patches to latest denx/master, I have observed 
that the following commit has broken the build for ARM family of devices (in my 
case it's OMAP3). I have patch fixing this issue, which I will submit shortly.

Commit -
===
commit 84b5e8022ef62b68df360392a55c4fc2f2e568d7
Author: Wolfgang Denk 
Date:   Fri Jul 29 14:42:18 2011 +0200

Constify getenv(), setenv() and hash code functions

This is needed to get rid of build warnings like

main.c:311: warning: passing argument 2 of 'setenv' discards qualifiers 
from pointer target type

which result from commit 09c2e90 "unify version_string".

Signed-off-by: Wolfgang Denk 
Cc: Andreas Biemann 


Error log -
=

arm-none-linux-gnueabi-gcc -DDO_DEPS_ONLY \
-g  -Os   -fno-common -ffixed-r8 -msoft-float   -D__KERNEL__ 
-DCONFIG_SYS_TEXT_BASE=0x80008000 
-I/db/psp_git/users/a0393758/omap-uboot-denx/include -fno-builtin 
-ffreestanding -nostdinc -isystem 
/opt/codesourcery/2010q1-202/bin/../lib/gcc/arm-none-linux-gnueabi/4.4.1/include
 -pipe  -DCONFIG_ARM -D__ARM__ -marm  -mabi=aapcs-linux -mno-thumb-interwork 
-march=armv5 -Wall -Wstrict-prototypes -fno-stack-protector 
-Wno-format-nonliteral -Wno-format-security   \
-o lib/asm-offsets.s lib/asm-offsets.c -c -S
In file included from 
/db/psp_git/users/a0393758/omap-uboot-denx/include/common.h:276,
 from lib/asm-offsets.c:18:
/db/psp_git/users/a0393758/omap-uboot-denx/include/asm/u-boot-arm.h:66: error: 
conflicting types for 'setenv'
/db/psp_git/users/a0393758/omap-uboot-denx/include/common.h:271: note: previous 
declaration of 'setenv' was here
make: *** [lib/asm-offsets.s] Error 1


Thanks,
Vaibhav

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] am3517evm: change console device from ttyS2 to ttyO2

[Hiremath, Vaibhav]

> -Original Message-
> From: Yegor Yefremov [mailto:yegor_s...@visionsystems.de]
> Sent: Monday, July 18, 2011 3:48 PM
> To: Albert ARIBAUD
> Cc: u-boot@lists.denx.de; Hiremath, Vaibhav
> Subject: Re: [PATCH v2] am3517evm: change console device from ttyS2 to
> ttyO2
> 
> Am 18.07.2011 11:41, schrieb Albert ARIBAUD:
> > Le 18/07/2011 10:48, Yegor Yefremov a écrit :
> >>> From 74f884f3d76feda60d8fa1dff1f3fef8bd89acb1 Mon Sep 17 00:00:00 2001
> >> From: Yegor Yefremov
> >> Date: Mon, 18 Jul 2011 10:37:35 +0200
> >> Subject: [PATCH] am3517evm: change console device from ttyS2 to ttyO2
> >>
> >> the serial device names have been changed from ttySx to ttyOx, so the
> >> console device name should be also changed to support the latest kernel
> >> versions.
> >>
> >> Signed-off-by: Yegor Yefremov
> >> ---
> >>   include/configs/am3517_evm.h |2 +-
> >>   1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/include/configs/am3517_evm.h
> b/include/configs/am3517_evm.h
> >> index 80ad342..18aaadf 100644
> >> --- a/include/configs/am3517_evm.h
> >> +++ b/include/configs/am3517_evm.h
> >> @@ -190,7 +190,7 @@
> >>
> >>   #define CONFIG_EXTRA_ENV_SETTINGS \
> >>   "loadaddr=0x8200\0" \
> >> -"console=ttyS2,115200n8\0" \
> >> +"console=ttyO2,115200n8\0" \
> >>   "mmcargs=setenv bootargs console=${console} " \
> >>   "root=/dev/mmcblk0p2 rw " \
> >>   "rootfstype=ext3 rootwait\0" \
> >
> > Cc:ing board maintainer, Vaibhav Hiremath  according to
> MAINTAINERS, for ACK.NAK.
> >
> > (apologies: I should have done this already in reply to patch V1).
> 
> Could you apply the patch (v2) now?
> 
[Hiremath, Vaibhav] Acked-by: Vaibhav Hiremath 

Thanks,
Vaibhav

> Yegor

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] AM3517:Fix for ARM Relocation support

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Monday, November 29, 2010 9:52 PM
> To: u-boot@lists.denx.de
> Cc: alb...@aribaud.net; Paulraj, Sandeep; Hiremath, Vaibhav
> Subject: [PATCH] AM3517:Fix for ARM Relocation support
> 
> From: Vaibhav Hiremath 
> 
> Also change the CONFIG_SYS_TEXT_BASE to 0x80008000, required
> with relocation support. This is the load address for primary
> boot loader (x-loader).
> 
[Hiremath, Vaibhav] Albert, Denk and Sandeep,

I have tested this patch with Makefile change (remove sorting of $LIB) on 
AM3517EVM.

Thanks,
Vaibhav

> Signed-off-by: Vaibhav Hiremath 
> ---
>  board/logicpd/am3517evm/config.mk |2 +-
>  include/configs/am3517_evm.h  |6 ++
>  2 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/board/logicpd/am3517evm/config.mk
> b/board/logicpd/am3517evm/config.mk
> index 102d32b..71ec5d0 100644
> --- a/board/logicpd/am3517evm/config.mk
> +++ b/board/logicpd/am3517evm/config.mk
> @@ -27,4 +27,4 @@
>  # (mem base + reserved)
> 
>  # For use with external or internal boots.
> -CONFIG_SYS_TEXT_BASE = 0x80e8
> +CONFIG_SYS_TEXT_BASE = 0x80008000
> diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
> index 9a9ba88..3dda1e9 100644
> --- a/include/configs/am3517_evm.h
> +++ b/include/configs/am3517_evm.h
> @@ -330,4 +330,10 @@ extern unsigned int boot_flash_sec;
>  extern unsigned int boot_flash_type;
>  #endif
> 
> +#define CONFIG_SYS_SDRAM_BASEPHYS_SDRAM_1
> +#define CONFIG_SYS_INIT_RAM_ADDR 0x4020f800
> +#define CONFIG_SYS_INIT_RAM_SIZE 0x800
> +#define CONFIG_SYS_INIT_SP_ADDR  (CONFIG_SYS_INIT_RAM_ADDR + \
> +  CONFIG_SYS_INIT_RAM_SIZE - \
> +  GENERATED_GBL_DATA_SIZE)
>  #endif /* __CONFIG_H */
> --
> 1.6.2.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] v2010-rc2: OMAP3 broken

[Hiremath, Vaibhav]

> -Original Message-
> From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
> On Behalf Of Hiremath, Vaibhav
> Sent: Monday, November 29, 2010 6:50 PM
> To: Wolfgang Denk; u-boot@lists.denx.de
> Subject: Re: [U-Boot] v2010-rc2: OMAP3 broken
> 
> 
> > -Original Message-
> > From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
> > On Behalf Of Wolfgang Denk
> > Sent: Monday, November 29, 2010 6:19 PM
> > To: u-boot@lists.denx.de
> > Subject: [U-Boot] v2010-rc2: OMAP3 broken
> >
> > Hi,
> >
> > it seems that commit 566d49a3f has broken OMAP3 - at least beagle and
> > devkit8000 hang in or after relocation.
> >
> [Hiremath, Vaibhav] AM3517 also used to hangs in relocate_code function.
> 
> 
> 
> > The culprit is this the "$(sort $(LIBS)) in Makefile, i. e. the
> > following change will unbreak the boards:
> >
> > @@ -263,7 +263,7 @@ ifeq ($(SOC),s5pc2xx)
> >  LIBS += $(CPUDIR)/s5p-common/libs5p-common.o
> >  endif
> >
> > -LIBS := $(addprefix $(obj),$(sort $(LIBS)))
> > +LIBS := $(addprefix $(obj),$(LIBS))
> >  .PHONY : $(LIBS) $(TIMESTAMP_FILE) $(VERSION_FILE)
> >
> >  LIBBOARD = board/$(BOARDDIR)/lib$(BOARD).o
> >
> >
> [Hiremath, Vaibhav] The above patch works for me as well.
> 
> > Unfortunately we need the sort to avoild duplicate listing of libs /
> > objects on PowerPC.  And I don;t understand yet how this change can
> > cause such an affect.
> >
> > Any help welcome.
> >
> [Hiremath, Vaibhav] I can put my debug observations here,
> 
> 
> The system is hanging at
> 
> fixrel:
> /* relative fix: increase location by offset */
> ldr r1, [r0]
> 
[Hiremath, Vaibhav] pasting error, the actual place is 

fixnext:
str r1, [r0]

Thanks,
Vaibhav

> Here the value of r0 is relocation offset and not an address.
> 
> fixloop:
> ldr r0, [r2]/* r0 <- location to fix up, IN FLASH! */
> add r0, r0, r9  /* r0 <- location to fix up in RAM */
> 
> In the above two instructions, load from [r2] is coming as 0, causing
> reference to invalid address (relocation offset).
> 
> After applying your patch, the value from above load instruction comes as
> 0x80008020, which further gets added to offset (valid address).
> 
> 
> I hope this might give you some pointers, and I am not an expert on
> makefile, so not sure about relation between library sort and above
> finding.
> 
> Thanks,
> Vaibhav
> > Best regards,
> >
> > Wolfgang Denk
> >
> > --
> > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> > It seems intuitively obvious to me, which  means  that  it  might  be
> > wrong. -- Chris Torek
> > ___
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] v2010-rc2: OMAP3 broken

[Hiremath, Vaibhav]

> -Original Message-
> From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
> On Behalf Of Wolfgang Denk
> Sent: Monday, November 29, 2010 6:19 PM
> To: u-boot@lists.denx.de
> Subject: [U-Boot] v2010-rc2: OMAP3 broken
> 
> Hi,
> 
> it seems that commit 566d49a3f has broken OMAP3 - at least beagle and
> devkit8000 hang in or after relocation.
> 
[Hiremath, Vaibhav] AM3517 also used to hangs in relocate_code function.



> The culprit is this the "$(sort $(LIBS)) in Makefile, i. e. the
> following change will unbreak the boards:
> 
> @@ -263,7 +263,7 @@ ifeq ($(SOC),s5pc2xx)
>  LIBS += $(CPUDIR)/s5p-common/libs5p-common.o
>  endif
> 
> -LIBS := $(addprefix $(obj),$(sort $(LIBS)))
> +LIBS := $(addprefix $(obj),$(LIBS))
>  .PHONY : $(LIBS) $(TIMESTAMP_FILE) $(VERSION_FILE)
> 
>  LIBBOARD = board/$(BOARDDIR)/lib$(BOARD).o
> 
> 
[Hiremath, Vaibhav] The above patch works for me as well.

> Unfortunately we need the sort to avoild duplicate listing of libs /
> objects on PowerPC.  And I don;t understand yet how this change can
> cause such an affect.
> 
> Any help welcome.
> 
[Hiremath, Vaibhav] I can put my debug observations here,


The system is hanging at 

fixrel:
/* relative fix: increase location by offset */
ldr r1, [r0]

Here the value of r0 is relocation offset and not an address.

fixloop:
ldr r0, [r2]/* r0 <- location to fix up, IN FLASH! */
add r0, r0, r9  /* r0 <- location to fix up in RAM */

In the above two instructions, load from [r2] is coming as 0, causing reference 
to invalid address (relocation offset).

After applying your patch, the value from above load instruction comes as 
0x80008020, which further gets added to offset (valid address).


I hope this might give you some pointers, and I am not an expert on makefile, 
so not sure about relation between library sort and above finding.

Thanks,
Vaibhav
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> It seems intuitively obvious to me, which  means  that  it  might  be
> wrong. -- Chris Torek
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] denx/master is not building for OMAP3 platforms except Beagle

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Monday, October 04, 2010 12:08 AM
> To: Hiremath, Vaibhav
> Cc: Albert ARIBAUD; u-boot@lists.denx.de
> Subject: Re: [U-Boot] denx/master is not building for OMAP3 platforms
> except Beagle
> 
> Dear "Hiremath, Vaibhav",
> 
> In message <19f8576c6e063c45be387c64729e739404aa21c...@dbde02.ent.ti.com>
> you wrote:
> >
> > > Note that adding the definition may not be sufficient to get
> relocation
> > > working.
> > >
> > [Hiremath, Vaibhav] But atleast it will make code to compile cleanly. I
> feel,
> > at any cost we should not add such patches which will break compilation,
> >  the code should build always.
> 
> If the code compiles without problems, but then fails to run, the
> situation would be only worse.
> 
[Hiremath, Vaibhav] I agree that the situation in both the case is going to be 
only worst, but I feel we should not merge the patches which breaks other 
platforms.

Anyway I will test this for AM3517, OMAP3EVM and submit the patch shortly.

Thanks,
Vaibhav

> It is MUCH BETTER to roar a clear and unmistakable error message into
> the face of the user so everybody gets aware that some work needs to
> be done to fix these boards rather than to hush up the problems, in
> which case nobody would do anything, and a much bigger turmoil would
> start when the feature removel time comes and all these broken boards
> get removed from the tree,
> 
[Hiremath, Vaibhav] I 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> Was heißt Windows auf Indianisch? - "Weißer  Mann,  der  auf  Sanduhr
> wartet!"
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] denx/master is not building for OMAP3 platforms except Beagle

[Hiremath, Vaibhav]

> -Original Message-
> From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
> On Behalf Of Albert ARIBAUD
> Sent: Sunday, October 03, 2010 4:37 PM
> To: u-boot@lists.denx.de
> Subject: Re: [U-Boot] denx/master is not building for OMAP3 platforms
> except Beagle
> 
> Le 03/10/2010 12:50, Hiremath, Vaibhav a écrit :
> > Hi All,
> >
> > I think the current denx/matser is broken and is not building up for
> OMAP3 platforms except Beagle board.
> >
> > The error message on build is -
> >
> > board.c: In function '__dram_init_banksize':
> > board.c:468: error: 'CONFIG_SYS_SDRAM_BASE' undeclared (first use in
> this function)
> > board.c:468: error: (Each undeclared identifier is reported only once
> > board.c:468: error: for each function it appears in.)
> > board.c: In function 'board_init_f':
> > board.c:514: error: 'CONFIG_SYS_INIT_SP_ADDR' undeclared (first use in
> this function)
> > board.c:547: error: 'CONFIG_SYS_SDRAM_BASE' undeclared (first use in
> this function)
> > make[1]: *** [board.o] Error 1
> > make[1]: Leaving directory `/home/devel/git-work/denx-
> uboot/arch/arm/lib'
> > make: *** [arch/arm/lib/libarm.a] Error 2
> >
> >
> > The root-cause is-
> >
> > +#undef CONFIG_SYS_ARM_WITHOUT_RELOC
> > +#define CONFIG_SYS_SDRAM_BASE   PHYS_SDRAM_1
> > +#define CONFIG_SYS_INIT_SP_ADDR (LOW_LEVEL_SRAM_STACK -
> CONFIG_SYS_GBL_DATA_SIZE)
> >
> >
> > The above definition is missing in all (zoom1, zoom2, evm, am3517evm,
> sdp3430, overo, Pandora) config files.
> >
> > Am I missing something here? Just wanted to cross-check before posting
> patch to the list.
> 
> This is due to the introduction of relocation on ARM platforms -- see
> Wolfgang's recent release announcement.
[Hiremath, Vaibhav] Yes that's correct. I am aware of that.

> 
> Note that adding the definition may not be sufficient to get relocation
> working.
>
[Hiremath, Vaibhav] But atleast it will make code to compile cleanly. I feel, 
at any cost we should not add such patches which will break compilation, the 
code should build always.

Thanks,
Vaibhav
 
> Amicalement,
> --
> Albert.
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] denx/master is not building for OMAP3 platforms except Beagle

[Hiremath, Vaibhav]

Hi All,

I think the current denx/matser is broken and is not building up for OMAP3 
platforms except Beagle board.

The error message on build is - 

board.c: In function '__dram_init_banksize':
board.c:468: error: 'CONFIG_SYS_SDRAM_BASE' undeclared (first use in this 
function)
board.c:468: error: (Each undeclared identifier is reported only once
board.c:468: error: for each function it appears in.)
board.c: In function 'board_init_f':
board.c:514: error: 'CONFIG_SYS_INIT_SP_ADDR' undeclared (first use in this 
function)
board.c:547: error: 'CONFIG_SYS_SDRAM_BASE' undeclared (first use in this 
function)
make[1]: *** [board.o] Error 1
make[1]: Leaving directory `/home/devel/git-work/denx-uboot/arch/arm/lib'
make: *** [arch/arm/lib/libarm.a] Error 2


The root-cause is-

+#undef CONFIG_SYS_ARM_WITHOUT_RELOC 
+#define CONFIG_SYS_SDRAM_BASE   PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR (LOW_LEVEL_SRAM_STACK - 
CONFIG_SYS_GBL_DATA_SIZE)


The above definition is missing in all (zoom1, zoom2, evm, am3517evm, sdp3430, 
overo, Pandora) config files.

Am I missing something here? Just wanted to cross-check before posting patch to 
the list.

Thanks,
Vaibhav

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V3 1/2] AM35x: Add support for AM3517EVM

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Monday, June 07, 2010 5:55 PM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de; t...@bumblecow.com; Paulraj, Sandeep; Premi,
> Sanjeev
> Subject: Re: [PATCH-V3 1/2] AM35x: Add support for AM3517EVM
> 
> Dear "Hiremath, Vaibhav",
> 
> In message <19f8576c6e063c45be387c64729e7394044e7a1...@dbde02.ent.ti.com>
> you wrote:
> ...
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index 5cbc845..0bc65e1 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -798,6 +798,10 @@ Alex Z
> > > > >   lartSA1100
> > > > >   dnp1110 SA1110
> > > > >
> > > > > +Vaibhav Hiremath 
> > > > > +
> > > > > + am3517_evm  ARM CORTEX-A8 (AM35x SoC)
> > > > > +
> > > >
> > > > Please keep list sorted.
> > > >
> > > [Hiremath, Vaibhav] How does this sorted, I could not see any relation
> > > between the entries there.
> 
> The list is sorted alphabetically by maintainer' last names, and then
> by CPU / board names.
> 
[Hiremath, Vaibhav] Thanks, I will update the patch and submit is shortly.

> > > > > diff --git a/arch/arm/include/asm/arch-omap3/mux.h
> > > > b/arch/arm/include/asm/arch-omap3/mux.h
> > > > > index 0c01c73..ffeb982 100644
> > > > > --- a/arch/arm/include/asm/arch-omap3/mux.h
> > > > > +++ b/arch/arm/include/asm/arch-omap3/mux.h
> > > > ...
> > > > > +/* AM3517 specific */
> > > > > +#define CONTROL_PADCONF_CCDC_PCLK0x01E4
> > > > > +#define CONTROL_PADCONF_CCDC_FIELD   0x01E6
> > > >
> > > > Board specific defoinitions should not be added to global header
> > > > files. Please use a board specific header instead.
> > > >
> > > [Hiremath, Vaibhav] I think this has been placed at the right place.
> This is
> > > mux definition and got added to mux.h file. You could see all mux
> definition
> > > are present in this file.
> > >
> > > Do you see any issues with this?
> 
> Yes, as I wrote: board specific definitions should not be added to
> global header files. They should be added to board specific files
> only, avoiding the need for tons of #ifdef's in global files.
> 
[Hiremath, Vaibhav] Yes I agree this has to be there in board header file, but 
I don't think we are using #ifdefs anywhere for this, since the usage of this 
is happening through board header file.

I am moving these definitions to board/logicpd/am3517evm/am3517evm.h file.

Thanks,
Vaibhav
> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> When you die, the first thing you lose is your life. The  next  thing
> is the illusions.   - Terry Pratchett, _Pyramids_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V3 1/2] AM35x: Add support for AM3517EVM

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Thursday, June 03, 2010 10:57 PM
> To: 'Wolfgang Denk'
> Cc: u-boot@lists.denx.de; t...@bumblecow.com; Paulraj, Sandeep; Premi,
> Sanjeev
> Subject: RE: [PATCH-V3 1/2] AM35x: Add support for AM3517EVM
> 
[Hiremath, Vaibhav] Denk,

Can you please reply to below queries of mine, so that I can incorporate the 
changes and submit it again?

Thanks,
Vaibhav

> 
> > -Original Message-
> > From: Wolfgang Denk [mailto:w...@denx.de]
> > Sent: Monday, May 31, 2010 3:11 PM
> > To: Hiremath, Vaibhav
> > Cc: u-boot@lists.denx.de; t...@bumblecow.com; Paulraj, Sandeep; Premi,
> > Sanjeev
> > Subject: Re: [PATCH-V3 1/2] AM35x: Add support for AM3517EVM
> >
> > Dear hvaib...@ti.com,
> >
> > In message <1273166585-26101-1-git-send-email-hvaib...@ti.com> you wrote:
> > > From: Vaibhav Hiremath 
> > >
> > > This patch adds basic support for the AM3517EVM.
> > > It includes:
> > >   - Board int file (.c and .h)
> > >   - Default configuration file
> > >   - Updates for Makefile
> > >
> > > Changes from V2:
> > >   - Removed trailing spaces
> > >   - Updated MAINTAINERS & MAKEALL for am3517_evm
> >
> > Such comments do not belong into the commit message. Please place thes
> > ebelow the "---" line:
> >
> [Hiremath, Vaibhav] Ok will incorporate in next post.
> 
> > > Signed-off-by: Vaibhav Hiremath 
> > > Signed-off-by: Sanjeev Premi 
> > > ---
> >
> > ==> Comments should go here.
> >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 5cbc845..0bc65e1 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -798,6 +798,10 @@ Alex Z
> > >   lartSA1100
> > >   dnp1110 SA1110
> > >
> > > +Vaibhav Hiremath 
> > > +
> > > + am3517_evm  ARM CORTEX-A8 (AM35x SoC)
> > > +
> >
> > Please keep list sorted.
> >
> [Hiremath, Vaibhav] How does this sorted, I could not see any relation
> between the entries there.
> 
[Hiremath, Vaibhav] Denk,
> > ...
> > > diff --git a/arch/arm/include/asm/arch-omap3/mux.h
> > b/arch/arm/include/asm/arch-omap3/mux.h
> > > index 0c01c73..ffeb982 100644
> > > --- a/arch/arm/include/asm/arch-omap3/mux.h
> > > +++ b/arch/arm/include/asm/arch-omap3/mux.h
> > ...
> > > +/* AM3517 specific */
> > > +#define CONTROL_PADCONF_CCDC_PCLK0x01E4
> > > +#define CONTROL_PADCONF_CCDC_FIELD   0x01E6
> >
> > Board specific defoinitions should not be added to global header
> > files. Please use a board specific header instead.
> >
> [Hiremath, Vaibhav] I think this has been placed at the right place. This is
> mux definition and got added to mux.h file. You could see all mux definition
> are present in this file.
> 
> Do you see any issues with this?
> 
> > > --- /dev/null
> > > +++ b/board/logicpd/am3517evm/am3517evm.c
> > > @@ -0,0 +1,76 @@
> > ...
> > > +int board_init(void)
> > > +{
> > > + DECLARE_GLOBAL_DATA_PTR;
> >
> > This is bound to break. DECLARE_GLOBAL_DATA_PTR must always be used on
> > file scope only; never use this on function scope.
> [Hiremath, Vaibhav] Agreed. Actually this code is derived form
> board/ti/evm/, so followed the same here.
> 
> I will change it in next post.
> 
> > Please check all
> > your code.
> >
> [Hiremath, Vaibhav] Do you see any other issues? I don't get this statement.
> 
> Thanks,
> Vaibhav
> 
> >
> > Best regards,
> >
> > Wolfgang Denk
> >
> > --
> > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> > Genius doesn't work on an assembly line basis.  You can't simply say,
> > "Today I will be brilliant."
> > -- Kirk, "The Ultimate Computer", stardate 4731.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V3 2/2] omap3: Consolidate SDRC related operations

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Friday, June 04, 2010 7:23 PM
> To: u-boot@lists.denx.de
> Cc: Paulraj, Sandeep; t...@bumblecow.com; w...@denx.de; Hiremath, Vaibhav
> Subject: [PATCH-V3 2/2] omap3: Consolidate SDRC related operations
>
> From: Vaibhav Hiremath 
>
> Consolidated SDRC related functions into one file - sdrc.c
>
> And also replaced sdrc_init with generic memory init
> function (mem_init), this generalization of omap memory setup
> is necessary to support the new emif4 interface introduced in AM3517.
>
> Signed-off-by: Vaibhav Hiremath 
> ---
> Changes from V2:
>   - Removed all instances of #ifdef CONFIG_SDRC Changes from V1:
>   - Refreshed against latest denx/master
>
[Hiremath, Vaibhav] Again, as per Denk's comment moving patch comment below --- 
line.

Since last time I didn't get any comments other than this, so hoping this time 
it gets merged.

Thanks,
Vaibhav

>  arch/arm/cpu/arm_cortexa8/omap3/Makefile|4 +-
>  arch/arm/cpu/arm_cortexa8/omap3/board.c |   35 +-
>  arch/arm/cpu/arm_cortexa8/omap3/mem.c   |   90 
>  arch/arm/cpu/arm_cortexa8/omap3/sdrc.c  |  202
> +++
>  arch/arm/cpu/arm_cortexa8/omap3/sys_info.c  |   41 --
>  arch/arm/include/asm/arch-omap3/cpu.h   |1 +
>  arch/arm/include/asm/arch-omap3/mem.h   |   13 ++
>  arch/arm/include/asm/arch-omap3/sys_proto.h |2 -
>  include/configs/devkit8000.h|2 +
>  include/configs/omap3_beagle.h  |2 +
>  include/configs/omap3_evm.h |2 +
>  include/configs/omap3_overo.h   |2 +
>  include/configs/omap3_pandora.h |2 +
>  include/configs/omap3_sdp3430.h |2 +
>  include/configs/omap3_zoom1.h   |2 +
>  include/configs/omap3_zoom2.h   |2 +
>  16 files changed, 236 insertions(+), 168 deletions(-)
>  create mode 100644 arch/arm/cpu/arm_cortexa8/omap3/sdrc.c
>
> diff --git a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> index 136b163..1e80eb3 100644
> --- a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> +++ b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> @@ -37,8 +37,10 @@ COBJS  += syslib.o
>  COBJS+= sys_info.o
>  COBJS+= timer.o
>
> +COBJS-$(CONFIG_SDRC) += sdrc.o
> +
>  SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> -OBJS := $(addprefix $(obj),$(COBJS) $(SOBJS))
> +OBJS := $(addprefix $(obj),$(COBJS) $(COBJS-y) $(SOBJS))
>
>  all:  $(obj).depend $(LIB)
>
> diff --git a/arch/arm/cpu/arm_cortexa8/omap3/board.c
> b/arch/arm/cpu/arm_cortexa8/omap3/board.c
> index 69a08fd..d2500ca 100644
> --- a/arch/arm/cpu/arm_cortexa8/omap3/board.c
> +++ b/arch/arm/cpu/arm_cortexa8/omap3/board.c
> @@ -40,8 +40,6 @@
>
>  extern omap3_sysinfo sysinfo;
>
> -extern u32 is_mem_sdr(void);
> -
>
> /***
> ***
>   * Routine: delay
>   * Description: spinning delay to use before udelay works
> @@ -233,7 +231,7 @@ void s_init(void)
>   per_clocks_enable();
>
>   if (!in_sdram)
> - sdrc_init();
> + mem_init();
>  }
>
>
> /***
> ***
> @@ -274,37 +272,6 @@ void watchdog_init(void)
>  }
>
>
> /***
> ***
> - * Routine: dram_init
> - * Description: sets uboots idea of sdram size
> -
> 
> */
> -int dram_init(void)
> -{
> - DECLARE_GLOBAL_DATA_PTR;
> - unsigned int size0 = 0, size1 = 0;
> -
> - size0 = get_sdr_cs_size(CS0);
> -
> - /*
> -  * If a second bank of DDR is attached to CS1 this is
> -  * where it can be started.  Early init code will init
> -  * memory on CS0.
> -  */
> - if ((sysinfo.mtype == DDR_COMBO) || (sysinfo.mtype == DDR_STACKED)) {
> - do_sdrc_init(CS1, NOT_EARLY);
> - make_cs1_contiguous();
> -
> - size1 = get_sdr_cs_size(CS1);
> - }
> -
> - gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
> - gd->bd->bi_dram[0].size = size0;
> - gd->bd->bi_dram[1].start = PHYS_SDRAM_1 + get_sdr_cs_offset(CS1);
> - gd->bd->bi_dram[1].size = size1;
> -
> - return 0;
> -}
> -
> -
> /***
> ***
>   * Dummy function to handle errors for EABI incompatibility
>
> **

Re: [U-Boot] [PATCH-V4] OMAP3EVM: Added NAND support

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Friday, June 04, 2010 7:15 PM
> To: u-boot@lists.denx.de
> Cc: Paulraj, Sandeep; t...@bumblecow.com; w...@denx.de; Hiremath, Vaibhav
> Subject: [PATCH-V4] OMAP3EVM: Added NAND support
> 
> From: Vaibhav Hiremath 
> 
> The EVMS have been shipping with NAND (instead of OneNAND) as default.
> So, this patch sets NAND as default.
> 
> To choose OneNAND, define CMD_ONENAND instead of CMD_NAND in the
> config file omap3_evm.h.
> 
> Signed-off-by: Vaibhav Hiremath 
> ---
> Changes from V3 :-
>     - Added undef statement for CMD_ONENAND.
> 
[Hiremath, Vaibhav] As suggested by denk, I have moved the comments below ---. 
The patch content has not been changed so not version.

Hoping this time Tom will merge this patch.

Thanks,
Vaibhav

>  include/configs/omap3_evm.h |8 +++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
> index 0d99f7d..88af492 100644
> --- a/include/configs/omap3_evm.h
> +++ b/include/configs/omap3_evm.h
> @@ -151,7 +151,7 @@
> 
>  #define CONFIG_CMD_I2C   /* I2C serial bus support   */
>  #define CONFIG_CMD_MMC   /* MMC support  */
> -#define CONFIG_CMD_ONENAND   /* ONENAND support  */
> +#define CONFIG_CMD_NAND  /* NAND support */
>  #define CONFIG_CMD_DHCP
>  #define CONFIG_CMD_PING
> 
> @@ -306,7 +306,13 @@
>  #define CONFIG_SYS_MONITOR_BASE  CONFIG_SYS_FLASH_BASE
>  #define CONFIG_SYS_ONENAND_BASE  ONENAND_MAP
> 
> +#if defined(CONFIG_CMD_NAND)
> +#define CONFIG_NAND_OMAP_GPMC
> +#define GPMC_NAND_ECC_LP_x16_LAYOUT  1
> +#define CONFIG_ENV_IS_IN_NAND
> +#elif defined(CONFIG_CMD_ONENAND)
>  #define CONFIG_ENV_IS_IN_ONENAND 1
> +#endif
>  #define ONENAND_ENV_OFFSET   0x26 /* environment starts here */
>  #define SMNAND_ENV_OFFSET0x26 /* environment starts here */
> 
> --
> 1.6.2.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V3 2/2] AM35x: Add support for EMIF4

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Monday, May 31, 2010 3:14 PM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de; t...@bumblecow.com; Paulraj, Sandeep; Premi,
> Sanjeev
> Subject: Re: [PATCH-V3 2/2] AM35x: Add support for EMIF4
> 
> Dear hvaib...@ti.com,
> 
> In message <1273166585-26101-2-git-send-email-hvaib...@ti.com> you wrote:
> > From: Vaibhav Hiremath 
> >
> > This patch adds support for the EMIF4 interface
> > available in the AM35x processors.
> >
> > Changes from V2:
> > - Removed all instances of #ifdef CONFIG_EMIF4
> 
> See previeos comment - such comments belong below the "---" line and
> not into the commit message.
> 
[Hiremath, Vaibhav] OK, I will incorporate changes in next post.

> > diff --git a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > index 1e80eb3..d25bfd5 100644
> > --- a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > +++ b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > @@ -38,6 +38,7 @@ COBJS += sys_info.o
> >  COBJS  += timer.o
> >
> >  COBJS-$(CONFIG_SDRC)   += sdrc.o
> > +COBJS-$(CONFIG_EMIF4)  +=emif4.o
> 
> Please keep lists sorted.
> 
[Hiremath, Vaibhav] Will change and submit it again.

Thanks,
Vaibhav

> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> The complexity of software is an essential property, not an  acciden-
> tal  one. Hence, descriptions of a software entity that abstract away
> its complexity often abstract away its essence.- Fred Brooks, Jr.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V3 1/2] AM35x: Add support for AM3517EVM

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Monday, May 31, 2010 3:11 PM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de; t...@bumblecow.com; Paulraj, Sandeep; Premi,
> Sanjeev
> Subject: Re: [PATCH-V3 1/2] AM35x: Add support for AM3517EVM
> 
> Dear hvaib...@ti.com,
> 
> In message <1273166585-26101-1-git-send-email-hvaib...@ti.com> you wrote:
> > From: Vaibhav Hiremath 
> >
> > This patch adds basic support for the AM3517EVM.
> > It includes:
> > - Board int file (.c and .h)
> > - Default configuration file
> > - Updates for Makefile
> >
> > Changes from V2:
> > - Removed trailing spaces
> > - Updated MAINTAINERS & MAKEALL for am3517_evm
> 
> Such comments do not belong into the commit message. Please place thes
> ebelow the "---" line:
> 
[Hiremath, Vaibhav] Ok will incorporate in next post.

> > Signed-off-by: Vaibhav Hiremath 
> > Signed-off-by: Sanjeev Premi 
> > ---
> 
> ==> Comments should go here.
> 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5cbc845..0bc65e1 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -798,6 +798,10 @@ Alex Z
> >     lartSA1100
> > dnp1110 SA1110
> >
> > +Vaibhav Hiremath 
> > +
> > +   am3517_evm  ARM CORTEX-A8 (AM35x SoC)
> > +
> 
> Please keep list sorted.
> 
[Hiremath, Vaibhav] How does this sorted, I could not see any relation between 
the entries there. 

> ...
> > diff --git a/arch/arm/include/asm/arch-omap3/mux.h
> b/arch/arm/include/asm/arch-omap3/mux.h
> > index 0c01c73..ffeb982 100644
> > --- a/arch/arm/include/asm/arch-omap3/mux.h
> > +++ b/arch/arm/include/asm/arch-omap3/mux.h
> ...
> > +/* AM3517 specific */
> > +#define CONTROL_PADCONF_CCDC_PCLK  0x01E4
> > +#define CONTROL_PADCONF_CCDC_FIELD 0x01E6
> 
> Board specific defoinitions should not be added to global header
> files. Please use a board specific header instead.
> 
[Hiremath, Vaibhav] I think this has been placed at the right place. This is 
mux definition and got added to mux.h file. You could see all mux definition 
are present in this file.

Do you see any issues with this?

> > --- /dev/null
> > +++ b/board/logicpd/am3517evm/am3517evm.c
> > @@ -0,0 +1,76 @@
> ...
> > +int board_init(void)
> > +{
> > +   DECLARE_GLOBAL_DATA_PTR;
> 
> This is bound to break. DECLARE_GLOBAL_DATA_PTR must always be used on
> file scope only; never use this on function scope.  
[Hiremath, Vaibhav] Agreed. Actually this code is derived form board/ti/evm/, 
so followed the same here.

I will change it in next post.

> Please check all
> your code.
> 
[Hiremath, Vaibhav] Do you see any other issues? I don't get this statement.

Thanks,
Vaibhav

> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> Genius doesn't work on an assembly line basis.  You can't simply say,
> "Today I will be brilliant."
>   -- Kirk, "The Ultimate Computer", stardate 4731.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] ARM pull request.

[Hiremath, Vaibhav]

> -Original Message-
> From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On
> Behalf Of Tom Rix
> Sent: Sunday, May 30, 2010 7:22 PM
> To: Wolfgang Denk
> Cc: u-boot@lists.denx.de
> Subject: [U-Boot] ARM pull request.
> 
> This is to catch master up to ARM mach-types
> 
> Tom
> 
> The following changes since commit 01f03bda5b22e5aeae5f02fd537da97a41485c73:
>Wolfgang Denk (1):
>  Prepare v2010.06-rc1
> 
> are available in the git repository at:
> 
>git://git.denx.de/u-boot-arm master
> 
[Hiremath, Vaibhav] Tom,

I just thought of reminding you about long pending patches for OMAP3 & AM35x 
which I had submitted.

OMAP3EVM: Added NAND support
omap3: Calculate CS1 size only when SDRC is initialized for CS1
omap3: Consolidate SDRC related operations
AM35x: Add support for AM3517EVM
AM35x: Add support for EMIF4


Thanks,
Vaibhav

> Tom (2):
>ARM Update mach-types
>ARM Update mach-types
> 
>   arch/arm/include/asm/mach-types.h | 1173
> -
>   1 files changed, 1165 insertions(+), 8 deletions(-)
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V3 1/2] omap3: Calculate CS1 size only when SDRC is initialized for CS1

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Tuesday, May 11, 2010 10:30 AM
> To: Hiremath, Vaibhav; u-boot@lists.denx.de
> Cc: w...@denx.de; t...@bumblecow.com; Paulraj, Sandeep; Premi, Sanjeev
> Subject: RE: [PATCH-V3 1/2] omap3: Calculate CS1 size only when SDRC is
> initialized for CS1
> 
> 
> > -Original Message-
> > From: Hiremath, Vaibhav
> > Sent: Thursday, May 06, 2010 10:52 PM
> > To: u-boot@lists.denx.de
> > Cc: w...@denx.de; t...@bumblecow.com; Paulraj, Sandeep; Hiremath, Vaibhav;
> > Premi, Sanjeev
> > Subject: [PATCH-V3 1/2] omap3: Calculate CS1 size only when SDRC is
> > initialized for CS1
> >
> > From: Vaibhav Hiremath 
> >
> > The patch makes sure that size for SDRC CS1 gets calculated
> > only when the CS1 SDRC is initialized.
> >
> [Hiremath, Vaibhav] Denk,
> 
> If we do not have any further comments, can we merge these patches?
[Hiremath, Vaibhav] Tom,

Can you merge these patches and give pull request to Denk, this is long pending 
item.

Thanks,
Vaibhav

> 
> Thanks,
> Vaibhav
> 
> > Signed-off-by: Vaibhav Hiremath 
> > Signed-off-by: Sanjeev Premi 
> > ---
> >  arch/arm/cpu/arm_cortexa8/omap3/board.c |7 ---
> >  1 files changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/cpu/arm_cortexa8/omap3/board.c
> > b/arch/arm/cpu/arm_cortexa8/omap3/board.c
> > index 7b78fa4..69a08fd 100644
> > --- a/arch/arm/cpu/arm_cortexa8/omap3/board.c
> > +++ b/arch/arm/cpu/arm_cortexa8/omap3/board.c
> > @@ -282,6 +282,8 @@ int dram_init(void)
> > DECLARE_GLOBAL_DATA_PTR;
> > unsigned int size0 = 0, size1 = 0;
> >
> > +   size0 = get_sdr_cs_size(CS0);
> > +
> > /*
> >  * If a second bank of DDR is attached to CS1 this is
> >  * where it can be started.  Early init code will init
> > @@ -290,10 +292,9 @@ int dram_init(void)
> > if ((sysinfo.mtype == DDR_COMBO) || (sysinfo.mtype == DDR_STACKED)) {
> > do_sdrc_init(CS1, NOT_EARLY);
> > make_cs1_contiguous();
> > -   }
> >
> > -   size0 = get_sdr_cs_size(CS0);
> > -   size1 = get_sdr_cs_size(CS1);
> > +   size1 = get_sdr_cs_size(CS1);
> > +   }
> >
> > gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
> > gd->bd->bi_dram[0].size = size0;
> > --
> > 1.6.2.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V5] OMAP3EVM: Added NAND support

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Tuesday, May 11, 2010 2:29 PM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de; t...@bumblecow.com; Paulraj, Sandeep; Scott Wood
> Subject: Re: [PATCH-V5] OMAP3EVM: Added NAND support
> 
> Dear "Hiremath, Vaibhav",
> 
> In message <19f8576c6e063c45be387c64729e7394044e404...@dbde02.ent.ti.com>
> you wrote:
> >
> > > Subject: [PATCH-V5] OMAP3EVM: Added NAND support
> > >
> > > From: Vaibhav Hiremath 
> > >
> > > The EVMS have been shipping with NAND (instead of OneNAND) as default.
> > > So, this patch sets NAND as default.
> > >
> > > To choose OneNAND, define CMD_ONENAND instead of CMD_NAND in the
> > > config file omap3_evm.h,
> > >
> > > Changes From V4 :-
> > >   - Removed #undef ONENAND line (comment from Denk)
> > > Changes from V3 :-
> > >   - Refreshed against latest u-boot/master
> > > Changes from V2 :-
> > >   - Added undef statement for CMD_ONENAND.
> > >
> > [Hiremath, Vaibhav] Denk,
> >
> > If we do not have any further comments, can we merge these patches?
> 
> The patches you listed are either ARM related and as such to be
> handdled by the ARM custodian, Tom, and/or NAND related ans as such to
> be addressed by the NAND custodian, Scott.
> 
> 
> I just wait for their pull requests.
[Hiremath, Vaibhav] Thanks Denk,

I think all these patches falls under Tom's list.

Tom,

Can you please merge these patches?

Thanks,
Vaibhav

> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> "The glory of creation is in its infinite diversity." "And in the way
> our differences combine to create meaning and beauty."
>   -- Dr. Miranda Jones and Spock, "Is There in Truth No Beauty?",
>  stardate 5630.8
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V3 1/2] AM35x: Add support for AM3517EVM

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Thursday, May 06, 2010 10:53 PM
> To: u-boot@lists.denx.de
> Cc: w...@denx.de; t...@bumblecow.com; Paulraj, Sandeep; Hiremath, Vaibhav;
> Premi, Sanjeev
> Subject: [PATCH-V3 1/2] AM35x: Add support for AM3517EVM
>
> From: Vaibhav Hiremath 
>
> This patch adds basic support for the AM3517EVM.
> It includes:
>   - Board int file (.c and .h)
>   - Default configuration file
>   - Updates for Makefile
>
> Changes from V2:
>   - Removed trailing spaces
>   - Updated MAINTAINERS & MAKEALL for am3517_evm
>
[Hiremath, Vaibhav] Denk,

If we do not have any further comments, can we merge these patches?

Thanks,
Vaibhav

> Signed-off-by: Vaibhav Hiremath 
> Signed-off-by: Sanjeev Premi 
> ---
>  MAINTAINERS   |4 +
>  MAKEALL   |1 +
>  Makefile  |3 +
>  arch/arm/include/asm/arch-omap3/mux.h |   38 +++-
>  board/logicpd/am3517evm/Makefile  |   46 
>  board/logicpd/am3517evm/am3517evm.c   |   76 ++
>  board/logicpd/am3517evm/am3517evm.h   |  405
> +
>  board/logicpd/am3517evm/config.mk |   30 +++
>  include/configs/am3517_evm.h  |  296 
>  9 files changed, 898 insertions(+), 1 deletions(-)
>  create mode 100644 board/logicpd/am3517evm/Makefile
>  create mode 100644 board/logicpd/am3517evm/am3517evm.c
>  create mode 100644 board/logicpd/am3517evm/am3517evm.h
>  create mode 100644 board/logicpd/am3517evm/config.mk
>  create mode 100644 include/configs/am3517_evm.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5cbc845..0bc65e1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -798,6 +798,10 @@ Alex Z
>   lartSA1100
>   dnp1110 SA1110
>
> +Vaibhav Hiremath 
> +
> + am3517_evm  ARM CORTEX-A8 (AM35x SoC)
> +
>  -
>
>  Unknown / orphaned boards:
> diff --git a/MAKEALL b/MAKEALL
> index bb09627..cd59daa 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -641,6 +641,7 @@ LIST_ARM11="  \
>  ## ARM Cortex-A8 Systems
>  #
>  LIST_ARM_CORTEX_A8=" \
> + am3517_evm  \
>   devkit8000  \
>   mx51evk \
>   omap3_beagle\
> diff --git a/Makefile b/Makefile
> index 2d96574..57b3491 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3155,6 +3155,9 @@ SMN42_config:   unconfig
>  ## ARM CORTEX Systems
>  #
>
> +am3517_evm_config :  unconfig
> + @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 am3517evm logicpd omap3
> +
>  devkit8000_config :  unconfig
>   @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 devkit8000 timll omap3
>
> diff --git a/arch/arm/include/asm/arch-omap3/mux.h
> b/arch/arm/include/asm/arch-omap3/mux.h
> index 0c01c73..ffeb982 100644
> --- a/arch/arm/include/asm/arch-omap3/mux.h
> +++ b/arch/arm/include/asm/arch-omap3/mux.h
> @@ -283,7 +283,7 @@
>  /*Control and debug */
>  #define CONTROL_PADCONF_SYS_32K  0x0A04
>  #define CONTROL_PADCONF_SYS_CLKREQ   0x0A06
> -#define CONTROL_PADCONF_SYS_NIRQ 0x01E0
> +#define CONTROL_PADCONF_SYS_NRESWARM 0x0A08
>  #define CONTROL_PADCONF_SYS_BOOT00x0A0A
>  #define CONTROL_PADCONF_SYS_BOOT10x0A0C
>  #define CONTROL_PADCONF_SYS_BOOT20x0A0E
> @@ -337,6 +337,7 @@
>  #define CONTROL_PADCONF_ETK_D14_ES2  0x05F8
>  #define CONTROL_PADCONF_ETK_D15_ES2  0x05FA
>  /*Die to Die */
> +#define CONTROL_PADCONF_SYS_NIRQ 0x01E0
>  #define CONTROL_PADCONF_D2D_MCAD00x01E4
>  #define CONTROL_PADCONF_D2D_MCAD10x01E6
>  #define CONTROL_PADCONF_D2D_MCAD20x01E8
> @@ -403,6 +404,41 @@
>  #define CONTROL_PADCONF_D2D_SBUSFLAG 0x0260
>  #define CONTROL_PADCONF_SDRC_CKE00x0262
>  #define CONTROL_PADCONF_SDRC_CKE10x0264
> +/* AM3517 specific */
> +#define CONTROL_PADCONF_CCDC_PCLK0x01E4
> +#define CONTROL_PADCONF_CCDC_FIELD   0x01E6
> +#define CONTROL_PADCONF_CCDC_HD  0x01E8
> +#define CONTROL_PADCONF_CCDC_VD  0x01EA
> +#define CONTROL_PADCONF_CCDC_WEN 0x01EC
> +#define CONTROL_PADCONF_CCDC_DATA0   0x01EE
> +#define CONTROL_PADCONF_CCDC_DATA1   0x01F0
> +#define CONTROL_PADCONF_CCDC_DATA2   0x01F2
> +#define CONTROL_PADCONF_CCDC_DATA3   0x01F4
> +#define CONTROL_PADCONF_CCDC_DATA4   0x01F6
> +#define CONTROL_PADCONF_CCDC_DATA5   0x01F8
> +#define CONTROL_PADCONF_C

Re: [U-Boot] [PATCH-V3 1/2] omap3: Calculate CS1 size only when SDRC is initialized for CS1

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Thursday, May 06, 2010 10:52 PM
> To: u-boot@lists.denx.de
> Cc: w...@denx.de; t...@bumblecow.com; Paulraj, Sandeep; Hiremath, Vaibhav;
> Premi, Sanjeev
> Subject: [PATCH-V3 1/2] omap3: Calculate CS1 size only when SDRC is
> initialized for CS1
> 
> From: Vaibhav Hiremath 
> 
> The patch makes sure that size for SDRC CS1 gets calculated
> only when the CS1 SDRC is initialized.
> 
[Hiremath, Vaibhav] Denk,

If we do not have any further comments, can we merge these patches?

Thanks,
Vaibhav

> Signed-off-by: Vaibhav Hiremath 
> Signed-off-by: Sanjeev Premi 
> ---
>  arch/arm/cpu/arm_cortexa8/omap3/board.c |7 ---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm_cortexa8/omap3/board.c
> b/arch/arm/cpu/arm_cortexa8/omap3/board.c
> index 7b78fa4..69a08fd 100644
> --- a/arch/arm/cpu/arm_cortexa8/omap3/board.c
> +++ b/arch/arm/cpu/arm_cortexa8/omap3/board.c
> @@ -282,6 +282,8 @@ int dram_init(void)
>   DECLARE_GLOBAL_DATA_PTR;
>   unsigned int size0 = 0, size1 = 0;
> 
> + size0 = get_sdr_cs_size(CS0);
> +
>   /*
>* If a second bank of DDR is attached to CS1 this is
>* where it can be started.  Early init code will init
> @@ -290,10 +292,9 @@ int dram_init(void)
>   if ((sysinfo.mtype == DDR_COMBO) || (sysinfo.mtype == DDR_STACKED)) {
>   do_sdrc_init(CS1, NOT_EARLY);
>   make_cs1_contiguous();
> - }
> 
> - size0 = get_sdr_cs_size(CS0);
> - size1 = get_sdr_cs_size(CS1);
> + size1 = get_sdr_cs_size(CS1);
> + }
> 
>   gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>   gd->bd->bi_dram[0].size = size0;
> --
> 1.6.2.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V5] OMAP3EVM: Added NAND support

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Thursday, May 06, 2010 10:49 PM
> To: u-boot@lists.denx.de
> Cc: w...@denx.de; t...@bumblecow.com; Paulraj, Sandeep; Hiremath, Vaibhav
> Subject: [PATCH-V5] OMAP3EVM: Added NAND support
> 
> From: Vaibhav Hiremath 
> 
> The EVMS have been shipping with NAND (instead of OneNAND) as default.
> So, this patch sets NAND as default.
> 
> To choose OneNAND, define CMD_ONENAND instead of CMD_NAND in the
> config file omap3_evm.h,
> 
> Changes From V4 :-
>   - Removed #undef ONENAND line (comment from Denk)
> Changes from V3 :-
>   - Refreshed against latest u-boot/master
> Changes from V2 :-
>   - Added undef statement for CMD_ONENAND.
> 
[Hiremath, Vaibhav] Denk,

If we do not have any further comments, can we merge these patches?

Thanks,
Vaibhav

> Signed-off-by: Vaibhav Hiremath 
> ---
>  include/configs/omap3_evm.h |8 +++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
> index 0d99f7d..88af492 100644
> --- a/include/configs/omap3_evm.h
> +++ b/include/configs/omap3_evm.h
> @@ -151,7 +151,7 @@
> 
>  #define CONFIG_CMD_I2C   /* I2C serial bus support   */
>  #define CONFIG_CMD_MMC   /* MMC support  */
> -#define CONFIG_CMD_ONENAND   /* ONENAND support  */
> +#define CONFIG_CMD_NAND  /* NAND support */
>  #define CONFIG_CMD_DHCP
>  #define CONFIG_CMD_PING
> 
> @@ -306,7 +306,13 @@
>  #define CONFIG_SYS_MONITOR_BASE  CONFIG_SYS_FLASH_BASE
>  #define CONFIG_SYS_ONENAND_BASE  ONENAND_MAP
> 
> +#if defined(CONFIG_CMD_NAND)
> +#define CONFIG_NAND_OMAP_GPMC
> +#define GPMC_NAND_ECC_LP_x16_LAYOUT  1
> +#define CONFIG_ENV_IS_IN_NAND
> +#elif defined(CONFIG_CMD_ONENAND)
>  #define CONFIG_ENV_IS_IN_ONENAND 1
> +#endif
>  #define ONENAND_ENV_OFFSET   0x26 /* environment starts here */
>  #define SMNAND_ENV_OFFSET0x26 /* environment starts here */
> 
> --
> 1.6.2.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RESEND:PATCH-V4] OMAP3EVM: Added NAND support

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Thursday, May 06, 2010 4:20 PM
> To: Nishanth Menon
> Cc: Hiremath, Vaibhav; u-boot@lists.denx.de
> Subject: Re: [U-Boot] [RESEND:PATCH-V4] OMAP3EVM: Added NAND support
> 
> Dear Nishanth Menon,
> 
> In message 
> you wrote:
> > On Thu, May 6, 2010 at 12:36 AM, Hiremath, Vaibhav 
> wrote:
> ...
> > > I do agree that we don't have to undef here, but agreed to Nishant's
> comment only because from user point of view, if user would
> > > like to enable ONENAND support then for him it's easy he just have to
> comment NAND line and make change this #define. He
> > > doesn't have to dig inside code to find out whether ONENAND is supported
> or not.
> 
> Well, of course the user _has_ to dig into the code and check if the
> feature is supported, because there is no information what the
> "#undef" or the comment means - it can mean anything:
> 
> - disabled here and left in so you can easily re-add it if you like
> - disabled because known to be unsupported or broken
> - disabled because untested
> - ...
[Hiremath, Vaibhav] Ok. Agreed. I will remove undef line and submit the patch.

Thanks,
Vaibhav

> 
> > platforms such as SDP platforms have three flash devices - nand,
> > onenand and nor - these are development platforms and are meant to
> > bootup from any of these devices based on which ever dip switch is
> > set. having a #undef is more elegant than /* */ and easier to use from
> > a developer perspective.
> 
> Please provide one working configuration, or several config options,
> but don't try to add kind of configuration menues using "#define" /
> "#undef" lists. These are useless and confusing at best.
> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> Motto of the Electrical Engineer: Working computer hardware is a  lot
> like an erect penis: it stays up as long as you don't fuck with it.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V2 4/4] AM35x: Add support for EMIF4

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Thursday, May 06, 2010 1:44 AM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH-V2 4/4] AM35x: Add support for EMIF4
> 
> Dear hvaib...@ti.com,
> 
> In message <1272034546-26041-6-git-send-email-hvaib...@ti.com> you wrote:
> > From: Vaibhav Hiremath 
> >
> > This patch adds support for the EMIF4 interface
> > available in the AM35x processors.
> >
> > Signed-off-by: Vaibhav Hiremath 
> > Signed-off-by: Sanjeev Premi 
> > ---
> >  arch/arm/cpu/arm_cortexa8/omap3/Makefile|3 +
> >  arch/arm/cpu/arm_cortexa8/omap3/emif4.c |  168
> +++
> >  arch/arm/include/asm/arch-omap3/cpu.h   |   24 
> >  arch/arm/include/asm/arch-omap3/emif4.h |   79 +
> >  arch/arm/include/asm/arch-omap3/sys_proto.h |3 +
> >  5 files changed, 277 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/arm/cpu/arm_cortexa8/omap3/emif4.c
> >  create mode 100644 arch/arm/include/asm/arch-omap3/emif4.h
> >
> > diff --git a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > index 8cc7802..0a23fa5 100644
> > --- a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > +++ b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > @@ -36,6 +36,9 @@ COBJS += mem.o
> >  ifdef  CONFIG_SDRC
> >  COBJS  += sdrc.o
> >  endif
> > +ifdef  CONFIG_EMIF4
> > +COBJS  += emif4.o
> > +endif
> 
> Don't use ifdef, use COBJS-$(CONFIG_EMIF4) instead.
> 
> > diff --git a/arch/arm/include/asm/arch-omap3/sys_proto.h
> b/arch/arm/include/asm/arch-omap3/sys_proto.h
> > index 34e4e0d..7b425be 100644
> > --- a/arch/arm/include/asm/arch-omap3/sys_proto.h
> > +++ b/arch/arm/include/asm/arch-omap3/sys_proto.h
> > @@ -35,6 +35,9 @@ void memif_init(void);
> >  void sdrc_init(void);
> >  void do_sdrc_init(u32, u32);
> >  #endif
> > +#if defined(CONFIG_EMIF4)
> > +void emif4_init(void);
> > +#endif
> 
> I guess you can omit the #ifdef here, right?
> 
[Hiremath, Vaibhav] Denk,

We have OMAP families supporting both SDRC and EMIF4 (obviously mutually 
exclusive), so we need to add this #ifdef.

Thanks,
Vaibhav

> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> A failure will not appear until a unit has passed final inspection.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V2 3/4] AM35x: Add support for AM3517EVM

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Thursday, May 06, 2010 1:42 AM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH-V2 3/4] AM35x: Add support for AM3517EVM
> 
> Dear hvaib...@ti.com,
> 
> In message <1272034546-26041-5-git-send-email-hvaib...@ti.com> you wrote:
> > From: Vaibhav Hiremath 
> >
> > This patch adds basic support for the AM3517EVM.
> > It includes:
> > - Board int file (.c and .h)
> > - Default configuration file
> > - Updates for Makefile
> >
> > Signed-off-by: Vaibhav Hiremath 
> > Signed-off-by: Sanjeev Premi 
> > ---
> >  Makefile  |3 +
> >  arch/arm/include/asm/arch-omap3/mux.h |   36 +++
> >  board/logicpd/am3517evm/Makefile  |   47 
> >  board/logicpd/am3517evm/am3517evm.c   |   76 ++
> >  board/logicpd/am3517evm/am3517evm.h   |  405
> +
> >  board/logicpd/am3517evm/config.mk |   30 +++
> >  include/configs/am3517_evm.h  |  297 
> >  7 files changed, 894 insertions(+), 0 deletions(-)
> >  create mode 100644 board/logicpd/am3517evm/Makefile
> >  create mode 100644 board/logicpd/am3517evm/am3517evm.c
> >  create mode 100644 board/logicpd/am3517evm/am3517evm.h
> >  create mode 100644 board/logicpd/am3517evm/config.mk
> >  create mode 100644 include/configs/am3517_evm.h
> 
> Entries to MAKEALL and MAINTAINERS missing.
[Hiremath, Vaibhav] Ok, will add this in next version.

> 
> > diff --git a/Makefile b/Makefile
> > index 34f10ce..487ae73 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -3169,6 +3169,9 @@ omap3_zoom1_config :  unconfig
> >  omap3_zoom2_config :   unconfig
> > @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd omap3
> >
> > +am3517_evm_config :    unconfig
> > +   @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 am3517evm logicpd omap3
> > +
> >  smdkc100_config:   unconfig
> > @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 smdkc100 samsung s5pc1xx
> 
> Please keep list sorted.
> 
[Hiremath, Vaibhav] ok, will move up.

> > diff --git a/arch/arm/include/asm/arch-omap3/mux.h
> b/arch/arm/include/asm/arch-omap3/mux.h
> > index 0c01c73..8ea47b6 100644
> > --- a/arch/arm/include/asm/arch-omap3/mux.h
> > +++ b/arch/arm/include/asm/arch-omap3/mux.h
> > @@ -283,6 +283,7 @@
> >  /*Control and debug */
> >  #define CONTROL_PADCONF_SYS_32K        0x0A04
> >  #define CONTROL_PADCONF_SYS_CLKREQ 0x0A06
> > +#define CONTROL_PADCONF_SYS_NRESWARM   0x0A08
> >  #define CONTROL_PADCONF_SYS_NIRQ   0x01E0
> >  #define CONTROL_PADCONF_SYS_BOOT0  0x0A0A
> >  #define CONTROL_PADCONF_SYS_BOOT1  0x0A0C
> 
> CONTROL_PADCONF_SYS_NIRQ looks out of place here. 
[Hiremath, Vaibhav] ok I will place it appropriately.

> And all this asks
> to be converted into a proper C struct.
[Hiremath, Vaibhav] This is following up the existing way of configuration like 
all other OMAP devices. I do agree that we need to clean this up.

Can it be done in sub-sequent series of patches on top of this? Let AM3517EVm 
support goes in. What's your opinion on this?

> 
> > diff --git a/board/logicpd/am3517evm/Makefile
> b/board/logicpd/am3517evm/Makefile
> > new file mode 100644
> > index 000..3c71fef
> > --- /dev/null
> > +++ b/board/logicpd/am3517evm/Makefile
> ...
> > +include $(SRCTREE)/rules.mk
> > +
> > +sinclude $(obj).depend
> > +
> 
> Don't add trailing empty lines. [Please check & fix globally.]
> 
[Hiremath, Vaibhav] Ok, I will cross-check and will fix in next version.

Thanks,
Vaibhav

> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> Any sufficiently advanced technology is indistinguishable from magic.
> Clarke's Third Law   - _Profiles of the Future_ (1962; rev. 1973)
>   ``Hazards of Prophecy: The Failure of Imagination''
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V2 2/4] omap3: Consolidate SDRC related operations

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Thursday, May 06, 2010 1:38 AM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH-V2 2/4] omap3: Consolidate SDRC related
> operations
> 
> Dear hvaib...@ti.com,
> 
[Hiremath, Vaibhav] Thanks Denk for your comments, see my response below -

> In message <1272034546-26041-4-git-send-email-hvaib...@ti.com> you wrote:
> > From: Vaibhav Hiremath 
> >
> > Consolidated SDRC related functions into one file - sdrc.c
> >
> > And also replaced sdrc_init with generic memory init
> > function (mem_init), this generalization of omap memory setup
> > is necessary to support the new emif4 interface introduced in AM3517.
> >
> > Signed-off-by: Vaibhav Hiremath 
> > Signed-off-by: Sanjeev Premi 
> 
> > diff --git a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > index 136b163..8cc7802 100644
> > --- a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > +++ b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > @@ -33,6 +33,9 @@ COBJS += board.o
> >  COBJS  += clock.o
> >  COBJS  += gpio.o
> >  COBJS  += mem.o
> > +ifdef  CONFIG_SDRC
> > +COBJS  += sdrc.o
> > +endif
> 
> Please don't use 'ifdef" here; instead, use `COBJS-$(CONFIG_SDRC)'
[Hiremath, Vaibhav] ok, will incorporate in next version.


> 
> > diff --git a/arch/arm/include/asm/arch-omap3/cpu.h
> b/arch/arm/include/asm/arch-omap3/cpu.h
> > index aa8de32..a49af10 100644
> > --- a/arch/arm/include/asm/arch-omap3/cpu.h
> > +++ b/arch/arm/include/asm/arch-omap3/cpu.h
> > @@ -183,6 +183,7 @@ struct sms {
> >  /* SDRC */
> >  #ifndef __KERNEL_STRICT_NAMES
> >  #ifndef __ASSEMBLY__
> > +#if defined(CONFIG_SDRC)
> >  struct sdrc_cs {
> > u32 mcfg;   /* 0x80 || 0xB0 */
> > u32 mr;     /* 0x84 || 0xB4 */
> > @@ -215,6 +216,8 @@ struct sdrc {
> > u8 res4[0xC];
> > struct sdrc_cs cs[2];   /* 0x80 || 0xB0 */
> >  };
> > +
> > +#endif /* CONFIG_SDRC */
> 
> I don't like such a #ifdef here - it is absolutely necessary? Why?
> 
[Hiremath, Vaibhav] Denk,

This is common file being used for all OMAP series of devices (OMAP2, OMAP3 and 
AM35x family) and OMAP2/3 family supports SDRC controller and AM35x family 
support EMIF4.

And due to this difference we need to add this #ifdef.

> > diff --git a/arch/arm/include/asm/arch-omap3/sys_proto.h
> b/arch/arm/include/asm/arch-omap3/sys_proto.h
> > index 34bd515..34e4e0d 100644
> > --- a/arch/arm/include/asm/arch-omap3/sys_proto.h
> > +++ b/arch/arm/include/asm/arch-omap3/sys_proto.h
> > @@ -31,8 +31,10 @@ void prcm_init(void);
> >  void per_clocks_enable(void);
> >
> >  void memif_init(void);
> > +#if defined(CONFIG_SDRC)
> >  void sdrc_init(void);
> >  void do_sdrc_init(u32, u32);
> > +#endif
> 
> Ditto - please drop this #ifdef.
> 
[Hiremath, Vaibhav] Same as above.

Thanks,
Vaibhav

> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> People seldom know what they want until you give them what  they  ask
> for.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RESEND:PATCH-V4] OMAP3EVM: Added NAND support

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Thursday, May 06, 2010 1:31 AM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [RESEND:PATCH-V4] OMAP3EVM: Added NAND support
> 
> Dear hvaib...@ti.com,
> 
> In message <1272034546-26041-2-git-send-email-hvaib...@ti.com> you wrote:
> >
> > diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
> > index 0d99f7d..1d31731 100644
> > --- a/include/configs/omap3_evm.h
> > +++ b/include/configs/omap3_evm.h
> > @@ -151,7 +151,8 @@
> >
> >  #define CONFIG_CMD_I2C /* I2C serial bus support   */
> >  #define CONFIG_CMD_MMC /* MMC support  */
> > -#define CONFIG_CMD_ONENAND /* ONENAND support  */
> > +#undef CONFIG_CMD_ONENAND  /* ONENAND support  */
> 
> Please do not #undef what is not #define'd anyway.
> 
[Hiremath, Vaibhav] This was the initial comment received from Nishanth Menon 
on very first path, and that's where I added undef line.

The initial patch was something -

> -#define CONFIG_CMD_ONENAND /* ONENAND support  */
> +/*#define CONFIG_CMD_ONENAND*/ /* ONENAND support  */
> +#define CONFIG_CMD_NAND/* NAND support */

I do agree that we don't have to undef here, but agreed to Nishant's comment 
only because from user point of view, if user would like to enable ONENAND 
support then for him it's easy he just have to comment NAND line and make 
change this #define. He doesn't have to dig inside code to find out whether 
ONENAND is supported or not.


Thanks,
Vaibhav

> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> What is tolerance? -- it is the consequence of humanity. We  are  all
> formed  of frailty and error; let us pardon reciprocally each other's
> folly -- that is the first law of nature.  - Voltaire
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH-V2 0/4] Add Support for AM3517EVM with EMIF4

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Friday, April 23, 2010 8:26 PM
> To: u-boot@lists.denx.de
> Cc: Paulraj, Sandeep; tom@windriver.com; Hiremath, Vaibhav
> Subject: [PATCH-V2 0/4] Add Support for AM3517EVM with EMIF4
> 
> From: Vaibhav Hiremath 
> 
> Changes from V1 (comments provided by Tom Rix):
>   - Refreshed against latest denx/master.
>   - Further split SDRC consolidated patch, since it was
> fixing up one issue in dram_init in addition to code
> moment.
>   - Retained copyright for sdrc.c file, since it is
> barely a code moment.
> 
> AM3517 device is high-performance, industrial applications
> processor designed and developed keeping Software Compatible
> with OMAP3 Processors.
> 
> Differances :-
> ===
>   - The SDRC controller has been replaced with EMIF4.
>   - Some new IP's got added like, CAN, VPFE, etc...
>   - Removed ISP completely
> 
> This patch series adds support for AM3517EVM along with EMIF4 configuration.
> 
> Tested :-
> ===
>   - OMAP3 EVM (both NAND and MMC boot mode)
>   - AM3517 EVM (both NAND and MMC boot mode)
> 
> Build tested on all OMAP3 platforms.
> 
> Below are some of the useful links :-
> ===
> AM3517 device is high-performance, industrial applications processor
> designed
> and developed keeping Software Compatible with OMAP3 Processors.
> 
> Below are some of the useful links -
> 
> Migration from OMAP35x to AM35x :-
> http://focus.ti.com/lit/an/sprab91/sprab91.pdf
> 
> Specs/TRM :-
> http://focus.ti.com/docs/prod/folders/print/am3517.html
> 
> EVM Link -:
> http://www.logicpd.com/products/development-kits/zoom-am3517-experimenter-
> kit
> 
> 
> Vaibhav Hiremath (4):
>   omap3: Calculate CS1 size only when SDRC is initialized for CS1
>   omap3: Consolidate SDRC related operations
>   AM35x: Add support for AM3517EVM
>   AM35x: Add support for EMIF4
> 
>  Makefile|3 +
>  arch/arm/cpu/arm_cortexa8/omap3/Makefile|6 +
>  arch/arm/cpu/arm_cortexa8/omap3/board.c |   34 +---
>  arch/arm/cpu/arm_cortexa8/omap3/emif4.c |  168 +++
>  arch/arm/cpu/arm_cortexa8/omap3/mem.c   |   90 --
>  arch/arm/cpu/arm_cortexa8/omap3/sdrc.c  |  202 +
>  arch/arm/cpu/arm_cortexa8/omap3/sys_info.c  |   41 ---
>  arch/arm/include/asm/arch-omap3/cpu.h   |   27 ++
>  arch/arm/include/asm/arch-omap3/emif4.h |   79 ++
>  arch/arm/include/asm/arch-omap3/mem.h   |   13 +
>  arch/arm/include/asm/arch-omap3/mux.h   |   36 +++
>  arch/arm/include/asm/arch-omap3/sys_proto.h |7 +-
>  board/logicpd/am3517evm/Makefile|   47 +++
>  board/logicpd/am3517evm/am3517evm.c |   76 +
>  board/logicpd/am3517evm/am3517evm.h |  405
> +++
>  board/logicpd/am3517evm/config.mk   |   30 ++
>  include/configs/am3517_evm.h|  297 
>  include/configs/devkit8000.h|2 +
>  include/configs/omap3_beagle.h  |2 +
>  include/configs/omap3_evm.h |2 +
>  include/configs/omap3_overo.h   |2 +
>  include/configs/omap3_pandora.h |2 +
>  include/configs/omap3_sdp3430.h |2 +
>  include/configs/omap3_zoom1.h   |2 +
>  include/configs/omap3_zoom2.h   |2 +
>  25 files changed, 1411 insertions(+), 166 deletions(-)
>  create mode 100644 arch/arm/cpu/arm_cortexa8/omap3/emif4.c
>  create mode 100644 arch/arm/cpu/arm_cortexa8/omap3/sdrc.c
>  create mode 100644 arch/arm/include/asm/arch-omap3/emif4.h
>  create mode 100644 board/logicpd/am3517evm/Makefile
>  create mode 100644 board/logicpd/am3517evm/am3517evm.c
>  create mode 100644 board/logicpd/am3517evm/am3517evm.h
>  create mode 100644 board/logicpd/am3517evm/config.mk
>  create mode 100644 include/configs/am3517_evm.h

[Hiremath, Vaibhav] Tom,

A gentle reminder to review this series on patch-sets.

Thanks,
Vaibhav
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/3] OMAP3: Consolidate SDRC related operations

[Hiremath, Vaibhav]

> -Original Message-
> From: Tom [mailto:tom@windriver.com]
> Sent: Sunday, February 07, 2010 9:44 PM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de; Paulraj, Sandeep; Premi, Sanjeev
> Subject: Re: [PATCH 1/3] OMAP3: Consolidate SDRC related operations
> 
> hvaib...@ti.com wrote:
> > From: Vaibhav Hiremath 
> >
> > Consolidated all SDRC related functions/operations into separate
> > file - sdrc.c.
> 
> Please add a long comment to explain why this is necessary.
> Something like..
> 'Generalizing omap memory setup is necessary to support the new
> emif4 interface
> that for am3517 uses.. '
[Hiremath, Vaibhav] Ok, will update in next version.

> 
> >
> > Signed-off-by: Vaibhav Hiremath 
> > Signed-off-by: Sanjeev Premi 
> 
> There is a regression.
> Please check devkit8000
> cpu/arm_cortexa8/omap3/libomap3.a(board.o): In function
> `checkboard':
> .../cpu/arm_cortexa8/omap3/board.c:313: undefined reference to
> `is_mem_sdr'
> cpu/arm_cortexa8/omap3/libomap3.a(board.o): In function `s_init':
> .../cpu/arm_cortexa8/omap3/board.c:228: undefined reference to
> `mem_init'
> cpu/arm_cortexa8/omap3/libomap3.a(mem.o): In function `mem_ok':
> .../cpu/arm_cortexa8/omap3/mem.c:92: undefined reference to
> `get_sdr_cs_offset'
> lib_arm/libarm.a(board.o):(.data+0x28): undefined reference to
> `dram_init'
> 
> The biggest problem with this patch is that though the comment says
> it is
> a code movement patch, it has other changes it in.  These changes
> must
> be separated into its own patch(s).
> 
> Because of these problems, this is only a partial review.
[Hiremath, Vaibhav] I will separate such changes into separate commit and 
submit it to list.

> 
> > ---
> >  cpu/arm_cortexa8/omap3/Makefile|3 +
> >  cpu/arm_cortexa8/omap3/board.c |   34 +--
> 
> 
> 
> > u32 size)
> >  {
> > diff --git a/cpu/arm_cortexa8/omap3/sdrc.c
> b/cpu/arm_cortexa8/omap3/sdrc.c
> > new file mode 100644
> > index 000..9a46155
> > --- /dev/null
> > +++ b/cpu/arm_cortexa8/omap3/sdrc.c
> > @@ -0,0 +1,186 @@
> > +/*
> > + * Functions related to SDRC.
> > + *
> > + * This file has been created after exctracting and consolidating
> > + * the SDRC related content from mem.c and board.c.
> > + *
> > + * Copyright (C) 2009 Texas Instruments Incorporated -
> http://www.ti.com/
> > + *
> 
> Because this is code movement, include the original copyrights
[Hiremath, Vaibhav] Ok, will update in next version.

> 
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of
> > + * the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be
> useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public
> License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > + * MA 02111-1307 USA
> > + */
> > +
> 
> 
> 
> > +
> > +   if (!mem_ok(cs))
> > +   writel(0, &sdrc_base->cs[cs].mcfg);
> > +}
> > +
> > +/**
> 
> Follow the multi-line comment.
> Remove the extra '*'
> This happens other places in this patch.
> Fix globally
[Hiremath, Vaibhav] Ok.

Thanks Tom for the review, I will update the patch series and submit it again.

Thanks,
Vaibhav

> 
> > + * dram_init - Sets uboots idea of sdram size
> > + */
> > +int dram_init(void)
> > +{
> > +   DECLARE_GLOBAL_DATA_PTR;
> > +   unsigned int size0 = 0, size1 = 0;
> > +
> > +   size0 = get_sdr_cs_size(CS0);
> > +   /*
> > +* If a second bank of DDR is attached to CS1 this is
> > +* where it can be started.  Early init code will init
> > +* memory on CS0.
> > +*/
> > +   if ((sysinfo.mtype == DDR_COMBO) || (sysinfo.mtype ==
> DDR_STACKED)) {
> > +   do_sdrc_init(CS1, NOT_EARLY);
> > +   make_cs1_contiguous();
> > +
> > +   size1 = get_sdr_cs_size(CS1);
> 
> This is different that a code movement change.
> The comment of the change does not match what you have done.
> Split the real changes into a separate patch.
> 
> Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/3] Add Support for AM3517EVM with EMIF4

[Hiremath, Vaibhav]

> -Original Message-
> From: Tom [mailto:tom@windriver.com]
> Sent: Wednesday, February 03, 2010 6:54 PM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de; Paulraj, Sandeep
> Subject: Re: [PATCH 0/3] Add Support for AM3517EVM with EMIF4
> 
> Hiremath, Vaibhav wrote:
> >> -Original Message-
> >> From: Hiremath, Vaibhav
> >> Sent: Saturday, January 30, 2010 3:47 PM
> >> To: u-boot@lists.denx.de
> >> Cc: Paulraj, Sandeep; tom@windriver.com; Hiremath, Vaibhav
> >> Subject: [PATCH 0/3] Add Support for AM3517EVM with EMIF4
> >>
> >> From: Vaibhav Hiremath 
> >>
> 
> 
> >>
> > [Hiremath, Vaibhav] Sandeep,
> >
> > Can you please merge these series of patches for next window?
> >
> 
> This patchset still needs to be reviewed.
> I will post my review this weekend.
[Hiremath, Vaibhav] Review comments are always welcomed. Since this is second 
version and we haven't had any comments last time. I requested to merge.

Looking forward for your comments.

Thanks,
Vaibhav

> Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/3] Add Support for AM3517EVM with EMIF4

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Saturday, January 30, 2010 3:47 PM
> To: u-boot@lists.denx.de
> Cc: Paulraj, Sandeep; tom@windriver.com; Hiremath, Vaibhav
> Subject: [PATCH 0/3] Add Support for AM3517EVM with EMIF4
> 
> From: Vaibhav Hiremath 
> 
> AM3517 device is high-performance, industrial applications processor
> designed
> and developed keeping Software Compatible with OMAP3 Processors.
> 
> Differances :-
> ===
>   - The SDRC controller has been replaced with EMIF4.
>   - Some new IP's got added like, CAN, VPFE, etc...
>   - Removed ISP completely
> 
> This patch series adds support for AM3517EVM along with EMIF4
> configuration.
> 
> Tested :-
> ===
>   - OMAP3 EVM (both NAND and MMC boot mode)
>   - OMAP3 BEAGLE (MMC boot mode)
>   - AM3517 EVM (both NAND and MMC boot mode)
> 
> Below are some of the useful links :-
> ===
> AM3517 device is high-performance, industrial applications processor
> designed
> and developed keeping Software Compatible with OMAP3 Processors.
> 
> Below are some of the useful links -
> 
> Migration from OMAP35x to AM35x :-
> http://focus.ti.com/lit/an/sprab91/sprab91.pdf
> 
> Specs/TRM :-
> http://focus.ti.com/docs/prod/folders/print/am3517.html
> 
> EVM Link -:
> http://www.logicpd.com/products/development-kits/zoom-am3517-
> experimenter-kit
> 
> 
> Vaibhav Hiremath (3):
>   OMAP3: Consolidate SDRC related operations
>   AM35x: Add support for AM3517EVM
>   AM35x: Add support for EMIF4
> 
[Hiremath, Vaibhav] Sandeep,

Can you please merge these series of patches for next window?

Thanks,
Vaibhav

>  MAINTAINERS|4 +
>  Makefile   |3 +
>  board/ti/am3517evm/Makefile|   47 
>  board/ti/am3517evm/am3517evm.c |   76 ++
>  board/ti/am3517evm/am3517evm.h |  400
> 
>  board/ti/am3517evm/config.mk   |   29 +++
>  cpu/arm_cortexa8/omap3/Makefile|6 +
>  cpu/arm_cortexa8/omap3/board.c |   34 +---
>  cpu/arm_cortexa8/omap3/emif4.c |  160 +
>  cpu/arm_cortexa8/omap3/mem.c   |   90 ---
>  cpu/arm_cortexa8/omap3/sdrc.c  |  186 +++
>  cpu/arm_cortexa8/omap3/sys_info.c  |   42 +
>  include/asm-arm/arch-omap3/cpu.h   |   26 ++
>  include/asm-arm/arch-omap3/emif4.h |   77 ++
>  include/asm-arm/arch-omap3/mem.h   |   24 ++
>  include/asm-arm/arch-omap3/mux.h   |   35 +++
>  include/asm-arm/arch-omap3/sys_proto.h |7 +-
>  include/configs/am3517_evm.h   |  293
> +++
>  include/configs/omap3_beagle.h |2 +
>  include/configs/omap3_evm.h|2 +
>  include/configs/omap3_overo.h  |2 +
>  include/configs/omap3_pandora.h|2 +
>  include/configs/omap3_sdp3430.h|2 +
>  include/configs/omap3_zoom1.h  |2 +
>  include/configs/omap3_zoom2.h  |2 +
>  25 files changed, 1387 insertions(+), 166 deletions(-)
>  create mode 100644 board/ti/am3517evm/Makefile
>  create mode 100644 board/ti/am3517evm/am3517evm.c
>  create mode 100644 board/ti/am3517evm/am3517evm.h
>  create mode 100644 board/ti/am3517evm/config.mk
>  create mode 100644 cpu/arm_cortexa8/omap3/emif4.c
>  create mode 100644 cpu/arm_cortexa8/omap3/sdrc.c
>  create mode 100644 include/asm-arm/arch-omap3/emif4.h
>  create mode 100644 include/configs/am3517_evm.h

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-ti master

[Hiremath, Vaibhav]

> -Original Message-
> From: u-boot-boun...@lists.denx.de [mailto:u-boot-
> boun...@lists.denx.de] On Behalf Of s-paul...@ti.com
> Sent: Friday, January 29, 2010 2:36 AM
> To: u-boot@lists.denx.de; tom@windriver.com
> Subject: [U-Boot] Please pull u-boot-ti master
> 
> Tom,
> 
> Please pull u-boot-ti master.
> 
> Thanks,
> Sandeep
> 
> The following changes since commit
> 797312a15edc9dfb433e6903a75189030e7a:
>   Wolfgang Denk (1):
> Merge branch 'master' of git://git.denx.de/u-boot-mpc83xx
> 
[Hiremath, Vaibhav] Sandeep,

Can you merge below patch also, 

4803  11/23 hvaib...@ti.com[U-Boot] [PATCH V4] OMAP3EVM: Added NAND support

I am about to submit the other patches also.

Thanks,
Vaibhav

> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-ti.git master
> 
> Ladislav Michl (3):
>   NetStar: Disable CONFIG_CMD_JFFS2
>   NetStar: make crcit utility more readable
>   NetStar: Remove debug junk leaked into eeprom utility
> 
> Nick Thompson (1):
>   da830evm: Use table driven pin mux configuration
> 
> Scott Ellis (1):
>   Overo GPMC registers
> 
> Sekhar Nori (1):
>   TI DaVinci: Driver for the davinci SPI controller
> 
> Tom Rix (1):
>   OMAP3 Move declaration of gpmc_cfg.
> 
>  board/davinci/da830evm/da830evm.c |   35 +++---
>  board/netstar/crcit.c |9 +-
>  board/netstar/eeprom.c|8 +-
>  board/netstar/eeprom_start.S  |  166 +-
> --
>  board/overo/overo.c   |   14 +-
>  board/overo/overo.h   |9 ++
>  drivers/spi/Makefile  |1 +
>  drivers/spi/davinci_spi.c |  223
> +
>  drivers/spi/davinci_spi.h |  101 +
>  include/asm-arm/arch-omap3/cpu.h  |4 +
>  include/configs/devkit8000.h  |1 -
>  include/configs/netstar.h |3 -
>  include/configs/omap3_beagle.h|1 -
>  include/configs/omap3_evm.h   |1 -
>  include/configs/omap3_overo.h |1 -
>  include/configs/omap3_pandora.h   |1 -
>  include/configs/omap3_sdp3430.h   |1 -
>  include/configs/omap3_zoom1.h |1 -
>  include/configs/omap3_zoom2.h |1 -
>  19 files changed, 369 insertions(+), 212 deletions(-)
>  create mode 100644 drivers/spi/davinci_spi.c
>  create mode 100644 drivers/spi/davinci_spi.h
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] u-boot fails to read from nand flash in omap3

[Hiremath, Vaibhav]

> -Original Message-
> From: u-boot-boun...@lists.denx.de [mailto:u-boot-
> boun...@lists.denx.de] On Behalf Of fgd
> Sent: Tuesday, January 19, 2010 1:52 PM
> To: u-boot@lists.denx.de
> Subject: [U-Boot] u-boot fails to read from nand flash in omap3
> 
> 
>  Hi everyone,
> I've recently been playing with an omap3 beagle board and I've found
> a
> problem that I think involves the reading of nand memory...
> I have recompiled u-boot for the beagle board (I just changed its
> prompt, as
> a simple test to check that it's my u-boot and not the one that was
> there
[Hiremath, Vaibhav] U-Boot version may be useful here.

> before, and I used the default configs for the beagle), then I have
> loaded
> u-boot and the x-loader into flash, and I have succesfully rebooted
> and seen
> 'my' u-boot prompt...
> after that, I wanted to load a linux kernel and a file system into
> nand
> flash, instead of using the external memory card (if I boot a kernel
> stored
> there, it works), so I go and load an uImage into flash, then read
> it back
> to RAM, and boot from there, and it still works, BUT, as soon as I
> reset the
> OMAP, when it tries to copy the kernel data stored in flash into RAM
> to boot
> from it, the nand reading operation will fail, and if I try to boot
> that
> kernel it will complain about a CRC checksum error...
> the exact error looks like this:
> #  nand read ${loadaddr} 28 40
> 
> NAND read: device 0 offset 0x28, size 0x40
> NAND read from offset 28 failed -74
> 
[Hiremath, Vaibhav] Can you please provide exact steps which you are following 
for NAND write and read operation?

> note that this just happens after I reset the board... I thought it
> could be
> a hardware problem with my board, but I've tried in a different
> board (an
> omap3 evm) and I'm getting the same thing, so I think I might be
> missing
[Hiremath, Vaibhav] I am working on OMAP3EVM and it is working fine for me. It 
looks like somehow NAND is getting corrupted, detailed steps required to 
comment anything on this.

Thanks,
Vaibhav

> something...
> has anyone of you tried something like this or has encountered any
> similar
> problem? any help will be greatly appreciated, if you need any extra
> info
> about what I have done just tell me...
> thanks a lot in advance, regards
> 
> Fernando
> --
> View this message in context: http://old.nabble.com/u-boot-fails-to-
> read-from-nand-flash-in-omap3-tp27222315p27222315.html
> Sent from the Uboot - Users mailing list archive at Nabble.com.
> 
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] OMAP3 EVM board nand support missed

[Hiremath, Vaibhav]

> -Original Message-
> From: u-boot-boun...@lists.denx.de [mailto:u-boot-
> boun...@lists.denx.de] On Behalf Of Arno Steffen
> Sent: Monday, January 18, 2010 5:19 PM
> To: u-boot@lists.denx.de
> Subject: [U-Boot] OMAP3 EVM board nand support missed
> 
> Testing the latest release (2009-08) I missed the NAND support
> (there
> is just ONENAND).
[Hiremath, Vaibhav] latest stable u-boot version is 2009-11.
> Adding the line in config
> #define CONFIG_CMD_NAND   /* NAND support */
> cause a error in building uboot:
> ...drivers/mtd/nand/libnand.a(nand.o): In function `nand_init_chip':
> /opt/src/ub/u-boot-ti-git-2009-08/drivers/mtd/nand/nand.c:53:
> undefined reference to `board_nand_init'
> make: *** [u-boot] Fehler 1
> 
[Hiremath, Vaibhav] There are some more definitions you must add to your header 
file to build NAND support. please refer to the patch,


http://www.mail-archive.com/u-boot@lists.denx.de/msg25521.html

Thanks,
Vaibhav


> Is this intentionally not supported anymore? What's to do to get
> nand
> support for my board?
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/3] omap3: Consolidate SDRC related operations

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Wednesday, December 23, 2009 8:16 PM
> To: u-boot@lists.denx.de
> Cc: Hiremath, Vaibhav; Premi, Sanjeev
> Subject: [PATCH 1/3] omap3: Consolidate SDRC related operations
>
> Consolidated SDRC related functions into one
> file - sdrc.c.
>
> Signed-off-by: Sanjeev Premi 
> ---
>  cpu/arm_cortexa8/omap3/Makefile|3 +
>  cpu/arm_cortexa8/omap3/board.c |   34 +--
>  cpu/arm_cortexa8/omap3/mem.c   |   70 -
>  cpu/arm_cortexa8/omap3/sdrc.c  |  169
> 
>  cpu/arm_cortexa8/omap3/sys_info.c  |   42 +
>  include/asm-arm/arch-omap3/mem.h   |   14 +++
>  include/asm-arm/arch-omap3/sys_proto.h |4 +-
>  include/configs/omap3_beagle.h |2 +
>  include/configs/omap3_evm.h|2 +
>  include/configs/omap3_overo.h  |2 +
>  include/configs/omap3_pandora.h|2 +
>  include/configs/omap3_sdp3430.h|2 +
>  include/configs/omap3_zoom1.h  |2 +
>  include/configs/omap3_zoom2.h  |2 +
>  14 files changed, 204 insertions(+), 146 deletions(-)
>  create mode 100644 cpu/arm_cortexa8/omap3/sdrc.c
>
[Hiremath, Vaibhav] Hi Tom and Sandeep,

We do not any review comments on this; can we merge these series of patches? I 
may required to refresh these patches against tip, please do let me know your 
opinion on this.

Thanks,
Vaibhav

> diff --git a/cpu/arm_cortexa8/omap3/Makefile
> b/cpu/arm_cortexa8/omap3/Makefile
> index 136b163..8cc7802 100644
> --- a/cpu/arm_cortexa8/omap3/Makefile
> +++ b/cpu/arm_cortexa8/omap3/Makefile
> @@ -33,6 +33,9 @@ COBJS   += board.o
>  COBJS+= clock.o
>  COBJS+= gpio.o
>  COBJS+= mem.o
> +ifdefCONFIG_SDRC
> +COBJS+= sdrc.o
> +endif
>  COBJS+= syslib.o
>  COBJS+= sys_info.o
>  COBJS+= timer.o
> diff --git a/cpu/arm_cortexa8/omap3/board.c
> b/cpu/arm_cortexa8/omap3/board.c
> index 2aa69b3..0bad682 100644
> --- a/cpu/arm_cortexa8/omap3/board.c
> +++ b/cpu/arm_cortexa8/omap3/board.c
> @@ -40,8 +40,6 @@
>
>  extern omap3_sysinfo sysinfo;
>
> -extern u32 is_mem_sdr(void);
> -
>
> /***
> ***
>   * Routine: delay
>   * Description: spinning delay to use before udelay works
> @@ -227,7 +225,7 @@ void s_init(void)
>   per_clocks_enable();
>
>   if (!in_sdram)
> - sdrc_init();
> + mem_init();
>  }
>
>
> /***
> ***
> @@ -268,36 +266,6 @@ void watchdog_init(void)
>  }
>
>
> /***
> ***
> - * Routine: dram_init
> - * Description: sets uboots idea of sdram size
> -
> 
> */
> -int dram_init(void)
> -{
> - DECLARE_GLOBAL_DATA_PTR;
> - unsigned int size0 = 0, size1 = 0;
> -
> - /*
> -  * If a second bank of DDR is attached to CS1 this is
> -  * where it can be started.  Early init code will init
> -  * memory on CS0.
> -  */
> - if ((sysinfo.mtype == DDR_COMBO) || (sysinfo.mtype ==
> DDR_STACKED)) {
> - do_sdrc_init(CS1, NOT_EARLY);
> - make_cs1_contiguous();
> - }
> -
> - size0 = get_sdr_cs_size(CS0);
> - size1 = get_sdr_cs_size(CS1);
> -
> - gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
> - gd->bd->bi_dram[0].size = size0;
> - gd->bd->bi_dram[1].start = PHYS_SDRAM_1 +
> get_sdr_cs_offset(CS1);
> - gd->bd->bi_dram[1].size = size1;
> -
> - return 0;
> -}
> -
> -
> /***
> ***
>   * Dummy function to handle errors for EABI incompatibility
>
> 
> */
>  void abort(void)
> diff --git a/cpu/arm_cortexa8/omap3/mem.c
> b/cpu/arm_cortexa8/omap3/mem.c
> index dfb7e4c..107ffb2 100644
> --- a/cpu/arm_cortexa8/omap3/mem.c
> +++ b/cpu/arm_cortexa8/omap3/mem.c
> @@ -123,76 +123,6 @@ u32 mem_ok(u32 cs)
>   return 1;
>  }
>
> -/
> - *  sdrc_init() - init the sdrc chip selects CS0 and CS1
> - *  - early init routines, called from flash or
> - *  SRAM.
> - ***/
> -void sdrc_init(void)
> -{
> - /* only init up first bank here */
> - do_sdrc_i

Re: [U-Boot] [PATCH 1/3] omap3: Consolidate SDRC related operations

[Hiremath, Vaibhav]

> -Original Message-
> From: Hiremath, Vaibhav
> Sent: Wednesday, December 23, 2009 8:16 PM
> To: u-boot@lists.denx.de
> Cc: Hiremath, Vaibhav; Premi, Sanjeev
> Subject: [PATCH 1/3] omap3: Consolidate SDRC related operations
>
> Consolidated SDRC related functions into one
> file - sdrc.c.
>
> Signed-off-by: Sanjeev Premi 
> ---
>  cpu/arm_cortexa8/omap3/Makefile|3 +
>  cpu/arm_cortexa8/omap3/board.c |   34 +--
>  cpu/arm_cortexa8/omap3/mem.c   |   70 -
>  cpu/arm_cortexa8/omap3/sdrc.c  |  169
> 
>  cpu/arm_cortexa8/omap3/sys_info.c  |   42 +
>  include/asm-arm/arch-omap3/mem.h   |   14 +++
>  include/asm-arm/arch-omap3/sys_proto.h |4 +-
>  include/configs/omap3_beagle.h |2 +
>  include/configs/omap3_evm.h|2 +
>  include/configs/omap3_overo.h  |2 +
>  include/configs/omap3_pandora.h|2 +
>  include/configs/omap3_sdp3430.h|2 +
>  include/configs/omap3_zoom1.h  |2 +
>  include/configs/omap3_zoom2.h  |2 +
>  14 files changed, 204 insertions(+), 146 deletions(-)
>  create mode 100644 cpu/arm_cortexa8/omap3/sdrc.c
>
[Hiremath, Vaibhav] Hi,
Any update on this? If we do not have any comments then can we merge these 
patches?

Thanks,
Vaibhav

> diff --git a/cpu/arm_cortexa8/omap3/Makefile
> b/cpu/arm_cortexa8/omap3/Makefile
> index 136b163..8cc7802 100644
> --- a/cpu/arm_cortexa8/omap3/Makefile
> +++ b/cpu/arm_cortexa8/omap3/Makefile
> @@ -33,6 +33,9 @@ COBJS   += board.o
>  COBJS+= clock.o
>  COBJS+= gpio.o
>  COBJS+= mem.o
> +ifdefCONFIG_SDRC
> +COBJS+= sdrc.o
> +endif
>  COBJS+= syslib.o
>  COBJS+= sys_info.o
>  COBJS+= timer.o
> diff --git a/cpu/arm_cortexa8/omap3/board.c
> b/cpu/arm_cortexa8/omap3/board.c
> index 2aa69b3..0bad682 100644
> --- a/cpu/arm_cortexa8/omap3/board.c
> +++ b/cpu/arm_cortexa8/omap3/board.c
> @@ -40,8 +40,6 @@
>
>  extern omap3_sysinfo sysinfo;
>
> -extern u32 is_mem_sdr(void);
> -
>
> /***
> ***
>   * Routine: delay
>   * Description: spinning delay to use before udelay works
> @@ -227,7 +225,7 @@ void s_init(void)
>   per_clocks_enable();
>
>   if (!in_sdram)
> - sdrc_init();
> + mem_init();
>  }
>
>
> /***
> ***
> @@ -268,36 +266,6 @@ void watchdog_init(void)
>  }
>
>
> /***
> ***
> - * Routine: dram_init
> - * Description: sets uboots idea of sdram size
> -
> 
> */
> -int dram_init(void)
> -{
> - DECLARE_GLOBAL_DATA_PTR;
> - unsigned int size0 = 0, size1 = 0;
> -
> - /*
> -  * If a second bank of DDR is attached to CS1 this is
> -  * where it can be started.  Early init code will init
> -  * memory on CS0.
> -  */
> - if ((sysinfo.mtype == DDR_COMBO) || (sysinfo.mtype ==
> DDR_STACKED)) {
> - do_sdrc_init(CS1, NOT_EARLY);
> - make_cs1_contiguous();
> - }
> -
> - size0 = get_sdr_cs_size(CS0);
> - size1 = get_sdr_cs_size(CS1);
> -
> - gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
> - gd->bd->bi_dram[0].size = size0;
> - gd->bd->bi_dram[1].start = PHYS_SDRAM_1 +
> get_sdr_cs_offset(CS1);
> - gd->bd->bi_dram[1].size = size1;
> -
> - return 0;
> -}
> -
> -
> /***
> ***
>   * Dummy function to handle errors for EABI incompatibility
>
> 
> */
>  void abort(void)
> diff --git a/cpu/arm_cortexa8/omap3/mem.c
> b/cpu/arm_cortexa8/omap3/mem.c
> index dfb7e4c..107ffb2 100644
> --- a/cpu/arm_cortexa8/omap3/mem.c
> +++ b/cpu/arm_cortexa8/omap3/mem.c
> @@ -123,76 +123,6 @@ u32 mem_ok(u32 cs)
>   return 1;
>  }
>
> -/
> - *  sdrc_init() - init the sdrc chip selects CS0 and CS1
> - *  - early init routines, called from flash or
> - *  SRAM.
> - ***/
> -void sdrc_init(void)
> -{
> - /* only init up first bank here */
> - do_sdrc_init(CS0, EARLY_INIT);
> -}
> -
> -
> 

Re: [U-Boot] [PATCH 0/4] AM35x: Initial support for the processor

[Hiremath, Vaibhav]

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927
> -Original Message-
> From: Tom [mailto:tom@windriver.com]
> Sent: Wednesday, December 16, 2009 1:32 AM
> To: Premi, Sanjeev
> Cc: u-boot@lists.denx.de; Hiremath, Vaibhav; Paulraj, Sandeep
> Subject: Re: [U-Boot] [PATCH 0/4] AM35x: Initial support for the
> processor
> 
> Sanjeev Premi wrote:
> > This patchset adds basic support for the AM35x
> > processors. It also ensures that u-boot banner
> > shows correct processor at start-up.
> >
> > Addition of AM35x impacts existing code for OMAP3,
> > most patches in this set are applicable to both
> > processor families.
> >
> > The series has been tested on the OMAP3EVM and
> > AM3517EVM. To test on AM3517EVM, earlier patches
> > posted by Vaibhav are required.
> >
> >   [1] http://lists.denx.de/pipermail/u-boot/2009-
> November/064670.html
> >
> >
> 
> The am3517 support is not in.
> This patchset is dependent on it.
> These changes can only be reviewed casually until then.
> 
> Vaibhav,
> When will next rev of the am3517 changes be posted 
[Hiremath, Vaibhav] Tom,
I am bit busy with some outstanding issues on Linux kernel, but probably 
sometime next week I will be able to re-submit the patches.

Thanks,
Vaibhav

> 
> Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH V4] OMAP3EVM: Added NAND support

[Hiremath, Vaibhav]

> -Original Message-
> From: Tom [mailto:tom@windriver.com]
> Sent: Friday, November 27, 2009 9:21 PM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH V4] OMAP3EVM: Added NAND support
> 
> hvaib...@ti.com wrote:
> > From: Vaibhav Hiremath 
> >
> > The EVMS have been shipping with NAND (instead of OneNAND) as
> default. So, this
> > patch sets NAND as default.
> >
> > To choose OneNAND, define CMD_ONENAND instead of CMD_NAND in the
> config file
> > omap3_evm.h
> >
> > Changes from V3 :-
> > - Added undef statement for CMD_ONENAND.
> >
> 
> This is looking good.
> Is there interest in making the onenand a makefile config option?
> It would depend on how common the onenand boards are.
[Hiremath, Vaibhav] As far as I know, majority of the EVM's shipping out are 
with NAND parts, so should be safe to move to NAND as a default.

Thanks,
Vaibhav

> Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] omap3_mmc: Encapsulate twl4030 under option CONFIG_TWL4030_POWER

[Hiremath, Vaibhav]

> -Original Message-
> From: Tom [mailto:tom@windriver.com]
> Sent: Friday, November 27, 2009 7:34 PM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH] omap3_mmc: Encapsulate twl4030 under
> option CONFIG_TWL4030_POWER
> 
> hvaib...@ti.com wrote:
> > From: Vaibhav Hiremath 
> >
> > Fixes the build/compilation error if we try to re-use the
> omap3_mmc code
> > without TWL4030_POWER.
> >
> > Signed-off-by: Vaibhav Hiremath 
> 
> This is fine.
> I have pushed this to arm/next.
> 
[Hiremath, Vaibhav] Thanks, 

Thanks,
Vaibhav

> Thanks
> Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 5/5] AM3517: Add support for EMIF4

[Hiremath, Vaibhav]

> -Original Message-
> From: Tom [mailto:tom@windriver.com]
> Sent: Thursday, November 26, 2009 9:44 PM
> To: Hiremath, Vaibhav
> Cc: Wolfgang Denk; u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 5/5] AM3517: Add support for EMIF4
> 
> Hiremath, Vaibhav wrote:
> >> -Original Message-
> >> From: Wolfgang Denk [mailto:w...@denx.de]
> >> Sent: Tuesday, November 24, 2009 1:21 AM
> >> To: Hiremath, Vaibhav
> >> Cc: u-boot@lists.denx.de
> >> Subject: Re: [U-Boot] [PATCH 5/5] AM3517: Add support for EMIF4
> >>
> >> Dear hvaib...@ti.com,
> >>
> >> In message <1258974555-28173-1-git-send-email-hvaib...@ti.com>
> you
> >> wrote:
> >>> From: Vaibhav Hiremath 
> >>>
> >>> Changes:-
> >>>
> >>>   - Created 2 seperate config option
> >>>   * CONFIG_SDRC (omap34xx family)
> >>>   * CONFIG_EMIF4 (am3517 family)
> >>>   - Changed all omap3 dependent file for CONFIG_SDRC
> >>>
> >>> Tested On:-
> >>>
> >>> - AM3517EVM board
> >>> - OMAP3EVM board
> >>> - BEAGLE board
> >>>
> >>> I would need help here from people to validate this change for
> >> SDP/ZOOMx
> >>> and other OMAP3 version of boards.
> >> This commit adds a lot of  #ifdef's - maybe it would make more
> sense
> >> to split code into different files?
> >>
> > [Hiremath, Vaibhav] Initially I thought of this, but since
> currently AM3517 is the only device in OMAP3 series which uses EMIF
> and all others use SDRC. So I thought lets start with this approach
> and get peoples opinion on this, and then we can split the files.
> >
> 
> Please split this patch.
> Add the logic for the exiting boards as the first patch.
> Add the logic for the am3517 as the second.
> This will allow this change to be bisected.
> 
[Hiremath, Vaibhav] Ok, will do in next version.

> I would prefer each set of defines to have their own file.
[Hiremath, Vaibhav] How about taking this is second version?

Thanks,
Vaibhav

> 
> Tom
> 
> > Thanks,
> > Vaibhav
> >
> >> Best regards,
> >>
> >> Wolfgang Denk
> >>
> >> --
> >> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev
> >> Zundel
> >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> >> Germany
> >> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> >> w...@denx.de
> >> You are an excellent tactician, Captain. You let your second in
> >> com-
> >> mand attack while you sit and watch for weakness.
> >>-- Khan Noonian Singh, "Space Seed", stardate 3141.9
> > ___
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/5] Added configuration file for AM3517EVM

[Hiremath, Vaibhav]

> -Original Message-
> From: Tom [mailto:tom@windriver.com]
> Sent: Thursday, November 26, 2009 9:34 PM
> To: Hiremath, Vaibhav
> Cc: Wolfgang Denk; u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 3/5] Added configuration file for
> AM3517EVM
> 
> Hiremath, Vaibhav wrote:
> >> -Original Message-
> >> From: Wolfgang Denk [mailto:w...@denx.de]
> >> Sent: Tuesday, November 24, 2009 1:16 AM
> >> To: Hiremath, Vaibhav
> >> Cc: u-boot@lists.denx.de
> >> Subject: Re: [U-Boot] [PATCH 3/5] Added configuration file for
> >> AM3517EVM
> >>
> >> Dear hvaib...@ti.com,
> >>
> >> In message <1258974524-28097-1-git-send-email-hvaib...@ti.com>
> you
> >> wrote:
> >>> From: Vaibhav Hiremath 
> >>>
> >>>
> >>> Signed-off-by: Vaibhav Hiremath 
> >>> ---
> >>>  include/configs/am3517_evm.h |  293
> >> ++
> >>>  1 files changed, 293 insertions(+), 0 deletions(-)
> >>>  create mode 100644 include/configs/am3517_evm.h
> >> See before: this patch must be part of the commit that adds the
> >> board
> >> code.
> >>
> >>
> >>> +#ifndef __ASSEMBLY__
> >>> +extern struct gpmc *gpmc_cfg;
> >>> +extern unsigned int boot_flash_base;
> >>> +extern volatile unsigned int boot_flash_env_addr;
> >>> +extern unsigned int boot_flash_off;
> >>> +extern unsigned int boot_flash_sec;
> >>> +extern unsigned int boot_flash_type;
> >>> +#endif
> >> Please add prototype declarations to some appropriate header file
> >> instead.
> >>
> > [Hiremath, Vaibhav] Actually this code is borrowed from OMAP3EVM
> file, and I think almost all devices handles this same way.
> >
> > It is bit difficult to handle this, since we are supporting
> multiple flash devices and these variables are initialized run-time
> and so the macros below,
> >
> > CONFIG_SYS_FLASH_BASE,
> > CONFIG_ENV_OFFSET,
> > CONFIG_SYS_ENV_SECT_SIZE
> >
> > I will try to dig bit more on this, but I think as of now we can
> go with this.
> 
> This code is changing so you may want to wait on investing a lot of
> effort into it.  Please see the CM-T35 board submission.
> Please review what is already been proposed to fix this for all the
> omap3's and
> comment.
> 
[Hiremath, Vaibhav] Thanks for pointing me to this, I will definitely go 
through this and get back to you if I have any issues/questions.

Thanks,
Vaibhav

> Tom
> 
> >
> > Thanks,
> > Vaibhav
> >
> >> Best regards,
> >>
> >> Wolfgang Denk
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/5] Introducing TI's New SoC/board AM3517EVM

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Tuesday, November 24, 2009 1:33 AM
> To: Paulraj, Sandeep
> Cc: Hiremath, Vaibhav; u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 0/5] Introducing TI's New SoC/board
> AM3517EVM
> 
> Dear "Paulraj, Sandeep",
> 
> In message
> <0554bef07d437848af01b9c9b5f0bc5d942dc...@dlee01.ent.ti.com> you
> wrote:
> >
> > I hope you made the patches against the current u-boot-ti/master
> 
> Please note that this is a tendency I seriously dislike.
> 
> 
> Please do NOT do this.
> 
> 
> Please see bullet # 3 at http://www.denx.de/wiki/U-Boot/Patches :
> 
>   Please use the "master" branch of the mainline U-Boot git
>   repository (git://git.denx.de/u-boot.git) as reference, unless
>   (usually late in a release cycle) there has been an
>   announcement to use the "next" branch of this repository
>   instead.
> 
> If we see patches againt any of 30 or so custodian trees, which
> don't
> apply against the "official" master tree, we will see chaos pretty
> soon. Please let's make sure there is only minimal difference
> between
> custdian trees and "master" (or "next"), so there is no reason to
> use
> custodian tress as reference for patches instead.
> 
> 
> Please _always_ use "master" (or "next") as base for patches!
> 
[Hiremath, Vaibhav] Before submitting patch I conformed that the patches gets 
applied on master branch cleanly.

Thanks,
Vaibhav

> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev
> Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> w...@denx.de
> A Perl script is correct if it's halfway readable and  gets  the
> job
> done before your boss fires you.
>- L. Wall & R. L. Schwartz, _Programming
> Perl_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 5/5] AM3517: Add support for EMIF4

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Tuesday, November 24, 2009 1:21 AM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 5/5] AM3517: Add support for EMIF4
> 
> Dear hvaib...@ti.com,
> 
> In message <1258974555-28173-1-git-send-email-hvaib...@ti.com> you
> wrote:
> > From: Vaibhav Hiremath 
> >
> > Changes:-
> >
> > - Created 2 seperate config option
> > * CONFIG_SDRC (omap34xx family)
> > * CONFIG_EMIF4 (am3517 family)
> > - Changed all omap3 dependent file for CONFIG_SDRC
> >
> > Tested On:-
> >
> > - AM3517EVM board
> > - OMAP3EVM board
> > - BEAGLE board
> >
> > I would need help here from people to validate this change for
> SDP/ZOOMx
> > and other OMAP3 version of boards.
> 
> This commit adds a lot of  #ifdef's - maybe it would make more sense
> to split code into different files?
> 
[Hiremath, Vaibhav] Initially I thought of this, but since currently AM3517 is 
the only device in OMAP3 series which uses EMIF and all others use SDRC. So I 
thought lets start with this approach and get peoples opinion on this, and then 
we can split the files.

Thanks,
Vaibhav

> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev
> Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> w...@denx.de
> You are an excellent tactician, Captain. You let your second in
> com-
> mand attack while you sit and watch for weakness.
>   -- Khan Noonian Singh, "Space Seed", stardate 3141.9
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/5] AM3517EVM: Add mux configuration

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Tuesday, November 24, 2009 1:19 AM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 4/5] AM3517EVM: Add mux configuration
> 
> Dear hvaib...@ti.com,
> 
> In message <1258974539-28130-1-git-send-email-hvaib...@ti.com> you
> wrote:
> > From: Vaibhav Hiremath 
> >
> > Updated mux.h file for AM3517 specific mux configuration.
> >
> > Signed-off-by: Vaibhav Hiremath 
> > ---
> >  include/asm-arm/arch-omap3/mux.h |   35
> +++
> >  1 files changed, 35 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/asm-arm/arch-omap3/mux.h b/include/asm-
> arm/arch-omap3/mux.h
> > index 0c01c73..9f06fbb 100644
> > --- a/include/asm-arm/arch-omap3/mux.h
> > +++ b/include/asm-arm/arch-omap3/mux.h
> > @@ -403,6 +403,41 @@
> >  #define CONTROL_PADCONF_D2D_SBUSFLAG   0x0260
> >  #define CONTROL_PADCONF_SDRC_CKE0  0x0262
> >  #define CONTROL_PADCONF_SDRC_CKE1  0x0264
> > +/* AM3517 specific */
> > +#define CONTROL_PADCONF_CCDC_PCLK   0x01E4
> > +#define CONTROL_PADCONF_CCDC_FIELD  0x01E6
> > +#define CONTROL_PADCONF_CCDC_HD 0x01E8
> > +#define CONTROL_PADCONF_CCDC_VD     0x01EA
> > +#define CONTROL_PADCONF_CCDC_WEN0x01EC
> ...
> 
> Where are these defines used? I think I don't see them in any of the
> patches of this patch series?
> 
[Hiremath, Vaibhav] These are being used in board/ty/am3517/am3517evm.c file 
under the function set_muxconf_regs().

Thanks,
Vaibhav

> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev
> Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> w...@denx.de
> f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/5] Added configuration file for AM3517EVM

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Tuesday, November 24, 2009 1:16 AM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 3/5] Added configuration file for
> AM3517EVM
> 
> Dear hvaib...@ti.com,
> 
> In message <1258974524-28097-1-git-send-email-hvaib...@ti.com> you
> wrote:
> > From: Vaibhav Hiremath 
> >
> >
> > Signed-off-by: Vaibhav Hiremath 
> > ---
> >  include/configs/am3517_evm.h |  293
> ++
> >  1 files changed, 293 insertions(+), 0 deletions(-)
> >  create mode 100644 include/configs/am3517_evm.h
> 
> See before: this patch must be part of the commit that adds the
> board
> code.
> 
> 
> > +#ifndef __ASSEMBLY__
> > +extern struct gpmc *gpmc_cfg;
> > +extern unsigned int boot_flash_base;
> > +extern volatile unsigned int boot_flash_env_addr;
> > +extern unsigned int boot_flash_off;
> > +extern unsigned int boot_flash_sec;
> > +extern unsigned int boot_flash_type;
> > +#endif
> 
> Please add prototype declarations to some appropriate header file
> instead.
> 
[Hiremath, Vaibhav] Actually this code is borrowed from OMAP3EVM file, and I 
think almost all devices handles this same way.

It is bit difficult to handle this, since we are supporting multiple flash 
devices and these variables are initialized run-time and so the macros below,

CONFIG_SYS_FLASH_BASE,
CONFIG_ENV_OFFSET,
CONFIG_SYS_ENV_SECT_SIZE

I will try to dig bit more on this, but I think as of now we can go with this.

Thanks,
Vaibhav

> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev
> Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> w...@denx.de
> Es sind überhaupt nur die Dummköpfe, die sich den Befehlen der
> Mäch-
> tigen  widersetzen.  Um  sie  zu ruinieren ist es genug, ihre
> Befehle
> treu zu erfüllen.  - Peter Hacks: "Die schöne
> Helena"
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/5] am3517_evm_config options added to Makfile

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Tuesday, November 24, 2009 1:14 AM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 2/5] am3517_evm_config options added to
> Makfile
> 
> Dear hvaib...@ti.com,
> 
> In message <1258974509-28062-1-git-send-email-hvaib...@ti.com> you
> wrote:
> > From: Vaibhav Hiremath 
> >
> >
> > Signed-off-by: Vaibhav Hiremath 
> > ---
> >  Makefile |3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> This patch must be part of the commit that adds the code. Don't
> split
> it off.
> 
[Hiremath, Vaibhav] Ok, Will fix in next version.

Thanks,
Vaibhav
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev
> Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> w...@denx.de
> When the bosses talk about improving  productivity,  they  are
> never
> talking about themselves.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/5] Introducing AM3517EVM support

[Hiremath, Vaibhav]

> -Original Message-
> From: Wolfgang Denk [mailto:w...@denx.de]
> Sent: Tuesday, November 24, 2009 1:13 AM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH 1/5] Introducing AM3517EVM support
> 
> Dear hvaib...@ti.com,
> 
> In message <1258974382-26568-1-git-send-email-hvaib...@ti.com> you
> wrote:
> > From: Vaibhav Hiremath 
> >
> > Changes:-
> > - Added board specific directory under board/ti/am3517/
> > - Basic board support.
> >
> > Signed-off-by: Vaibhav Hiremath 
> > ---
> >  board/ti/am3517evm/Makefile  |   46 +
> >  board/ti/am3517evm/am3517evm.c   |   76 
> >  board/ti/am3517evm/am3517evm.h   |  388
> ++
> >  board/ti/am3517evm/config.mk |   29 +++
> >  include/asm-arm/arch-omap3/mem.h |   10 +
> >  5 files changed, 549 insertions(+), 0 deletions(-)
> >  create mode 100644 board/ti/am3517evm/Makefile
> >  create mode 100644 board/ti/am3517evm/am3517evm.c
> >  create mode 100644 board/ti/am3517evm/am3517evm.h
> >  create mode 100644 board/ti/am3517evm/config.mk
> ...
> > diff --git a/board/ti/am3517evm/am3517evm.h
> b/board/ti/am3517evm/am3517evm.h
> > new file mode 100644
> > index 000..7897912
> > --- /dev/null
> > +++ b/board/ti/am3517evm/am3517evm.h
> ...
> > +#define MUX_AM3517EVM() \
> > + /*SDRC*/\
> > + MUX_VAL(CP(SDRC_D0),  (IEN  | PTD | DIS | M0))
> /*SDRC_D0*/\
> > + MUX_VAL(CP(SDRC_D1),  (IEN  | PTD | DIS | M0))
> /*SDRC_D1*/\
> ...
> 
> Indentation by TAB, please.
> 
[Hiremath, Vaibhav] Ok, Will fix in next version.

Thanks,
Vaibhav
> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev
> Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> w...@denx.de
> There are no data that cannot be plotted on a straight  line  if
> the
> axis are chosen correctly.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/5] Introducing TI's New SoC/board AM3517EVM

[Hiremath, Vaibhav]

> -Original Message-
> From: Paulraj, Sandeep
> Sent: Monday, November 23, 2009 7:20 PM
> To: Hiremath, Vaibhav; u-boot@lists.denx.de
> Subject: RE: [PATCH 0/5] Introducing TI's New SoC/board AM3517EVM
> 
> 
> 
> >
> > From: Vaibhav Hiremath 
> >
> > AM3517 device is high-performance, industrial applications
> processor
> > designed
> > and developed keeping Software Compatible with OMAP3 Processors.
> >
> > Below are some of the useful links -
> > AM3517 device is high-performance, industrial applications
> processor
> > designed
> > and developed keeping Software Compatible with OMAP3 Processors.
> >
> > Below are some of the useful links -
> >
> > Migration from OMAP35x to AM35x :-
> > http://focus.ti.com/lit/an/sprab91/sprab91.pdf
> >
> > Specs/TRM :-
> > http://focus.ti.com/docs/prod/folders/print/am3517.html
> >
> > EVM Link -:
> > http://www.logicpd.com/products/development-kits/zoom-am3517-
> experimenter-
> > kit
> >
> > Vaibhav Hiremath (5):
> >   Introducing AM3517EVM support
> >   am3517_evm_config options added to Makfile
> >   Added configuration file for AM3517EVM
> >   Added AM3517EVM specific mux configuration to omap3/mux.h
> >   AM3517: Add support for EMIF4
> >
> >  Makefile   |3 +
> >  board/ti/am3517evm/Makefile|   46 
> >  board/ti/am3517evm/am3517evm.c |   76 +++
> >  board/ti/am3517evm/am3517evm.h |  388
> > 
> >  board/ti/am3517evm/config.mk   |   29 +++
> >  cpu/arm_cortexa8/omap3/board.c |   11 +-
> >  cpu/arm_cortexa8/omap3/mem.c   |  110 --
> >  cpu/arm_cortexa8/omap3/sys_info.c  |   12 +-
> >  include/asm-arm/arch-omap3/cpu.h   |   26 +++
> >  include/asm-arm/arch-omap3/mem.h   |   66 ++-
> >  include/asm-arm/arch-omap3/mux.h   |   35 +++
> >  include/asm-arm/arch-omap3/sys_proto.h |4 +
> >  include/configs/am3517_evm.h   |  299
> 
> >  include/configs/devkit8000.h   |4 +
> >  include/configs/omap3_beagle.h |4 +
> >  include/configs/omap3_evm.h|4 +
> >  include/configs/omap3_overo.h  |4 +
> >  include/configs/omap3_pandora.h|4 +
> >  include/configs/omap3_sdp3430.h|4 +
> >  include/configs/omap3_zoom1.h  |4 +
> >  include/configs/omap3_zoom2.h  |4 +
> >  21 files changed, 1112 insertions(+), 25 deletions(-)
> >  create mode 100644 board/ti/am3517evm/Makefile
> >  create mode 100644 board/ti/am3517evm/am3517evm.c
> >  create mode 100644 board/ti/am3517evm/am3517evm.h
> >  create mode 100644 board/ti/am3517evm/config.mk
> >  create mode 100644 include/configs/am3517_evm.h
> 
> Vaibhav,
> 
> We will need entries to MAINTAINERS and MAKEALL as well.
> 
[Hiremath, Vaibhav] Ok, will do that.

> Please submit it when you submit the next set of patches. I am sure
> you will receive some comments.
[Hiremath, Vaibhav] I hope so.
> 
> I hope you made the patches against the current u-boot-ti/master
[Hiremath, Vaibhav] Yes that's correct.

Thanks,
Vaibhav
> 
> Thanks,
> Sandeep

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] OMAP3EVM: Added NAND support

[Hiremath, Vaibhav]

> -Original Message-
> From: Nishanth Menon [mailto:menon.nisha...@gmail.com]
> Sent: Wednesday, November 18, 2009 11:38 PM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH] OMAP3EVM: Added NAND support
> 
> On Wed, Nov 18, 2009 at 12:58 AM,   wrote:
> > From: Vaibhav Hiremath 
> >
> > User can now choose between NAND and ONENAND support in
> omap3_evm.h
> >
> > Signed-off-by: Vaibhav Hiremath 
> > ---
> >  include/configs/omap3_evm.h |   27 ++-
> >  1 files changed, 26 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/configs/omap3_evm.h
> b/include/configs/omap3_evm.h
> > index a5514ae..3434306 100644
> > --- a/include/configs/omap3_evm.h
> > +++ b/include/configs/omap3_evm.h
> > @@ -110,7 +110,8 @@
> >
> >  #define CONFIG_CMD_I2C         /* I2C serial bus support       */
> >  #define CONFIG_CMD_MMC         /* MMC support                  */
> > -#define CONFIG_CMD_ONENAND     /* ONENAND support              */
> > +/*#define CONFIG_CMD_ONENAND*/ /* ONENAND support              */
> do you wish to use #undef instead of commented code? also adding a
> comment on top saying this is an option might help..
> 
[Hiremath, Vaibhav] Good point, I will add this.

> This patch opens up a chain for me: how do we have the same build of
> u-boot boot accross nand, onenand, mmc  type devices?
> current  u-boot looks constrainted in that respect.
> 
[Hiremath, Vaibhav] Atleast for NAND and MMC we are using same build for 
obvious reasons, but I am not sure about onenand though. I need to look at it.

> > +#define CONFIG_CMD_NAND                /* NAND support
>       */
> >  #define CONFIG_CMD_DHCP
> >  #define CONFIG_CMD_PING
> >
> > @@ -141,6 +142,7 @@
> >                                                        /* to
> access */
> >                                                        /* nand at
> CS0 */
> >
> > +
> >  #define CONFIG_SYS_MAX_NAND_DEVICE     1               /* Max
> number of */
> >                                                        /* NAND
> devices */
> >  #define CONFIG_SYS_64BIT_VSPRINTF              /* needed for
> nand_util.c */
> > @@ -268,7 +270,13 @@
> >  #define CONFIG_SYS_MONITOR_BASE
>  CONFIG_SYS_FLASH_BASE
> >  #define CONFIG_SYS_ONENAND_BASE                ONENAND_MAP
> >
> > +#if defined(CONFIG_CMD_NAND)
> > +#define CONFIG_NAND_OMAP_GPMC
> > +#define GPMC_NAND_ECC_LP_x16_LAYOUT    1
> > +#define CONFIG_ENV_IS_IN_NAND          1
> > +#elif defined(CONFIG_CMD_ONENAND)
> >  #define CONFIG_ENV_IS_IN_ONENAND       1
> > +#endif
> 
> what if a user decided to enable NAND and ONENAND?
> 
> >  #define ONENAND_ENV_OFFSET             0x26 /* environment
> starts here */
> >  #define SMNAND_ENV_OFFSET              0x26 /* environment
> starts here */
> >
> > @@ -300,6 +308,23 @@ extern unsigned int boot_flash_sec;
> >  extern unsigned int boot_flash_type;
> >  #endif
> >
> > +
> > +#define WRITE_NAND_COMMAND(d, adr)\
> > +                       writel(d, &nand_cs_base->nand_cmd)
> writel? i thought u had 16 bit nand device.
> 
> > +#define WRITE_NAND_ADDRESS(d, adr)\
> > +                       writel(d, &nand_cs_base->nand_adr)
> > +#define WRITE_NAND(d, adr) writew(d, &nand_cs_base->nand_dat)
> > +#define READ_NAND(adr) readl(&nand_cs_base->nand_dat)
> readl?? should'nt you be using readw?
> 
> Why these functions? does'nt mtd layer handle this? look at beagle -
> >
> it does not use that..
> 
> > +
> > +/* Other NAND Access APIs */
> > +#define NAND_WP_OFF() do {readl(&gpmc_cfg_base->config) |=
> GPMC_CONFIG_WP; } \
> > +                       while (0)
> > +#define NAND_WP_ON() do {readl(&gpmc_cfg_base->config) &=
> ~GPMC_CONFIG_WP; } \
> > +                       while (0)
> > +#define NAND_DISABLE_CE(nand)
> > +#define NAND_ENABLE_CE(nand)
> > +#define NAND_WAIT_READY(nand)  udelay(10)
> > +
> are these really needed?
[Hiremath, Vaibhav] Nishant, you are looking at old patchset which I sent by 
mistake. Please review new V3 version of patch.

Thanks,
Vaibhav

> 
> >  /*---
> -
> >  * SMSC9115 Ethernet from SMSC9118 family
> >  *
> 
> > --
> > 1.6.2.4
> >
> > ___
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> >

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] OMAP3EVM: Added NAND support

[Hiremath, Vaibhav]

> -Original Message-
> From: Dirk Behme [mailto:dirk.be...@googlemail.com]
> Sent: Wednesday, November 18, 2009 2:07 PM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH] OMAP3EVM: Added NAND support
> 
> 
> It would have been nice if subject had a 'v2' now.
> 
[Hiremath, Vaibhav] Ok.

> hvaib...@ti.com wrote:
> > From: Vaibhav Hiremath 
> 
> Patch description missing here now. And if you re-add, it would be
> good to mention that you switch from ONENAND to NAND, too.
> 
[Hiremath, Vaibhav] Will add the description accordingly and submit 'v3'.

> > Signed-off-by: Vaibhav Hiremath 
> > ---
> >  include/configs/omap3_evm.h |   10 +-
> >  1 files changed, 9 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/configs/omap3_evm.h
> b/include/configs/omap3_evm.h
> > index a5514ae..fbc45dc 100644
> > --- a/include/configs/omap3_evm.h
> > +++ b/include/configs/omap3_evm.h
> > @@ -110,7 +110,8 @@
> >
> >  #define CONFIG_CMD_I2C /* I2C serial bus support   */
> >  #define CONFIG_CMD_MMC /* MMC support  */
> > -#define CONFIG_CMD_ONENAND /* ONENAND support  */
> > +/*#define CONFIG_CMD_ONENAND*/ /* ONENAND support  */
> > +#define CONFIG_CMD_NAND/* NAND support */
> 
> Often it can be irritating for users if default changes silently.
> But
> EVM people have to discuss about this, I can't say what the
> preferred
> NAND support is.
> 
[Hiremath, Vaibhav] If we don't get any objection/comments for this change, 
then I think it should be safe to change to NAND support by default.

> >  #define CONFIG_CMD_DHCP
> >  #define CONFIG_CMD_PING
> >
> > @@ -141,6 +142,7 @@
> > /* to access */
> > /* nand at CS0 */
> >
> > +
> 
> What's this?
[Hiremath, Vaibhav] Will remove in next version.

Thanks Dirk for reviewing this patch.

Thanks,
Vaibhav
> 
> Best regards
> 
> Dirk
> 
> >  #define CONFIG_SYS_MAX_NAND_DEVICE 1   /* Max number
> of */
> > /* NAND devices */
> >  #define CONFIG_SYS_64BIT_VSPRINTF  /* needed for
> nand_util.c */
> > @@ -268,7 +270,13 @@
> >  #define CONFIG_SYS_MONITOR_BASECONFIG_SYS_FLASH_BASE
> >  #define CONFIG_SYS_ONENAND_BASEONENAND_MAP
> >
> > +#if defined(CONFIG_CMD_NAND)
> > +#define CONFIG_NAND_OMAP_GPMC
> > +#define GPMC_NAND_ECC_LP_x16_LAYOUT1
> > +#define CONFIG_ENV_IS_IN_NAND  1
> > +#elif defined(CONFIG_CMD_ONENAND)
> >  #define CONFIG_ENV_IS_IN_ONENAND   1
> > +#endif
> >  #define ONENAND_ENV_OFFSET 0x26 /* environment starts
> here */
> >  #define SMNAND_ENV_OFFSET  0x26 /* environment starts
> here */
> >
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] OMAP3EVM: Added NAND support

[Hiremath, Vaibhav]

> -Original Message-
> From: Dirk Behme [mailto:dirk.be...@googlemail.com]
> Sent: Wednesday, November 18, 2009 1:01 PM
> To: Hiremath, Vaibhav
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH] OMAP3EVM: Added NAND support
> 
> hvaib...@ti.com wrote:
> > From: Vaibhav Hiremath 
> >
> > User can now choose between NAND and ONENAND support in
> omap3_evm.h
> >
> > Signed-off-by: Vaibhav Hiremath 
> > ---
> >  include/configs/omap3_evm.h |   27 ++-
> >  1 files changed, 26 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/configs/omap3_evm.h
> b/include/configs/omap3_evm.h
> > index a5514ae..3434306 100644
> > --- a/include/configs/omap3_evm.h
> > +++ b/include/configs/omap3_evm.h
> > @@ -110,7 +110,8 @@
> >
> >  #define CONFIG_CMD_I2C /* I2C serial bus support   */
> >  #define CONFIG_CMD_MMC /* MMC support  */
> > -#define CONFIG_CMD_ONENAND /* ONENAND support  */
> > +/*#define CONFIG_CMD_ONENAND*/ /* ONENAND support  */
> > +#define CONFIG_CMD_NAND/* NAND support */
> 
> Is it okay to switch the default from ONENAND to NAND here?
> 
[Hiremath, Vaibhav] Most EVM's which I have seen comes with NAND support, so I 
have chosen NAND as a default.  And anyway here user can select ONENAND also.

Do you see any issues with moving NAND as a default?

> >  #define CONFIG_CMD_DHCP
> >  #define CONFIG_CMD_PING
> >
> > @@ -141,6 +142,7 @@
> > /* to access */
> > /* nand at CS0 */
> >
> > +
> 
> ?
> 
> >  #define CONFIG_SYS_MAX_NAND_DEVICE 1   /* Max number
> of */
> > /* NAND devices */
> >  #define CONFIG_SYS_64BIT_VSPRINTF  /* needed for
> nand_util.c */
> > @@ -268,7 +270,13 @@
> >  #define CONFIG_SYS_MONITOR_BASECONFIG_SYS_FLASH_BASE
> >  #define CONFIG_SYS_ONENAND_BASEONENAND_MAP
> >
> > +#if defined(CONFIG_CMD_NAND)
> > +#define CONFIG_NAND_OMAP_GPMC
> > +#define GPMC_NAND_ECC_LP_x16_LAYOUT1
> > +#define CONFIG_ENV_IS_IN_NAND  1
> > +#elif defined(CONFIG_CMD_ONENAND)
> >  #define CONFIG_ENV_IS_IN_ONENAND   1
> > +#endif
> >  #define ONENAND_ENV_OFFSET 0x26 /* environment starts
> here */
> >  #define SMNAND_ENV_OFFSET  0x26 /* environment starts
> here */
> >
> > @@ -300,6 +308,23 @@ extern unsigned int boot_flash_sec;
> >  extern unsigned int boot_flash_type;
> >  #endif
> >
> > +
> > +#define WRITE_NAND_COMMAND(d, adr)\
> > +   writel(d, &nand_cs_base->nand_cmd)
> > +#define WRITE_NAND_ADDRESS(d, adr)\
> > +   writel(d, &nand_cs_base->nand_adr)
> > +#define WRITE_NAND(d, adr) writew(d, &nand_cs_base->nand_dat)
> > +#define READ_NAND(adr) readl(&nand_cs_base->nand_dat)
> > +
> > +/* Other NAND Access APIs */
> > +#define NAND_WP_OFF() do {readl(&gpmc_cfg_base->config) |=
> GPMC_CONFIG_WP; } \
> > +   while (0)
> > +#define NAND_WP_ON() do {readl(&gpmc_cfg_base->config) &=
> ~GPMC_CONFIG_WP; } \
> > +   while (0)
> > +#define NAND_DISABLE_CE(nand)
> > +#define NAND_ENABLE_CE(nand)
> > +#define NAND_WAIT_READY(nand)  udelay(10)
> 
> Would encapsulating this with
> 
> #if defined(CONFIG_CMD_NAND)
> 
> #endif
> 
> make sense here?
> 
[Hiremath, Vaibhav] Opps. Sorry, by mistake I have sent old patch, sending you 
the cleaned one.

Thanks,
Vaibhav
> Best regards
> 
> Dirk

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot