[U-Boot] fsl_esdhc.c bug

[Jim Lentz]

All,

There is a bug rendering SDCard support useless on Freescale esdhc 
controller.


File drivers/mmc/fsl_esdhc.c, function esdhc_pio_read_write

*change: *

struct fsl_esdhc *regs = mmc->priv;

*to:*

struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;
volatile struct fsl_esdhc *regs = (struct fsl_esdhc *)cfg->esdhc_base;

How do I/we get this into the mainstream?

I cloned the repository, and have it fixed. First time using git, and 
trying to contribute to OpenSource too.


Regards,

Jim



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] fsl_esdhc.c bug

[Jim Lentz]

On 12/16/2011 09:51 AM, Fabio Estevam wrote:

Hi Jim,

On Fri, Dec 16, 2011 at 11:48 AM, Jim Lentz  wrote:

All,

There is a bug rendering SDCard support useless on Freescale esdhc
controller.

Which Freescale processor do you use?

Please describe in details the problem you see, how to reproduce it,
the U-boot version
that you use, etc.

Regards,

Fabio Estevam

Freescale P2020. Latest U-boot version.

Easiest way to see it is typing mmcinfo at the U-boot cli. It will hang.

By default, PIO mode is selected when CONFIG_P2020 is defined. Legacy 
P2020 silicon revisions require PIO mode.


The esdhc_pio_read_write function has a bad reg pointer.

Jim
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot