Re: [U-Boot] [PATCH] include/fsl_usb.h: Cleanup license header
Acked. -Ramneek -Original Message- From: sun york-R58495 Sent: Wednesday, August 14, 2013 11:56 PM To: Mehresh Ramneek-B31383 Cc: u-boot@lists.denx.de; sun york-R58495 Subject: [PATCH] include/fsl_usb.h: Cleanup license header Replace license header with SPDX license identifier. Replace GPL-2.0 with GPL-2.0+. Signed-off-by: York Sun --- include/fsl_usb.h | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/include/fsl_usb.h b/include/fsl_usb.h index 88d6a1f..915774c 100644 --- a/include/fsl_usb.h +++ b/include/fsl_usb.h @@ -3,23 +3,7 @@ * * Copyright 2013 Freescale Semiconductor, Inc. * - * This software may be used and distributed according to the - * terms of the GNU Public License, Version 2, incorporated - * herein by reference. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License - * Version 2 as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, - * MA 02111-1307 USA + * SPDX-License-Identifier:GPL-2.0+ */ #ifndef _ASM_FSL_USB_H_ -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] USB host on MPC8349 not working
Hi Stewart, Did you probe PHY CLK on external phy pin ? Is phy clock coming to the soc ? Regards, Ramneek -Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Stewart Hamilton Sent: Monday, July 08, 2013 12:08 PM To: 'u-boot@lists.denx.de' Subject: [U-Boot] USB host on MPC8349 not working Hi We have been using U- boot on our MPC8349 based board This was based on the v2009.06-rc2 circa May 2009 version. This was configured to boot embedded linux from a Usb storage device. Recently Micron release a revised version of this device (MTFDCAE002S ) and our current U-Boot is unable to load from it. Booting into the Linux via other means has enabled us to program and verify this device works correctly in our system. So it appears the 4 year old version of U-boot we are using is problem. I have download the latest version of U-Boot and after numberer of changes to our configuration file got it to compile and boot Unfortunately I cannot get it to configure the MPC8349 USB host controller. We are running this USB controller in MPH mode. After U-boot has booted into the console mode. Typing USB start produced the following error.. (Re)start USB... USB0: SET PHY CLOCK E0022500 USB PHY clock invalid! lowlevel init failed USB error: all controllers failed lowlevel init Tracing this error shows it originates from the usb_phy_clk_valid routine in ehci-fsl.c I cannot find out why the ehci control port is unable to have the clock enabled. I would appreciate any help or advice that people on here are able to give Below are our Configuration head files and the low level board driver. MPX8349.h /* */ #ifndef __CONFIG_H #define __CONFIG_H /* * High Level Configuration Options */ #define CONFIG_E300 1 /* E300 Family */ #define CONFIG_MPC83xx 1 /* MPC83xx family */ #define CONFIG_MPC834x 1 /* MPC834x family */ #define CONFIG_MPC8349 1 /* MPC8349 specific */ // #define CONFIG_MPC8349EMDS 1 /* MPC8349EMDS board specific */ #define CONFIG_SYS_TEXT_BASE 0xFC00 #define CONFIG_PCI #undef CONFIG_MPC83XX_PCI2 /* support for 2nd PCI controller */ #define CONFIG_SYS_USB_HOST /* use the EHCI USB controller */ #ifdef CONFIG_SYS_USB_HOST /* * Support USB */ #define CONFIG_USB_STORAGE #define CONFIG_USB_EHCI #define CONFIG_USB_EHCI_FSL #define CONFIG_USB_EHCI_MPC83XX #define CONFIG_DOS_PARTITION #define CONFIG_EHCI_HCD_INIT_AFTER_RESET /* Current USB implementation supports the only USB controller, * so we have to choose between the MPH or the DR ones */ #if 1 #define CONFIG_HAS_FSL_MPH_USB #else #define CONFIG_HAS_FSL_DR_USB #endif #endif #define CONFIG_PCI_33M #ifdef CONFIG_PCI_66M #define CONFIG_83XX_CLKIN 6600 /* in Hz */ #else #define CONFIG_83XX_CLKIN 3300 /* in Hz */ #endif #ifdef CONFIG_PCISLAVE #define CONFIG_PCI #define CONFIG_83XX_PCICLK /* in Hz */ #endif /* CONFIG_PCISLAVE */ #ifndef CONFIG_SYS_CLK_FREQ #ifdef CONFIG_PCI_66M #define CONFIG_SYS_CLK_FREQ 6600 #else #define CONFIG_SYS_CLK_FREQ 5940 #endif #endif #undef CONFIG_BOARD_EARLY_INIT_F /* don't call board_pre_init */ #undef CONFIG_BOARD_EARLY_INIT_R /* no board specific init */ #define CONFIG_MISC_INIT_F 1 /* Use misc_init_f() */ #define CONFIG_SYS_IMMR0xE000 #undef CONFIG_SYS_DRAM_TEST/* memory test, takes time */ #define CONFIG_SYS_MEMTEST_START 0x /* memtest region */ #define CONFIG_SYS_MEMTEST_END0x0010 /* * DDR Setup */ #undef CONFIG_DDR_ECC /* support DDR ECC function */ #undef CONFIG_DDR_ECC_CMD /* use DDR ECC user commands */ #undef CONFIG_SPD_EEPROM /* use SPD EEPROM for DDR setup*/ /* * define CONFIG_FSL_DDR2 to use unified DDR driver * undefine it to use old spd_sdram.c */ #undef CONFIG_FSL_DDR2 #ifdef CONFIG_FSL_DDR2 #define CONFIG_SYS_SPD_BUS_NUM 0 #define SPD_EEPROM_ADDRESS1 0x52 #define SPD_EEPROM_ADDRESS2 0x51 #define CONFIG_NUM_DDR_CONTROLLERS 1 #define CONFIG_DIMM_SLOTS_PER_CTLR 2 #define CONFIG_CHIP_SELECTS_PER_CTRL (2 * CONFIG_DIMM_SLOTS_PER_CTLR) #define CONFIG_ECC_INIT_VIA_DDRCONTROLLER #define CONFIG_MEM_INIT_VALUE 0xDeadBeef #endif /* * 32-bit data path mode. * * Please note that using this mode for devices with the real density of 64-bit * effectively reduces the amount of available memory due to the effect of * wrapping around while translating address to row/columns, for example in the * 256MB module the upper 128MB get aliased with contents of the lower * 128MB); normally this define should be used for devices with real 32-bit * data path. */ #undef CONFIG_DDR_32BIT #define CONFIG_SYS_DDR_BASE 0x/* DDR is system memory*/ #define CONFIG_SYS_SDRAM_BASE CONFIG_SYS_DDR_BASE #define CONFIG_SYS_DDR_SDRAM_BASE CONFIG_SYS_DDR_BASE #define CONF
Re: [U-Boot] [PATCH] powerpc/85xx: Add USB device-tree fixup for various platforms
> -Original Message- > From: Andy Fleming [mailto:aflem...@gmail.com] > Sent: Thursday, April 19, 2012 2:17 AM > To: Mehresh Ramneek-B31383 > Cc: u-boot@lists.denx.de; Fleming Andy-AFLEMING > Subject: Re: [U-Boot] [PATCH] powerpc/85xx: Add USB device-tree fixup for > various platforms > > On Mon, Mar 26, 2012 at 9:15 AM, Ramneek Mehresh > > wrote: > > Add USB device-tree fixup for following platforms: > > MPC8536DS, P1022DS, P1023RDS, P2020COME, P2020DS, P2041RDB, P3060QDS > > > > Signed-off-by: Ramneek Mehresh > > --- > > diff --git a/board/freescale/p2020come/p2020come.c > > b/board/freescale/p2020come/p2020come.c > > index 8cf7bee..ce78016 100644 > > --- a/board/freescale/p2020come/p2020come.c > > +++ b/board/freescale/p2020come/p2020come.c > > @@ -1,5 +1,5 @@ > > /* > > - * Copyright 2009 Freescale Semiconductor, Inc. > > + * Copyright 2009,2012 Freescale Semiconductor, Inc. > > * > > * See file CREDITS for list of people who contributed to this > > * project. > > @@ -282,6 +282,10 @@ void ft_board_setup(void *blob, bd_t *bd) > > > > fdt_fixup_memory(blob, (u64)base, (u64)size); > > > > +#ifdef CONFIG_HAS_FSL_DR_USB > > + fdt_fixup_dr_usb(blob, bd); > > +#endif > > + > > fdt_fixup_dr_usb(blob, bd); > > > Umm I don't think this is right. :) Thanks for pointing out ... will correct ... - Ramneek ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH]powerpc/8xxx:Add MPH controller support in USB device-tree fixup
Hi Marek, The final version of this patch is under review, didn't get any more comments, waiting for its acceptance... http://patchwork.ozlabs.org/patch/140557/ Thanks and Regards, Ramneek > -Original Message- > From: Marek Vasut [mailto:ma...@denx.de] > Sent: Monday, February 27, 2012 4:42 AM > To: u-boot@lists.denx.de > Cc: Mehresh Ramneek-B31383 > Subject: Re: [U-Boot] [PATCH]powerpc/8xxx:Add MPH controller support in > USB device-tree fixup > > > Add support for fixing usb mode and phy type for MPH(Multi Port Host) > > USB controllers in device-tree nodes. > > Required for socs like P3060, P5020, etc having MPH USB controller. > > > > Signed-off-by: Ramneek Mehresh > > --- > > arch/powerpc/cpu/mpc8xxx/fdt.c | 46 > > ++-- include/fdt_support.h > | > > 4 +- > > 2 files changed, 32 insertions(+), 18 > Hi, > > what's the status of this patch/patchset? > > Thanks > M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/8xxx: Update USB mode device tree fixup
Hi Wolfgang, I agree with you that there may be some boards that have USB (on soc) but do not use it. But in that case, they should not define CONFIG_HAS_FSL_DR_USB in their board file. usb.h file has a logic that if this file is included, and the USB protocol is not defined then it throws compilation error (which is correct because the driver will not be able to perform low level initialization which is specific to a protocol) The issue here is that we have some boards that are declaring that they have USB (by defining CONFIG_HAS_FSL_DR_USB), but they are not defining the protocol itself. This issue is not related to including file or using any macro from within it. What's the point of declaring the availability of an IP on a board without mentioning the protocol being used by this IP !! In case the board is not using USB, CONFIG_HAS_FSL_DR_USB should not be defined in the board file itself. Even if I make changes for not using a macro defined in file, the issue will still remain for boards defining CONFIG_HAS_FSL_DR_USB (without defining protocol) and using file... Thanks and Regards, Ramneek -Original Message- From: Wolfgang Denk [mailto:w...@denx.de] Sent: Wednesday, July 20, 2011 5:35 PM To: Mehresh Ramneek-B31383 Cc: Phillips Kim-R1AAHA; Gala Kumar-B11780; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] powerpc/8xxx: Update USB mode device tree fixup Dear Mehresh Ramneek-B31383, In message <16867771548d2f469f1a8f817f38278820a...@039-sn1mpn1-003.039d.mgd.msft.net> you wrote: > > I just checked that this error comes when you don't have any of the following > defined in the board file: > CONFIG_USB_UHCI > CONFIG_USB_OHCI > CONFIG_USB_EHCI > CONFIG_USB_OHCI_NEW > ... > MPC837xRDB has EHCI host controller. Hence, CONFIG_USB_EHCI and its relevant > support macros should be defined in include/configs/MPC837XERDB.h file. No, I disagree. It must be possible to configure such a port without USB as well. Not all boards based on this processer ever want to use USB (or even have it on their boards). Please fix this in a way that no such definitions are ever mandatory. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Your csh still thinks true is false. Write to your vendor today and tell them that next year Configure ought to "rm /bin/csh" unless they fix their blasted shell. :-) - Larry Wall in Configure from the perl distribution ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/8xxx: Update USB mode device tree fixup
Hi Kim, I just checked that this error comes when you don't have any of the following defined in the board file: CONFIG_USB_UHCI CONFIG_USB_OHCI CONFIG_USB_EHCI CONFIG_USB_OHCI_NEW ... MPC837xRDB has EHCI host controller. Hence, CONFIG_USB_EHCI and its relevant support macros should be defined in include/configs/MPC837XERDB.h file. This support is missing from MPC837XERDB.h file. If you include EHCI support inside this file, this error won't come. So I think option (a) makes more sense, that USB should be configured in all boards using it. Regards, Ramneek -Original Message- From: Phillips Kim-R1AAHA Sent: Wednesday, July 20, 2011 1:09 AM To: Gala Kumar-B11780 Cc: Mehresh Ramneek-B31383; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] powerpc/8xxx: Update USB mode device tree fixup On Thu, 30 Jun 2011 20:25:02 -0500 Kumar Gala wrote: > > On Jun 8, 2011, at 6:44 AM, Ramneek Mehresh wrote: > > > Modify support for USB mode fixup: > >- Add common support for USB mode and phy type > > device tree fix-up for all USB controllers > > mentioned in hwconfig string > >- Fetch USB mode and phy type via hwconfig; if not > > defined in hwconfig, then fetch them from env > > > > Signed-off-by: Ramneek Mehresh > > --- > > arch/powerpc/cpu/mpc8xxx/fdt.c | 77 > > +-- > > 1 files changed, 65 insertions(+), 12 deletions(-) > > applied to 85xx turns out this commit (72f4980) breaks some 83xx boards: $ ./MAKEALL MPC837XERDB Configuring for MPC837XERDB board... /home/r1aaha/git/u-boot/include/usb.h:159:2: error: #error USB Lowlevel not defined In file included from fdt.c:34:0: /home/r1aaha/git/u-boot/include/usb.h:159:2: error: #error USB Lowlevel not defined make[1]: *** [fdt.o] Error 1 it adds a USB-configured dependency by including usb.h in arch/powerpc/cpu/mpc8xxx/fdt.c, presumably just to get the USB_MAX_DEVICE constant. There are multiple ways to fix: a. configure USB in all boards that don't have it configured, b. repurpose CONFIG_HAS_FSL_DR_USB to also configure USB, c. remove #error USB Lowlevel not defined from usb.h, d. hardcode USB_MAX_DEVICE in fdt.c, e. have fdt.c loop only over existing usb nodes in the device tree. my personal preference is e. What do you think? Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] USB only works in Linux if started in UBoot
Hi Einar On which platform you faced this issue ? Regards, Ramneek. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/qoriq: Update USB mode device tree fixup
Hi Wolfgang, Thanks for your inputs... The first two points are the features provided by the same code change. They should be in the same patch. Adding of USB2 controller offset is for supporting second USB controller in QoriQ series of processors. I can send a separate patch for that. So I'll break this patch into two ... one with "adding support for USB mode and phy type device-tree fix-up, where mode and phy type are fetched via hwconfig string" And other for "adding second USB controller offset for QorIQ series of processors" Please tell if this would be fine ... Thanks and Regards, Ramneek -Original Message- From: Wolfgang Denk [mailto:w...@denx.de] Sent: Wednesday, April 06, 2011 10:47 AM To: Mehresh Ramneek-B31383 Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] powerpc/qoriq: Update USB mode device tree fixup Dear Ramneek Mehresh, In message <1300789256-14487-1-git-send-email-ramneek.mehr...@freescale.com> you wrote: > Modify support for USB mode fixup: > - Add support for fetching USB mode and phy type > via hwconfig > - Add common support for USB mode and phy type > device tree fix-up for all USB controllers > mentioned in hwconfig string > - Add USB2 controller offset Sounds as if these were 3 independent changes, so these should go into three separate patches. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The goal of science is to build better mousetraps. The goal of nature is to build better mice. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
