Re: [PATCH] binman: Avoid requiring a home directory on startup
On Tue, Feb 14, 2023 at 3:08 PM Tom Rini wrote: > Downloading things from the internet and putting them in to the default > PATH always and forever is also kinda not great? you just described a standard distribution. this is like literally how all of them work. not to mention every other language-specific distro tool out there (e.g. Python pip, Perl cpan, Go, etc...). maybe you'd like more guarantees on top (e.g. signature verification) which is reasonable. but to be clear, this script is already merged & in the tree, so your feedback doesn't block this patch. -mike
Re: [PATCH] binman: Avoid requiring a home directory on startup
considering, iiuc, the user has to execute the command to opt-in to installing the programs, putting it into a dir that's in $PATH is reasonable i would quibble that ~/bin is archaic and everyone should be using ~/.local/bin nowadays. but that can be a followup. https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html -mike
Re: [U-Boot] [PATCH 0/5] Do not use __DATE__ and __TIME__ anymore
On Thu 17 Apr 2014 17:00:27 Masahiro Yamada wrote: > The aim of this series is to prohibit using __DATE__ and __TIME__. as long as the version.h isn't impacted, this should fine. i don't think it is as it looks like the build will generate U_BOOT_DATE and U_BOOT_TIME into a const string by hand. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/5] blackfin: replace bfin_gen_rand_mac() with eth_random_addr()
On Thu 17 Apr 2014 17:00:30 Masahiro Yamada wrote: > --- a/include/configs/tcm-bf537.h > +++ b/include/configs/tcm-bf537.h > @@ -73,7 +73,7 @@ > #define CONFIG_HOSTNAME tcm-bf537 > /* Uncomment next line to use fixed MAC address */ > /* #define CONFIG_ETHADDR02:80:ad:20:31:e8 */ > - > +#define CONFIG_LIB_RAND this should be in bfin_adi_common.h instead. i think that replaces the majority of your config updates (if not all). -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC] i2c_reloc_fixup fails on m68k
On Tuesday 24 September 2013 02:33:55 Heiko Schocher wrote: > Am 23.09.2013 15:50, schrieb Jens Scharsig: > > Hello, > > > > I have a access violation problem with i2c_reloc_fixup on coldfire > > m68k systems. > > > > I found out, the i2c_reloc_fixup tries to relocate the adapter itself, > > but at this time i2c_adap_p is already relocated. > > Which toolchain? > > > Can anybody confirm this? > > Added Mike Frysinger, Sonic Zhang (for blackfin) Jason Jin (for m68k) > and Macpaul Lin (for nds32) to Cc ... > > > I think also m68k, backfin and nds32 systems are affected > > Sorry, I have no such system ... maybe you are the first who stepped > in it ... Blackfin doesn't do self-relocation like that, so we don't care :) -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Change of NDS32 Custodian
On Wednesday 31 July 2013 06:40:37 Marek Vasut wrote: > Dear Macpaul Lin, > > Here is a short announcement about a change in the U-boot NDS32 > > custodian. > > > > I have no longer working in Andes Technology Corporation and cannot > > provide the community the best support on NDS32 architecture. > > Kuan-Yu Kuo (a.k.a. Ken Kuo) will be the next custodian of u-boot-nds32 > > branch. > > > > Thanks for the great support and co-working guide from Wolfgang, Tom, > > Po-Yu Chuang, Mike, Marek and many people. > > Thanks for your help which made the u-boot porting work of NDS32 > > architecture becomes the first open source mainline contribution of > > NDS32. > > > > The official custodian e-mail of NDS32 will be changed to > > "ub...@andestech.com". Ken will send the patchwork permission request, > > patches to MAINTAINERS file, and update the U-boot Wiki later. > > Was good having you around! Thank you for your efforts! indeed ... it's been fun working with you Macpaul. hopefully we can meet up at some point and have a beer. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 1/3] blackfin: Enable early print via the generic serial API.
On Monday 13 May 2013 00:20:15 Sonic Zhang wrote: > Remove blackfin specific implementation of the generic serial API when > early print macro is defined. > > In BFIN_BOOT_BYPASS mode, don't call generic serial_puts, because > early print in bypass mode is running before code binary is relocated > to the link address. the link address of the function doesn't matter. all Blackfin func calls are pcrel based, not absolute address calls. i specifically crafted all of this early serial code so that this does work regardless of the address where the code happens to be executing. what doesn't work is if you try to use the early serial console with CONFIG_SYS_BFIN_UART (which allows all the serial devices to be selected on the fly). but the header file specifically handles that: #ifndef CONFIG_DEBUG_EARLY_SERIAL # define CONFIG_SYS_BFIN_UART #endif i guess the problem is that this commit is wrong: commit 820edc18b5aefa8c82d420f6cba3e13b5631f9b8 Author: Sonic Zhang Date: Fri Nov 30 17:39:32 2012 +0800 blackfin: Correct early serial mess output in BYPASS boot mode. it shouldn't be messing with the addresses there -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1] bfin: Move gpio support for bf54x and bf60x into the generic driver folder.
On Thursday 02 May 2013 01:55:25 Sonic Zhang wrote: > The gpio spec for bf54x and bf60x differ a lot from the old gpio driver for > bf5xx. A lot of machine macros are used to accomodate both code in one > gpio driver. This patch split the old gpio driver and move new gpio2 > support to the generic gpio driver folder. > > - To enable gpio2 driver, macro CONFIG_ADI_GPIO2 should be defined in the > board's config header file. > - The gpio2 driver supports bf54x, bf60x and future ADI processors, while > the older gpio driver supports bf50x, bf51x, bf52x, bf53x and bf561. > - All blackfin specific gpio function names are replaced by the generic > gpio APIs. the code in u-boot was written so as to make direct import from the kernel trivial. that way there is only one code base to maintain -- the kernel. last i looked, you hadn't split the drivers in the kernel, which means things are now diverging. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1] mmc: bfin: Ensure MMR writing is done before next command.
On Saturday 27 April 2013 07:04:10 Sonic Zhang wrote: > From: Sonic Zhang > > - Ensure MMR writing is done before next command. > - Invalidate the buffer before starting to read. this patch was written by Cliff, not yourself. the description really doesn't match reality, and no one has yet to explain what this is doing. i'm fairly certain Cliff, when presented with the bug (iirc, it was "mmc doesn't work at low SCLK") just threw in a crap ton of SSYNCs to slow the driver down and shuffled some code until it worked. no real analysis as to what was actually necessary. hence, i never pushed this upstream. i still don't think this belongs in mainline. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 1/2] bfin: Remove spi dma function in bf5xx.
On Monday 04 March 2013 02:20:08 Sonic Zhang wrote: > From: Scott Jiang > > BF5xx rx dma causes spi flash random read error. > Accually spi controller has problems both on tx and rx dma. > So remove spi dma support in u-boot. this is wrong, and imo, unnecessary. it's wrong because using DMA gains a lot of speed increases, and works for in many cases (i haven't seen cases where it didn't work, but i haven't been actively developing in the last year of course). it's unnecessary because there's already a CONFIG_xxx option to disable it if your platform is having problems and you can't figure things out, and don't need the speed gains. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/15] fdt: Use sed instead of cpp to pre-process the dtc
On Friday 28 December 2012 09:55:52 Simon Glass wrote: > On Thu, Dec 27, 2012 at 4:03 PM, Stephen Warren wrote: > > On 12/26/2012 03:28 PM, Simon Glass wrote: > >> Include file support in dtc is still not available in common > >> distributions so we need to keep our preprocessing arrangement around > >> for a little longer. > >> > >> But # is commonly used in FDT files, so use sed instead of cpp for this > >> preprocessing. > > > > This sounds like the wrong approach to me. I'd suggest using what I > > > > proposed for the kernel: > >> cmd_dtc_cpp = $(CPP) $(cpp_flags) -D__DTS__ -x assembler-with-cpp -o > >> $(dtc-tmp) $< ; \ > >> > >> $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 $(DTC_FLAGS) > >> $(dtc-tmp) > > > > The "-x assembler-with-cpp" is what solves the # problem IIRC. > > I originally used CPP as an expedient means of converting the > ARCH_CPU_DTS symbol until we all have a dtc with include path support. > > Are you saying that we want to actually use the CPP on tthe device > tree and (presumably) use U-Boot include files within the FDT? sounds reasonable to me. we already do it with linker scripts, and if the kernel is doing it, it means we can (possibly) share more. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/3] fw_env: fix incorrect usage of open(O_CREAT)
When using open(), the O_CREAT flag must be given a mode, otherwise it
uses random garbage from the stack. Also, it can fail to build:
In file included from /usr/include/fcntl.h:290:0,
from fw_env_main.c:42:
In function 'open',
inlined from 'main' at fw_env_main.c:97:9:
/usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode' declared
with attribute error: open with O_CREAT in second argument needs 3
arguments
Signed-off-by: Mike Frysinger
---
tools/env/fw_env_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/env/fw_env_main.c b/tools/env/fw_env_main.c
index c855f4c..40ea3f6 100644
--- a/tools/env/fw_env_main.c
+++ b/tools/env/fw_env_main.c
@@ -94,7 +94,7 @@ int main(int argc, char *argv[])
int lockfd = -1;
int retval = EXIT_SUCCESS;
- lockfd = open(lockname, O_WRONLY | O_CREAT | O_TRUNC);
+ lockfd = open(lockname, O_WRONLY | O_CREAT | O_TRUNC, 0666);
if (-1 == lockfd) {
fprintf(stderr, "Error opening lock file %s\n", lockname);
return EXIT_FAILURE;
--
1.7.12.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/3] fw_env: fix building w/out a config.h
Signed-off-by: Mike Frysinger
---
tools/env/Makefile | 11 ++-
tools/env/fw_env.h | 25 -
2 files changed, 10 insertions(+), 26 deletions(-)
diff --git a/tools/env/Makefile b/tools/env/Makefile
index ab73c8c..62a113a 100644
--- a/tools/env/Makefile
+++ b/tools/env/Makefile
@@ -24,7 +24,7 @@
include $(TOPDIR)/config.mk
HOSTSRCS := $(SRCTREE)/lib/crc32.c fw_env.c fw_env_main.c
-HEADERS:= fw_env.h $(OBJTREE)/include/config.h
+HEADERS:= fw_env.h
# Compile for a hosted environment on the target
HOSTCPPFLAGS = -idirafter $(SRCTREE)/include \
@@ -33,6 +33,15 @@ HOSTCPPFLAGS = -idirafter $(SRCTREE)/include \
-DUSE_HOSTCC \
-DTEXT_BASE=$(TEXT_BASE)
+# Pass CONFIG_xxx settings via the command line so that we can build w/out
+# a config.h file existing in the first place. Useful for generic builds.
+CONFIG_VARS_TO_PASS = \
+ ENV_OVERWRITE \
+ OVERWRITE_ETHADDR_ONCE \
+ ETHADDR
+HOSTCPPFLAGS += \
+ $(foreach x,$(CONFIG_VARS_TO_PASS),$(if
$(CONFIG_$(x)),-DCONFIG_$(x)=$(CONFIG_$(x
+
ifeq ($(MTD_VERSION),old)
HOSTCPPFLAGS += -DMTD_OLD
endif
diff --git a/tools/env/fw_env.h b/tools/env/fw_env.h
index a1a6807..19703c7 100644
--- a/tools/env/fw_env.h
+++ b/tools/env/fw_env.h
@@ -21,15 +21,6 @@
* MA 02111-1307 USA
*/
-/* Pull in the current config to define the default environment */
-#ifndef __ASSEMBLY__
-#define __ASSEMBLY__ /* get only #defines from config.h */
-#include
-#undef __ASSEMBLY__
-#else
-#include
-#endif
-
/*
* To build the utility with the static configuration
* comment out the next line.
@@ -52,22 +43,6 @@
#define DEVICE2_ENVSECTORS 2
#endif
-#ifndef CONFIG_BAUDRATE
-#define CONFIG_BAUDRATE115200
-#endif
-
-#ifndef CONFIG_BOOTDELAY
-#define CONFIG_BOOTDELAY 5 /* autoboot after 5 seconds */
-#endif
-
-#ifndef CONFIG_BOOTCOMMAND
-#define CONFIG_BOOTCOMMAND
\
- "bootp; "
\
- "setenv bootargs root=/dev/nfs nfsroot=${serverip}:${rootpath} "
\
- "ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}:${hostname}::off; "
\
- "bootm"
-#endif
-
extern int fw_printenv(int argc, char *argv[]);
extern char *fw_getenv (char *name);
extern int fw_setenv (int argc, char *argv[]);
--
1.7.12.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/3] fw_env: fix type of len
This variable is assigned by a size_t, and is printed that way, but is
incorrectly declared as an int. Which means we get warnings:
fw_env.c: In function 'fw_setenv':
fw_env.c:409:5: warning: format '%zu' expects argument of type 'size_t',
but argument 3 has type 'int' [-Wformat]
Signed-off-by: Mike Frysinger
---
tools/env/fw_env.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
index 9b023e8..02f97c0 100644
--- a/tools/env/fw_env.c
+++ b/tools/env/fw_env.c
@@ -379,7 +379,8 @@ int fw_env_write(char *name, char *value)
*/
int fw_setenv(int argc, char *argv[])
{
- int i, len;
+ int i;
+ size_t len;
char *name;
char *value = NULL;
--
1.7.12.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] bfin: Fix warning in bfin_mac
On Wed, Sep 12, 2012 at 10:32 AM, Joe Hershberger wrote: > On Wed, Sep 12, 2012 at 4:51 AM, Marek Vasut wrote: >> Dear Marek Vasut, >>> The buf variable in bfin_mac.c is not used and produces warning, >>> fix it. >>> >>> bfin_mac.c: In function 'bfin_EMAC_send': >>> bfin_mac.c:125:16: warning: variable 'buf' set but not used >>> [-Wunused-but-set-variable] >>> >>> Signed-off-by: Marek Vasut >>> Cc: Mike Frysinger >> >> Guess I should have Cced Joe too ... > > Acked-by: Joe Hershberger i can pick this up, or you can. it'll be another week before i'm back home & working on u-boot though. -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] bfin: Fix warning in bfin_mac
Acked-by: Mike Frysinger -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] bfin: Disable -fstack-usage
On Tue, Sep 11, 2012 at 3:08 PM, Marek Vasut wrote: > The GCC does not support this on blackfin, disable it. err, no, you're probably using gcc-4.5.x which didn't support -fstack-usage. that is not specific to Blackfin as gcc didn't add it until 4.6.x. why doesn't the cc-option check work ? -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Blackfin BF54x Silicon revision 0.4 and uClinux
On Friday 24 August 2012 10:09:37 Dimitar Penev wrote: > My question is not directly applicable with u-boot but I think here I may > find the answer > which I still don't get from the Analog Device forum. well, they'd be the people to pester > Does anyone got working hardware based on Blackfin BF54x rev 0.4 (the > current silicon revision) and uClinux > http://blackfin.uclinux.org/gf/project/uclinux-dist ? > I know about BF548 EZKIT Lite but it uses BF548 Rev 0.2. the bf548-ezkit has had every rev of silicon. i've personally booted u-boot and linux on bf54x processors revs 0.0, 0.1, 0.2, 0.3, and 0.4. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] MIPS: factor out endianess flag handling to arch config.mk
On Thursday 23 August 2012 18:50:47 daniel.schwierz...@gmail.com wrote: > From: Daniel Schwierzeck > > This is CPU independent and should be configured architecture-wide. nice Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 04/12] tools/env: Reduce the impact on real-time processes
On Thursday 23 August 2012 12:26:08 Joe Hershberger wrote: > On Wed, Aug 22, 2012 at 10:30 PM, Mike Frysinger wrote: > > On Friday 17 August 2012 16:49:38 Joe Hershberger wrote: > >> + * Break reads up into very small chunks so fw_printenv doesn't > >> + * block the kernel long enough to starve other kernel tasks. > > > > err, this sounds like a bug in your kernel driver. why should userspace > > be working around buggy drivers ? > > The problem is something to do with the mtd driver blocking some > resource on large reads that starves USB transfers. We never fully > investigated it. It's true that this is a work-around. Is that so > bad? Maybe so. i think it's a bad precedent that we shouldn't encourage. you add your wonky hardware workaround, and then the next guy will want to add his hack for their broken driver, and we're left with an ugly unmaintainable pile. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 06/16] Blackfin: Bf609-ezkit: implement soft switch
On Monday 20 August 2012 04:11:17 Bob Liu wrote: > On Wed, Aug 8, 2012 at 12:59 PM, Mike Frysinger wrote: > > start with the address that the newest boards are using, and then > > fallback to the older ones. this way there's no runtime penalty on > > newer boards, but older ones continue to work. > > > > shouldn't there be a new u-boot command here so people can toggle > > peripherals themselves ? i thought that was the intention when we first > > discussed this idea with the firmware team. > > I don't know whether a blackfin specific u-boot command can be accepted. sure it will. we've got some already (like "bootldr" and "otp" and "cplbinfo" and "ldrinfo"). if it's board specific (i suspect it will be), then just add it to the bf609-ezkit board dir. you can add u-boot commands in there just as easily as the common/ directory. common/cmd_cplbinfo.c is probably the easiest example to get you up and running > What about merge these series with the default setting first? > Because it's already a little big, let's make it simple at first. sure, setting up sane defaults is OK, but we'll still want the command :) -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 03/16] Blackfin: Bf60x: support big cplb page
On Monday 20 August 2012 04:00:21 Bob Liu wrote:
> On Wed, Aug 8, 2012 at 12:48 PM, Mike Frysinger wrote:
> > On Tuesday 07 August 2012 04:07:42 Bob Liu wrote:
> >> --- a/arch/blackfin/lib/board.c
> >> +++ b/arch/blackfin/lib/board.c
> >>
> >> void init_cplbtables(void)
> >> {
> >> ...
> >> +#if defined(__ADSPBF60x__)
> >> + icplb_add(0x0, 0x0);
> >
> > err, why ?
>
> Because other place use value "i" for both icplb and dcplb this make
> them consistent.
why not add an ICPLB entry for the same region you just added a DCPLB entry
for ? we can directly execute out of the flash memory region ...
> >> + cplb_page_size = (4 * 1024 * 1024);
> >> + cplb_page_mask = (~(cplb_page_size - 1));
> >
> > why only use CPLBs of 4 megs for external memory on BF60x ? you would
> > want to maximize the usage of 16MiB to reduce CPLB overhead.
>
> Bf60x will reinit cplb_page_size/mask behind.
sorry, i don't understand what you mean
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 12/12] env: cosmetic: Consilidate the default env definition
On Friday 17 August 2012 16:49:46 Joe Hershberger wrote: > There used to be a huge structure duplicated 3 times in the source. if this actually works: Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 10/12] env: acl: Add environment variable access control list
On Friday 17 August 2012 16:49:44 Joe Hershberger wrote:
> --- a/common/cmd_nvedit.c
> +++ b/common/cmd_nvedit.c
>
> +#if defined(CONFIG_ENV_ACL)
> +#include
> +#endif
the header should not need protection just to be included
> +#ifdef CONFIG_ENV_ACL
> + if (env_acl_validate_env_set_params(argc, argv) < 0)
> + return 1;
> +#endif
have the header define env_acl_validate_env_set_params() as a return 0 static
inline func when CONFIG_ENV_ACL isn't defined and then you can drop the ifdef
here
> --- /dev/null
> +++ b/common/env_acl.c
>
> + * (C) Copyright 2010
fwiw, it's 2012 now
> +static int _env_acl_lookup_r(const char *name, char *attributes, int
> static_acl)
> ...
> + entry = strstr(acl, name);
> + while (entry != NULL) {
> + if ((entry == acl || *(entry - 1) == ENV_ACL_LIST_DELIM ||
> + *(entry - 1) == ' ') &&
> + (*(entry + strlen(name)) == ENV_ACL_ATTR_SEP ||
> + *(entry + strlen(name)) == ENV_ACL_LIST_DELIM ||
> + *(entry + strlen(name)) == '\0' ||
> + *(entry + strlen(name)) == ' '))
> + break;
is that strlen optimized away ? i suspect not. and even if it is, the
duplication here is kind of ugly, so it'd be better to use a local var
anyways.
const char *acl_val = entry + strlen(name);
> +static int env_acl_lookup_r(const char *name, char *attributes)
> +{
> + int ret_val;
> + /* try the env first */
> + ret_val = _env_acl_lookup_r(name, attributes, 0);
> + if (ret_val != 0) {
> + /* if not found in the env, look in the static list */
> + ret_val = _env_acl_lookup_r(name, attributes, 1);
> + }
> + return ret_val;
> +}
> +
> +enum env_acl_var_type env_acl_get_type(const char *name)
> +{
> + char *type;
const
> +static void skip_num(int hex, const char *value, const char **end,
> + int max_digits)
> +{
> + int i;
> +
> + if (hex && is_hex_prefix(value))
> + value += 2;
> +
> + for (i = max_digits; i != 0; i--) {
> + if (hex && !isxdigit(*value))
> + break;
> + if (!hex && !isdigit(*value))
> + break;
> + value++;
> + }
> + if (end != NULL)
> + *end = value;
> +}
couldn't you use strtol and abuse the endptr field ?
> --- a/tools/env/fw_env.h
> +++ b/tools/env/fw_env.h
>
> +#define min(x, y) ({ \
> + typeof(x) _min1 = (x); \
> + typeof(y) _min2 = (y); \
> + (void) (&_min1 == &_min2); \
> + _min1 < _min2 ? _min1 : _min2; })
ugh, no. use include/compiler.h. you might want to look at the min/max
already defined in include/common.h rather than duplicating another one
locally.
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 06/12] env: Make the "silent" env var take effect immediately
On Friday 17 August 2012 16:49:40 Joe Hershberger wrote: > --- a/common/cmd_nvedit.c > +++ b/common/cmd_nvedit.c > > +#if defined(CONFIG_SILENT_CONSOLE) && \ > + defined(CONFIG_SILENT_CONSOLE_UPDATE_ON_SET) i wonder if the CONFIG_SILENT_CONSOLE check is needed. setting the latter without the former doesn't make sense. > +- CONFIG_SILENT_CONSOLE_UPDATE_ON_SET > + When the "silent" variable is changed with env set, the change > + will take effect immediately should end in a "." -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 05/12] tools/env: Serialize calls to fw_*env
On Friday 17 August 2012 16:49:39 Joe Hershberger wrote:
> Use a lock file at /var/lock/fw_printenv.lock.
the lock should be per-MTD, not per-system.
> + if (-1 == flock(lockfd, LOCK_EX)) {
i guess flock() on the fd returned from the mtd device itself doesn't work ?
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 04/12] tools/env: Reduce the impact on real-time processes
On Friday 17 August 2012 16:49:38 Joe Hershberger wrote: > + * Break reads up into very small chunks so fw_printenv doesn't > + * block the kernel long enough to starve other kernel tasks. err, this sounds like a bug in your kernel driver. why should userspace be working around buggy drivers ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/12] tools/env: Remove unneeded complexity
On Friday 17 August 2012 16:49:36 Joe Hershberger wrote:
> --- a/tools/env/fw_env.c
> +++ b/tools/env/fw_env.c
>
> - memset(value, 0, len - strlen(name));
> + memset(value, 0, len);
side note: this memset is mostly useles as the value buffer largely gets
written. all it should be is:
value[len - 1] = '\0';
similarly, this logic at the end:
if (value)
free(value);
that "if" check is pointless as free(NULL) works fine
if you really wanted, the whole loop could be rewritten to use realloc
for (i = 2; i < argc; ++i) {
const char *val = argv[i];
size_t val_len = strlen(val);
value = realloc(value, len + val_len + 1);
if (!value) {
fprintf(...);
return -1;
}
memcpy(value + len, val, val_len);
len += val_len;
value[len++] = ' ';
}
value[len - 1] = '\0';
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/12] tools/env: Use a board-specific default env
On Friday 17 August 2012 16:49:35 Joe Hershberger wrote: > */ > #define CONFIG_FILE "/etc/fw_env.config" > > +#ifndef CONFIG_FILE this doesn't make any sense. CONFIG_FILE is defined literally right above this check. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [[Patch V2] mips: 01/16] add mips64 standalone support
On Saturday 18 August 2012 22:25:24 Zhi-zhou Zhang wrote: > On 8/18/12, Mike Frysinger wrote: > > On Saturday 18 August 2012 08:22:51 Zhi-zhou Zhang wrote: > >> On Sat, Aug 18, 2012 at 3:31 AM, Mike Frysinger wrote: > >> > On Friday 17 August 2012 11:30:44 Zhizhou Zhang wrote: > >> > > --- a/arch/mips/config.mk > >> > > +++ b/arch/mips/config.mk > >> > > > >> > > +ifeq "$(CPU)" "mips64" > >> > > +CONFIG_STANDALONE_LOAD_ADDR ?= 0xFfffFfff8020 -T mips64.lds > >> > > +else > >> > > CONFIG_STANDALONE_LOAD_ADDR ?= 0x8020 -T mips.lds > >> > > +endif > >> > > >> > the cpu config.mk is sourced after this one. you could change this > >> > to: CONFIG_STANDALONE_LOAD_ADDR ?= > >> > $(DEFAULT_MIPS_STANDALONE_LOAD_ADDR) > >> > DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0x8020 -T mips.lds > >> > > >> > then in the mips64/config.mk: > >> > DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0xFfffFfff8020 -T mips64.lds > >> > >> Thanks for you advising. But if I changed like so, I should modify > >> mips32/ > >> config.mk and xburst/config.mk as also. > > > > why ? my suggestion shouldn't affect any other cpu config.mk. > > Oh, I'm so sorry, I think that you mean to replace > CONFIG_STANDALONE_LOAD_ADDR by DEFAULT_MIPS_STANDALONE_LOAD_ADDR. > So your idea is to keep both CONFIG_STANDALONE_LOAD_ADDR and > DEFAULT_MIPS_STANDALONE_LOAD_ADDR, one for mips64, anther for mips32. > Actually I haven't test standalone example. I add standalone config > and build option for I would get an error if didn't do that. It brings > me a lot of mess. I want to disable stanalone support in TOP Makefile, > could I do that? i don't know what you mean. you should be able to do: --- a/arch/mips/config.mk +++ b/arch/mips/config.mk @@ -23,7 +23,8 @@ CROSS_COMPILE ?= mips_4KC- -CONFIG_STANDALONE_LOAD_ADDR ?= 0x8020 -T mips.lds +CONFIG_STANDALONE_LOAD_ADDR ?= $(DEFAULT_MIPS_STANDALONE_LOAD_ADDR) +DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0x8020 -T mips.lds PLATFORM_CPPFLAGS += -DCONFIG_MIPS -D__MIPS__ then in your arch/mips/mips64/config.mk, add this one line: DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0xFfffFfff8020 -T mips64.lds does that not work ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch V3 1/4] [MIPS] Add support for MIPS64 cpus
On Monday 20 August 2012 10:22:23 Zhizhou Zhang wrote:
> +void __weak _machine_restart(void)
> +{
> +}
this should be:
void __noreturn __weak _machine_restart(void)
{
while (1);
}
there should also be a prototype for this in one of the mips64 headers
> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +{
> + _machine_restart();
> +
> + fprintf(stderr, "*** reset failed ***\n");
> + return 0;
> +}
then this would be:
int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
_machine_restart();
}
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch V3 0/4] add mips64 cpu support
On Monday 20 August 2012 10:22:22 Zhizhou Zhang wrote: > This patch add mips64 cpu support. > Changes in V3: > - merge related files into one patch, no longer one file one patch. > - add detailed commit message. > - remove standalone example. it's too complicate. do you keep sending these patchsets in duplicate on purpose ? your v2 and v3 series both were doubly sent. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/6] net: asix: split out basic reset function
On Wednesday 22 August 2012 06:09:04 Lucas Stach wrote: > The basic device reset ensures that the device is ready to > service commands and does not need to get redone before each > network operation. > > Split out the basic reset from asix_init() and instead call it > from asix_eth_get_info(), so that it only gets called once. i'm afraid this is wrong. the register step (which asix_eth_get_info is afaict) should not touch the hardware (other than to extract the MAC address). the init func is supposed to bring up the hardware from scratch since the expectation is that the halt func brings it down completely. if it's not really possible to completely "bring down" the hardware, then have the asix_init func declare a local static int so that it does the "full" bring up only once. so NAK this patch as is -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/5] MX28: SPI: Supercharge the SPI driver
On Wednesday 22 August 2012 13:43:19 Marek Vasut wrote: > Dear Mike Frysinger, > > On Tuesday 21 August 2012 22:17:27 Marek Vasut wrote: > > > This change implements DMA chaining into SPI driver. This allows > > > the transfers to go much faster, while also fixing SF issues. > > > > might be nice to have the word "DMA" in the patch summary > > > > MX28: SPI: Supercharge the SPI driver w/DMA > > Possibly ... it's obvious from the description though yes, the description makes it obvious, if you get that far. but the summary is useless when scanning with `git log --format=oneline`, or even just `git log` and letting the eye track the subject line. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Blackfin BF547 board testing.
On Wednesday 22 August 2012 11:13:54 Dimitar Penev wrote: > - GCC assumes rev 0.2 of the CPU is this OK with the rev 0.4 which we have > on board? err, gcc assumes nothing. this is controlled by your board config's CONFIG_BFIN_CPU setting. > The first reason for this behavior seems to be memory issue. hardware (and certainly linux) issues are probably better diagnosed on the ADI support forums: http://ez.analog.com/community/dsp/blackfin-processors http://ez.analog.com/community/dsp/software-and-development-tools -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/5] MX28: SPI: Supercharge the SPI driver
On Tuesday 21 August 2012 22:17:27 Marek Vasut wrote: > This change implements DMA chaining into SPI driver. This allows > the transfers to go much faster, while also fixing SF issues. might be nice to have the word "DMA" in the patch summary MX28: SPI: Supercharge the SPI driver w/DMA -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/4] spi: atmel: add WDRBT bit to avoid receive overrun
On Tuesday 21 August 2012 07:11:18 Andreas Bießmann wrote: > On 20.08.2012 08:32, Bo Shen wrote: > > The atmel at91sam9x5 series spi has feature to avoid receive overren > > > > Using the patch to enable it > > > > Signed-off-by: Bo Shen > > Acked-by: Andreas Bießmann > > Mike, will you take this patch? for SoC drivers, sometimes i'll help review, but i'd expect it to be merged through the respective architecture tree. i've only been sheriffing the spi core changes. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] spiflash: at25: using common spi flash operation
On Tuesday 21 August 2012 07:26:27 Andreas Bießmann wrote: > On 20.08.2012 08:32, Bo Shen wrote: > > Using common spi flash operation function to replace private operation > > funtion > > > > This patch is based on http://patchwork.ozlabs.org/patch/177896/ > > which has been merged by Mike frysinger > > Mike, do you think this is a fix? Should it go into 2012.10? Will you > take it? i'll take care of merging the changes to drivers/mtd/spi/*, but always happy to see people help to review the changes :). especially with the atmel driver as their dataflashes have the unique command set :(. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch v3 2/2] net: asix: add support for AX88772B
On Tuesday 21 August 2012 09:23:13 Lucas Stach wrote: > + struct ueth_data *dev = (struct ueth_data *)eth->priv; > + struct asix_private *priv = (struct asix_private *)dev->dev_priv; not that it's harmful, but priv is void*, so the casts aren't needed > + ALLOC_CACHE_ALIGN_BUFFER(unsigned char, ee_buf, 2); > + ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buf, ETH_ALEN); since you don't use both buffers at the same time, just declare one that is big enough to work for either code path. so looks like you could throw away ee_buf here. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch v3 1/2] net: introduce transparent driver private in ueth_data
On Tuesday 21 August 2012 09:23:12 Lucas Stach wrote: > Avoid clutter in ueth_data. Individual drivers should not mess > with structures belonging to the core like this. nice work -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] fdt: Add a Linux tool for reading values from FDT files
On Monday 20 August 2012 20:51:32 Joe Hershberger wrote: > On Mon, Aug 20, 2012 at 7:24 PM, Mike Frysinger wrote: > > On Monday 20 August 2012 19:40:45 Joe Hershberger wrote: > >> On Fri, Aug 17, 2012 at 6:35 PM, Mike Frysinger wrote: > >> > On Friday 17 August 2012 16:34:40 Joe Hershberger wrote: > >> >> Designed to be able to access itb files on a filesystem or an mtd > >> >> partition. > >> >> > >> >> Supports print and list (like the fdt command) and also offset for > >> >> finding the offset and size of a given property in an FDT file. > >> >> > >> >> This is especially helpful when reading properties from an ITB file. > >> > > >> > doesn't the ftdump utility from the dtc package cover your needs ? > >> > >> No. The purpose is to use this utility e.g. in a Linux shell script > >> to retrieve a property from the ITB. The two places I use it are to > >> retrieve a version number from the ITB and to identify the offset and > >> size of a data block (image) in the ITB. > >> > >> From what I can see the ftdump utility in the dtc component just dumps > >> the ITB as a single blob with no options. I'm looking at the dtc > >> 1.2.0 source. > > > > ... so wouldn't the logical thing be to extend ftdump to support your > > needs and send a patch to the DTC authors rather than to write an entire > > tool from scratch and commit it to a tree that is merely a user of > > device trees ? > > Yes it probably would have been, if I had noticed that the ftdump > utility existed, then that is the approach I would have taken. I > think it is of specific use to u-boot users, but if you think it's > better to extend ftdump, I guess I could take that approach. i think it has a better chance of being maintained and other people using it if it were merged into the canonical DTC project. i can see a more swiss army type tool being useful to people rather than having to pipe it all through awk. git: git://git.jdl.com/software/dtc.git e-mail: devicetree-disc...@lists.ozlabs.org they're friendly people :) -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] fdt: Add a Linux tool for reading values from FDT files
On Monday 20 August 2012 19:40:45 Joe Hershberger wrote: > On Fri, Aug 17, 2012 at 6:35 PM, Mike Frysinger wrote: > > On Friday 17 August 2012 16:34:40 Joe Hershberger wrote: > >> Designed to be able to access itb files on a filesystem or an mtd > >> partition. > >> > >> Supports print and list (like the fdt command) and also offset for > >> finding the offset and size of a given property in an FDT file. > >> > >> This is especially helpful when reading properties from an ITB file. > > > > doesn't the ftdump utility from the dtc package cover your needs ? > > No. The purpose is to use this utility e.g. in a Linux shell script > to retrieve a property from the ITB. The two places I use it are to > retrieve a version number from the ITB and to identify the offset and > size of a data block (image) in the ITB. > > From what I can see the ftdump utility in the dtc component just dumps > the ITB as a single blob with no options. I'm looking at the dtc > 1.2.0 source. ... so wouldn't the logical thing be to extend ftdump to support your needs and send a patch to the DTC authors rather than to write an entire tool from scratch and commit it to a tree that is merely a user of device trees ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] net: asix: add support for AX88772B
On Monday 20 August 2012 13:52:18 Lucas Stach wrote:
> + memset(buf, 0, ETH_ALEN);
this memset is pointless
> + for (i = 0; i < (ETH_ALEN >> 1); i++) {
> + memset(read_buf, 0, 2);
this memset is pointless
> + memcpy((buf + i*2), read_buf, 2);
use spaces: "i * 2"
> + debug("MAC read from EEPROM: %02x:%02x:%02x:%02x:%02x:%02x\n",
> + buf[0], buf[1], buf[2], buf[3], buf[4], buf[5]);
use %pM instead of spelling out each byte yourself
> + if (asix_write_cmd(dev, AX_CMD_WRITE_NODE_ID, 0, 0, ETH_ALEN, buf)) {
> + printf("Failed to set MAC address.\n");
> + return -1;
> + }
> +
> + return 0;
> +}
ret = asix_write_cmd(...)
if (ret)
puts(...);
return ret;
> static struct asix_dongle asix_dongles[] = {
this probably should be const
> --- a/include/usb_ether.h
> +++ b/include/usb_ether.h
>
> +#ifdef CONFIG_USB_ETHER_ASIX
> + int asix_flags;
> +#endif
> };
looks like the usb ether stack is fundamentally flawed if drivers are allowed
to screw with the structure. this is what "void *priv" fields are for.
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] arm: rmobile: Add support Renesas SH73A0
On Sunday 19 August 2012 10:40:05 Nobuhiro Iwamatsu wrote:
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/rmobile/board.c
>
> +#ifdef CONFIG_DISPLAY_BOARDINFO
> +int checkboard(void)
> +{
> + printf("Board: %s\n", sysinfo.board_string);
> + return 0;
> +}
> +#endif /* CONFIG_DISPLAY_BOARDINFO */
seems like you could have the makefile do:
COBJS-$(CONFIG_DISPLAY_BOARDINFO) += board.o
then you wouldn't need these ifdefs in this file
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/rmobile/cpu_info-sh73a0.c
>
> +#ifdef CONFIG_DISPLAY_CPUINFO
> +u32 rmobile_get_cpu_type(void)
> +{
> + u32 id;
> + u32 type;
> + struct sh73a0_hpb *hpb = (struct sh73a0_hpb *)HPB_BASE;
> +
> + id = readl(hpb->cccr);
> + type = (id >> 8) & 0xFF;
> +
> + return type;
> +}
> +
> +u32 get_cpu_rev(void)
> +{
> + u32 id;
> + u32 rev;
> + struct sh73a0_hpb *hpb = (struct sh73a0_hpb *)HPB_BASE;
> +
> + id = readl(hpb->cccr);
> + rev = (id >> 4) & 0xF;
> +
> + return rev;
> +}
> +#endif /* CONFIG_DISPLAY_CPUINFO */
seems like you could have the makefile do:
COBJS-$(CONFIG_DISPLAY_CPUINFO) += board.o
then you wouldn't need these ifdefs in this file
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [[Patch V2] mips: 01/16] add mips64 standalone support
On Saturday 18 August 2012 08:22:51 Zhi-zhou Zhang wrote: > On Sat, Aug 18, 2012 at 3:31 AM, Mike Frysinger wrote: > > On Friday 17 August 2012 11:30:44 Zhizhou Zhang wrote: > > > --- a/arch/mips/config.mk > > > +++ b/arch/mips/config.mk > > > > > > +ifeq "$(CPU)" "mips64" > > > +CONFIG_STANDALONE_LOAD_ADDR ?= 0xFfffFfff8020 -T mips64.lds > > > +else > > > CONFIG_STANDALONE_LOAD_ADDR ?= 0x8020 -T mips.lds > > > +endif > > > > the cpu config.mk is sourced after this one. you could change this to: > > CONFIG_STANDALONE_LOAD_ADDR ?= $(DEFAULT_MIPS_STANDALONE_LOAD_ADDR) > > DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0x8020 -T mips.lds > > > > then in the mips64/config.mk: > > DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0xFfffFfff8020 -T mips64.lds > > Thanks for you advising. But if I changed like so, I should modify mips32/ > config.mk and xburst/config.mk as also. why ? my suggestion shouldn't affect any other cpu config.mk. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/7 V4] SPI: Add W25Q32 to Winbond SPI flash table
On Friday 17 August 2012 04:28:02 Joonyoung Shim wrote:
> 2012/8/2 Rajeshwari Shinde :
> > + {
> > + .id = 0x5014,
> > + .l2_page_size = 8,
> > + .pages_per_sector = 16,
> > + .sectors_per_block = 16,
>
> Above three fields is removed from commit
> a4ed3b653163367628d4ad173dfe3faf388da0ac,
that was mentioned & fixed already
> but in spi_flash_probe_winbond()
>
>flash->page_size = 4096;
this was also reported & fixed independently
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] net: Allow netconsole settings to change after nc_start
On Friday 17 August 2012 15:48:20 Joe Hershberger wrote: > --- a/drivers/net/netconsole.c > +++ b/drivers/net/netconsole.c > > +static int refresh_settings_from_env(void) this func always returns 0. why not change it to void to simplify the code (source and generated) ? > + char *p; const -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/12] env: Check for NULL pointer in envmatch()
On Friday 17 August 2012 16:49:42 Joe Hershberger wrote: > If the pointer passed into envmatch() is NULL, return -1 instead of > crashing. so don't pass in NULL ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] Implement verify option for sha1sum command
On Friday 17 August 2012 17:00:45 Joe Hershberger wrote: > Loosely based on CONFIG_CRC32_VERIFY. i've always found that code logic in desperate need of cleaning up. let's please not copy this wart. can't we unify these two code paths ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add a memory get command
On Friday 17 August 2012 16:58:41 Joe Hershberger wrote:
> --- a/common/cmd_mem.c
> +++ b/common/cmd_mem.c
>
> +#ifdef CONFIG_CMD_MEM_GET
not the greatest name ...
> +int do_mem_mg(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
static
> + size = cmd_get_data_size(argv[0], 4);
> + if (size < 0)
> + return 1;
> +
> + var = argv[1];
> +
> + addr = simple_strtoul(argv[2], NULL, 16);
> + addr += base_address;
> +
> + if (size == 4) {
> + uint32_t value = readl(addr);
why use io.h commands ? we don't use it with any of the other mem commands.
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add a command to access the system timer
On Friday 17 August 2012 16:57:58 Joe Hershberger wrote: > Two sub-commands... start and get. > * start sets the reference. > * get prints out the time since the last start (in "." format). > If get is called without start, returns time since boot. > Simple way to benchmark an operation: "timer > start;;timer get" please add a CONFIG_CMD_xxx for this > --- a/common/cmd_misc.c > +++ b/common/cmd_misc.c > > +int do_timer(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) static > +U_BOOT_CMD( > + timer ,2,1, do_timer, no space between "timer" and "," -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add a new "ini" command
On Friday 17 August 2012 16:56:57 Joe Hershberger wrote:
> This allows you to read ini-formatted data from anywhere and then
> import one of the sections into the environment
>
> This is based on rev 16 at http://code.google.com/p/inih/
document it in top level README ?
> --- /dev/null
> +++ b/common/cmd_ini.c
>
> +int do_ini(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
static
> +{
> + const char *section;
> + char *file_address;
> + size_t file_size;
> +
> + if (argc == 1)
> + return CMD_RET_USAGE;
> +
> + section = argv[1];
> + if (argc < 3)
> + file_address = (char *)simple_strtoul(getenv("loadaddr"),
> + NULL, 16);
> + else
> + file_address = (char *)simple_strtoul(argv[2], NULL, 16);
file_address = (char *)simple_strtoul(argc < 3 ? getenv("loadaddr") : argv[2],
NULL, 16);
> + if (argc < 4)
> + file_size = (size_t)simple_strtoul(getenv("filesize"),
> + NULL, 16);
> + else
> + file_size = (size_t)simple_strtoul(argv[3], NULL, 16);
same here
> + ini_parse(file_address, file_size, ini_handler, (void *)section);
> +
> + /* success */
> + return 0;
> +}
return ini_parse() ?
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Change dead code in "test" cmd to debug output
On Friday 17 August 2012 16:56:12 Joe Hershberger wrote:
> --- a/common/cmd_test.c
> +++ b/common/cmd_test.c
>
> -#if 0
> +#ifdef DEBUG
> {
> - printf("test:");
> + debug("test(%d):", argc);
> left = 1;
> while (argv[left])
> - printf(" %s", argv[left++]);
> + debug(" '%s'", argv[left++]);
> }
> #endif
i think you can even remove the #ifdef DEBUG here since debug() will expand to
nothing, and gcc should do DCE on the whole block
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Output strings from echo with puts where easy
On Friday 17 August 2012 16:55:18 Joe Hershberger wrote:
> --- a/common/cmd_echo.c
> +++ b/common/cmd_echo.c
>
> - while ((c = *p++) != '\0') {
> - if (c == '\\' && *p == 'c') {
> - putnl = 0;
> - p++;
> - } else {
> - putc(c);
> - }
> +
> + nls = strstr(p, "\\c");
> + if (nls) {
> + putnl = 0;
> + *nls = '\0';
> + puts(p);
> + puts(nls + 2);
> + *nls = '\\';
> + } else {
> + puts(p);
> }
> }
what if someone uses \c multiple times ?
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Cleanup cache command prints
On Friday 17 August 2012 16:54:23 Joe Hershberger wrote: > Only print when queried, not every time the setting is changed. considering there's a lot more style changes here than functional, it'd probably be good to split up into two as for the basic idea, makes sense to me -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] fdt: Add a Linux tool for reading values from FDT files
On Friday 17 August 2012 16:34:40 Joe Hershberger wrote: > Designed to be able to access itb files on a filesystem or an mtd > partition. > > Supports print and list (like the fdt command) and also offset for > finding the offset and size of a given property in an FDT file. > > This is especially helpful when reading properties from an ITB file. doesn't the ftdump utility from the dtc package cover your needs ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/3] hush: Include file and line number when reporting syntax errors
On Friday 17 August 2012 16:26:31 Joe Hershberger wrote:
> Make debugging script problems easier just like non-u-boot.
err, but you're posting "hush.c" all the time, and the line number of the
source code in hush.c, not the line of the shell script
> --- a/common/hush.c
> +++ b/common/hush.c
>
> #ifdef __U_BOOT__
> -static void syntax_err(void) {
> - printf("syntax error\n");
> +static void __syntax_err(char *file, int line)
const char *file
> +{
> + printf("syntax error %s:%d\n", file, line);
> }
> +#define syntax_err() __syntax_err(__FILE__, __LINE__)
shouldn't this be behind a DEBUG define ?
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] hush: Add default value substitution support
On Friday 17 August 2012 16:26:29 Joe Hershberger wrote:
> Use standard sh syntax:
> ${VAR:-default}
> Use default value: if VAR is set and non-null, expands to $VAR.
> Otherwise, expands to default.
> ${VAR:=default}
> Set default value: if VAR is set and non-null, expands to $VAR.
> Otherwise, sets hush VAR to default and expands to default.
> ${VAR:+default}
> If VAR is set and non-null, expands to the empty string.
> Otherwise, expands to default.
how about ${VAR-default} and ${VAR=default} and ${VAR+default} ?
> --- a/common/hush.c
> +++ b/common/hush.c
>
> + if (sep) {
> + *sep = '\0';
> + if (*(sep + 1) == '-')
switch (sep[1]) {
case '-':
...
> + default_val = sep+2;
sep + 2
> + if (!p || strlen(p) == 0) {
if (!p || !p[0])
> + if (assign) {
> + char *var = malloc(strlen(src)+strlen(default_val)+2);
please put spaces around the "+"
> + if (var) {
> + sprintf(var, "%s=%s", src, default_val);
> + set_local_var(var, 0);
> + }
isn't there a helper func for this ?
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] Add unlzma command
On Friday 17 August 2012 16:59:43 Joe Hershberger wrote: > Provide access to the lzma decompressor from the command line. same feedback for this file as the unlzo command feedback -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] Add unlzo command
On Friday 17 August 2012 16:59:44 Joe Hershberger wrote:
> --- a/common/Makefile
> +++ b/common/Makefile
>
> ifdef CONFIG_LZMA
> COBJS-$(CONFIG_CMD_UNLZMA) += cmd_unlzma.o
> endif
> +ifdef CONFIG_LZO
> +COBJS-$(CONFIG_CMD_UNLZO) += cmd_unlzo.o
> +endif
imo, these ifdefs shouldn't exist. the commands shouldn't get silently
ignored because someone omitted an option. add an #ifdef check to the .c file
and have it #error out if the necessary config options aren't defined.
> --- /dev/null
> +++ b/common/cmd_unlzo.c
>
> +int do_unlzo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
static
> + ret = lzop_decompress((void *)src, src_len, (void *)dst, &dst_len);
> + if (ret != LZO_E_OK) {
> + printf("unlzo: uncompress or overwrite error %d\n", ret);
> + return -1;
how about returning ret ?
> + sprintf(buf, "%lX", (unsigned long) dst_len);
> + setenv("filesize", buf);
setenv_ulong() ?
> +U_BOOT_CMD(
> + unlzo, 5, 1, do_unlzo,
> + "unlzo a memory region",
> + "srcaddr srcsize dstaddr [dstsize]"
> +);
isn't there a way you could "stream" this so you don't need the srcsize ? or
does the lzop API not support that ?
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [[Patch V2] mips: 06/16] add cpu/mips64/start.S
On Friday 17 August 2012 11:30:49 Zhizhou Zhang wrote: > remove cache init this commit message doesn't make much sense. if it meant to be covering what changed since v1, put it below the "---" marker below. > --- /dev/null > +++ b/arch/mips/cpu/mips64/start.S > > + .globl _start > + .text > +_start: include linux/linkage.h, then use: ENTRY(_start) you'll probably want to review the .S file for other places to use ENTRY() and LENTRY() and ENDPROC() and END(). -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [[Patch V2] mips: 04/16] add cpu/mips64/cpu.c
On Friday 17 August 2012 11:30:47 Zhizhou Zhang wrote:
> --- /dev/null
> +++ b/arch/mips/cpu/mips64/cpu.c
>
> +void __attribute__((weak)) _machine_restart(void)
> +{
> +}
change to __weak (include linux/compiler.h if you need to).
> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +{
> + _machine_restart();
> +
> + fprintf(stderr, "*** reset failed ***\n");
> + return 0;
> +}
this function should never return. add a __noreturn to machine_restart().
> +void cache_probe()
(void)
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [[Patch V2] mips: 03/16] add cpu/mips64/config.mk
On Friday 17 August 2012 11:30:46 Zhizhou Zhang wrote: > --- /dev/null > +++ b/arch/mips/cpu/mips64/config.mk > > +ENDIANNESS = -EL > + > +MIPSFLAGS += $(ENDIANNESS) seems to me this logic should get moved out of mips32/config.mk and into the top level mips config.mk -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [[Patch V2] mips: 01/16] add mips64 standalone support
On Friday 17 August 2012 11:30:44 Zhizhou Zhang wrote: > --- a/arch/mips/config.mk > +++ b/arch/mips/config.mk > > +ifeq "$(CPU)" "mips64" > +CONFIG_STANDALONE_LOAD_ADDR ?= 0xFfffFfff8020 -T mips64.lds > +else > CONFIG_STANDALONE_LOAD_ADDR ?= 0x8020 -T mips.lds > +endif the cpu config.mk is sourced after this one. you could change this to: CONFIG_STANDALONE_LOAD_ADDR ?= $(DEFAULT_MIPS_STANDALONE_LOAD_ADDR) DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0x8020 -T mips.lds then in the mips64/config.mk: DEFAULT_MIPS_STANDALONE_LOAD_ADDR = 0xFfffFfff8020 -T mips64.lds -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] spi: add atmel at25df321 serial flash support
On Friday 17 August 2012 01:08:01 Bo Shen wrote: > On 8/17/2012 12:18, Mike Frysinger wrote: > > On Thursday 16 August 2012 00:44:25 Bo Shen wrote: > >> Add atmel at25df321 serial flash support > > After reading the spi framework. I found there are common interface for > serial flash. So, I plan to use the common interface > (spi_flash_cmd_write_multi) while not the private interface > (dataflash_write_p2), and etc. > > I am sorry for this inconvenience. :( > > Will you revert this patch? Or, maybe I should submit a patch for this > base on the merged code? > > which one will you prefer to? i think this is an independent issue that the atmel driver has long not been using the unified pieces. if you want to submit a patch on top of this one, that'd be best. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/9] SOUND: Add I2S driver
On Friday 17 August 2012 08:48:59 Andrew Dyer wrote: > The code in the i2s.c file is still full of samsung soc specific stuff, so > I think the filename is misleading. Something like samsung-i2s.c would be > more appropriate. +1 -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] README: Update ver env var description
On Monday 13 August 2012 09:01:14 Benoît Thébaudeau wrote: > Commit 155cb01 replaced the read-only property of the ver env var with an > auto-restoring behavior. Update the README file accordingly. Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] spi: add atmel at25df321 serial flash support
On Thursday 16 August 2012 00:44:25 Bo Shen wrote: > Add atmel at25df321 serial flash support thanks, merged into my spi flash branch -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5] Consolidate bootcount code into drivers/bootcount
On Thursday 16 August 2012 23:55:41 Stefan Roese wrote: > This patch moves all bootcount implementations into a common > directory: drivers/bootcount. The generic bootcount driver > is now usable not only by powerpc platforms, but others as well. Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] smc911x and CONFIG_NET_MULTI
On Tuesday 14 August 2012 12:25:34 Dimitar Penev wrote: > We have developed a custom blackfin board having two LAN9218 chips on > board. Is the available smc911x driver tested with multiple network chips > on board? all net drivers have been converted to net multi a long time ago. > The base address of the first chip should be set to CONFIG_SMC911X_BASE. that is a board-specific convention. update your board_eth_init() to use whatever addresses you want. > On what physical address the second chip should be allocated so uboot finds > it? that is up to you to manage. u-boot has no addresses hardcoded in it except what *you* define in board_eth_init(). -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] spi_nor: add m25p32 spi nor driver
On Tuesday 14 August 2012 06:58:31 Terry Lv wrote: > This driver is ported from kernel and can handle a series of spi nor > flash including m25pxx, m45pxx, w25xxx, cat25xxx, sst25vf0xxx, > sst25wfxxx, s25xxx, mx25xxx, at25xxx, at26xxx, en25xxx, xxxs33b. it doesn't make much sense to add a driver which duplicates all the existing ones. long term, we should look at migrating to the linux driver i think (if we can make it work), but i don't think this port is exactly the way. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch 0/17] New 'qemu-mips64' test architecture for U-Boot
On Tuesday 14 August 2012 11:49:49 Mike Frysinger wrote: > On Tuesday 14 August 2012 11:06:51 Zhi-zhou Zhang wrote: > > As so far, U-Boot has already supports mips32. But there are some > > > > differences between mips64 and mips32. Such as different ABI, different > > output format. so this patch adds mips64 support. > > many of your patches are line wrapped. please use `git send-email` rather > than whatever client you're using (looks like gmail?) as it won't screw > things up. hmm, actually it's worse than that -- the leading whitespace is all mangled too. i'm assuming your code isn't that screwed up, so please resend with git- sendemail. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Patch 0/17] New 'qemu-mips64' test architecture for U-Boot
On Tuesday 14 August 2012 11:06:51 Zhi-zhou Zhang wrote: > As so far, U-Boot has already supports mips32. But there are some > differences between mips64 and mips32. Such as different ABI, different > output format. so this patch adds mips64 support. many of your patches are line wrapped. please use `git send-email` rather than whatever client you're using (looks like gmail?) as it won't screw things up. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] sf: spansion: Add support for S25FL256S
On Tuesday 14 August 2012 07:11:22 Michal Simek wrote: > Add support for Spansion S25FL256S SPI flash. thanks, added to my sf branch -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request u-boot-blackfin.git (sf branch)
The following changes since commit 4d3c95f5ea7c737a21cd6b9c59435ee693b3f127: zfs: Add ZFS filesystem support (2012-08-09 23:42:20 +0200) are available in the git repository at: git://www.denx.de/git/u-boot-blackfin.git sf for you to fetch changes up to 4a4cb4e11149158c9eabb1537a1eaee7372ce491: sf: spansion: Add support for S25FL256S (2012-08-14 11:45:50 -0400) Marek Vasut (1): cmd_spi: remove superfluous semicolon Michal Simek (2): sf: stmicro: add support for N25Q128A sf: spansion: Add support for S25FL256S Rajeshwari Shinde (1): sf: winbond: add W25Q32 Stephan Linz (2): sf: stmicro: support JEDEC standard two-byte signature sf: stmicro: add support N25Q128 parts Stephen Warren (1): sf: winbond: fix page_size common/cmd_spi.c |2 +- drivers/mtd/spi/spansion.c |7 +++ drivers/mtd/spi/stmicro.c | 39 +++ drivers/mtd/spi/winbond.c |7 ++- 4 files changed, 41 insertions(+), 14 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] sf: winbond: fix page_size
On Monday 13 August 2012 18:46:21 Stephen Warren wrote: > Commit a4ed3b6 "sf: inline data constants" modified winbond.c's page_size > from 256 to 4096. This prevents either/both of "sf write" writing the > correct data, or "sf read" from reading the correct data back. yeah, sorry about that. merged into my branch. > I'm not convinced there aren't other similar problems. At least eon.c's > values don't make much sense to me; sector_size=256*16*16, yet total > device size is just 256*16*nr_sectors. That was a pre-existing issue > though. yes, i get the feeling most spi drivers just copied an existing one, switched out some constants until it worked, and then moved on. i don't have an EON flashes, so i haven't looked too much. > Another audit might make sense. This might be due to the apparent > separation between page/sector/block, yet struct spi_flash only knowing > about page and sectors, not blocks, leaving sf authors to wonder whether > blocks are really sectors, or just to ignore blocks? part of it is that SPI flashes themselves aren't constant in terms of what they call blocks, sectors, and pages. so people have to read the datasheet and try and coordinate the meanings in that with how the spi flash code represents things, and coordinate with the erase commands that get used. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] Consolidate bootcount code into drivers/bootcount
On Monday 13 August 2012 07:56:03 Stefan Roese wrote: > rename arch/blackfin/cpu/bootcount.c => > drivers/bootcount/bootcount_blackfin.c (100%) create mode 100644 hmm, file was moved, but forgot to update arch/blackfin/cpu/Makefile to no longer refer to bootcount.c, so it fails. once that's fixed, it appears to build fine, and the compiled code looks OK to me. might be able to convert to the common code, but for now, i won't bother as it'll require some testing first. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] dlmalloc: remove manual reloc alias warning
On Monday 13 August 2012 05:02:03 Andreas Bießmann wrote: > From: Andreas Bießmann > > The avr32 architecture (and some others) require manual relocation. Due to > the previous error all avr32 boards gave warnings in MAKEALL wich makes it > hard to find new warnings. > > This patch fixes following warning: > ---8<--- > dlmalloc.c: In function 'malloc_bin_reloc': > dlmalloc.c:1493: warning: dereferencing pointer 'p' does break > strict-aliasing rules dlmalloc.c:1493: warning: dereferencing pointer 'p' > does break strict-aliasing rules dlmalloc.c:1490: note: initialized from > here > dlmalloc.c:1493: note: initialized from here > --->8--- > > Signed-off-by: Andreas Bießmann > --- > A question to all the other related arches, namely m68k, mips, nds32 and > sparc: Do you encounter the same warnings or is this warning due to my > outdated compiler (4.4.3 currently, unfortunately atmel do not bother to > send their patches mainline)? previous thread (and i think there was one before this): http://patchwork.ozlabs.org/patch/134597/ -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision
On Sunday 12 August 2012 13:11:03 Benoît Thébaudeau wrote: > OK. Actually, the only reason for which I need this patch is to make a > variable read-only, and the only reason for which you reject it is because > you fear that it breaks something. and because it bloats the codebase for 0 gain for the vast majority of boards (every one currently in the tree). -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision
On Sunday 12 August 2012 10:02:48 Benoît Thébaudeau wrote: > Dear Wolfgang Denk, > > > I have searched such a usage in the tree, but did not find any, so > > > this should > > > not break anything. > > > > You cannot expect to see the real, production environments in the > > mainline source tree. > > Right, but the same applied to serial# and ethaddr when they were added, > except if U-Boot deployment was not large enough at that time to worry > you. which makes all the difference in the world. those two variables were set up this way before 2002 (at least, that's according to the git history, and that's when the source code was first imported, so i can't easily check just how far back it goes). as the project grows up, policies evolve. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/5] README: The ver env var is not read-only
On Sunday 12 August 2012 09:58:24 Benoît Thébaudeau wrote: > Dear Wolfgang Denk, > > The correct fix for this would be the introduction of variable types, > > including flags like "read-only" (as for serial# or ethaddr) or > > "volatile" (i. e. not included in saveenv, as for filesize etc.) > > > > I have been thinking about this for a long time already, I just > > didn't > > find time yet to implement it. > > OK. Don't you think that the README file should be updated in some way in > the meantime to reflect this, since ver is neither read-only nor "normal"? sure, just mention any updates to it will be lost -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Is there file size limiation of tftp
On Saturday 11 August 2012 21:21:03 J.Hwan Kim wrote: > Is there any limit of file size for tftpboot? not really. how much unused RAM do you have ? > I have a problem downloading the file of which file size is 65MB. did you overwrite u-boot or something ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mtest: Disable dcache during test
On Saturday 11 August 2012 16:05:36 Benoît Thébaudeau wrote:
> On 08/11/2012 21:47, Andrew Dyer wrote:
> > I agree with Mike, use the current dcache settings. U-boot has always
> > assumed the user knew what they were doing.
> > If you want to print a small message with the dcache setting that
> > makes sense to me, but no big warning.
>
> Then, something like the following at runtime in the first lines printed my
> mtest?
>
> dcache state: on
i'd be fine with that. something like below (if you want to test & post,
that'd be good).
-mike
diff --git a/common/cmd_mem.c b/common/cmd_mem.c
index 18f0a3f..5628f6a 100644
--- a/common/cmd_mem.c
+++ b/common/cmd_mem.c
@@ -651,8 +651,10 @@ int do_mem_mtest (cmd_tbl_t *cmdtp, int flag, int argc,
char * const argv[])
else
iteration_limit = 0;
+ printf("Testing %08x ... %08x (dcache: %s):\n", (uint)start, (uint)end,
+ dcache_status() ? "on" : "off");
+
#if defined(CONFIG_SYS_ALT_MEMTEST)
- printf ("Testing %08x ... %08x:\n", (uint)start, (uint)end);
debug("%s:%d: start 0x%p end 0x%p\n",
__FUNCTION__, __LINE__, start, end);
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mtest: Disable dcache during test
On Saturday 11 August 2012 10:17:04 Benoît Thébaudeau wrote: > On 08/11/2012 05:18 AM, Mike Frysinger wrote: > > On Friday 10 August 2012 15:16:15 Benoît Thébaudeau wrote: > > > mtest is supposed to test many types of memory accesses in many > > > different > > > conditions. If dcache is enabled, memory accesses are likely > > > bursts, and > > > some memory accesses are simply skipped. Hence, dcache should be > > > disabled > > > during mtest operation so that what mtest actually tests is not > > > masked by > > > dcache. > > > > if you want dcache disabled, then why don't you run `dcache off` > > first ? i > > think it's useful to be able to do both, and forcing it one way is > > wrong. > > > > thus, NAK from me. > > Because you will very likely trust mtest and forget about running `dcache > off` first, so you may then be happy about falsely positive mtest results. there are a lot of commands in u-boot that people could "easily forget" to tweak and have it do the wrong thing. imo, mtest running in the active cache/memory settings is the *expected* behavior rather than having it silently reconfigure the system behind the back of the user. > Moreover, I can't find any sense or usefulness in running mtest with > dcache enabled. it can be useful to stress test the system with cache enabled. i recall during some early porting work that being able to test both caught bugs that we might have missed otherwise. > If there is really a need for running mtest with dcache enabled, an option > (disabled by default) could be added to the command line to tell mtest not > to disable dcache. we already have such an option: dcache off; mtest; dcache on -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/5] Add env var giving the board revision
On Friday 10 August 2012 13:46:08 Benoît Thébaudeau wrote: > The board revision can be a useful env var, like its serial number. unless i missed something, there is no standard "rev" variable today, which means this change can easily break anyone who happens to already be using a variable named "rev". i also don't see value here in hardcoding another variable that: - no one is setting - is way too generic (rev of *what* ? cpu ? board ? u-boot ? something else ?) - adds nothing on top of the existing "serial#" so NAK from me -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] eth_write_hwaddr: Return error for invalid MACs
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 4/5] README: The ver env var is not read-only
On Friday 10 August 2012 13:45:57 Benoît Thébaudeau wrote: > --- u-boot-4d3c95f.orig/README > +++ u-boot-4d3c95f/README > > If this variable is defined, an environment variable > named "ver" is created by U-Boot showing the U-Boot > version as printed by the "version" command. > - This variable is readonly. why don't we fix it to be read-only ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/5] env import/export: Remove from help if disabled
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] Consolidate bootcount code into drivers/bootcount
On Tuesday 05 June 2012 02:37:55 Stefan Roese wrote:
> --- /dev/null
> +++ b/drivers/bootcount/Makefile
>
> +COBJS-$(CONFIG_BFIN_CPU) += bootcount_blackfin.o
needs to be CONFIG_BLACKFIN
> +all: $(LIB)
unused rule -> delete
> --- /dev/null
> +++ b/include/bootcount.h
>
> +#ifdef CONFIG_SYS_BOOTCOUNT_LE
> +static inline void bc_out32(volatile u32 *addr, u32 data)
the bc_xxx names are a little confusing since they overlap so much with the
existing io.h api. how about "raw_bootcount_store" ?
> +{
> + out_le32(addr, data);
> +}
> +
> +static inline u32 bc_in32(volatile u32 *addr)
> +{
> + return in_le32(addr);
> +}
> +#else
> +static inline void bc_out32(volatile u32 *addr, u32 data)
> +{
> + out_be32(addr, data);
> +}
> +
> +static inline u32 bc_in32(volatile u32 *addr)
> +{
> + return in_be32(addr);
> +}
> +#endif
i'm not a big fan of defaulting to an endian regardless of the host. in this
case, it appears to benefit ppc only.
what about:
#include
#if !defined(CONFIG_SYS_BOOTCOUNT_LE) && !defined(CONFIG_SYS_BOOTCOUNT_BE)
# if __BYTE_ORDER == __LITTLE_ENDIAN
# define CONFIG_SYS_BOOTCOUNT_LE
# else
# define CONFIG_SYS_BOOTCOUNT_BE
# endif
#endif
or if you're not a fan of that, then:
#if defined(CONFIG_SYS_BOOTCOUNT_LE)
... current in_le logic ...
#elif defined(CONFIG_SYS_BOOTCOUNT_BE)
... current in_be logic ...
#else
# error "please select one of CONFIG_SYS_BOOTCOUNT_{L,B}E"
#endif
and then add a default to arch/powerpc/include/asm/config.h
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mtest: Disable dcache during test
On Friday 10 August 2012 15:16:15 Benoît Thébaudeau wrote: > mtest is supposed to test many types of memory accesses in many different > conditions. If dcache is enabled, memory accesses are likely bursts, and > some memory accesses are simply skipped. Hence, dcache should be disabled > during mtest operation so that what mtest actually tests is not masked by > dcache. if you want dcache disabled, then why don't you run `dcache off` first ? i think it's useful to be able to do both, and forcing it one way is wrong. thus, NAK from me. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Why no cache flushing in do_go_exec()
On Thursday 09 August 2012 22:38:09 Charles Manning wrote: > I'm helping to work through an issue where some code is loaded into RAM this is generally where cache is supposed to be flushed. you didn't describe how exactly the code is being loaded into RAM though. > and "go xxx" is issued to then launch the code. > > Sometimes this works and sometimes it does not, which makes me suspect that > there might be a cache flushing issue. > > I looked at do_exec_go() and it does not flush caches before jumping to the > entry point. > > Is there a good reason for this or is it an oversight? the caches should generally be in sync before you get a chance to execute `go`, so the current behavior is "as designed". > Would it help to add a call to cleanup_before_linux() to do_go_exec() to > make sure the right thing is happening? you cannot assume "go" is being used to execute Linux, so that would obviously be wrong. the assumption on the list is that "go" is really only used for u- boot standalone applications. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] serial: CONSOLE macro is not used
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] arm: rmobile: Add support Renesas SH73A0
On Friday 10 August 2012 03:41:17 Nobuhiro Iwamatsu wrote: > --- a/arch/arm/cpu/armv7/rmobile/Makefile > +++ b/arch/arm/cpu/armv7/rmobile/Makefile > > +clean: > + rm -f $(SOBJS) $(OBJS) > + dead code -> delete -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] sf: stmicro: Add support for N25Q128A
On Friday 10 August 2012 08:21:46 Michal Simek wrote: > Add support for Numonyx N25Q128A SPI flash. thanks, merged into my sf branch -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Sandbox: auto exiting on pipe closure
On Thursday 09 August 2012 16:39:20 Wolfgang Denk wrote: > Mike Frysinger wrote: > > On Monday 23 April 2012 02:41:08 Wolfgang Denk wrote: > > > 2) Sandbox does no handle EOF on stadin; this makes it impossible to > > > > > >use it in test scripts. For example, something like this should > > > > > >work: > > > $ echo printenv | ./u-boot > > > > > >[As woraround I have to use ``echo 'printenv;reset' | ./u-boot''; > > >this works, but is not really intuitive nore useful.] > > > > (raw) patch below handles that. it doesn't handle this though: > > ./u-boot << > > > but maybe i'm the only one who uses that form > > -mike > > Do you intend to submit this as a proper patch? it was meant as an RFC. no one was unhappy with it, so i'll clean it up and submit like normal. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] doc/git-mailrc: Add 'rmobile' alias
On Thursday 09 August 2012 10:30:23 Nobuhiro Iwamatsu wrote: > --- a/doc/git-mailrc > +++ b/doc/git-mailrc > > alias tegra uboot, Simon Glass , Tom Warren > alias ti uboot, Tom Rini > +alias rmobileuboot, iwamatsu please keep it sorted -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] COMMON: Add __stringify() function
On Wednesday 08 August 2012 12:01:07 Marek Vasut wrote: > Dear Mike Frysinger, > > On Wednesday 08 August 2012 06:52:17 Marek Vasut wrote: > > > This function converts static number to string in preprocessor. > > > This is useful as it allows higher usage of puts() in favour of > > > printf() > > > > a few more to convert: > > include/nios2.h:#define _str_(x) #x > > include/configs/astro_mcf5373l.h:#define _QUOTEME(x)#x > > include/configs/tegra2-common.h:#define QUOTE_(m) #m > > board/logicpd/zoom2/zoom2_serial.h:#define S(a) #a > > > > not sure if we also want to clean up (in case they're copied from Linux > > -- then we'd prob just leave these headers alone, but fix any usage > > outside of the headers to use your new stringify): > > arch/mips/include/asm/mipsregs.h:#define __STR(x) #x > > arch/powerpc/include/asm/processor.h:#define tostring(s)#s > > Ok, I'll send a subsequent patch for these ... what about merging these now > tho? fine by me -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem
On Wednesday 08 August 2012 11:10:34 Lukasz Majewski wrote: > This commit makes the video subsystem code cache aware. > Memory allocated for decompressed BMP memory is now cache line aligned. > > Flushing of the dcache is also performed after copying BMP data to fb > address. i think this is a more comprehensive fix: http://patchwork.ozlabs.org/patch/164722/ although your memalign() call might be useful to integrate into Simon's change -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] COMMON: Add __stringify() function
On Wednesday 08 August 2012 06:52:17 Marek Vasut wrote: > This function converts static number to string in preprocessor. > This is useful as it allows higher usage of puts() in favour of printf() a few more to convert: include/nios2.h:#define _str_(x) #x include/configs/astro_mcf5373l.h:#define _QUOTEME(x)#x include/configs/tegra2-common.h:#define QUOTE_(m) #m board/logicpd/zoom2/zoom2_serial.h:#define S(a) #a not sure if we also want to clean up (in case they're copied from Linux -- then we'd prob just leave these headers alone, but fix any usage outside of the headers to use your new stringify): arch/mips/include/asm/mipsregs.h:#define __STR(x) #x arch/powerpc/include/asm/processor.h:#define tostring(s)#s -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] COMMON: Use __stringify() instead of xstr()
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
