Re: [U-Boot] [PATCH] armv8: ls2080aqds: fix SGMII repeater settings

[S.H. Xie]

Hi York,

Please see inline.

> -Original Message-
> From: york sun
> Sent: Tuesday, November 08, 2016 2:42 AM
> To: Prabhakar Kushwaha <prabhakar.kushw...@nxp.com>
> Cc: shh@gmail.com; u-boot@lists.denx.de; S.H. Xie <shaohui@nxp.com>
> Subject: Re: [PATCH] armv8: ls2080aqds: fix SGMII repeater settings
> 
> On 10/17/2016 01:33 AM, shh@gmail.com wrote:
> > From: Shaohui Xie <shaohui@nxp.com>
> >
> > The current value to check whether the PHY was configured has
> > dependency on MC, it expects MC to start PCS AN, this is not true
> > during boot up, so it should be changed to remove the dependency.
> >
> > The PHY's register space should be restore to default after accessing
> > extended space.
> >
> > Signed-off-by: Shaohui Xie <shaohui@nxp.com>
> > ---
> >  board/freescale/ls2080aqds/eth.c | 13 -
> >  1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/board/freescale/ls2080aqds/eth.c
> > b/board/freescale/ls2080aqds/eth.c
> > index 95ff68b..cf6791e 100644
> > --- a/board/freescale/ls2080aqds/eth.c
> > +++ b/board/freescale/ls2080aqds/eth.c
> > @@ -144,8 +144,10 @@ static void sgmii_configure_repeater(int
> > serdes_port)
> >
> > mdelay(10);
> >
> > -   if ((value & 0xfff) == 0x40f) {
> > +   if ((value & 0xfff) == 0x401) {
> > printf("DPMAC %d:PHY is . Configured\n", dpmac_id);
> > +   miiphy_write(dev[mii_bus], riser_phy_addr[dpmac],
> > +0x1f, 0);
> > continue;
> > }
> >
> > @@ -181,28 +183,29 @@ static void sgmii_configure_repeater(int serdes_port)
> > if (ret > 0)
> > goto error;
> >
> > -   mdelay(1);
> > +   mdelay(100);
> 
> Why change the delay?
[S.H] During debug I found mdelay(1) was too short for the signal to be stable, 
mdelay(10) worked but occasional still can see failure, so I changed it to 100 
to assure it.

Thank you!
Shaohui
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] armv8: ls1046aqds: add lpuart support

[S.H. Xie]

Hi York,

Thanks for reviewing!
Please see inline.

> -Original Message-
> From: york sun
> Sent: Thursday, October 27, 2016 1:19 AM
> To: shh@gmail.com; u-boot@lists.denx.de
> Cc: S.H. Xie <shaohui@nxp.com>
> Subject: Re: [PATCH 2/2] armv8: ls1046aqds: add lpuart support
> 
> On 09/26/2016 11:36 PM, shh@gmail.com wrote:
> > From: Shaohui Xie <shaohui@nxp.com>
> >
> > LPUART0 is used by default, and it's using platform clock, if a
> > different clock is preferred, user can define CONFIG_LPUART_CLK.
> 
> Shaohui,
> 
> You may have to choose another name for macro CONFIG_LPUART_CLK. We need
> to avoid using CONFIG_*. If this clock is fixed on the board, you can use 
> SYS_FSL_*
> name space.
[S.H] I can drop the CONFIG_LPUART_CLK, it's not used on the QDS, I was 
thinking about 
to help user if their board uses different clock for LPUART and they don't want 
add code 
to calculate the frequency, they can just use a define.

> 
> You can keep using CONFIG_LPUART for now, but eventually we will convert it to
> Kconfig option.
[S.H] OK.

Thanks.
Shaohui
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot