Re: [U-Boot] [PATCH] Kirkwood: Add support for OpenRD-Client OpenRD-Ultimate
- Original Message - From: Prafulla Wadaskar prafu...@marvell.com To: Julian Pidancet julian.pidan...@citrix.com, u-boot@lists.denx.de Cc: tanmay upadhyay tanmay.upadh...@einfochips.com, Prabhanjan Sarnaik sarn...@marvell.com, Ashish Karkare akark...@marvell.com Sent: Wednesday, February 9, 2011 12:16:40 PM Subject: RE: [PATCH] Kirkwood: Add support for OpenRD-Client OpenRD-Ultimate -Original Message- From: Julian Pidancet [mailto:julian.pidan...@citrix.com] Sent: Tuesday, February 08, 2011 10:21 AM To: u-boot@lists.denx.de Cc: tanmay.upadh...@einfochips.com; Prafulla Wadaskar Subject: [PATCH] Kirkwood: Add support for OpenRD-Client OpenRD- Ultimate This patch modifies existing OpenRD-Base support to deal with all the three OpenRD boards (OpenRD-Base, OpenRD-Client OpenRD-Ultimate). This is a rebase onto master from an original patch sent by Tanmay Upadhyay a few months ago. All credits goes to him. It's been tested on my OpenRD-Ultimate and works perfectly fine. Signed-off-by: Julian Pidancet julian.pidan...@citrix.com mailto:julian.pidan...@citrix.com --- MAKEALL | 2 + board/Marvell/openrd/Makefile | 56 ++ board/Marvell/openrd/config.mk | 33 ++ board/Marvell/openrd/kwbimage.cfg | 168 ++ board/Marvell/openrd/openrd.c | 173 +++ board/Marvell/openrd/openrd.h | 50 + board/Marvell/openrd_base/Makefile | 56 -- board/Marvell/openrd_base/kwbimage.cfg | 168 -- board/Marvell/openrd_base/openrd_base.c | 153 --- board/Marvell/openrd_base/openrd_base.h | 46 boards.cfg | 4 +- include/configs/openrd.h | 115 include/configs/openrd_base.h | 92 +++-- include/configs/openrd_client.h | 50 + include/configs/openrd_ultimate.h | 50 + 15 files changed, 714 insertions(+), 502 deletions(-) create mode 100644 board/Marvell/openrd/Makefile create mode 100644 board/Marvell/openrd/config.mk create mode 100644 board/Marvell/openrd/kwbimage.cfg create mode 100644 board/Marvell/openrd/openrd.c create mode 100644 board/Marvell/openrd/openrd.h delete mode 100644 board/Marvell/openrd_base/Makefile delete mode 100644 board/Marvell/openrd_base/kwbimage.cfg delete mode 100644 board/Marvell/openrd_base/openrd_base.c delete mode 100644 board/Marvell/openrd_base/openrd_base.h create mode 100644 include/configs/openrd.h create mode 100644 include/configs/openrd_client.h create mode 100644 include/configs/openrd_ultimate.h Hi Julian I suggest not to delete old file, on the other hand you can rename or move them through git. Regards... Prafulla . . Hi Prafulla, In original patch I had moved files with 'git mv' command, but the patch showed up like this. Am I missing appropriate git command? Thanks, Tanmay ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Kirkwood: Add support for OpenRD-Client OpenRD-Ultimate
- Original Message - From: Julian Pidancet julian.pidan...@citrix.com To: u-boot@lists.denx.de Cc: tanmay upadhyay tanmay.upadh...@einfochips.com, prafu...@marvell.com Sent: Tuesday, February 8, 2011 11:50:54 PM Subject: [PATCH] Kirkwood: Add support for OpenRD-Client OpenRD-Ultimate This patch modifies existing OpenRD-Base support to deal with all the three OpenRD boards (OpenRD-Base, OpenRD-Client OpenRD-Ultimate). This is a rebase onto master from an original patch sent by Tanmay Upadhyay a few months ago. All credits goes to him. It's been tested on my OpenRD-Ultimate and works perfectly fine. Signed-off-by: Julian Pidancet julian.pidan...@citrix.com Acked by: Tanmay Upadhyay tanmay.upadh...@einfochips.com --- MAKEALL |2 + board/Marvell/openrd/Makefile | 56 ++ board/Marvell/openrd/config.mk | 33 ++ board/Marvell/openrd/kwbimage.cfg | 168 ++ board/Marvell/openrd/openrd.c | 173 +++ board/Marvell/openrd/openrd.h | 50 + board/Marvell/openrd_base/Makefile | 56 -- board/Marvell/openrd_base/kwbimage.cfg | 168 -- board/Marvell/openrd_base/openrd_base.c | 153 --- board/Marvell/openrd_base/openrd_base.h | 46 boards.cfg |4 +- include/configs/openrd.h| 115 include/configs/openrd_base.h | 92 +++-- include/configs/openrd_client.h | 50 + include/configs/openrd_ultimate.h | 50 + 15 files changed, 714 insertions(+), 502 deletions(-) create mode 100644 board/Marvell/openrd/Makefile create mode 100644 board/Marvell/openrd/config.mk create mode 100644 board/Marvell/openrd/kwbimage.cfg create mode 100644 board/Marvell/openrd/openrd.c create mode 100644 board/Marvell/openrd/openrd.h delete mode 100644 board/Marvell/openrd_base/Makefile delete mode 100644 board/Marvell/openrd_base/kwbimage.cfg delete mode 100644 board/Marvell/openrd_base/openrd_base.c delete mode 100644 board/Marvell/openrd_base/openrd_base.h create mode 100644 include/configs/openrd.h create mode 100644 include/configs/openrd_client.h create mode 100644 include/configs/openrd_ultimate.h diff --git a/MAKEALL b/MAKEALL index a732e6a..4b6da98 100755 --- a/MAKEALL +++ b/MAKEALL @@ -361,6 +361,8 @@ LIST_ARM9= \ omap5912osk \ omap730p2 \ openrd_base \ + openrd_client \ + openrd_ultimate \ rd6281a \ sbc2410x\ scb9328 \ diff --git a/board/Marvell/openrd/Makefile b/board/Marvell/openrd/Makefile new file mode 100644 index 000..19020e4 --- /dev/null +++ b/board/Marvell/openrd/Makefile @@ -0,0 +1,56 @@ +# +# (C) Copyright 2009 +# Net Insight www.netinsight.net +# Written-by: Simon Kagstrom simon.kagst...@netinsight.net +# +# Based on sheevaplug: +# (C) Copyright 2009 +# Marvell Semiconductor www.marvell.com +# Written-by: Prafulla Wadaskar prafu...@marvell.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, +# MA 02110-1301 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).o + +COBJS := openrd.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB):$(obj).depend $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/Marvell/openrd/config.mk b/board/Marvell/openrd/config.mk new file mode 100644 index 000..8ae355e --- /dev/null +++ b/board/Marvell/openrd/config.mk @@ -0,0 +1,33 @@ +# +# (C) Copyright 2009 +# Net Insight www.netinsight.net +# Written-by: Simon
Re: [U-Boot] [PATCH v2] Kirkwood: bugfix: DRAM size initialization
- Original Message -
From: Prafulla Wadaskar lt;prafu...@marvell.comgt;
To: Tanmay Upadhyay lt;tanmay.upadh...@einfochips.comgt;
Cc: u-boot@lists.denx.de, g remlin lt;g_rem...@rocketmail.comgt;, Ashish
Karkare lt;akark...@marvell.comgt;, Prabhanjan Sarnaik
lt;sarn...@marvell.comgt;
Sent: Thu, 21 Oct 2010 10:27:28 +0530 (IST)
Subject: RE: [PATCH v2] Kirkwood: bugfix: DRAM size initialization
-Original Message-
From: Tanmay Upadhyay [mailto:tanmay.upadh...@einfochips.com]
Sent: Friday, October 15, 2010 5:28 PM
To: Prafulla Wadaskar
Cc: u-boot@lists.denx.de; Tanmay Upadhyay
Subject: [PATCH v2] Kirkwood: bugfix: DRAM size initialization
If start of any DRAM bank is greater than total DDR size, remaining
DDR banks' start address size were left un-initialized in dram_init
function. This could break other functions who uses array
'gd-bd-bi_dram'. Kirkwood network driver is one example. This also
stops Linux kernel from booting.
v2 - Set start address also to 0. Without this Linux kernel couldn't
boot up
Signed-off-by: Tanmay Upadhyay tanmay.upadh...@einfochips.com
---
arch/arm/cpu/arm926ejs/kirkwood/dram.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/kirkwood/dram.c
b/arch/arm/cpu/arm926ejs/kirkwood/dram.c
index 7439c87..a4344b8 100644
--- a/arch/arm/cpu/arm926ejs/kirkwood/dram.c
+++ b/arch/arm/cpu/arm926ejs/kirkwood/dram.c
@@ -81,6 +81,16 @@ int dram_init(void)
gd-ram_size += gd-bd-bi_dram[i].size;
}
+
+ for (; i CONFIG_NR_DRAM_BANKS; i++) {
+ /* If above loop terminated prematurely, we need to set
+ * remaining banks' start address size as 0.
Otherwise other
+ * u-boot functions and Linux kernel gets wrong
values which
+ * could result in crash */
+ gd-bd-bi_dram[i].start = 0;
+ gd-bd-bi_dram[i].size = 0;
+ }
+
return 0;
}
Hi Tanmay
I hope you would not mind if I apply the below patch by Gray for similar fix
http://lists.denx.de/pipermail/u-boot/2010-October/079655.html
Regards..
Prafulla . .
Hi Prafulla,
Gray's patch takes care of ram size in u-boot. But still with his patch
non-contiguous memory would be exposed -if it's there - to Linux kernel by
start and size variables of bi_dram. My patch takes care of that by zeroing
these variables. What's your opinion?
Thanks,
Tanmay
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
