Re: [U-Boot] [PATCH v3 01/12] common: bootdelay: move CONFIG_BOOTDELAY into a Kconfig option
On 07-06-16, 08:31, Heiko Schocher wrote: > move CONFIG_BOOTDELAY into a Kconfig option. Used for this > purpose the moveconfig.py tool in tools. > > Signed-off-by: Heiko Schocher > > Reviewed-by: Tom Rini > --- > > Changes in v3: > - add reviewed-by from Tom Rini and > rebase against Prepare v2016.07-rc1 as Tom suggestd: > b104b3dc1dd90cdbf67ccf3c51b06e4f1592fe91 > > Changes in v2: > - add comment from Viresh: > remove strange ifdef after deleting CONFIG_BOOTDELAY > This may change behaviour, but as the define CONFIG_SPEAR_USBTTY > is not defined in mainline code, I think, it does not break > mainlined boards. > - add comment from Tom Rini: > set default value from CONFIG_BOOTDELAY to 2 seconds. > > include/configs/spear-common.h | 6 Acked-by: Viresh Kumar -- viresh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 01/12] common: bootdelay: move CONFIG_BOOTDELAY into a Kconfig option
On 19-05-16, 07:22, Heiko Schocher wrote: > Sorry for that ... I used patman and forgot the "-m" no maintainer > option ... Hmmm... on the other side, all involved people should be > informed ... added Simon to Cc ... Simon? In fact, your message wouldn't have hit the list as well. > patman may create a big cc list, for example when moving config options > to Kconfig ... > > Makes it sense to add them all into bcc? One way is to ignore all such people and don't add them at all. Adding them in bcc will make them at least aware of this :) > At least the ones the > maintainer script finds? > Is this easy to adapt in patman? No idea. > Hmm.. a problem is may "git send-mail", as there is no "--bcc-cmd" option ... > So, all bcc addresses must be added with the "--bcc=address" option ... > > >On 18-05-16, 16:18, Heiko Schocher wrote: > >>diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h > >>index c4b6234..5e2e2b1 100644 > >>--- a/include/configs/spear-common.h > >>+++ b/include/configs/spear-common.h > >>@@ -106,9 +106,7 @@ > >> * Default Environment Varible definitions > >> */ > >> #if defined(CONFIG_SPEAR_USBTTY) > >>-#define CONFIG_BOOTDELAY -1 > >> #else > >>-#define CONFIG_BOOTDELAY 1 > >> #endif > > > >Doesn't this ifdef look strange now ? :) All I was saying is that we have this now: #if defined(CONFIG_SPEAR_USBTTY) #else #endif So, you should have removed the ifdef completely. > Indeed ... I have no such hw ... could you prepare a patch, which moves > CONFIG_SPEAR_USBTTY to Kconfig, so if this option is selected, it > set CONFIG_BOOTDELAY to -1 ? I have left that company 4 years ago and don't have any hardware for it. Over that I was never involved in uboot coding for the same :) > So, in the first step I want to remove the lines > #if defined(CONFIG_SPEAR_USBTTY) > -#define CONFIG_BOOTDELAY -1 > #else > -#define CONFIG_BOOTDELAY 1 > #endif > > in include/configs/spear-common.h complete. Just kill the complete #ifdef/endif. -- viresh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 01/12] common: bootdelay: move CONFIG_BOOTDELAY into a Kconfig option
Sorry, I had to drop the extremely long cc list, otherwise I wasn't able to reply to this email. Mutt was rejecting it for some reason. Any anyway, you should have put all those people in bcc rather. On 18-05-16, 16:18, Heiko Schocher wrote: > diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h > index c4b6234..5e2e2b1 100644 > --- a/include/configs/spear-common.h > +++ b/include/configs/spear-common.h > @@ -106,9 +106,7 @@ > * Default Environment Varible definitions > */ > #if defined(CONFIG_SPEAR_USBTTY) > -#define CONFIG_BOOTDELAY -1 > #else > -#define CONFIG_BOOTDELAY 1 > #endif Doesn't this ifdef look strange now ? :) -- viresh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/4] arm: spear: Add command to switch between 1-bit HW ECC and SW BCH4
On 02-09-15, 11:10, Stefan Roese wrote: > This patch adds the "nandecc" command to switch between the SPEAr600 internal > 1-bit HW ECC and the 4-bit SW BCH4 ECC. This can be needed to support NAND > chips with a stronger ECC than 1-bit, as on the x600. And to dynamically > switch between both ECC schemes for backwards compatibility. > > Signed-off-by: Stefan Roese > Cc: Viresh Kumar > --- > arch/arm/cpu/arm926ejs/spear/cpu.c | 34 > ++ > arch/arm/include/asm/arch-spear/spr_misc.h | 1 + > 2 files changed, 35 insertions(+) For [2-4]/4: Acked-by: Viresh Kumar -- viresh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] mtd: nand: fsmc: Add BCH4 SW ECC support for SPEAr600
On 02-09-15, 11:10, Stefan Roese wrote:
> This patch adds support for 4-bit ECC BCH4 for the SPEAr600 SoC. This can
> be used by boards equipped with a NAND chip that requires 4-bit ECC strength.
> The SPEAr600 HW ECC only supports 1-bit ECC strength.
>
> To enable SW BCH4, you need to specify this in your config header:
>
> And use the command "nandecc bch4" to select this ECC scheme upon runtime.
>
> Tested on SPEAr600 x600 board.
>
> Signed-off-by: Stefan Roese
> Cc: Scott Wood
> Cc: Viresh Kumar
> ---
> drivers/mtd/nand/fsmc_nand.c | 40
> 1 file changed, 40 insertions(+)
>
> diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c
> index 567eff0..19f5526 100644
> --- a/drivers/mtd/nand/fsmc_nand.c
> +++ b/drivers/mtd/nand/fsmc_nand.c
> @@ -13,6 +13,7 @@
> #include
> #include
> #include
> +#include
> #include
> #include
> #include
> @@ -390,6 +391,45 @@ static int fsmc_read_page_hwecc(struct mtd_info *mtd,
> struct nand_chip *chip,
> return 0;
> }
>
> +#ifndef CONFIG_SPL_BUILD
> +/*
> + * fsmc_nand_switch_ecc - switch the ECC operation between different engines
> + *
> + * @eccstrength - the number of bits that could be corrected
> + * (1 - HW, 4 - SW BCH4)
> + */
> +int __maybe_unused fsmc_nand_switch_ecc(uint32_t eccstrength)
> +{
> + struct nand_chip *nand;
> + struct mtd_info *mtd;
> + int err = 0;
You don't have to initialize it.
> +
> + mtd = &nand_info[nand_curr_device];
> + nand = mtd->priv;
> +
> + /* Setup the ecc configurations again */
> + if (eccstrength == 1) {
> + nand->ecc.mode = NAND_ECC_HW;
> + nand->ecc.bytes = 3;
> + nand->ecc.strength = 1;
> + nand->ecc.layout = &fsmc_ecc1_layout;
> + nand->ecc.correct = nand_correct_data;
> + } else {
> + nand->ecc.mode = NAND_ECC_SOFT_BCH;
> + nand->ecc.calculate = nand_bch_calculate_ecc;
> + nand->ecc.correct = nand_bch_correct_data;
> + nand->ecc.bytes = 7;
> + nand->ecc.strength = 4;
> + nand->ecc.layout = NULL;
> + }
> +
> + /* Update NAND handling after ECC mode switch */
> + err = nand_scan_tail(mtd);
> +
> + return err;
> +}
> +#endif /* CONFIG_SPL_BUILD */
> +
> int fsmc_nand_init(struct nand_chip *nand)
> {
> static int chip_nr;
Other than that:
Acked-by: Viresh Kumar
--
viresh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/5] arm: spear: Fix booting - relocate vector table to 0 (low-vector)
On 18-08-15, 09:27, Stefan Roese wrote: > Booting SPEAr600 eval board doesn't work with current mainline U-Boot. With > this patch the low-vector bit is left to '0'. Resulting in the common > relocation of the vectors to 0 (SDRAM) to work correctly. > > Tested on the SPEAr600 EVB. > > Signed-off-by: Stefan Roese > Cc: Viresh Kumar > Cc: Vipin Kumar > --- > board/spear/common/spr_lowlevel_init.S | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/board/spear/common/spr_lowlevel_init.S > b/board/spear/common/spr_lowlevel_init.S > index 23a0369..6494883 100644 > --- a/board/spear/common/spr_lowlevel_init.S > +++ b/board/spear/common/spr_lowlevel_init.S > @@ -14,11 +14,6 @@ > */ > .globl lowlevel_init > lowlevel_init: > - /* By default, U-Boot switches CPU to low-vector */ > - /* Revert this as we work in high vector even in U-Boot */ > - mrc p15, 0, r0, c1, c0, 0 > - orr r0, r0, #0x2000 > - mcr p15, 0, r0, c1, c0, 0 > mov pc, lr > > /* void setfreq(unsigned int device, unsigned int frequency) */ For the complete series: Acked-by: Viresh Kumar -- viresh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 2/2] configs: remove CONFIG_NET_MULTI
On 02-06-15, 11:25, poesc...@lemonage.de wrote: > From: Lars Poeschel > > CONFIG_NET_MULTI is not used anywhere and thus can safely be removed > from the configs. > include/configs/spear-common.h | 1 - Acked-by: Viresh Kumar -- viresh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: spear: Move to generic board support
On 3 February 2015 at 12:57, Stefan Roese wrote: > Without this change the board support for these SPEAr boards would > be dropped soon. Generic board support seems to work just fine. > > Signed-off-by: Stefan Roese > Cc: Viresh Kumar > Cc: Vipin Kumar > --- > Unfortunately I missed the merge window by one day. I totally forget to > check here. But I'm currently busy with updating U-Boot on at least > the x600 board. Including updated SPL support (which is quite outdated). > So I really would like to not have these SPEAr board dropped from > mainline for now. > > Thanks, > Stefan > > include/configs/spear-common.h | 2 ++ > include/configs/x600.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h > index a11f4ed..16281f5 100644 > --- a/include/configs/spear-common.h > +++ b/include/configs/spear-common.h > @@ -11,6 +11,8 @@ > * Common configurations used for both spear3xx as well as spear6xx > */ > > +#define CONFIG_SYS_GENERIC_BOARD > + > /* U-boot Load Address */ > #define CONFIG_SYS_TEXT_BASE 0x0070 > > diff --git a/include/configs/x600.h b/include/configs/x600.h > index 04187c0..241bf65 100644 > --- a/include/configs/x600.h > +++ b/include/configs/x600.h > @@ -16,6 +16,7 @@ > */ > #define CONFIG_SPEAR600/* SPEAr600 SoC */ > #define CONFIG_X600 /* on X600 board */ > +#define CONFIG_SYS_GENERIC_BOARD > > #include Looks fine to me.. Acked-by: Viresh Kumar ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Email address of SPEAr custodian is not working
Cc'ing Vipins new id. On Tue, Sep 16, 2014 at 12:04 AM, Masahiro Yamada wrote: > Hello Tom, Wolfgang, > > > > > > I CCed Vipin Kumar and ended up in a bounce mail. > > > The error message I got from the mail server is as follows: > > > > The original message was received at Tue, 16 Sep 2014 14:12:01 +0900 (JST) > from [157.8.1.157] > >- The following addresses had permanent fatal errors - > > (reason: 550 5.1.1 User Unknown) > > > > > > He is not only a maintainer of various SPEAr boards > but also a SPEAr SoC family custodian: > http://www.denx.de/wiki/U-Boot/Custodians > > > What should we do? > > > > Is there any candidate for the SPEAr custodian? > (This seems better if possible.) > > Or abolish u-boot-stm repository? > > > > > Best Regards > Masahiro Yamada > > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/3] EXYNOS: Add support for Exynos4x12
On 3 October 2012 11:04, Chander Kashyap wrote: >> CCing Minkyu > mk7.k...@samsung.com is also Minkyu's ID. >> Tip: Always place a blank line before/after your comments, when replying mails. That makes it much more readable to others. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] ARM ld: .bss overlaps section .rel.dyn
On Fri, Feb 3, 2012 at 10:24 AM, Albert ARIBAUD wrote: >>> On 2/1/12, Amit Virdi wrote: I'm in the process of updating platform support for spear series of SoC on the latest u-boot. I picked u-boot v2011.12. I tried compiling for different spear boards (spear 300, 310, 300 and spear600). In every compilation, I'm getting following errors: --- arm-linux-ld: section .bss [007263cc -> 00728c5b] overlaps section .rel.dyn [007263cc -> 0072a623] arm-linux-ld: u-boot: section .bss lma 0x7263cc overlaps previous sections make: *** [u-boot] Error 1 --- This is one case. > > > In fact, .bss overlapping .rel.dyn is normal -- the linker file even > explicitly states this with ".bss __rel_dyn_start (OVERLAY)". > Ok. > Which compiler do you use and which board exactly are you building? > As mentioned in the beginning of this mail, he tried compiling lot of boards, spear 300, 310, 300 and spear600. There is a internal distribution from ST we are using, STLinux. Maybe we can try some other distribution, maybe Linaro. I can't really comment if this issue is due to the distributions we are using. :( The latest by which Amit can try compiling it again is Monday. Lets see what other distribution gives. -- viresh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
