Re: [RESEND PATCH] ARM: dts: stm32: fix display pinmux for stm32f746-disco

2023-08-16 Thread Patrice CHOTARD 



On 7/3/23 18:02, Dario Binacchi wrote:
> As reported by the datasheet (DocID027590 Rev 4) for PG12:
> - AF9  -> LCD_B4
> - AF14 -> LCD_B1
> 
> So replace AF14 with AF9 for PG12 in the dts.
> 
> Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for 
> stm32f7")
> Signed-off-by: Dario Binacchi 
> 
> ---
> 
>  arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi 
> b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> index 19b5451db441..522cffb1ac9f 100644
> --- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> +++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> @@ -169,7 +169,7 @@
>   ltdc_pins: ltdc@0 {
>   pins {
>   pinmux = , /* B0 */
> -  , /* B4 */
> +  ,  /* B4 */
>, /* VSYNC */
>, /* HSYNC */
>, /* CLK */
Applied on stm32-master

Thanks
Patrice

Re: [RESEND PATCH] ARM: dts: stm32: fix display pinmux for stm32f746-disco

2023-08-16 Thread Patrice CHOTARD 



On 7/3/23 18:02, Dario Binacchi wrote:
> As reported by the datasheet (DocID027590 Rev 4) for PG12:
> - AF9  -> LCD_B4
> - AF14 -> LCD_B1
> 
> So replace AF14 with AF9 for PG12 in the dts.
> 
> Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for 
> stm32f7")
> Signed-off-by: Dario Binacchi 
> 
> ---
> 
>  arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi 
> b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> index 19b5451db441..522cffb1ac9f 100644
> --- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> +++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> @@ -169,7 +169,7 @@
>   ltdc_pins: ltdc@0 {
>   pins {
>   pinmux = , /* B0 */
> -  , /* B4 */
> +  ,  /* B4 */
>, /* VSYNC */
>, /* HSYNC */
>, /* CLK */


Reviewed-by: Patrice Chotard 

Thanks
Patrice

[RESEND PATCH] ARM: dts: stm32: fix display pinmux for stm32f746-disco

2023-07-03 Thread Dario Binacchi 
As reported by the datasheet (DocID027590 Rev 4) for PG12:
- AF9  -> LCD_B4
- AF14 -> LCD_B1

So replace AF14 with AF9 for PG12 in the dts.

Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for stm32f7")
Signed-off-by: Dario Binacchi 

---

 arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi 
b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
index 19b5451db441..522cffb1ac9f 100644
--- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
+++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
@@ -169,7 +169,7 @@
ltdc_pins: ltdc@0 {
pins {
pinmux = , /* B0 */
-, /* B4 */
+,  /* B4 */
 , /* VSYNC */
 , /* HSYNC */
 , /* CLK */
-- 
2.32.0

Re: [PATCH] ARM: dts: stm32: fix display pinmux for stm32f746-disco

2023-06-05 Thread Patrice CHOTARD 
Hi Tom

On 6/1/23 19:11, Tom Rini wrote:
> On Thu, Jun 01, 2023 at 07:06:02PM +0200, Dario Binacchi wrote:
>> As reported by the datasheet (DocID027590 Rev 4) for PG12:
>> - AF9  -> LCD_B4
>> - AF14 -> LCD_B1
>>
>> So replace AF14 with AF9 for PG12 in the dts.
>>
>> Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for 
>> stm32f7")
>> Signed-off-by: Dario Binacchi 
>>
>> ---
>>
>>  arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi 
>> b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
>> index 19b5451db441..522cffb1ac9f 100644
>> --- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
>> +++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
>> @@ -169,7 +169,7 @@
>>  ltdc_pins: ltdc@0 {
>>  pins {
>>  pinmux = , /* B0 */
>> - , /* B4 */
>> + ,  /* B4 */
>>   , /* VSYNC */
>>   , /* HSYNC */
>>   , /* CLK */
> 
> Why is this whole stanza in a -u-boot.dtsi file and not an upstream
> file?
> 

LTDC entry has been put in stm32f746-disco-u-boot.dtsi by anticipation as 
described
in commit 01aabf97d1f0 ("ARM: dts: stm32: Migrate U-boot nodes to U-boot DT 
files for stm32f7")

So U-Boot DT will be synchronized with kernel one when Dario series will be 
available in kernel release.
The LTDC entry located in stm32f746-disco-u-boot.dtsi will be then removed.

Thanks
Patrice

Re: [PATCH] ARM: dts: stm32: fix display pinmux for stm32f746-disco

2023-06-02 Thread Dario Binacchi 
On Thu, Jun 1, 2023 at 7:11 PM Tom Rini  wrote:
>
> On Thu, Jun 01, 2023 at 07:06:02PM +0200, Dario Binacchi wrote:
> > As reported by the datasheet (DocID027590 Rev 4) for PG12:
> > - AF9  -> LCD_B4
> > - AF14 -> LCD_B1
> >
> > So replace AF14 with AF9 for PG12 in the dts.
> >
> > Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for 
> > stm32f7")
> > Signed-off-by: Dario Binacchi 
> >
> > ---
> >
> >  arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi 
> > b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> > index 19b5451db441..522cffb1ac9f 100644
> > --- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> > +++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> > @@ -169,7 +169,7 @@
> >   ltdc_pins: ltdc@0 {
> >   pins {
> >   pinmux = , /* B0 */
> > -  , /* B4 */
> > +  ,  /* B4 */
> >, /* VSYNC */
> >, /* HSYNC */
> >, /* CLK */
>
> Why is this whole stanza in a -u-boot.dtsi file and not an upstream
> file?

I just submitted a series to the linux kernel to add support for
display on stm32f746-disco.
https://lore.kernel.org/linux-arm-kernel/20230601170320.2845218-1-dario.binac...@amarulasolutions.com/T/

Thanks and regards,
Dario
>
> --
> Tom



-- 

Dario Binacchi

Senior Embedded Linux Developer

dario.binac...@amarulasolutions.com

__


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
i...@amarulasolutions.com

www.amarulasolutions.com

Re: [PATCH] ARM: dts: stm32: fix display pinmux for stm32f746-disco

2023-06-01 Thread Tom Rini 
On Thu, Jun 01, 2023 at 07:06:02PM +0200, Dario Binacchi wrote:
> As reported by the datasheet (DocID027590 Rev 4) for PG12:
> - AF9  -> LCD_B4
> - AF14 -> LCD_B1
> 
> So replace AF14 with AF9 for PG12 in the dts.
> 
> Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for 
> stm32f7")
> Signed-off-by: Dario Binacchi 
> 
> ---
> 
>  arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi 
> b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> index 19b5451db441..522cffb1ac9f 100644
> --- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> +++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
> @@ -169,7 +169,7 @@
>   ltdc_pins: ltdc@0 {
>   pins {
>   pinmux = , /* B0 */
> -  , /* B4 */
> +  ,  /* B4 */
>, /* VSYNC */
>, /* HSYNC */
>, /* CLK */

Why is this whole stanza in a -u-boot.dtsi file and not an upstream
file?

-- 
Tom


signature.asc
Description: PGP signature

[PATCH] ARM: dts: stm32: fix display pinmux for stm32f746-disco

2023-06-01 Thread Dario Binacchi 
As reported by the datasheet (DocID027590 Rev 4) for PG12:
- AF9  -> LCD_B4
- AF14 -> LCD_B1

So replace AF14 with AF9 for PG12 in the dts.

Fixes: fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for stm32f7")
Signed-off-by: Dario Binacchi 

---

 arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi 
b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
index 19b5451db441..522cffb1ac9f 100644
--- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
+++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
@@ -169,7 +169,7 @@
ltdc_pins: ltdc@0 {
pins {
pinmux = , /* B0 */
-, /* B4 */
+,  /* B4 */
 , /* VSYNC */
 , /* HSYNC */
 , /* CLK */
-- 
2.32.0