Re: [PATCH] arm: apple: Disable SMBIOS again
On Sun, 24 Dec 2023 19:12:55 +0100, Mark Kettenis wrote: > Apple machines do not have memory below 4G. Since U-Boot does > not support the SMBIOS 3 header structures this means we can't > support SMBIOS on these machines. Unfortunately the refactoring > of the SMBIOS code this cycle accidentally enabled it again. > > Applied to u-boot/master, thanks! -- Tom
Re: [PATCH] arm: apple: Disable SMBIOS again
On Sun, Dec 24, 2023 at 6:12 PM Mark Kettenis wrote:
>
> Apple machines do not have memory below 4G. Since U-Boot does
> not support the SMBIOS 3 header structures this means we can't
> support SMBIOS on these machines. Unfortunately the refactoring
> of the SMBIOS code this cycle accidentally enabled it again.
>
> Fixes: 53fab13a7b1 ("efi: Use the installed SMBIOS tables")
> Signed-off-by: Mark Kettenis
> ---
> configs/apple_m1_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass
Re: [PATCH] arm: apple: Disable SMBIOS again
> Date: Sun, 24 Dec 2023 20:37:47 +0100
> From: Heinrich Schuchardt
>
> On 12/24/23 19:12, Mark Kettenis wrote:
> > Apple machines do not have memory below 4G. Since U-Boot does
> > not support the SMBIOS 3 header structures this means we can't
> > support SMBIOS on these machines. Unfortunately the refactoring
> > of the SMBIOS code this cycle accidentally enabled it again.
> >
> > Fixes: 53fab13a7b1 ("efi: Use the installed SMBIOS tables")
> > Signed-off-by: Mark Kettenis
>
> My understanding this is for origin/master. For next we have pending
> patches from Simon to move to SMBIOS 3.
Right. Without this fix EFI boot will fail on U-Boot 2024.01. And
that is 99% of the users.
When the SMBIOS 3 patches land, I intend to turn this back on again
(after making sure the tables are populated with the appropriate
information).
> Reviewed-by: Heinrich Schuchardt
>
> > ---
> > configs/apple_m1_defconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig
> > index d58a9030db..b868d0e319 100644
> > --- a/configs/apple_m1_defconfig
> > +++ b/configs/apple_m1_defconfig
> > @@ -21,5 +21,5 @@ CONFIG_USB_KEYBOARD=y
> > CONFIG_SYS_WHITE_ON_BLACK=y
> > CONFIG_NO_FB_CLEAR=y
> > CONFIG_VIDEO_SIMPLE=y
> > -# CONFIG_GENERATE_SMBIOS_TABLE is not set
> > +# CONFIG_SMBIOS is not set
> > CONFIG_LMB_MAX_REGIONS=64
>
>
Re: [PATCH] arm: apple: Disable SMBIOS again
On 12/24/23 19:12, Mark Kettenis wrote:
Apple machines do not have memory below 4G. Since U-Boot does
not support the SMBIOS 3 header structures this means we can't
support SMBIOS on these machines. Unfortunately the refactoring
of the SMBIOS code this cycle accidentally enabled it again.
Fixes: 53fab13a7b1 ("efi: Use the installed SMBIOS tables")
Signed-off-by: Mark Kettenis
My understanding this is for origin/master. For next we have pending
patches from Simon to move to SMBIOS 3.
Reviewed-by: Heinrich Schuchardt
---
configs/apple_m1_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig
index d58a9030db..b868d0e319 100644
--- a/configs/apple_m1_defconfig
+++ b/configs/apple_m1_defconfig
@@ -21,5 +21,5 @@ CONFIG_USB_KEYBOARD=y
CONFIG_SYS_WHITE_ON_BLACK=y
CONFIG_NO_FB_CLEAR=y
CONFIG_VIDEO_SIMPLE=y
-# CONFIG_GENERATE_SMBIOS_TABLE is not set
+# CONFIG_SMBIOS is not set
CONFIG_LMB_MAX_REGIONS=64
[PATCH] arm: apple: Disable SMBIOS again
Apple machines do not have memory below 4G. Since U-Boot does
not support the SMBIOS 3 header structures this means we can't
support SMBIOS on these machines. Unfortunately the refactoring
of the SMBIOS code this cycle accidentally enabled it again.
Fixes: 53fab13a7b1 ("efi: Use the installed SMBIOS tables")
Signed-off-by: Mark Kettenis
---
configs/apple_m1_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig
index d58a9030db..b868d0e319 100644
--- a/configs/apple_m1_defconfig
+++ b/configs/apple_m1_defconfig
@@ -21,5 +21,5 @@ CONFIG_USB_KEYBOARD=y
CONFIG_SYS_WHITE_ON_BLACK=y
CONFIG_NO_FB_CLEAR=y
CONFIG_VIDEO_SIMPLE=y
-# CONFIG_GENERATE_SMBIOS_TABLE is not set
+# CONFIG_SMBIOS is not set
CONFIG_LMB_MAX_REGIONS=64
--
2.43.0
