Re: [PATCH] arm: dts: ast2600: Add I2C pinctrl

2023-06-01 Thread Tom Rini 
On Wed, Jun 01, 2022 at 11:10:18AM -0500, Eddie James wrote:

> Set the pinctrl groups for each I2C bus. These are essential to
> I2C operating correctly.
> 
> Signed-off-by: Eddie James 
> Reviewed-by: Joel Stanley 
> Reviewed-by: Ryan Chen 
> ---
>  arch/arm/dts/ast2600.dtsi | 33 +
>  1 file changed, 33 insertions(+)

Sorry for the delay in getting to this patch.  I think there's a more
general issue right now of needing to get the aspeed trees synced up to
the linux kernel, and then synced back down to U-Boot.

-- 
Tom


signature.asc
Description: PGP signature

RE: [PATCH] arm: dts: ast2600: Add I2C pinctrl

2022-06-06 Thread Ryan Chen 
> -Original Message-
> From: Joel Stanley 
> Sent: Thursday, June 2, 2022 11:40 AM
> To: Eddie James 
> Cc: U-Boot Mailing List ; Dylan Hung
> ; Billy Tsai ;
> ChiaWei Wang ; Simon Glass
> 
> Subject: Re: [PATCH] arm: dts: ast2600: Add I2C pinctrl
> 
> On Wed, 1 Jun 2022 at 16:10, Eddie James  wrote:
> >
> > Set the pinctrl groups for each I2C bus. These are essential to I2C
> > operating correctly.
> >
> > Signed-off-by: Eddie James 
> 
> Reviewed-by: Joel Stanley 
> 
Reviewed-by: Ryan Chen 
> > ---
> >  arch/arm/dts/ast2600.dtsi | 33 +
> >  1 file changed, 33 insertions(+)
> >
> > diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi
> > index 64074309b7..ef5b131ac0 100644
> > --- a/arch/arm/dts/ast2600.dtsi
> > +++ b/arch/arm/dts/ast2600.dtsi
> > @@ -833,6 +833,8 @@
> > bus-frequency = <10>;
> > interrupts = ;
> > clocks = < ASPEED_CLK_APB2>;
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_i2c1_default>;
> > status = "disabled";
> > };
> >
> > @@ -846,6 +848,8 @@
> > bus-frequency = <10>;
> > interrupts = ;
> > clocks = < ASPEED_CLK_APB2>;
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_i2c2_default>;
> > status = "disabled";
> > };
> >
> > @@ -859,6 +863,8 @@
> > bus-frequency = <10>;
> > interrupts = ;
> > clocks = < ASPEED_CLK_APB2>;
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_i2c3_default>;
> > };
> >
> > i2c3: i2c@200 {
> > @@ -871,6 +877,8 @@
> > bus-frequency = <10>;
> > interrupts = ;
> > clocks = < ASPEED_CLK_APB2>;
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_i2c4_default>;
> > };
> >
> > i2c4: i2c@280 {
> > @@ -883,6 +891,8 @@
> > bus-frequency = <10>;
> > interrupts = ;
> > clocks = < ASPEED_CLK_APB2>;
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_i2c5_default>;
> > };
> >
> > i2c5: i2c@300 {
> > @@ -895,6 +905,8 @@
> > bus-frequency = <10>;
> > interrupts = ;
> > clocks = < ASPEED_CLK_APB2>;
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_i2c6_default>;
> > };
> >
> > i2c6: i2c@380 {
> > @@ -907,6 +919,8 @@
> > bus-frequency = <10>;
> > interrupts = ;
> > clocks = < ASPEED_CLK_APB2>;
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_i2c7_default>;
> > };
> >
> > i2c7: i2c@400 {
> > @@ -919,6 +933,8 @@
> > bus-frequency = <10>;
> > interrupts = ;
> > clocks = < ASPEED_CLK_APB2>;
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_i2c8_default>;
> > };
> >
> > i2c8: i2c@480 {
> > @@ -931,6 +947,8 @@
> > bus-frequency = <10>;
> > interrupts = ;
> > clocks = < ASPEED_CLK_APB2>;
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_i2c9_default>;
> > };
> >
> > i2c9: i2c@500 {
> > @@ -943,6 +961,8 @@
> > bus-frequency = <10>;
> > interrupts = ;
> > clocks = < ASPEED_CLK_APB2>;
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_i2c10_default>;
> > status = "disabled";
> > };
> >
> > @@ -956,6 +976,8 @@
> > bus-frequency = <10>;
> > interrupts = ;
> > clocks = < ASPEED_CLK_APB2>;
>

Re: [PATCH] arm: dts: ast2600: Add I2C pinctrl

2022-06-01 Thread Joel Stanley 
On Wed, 1 Jun 2022 at 16:10, Eddie James  wrote:
>
> Set the pinctrl groups for each I2C bus. These are essential to
> I2C operating correctly.
>
> Signed-off-by: Eddie James 

Reviewed-by: Joel Stanley 

Thanks Eddie.

> ---
>  arch/arm/dts/ast2600.dtsi | 33 +
>  1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi
> index 64074309b7..ef5b131ac0 100644
> --- a/arch/arm/dts/ast2600.dtsi
> +++ b/arch/arm/dts/ast2600.dtsi
> @@ -833,6 +833,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c1_default>;
> status = "disabled";
> };
>
> @@ -846,6 +848,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c2_default>;
> status = "disabled";
> };
>
> @@ -859,6 +863,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c3_default>;
> };
>
> i2c3: i2c@200 {
> @@ -871,6 +877,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c4_default>;
> };
>
> i2c4: i2c@280 {
> @@ -883,6 +891,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c5_default>;
> };
>
> i2c5: i2c@300 {
> @@ -895,6 +905,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c6_default>;
> };
>
> i2c6: i2c@380 {
> @@ -907,6 +919,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c7_default>;
> };
>
> i2c7: i2c@400 {
> @@ -919,6 +933,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c8_default>;
> };
>
> i2c8: i2c@480 {
> @@ -931,6 +947,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c9_default>;
> };
>
> i2c9: i2c@500 {
> @@ -943,6 +961,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c10_default>;
> status = "disabled";
> };
>
> @@ -956,6 +976,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c11_default>;
> status = "disabled";
> };
>
> @@ -969,6 +991,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c12_default>;
> status = "disabled";
> };
>
> @@ -982,6 +1006,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c13_default>;
> status = "disabled";
> };
>
> @@ -995,6 +1021,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c14_default>;
> status = "disabled";
> };
>
> @@ -1008,6 +1036,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_i2c15_default>;
> status = "disabled";
> };
>
> @@ -1021,6 +1051,8 @@
> bus-frequency = <10>;
> interrupts = ;
> clocks = < ASPEED_CLK_APB2>;
> +   pinctrl-names = "default";

[PATCH] arm: dts: ast2600: Add I2C pinctrl

2022-06-01 Thread Eddie James 
Set the pinctrl groups for each I2C bus. These are essential to
I2C operating correctly.

Signed-off-by: Eddie James 
---
 arch/arm/dts/ast2600.dtsi | 33 +
 1 file changed, 33 insertions(+)

diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi
index 64074309b7..ef5b131ac0 100644
--- a/arch/arm/dts/ast2600.dtsi
+++ b/arch/arm/dts/ast2600.dtsi
@@ -833,6 +833,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c1_default>;
status = "disabled";
};
 
@@ -846,6 +848,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c2_default>;
status = "disabled";
};
 
@@ -859,6 +863,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c3_default>;
};
 
i2c3: i2c@200 {
@@ -871,6 +877,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c4_default>;
};
 
i2c4: i2c@280 {
@@ -883,6 +891,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c5_default>;
};
 
i2c5: i2c@300 {
@@ -895,6 +905,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c6_default>;
};
 
i2c6: i2c@380 {
@@ -907,6 +919,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c7_default>;
};
 
i2c7: i2c@400 {
@@ -919,6 +933,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c8_default>;
};
 
i2c8: i2c@480 {
@@ -931,6 +947,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c9_default>;
};
 
i2c9: i2c@500 {
@@ -943,6 +961,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c10_default>;
status = "disabled";
};
 
@@ -956,6 +976,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c11_default>;
status = "disabled";
};
 
@@ -969,6 +991,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c12_default>;
status = "disabled";
};
 
@@ -982,6 +1006,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c13_default>;
status = "disabled";
};
 
@@ -995,6 +1021,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c14_default>;
status = "disabled";
};
 
@@ -1008,6 +1036,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c15_default>;
status = "disabled";
};
 
@@ -1021,6 +1051,8 @@
bus-frequency = <10>;
interrupts = ;
clocks = < ASPEED_CLK_APB2>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c16_default>;
status = "disabled";
};
 
@@ -1246,6 +1278,7 @@
function = "I2C1";
groups = "I2C1";
};
+
pinctrl_i2c2_default: i2c2_default {
function = "I2C2";
groups = "I2C2";
-- 
2.31.1