Re: [PATCH] arm: kirkwood: Add support for ZyXEL NSA325 board
On 8/26/23 05:33, Tony Dinh wrote:
ZyXEL NSA325 specifications:
Marvell Kirkwood 88F6282 SoC
1.6 GHz CPU
1x GBE LAN port (Marvell MV88E1318)
512 MB RAM
128 MB Eon NAND, SLC
I2C
1x USB 3.0 (on PCIe bus)
2x USB 2.0
2x SATA (hot swap slots)
Serial console
Signed-off-by: Tony Dinh
Applied to u-boot-marvell/master
Thanks,
Stefan
---
arch/arm/dts/Makefile| 1 +
arch/arm/dts/kirkwood-6282.dtsi | 161
arch/arm/dts/kirkwood-nsa325.dts | 231 +++
arch/arm/dts/kirkwood-nsa3x0-common.dtsi | 157 +++
arch/arm/mach-kirkwood/Kconfig | 7 +
board/zyxel/nsa325/Kconfig | 12 ++
board/zyxel/nsa325/MAINTAINERS | 9 +
board/zyxel/nsa325/Makefile | 11 ++
board/zyxel/nsa325/kwbimage.cfg | 55 ++
board/zyxel/nsa325/nsa325.c | 196 +++
configs/nsa325_defconfig | 81
include/configs/nsa325.h | 37
12 files changed, 958 insertions(+)
create mode 100644 arch/arm/dts/kirkwood-6282.dtsi
create mode 100644 arch/arm/dts/kirkwood-nsa325.dts
create mode 100644 arch/arm/dts/kirkwood-nsa3x0-common.dtsi
create mode 100644 board/zyxel/nsa325/Kconfig
create mode 100644 board/zyxel/nsa325/MAINTAINERS
create mode 100644 board/zyxel/nsa325/Makefile
create mode 100644 board/zyxel/nsa325/kwbimage.cfg
create mode 100644 board/zyxel/nsa325/nsa325.c
create mode 100644 configs/nsa325_defconfig
create mode 100644 include/configs/nsa325.h
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 85fd5b1157..b9fc46544f 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -66,6 +66,7 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += \
kirkwood-ns2max.dtb \
kirkwood-ns2mini.dtb \
kirkwood-nsa310s.dtb \
+ kirkwood-nsa325.dtb \
kirkwood-openrd-base.dtb \
kirkwood-openrd-client.dtb \
kirkwood-openrd-ultimate.dtb \
diff --git a/arch/arm/dts/kirkwood-6282.dtsi b/arch/arm/dts/kirkwood-6282.dtsi
new file mode 100644
index 00..e732c501ea
--- /dev/null
+++ b/arch/arm/dts/kirkwood-6282.dtsi
@@ -0,0 +1,161 @@
+// SPDX-License-Identifier: GPL-2.0
+/ {
+ mbus@f100 {
+ pciec: pcie@8200 {
+ compatible = "marvell,kirkwood-pcie";
+ status = "disabled";
+ device_type = "pci";
+
+ #address-cells = <3>;
+ #size-cells = <2>;
+
+ bus-range = <0x00 0xff>;
+
+ ranges =
+ <0x8200 0 0x4 MBUS_ID(0xf0, 0x01)
0x4 0 0x2000
+ 0x8200 0 0x44000 MBUS_ID(0xf0, 0x01)
0x44000 0 0x2000
+ 0x8200 0 0x8 MBUS_ID(0xf0, 0x01)
0x8 0 0x2000
+ 0x8200 0x1 0 MBUS_ID(0x04, 0xe8) 0
1 0 /* Port 0.0 MEM */
+ 0x8100 0x1 0 MBUS_ID(0x04, 0xe0) 0
1 0 /* Port 0.0 IO */
+ 0x8200 0x2 0 MBUS_ID(0x04, 0xd8) 0
1 0 /* Port 1.0 MEM */
+ 0x8100 0x2 0 MBUS_ID(0x04, 0xd0) 0 1
0 /* Port 1.0 IO */>;
+
+ pcie0: pcie@1,0 {
+ device_type = "pci";
+ assigned-addresses = <0x82000800 0 0x0004 0
0x2000>;
+ reg = <0x0800 0 0 0 0>;
+ #address-cells = <3>;
+ #size-cells = <2>;
+ #interrupt-cells = <1>;
+ ranges = <0x8200 0 0 0x8200 0x1 0 1 0
+ 0x8100 0 0 0x8100 0x1 0 1 0>;
+ bus-range = <0x00 0xff>;
+ interrupt-names = "intx", "error";
+ interrupts = <9>, <44>;
+ interrupt-map-mask = <0 0 0 7>;
+ interrupt-map = <0 0 0 1 _intc 0>,
+ <0 0 0 2 _intc 1>,
+ <0 0 0 3 _intc 2>,
+ <0 0 0 4 _intc 3>;
+ marvell,pcie-port = <0>;
+ marvell,pcie-lane = <0>;
+ clocks = <_clk 2>;
+ status = "disabled";
+
+ pcie0_intc: interrupt-controller {
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ };
+ };
+
+ pcie1: pcie@2,0 {
+
Re: [PATCH] arm: kirkwood: Add support for ZyXEL NSA325 board
Hi Stefan,
For unknown reasons (probably Gmail glitches), I did not receive your
email review in this thread. But I did receive the other email review
for the Pogo V4 LTO! lore.kernel.org is OK.
https://lore.kernel.org/u-boot/65ab8aa6-c290-0649-0b2e-374c4f84e...@denx.de/T/#mf17689e3e963ab7a34fda34a97f67dea7a877b65
Stefan: "Just checking: Are the DT files imported from the Linux ones?"
Yes, these DT files were copied verbatim from Linux. That's why we see
some minor warnings about styles.
All the best,
Tony
On Fri, Aug 25, 2023 at 8:33 PM Tony Dinh wrote:
>
> ZyXEL NSA325 specifications:
>
> Marvell Kirkwood 88F6282 SoC
> 1.6 GHz CPU
> 1x GBE LAN port (Marvell MV88E1318)
> 512 MB RAM
> 128 MB Eon NAND, SLC
> I2C
> 1x USB 3.0 (on PCIe bus)
> 2x USB 2.0
> 2x SATA (hot swap slots)
> Serial console
>
> Signed-off-by: Tony Dinh
> ---
>
> arch/arm/dts/Makefile| 1 +
> arch/arm/dts/kirkwood-6282.dtsi | 161
> arch/arm/dts/kirkwood-nsa325.dts | 231 +++
> arch/arm/dts/kirkwood-nsa3x0-common.dtsi | 157 +++
> arch/arm/mach-kirkwood/Kconfig | 7 +
> board/zyxel/nsa325/Kconfig | 12 ++
> board/zyxel/nsa325/MAINTAINERS | 9 +
> board/zyxel/nsa325/Makefile | 11 ++
> board/zyxel/nsa325/kwbimage.cfg | 55 ++
> board/zyxel/nsa325/nsa325.c | 196 +++
> configs/nsa325_defconfig | 81
> include/configs/nsa325.h | 37
> 12 files changed, 958 insertions(+)
> create mode 100644 arch/arm/dts/kirkwood-6282.dtsi
> create mode 100644 arch/arm/dts/kirkwood-nsa325.dts
> create mode 100644 arch/arm/dts/kirkwood-nsa3x0-common.dtsi
> create mode 100644 board/zyxel/nsa325/Kconfig
> create mode 100644 board/zyxel/nsa325/MAINTAINERS
> create mode 100644 board/zyxel/nsa325/Makefile
> create mode 100644 board/zyxel/nsa325/kwbimage.cfg
> create mode 100644 board/zyxel/nsa325/nsa325.c
> create mode 100644 configs/nsa325_defconfig
> create mode 100644 include/configs/nsa325.h
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 85fd5b1157..b9fc46544f 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -66,6 +66,7 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += \
> kirkwood-ns2max.dtb \
> kirkwood-ns2mini.dtb \
> kirkwood-nsa310s.dtb \
> + kirkwood-nsa325.dtb \
> kirkwood-openrd-base.dtb \
> kirkwood-openrd-client.dtb \
> kirkwood-openrd-ultimate.dtb \
> diff --git a/arch/arm/dts/kirkwood-6282.dtsi b/arch/arm/dts/kirkwood-6282.dtsi
> new file mode 100644
> index 00..e732c501ea
> --- /dev/null
> +++ b/arch/arm/dts/kirkwood-6282.dtsi
> @@ -0,0 +1,161 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/ {
> + mbus@f100 {
> + pciec: pcie@8200 {
> + compatible = "marvell,kirkwood-pcie";
> + status = "disabled";
> + device_type = "pci";
> +
> + #address-cells = <3>;
> + #size-cells = <2>;
> +
> + bus-range = <0x00 0xff>;
> +
> + ranges =
> + <0x8200 0 0x4 MBUS_ID(0xf0, 0x01)
> 0x4 0 0x2000
> + 0x8200 0 0x44000 MBUS_ID(0xf0, 0x01)
> 0x44000 0 0x2000
> + 0x8200 0 0x8 MBUS_ID(0xf0, 0x01)
> 0x8 0 0x2000
> + 0x8200 0x1 0 MBUS_ID(0x04, 0xe8) 0
>1 0 /* Port 0.0 MEM */
> + 0x8100 0x1 0 MBUS_ID(0x04, 0xe0) 0
>1 0 /* Port 0.0 IO */
> + 0x8200 0x2 0 MBUS_ID(0x04, 0xd8) 0
>1 0 /* Port 1.0 MEM */
> + 0x8100 0x2 0 MBUS_ID(0x04, 0xd0) 0
>1 0 /* Port 1.0 IO */>;
> +
> + pcie0: pcie@1,0 {
> + device_type = "pci";
> + assigned-addresses = <0x82000800 0 0x0004
> 0 0x2000>;
> + reg = <0x0800 0 0 0 0>;
> + #address-cells = <3>;
> + #size-cells = <2>;
> + #interrupt-cells = <1>;
> + ranges = <0x8200 0 0 0x8200 0x1 0 1 0
> + 0x8100 0 0 0x8100 0x1 0 1
> 0>;
> + bus-range = <0x00 0xff>;
> + interrupt-names = "intx", "error";
> + interrupts = <9>, <44>;
> + interrupt-map-mask = <0 0 0 7>;
> + interrupt-map = <0 0 0 1 _intc 0>,
> + <0 0 0 2 _intc 1>,
> +
Re: [PATCH] arm: kirkwood: Add support for ZyXEL NSA325 board
On 8/26/23 05:33, Tony Dinh wrote:
ZyXEL NSA325 specifications:
Marvell Kirkwood 88F6282 SoC
1.6 GHz CPU
1x GBE LAN port (Marvell MV88E1318)
512 MB RAM
128 MB Eon NAND, SLC
I2C
1x USB 3.0 (on PCIe bus)
2x USB 2.0
2x SATA (hot swap slots)
Serial console
Signed-off-by: Tony Dinh
---
arch/arm/dts/Makefile| 1 +
arch/arm/dts/kirkwood-6282.dtsi | 161
arch/arm/dts/kirkwood-nsa325.dts | 231 +++
arch/arm/dts/kirkwood-nsa3x0-common.dtsi | 157 +++
Just checking: Are the DT files imported from the Linux ones?
Other than this:
Reviewed-by: Stefan Roese
Thanks,
Stefan
arch/arm/mach-kirkwood/Kconfig | 7 +
board/zyxel/nsa325/Kconfig | 12 ++
board/zyxel/nsa325/MAINTAINERS | 9 +
board/zyxel/nsa325/Makefile | 11 ++
board/zyxel/nsa325/kwbimage.cfg | 55 ++
board/zyxel/nsa325/nsa325.c | 196 +++
configs/nsa325_defconfig | 81
include/configs/nsa325.h | 37
12 files changed, 958 insertions(+)
create mode 100644 arch/arm/dts/kirkwood-6282.dtsi
create mode 100644 arch/arm/dts/kirkwood-nsa325.dts
create mode 100644 arch/arm/dts/kirkwood-nsa3x0-common.dtsi
create mode 100644 board/zyxel/nsa325/Kconfig
create mode 100644 board/zyxel/nsa325/MAINTAINERS
create mode 100644 board/zyxel/nsa325/Makefile
create mode 100644 board/zyxel/nsa325/kwbimage.cfg
create mode 100644 board/zyxel/nsa325/nsa325.c
create mode 100644 configs/nsa325_defconfig
create mode 100644 include/configs/nsa325.h
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 85fd5b1157..b9fc46544f 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -66,6 +66,7 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += \
kirkwood-ns2max.dtb \
kirkwood-ns2mini.dtb \
kirkwood-nsa310s.dtb \
+ kirkwood-nsa325.dtb \
kirkwood-openrd-base.dtb \
kirkwood-openrd-client.dtb \
kirkwood-openrd-ultimate.dtb \
diff --git a/arch/arm/dts/kirkwood-6282.dtsi b/arch/arm/dts/kirkwood-6282.dtsi
new file mode 100644
index 00..e732c501ea
--- /dev/null
+++ b/arch/arm/dts/kirkwood-6282.dtsi
@@ -0,0 +1,161 @@
+// SPDX-License-Identifier: GPL-2.0
+/ {
+ mbus@f100 {
+ pciec: pcie@8200 {
+ compatible = "marvell,kirkwood-pcie";
+ status = "disabled";
+ device_type = "pci";
+
+ #address-cells = <3>;
+ #size-cells = <2>;
+
+ bus-range = <0x00 0xff>;
+
+ ranges =
+ <0x8200 0 0x4 MBUS_ID(0xf0, 0x01)
0x4 0 0x2000
+ 0x8200 0 0x44000 MBUS_ID(0xf0, 0x01)
0x44000 0 0x2000
+ 0x8200 0 0x8 MBUS_ID(0xf0, 0x01)
0x8 0 0x2000
+ 0x8200 0x1 0 MBUS_ID(0x04, 0xe8) 0
1 0 /* Port 0.0 MEM */
+ 0x8100 0x1 0 MBUS_ID(0x04, 0xe0) 0
1 0 /* Port 0.0 IO */
+ 0x8200 0x2 0 MBUS_ID(0x04, 0xd8) 0
1 0 /* Port 1.0 MEM */
+ 0x8100 0x2 0 MBUS_ID(0x04, 0xd0) 0 1
0 /* Port 1.0 IO */>;
+
+ pcie0: pcie@1,0 {
+ device_type = "pci";
+ assigned-addresses = <0x82000800 0 0x0004 0
0x2000>;
+ reg = <0x0800 0 0 0 0>;
+ #address-cells = <3>;
+ #size-cells = <2>;
+ #interrupt-cells = <1>;
+ ranges = <0x8200 0 0 0x8200 0x1 0 1 0
+ 0x8100 0 0 0x8100 0x1 0 1 0>;
+ bus-range = <0x00 0xff>;
+ interrupt-names = "intx", "error";
+ interrupts = <9>, <44>;
+ interrupt-map-mask = <0 0 0 7>;
+ interrupt-map = <0 0 0 1 _intc 0>,
+ <0 0 0 2 _intc 1>,
+ <0 0 0 3 _intc 2>,
+ <0 0 0 4 _intc 3>;
+ marvell,pcie-port = <0>;
+ marvell,pcie-lane = <0>;
+ clocks = <_clk 2>;
+ status = "disabled";
+
+ pcie0_intc: interrupt-controller {
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ };
+ };
+
+
[PATCH] arm: kirkwood: Add support for ZyXEL NSA325 board
ZyXEL NSA325 specifications:
Marvell Kirkwood 88F6282 SoC
1.6 GHz CPU
1x GBE LAN port (Marvell MV88E1318)
512 MB RAM
128 MB Eon NAND, SLC
I2C
1x USB 3.0 (on PCIe bus)
2x USB 2.0
2x SATA (hot swap slots)
Serial console
Signed-off-by: Tony Dinh
---
arch/arm/dts/Makefile| 1 +
arch/arm/dts/kirkwood-6282.dtsi | 161
arch/arm/dts/kirkwood-nsa325.dts | 231 +++
arch/arm/dts/kirkwood-nsa3x0-common.dtsi | 157 +++
arch/arm/mach-kirkwood/Kconfig | 7 +
board/zyxel/nsa325/Kconfig | 12 ++
board/zyxel/nsa325/MAINTAINERS | 9 +
board/zyxel/nsa325/Makefile | 11 ++
board/zyxel/nsa325/kwbimage.cfg | 55 ++
board/zyxel/nsa325/nsa325.c | 196 +++
configs/nsa325_defconfig | 81
include/configs/nsa325.h | 37
12 files changed, 958 insertions(+)
create mode 100644 arch/arm/dts/kirkwood-6282.dtsi
create mode 100644 arch/arm/dts/kirkwood-nsa325.dts
create mode 100644 arch/arm/dts/kirkwood-nsa3x0-common.dtsi
create mode 100644 board/zyxel/nsa325/Kconfig
create mode 100644 board/zyxel/nsa325/MAINTAINERS
create mode 100644 board/zyxel/nsa325/Makefile
create mode 100644 board/zyxel/nsa325/kwbimage.cfg
create mode 100644 board/zyxel/nsa325/nsa325.c
create mode 100644 configs/nsa325_defconfig
create mode 100644 include/configs/nsa325.h
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 85fd5b1157..b9fc46544f 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -66,6 +66,7 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += \
kirkwood-ns2max.dtb \
kirkwood-ns2mini.dtb \
kirkwood-nsa310s.dtb \
+ kirkwood-nsa325.dtb \
kirkwood-openrd-base.dtb \
kirkwood-openrd-client.dtb \
kirkwood-openrd-ultimate.dtb \
diff --git a/arch/arm/dts/kirkwood-6282.dtsi b/arch/arm/dts/kirkwood-6282.dtsi
new file mode 100644
index 00..e732c501ea
--- /dev/null
+++ b/arch/arm/dts/kirkwood-6282.dtsi
@@ -0,0 +1,161 @@
+// SPDX-License-Identifier: GPL-2.0
+/ {
+ mbus@f100 {
+ pciec: pcie@8200 {
+ compatible = "marvell,kirkwood-pcie";
+ status = "disabled";
+ device_type = "pci";
+
+ #address-cells = <3>;
+ #size-cells = <2>;
+
+ bus-range = <0x00 0xff>;
+
+ ranges =
+ <0x8200 0 0x4 MBUS_ID(0xf0, 0x01)
0x4 0 0x2000
+ 0x8200 0 0x44000 MBUS_ID(0xf0, 0x01)
0x44000 0 0x2000
+ 0x8200 0 0x8 MBUS_ID(0xf0, 0x01)
0x8 0 0x2000
+ 0x8200 0x1 0 MBUS_ID(0x04, 0xe8) 0
1 0 /* Port 0.0 MEM */
+ 0x8100 0x1 0 MBUS_ID(0x04, 0xe0) 0
1 0 /* Port 0.0 IO */
+ 0x8200 0x2 0 MBUS_ID(0x04, 0xd8) 0
1 0 /* Port 1.0 MEM */
+ 0x8100 0x2 0 MBUS_ID(0x04, 0xd0) 0
1 0 /* Port 1.0 IO */>;
+
+ pcie0: pcie@1,0 {
+ device_type = "pci";
+ assigned-addresses = <0x82000800 0 0x0004 0
0x2000>;
+ reg = <0x0800 0 0 0 0>;
+ #address-cells = <3>;
+ #size-cells = <2>;
+ #interrupt-cells = <1>;
+ ranges = <0x8200 0 0 0x8200 0x1 0 1 0
+ 0x8100 0 0 0x8100 0x1 0 1 0>;
+ bus-range = <0x00 0xff>;
+ interrupt-names = "intx", "error";
+ interrupts = <9>, <44>;
+ interrupt-map-mask = <0 0 0 7>;
+ interrupt-map = <0 0 0 1 _intc 0>,
+ <0 0 0 2 _intc 1>,
+ <0 0 0 3 _intc 2>,
+ <0 0 0 4 _intc 3>;
+ marvell,pcie-port = <0>;
+ marvell,pcie-lane = <0>;
+ clocks = <_clk 2>;
+ status = "disabled";
+
+ pcie0_intc: interrupt-controller {
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ };
+ };
+
+ pcie1: pcie@2,0 {
+ device_type = "pci";
+ assigned-addresses = <0x82001000 0 0x00044000 0
0x2000>;
+
