Re: [PATCH] board: phytec: fix link error when disabling PHYTEC_SOM_DETECTION

[Yannic Moog]

Hi Fabio

On Fri, 2024-01-12 at 14:55 -0300, Fabio Estevam wrote:
> Hi Yannic,
> 
> On Thu, Jan 11, 2024 at 5:27 AM Yannic Moog  wrote:
> > 
> > Commit aa7858fe5e2e ("board: phytec: som_detection: move definitions to
> > source file") moved function definitions from header to source file.
> > Makefile however was not updated to unconditionally build the imx8 and
> > phytec som detection units. Fix this.
> > 
> > Fixes: aa7858fe5e2e ("board: phytec: som_detection: move definitions to 
> > source file")
> > Signed-off-by: Yannic Moog 
> 
> This causes build failure:
> 
> https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/769421

Thank you, I will send an updated version.

Re: [PATCH] board: phytec: fix link error when disabling PHYTEC_SOM_DETECTION

[Fabio Estevam]

Hi Yannic,

On Thu, Jan 11, 2024 at 5:27 AM Yannic Moog  wrote:
>
> Commit aa7858fe5e2e ("board: phytec: som_detection: move definitions to
> source file") moved function definitions from header to source file.
> Makefile however was not updated to unconditionally build the imx8 and
> phytec som detection units. Fix this.
>
> Fixes: aa7858fe5e2e ("board: phytec: som_detection: move definitions to 
> source file")
> Signed-off-by: Yannic Moog 

This causes build failure:

https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/769421

[PATCH] board: phytec: fix link error when disabling PHYTEC_SOM_DETECTION

[Yannic Moog]

Commit aa7858fe5e2e ("board: phytec: som_detection: move definitions to
source file") moved function definitions from header to source file.
Makefile however was not updated to unconditionally build the imx8 and
phytec som detection units. Fix this.

Fixes: aa7858fe5e2e ("board: phytec: som_detection: move definitions to source 
file")
Signed-off-by: Yannic Moog 
---
 board/phytec/common/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/phytec/common/Makefile b/board/phytec/common/Makefile
index fe28964ce21..5f8e8435413 100644
--- a/board/phytec/common/Makefile
+++ b/board/phytec/common/Makefile
@@ -7,5 +7,4 @@ ifdef CONFIG_SPL_BUILD
 obj- := __dummy__.o
 endif
 
-obj-$(CONFIG_PHYTEC_SOM_DETECTION) += phytec_som_detection.o
-obj-$(CONFIG_PHYTEC_IMX8M_SOM_DETECTION) += imx8m_som_detection.o
+obj-y += phytec_som_detection.o imx8m_som_detection.o

---
base-commit: 7a59d520ef0bfd29b339cba5282149271d5ac3b2
change-id: 20240111-wip-y-moog-phytec-de-som-detection-fixup-5cade747a48a

Best regards,
-- 
Yannic Moog