Re: [PATCH] board: stm32mp1: add splash screen on dk2

[Grzegorz Szymaszek]

On Tue, Jul 04, 2023 at 11:14:39AM +0200, Dario Binacchi wrote:
> On Tue, Jul 4, 2023 at 10:11 AM Grzegorz Szymaszek  
> wrote:
> > > + ulong logo =
> > > + (ulong)stmicroelectronics_uboot_logo_8bit_rle;
> > > + bmp_display(logo, BMP_ALIGN_CENTER, BMP_ALIGN_CENTER);
> > 
> > Technically logo is const.
> 
> int bmp_display(ulong addr, int x, int y);
> And throughout the code, I only find ulong parameters being passed to
> this function.
> Perhaps I can replace "logo" with "addr".

I'm afraid my comment was perhaps too terse: I wanted to point out that
your "ulong logo" variable is assigned to only once, its value is never
changed, so instead of plain "ulong", you could declare its type as
"const ulong". I won't insist on this change since the code is trivial.

Consider simply removing the new variable and just passing
"(ulong)stmicroelectronics_uboot_logo_8bit_rle" directly as the
bmp_display()'s argument, like in
board/st/stm32f746-disco/stm32f746-disco.c.


signature.asc
Description: PGP signature

Re: [PATCH] board: stm32mp1: add splash screen on dk2

[Dario Binacchi]

Hi all,

On Tue, Jul 4, 2023 at 10:11 AM Grzegorz Szymaszek  wrote:
>
> Hi,
>
> On Mon, Jul 03, 2023 at 06:27:54PM +0200, Dario Binacchi wrote:
> > diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
> > -%<-
> >  #include 
> > +#include 
> > +#include 
> >  #include 
>
> These two should be put above syscon.h if you want to keep the includes
> sorted alphabetically.

yes, you are right. I will update in v2

>
> > + ulong logo =
> > + (ulong)stmicroelectronics_uboot_logo_8bit_rle;
> > + bmp_display(logo, BMP_ALIGN_CENTER, BMP_ALIGN_CENTER);
>
> Technically logo is const.

int bmp_display(ulong addr, int x, int y);
And throughout the code, I only find ulong parameters being passed to
this function.
Perhaps I can replace "logo" with "addr".

Thanks and regards,
Dario

>
>
> All the best
>
> --
> Grzegorz



-- 

Dario Binacchi

Senior Embedded Linux Developer

dario.binac...@amarulasolutions.com

__


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
i...@amarulasolutions.com

www.amarulasolutions.com

Re: [PATCH] board: stm32mp1: add splash screen on dk2

[Grzegorz Szymaszek]

Hi,

On Mon, Jul 03, 2023 at 06:27:54PM +0200, Dario Binacchi wrote:
> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
> -%<-
>  #include 
> +#include 
> +#include 
>  #include 

These two should be put above syscon.h if you want to keep the includes
sorted alphabetically.

> + ulong logo =
> + (ulong)stmicroelectronics_uboot_logo_8bit_rle;
> + bmp_display(logo, BMP_ALIGN_CENTER, BMP_ALIGN_CENTER);

Technically logo is const.


All the best

-- 
Grzegorz


signature.asc
Description: PGP signature

[PATCH] board: stm32mp1: add splash screen on dk2

[Dario Binacchi]

Display the STMicroelectronics logo.

Signed-off-by: Dario Binacchi 
---

 board/st/stm32mp1/stm32mp1.c | 12 
 1 file changed, 12 insertions(+)

diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
index 1a1b1844c8c0..c8c2a83b2acf 100644
--- a/board/st/stm32mp1/stm32mp1.c
+++ b/board/st/stm32mp1/stm32mp1.c
@@ -32,7 +32,10 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -684,6 +687,15 @@ int board_init(void)
fw_images[0].fw_name = u"STM32MP-FIP";
fw_images[0].image_index = 1;
 #endif
+
+   if (IS_ENABLED(CONFIG_CMD_BMP)) {
+   if (board_is_stm32mp15x_dk2()) {
+   ulong logo =
+   (ulong)stmicroelectronics_uboot_logo_8bit_rle;
+   bmp_display(logo, BMP_ALIGN_CENTER, BMP_ALIGN_CENTER);
+   }
+   }
+
return 0;
 }
 
-- 
2.32.0