Re: [PATCH] clk: at91: Fix initializing arrays

2023-09-29 Thread Eugen Hristev

On 9/24/23 12:58, Francois Berder wrote:

Arrays are not cleared entirely because ARRAY_SIZE
returns the number of elements in an array, not the size
in bytes.
This commit fixes the calls to memset by providing the
array size in bytes instead of the number of elements
in the array.

Signed-off-by: Francois Berder 
---


Applied to u-boot-at91/ master, thanks !



[PATCH] clk: at91: Fix initializing arrays

2023-09-24 Thread Francois Berder
Arrays are not cleared entirely because ARRAY_SIZE
returns the number of elements in an array, not the size
in bytes.
This commit fixes the calls to memset by providing the
array size in bytes instead of the number of elements
in the array.

Signed-off-by: Francois Berder 
---
 drivers/clk/at91/sam9x60.c | 4 ++--
 drivers/clk/at91/sama7g5.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
index e2f72446d5..d858c860f6 100644
--- a/drivers/clk/at91/sam9x60.c
+++ b/drivers/clk/at91/sam9x60.c
@@ -429,8 +429,8 @@ static int sam9x60_clk_probe(struct udevice *dev)
if (!base)
return -EINVAL;
 
-   memset(muxallocs,0, ARRAY_SIZE(muxallocs));
-   memset(clkmuxallocs, 0, ARRAY_SIZE(clkmuxallocs));
+   memset(muxallocs,0, sizeof(muxallocs));
+   memset(clkmuxallocs, 0, sizeof(clkmuxallocs));
 
ret = clk_get_by_index(dev, 0, &clk);
if (ret)
diff --git a/drivers/clk/at91/sama7g5.c b/drivers/clk/at91/sama7g5.c
index 3abd220803..3e62fb1f58 100644
--- a/drivers/clk/at91/sama7g5.c
+++ b/drivers/clk/at91/sama7g5.c
@@ -1115,8 +1115,8 @@ static int sama7g5_clk_probe(struct udevice *dev)
if (IS_ERR(base))
return PTR_ERR(base);
 
-   memset(muxallocs,0, ARRAY_SIZE(muxallocs));
-   memset(clkmuxallocs, 0, ARRAY_SIZE(clkmuxallocs));
+   memset(muxallocs,0, sizeof(muxallocs));
+   memset(clkmuxallocs, 0, sizeof(clkmuxallocs));
 
ret = clk_get_by_index(dev, 0, &clk);
if (ret)
-- 
2.34.1