Re: [PATCH] cmd: irq: disable CMD_IRQ for riscv arch

[Bin Meng]

On Mon, Aug 24, 2020 at 11:09 PM Pragnesh Patel
 wrote:
>
> For RISC-V arch, no need for CMD_IRQ so disable the same.
>
> Signed-off-by: Pragnesh Patel 
> ---
>  cmd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng 

Re: [PATCH] cmd: irq: disable CMD_IRQ for riscv arch

[Rick Chen]

> From: Pragnesh Patel [mailto:pragnesh.pa...@sifive.com]
> Sent: Monday, August 24, 2020 11:09 PM
> To: u-boot@lists.denx.de; atish.pa...@wdc.com; bmeng...@gmail.com; 
> anup.pa...@wdc.com; sagar.ka...@sifive.com; Rick Jian-Zhi Chen(陳建志)
> Cc: paul.walms...@sifive.com; Pragnesh Patel; Simon Glass; Heinrich 
> Schuchardt; Sam Protsenko; Miquel Raynal; Patrick Delaunay; Ramon Fried; Joel 
> Johnson; AKASHI Takahiro
> Subject: [PATCH] cmd: irq: disable CMD_IRQ for riscv arch
>
> For RISC-V arch, no need for CMD_IRQ so disable the same.
>
> Signed-off-by: Pragnesh Patel 
> ---
>  cmd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Rick Chen 

Re: [PATCH] cmd: irq: disable CMD_IRQ for riscv arch

[Heinrich Schuchardt]

On 24.08.20 17:08, Pragnesh Patel wrote:
> For RISC-V arch, no need for CMD_IRQ so disable the same.
>
> Signed-off-by: Pragnesh Patel 

This avoids possible misconfiguration leading to

riscv64-linux-gnu-ld.bfd:
cmd/built-in.o:(.u_boot_list_2_cmd_2_irqinfo+0x18):
undefined reference to `do_irqinfo'
make: *** [Makefile:1753: u-boot] Error 1

Reviewed-by: Heinrich Schuchardt 

> ---
>  cmd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 9ad511aa17..9709666261 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -2217,7 +2217,7 @@ config CMD_DIAG
>
>  config CMD_IRQ
>   bool "irq - Show information about interrupts"
> - depends on !ARM && !MIPS && !SH
> + depends on !ARM && !MIPS && !RISCV && !SH
>   help
> This enables two commands:
>
>

[PATCH] cmd: irq: disable CMD_IRQ for riscv arch

[Pragnesh Patel]

For RISC-V arch, no need for CMD_IRQ so disable the same.

Signed-off-by: Pragnesh Patel 
---
 cmd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 9ad511aa17..9709666261 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -2217,7 +2217,7 @@ config CMD_DIAG
 
 config CMD_IRQ
bool "irq - Show information about interrupts"
-   depends on !ARM && !MIPS && !SH
+   depends on !ARM && !MIPS && !RISCV && !SH
help
  This enables two commands:
 
-- 
2.17.1