Re: [PATCH] configs: Increase malloc size after relocation
Hi Vignesh, On 11/01/23 14:55, Vignesh Raghavendra wrote: On 11/01/23 11:34, Neha Malcom Francis wrote: Current default size of 0x10 is not capable of getting the FIT buffer during boot when transitioning to using binman generated boot images for certain K3 devices, so increase it to 0x40. Since A72 SPL is coming after relocation to DDR this should not be an issue for any K3 device, so make it default for all. Signed-off-by: Neha Malcom Francis --- common/spl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index a25d8fd2e0..d8c78ddb76 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -385,6 +385,7 @@ config SPL_STACK_R_ADDR config SPL_STACK_R_MALLOC_SIMPLE_LEN depends on SPL_STACK_R && SPL_SYS_MALLOC_SIMPLE hex "Size of malloc_simple heap after switching to DRAM SPL stack" + default 0x40 if ARCH_K3 Wont this take affect for both R5 SPL and A72 SPL as ARCH_K3 = y in both cases? J721E and J7200 did not have SPL_SYS_MALLOC_SIMPLE set in R5 and that misled me into believing it was the same for other K3 devices as well, which it is not. You're right, it will take effect for A72 SPL, I will change it to only if it is both ARCH_K3 and ARM64 default 0x10 help Specify the amount of the stack to use as memory pool for -- Thanking You Neha Malcom Francis
Re: [PATCH] configs: Increase malloc size after relocation
On 11/01/23 11:34, Neha Malcom Francis wrote: > Current default size of 0x10 is not capable of getting the FIT > buffer during boot when transitioning to using binman generated boot > images for certain K3 devices, so increase it to 0x40. Since A72 SPL > is coming after relocation to DDR this should not be an issue for any K3 > device, so make it default for all. > > Signed-off-by: Neha Malcom Francis > --- > common/spl/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > index a25d8fd2e0..d8c78ddb76 100644 > --- a/common/spl/Kconfig > +++ b/common/spl/Kconfig > @@ -385,6 +385,7 @@ config SPL_STACK_R_ADDR > config SPL_STACK_R_MALLOC_SIMPLE_LEN > depends on SPL_STACK_R && SPL_SYS_MALLOC_SIMPLE > hex "Size of malloc_simple heap after switching to DRAM SPL stack" > + default 0x40 if ARCH_K3 Wont this take affect for both R5 SPL and A72 SPL as ARCH_K3 = y in both cases? > default 0x10 > help > Specify the amount of the stack to use as memory pool for -- Regards Vignesh
[PATCH] configs: Increase malloc size after relocation
Current default size of 0x10 is not capable of getting the FIT buffer during boot when transitioning to using binman generated boot images for certain K3 devices, so increase it to 0x40. Since A72 SPL is coming after relocation to DDR this should not be an issue for any K3 device, so make it default for all. Signed-off-by: Neha Malcom Francis --- common/spl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index a25d8fd2e0..d8c78ddb76 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -385,6 +385,7 @@ config SPL_STACK_R_ADDR config SPL_STACK_R_MALLOC_SIMPLE_LEN depends on SPL_STACK_R && SPL_SYS_MALLOC_SIMPLE hex "Size of malloc_simple heap after switching to DRAM SPL stack" + default 0x40 if ARCH_K3 default 0x10 help Specify the amount of the stack to use as memory pool for -- 2.34.1
