Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
Hi, On Fri, 03 May 2024 09:00:38 +0200, Benjamin Hahn wrote: > Set CONFIG_USB_GADGET_MANUFACTURER to PHYTEC for all PHYTEC boards. > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu) [1/1] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/371b379edbf3488d77bc321dc5d2a0e22e067744 -- Mattijs
Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
Hi Benjamin, Thank you for the patch. On ven., mai 03, 2024 at 09:00, Benjamin Hahn wrote: > Set CONFIG_USB_GADGET_MANUFACTURER to PHYTEC for all PHYTEC boards. > > Signed-off-by: Benjamin Hahn Reviewed-by: Mattijs Korpershoek This is assigned to me on patchwork. I can pick it up through u-boot-dfu. If someone else wants to pick it up, please let me know. > --- > configs/phycore-imx8mp_defconfig | 2 +- > configs/phycore_am64x_a53_defconfig | 2 +- > configs/phycore_am64x_r5_defconfig | 2 +- > configs/phycore_pcl063_defconfig | 2 +- > configs/phycore_pcl063_ull_defconfig | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/configs/phycore-imx8mp_defconfig > b/configs/phycore-imx8mp_defconfig > index e9a287cb441f..9f42edd72324 100644 > --- a/configs/phycore-imx8mp_defconfig > +++ b/configs/phycore-imx8mp_defconfig > @@ -147,7 +147,7 @@ CONFIG_USB_DWC3=y > CONFIG_USB_DWC3_GENERIC=y > CONFIG_USB_STORAGE=y > CONFIG_USB_GADGET=y > -CONFIG_USB_GADGET_MANUFACTURER="FSL" > +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" > CONFIG_USB_GADGET_VENDOR_NUM=0x0525 > CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 > CONFIG_IMX_WATCHDOG=y > diff --git a/configs/phycore_am64x_a53_defconfig > b/configs/phycore_am64x_a53_defconfig > index 1a9359773b45..9b52f8ad0644 100644 > --- a/configs/phycore_am64x_a53_defconfig > +++ b/configs/phycore_am64x_a53_defconfig > @@ -159,7 +159,7 @@ CONFIG_USB_CDNS3=y > CONFIG_USB_CDNS3_GADGET=y > CONFIG_USB_CDNS3_HOST=y > CONFIG_USB_GADGET=y > -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments" > +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" > CONFIG_USB_GADGET_VENDOR_NUM=0x0451 > CONFIG_USB_GADGET_PRODUCT_NUM=0x6165 > CONFIG_USB_GADGET_DOWNLOAD=y > diff --git a/configs/phycore_am64x_r5_defconfig > b/configs/phycore_am64x_r5_defconfig > index 61d784fa17f6..15a7e7089e73 100644 > --- a/configs/phycore_am64x_r5_defconfig > +++ b/configs/phycore_am64x_r5_defconfig > @@ -171,7 +171,7 @@ CONFIG_USB_STORAGE=y > CONFIG_SPL_USB_STORAGE=y > CONFIG_USB_GADGET=y > CONFIG_SPL_USB_GADGET=y > -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments" > +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" > CONFIG_USB_GADGET_VENDOR_NUM=0x0451 > CONFIG_USB_GADGET_PRODUCT_NUM=0x6165 > CONFIG_USB_GADGET_DOWNLOAD=y > diff --git a/configs/phycore_pcl063_defconfig > b/configs/phycore_pcl063_defconfig > index 017054a8e12b..2f6b158a6772 100644 > --- a/configs/phycore_pcl063_defconfig > +++ b/configs/phycore_pcl063_defconfig > @@ -62,7 +62,7 @@ CONFIG_IMX_THERMAL=y > CONFIG_USB=y > CONFIG_SPL_USB_HOST=y > CONFIG_USB_GADGET=y > -CONFIG_USB_GADGET_MANUFACTURER="Phytec" > +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" > CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 > CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff > CONFIG_CI_UDC=y > diff --git a/configs/phycore_pcl063_ull_defconfig > b/configs/phycore_pcl063_ull_defconfig > index b3da43a5bf1e..b42a410da69c 100644 > --- a/configs/phycore_pcl063_ull_defconfig > +++ b/configs/phycore_pcl063_ull_defconfig > @@ -53,7 +53,7 @@ CONFIG_IMX_THERMAL=y > CONFIG_USB=y > CONFIG_SPL_USB_HOST=y > CONFIG_USB_GADGET=y > -CONFIG_USB_GADGET_MANUFACTURER="Phytec" > +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" > CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 > CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff > CONFIG_CI_UDC=y > > --- > base-commit: 6fdb021f148f598a67eb3cac5e3eb4a569cdaacd > change-id: 20240503-wip-bhahn-bspimx8m-3196-c1ebd0bab6ac > > Best regards, > -- > Benjamin Hahn
Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
Hi Benjamin, On Mon, May 6, 2024 at 7:52 AM Benjamin Hahn wrote: > We are not registered at USB-IF and therefore don't have a valid > VENDOR_NUM and PRODUCT_NUM, so we rely on the VENDOR_NUM and PRODUCT_NUM > of the SoC Vendor, so the correct features get enabled by the driver. Ok, understood. Reviewed-by: Fabio Estevam
Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
Hi Fabio, On 03.05.24 14:44, Fabio Estevam wrote: > Hi Benjamin, > > On Fri, May 3, 2024 at 4:01 AM Benjamin Hahn wrote: > >> -CONFIG_USB_GADGET_MANUFACTURER="FSL" >> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" >> CONFIG_USB_GADGET_VENDOR_NUM=0x0525 >> CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 > ... >> -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments" >> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" >> CONFIG_USB_GADGET_VENDOR_NUM=0x0451 >> CONFIG_USB_GADGET_PRODUCT_NUM=0x6165 > What about making VENDOR_NUM/PRODUCT_NUM consistent as well? We are not registered at USB-IF and therefore don't have a valid VENDOR_NUM and PRODUCT_NUM, so we rely on the VENDOR_NUM and PRODUCT_NUM of the SoC Vendor, so the correct features get enabled by the driver. With kind regards, Benjamin Hahn
Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
Hi Benjamin, On Fri, May 3, 2024 at 4:01 AM Benjamin Hahn wrote: > -CONFIG_USB_GADGET_MANUFACTURER="FSL" > +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" > CONFIG_USB_GADGET_VENDOR_NUM=0x0525 > CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 ... > -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments" > +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" > CONFIG_USB_GADGET_VENDOR_NUM=0x0451 > CONFIG_USB_GADGET_PRODUCT_NUM=0x6165 What about making VENDOR_NUM/PRODUCT_NUM consistent as well?
Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
Am 03.05.24 um 09:00 schrieb Benjamin Hahn: Set CONFIG_USB_GADGET_MANUFACTURER to PHYTEC for all PHYTEC boards. Signed-off-by: Benjamin Hahn Acked-by: Wadim Egorov --- configs/phycore-imx8mp_defconfig | 2 +- configs/phycore_am64x_a53_defconfig | 2 +- configs/phycore_am64x_r5_defconfig | 2 +- configs/phycore_pcl063_defconfig | 2 +- configs/phycore_pcl063_ull_defconfig | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/configs/phycore-imx8mp_defconfig b/configs/phycore-imx8mp_defconfig index e9a287cb441f..9f42edd72324 100644 --- a/configs/phycore-imx8mp_defconfig +++ b/configs/phycore-imx8mp_defconfig @@ -147,7 +147,7 @@ CONFIG_USB_DWC3=y CONFIG_USB_DWC3_GENERIC=y CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="FSL" +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" CONFIG_USB_GADGET_VENDOR_NUM=0x0525 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 CONFIG_IMX_WATCHDOG=y diff --git a/configs/phycore_am64x_a53_defconfig b/configs/phycore_am64x_a53_defconfig index 1a9359773b45..9b52f8ad0644 100644 --- a/configs/phycore_am64x_a53_defconfig +++ b/configs/phycore_am64x_a53_defconfig @@ -159,7 +159,7 @@ CONFIG_USB_CDNS3=y CONFIG_USB_CDNS3_GADGET=y CONFIG_USB_CDNS3_HOST=y CONFIG_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments" +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" CONFIG_USB_GADGET_VENDOR_NUM=0x0451 CONFIG_USB_GADGET_PRODUCT_NUM=0x6165 CONFIG_USB_GADGET_DOWNLOAD=y diff --git a/configs/phycore_am64x_r5_defconfig b/configs/phycore_am64x_r5_defconfig index 61d784fa17f6..15a7e7089e73 100644 --- a/configs/phycore_am64x_r5_defconfig +++ b/configs/phycore_am64x_r5_defconfig @@ -171,7 +171,7 @@ CONFIG_USB_STORAGE=y CONFIG_SPL_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_SPL_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments" +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" CONFIG_USB_GADGET_VENDOR_NUM=0x0451 CONFIG_USB_GADGET_PRODUCT_NUM=0x6165 CONFIG_USB_GADGET_DOWNLOAD=y diff --git a/configs/phycore_pcl063_defconfig b/configs/phycore_pcl063_defconfig index 017054a8e12b..2f6b158a6772 100644 --- a/configs/phycore_pcl063_defconfig +++ b/configs/phycore_pcl063_defconfig @@ -62,7 +62,7 @@ CONFIG_IMX_THERMAL=y CONFIG_USB=y CONFIG_SPL_USB_HOST=y CONFIG_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="Phytec" +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff CONFIG_CI_UDC=y diff --git a/configs/phycore_pcl063_ull_defconfig b/configs/phycore_pcl063_ull_defconfig index b3da43a5bf1e..b42a410da69c 100644 --- a/configs/phycore_pcl063_ull_defconfig +++ b/configs/phycore_pcl063_ull_defconfig @@ -53,7 +53,7 @@ CONFIG_IMX_THERMAL=y CONFIG_USB=y CONFIG_SPL_USB_HOST=y CONFIG_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="Phytec" +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff CONFIG_CI_UDC=y --- base-commit: 6fdb021f148f598a67eb3cac5e3eb4a569cdaacd change-id: 20240503-wip-bhahn-bspimx8m-3196-c1ebd0bab6ac Best regards,
[PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
Set CONFIG_USB_GADGET_MANUFACTURER to PHYTEC for all PHYTEC boards. Signed-off-by: Benjamin Hahn --- configs/phycore-imx8mp_defconfig | 2 +- configs/phycore_am64x_a53_defconfig | 2 +- configs/phycore_am64x_r5_defconfig | 2 +- configs/phycore_pcl063_defconfig | 2 +- configs/phycore_pcl063_ull_defconfig | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/configs/phycore-imx8mp_defconfig b/configs/phycore-imx8mp_defconfig index e9a287cb441f..9f42edd72324 100644 --- a/configs/phycore-imx8mp_defconfig +++ b/configs/phycore-imx8mp_defconfig @@ -147,7 +147,7 @@ CONFIG_USB_DWC3=y CONFIG_USB_DWC3_GENERIC=y CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="FSL" +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" CONFIG_USB_GADGET_VENDOR_NUM=0x0525 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 CONFIG_IMX_WATCHDOG=y diff --git a/configs/phycore_am64x_a53_defconfig b/configs/phycore_am64x_a53_defconfig index 1a9359773b45..9b52f8ad0644 100644 --- a/configs/phycore_am64x_a53_defconfig +++ b/configs/phycore_am64x_a53_defconfig @@ -159,7 +159,7 @@ CONFIG_USB_CDNS3=y CONFIG_USB_CDNS3_GADGET=y CONFIG_USB_CDNS3_HOST=y CONFIG_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments" +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" CONFIG_USB_GADGET_VENDOR_NUM=0x0451 CONFIG_USB_GADGET_PRODUCT_NUM=0x6165 CONFIG_USB_GADGET_DOWNLOAD=y diff --git a/configs/phycore_am64x_r5_defconfig b/configs/phycore_am64x_r5_defconfig index 61d784fa17f6..15a7e7089e73 100644 --- a/configs/phycore_am64x_r5_defconfig +++ b/configs/phycore_am64x_r5_defconfig @@ -171,7 +171,7 @@ CONFIG_USB_STORAGE=y CONFIG_SPL_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_SPL_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments" +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" CONFIG_USB_GADGET_VENDOR_NUM=0x0451 CONFIG_USB_GADGET_PRODUCT_NUM=0x6165 CONFIG_USB_GADGET_DOWNLOAD=y diff --git a/configs/phycore_pcl063_defconfig b/configs/phycore_pcl063_defconfig index 017054a8e12b..2f6b158a6772 100644 --- a/configs/phycore_pcl063_defconfig +++ b/configs/phycore_pcl063_defconfig @@ -62,7 +62,7 @@ CONFIG_IMX_THERMAL=y CONFIG_USB=y CONFIG_SPL_USB_HOST=y CONFIG_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="Phytec" +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff CONFIG_CI_UDC=y diff --git a/configs/phycore_pcl063_ull_defconfig b/configs/phycore_pcl063_ull_defconfig index b3da43a5bf1e..b42a410da69c 100644 --- a/configs/phycore_pcl063_ull_defconfig +++ b/configs/phycore_pcl063_ull_defconfig @@ -53,7 +53,7 @@ CONFIG_IMX_THERMAL=y CONFIG_USB=y CONFIG_SPL_USB_HOST=y CONFIG_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="Phytec" +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" CONFIG_USB_GADGET_VENDOR_NUM=0x1b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff CONFIG_CI_UDC=y --- base-commit: 6fdb021f148f598a67eb3cac5e3eb4a569cdaacd change-id: 20240503-wip-bhahn-bspimx8m-3196-c1ebd0bab6ac Best regards, -- Benjamin Hahn
