Re: [PATCH] doc: build: update docker image to latest
Hi Tom,
Thank you for the review.
On lun., avril 08, 2024 at 14:11, Tom Rini wrote:
> On Fri, Apr 05, 2024 at 08:16:19AM +0200, Mattijs Korpershoek wrote:
>
>
>> commit cacc0b2678c0 ("CI: Move to latest container image") updated the
>> docker container image.
>>
>> Reflect the change in the documentation.
>>
>> Signed-off-by: Mattijs Korpershoek
>
> I'm fine with updating this for now, so:
>
> Reviewed-by: Tom Rini
>
> But I think longer term we/I should reword the section to be clear
> that's an example syntax not a "recreate the current tag" since only I
> can push that result.
I agree. I will do another reword later to explain where to find the
reference image (pointing to .gitlab-ci.yml)
>
> --
> Tom
Re: [PATCH] doc: build: update docker image to latest
On Fri, Apr 05, 2024 at 08:16:19AM +0200, Mattijs Korpershoek wrote:
> commit cacc0b2678c0 ("CI: Move to latest container image") updated the
> docker container image.
>
> Reflect the change in the documentation.
>
> Signed-off-by: Mattijs Korpershoek
I'm fine with updating this for now, so:
Reviewed-by: Tom Rini
But I think longer term we/I should reword the section to be clear
that's an example syntax not a "recreate the current tag" since only I
can push that result.
--
Tom
signature.asc
Description: PGP signature
Re: [PATCH] doc: build: update docker image to latest
On 4/5/24 08:16, Mattijs Korpershoek wrote:
commit cacc0b2678c0 ("CI: Move to latest container image") updated the
docker container image.
Reflect the change in the documentation.
Signed-off-by: Mattijs Korpershoek
Reviewed-by: Heinrich Schuchardt
---
Note: maybe we can consider doing the doc change each time we update
.gitlab-ci.yml ?
---
doc/build/docker.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/build/docker.rst b/doc/build/docker.rst
index 953d1b28a063..45659b3b89dc 100644
--- a/doc/build/docker.rst
+++ b/doc/build/docker.rst
@@ -11,4 +11,4 @@ Or to use an existing container
.. code-block:: bash
-sudo docker pull trini/u-boot-gitlab-ci-runner:bionic-20200807-02Sep2020
+sudo docker pull trini/u-boot-gitlab-ci-runner:jammy-20240227-14Mar2024
---
base-commit: cdfcc37428e06f4730ab9a17cc084eeb7676ea1a
change-id: 20240405-doc-container-img-904d56d5efcb
Best regards,
[PATCH] doc: build: update docker image to latest
commit cacc0b2678c0 ("CI: Move to latest container image") updated the
docker container image.
Reflect the change in the documentation.
Signed-off-by: Mattijs Korpershoek
---
Note: maybe we can consider doing the doc change each time we update
.gitlab-ci.yml ?
---
doc/build/docker.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/build/docker.rst b/doc/build/docker.rst
index 953d1b28a063..45659b3b89dc 100644
--- a/doc/build/docker.rst
+++ b/doc/build/docker.rst
@@ -11,4 +11,4 @@ Or to use an existing container
.. code-block:: bash
-sudo docker pull trini/u-boot-gitlab-ci-runner:bionic-20200807-02Sep2020
+sudo docker pull trini/u-boot-gitlab-ci-runner:jammy-20240227-14Mar2024
---
base-commit: cdfcc37428e06f4730ab9a17cc084eeb7676ea1a
change-id: 20240405-doc-container-img-904d56d5efcb
Best regards,
--
Mattijs Korpershoek
