Re: [PATCH] drivers: video: rockchip: fix building eDP and LVDS drivers
On Mon, 20 Apr 2020 19:18:25 +0100 Peter Robinson pbrobin...@gmail.com wrote: > The rk_edp.c and rk_lvds.c files reference rk_setreg which is declared in > hardware.h so include it so the drivers build. Adjust rk_lvds.c so > includes are in alphabetical order while updating. > > Signed-off-by: Peter Robinson > --- > drivers/video/rockchip/rk_edp.c | 1 + > drivers/video/rockchip/rk_lvds.c | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) Applied to u-boot-video/master, thanks! -- Anatolij
Re: [PATCH] drivers: video: rockchip: fix building eDP and LVDS drivers
On 2020-04-20, Peter Robinson wrote: > The rk_edp.c and rk_lvds.c files reference rk_setreg which is declared in > hardware.h so include it so the drivers build. Adjust rk_lvds.c so > includes are in alphabetical order while updating. > > Signed-off-by: Peter Robinson > Reviewed-by: Anatolij Gustschin This fixed the build I was having with the pinebook pro patches when applied to v2020.04, built on both Debian and GNU Guix. Thanks! Tested-by: Vagrant Cascadian > --- > drivers/video/rockchip/rk_edp.c | 1 + > drivers/video/rockchip/rk_lvds.c | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/rockchip/rk_edp.c b/drivers/video/rockchip/rk_edp.c > index 8703df0ec0..cf84b886e7 100644 > --- a/drivers/video/rockchip/rk_edp.c > +++ b/drivers/video/rockchip/rk_edp.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > > #define MAX_CR_LOOP 5 > diff --git a/drivers/video/rockchip/rk_lvds.c > b/drivers/video/rockchip/rk_lvds.c > index cf5c0439b1..79e24baf53 100644 > --- a/drivers/video/rockchip/rk_lvds.c > +++ b/drivers/video/rockchip/rk_lvds.c > @@ -13,8 +13,9 @@ > #include > #include > #include > -#include > #include > +#include > +#include > #include > #include > signature.asc Description: PGP signature
Re: [PATCH] drivers: video: rockchip: fix building eDP and LVDS drivers
On Mon, 20 Apr 2020 19:18:25 +0100 Peter Robinson pbrobin...@gmail.com wrote: > The rk_edp.c and rk_lvds.c files reference rk_setreg which is declared in > hardware.h so include it so the drivers build. Adjust rk_lvds.c so > includes are in alphabetical order while updating. > > Signed-off-by: Peter Robinson Reviewed-by: Anatolij Gustschin -- Anatolij
[PATCH] drivers: video: rockchip: fix building eDP and LVDS drivers
The rk_edp.c and rk_lvds.c files reference rk_setreg which is declared in hardware.h so include it so the drivers build. Adjust rk_lvds.c so includes are in alphabetical order while updating. Signed-off-by: Peter Robinson --- drivers/video/rockchip/rk_edp.c | 1 + drivers/video/rockchip/rk_lvds.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/rockchip/rk_edp.c b/drivers/video/rockchip/rk_edp.c index 8703df0ec0..cf84b886e7 100644 --- a/drivers/video/rockchip/rk_edp.c +++ b/drivers/video/rockchip/rk_edp.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #define MAX_CR_LOOP 5 diff --git a/drivers/video/rockchip/rk_lvds.c b/drivers/video/rockchip/rk_lvds.c index cf5c0439b1..79e24baf53 100644 --- a/drivers/video/rockchip/rk_lvds.c +++ b/drivers/video/rockchip/rk_lvds.c @@ -13,8 +13,9 @@ #include #include #include -#include #include +#include +#include #include #include -- 2.26.1
