Re: [PATCH] efi_loader: fix wrong attribute check for QueryVariableInfo

[Heinrich Schuchardt]

On 2/15/23 03:32, Masahisa Kojima wrote:

QueryVariableInfo with EFI_VARIABLE_HARDWARE_ERROR_RECORD is
accepted, remove wrong attribute check.

Fixes: 454a9442fbce ("efi_loader: update attribute check for 
QueryVariableInfo()")
Signed-off-by: Masahisa Kojima 


Reviewed-by: Heinrich Schuchardt 


---
  lib/efi_loader/efi_variable.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c
index b12e79d658..f1d967cd0e 100644
--- a/lib/efi_loader/efi_variable.c
+++ b/lib/efi_loader/efi_variable.c
@@ -385,9 +385,6 @@ efi_status_t efi_query_variable_info_int(u32 attributes,
EFI_VARIABLE_RUNTIME_ACCESS)
return EFI_INVALID_PARAMETER;
  
-	if (attributes & EFI_VARIABLE_HARDWARE_ERROR_RECORD)

-   return EFI_UNSUPPORTED;
-
if (attributes & ~(u32)EFI_VARIABLE_MASK)
return EFI_INVALID_PARAMETER;
  

[PATCH] efi_loader: fix wrong attribute check for QueryVariableInfo

[Masahisa Kojima]

QueryVariableInfo with EFI_VARIABLE_HARDWARE_ERROR_RECORD is
accepted, remove wrong attribute check.

Fixes: 454a9442fbce ("efi_loader: update attribute check for 
QueryVariableInfo()")
Signed-off-by: Masahisa Kojima 
---
 lib/efi_loader/efi_variable.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c
index b12e79d658..f1d967cd0e 100644
--- a/lib/efi_loader/efi_variable.c
+++ b/lib/efi_loader/efi_variable.c
@@ -385,9 +385,6 @@ efi_status_t efi_query_variable_info_int(u32 attributes,
EFI_VARIABLE_RUNTIME_ACCESS)
return EFI_INVALID_PARAMETER;
 
-   if (attributes & EFI_VARIABLE_HARDWARE_ERROR_RECORD)
-   return EFI_UNSUPPORTED;
-
if (attributes & ~(u32)EFI_VARIABLE_MASK)
return EFI_INVALID_PARAMETER;
 
-- 
2.17.1