Re: [PATCH] i2c: mxc_i2c: Use hex notation for the base address

2023-02-13 Thread Heiko Schocher 
Hello Fabio,

On 03.01.23 20:03, Fabio Estevam wrote:
> Printing the I2C controller base address in decimal notation
> is not helpful.
> 
> Change it to hex notation, which is the standard format found
> in the Reference Manual and devicetree.
> 
> Signed-off-by: Fabio Estevam 
> Acked-by: Dhruva Gole 
> Reviewed-by: Heiko Schocher 
> ---
>  drivers/i2c/mxc_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-i2c.git master

bye,
Heiko
-- 
DENX Software Engineering GmbH,  Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de

Re: [PATCH] i2c: mxc_i2c: Use hex notation for the base address

2023-01-10 Thread Heiko Schocher 
Hello Fabio,

On 03.01.23 20:03, Fabio Estevam wrote:
> Printing the I2C controller base address in decimal notation
> is not helpful.
> 
> Change it to hex notation, which is the standard format found
> in the Reference Manual and devicetree.
> 
> Signed-off-by: Fabio Estevam 
> ---
>  drivers/i2c/mxc_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Heiko Schocher 

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,  Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de

Re: [PATCH] i2c: mxc_i2c: Use hex notation for the base address

2023-01-03 Thread Dhruva Gole 




On 04/01/23 00:33, Fabio Estevam wrote:

Printing the I2C controller base address in decimal notation
is not helpful.

Change it to hex notation, which is the standard format found
in the Reference Manual and devicetree.


Agree



Signed-off-by: Fabio Estevam 
---


Acked-by: Dhruva Gole 


  drivers/i2c/mxc_i2c.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
index f80ff5383b..9dd349d056 100644
--- a/drivers/i2c/mxc_i2c.c
+++ b/drivers/i2c/mxc_i2c.c
@@ -938,7 +938,7 @@ static int mxc_i2c_probe(struct udevice *bus)
 * we can set pinmux here in probe function.
 */
  
-	debug("i2c : controller bus %d at %lu , speed %d: ",

+   debug("i2c : controller bus %d at 0x%lx , speed %d: ",
  dev_seq(bus), i2c_bus->base,
  i2c_bus->speed);
  


--
Thanks and Regards,
Dhruva Gole

[PATCH] i2c: mxc_i2c: Use hex notation for the base address

2023-01-03 Thread Fabio Estevam 
Printing the I2C controller base address in decimal notation
is not helpful.

Change it to hex notation, which is the standard format found
in the Reference Manual and devicetree.

Signed-off-by: Fabio Estevam 
---
 drivers/i2c/mxc_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
index f80ff5383b..9dd349d056 100644
--- a/drivers/i2c/mxc_i2c.c
+++ b/drivers/i2c/mxc_i2c.c
@@ -938,7 +938,7 @@ static int mxc_i2c_probe(struct udevice *bus)
 * we can set pinmux here in probe function.
 */
 
-   debug("i2c : controller bus %d at %lu , speed %d: ",
+   debug("i2c : controller bus %d at 0x%lx , speed %d: ",
  dev_seq(bus), i2c_bus->base,
  i2c_bus->speed);
 
-- 
2.25.1