Re: [PATCH] lib: Kconfig: fix PHANDLE_CHECK_SEQ position outside of menu

[Tom Rini]

On Tue, Jan 04, 2022 at 06:20:19PM +0200, Eugen Hristev wrote:

> CONFIG_PHANDLE_CHECK_SEQ is outside of the menu 'Library routines'
> thus it's invisible in menuconfig and cannot be selected.
> Fix this by moving the 'endmenu' after the PHANDLE_CHECK_SEQ definition
> 
> Fixes: c589132a1d ("fdt: Use phandle to distinguish DT nodes with same name")
> Signed-off-by: Eugen Hristev 
> Reviewed-by: Aswath Govindraju 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature

Re: [PATCH] lib: Kconfig: fix PHANDLE_CHECK_SEQ position outside of menu

[Simon Glass]

On Tue, 4 Jan 2022 at 09:20, Eugen Hristev  wrote:
>
> CONFIG_PHANDLE_CHECK_SEQ is outside of the menu 'Library routines'
> thus it's invisible in menuconfig and cannot be selected.
> Fix this by moving the 'endmenu' after the PHANDLE_CHECK_SEQ definition
>
> Fixes: c589132a1d ("fdt: Use phandle to distinguish DT nodes with same name")
> Signed-off-by: Eugen Hristev 
> ---
>  lib/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass 

Re: [PATCH] lib: Kconfig: fix PHANDLE_CHECK_SEQ position outside of menu

[Aswath Govindraju]

Hi Eugen,

On 04/01/22 9:50 pm, Eugen Hristev wrote:
> CONFIG_PHANDLE_CHECK_SEQ is outside of the menu 'Library routines'
> thus it's invisible in menuconfig and cannot be selected.
> Fix this by moving the 'endmenu' after the PHANDLE_CHECK_SEQ definition
> 
> Fixes: c589132a1d ("fdt: Use phandle to distinguish DT nodes with same name")
> Signed-off-by: Eugen Hristev 

Thank you for fixing this :)

Reviewed-by: Aswath Govindraju 

Thanks,
Aswath
> ---
>  lib/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 807a4c6ade..652a11a154 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -827,11 +827,11 @@ config LMB_RESERVED_REGIONS
> Define the number of supported reserved regions in the library logical
> memory blocks.
>  
> -endmenu
> -
>  config PHANDLE_CHECK_SEQ
>   bool "Enable phandle check while getting sequence number"
>   help
> When there are multiple device tree nodes with same name,
>enable this config option to distinguish them using
> phandles in fdtdec_get_alias_seq() function.
> +
> +endmenu
>