Re: [PATCH] mailbox: k3-sec-proxy: fix error handling for missing scfg in FDT

[Tom Rini]

On Tue, Sep 26, 2023 at 02:42:54PM +0200, Matthias Schiffer wrote:

> The wrong field was checked.
> 
> Fixes: f9aa41023bd9 ("mailbox: Introduce K3 Secure Proxy Driver")
> Signed-off-by: Matthias Schiffer 
> Reviewed-by: Nishanth Menon 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature

Re: [PATCH] mailbox: k3-sec-proxy: fix error handling for missing scfg in FDT

[Nishanth Menon]

On 14:42-20230926, Matthias Schiffer wrote:
> The wrong field was checked.
> 
> Fixes: f9aa41023bd9 ("mailbox: Introduce K3 Secure Proxy Driver")
> Signed-off-by: Matthias Schiffer 
> ---
>  drivers/mailbox/k3-sec-proxy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/k3-sec-proxy.c b/drivers/mailbox/k3-sec-proxy.c
> index 815808498f2..27072610462 100644
> --- a/drivers/mailbox/k3-sec-proxy.c
> +++ b/drivers/mailbox/k3-sec-proxy.c
> @@ -326,7 +326,7 @@ static int k3_sec_proxy_of_to_priv(struct udevice *dev,
>   }
>  
>   spm->scfg = devfdt_get_addr_name(dev, "scfg");
> - if (spm->rt == FDT_ADDR_T_NONE) {
> + if (spm->scfg == FDT_ADDR_T_NONE) {
>   dev_err(dev, "No reg property for Secure Cfg base\n");
>   return -EINVAL;
>   }

Uggh.. Thanks for catching this.

Reviewed-by: Nishanth Menon 
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 
849D 1736 249D

[PATCH] mailbox: k3-sec-proxy: fix error handling for missing scfg in FDT

[Matthias Schiffer]

The wrong field was checked.

Fixes: f9aa41023bd9 ("mailbox: Introduce K3 Secure Proxy Driver")
Signed-off-by: Matthias Schiffer 
---
 drivers/mailbox/k3-sec-proxy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mailbox/k3-sec-proxy.c b/drivers/mailbox/k3-sec-proxy.c
index 815808498f2..27072610462 100644
--- a/drivers/mailbox/k3-sec-proxy.c
+++ b/drivers/mailbox/k3-sec-proxy.c
@@ -326,7 +326,7 @@ static int k3_sec_proxy_of_to_priv(struct udevice *dev,
}
 
spm->scfg = devfdt_get_addr_name(dev, "scfg");
-   if (spm->rt == FDT_ADDR_T_NONE) {
+   if (spm->scfg == FDT_ADDR_T_NONE) {
dev_err(dev, "No reg property for Secure Cfg base\n");
return -EINVAL;
}
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/