Re: [PATCH] net: gem: Reduce timeout of mdio phy idle status check

2022-01-05 Thread Michal Simek 
čt 18. 11. 2021 v 13:05 odesílatel Michal Simek
 napsal:
>
> From: Ashok Reddy Soma 
>
> Timeout for checking mdio phy idle status is 20seconds. In case of errors
> this timeout will be too much. Reduce it to 100ms.
>
> Signed-off-by: Ashok Reddy Soma 
> Signed-off-by: Michal Simek 
> ---
>
>  drivers/net/zynq_gem.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index c309c3c95499..033021f1cbfc 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -110,6 +110,8 @@
>
>  #define ZYNQ_GEM_DCFG_DBG6_DMA_64B BIT(23)
>
> +#define MDIO_IDLE_TIMEOUT_MS   100
> +
>  /* Use MII register 1 (MII status register) to detect PHY */
>  #define PHY_DETECT_REG  1
>
> @@ -225,7 +227,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 
> phy_addr, u32 regnum,
> int err;
>
> err = wait_for_bit_le32(®s->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
> -   true, 2, false);
> +   true, MDIO_IDLE_TIMEOUT_MS, false);
> if (err)
> return err;
>
> @@ -238,7 +240,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 
> phy_addr, u32 regnum,
> writel(mgtcr, ®s->phymntnc);
>
> err = wait_for_bit_le32(®s->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
> -   true, 2, false);
> +   true, MDIO_IDLE_TIMEOUT_MS, false);
> if (err)
> return err;
>
> --
> 2.33.1
>

Applied.
M

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs

Re: [PATCH] net: gem: Reduce timeout of mdio phy idle status check

2021-11-21 Thread Ramon Fried 
On Thu, Nov 18, 2021 at 2:05 PM Michal Simek  wrote:
>
> From: Ashok Reddy Soma 
>
> Timeout for checking mdio phy idle status is 20seconds. In case of errors
> this timeout will be too much. Reduce it to 100ms.
>
> Signed-off-by: Ashok Reddy Soma 
> Signed-off-by: Michal Simek 
> ---
>
>  drivers/net/zynq_gem.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index c309c3c95499..033021f1cbfc 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -110,6 +110,8 @@
>
>  #define ZYNQ_GEM_DCFG_DBG6_DMA_64B BIT(23)
>
> +#define MDIO_IDLE_TIMEOUT_MS   100
> +
>  /* Use MII register 1 (MII status register) to detect PHY */
>  #define PHY_DETECT_REG  1
>
> @@ -225,7 +227,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 
> phy_addr, u32 regnum,
> int err;
>
> err = wait_for_bit_le32(®s->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
> -   true, 2, false);
> +   true, MDIO_IDLE_TIMEOUT_MS, false);
> if (err)
> return err;
>
> @@ -238,7 +240,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 
> phy_addr, u32 regnum,
> writel(mgtcr, ®s->phymntnc);
>
> err = wait_for_bit_le32(®s->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
> -   true, 2, false);
> +   true, MDIO_IDLE_TIMEOUT_MS, false);
> if (err)
> return err;
>
> --
> 2.33.1
>
Reviewed-by: Ramon Fried

[PATCH] net: gem: Reduce timeout of mdio phy idle status check

2021-11-18 Thread Michal Simek 
From: Ashok Reddy Soma 

Timeout for checking mdio phy idle status is 20seconds. In case of errors
this timeout will be too much. Reduce it to 100ms.

Signed-off-by: Ashok Reddy Soma 
Signed-off-by: Michal Simek 
---

 drivers/net/zynq_gem.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index c309c3c95499..033021f1cbfc 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -110,6 +110,8 @@
 
 #define ZYNQ_GEM_DCFG_DBG6_DMA_64B BIT(23)
 
+#define MDIO_IDLE_TIMEOUT_MS   100
+
 /* Use MII register 1 (MII status register) to detect PHY */
 #define PHY_DETECT_REG  1
 
@@ -225,7 +227,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 
phy_addr, u32 regnum,
int err;
 
err = wait_for_bit_le32(®s->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
-   true, 2, false);
+   true, MDIO_IDLE_TIMEOUT_MS, false);
if (err)
return err;
 
@@ -238,7 +240,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 
phy_addr, u32 regnum,
writel(mgtcr, ®s->phymntnc);
 
err = wait_for_bit_le32(®s->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
-   true, 2, false);
+   true, MDIO_IDLE_TIMEOUT_MS, false);
if (err)
return err;
 
-- 
2.33.1

Re: [PATCH] net: gem: Reduce timeout of mdio phy idle status check

2021-11-01 Thread Ramon Fried 
On Fri, Oct 29, 2021 at 2:16 PM Michal Simek  wrote:
>
> From: Ashok Reddy Soma 
>
> Timeout for checking mdio phy idle status is 20seconds. In case of errors
> this timeout will be too much. Reduce it to 100ms.
>
> Signed-off-by: Ashok Reddy Soma 
> Signed-off-by: Michal Simek 
> ---
>
>  drivers/net/zynq_gem.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index c309c3c95499..033021f1cbfc 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -110,6 +110,8 @@
>
>  #define ZYNQ_GEM_DCFG_DBG6_DMA_64B BIT(23)
>
> +#define MDIO_IDLE_TIMEOUT_MS   100
> +
>  /* Use MII register 1 (MII status register) to detect PHY */
>  #define PHY_DETECT_REG  1
>
> @@ -225,7 +227,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 
> phy_addr, u32 regnum,
> int err;
>
> err = wait_for_bit_le32(®s->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
> -   true, 2, false);
> +   true, MDIO_IDLE_TIMEOUT_MS, false);
> if (err)
> return err;
>
> @@ -238,7 +240,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 
> phy_addr, u32 regnum,
> writel(mgtcr, ®s->phymntnc);
>
> err = wait_for_bit_le32(®s->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
> -   true, 2, false);
> +   true, MDIO_IDLE_TIMEOUT_MS, false);
> if (err)
> return err;
>
> --
> 2.33.1
>
Reviewed-by: Ramon Fried

[PATCH] net: gem: Reduce timeout of mdio phy idle status check

2021-10-29 Thread Michal Simek 
From: Ashok Reddy Soma 

Timeout for checking mdio phy idle status is 20seconds. In case of errors
this timeout will be too much. Reduce it to 100ms.

Signed-off-by: Ashok Reddy Soma 
Signed-off-by: Michal Simek 
---

 drivers/net/zynq_gem.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index c309c3c95499..033021f1cbfc 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -110,6 +110,8 @@
 
 #define ZYNQ_GEM_DCFG_DBG6_DMA_64B BIT(23)
 
+#define MDIO_IDLE_TIMEOUT_MS   100
+
 /* Use MII register 1 (MII status register) to detect PHY */
 #define PHY_DETECT_REG  1
 
@@ -225,7 +227,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 
phy_addr, u32 regnum,
int err;
 
err = wait_for_bit_le32(®s->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
-   true, 2, false);
+   true, MDIO_IDLE_TIMEOUT_MS, false);
if (err)
return err;
 
@@ -238,7 +240,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 
phy_addr, u32 regnum,
writel(mgtcr, ®s->phymntnc);
 
err = wait_for_bit_le32(®s->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
-   true, 2, false);
+   true, MDIO_IDLE_TIMEOUT_MS, false);
if (err)
return err;
 
-- 
2.33.1