RE: [PATCH] net: phy: micrel: Get phy node from phy-handle

2022-11-27 Thread Lim, Jit Loon 
-Original Message-
From: Ramon Fried  
Sent: Sunday, 27 November, 2022 6:50 AM
To: Lim, Jit Loon 
Cc: u-boot@lists.denx.de; Jagan Teki ; Vignesh R 
; Vasut, Marek ; Simon 
; Chee, Tien Fong ; 
Hea, Kok Kiang ; Lim, Elly Siew Chin 
; Kho, Sin Hui ; 
Lokanathan, Raaj ; Maniyam, Dinesh 
; Ng, Boon Khai ; Yuslaimi, 
Alif Zakuan ; Chong, Teik Heng 
; Zamri, Muhammad Hazim Izzat 
; Tang, Sieu Mun 
; Ley Foon Tan 
Subject: Re: [PATCH] net: phy: micrel: Get phy node from phy-handle

On Tue, Nov 22, 2022 at 4:41 PM Jit Loon Lim  wrote:
>
> From: Ley Foon Tan 
>
> HSD #1509063521: Try to get phy node from "phy-handle" if can't find 
> ethernet-phy subnode.
What is this HSD ? Intel internal ?
Please remove.

Yes, this is for Intel internal tracking. We shall remove it and update the 
patch. 

> Lastly only use Ethernet node if can't find phy node from ethernet-phy 
> subnode and phy-handle.
>
> Signed-off-by: Ley Foon Tan 
> Signed-off-by: Jit Loon Lim 
> ---
>  drivers/net/phy/micrel_ksz90x1.c | 11 +--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/micrel_ksz90x1.c 
> b/drivers/net/phy/micrel_ksz90x1.c
> index e5f578201f..e33789b7f7 100644
> --- a/drivers/net/phy/micrel_ksz90x1.c
> +++ b/drivers/net/phy/micrel_ksz90x1.c
> @@ -112,6 +112,7 @@ static int ksz90x1_of_config_group(struct 
> phy_device *phydev,  {
> struct udevice *dev = phydev->dev;
> struct phy_driver *drv = phydev->drv;
> +   struct ofnode_phandle_args phandle;
> int val[4];
> int i, changed = 0, offset, max;
> u16 regval = 0;
> @@ -128,8 +129,14 @@ static int ksz90x1_of_config_group(struct phy_device 
> *phydev,
> }
>
> if (!ofnode_valid(node)) {
> -   /* No node found, look in the Ethernet node */
> -   node = dev_ofnode(dev);
> +   if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0,
> +  &phandle)) {
> +   /* No phy-handle found, look in the Ethernet node */
> +   node = dev_ofnode(dev);
> +   } else {
> +   /* phy-handle found */
> +   node = phandle.node;
> +   }
> }
>
> for (i = 0; i < ofcfg->grpsz; i++) {
> --
> 2.26.2
>

Re: [PATCH] net: phy: micrel: Get phy node from phy-handle

2022-11-26 Thread Ramon Fried 
On Tue, Nov 22, 2022 at 4:41 PM Jit Loon Lim  wrote:
>
> From: Ley Foon Tan 
>
> HSD #1509063521: Try to get phy node from "phy-handle" if can't find 
> ethernet-phy subnode.
What is this HSD ? Intel internal ?
Please remove.
> Lastly only use Ethernet node if can't find phy node from ethernet-phy
> subnode and phy-handle.
>
> Signed-off-by: Ley Foon Tan 
> Signed-off-by: Jit Loon Lim 
> ---
>  drivers/net/phy/micrel_ksz90x1.c | 11 +--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/micrel_ksz90x1.c 
> b/drivers/net/phy/micrel_ksz90x1.c
> index e5f578201f..e33789b7f7 100644
> --- a/drivers/net/phy/micrel_ksz90x1.c
> +++ b/drivers/net/phy/micrel_ksz90x1.c
> @@ -112,6 +112,7 @@ static int ksz90x1_of_config_group(struct phy_device 
> *phydev,
>  {
> struct udevice *dev = phydev->dev;
> struct phy_driver *drv = phydev->drv;
> +   struct ofnode_phandle_args phandle;
> int val[4];
> int i, changed = 0, offset, max;
> u16 regval = 0;
> @@ -128,8 +129,14 @@ static int ksz90x1_of_config_group(struct phy_device 
> *phydev,
> }
>
> if (!ofnode_valid(node)) {
> -   /* No node found, look in the Ethernet node */
> -   node = dev_ofnode(dev);
> +   if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0,
> +  &phandle)) {
> +   /* No phy-handle found, look in the Ethernet node */
> +   node = dev_ofnode(dev);
> +   } else {
> +   /* phy-handle found */
> +   node = phandle.node;
> +   }
> }
>
> for (i = 0; i < ofcfg->grpsz; i++) {
> --
> 2.26.2
>

[PATCH] net: phy: micrel: Get phy node from phy-handle

2022-11-22 Thread Jit Loon Lim 
From: Ley Foon Tan 

HSD #1509063521: Try to get phy node from "phy-handle" if can't find 
ethernet-phy subnode.
Lastly only use Ethernet node if can't find phy node from ethernet-phy
subnode and phy-handle.

Signed-off-by: Ley Foon Tan 
Signed-off-by: Jit Loon Lim 
---
 drivers/net/phy/micrel_ksz90x1.c | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/micrel_ksz90x1.c b/drivers/net/phy/micrel_ksz90x1.c
index e5f578201f..e33789b7f7 100644
--- a/drivers/net/phy/micrel_ksz90x1.c
+++ b/drivers/net/phy/micrel_ksz90x1.c
@@ -112,6 +112,7 @@ static int ksz90x1_of_config_group(struct phy_device 
*phydev,
 {
struct udevice *dev = phydev->dev;
struct phy_driver *drv = phydev->drv;
+   struct ofnode_phandle_args phandle;
int val[4];
int i, changed = 0, offset, max;
u16 regval = 0;
@@ -128,8 +129,14 @@ static int ksz90x1_of_config_group(struct phy_device 
*phydev,
}
 
if (!ofnode_valid(node)) {
-   /* No node found, look in the Ethernet node */
-   node = dev_ofnode(dev);
+   if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0,
+  &phandle)) {
+   /* No phy-handle found, look in the Ethernet node */
+   node = dev_ofnode(dev);
+   } else {
+   /* phy-handle found */
+   node = phandle.node;
+   }
}
 
for (i = 0; i < ofcfg->grpsz; i++) {
-- 
2.26.2

Re: [PATCH] net: phy: micrel: Get phy node from phy-handle

2021-04-29 Thread Ramon Fried 
On Mon, Apr 26, 2021 at 6:43 AM Ley Foon Tan  wrote:
>
> If can't find ethernet-phy subnode, try to get phy node from "phy-handle".
> Lastly, only use Ethernet node if can't find phy node from ethernet-phy
> subnode and phy-handle.
>
> Signed-off-by: Ley Foon Tan 
> ---
>  drivers/net/phy/micrel_ksz90x1.c | 11 +--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/micrel_ksz90x1.c 
> b/drivers/net/phy/micrel_ksz90x1.c
> index e5f578201f35..e33789b7f747 100644
> --- a/drivers/net/phy/micrel_ksz90x1.c
> +++ b/drivers/net/phy/micrel_ksz90x1.c
> @@ -112,6 +112,7 @@ static int ksz90x1_of_config_group(struct phy_device 
> *phydev,
>  {
> struct udevice *dev = phydev->dev;
> struct phy_driver *drv = phydev->drv;
> +   struct ofnode_phandle_args phandle;
> int val[4];
> int i, changed = 0, offset, max;
> u16 regval = 0;
> @@ -128,8 +129,14 @@ static int ksz90x1_of_config_group(struct phy_device 
> *phydev,
> }
>
> if (!ofnode_valid(node)) {
> -   /* No node found, look in the Ethernet node */
> -   node = dev_ofnode(dev);
> +   if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0,
> +  &phandle)) {
> +   /* No phy-handle found, look in the Ethernet node */
> +   node = dev_ofnode(dev);
> +   } else {
> +   /* phy-handle found */
> +   node = phandle.node;
> +   }
> }
>
> for (i = 0; i < ofcfg->grpsz; i++) {
> --
> 2.25.1
>
Reviewed-by: Ramon Fried

[PATCH] net: phy: micrel: Get phy node from phy-handle

2021-04-25 Thread Ley Foon Tan 
If can't find ethernet-phy subnode, try to get phy node from "phy-handle".
Lastly, only use Ethernet node if can't find phy node from ethernet-phy
subnode and phy-handle.

Signed-off-by: Ley Foon Tan 
---
 drivers/net/phy/micrel_ksz90x1.c | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/micrel_ksz90x1.c b/drivers/net/phy/micrel_ksz90x1.c
index e5f578201f35..e33789b7f747 100644
--- a/drivers/net/phy/micrel_ksz90x1.c
+++ b/drivers/net/phy/micrel_ksz90x1.c
@@ -112,6 +112,7 @@ static int ksz90x1_of_config_group(struct phy_device 
*phydev,
 {
struct udevice *dev = phydev->dev;
struct phy_driver *drv = phydev->drv;
+   struct ofnode_phandle_args phandle;
int val[4];
int i, changed = 0, offset, max;
u16 regval = 0;
@@ -128,8 +129,14 @@ static int ksz90x1_of_config_group(struct phy_device 
*phydev,
}
 
if (!ofnode_valid(node)) {
-   /* No node found, look in the Ethernet node */
-   node = dev_ofnode(dev);
+   if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0,
+  &phandle)) {
+   /* No phy-handle found, look in the Ethernet node */
+   node = dev_ofnode(dev);
+   } else {
+   /* phy-handle found */
+   node = phandle.node;
+   }
}
 
for (i = 0; i < ofcfg->grpsz; i++) {
-- 
2.25.1