Re: [PATCH] riscv: binman: Add help message for missing blobs

2023-02-17 Thread Rick Chen 
Hi Leo

> On Thu, Feb 16, 2023 at 09:19:45AM +0800, Rick Chen wrote:
> > Add the 'missing-msg' for more detailed output
> > on missing system firmware.
> >
> > Signed-off-by: Rick Chen 
> > ---
> >  arch/riscv/dts/binman.dtsi | 1 +
> >  tools/binman/missing-blob-help | 4 
> >  2 files changed, 5 insertions(+)
> >
> > diff --git a/arch/riscv/dts/binman.dtsi b/arch/riscv/dts/binman.dtsi
> > index b8fc8f7f35..156cb00971 100644
> > --- a/arch/riscv/dts/binman.dtsi
> > +++ b/arch/riscv/dts/binman.dtsi
> > @@ -45,6 +45,7 @@
> >
> >   opensbi_blob: opensbi {
> >   filename = "fw_dynamic.bin";
> > + missing-msg = "opensbi";
> >   };
> >   };
> >
> > diff --git a/tools/binman/missing-blob-help b/tools/binman/missing-blob-help
> > index c61ca02a35..654ad642a3 100644
> > --- a/tools/binman/missing-blob-help
> > +++ b/tools/binman/missing-blob-help
> > @@ -37,3 +37,7 @@ https://github.com/siemens/k3-rti-wdt.
> >  tee-os:
> >  See the documentation for your board. You may need to build Open Portable
> >  Trusted Execution Environment (OP-TEE) with TEE=/path/to/tee.bin
> > +
> > +opensbi:
> > +See the documentation for your board. The OpenSBI git repo is at
> > +https://github.com/riscv/opensbi.git
> Hi Rick,
>
> Could we add something like
> "build fw_dynamic.bin first and re-build u-boot with 
> OPENSBI=/path/to/fw_dynamic.bin"

OK.

Thanks,
Rick

>
> Other than that,
> Reviewed-by: Leo Yu-Chi Liang 
>
> > --
> > 2.17.1
> >

Re: [PATCH] riscv: binman: Add help message for missing blobs

2023-02-15 Thread Leo Liang 
Hi Rick,

On Thu, Feb 16, 2023 at 09:19:45AM +0800, Rick Chen wrote:
> Add the 'missing-msg' for more detailed output
> on missing system firmware.
> 
> Signed-off-by: Rick Chen 
> ---
>  arch/riscv/dts/binman.dtsi | 1 +
>  tools/binman/missing-blob-help | 4 
>  2 files changed, 5 insertions(+)
> 
> diff --git a/arch/riscv/dts/binman.dtsi b/arch/riscv/dts/binman.dtsi
> index b8fc8f7f35..156cb00971 100644
> --- a/arch/riscv/dts/binman.dtsi
> +++ b/arch/riscv/dts/binman.dtsi
> @@ -45,6 +45,7 @@
>  
>   opensbi_blob: opensbi {
>   filename = "fw_dynamic.bin";
> + missing-msg = "opensbi";
>   };
>   };
>  
> diff --git a/tools/binman/missing-blob-help b/tools/binman/missing-blob-help
> index c61ca02a35..654ad642a3 100644
> --- a/tools/binman/missing-blob-help
> +++ b/tools/binman/missing-blob-help
> @@ -37,3 +37,7 @@ https://github.com/siemens/k3-rti-wdt.
>  tee-os:
>  See the documentation for your board. You may need to build Open Portable
>  Trusted Execution Environment (OP-TEE) with TEE=/path/to/tee.bin
> +
> +opensbi:
> +See the documentation for your board. The OpenSBI git repo is at
> +https://github.com/riscv/opensbi.git
Hi Rick,

Could we add something like
"build fw_dynamic.bin first and re-build u-boot with 
OPENSBI=/path/to/fw_dynamic.bin"

Other than that,
Reviewed-by: Leo Yu-Chi Liang 

> -- 
> 2.17.1
>

[PATCH] riscv: binman: Add help message for missing blobs

2023-02-15 Thread Rick Chen 
Add the 'missing-msg' for more detailed output
on missing system firmware.

Signed-off-by: Rick Chen 
---
 arch/riscv/dts/binman.dtsi | 1 +
 tools/binman/missing-blob-help | 4 
 2 files changed, 5 insertions(+)

diff --git a/arch/riscv/dts/binman.dtsi b/arch/riscv/dts/binman.dtsi
index b8fc8f7f35..156cb00971 100644
--- a/arch/riscv/dts/binman.dtsi
+++ b/arch/riscv/dts/binman.dtsi
@@ -45,6 +45,7 @@
 
opensbi_blob: opensbi {
filename = "fw_dynamic.bin";
+   missing-msg = "opensbi";
};
};
 
diff --git a/tools/binman/missing-blob-help b/tools/binman/missing-blob-help
index c61ca02a35..654ad642a3 100644
--- a/tools/binman/missing-blob-help
+++ b/tools/binman/missing-blob-help
@@ -37,3 +37,7 @@ https://github.com/siemens/k3-rti-wdt.
 tee-os:
 See the documentation for your board. You may need to build Open Portable
 Trusted Execution Environment (OP-TEE) with TEE=/path/to/tee.bin
+
+opensbi:
+See the documentation for your board. The OpenSBI git repo is at
+https://github.com/riscv/opensbi.git
-- 
2.17.1